| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- TextStyle class that specify the styles.
- Model owns TextStyle object. No need for client to manage
memory.
- It updates style list each time new item is added
and resolves overlap so that Paint method can simply
iterate and paint them.
- I changed selection so that it simply changes background of the selected text. This seems to be how webkit does and is much simpler.
URL decoration in omnibox
Renamed ClearCompositionText -> CancelCompositionText
No need to review changes to range. (http://codereview.chromium.org/7039051/)
BUG=none
TEST=added tests for textfield views.
Review URL: http://codereview.chromium.org/7047023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/84070
TEST=none
Review URL: http://codereview.chromium.org/7071017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/83663
TEST=none
Review URL: http://codereview.chromium.org/7068036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/83663
TEST=none
Review URL: http://codereview.chromium.org/7069022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- added ViewsDelegate::GetDispositionForEvent() pure virtual
- added MenuModelAdapter
- added unit test for MenuModelAdapter
- added comment for MenuModel::GetFirstItemIndex() that callers may pass NULL for NativeMenu argument
- fixed index offset bug in MenuModel::GetModelAndIndexForCommandId()
- fixed spurious call to MenuDelegate::IsCommandEnabled()
BUG=none
TEST=included
Review URL: http://codereview.chromium.org/7067032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=things still work
Review URL: http://codereview.chromium.org/6990028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Move NativeWidgetView to its own file.
- Enhances the example to contain a button.
http://crbug.com/83663
TEST=none
Review URL: http://codereview.chromium.org/7065042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to its parent NativeWidget.
http://crbug.com/83663
TEST=none
Review URL: http://codereview.chromium.org/6990048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ibus is not usable on lucid, so touchui build still needs to use ibus-gtk.
BUG=none
TEST=touchui compiles
TBR=hashimoto@chromium.org, oshima@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TouchUI)
Add switch "--enable-inputmethod-ibus" to enable InputMethodIBus on ChromeOS
Modify gyp files to link IBus
BUG=chromium-os:15566
TEST=manually
Review URL: http://codereview.chromium.org/7004029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We provided <(library) as a variable to support a peculiar
build configuration on Linux. We no longer support that build
configuration, so we can simplify this code to no longer use
a variable.
Review URL: http://codereview.chromium.org/7051014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and use_x11 for the gyp files. For lists of source files that use a mix of POSIX and Gtk APIs, toolkit_uses_gtk was given precedence. I also added Solaris to the remaining grit files.
Patch by ruben (chromium@hybridsource.org).
Review URL: http://codereview.chromium.org/7011032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/7048006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/7039050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=out/Debug/views_unittests --gtest_filter=NativeComboboxViewsTest.KeyTest
Review URL: http://codereview.chromium.org/6980007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the code in a couple of places.
BUG=none
TEST=none
R=ben@chromium.org,wjmaclean@chromium.org,rjkroege@chromium.org
Review URL: http://codereview.chromium.org/6999005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6980004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6910009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
following known missing items will be added in a separate CL
+ RTL handling
+ possible vertical centering of menu (UX)
+ Handle Key events for accessibility
+ Factor the focused border also present in textfield
+ look of the double arrow (now drawn in skia)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6880224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
method in a derived class was not marked as virtual.
Resubmitting change to fix a build break in the arm builder. The only change
from the original code is in text_button.cc, line 402, where text_x is
initialized to 0.
Add classes for native themed push buttons, radio buttons, and checkboxes.
These controls expose the same public interface and the existing controls
of the same type to make it easier to change between the implementations.
BUG=None
TEST=The new controls should look and feel like native platform controls
R=ben@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83373
Review URL: http://codereview.chromium.org/6853015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The only changefrom the original code is in text_button.cc, line 402, where text_x isinitialized to 0.Add classes for native themed push buttons, radio buttons, and checkboxes.These controls expose the same public interface and the existing controlsof the same type to make it easier to change between the implementations.BUG=NoneTEST=The new controls should look and feel like native platform controlsR=ben@chromium.orgReview URL: http://codereview.chromium.org/6853015
TBR=rogerta@chromium.org
Review URL: http://codereview.chromium.org/6902119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from the original code is in text_button.cc, line 402, where text_x is
initialized to 0.
Add classes for native themed push buttons, radio buttons, and checkboxes.
These controls expose the same public interface and the existing controls
of the same type to make it easier to change between the implementations.
BUG=None
TEST=The new controls should look and feel like native platform controls
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6853015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:80700
TEST=Test it on Linux desktop
Review URL: http://codereview.chromium.org/6904053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
and checkboxes.These controls expose the same public interface and the existing controlsof the same type to make it easier to change between the implementations.BUG=NoneTEST=The new controls should look and feel like native platform controlsR=ben@chromium.orgReview URL: http://codereview.chromium.org/6853015
TBR=rogerta@chromium.org
Review URL: http://codereview.chromium.org/6904040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These controls expose the same public interface and the existing controls
of the same type to make it easier to change between the implementations.
BUG=None
TEST=The new controls should look and feel like native platform controls
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6853015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=76996
TEST=none
Review URL: http://codereview.chromium.org/6894040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While I'm here, did some changes:
- Rename the LinkController interface to LinkListener.
- Move the interface to link_listener.h
- Rename the event from LinkActivated to LinkClicked.
- Changed the get/set accessors to listener()/set_listener().
- Add OVERRIDE to LinkClicked methods.
BUG=None
TEST=None
R=sky@chromium.org
Review URL: http://codereview.chromium.org/6881099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=compile with toolkit_views=1, run out/Debug/views_examples. You should see a link tab,
and a link with "Click me!" and make sure it works.
R=oshima@chromium.org,sky@chromium.org
Review URL: http://codereview.chromium.org/6883122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6880081
Patch from Emmanuel Saint-Loubert <saintlou@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=ben@chromium.org
TBR=ben@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6878085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6877065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- clang build requires destructor in complex classes
- chromeos build requires newline at end of files
Adding a native theme painter, to allow Views to use NativeTheme to draw
their background. Added example code to show it in use. I still have not
hooked this into any existing View-based controls.
BUG=None
TEST=None
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6820007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=rogerta
Review URL: http://codereview.chromium.org/6823011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
their background. Added example code to show it in use. I still have not
hooked this into any existing View-based controls.
This CL depends on changes currently being made to native theme, see
http://codereview.chromium.org/6728029/ for details.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6771056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL also fixes some issues related to NULL host_ pointer in the
original code. Hope the fixes are correct.
Another side effect of this CL is: it converts views::KeyEvent to NativeWebKeyboardEvent by using the conversion table of Views instead of WebInputEventFactory provided by WebKit. See bug 54315.
BUG=54315
BUG=75003
TEST=none
Review URL: http://codereview.chromium.org/6713083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds:
1. Interfaces: InputMethod, InputMethodDelegate, TextInputClient.
2. InputMethodGtk: an InputMethod implementation based on GtkIMContext.
3. MockInputMethod: a mock InputMethod implementation for unit tests.
BUG=75003
TEST=none
Review URL: http://codereview.chromium.org/6688049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
NativeMenuHost.
This is the first step, creating this structure. Will consolidate common functionality and state next.
BUG=72040
TEST=all menu tests for bookmark bar, wrench menu
Review URL: http://codereview.chromium.org/6740022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
compositor_gl.cc (in gfx) depends on app_base (for gl_bindings), but app_base depends on gfx. This gets rid of the cyclic dependency. It is part of the larger effort to move app/gfx/gl to ui/gfx/gl.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/6718034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=75003
TEST=views_unittests --gtest_filter=EventTest.*
Review URL: http://codereview.chromium.org/6713027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=views_examples, and existing views_unittests
R=sky@chromium.org
Review URL: http://codereview.chromium.org/6685039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=original unittests.
Review URL: http://codereview.chromium.org/6695021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move AccessibleViewState constructor into a .cc file.
Add dependency on ui/base to views_unittests so that
it actually compiles source files in ui/base.
Rename WindowDelegate::GetAccessibleState to
WindowDelegate::GetAccessibleWindowState so that it
doesn't conflict with View::GetAccessibleState in
BrowserView, which inherits from both. This was a real
bug, introduced recently because both GetAccessibleState
methods were renamed from previous non-conflicting
method names.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6691009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=74988
TEST=none
Review URL: http://codereview.chromium.org/6581010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=carnitas
TEST=compiles
Review URL: http://codereview.chromium.org/6612047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=existing unit_tests
Review URL: http://codereview.chromium.org/6628037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=71130
Review URL: http://codereview.chromium.org/6529025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
To fix circular dependencies between ui/base/ui_base.gyp and app/app.gyp I'm moving app_strings to ui/base/strings.
BUG=72317
TEST=Compiled on Mac, Linux, Windows.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To fix circular dependencies between ui/base/ui_base.gyp and app/app.gyp I'm moving app_strings to ui/base/strings.
BUG=72317
TEST=Compiled on Mac, Linux, Windows.
Review URL: http://codereview.chromium.org/6541035
TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/6623055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
To fix circular dependencies between ui/base/ui_base.gyp and app/app.gyp I'm moving app_strings to ui/base/strings.
BUG=72317
TEST=Compiled on Mac, Linux, Windows.
Review URL: http://codereview.chromium.org/6541035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create NativeWindow/NativeWindowDelegate interfaces.
BUG=72040
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/6626036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77006 0039d316-1c4b-4281-b951-d872f2087c98
|