summaryrefslogtreecommitdiffstats
path: root/views/widget/native_widget.h
Commit message (Collapse)AuthorAgeFilesLines
* Rename VIEWS_API to VIEWS_EXPORT.darin@chromium.org2011-08-051-1/+1
| | | | | | | R=rvargas@chromium.org Review URL: http://codereview.chromium.org/7550038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95651 0039d316-1c4b-4281-b951-d872f2087c98
* Create views.dll / libviews.sodarin@chromium.org2011-07-281-1/+1
| | | | | | | R=sky@chromium.org,rvargas@chromium.org Review URL: http://codereview.chromium.org/7493017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94428 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land:ben@chromium.org2011-06-161-180/+12
| | | | | | | | | | | | | | Move private NativeWidget methods to new internal interface NativeWidgetPrivate. This should make it harder to abuse accidentally. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7170019 Review URL: http://codereview.chromium.org/7189012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89357 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 89216 - Move private NativeWidget methods to new internal interface ↵ben@chromium.org2011-06-151-12/+180
| | | | | | | | | | | | | | | NativeWidgetPrivate. This should make it harder to abuse accidentally. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7170019 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/7097016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89232 0039d316-1c4b-4281-b951-d872f2087c98
* Move private NativeWidget methods to new internal interface NativeWidgetPrivate.ben@chromium.org2011-06-151-180/+12
| | | | | | | | | | This should make it harder to abuse accidentally. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7170019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89216 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate Window completely.ben@chromium.org2011-06-131-5/+1
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7108047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88905 0039d316-1c4b-4281-b951-d872f2087c98
* Move last of event handlers down to NativeWidgetWin/Gtk.ben@chromium.org2011-06-091-0/+3
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7129022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88564 0039d316-1c4b-4281-b951-d872f2087c98
* Move more from Window onto Widget.ben@chromium.org2011-06-081-3/+8
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7054052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88356 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land: Move NonClientView and FrameType logic from Window to Widget.ben@chromium.org2011-06-031-0/+8
| | | | | | | | | | Also fixes leak of default WidgetDelegate by replacing it with a DefaultWidgetDelegate subclass that overrides DeleteDelegate and deletes itself. This required moving the destruction logic from Window down onto Widget. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7033049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87784 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 87702 - Move NonClientView and FrameType logic from Window to Widget.ben@chromium.org2011-06-021-8/+0
| | | | | | | | | | | | | Also fixes leak of default WidgetDelegate by replacing it with a DefaultWidgetDelegate subclass that overrides DeleteDelegate and deletes itself. This required moving the destruction logic from Window down onto Widget. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7033049 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/7109028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87719 0039d316-1c4b-4281-b951-d872f2087c98
* Move NonClientView and FrameType logic from Window to Widget.ben@chromium.org2011-06-021-0/+8
| | | | | | | | | | Also fixes leak of default WidgetDelegate by replacing it with a DefaultWidgetDelegate subclass that overrides DeleteDelegate and deletes itself. This required moving the destruction logic from Window down onto Widget. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7033049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87702 0039d316-1c4b-4281-b951-d872f2087c98
* Move the last of the easy stuff from Window onto Widget.ben@chromium.org2011-06-011-0/+23
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7080060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87517 0039d316-1c4b-4281-b951-d872f2087c98
* Move Fullscreen API onto Widget.ben@chromium.org2011-06-011-0/+2
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7105003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87476 0039d316-1c4b-4281-b951-d872f2087c98
* Move SetWindowBounds onto Widget.ben@chromium.org2011-05-271-0/+2
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6976047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87073 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of functions from Window onto Widget.ben@chromium.org2011-05-271-2/+9
| | | | | | | | | BUG=72040 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86914 Review URL: http://codereview.chromium.org/7075019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87029 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 86914 - Move a bunch of functions from Window onto Widget.wtc@chromium.org2011-05-271-9/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Many tests in browser_tests crashed with a LOG(DFATAL) message on Chrome OS: [28862:28862:0526/153905:3290241082989:FATAL:browser_main.cc(955)] GLib-GObject: invalid (NULL) pointer instance Backtrace: base::debug::StackTrace::StackTrace() [0x33308d6] logging::LogMessage::~LogMessage() [0x334df2e] (anonymous namespace)::GLibLogHandler() [0x7c7d45] 0x2ab2a37a7fb9 0x2ab2a37a83d3 0x2ab2a313302a 0x2ab2a31315c5 views::NativeWidgetGtk::InitNativeWidget() [0x1a30dcf] views::Widget::Init() [0x1a37fa7] NativeTabContentsViewGtk::InitNativeTabContentsView() [0x10c6b83] TabContentsViewViews::CreateView() [0x397ac46] TabContents::TabContents() [0x1501e09] Browser::TabContentsFactory() [0xc84725] browser::Navigate() [0xc954c7] Browser::AddSelectedTabWithURL() [0xc76d9e] (anonymous namespace)::InitializeBrowser() [0x70be3d] InProcessBrowserTest::CreateBrowser() [0x70d178] InProcessBrowserTest::RunTestOnMainThreadLoop() [0x70d34a] [...snipped...] BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7075019 R=msw@chromium.org TBR=ben@chromium.org Review URL: http://codereview.chromium.org/6976040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86939 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of functions from Window onto Widget.ben@chromium.org2011-05-261-2/+9
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7075019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86914 0039d316-1c4b-4281-b951-d872f2087c98
* Add NativeWidgetViews. This is a stub implementation that mostly just defers ↵ben@chromium.org2011-05-241-0/+1
| | | | | | | | | | to its parent NativeWidget. http://crbug.com/83663 TEST=none Review URL: http://codereview.chromium.org/6990048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86488 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land:ben@chromium.org2011-05-131-0/+26
| | | | | | | | | | | | Split the hierarchy. Now with AutocompletePopup implementing SupportsWeakPtr as before. This fixes the Windows XP crashes in browser_tests. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7015051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85298 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 85269 - Split the hierarchy. ben@chromium.org2011-05-131-26/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Widget ---- Now recognizes a supplied NativeWidget via InitParams. If this is specified then a default one is not created. Is now created directly rather than using a factory. NativeWidget creation is not performed until Init() is called. This means some functions that rely on a NativeWidget must not be called until _AFTER_ Init() (explains some of the function call reordering in this CL, e.g. moving SetOpacity() until after Init()). ResetLastMouseMovedFlag() moved to this API so that BaseTabStrip can call it in a cross-platform way. Made last remaining unimplemented methods on Widget pass-thru to NativeWidget implementations. * WidgetWin/WidgetGtk ---- The NativeWidget implementations now both require a NativeWidgetDelegate implementation upon construction. This is passed through the constructor by the static factory method NativeWidget::CreateNativeWidget and by subclasses such as WindowWin, BubbleWidgetWin, etc. Some classes that are constructed directly (e.g. LockWindow, in ChromeOS) never have a Widget created for them, so they create the Widget themselves in their base class initializer. Code in these classes (and their WindowWin/WindowGtk, BrowserFrameWin, BrowserFrameGtk subclasses) must now call GetWidget() etc to call Widget API methods since they are no longer subclasses. static_casting to this (and derived) types must now be done on the Widget's native_widget(). GetWindow() is renamed to GetContainingWindow() to avoid naming conflicts. * Window ---- Window is now a subclass of Widget. Now recognizes a supplied NativeWindow via InitParams. If this is specified then a default one is not created. Window::CloseWindow becomes an override of Widget::Close. CloseAllSecondaryWindows() becomes CloseAllSecondaryWidgets() and moves to widget.h IsAppWindow() is removed and replaced by set_is_secondary_widget on Widget. * MenuHost ---- Subclasses Widget now. * TabContentsViewViews ---- It looks like the Gtk-views code here was still using the old implementation of the Native version of this class - i.e. a class that subclassed TabContentsView AND WidgetGtk. A no-no. I had to write NativeTabContentsViewGtk, which is almost identical to NativeTabContentsViewWin with the Gtk bits of TabContentsViewGtk thrown in. * BrowserFrame ---- Platform-specific functionality is now restricted to BrowserFrameWin/BrowserFrameGtk behind a NativeBrowserFrame interface. Construction is exposed via a static factory method on NativeBrowserFrame. BrowserFrame becomes a concrete class that now subclasses Window. As a result, it no longer needs a GetWindow() accessor method, so people with a BrowserFrame* can just call Window methods directly on it. It is constructed directly, replacing the BrowserFrame::Create() method. NativeBrowserFrameDelegate is no longer needed. BrowserFrameChromeos is simpler as a couple of #ifdefs in BrowserFrame, so I got rid of that too. * AutocompletePopupWin/Gtk ---- No longer required. AutocompletePopupContentsView now just uses a Widget directly. * There is some lingering ugliness: - If you set a native_window field on Window::InitParams you must also manually set widget_init_params.native_widget. I will make InitParams do more of this automatically later. - It'd be nice for the ContentsView to be specified via InitParams. I'll get to this later. - NativeBrowserFrame could probably disappear as an interface. It only exists to provide a couple of methods that may be implemented in other ways. - delete_on_destroy should now be an ownership directionality enum. I will do this later. - Secondary-widgetness should somehow be inferred from transience. Later. - set_focus_on_creation for both the NativeWidgets should probably move to Widget if it is really needed. - WidgetWin/Gtk::SetInitialFocus seems like it could move to Widget. - I need to clean up function order in some cases. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7012006 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/7011038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85283 0039d316-1c4b-4281-b951-d872f2087c98
* Split the hierarchy. ben@chromium.org2011-05-131-0/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Widget ---- Now recognizes a supplied NativeWidget via InitParams. If this is specified then a default one is not created. Is now created directly rather than using a factory. NativeWidget creation is not performed until Init() is called. This means some functions that rely on a NativeWidget must not be called until _AFTER_ Init() (explains some of the function call reordering in this CL, e.g. moving SetOpacity() until after Init()). ResetLastMouseMovedFlag() moved to this API so that BaseTabStrip can call it in a cross-platform way. Made last remaining unimplemented methods on Widget pass-thru to NativeWidget implementations. * WidgetWin/WidgetGtk ---- The NativeWidget implementations now both require a NativeWidgetDelegate implementation upon construction. This is passed through the constructor by the static factory method NativeWidget::CreateNativeWidget and by subclasses such as WindowWin, BubbleWidgetWin, etc. Some classes that are constructed directly (e.g. LockWindow, in ChromeOS) never have a Widget created for them, so they create the Widget themselves in their base class initializer. Code in these classes (and their WindowWin/WindowGtk, BrowserFrameWin, BrowserFrameGtk subclasses) must now call GetWidget() etc to call Widget API methods since they are no longer subclasses. static_casting to this (and derived) types must now be done on the Widget's native_widget(). GetWindow() is renamed to GetContainingWindow() to avoid naming conflicts. * Window ---- Window is now a subclass of Widget. Now recognizes a supplied NativeWindow via InitParams. If this is specified then a default one is not created. Window::CloseWindow becomes an override of Widget::Close. CloseAllSecondaryWindows() becomes CloseAllSecondaryWidgets() and moves to widget.h IsAppWindow() is removed and replaced by set_is_secondary_widget on Widget. * MenuHost ---- Subclasses Widget now. * TabContentsViewViews ---- It looks like the Gtk-views code here was still using the old implementation of the Native version of this class - i.e. a class that subclassed TabContentsView AND WidgetGtk. A no-no. I had to write NativeTabContentsViewGtk, which is almost identical to NativeTabContentsViewWin with the Gtk bits of TabContentsViewGtk thrown in. * BrowserFrame ---- Platform-specific functionality is now restricted to BrowserFrameWin/BrowserFrameGtk behind a NativeBrowserFrame interface. Construction is exposed via a static factory method on NativeBrowserFrame. BrowserFrame becomes a concrete class that now subclasses Window. As a result, it no longer needs a GetWindow() accessor method, so people with a BrowserFrame* can just call Window methods directly on it. It is constructed directly, replacing the BrowserFrame::Create() method. NativeBrowserFrameDelegate is no longer needed. BrowserFrameChromeos is simpler as a couple of #ifdefs in BrowserFrame, so I got rid of that too. * AutocompletePopupWin/Gtk ---- No longer required. AutocompletePopupContentsView now just uses a Widget directly. * There is some lingering ugliness: - If you set a native_window field on Window::InitParams you must also manually set widget_init_params.native_widget. I will make InitParams do more of this automatically later. - It'd be nice for the ContentsView to be specified via InitParams. I'll get to this later. - NativeBrowserFrame could probably disappear as an interface. It only exists to provide a couple of methods that may be implemented in other ways. - delete_on_destroy should now be an ownership directionality enum. I will do this later. - Secondary-widgetness should somehow be inferred from transience. Later. - set_focus_on_creation for both the NativeWidgets should probably move to Widget if it is really needed. - WidgetWin/Gtk::SetInitialFocus seems like it could move to Widget. - I need to clean up function order in some cases. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7012006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85269 0039d316-1c4b-4281-b951-d872f2087c98
* Rename CreateParams to InitParams.ben@chromium.org2011-04-261-1/+1
| | | | | | | | | http://crbug.com/72040 TEST=none TBR=sky Review URL: http://codereview.chromium.org/6901034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83057 0039d316-1c4b-4281-b951-d872f2087c98
* Rework the way Widget::Init works:ben@chromium.org2011-04-261-2/+2
| | | | | | | | | | | | | - Remove SetCreateParams from the public Widget API. - Add parent/bounds fields to CreateParams - Make Widget::Init be the canonical init method (vs. WidgetWin/Gtk Init) and have it take a CreateParams. - NativeWidget now has a InitNativeWidget method, which subclasses can override. Everyone must call Widget::Init via Widget* (not WidgetWin* as this will be ambiguous to WindowImpl::Init). BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6881107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83037 0039d316-1c4b-4281-b951-d872f2087c98
* Removes code added to track down crash. The crash seems to havesky@chromium.org2011-04-151-7/+0
| | | | | | | | | | | | | | | | | | | | occurred for two reasons: . window class name changing out from under us. . CreateWindow returning NULL because we're out of memory. I've changed the following: . Left in CHECK on return from CreateWindow. . Removed dependency on class name. We don't really need it anyway. I've also changed View::PaintFocusableBorder to check focusable last, as that requires looking up the FocusManager BUG=77651 TEST=none Review URL: http://codereview.chromium.org/6865023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81812 0039d316-1c4b-4281-b951-d872f2087c98
* Pull content from TabContentsViewViews into NativeTabContentsViewWin.ben@chromium.org2011-04-121-0/+1
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6824060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81328 0039d316-1c4b-4281-b951-d872f2087c98
* Adds more debugging code in hopes of figuring out a crash. Sorry forsky@chromium.org2011-04-081-0/+7
| | | | | | | | | | | | | | | | | needing to add so much plumbing here. We're not creating the FocusManager for BrowserView. I can only think that either we're not getting the create event, or we're getting the wrong parent widget. This should help us nail down which one is happening. BUG=77651 TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6820009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81012 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate cross platform logic into MenuHost.ben@chromium.org2011-04-011-1/+4
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6690054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80232 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate the new input method API for Views into Chromium.suzhe@google.com2011-04-011-0/+12
| | | | | | | | | | | | | | | | | | This CL contains following changes: 1. Improve TextfieldViewsModel to support composition text. 2. Implement TextInputClient interface in NativeTextfieldViews. 3. Fix Textfield and native implementations to avoid calling TextfieldController::ContentsChanged() when the text is changed by calling Textfield::SetText() or AppendText(). 4. Fix a bug in FocusManager that causes NativeTextfieldViewsTest.FocusTraversalTest to fail. 5. Fix accelerator_handler_touch.cc to send key events to the top-level widget's input method instance instead of the root view. 6. Do the same fix in extension_input_api.cc. 7. Hook InputMethod into WidgetGtk and WidgetWin. BUG=75003 TEST=views_unittests --gtest_filter=NativeTextfieldViews* Review URL: http://codereview.chromium.org/6675005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80226 0039d316-1c4b-4281-b951-d872f2087c98
* Notify child widgets before and after a reparenting.asanka@chromium.org2011-03-311-0/+5
| | | | | | | | | | | | | | | | Attaching a native view to a NativeViewHostWin may cause that view to be disassociated from a view hierarchy with a different FocusManager. Notifying the widgets that they are about to be removed from their current parent gives them the opportunity to disassociate themselves from their current FocusManager. BUG=77447 TEST=none Review URL: http://codereview.chromium.org/6776025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80096 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate Widget Event code, other cleanup.msw@chromium.org2011-03-311-3/+3
| | | | | | | | | | | | | Rename *NativeCapture to *MouseCapture. Rename and move ShouldReleaseCaptureOnMouseReleased. Move static flag function to Event. BUG=72040 TEST=Mouse interaction on win & linux_views. Review URL: http://codereview.chromium.org/6756043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80065 0039d316-1c4b-4281-b951-d872f2087c98
* Convert some WidgetWin construction to use CreateParams.ben@chromium.org2011-03-241-1/+1
| | | | | | | | | BUG=72040 TEST=none R=erg@chromium.org,estade@chromium.org Review URL: http://codereview.chromium.org/6719006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79279 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 79211 - Convert some WidgetWin construction to use CreateParams.ben@chromium.org2011-03-231-1/+1
| | | | | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6719006 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/6696053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79212 0039d316-1c4b-4281-b951-d872f2087c98
* Convert some WidgetWin construction to use CreateParams.ben@chromium.org2011-03-231-1/+1
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6719006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79211 0039d316-1c4b-4281-b951-d872f2087c98
* Re-lands:ben@chromium.org2011-03-161-0/+7
| | | | | | | | | | | | Add native capture API to Widget, and fix a bug in Window where we wouldn't let the window be closed from the X. BUG=72040 TEST=none R=sky Review URL: http://codereview.chromium.org/6670049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78394 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 78222 - Add native capture API to Widget, and fix a bug in Window ↵ben@chromium.org2011-03-151-7/+0
| | | | | | | | | | | | | | | where we wouldn't let the window be closed from the X. BUG=72040 TEST=none TBR=sky Review URL: http://codereview.chromium.org/6697016 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/6695028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78241 0039d316-1c4b-4281-b951-d872f2087c98
* Add native capture API to Widget, and fix a bug in Window where we wouldn't ↵ben@chromium.org2011-03-151-0/+7
| | | | | | | | | | | | let the window be closed from the X. BUG=72040 TEST=none TBR=sky Review URL: http://codereview.chromium.org/6697016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78222 0039d316-1c4b-4281-b951-d872f2087c98
* Start working on compositor tree painting.sadrul@chromium.org2011-03-151-0/+4
| | | | | | | | | | | | | As a first step, maintain a skia canvas in each transformed view. Each transformed view will acquire a texture-id for the canvas it owns. Whenever the canvas is updated, it will trigger a refresh in the compositor tree. BUG=none TEST=none Review URL: http://codereview.chromium.org/6594125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78149 0039d316-1c4b-4281-b951-d872f2087c98
* Build out NativeWindow interface for Window method pass-thrus.ben@chromium.org2011-03-101-0/+6
| | | | | | | | | | BUG=72040 TEST=none TBR=sky Review URL: http://codereview.chromium.org/6659035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77671 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate more into Window:ben@chromium.org2011-03-091-4/+4
| | | | | | | | | | | | - inactive rendering disabling tracking - window icon updating BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6650031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77497 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate window showing into Window base class.ben@chromium.org2011-03-091-0/+3
| | | | | | | | | | | NativeWindow gets methods to update accessible state, title, Center and Show. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6647004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77421 0039d316-1c4b-4281-b951-d872f2087c98
* Make more methods on Widget non-virtual and move to NativeWidgetben@chromium.org2011-03-041-0/+12
| | | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6623025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76997 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up more of Widget.ben@chromium.org2011-03-031-0/+11
| | | | | | | | | | | | - Move cross platform code to Widget. - Move platform-specific code into focused Widget* implementations. BUG=72040 TEST=existing Review URL: http://codereview.chromium.org/6609023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76790 0039d316-1c4b-4281-b951-d872f2087c98
* Replace Widget::GetBounds with Widget::GetClientScreenBounds and ↵ben@chromium.org2011-03-031-0/+18
| | | | | | | | | | | GetWindowScreenBounds BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6615016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76759 0039d316-1c4b-4281-b951-d872f2087c98
* Land the new functions added by 76483 - but do not use them anywhere outside ↵ben@chromium.org2011-03-021-2/+27
| | | | | | | | | | | | | of their tests. This will help me incrementally re-deploy these functions and identify what is causing the buildbot test redness. BUG=72040 TEST=none TBR=sky (all code originally reviewed here: http://codereview.chromium.org/6598069/ ) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76623 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting to fix builder redness. Please fix and reland.ananta@chromium.org2011-03-021-26/+2
| | | | | | | | | | | | | | Revert 76483 - Remove/replace RootView/Widget getters with new NativeWidget getters. BUG=72040 TEST=existing unittests. Review URL: http://codereview.chromium.org/6598069 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/6597099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76508 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting to fix builder redness. Please reland with the fixes.ananta@chromium.org2011-03-021-2/+1
| | | | | | | | | | | | | Revert 76485 - Move typedef per review comment. oops! BUG=none TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/6597098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76507 0039d316-1c4b-4281-b951-d872f2087c98
* Move typedef per review comment. oops!ben@chromium.org2011-03-021-1/+2
| | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76485 0039d316-1c4b-4281-b951-d872f2087c98
* Remove/replace RootView/Widget getters with new NativeWidget getters.ben@chromium.org2011-03-021-2/+26
| | | | | | | | | BUG=72040 TEST=existing unittests. Review URL: http://codereview.chromium.org/6598069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76483 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up empty interfaces for NativeWidget/NativeWidgetDelegate.ben@chromium.org2011-02-251-0/+26
| | | | | | | | | | | These will be filled out in subsequent changelists to isolate the communication between Widget and WidgetWin/Gtk. BUG=72040 TEST=existing Review URL: http://codereview.chromium.org/6596013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76100 0039d316-1c4b-4281-b951-d872f2087c98
* Remove NativeWidgetWin/WidgetImpl again. I'm going to take a different ↵ben@chromium.org2011-02-241-83/+0
| | | | | | | | | | | | | | approach to extracting this stuff. BUG=72040 TEST=none TBR=sky Review URL: http://codereview.chromium.org/6574043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75995 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-04 02:04:44 +0000