| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
The patch caused memory leak in views_unittests. added patch http://codereview.chromium.org/7858015/ to fix unittests memory leak.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7831071
Patch from Alice Tull <alicet@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7925017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 1de05c148460b26037b069501c19ee0c20aeb4ad.
TBR=backer@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7888049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also fixes rendering.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7889017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This moves WidgetFocusManager into its source/header files avoiding the use of nested classes.
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7885001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
LayerDelegate.
http://crbug.com/93947
TEST=none
Review URL: http://codereview.chromium.org/7845033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
If the root view is animating, or it's bounds do not fill the client area, compositing should clear first to clean up any ghosts.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7778045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
improve Pure Views for Chromium and ChromiumOS benefit independently of Touch. And therefore make the "use_only_pure_views" orthogonal so that it can be enabled with chromeos==0 or ==1 and/or with touchui==0.
The ultimate goal is to have toolkit_views <==> use_only_pure_views when all the GTK code has been removed from Views.
Note: as a side-effect this should reduce the need to use #ifdef TOUCH_UI which in many cases shall be replaced by USE_ONLY_PURE_VIEWS.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7780012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use TabContentsViewViews for RenderWidgetHostViweViews.
* Removed TabContentsViewTouch.
* Changed so that mouse and resize event goes through NativeWidgetViews so that NativeTabContentsViewViews can invoke NativeTabContentsViewDelegates.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100792
Review URL: http://codereview.chromium.org/7460001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit a8938434c75e2a7300e04c1f23fe363bdcb67bc6.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7878008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Removed TabContentsViewTouch.
* Changed so that mouse and resize event goes through NativeWidgetViews so that NativeTabContentsViewViews can invoke NativeTabContentsViewDelegates.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7460001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r100231 was: add bubble views files.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7720001
TBR=alicet@chromium.org
Review URL: http://codereview.chromium.org/7860025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7720001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes enable save and restore of minimized window state on Windows. (Mac and Linux came prior). The window state is now saved whenever size-changed notifications fire (in addition to the original activation and close cases).
BUG=43274
TEST=Manual. Launch Chrome on Windows, create two browser windows, minimize "a" window, quit. Relaunch, expect "a" to be minimized.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98679
Review URL: http://codereview.chromium.org/7748036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Windows
These changes enable save and restore of minimized window state on Windows. (Mac and Linux came prior). The window state is now saved whenever size-changed notifications fire (in addition to the original activation and close cases).
BUG=43274
TEST=Manual. Launch Chrome on Windows, create two browser windows, minimize "a" window, quit. Relaunch, expect "a" to be minimized.
Review URL: http://codereview.chromium.org/7748036
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/7790010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes enable save and restore of minimized window state on Windows. (Mac and Linux came prior). The window state is now saved whenever size-changed notifications fire (in addition to the original activation and close cases).
BUG=43274
TEST=Manual. Launch Chrome on Windows, create two browser windows, minimize "a" window, quit. Relaunch, expect "a" to be minimized.
Review URL: http://codereview.chromium.org/7748036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clicking keyboard (and any popup like menu) was activating the widget, which
hides VirtualKeyboard as it was stealing focus from browser window.
This also moves the code that handles window activation to WindowManaer.
Removed desktop_window_root_view.cc|h as it's no longer necesssary.
BUG=none
TEST=VirtualKeyboard on views desktop should work.
Review URL: http://codereview.chromium.org/7740039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
will do a patch after this so that it can be cleanly merged over.
TBR since it's just a revert.
BUG=91396
TEST=none
R=ben@chromium.org
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/7745049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/93944
TEST=none
Review URL: http://codereview.chromium.org/7744045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=penghaung@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7746005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
indicates FindPreference is returning NULL and we're in shutdown
because the last window is being closed. I suspect that for some
reason on some machines this triggers us to get a WM_CLOSE after we've
removed the property used to lookup the profile (removed in
WM_DESTROY) so that we fall back to the local state prefs which don't
have a property for window position and we crash. I'm adding debugging
code to determine whether that is in fact happening.
BUG=91396
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7727001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Create inputmethod only when it's requested via Widget::GetInputMethod. This is what original code did.
BUG=none
TEST=added WidgetTest::ChangeActivation
Review URL: http://codereview.chromium.org/7729007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
widget visibility changes.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7706023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none. no new functionality. all tests should pass.
Review URL: http://codereview.chromium.org/7371007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes TouchFrame's NonClientHitTest to ignore VirtualKeyboard area.
Move mouse capture logic to Window Manager so that nested
mouse capture with nested NWVs works correctly.
Note1: This is a tentative WM that allows us to move/resize window in views desktop until we have real window manager based on aura/layer API.
Note2: There is an compositor related issue and doesn't work well when compositor is enabled. I'll look into it after this CL.
Review URL: http://codereview.chromium.org/7530017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7655020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For reasonss that are not entirely clear, Browser::GetSavedMaximizedState() is sometimes setting maximized to true for panels created by an extension on ChromeOS.
Since panels have no concept of a maximized state, fix this by always returning 'false'.
This also includes a patch to widget.cc that is not necessary to fix this behavior, but it fixes the case where ShowInactive gets called when the widget is maximized (which shouldn't normally happen).
BUG=chromium-os:18534
TEST=See issue + test opening panels from an extension
Review URL: http://codereview.chromium.org/7551002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:17013
TEST=Open two windows on device, open wrench menu, use Alt-Tab to switch windows and check that menu closes.
Review URL: http://codereview.chromium.org/7484048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes issue where NativeTabbedPaneGtk gets retained by the top-level FocusManager during the Widget::Close tear-down sequence. This fix clears focus before proceeding with the tear-down. This avoids redundant operations with the FocusManger as views get deleted, specifically in the FocusManager::ViewRemoved() call.
Caught by Valgrind as a use after free violation:
sh tools/valgrind/chrome_tests.sh views --gtest_filter=FocusManagerTest.FocusNativeControls
BUG=89596
TEST=tools/valgrind/chrome_tests.sh views --gtest_filter=FocusManagerTest.FocusNativeControls
Review URL: http://codereview.chromium.org/7468037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=WidgetTest.GrabUngrab, and run views-desktop, click on a window the minize, click on the second window to minimize. Both should minize correctly.
Review URL: http://codereview.chromium.org/7432008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it. Previously if we were going to maximize the window we would first
create it at the restored size, then maximize it. On slower machines
this could result in a noticeable relayout of the web page.
BUG=11229
TEST=see bug.
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7358005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7398014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to remove it from all, but it's needed for the save. The reason I'm
doing this is I'm changing the calling order so that the delegate
won't know it's widget at the time GetSavedXXX is invoked. Turns out
we really only need the widget during the save calls anyway, so this
all still works.
BUG=none
TEST=none
R=ben@chromium.org,mirandac@chromium.org
Review URL: http://codereview.chromium.org/7377004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use Widget API to get FocusManager for native_view/window.
Move FocusNatieView to native widget impl.
This is necessary for NativeWidgetX
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7351008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create InputMethod object per Top level NativeWidgetView
- use MockInputMethod when IBUS is not available for now.
Call OnNativeWidgetActivationChanged when activation changed.
Handle InputFocus change when activation changed. This is temp solution until we have WM in place.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7353009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use this new observation technique to avoid a crash in views-desktop when the
active widget is closed.
BUG=none
TEST=Run views_desktop, close a window, click, it doesn't crash!
Review URL: http://codereview.chromium.org/7342015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gets mouse capture to work for menus with pure views. As part of this
I moved what was in menu_host_gtk into native_widget_gtk. Gtk supports
two grab types, both mouse and key. We only want key grab when showing
menus.
BUG=none
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/7354006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/7352001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
implementation.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7353007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of this
I moved what was in menu_host_gtk into native_widget_gtk. Gtk supports
two grab types, both mouse and key. We only want key grab when showing
menus.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7346003
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/7350008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I moved what was in menu_host_gtk into native_widget_gtk. Gtk supports
two grab types, both mouse and key. We only want key grab when showing
menus.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7346003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 92074 - Revert 92071 - Fix a chrome browser crash which occurs when displaying the page info bubble in a ChromeFrame page.
The crash occurs while dereferencing a NULL NonClientView member in the widget code. This member
is only instantiated if the widget is of type InitParams::TYPE_WINDOW.
ChromeFrame always instantiates as a popup window and hence this member is always NULL.
Fix is to add a NULL check at the relevant places in the widget code.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=88960
BUG=88960
Review URL: http://codereview.chromium.org/7301028
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/7258008
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/7340007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
page info bubble in a ChromeFrame page.
The crash occurs while dereferencing a NULL NonClientView member in the widget code. This member
is only instantiated if the widget is of type InitParams::TYPE_WINDOW.
ChromeFrame always instantiates as a popup window and hence this member is always NULL.
Fix is to add a NULL check at the relevant places in the widget code.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=88960
BUG=88960
Review URL: http://codereview.chromium.org/7301028
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/7258008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in a ChromeFrame page.
The crash occurs while dereferencing a NULL NonClientView member in the widget code. This member
is only instantiated if the widget is of type InitParams::TYPE_WINDOW.
ChromeFrame always instantiates as a popup window and hence this member is always NULL.
Fix is to add a NULL check at the relevant places in the widget code.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=88960
BUG=88960
Review URL: http://codereview.chromium.org/7301028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:85585
TEST=run views_examples
Review URL: http://codereview.chromium.org/7237064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CreateRenderWidgetHostView would delete the old RenderWidgetHostView.
Also fixes compile error in views_unittests.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7329027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
independent of any tfarina-induced bustage.
BUG=none
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/7313027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
level Window in the views desktop world.
Adds the beginning of a set of tests for this behavior.
Also fixes the leaks associated with destruction of NativeWidgetViews, and adds a moderately comprehensive set of tests for Widget ownership.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7273084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7280002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Basically having TOUCH_UI => pure-views exposed an issue when pure-views are enabled and deskop is not. Not that this last issue is fixed we can revert that workaround.
TBR=sky@chromium.org
BUG=none
TEST=TouchUi tests
Review URL: http://codereview.chromium.org/7294008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91203 0039d316-1c4b-4281-b951-d872f2087c98
|