summaryrefslogtreecommitdiffstats
path: root/views/widget
Commit message (Collapse)AuthorAgeFilesLines
* Reverting 27504, it breaks the interactive ui tests on Windows.jcampan@chromium.org2009-09-292-57/+1
| | | | | | | TBR=oshima Review URL: http://codereview.chromium.org/243034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27512 0039d316-1c4b-4281-b951-d872f2087c98
* See original review atjcampan@chromium.org2009-09-292-1/+57
| | | | | | | | | | | | | | http://codereview.chromium.org/251001/show This CL hooks the focus traversal for the TabbedPaneView on Linux with toolkit views. It also has few focus related fixed (focus with buttons, clearing focus effectively in the focus manager). BUG=None TEST=Run the view_examples app. Press tab to move the focus. Try the different tabs. Review URL: http://codereview.chromium.org/246030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27504 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding keyboard code refactoring:jcampan@chromium.org2009-09-292-4/+6
| | | | | | | | | | | | | | | | http://codereview.chromium.org/248010/show Changing the KeyboardEvent to use a KeyboardCode instead of a w_char. Led to several places where I had to switch from VK_ to VKEY_. Also cleaned-up the table view OnKeyDown method. Since TableView is a NativeControl it can use the NativeControl::OnKeyDown directly. BUG=None TEST=Make sure short-cuts works as expected, especially in the omnibox. Review URL: http://codereview.chromium.org/251020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27444 0039d316-1c4b-4281-b951-d872f2087c98
* Refactored event handler method bodies from widget_win.h tokbr@google.com2009-09-282-99/+203
| | | | | | | | | | | | widget_win.cc. This significantly reduces build times when modifying the code of these event handlers during debugging. BUG=http://code.google.com/p/chromium/issues/detail?id=23274 TEST=none Review URL: http://codereview.chromium.org/254003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27435 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27412 it breaks the toolkit views Linux build.jcampan@chromium.org2009-09-282-6/+4
| | | | | | | TBR=sky Review URL: http://codereview.chromium.org/254005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27416 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the KeyboardEvent to use a KeyboardCode instead of a w_char. Led to ↵jcampan@chromium.org2009-09-282-4/+6
| | | | | | | | | | | | several places where I had to switch from VK_ to VKEY_. Also cleaned-up the table view OnKeyDown method. Since TableView is a NativeControl it can use the NativeControl::OnKeyDown directly. BUG=None TEST=Make sure short-cuts works as expected, especially in the omnibox. Review URL: http://codereview.chromium.org/248010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27412 0039d316-1c4b-4281-b951-d872f2087c98
* [Relanding erg's change with fix for toolkit_views shortcuts and jcampan@chromium.org2009-09-251-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | interactive ui tests. Note that this was originally reviewed in http://codereview.chromium.org/217022/show I originally Elliot suggestion of replacing the usage of int for keycode with the bae::Keycode type, but that led to the CL getting out of hands (as this is used in many different places). So this is only the patch set 1 of that CL, I'll replace the type in another CL] Use windows keycodes under linux (and all non-windows platforms). This fixes any place where we use a VKEY_* (RenderWidgetHost, for example) under Linux, but breaks accelerators in TOOLKIT_VIEWS which relied on this wrong behaviour. Previously, keyboard_codes_linux defined all the VKEY_* constants as their GDK_* counterparts, which is wrong since the VKEY_* are supposed to resolve to windows key codes. BUG=22551 TEST=Make sure accelerators still work as expected on Chrome Linux and Chrome Linux with toolkit views. Test when the the accelerators with the focus in the location bar and also with the focus on the page. Review URL: http://codereview.chromium.org/235025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27284 0039d316-1c4b-4281-b951-d872f2087c98
* Implements file contents support in OSExchangeData and DropTargetsky@chromium.org2009-09-231-22/+26
| | | | | | | | | | | | | for gtk. Makes html and file contents support in OSExchangeData only for windows (as that is the only place we need it), and makes dragging files work. BUG=none TEST=none Review URL: http://codereview.chromium.org/232002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26995 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for a focus related NOTREACHED when closing Chromejcampan@chromium.org2009-09-231-4/+9
| | | | | | | | | | | | | | | | | A focus related asserion was hit when closing Chrome. It was caused by the top level widget being destroyed and deleting itself before its children. When deleted it would delete the focus manager without giving child widgets a chance to remove focus change listener causing the assert. We now delay the deletion of the WidgetGtk so child widget get the destroy message when the top WidgetGtk is still alive. BUG=None TEST=Close Chrome toolkit views. It should not assert because of the focus manager. Review URL: http://codereview.chromium.org/231003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26952 0039d316-1c4b-4281-b951-d872f2087c98
* Fix code to get widget position on screen.chocobo@google.com2009-09-221-12/+12
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/215053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26829 0039d316-1c4b-4281-b951-d872f2087c98
* Decolated window support in WidgetGtk. oshima@chromium.org2009-09-222-6/+11
| | | | | | | Will be used primarily for testing. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26778 0039d316-1c4b-4281-b951-d872f2087c98
* Fix BrowserFrameWin::OnMoving bad_override coverity error.mattm@chromium.org2009-09-181-1/+1
| | | | | | | | BUG=17104 Review URL: http://codereview.chromium.org/208019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26633 0039d316-1c4b-4281-b951-d872f2087c98
* The focus is not restored properly when a Windows modal dialogjcampan@chromium.org2009-09-142-1/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (such as "open file', 'print'...) is closed. We are running these dialogs from a different thread and they cause the browser window to get activated before it has been enabled. This causes the focus restoration to fail as the window is not enabled. In an earlier patch, I fixed it by storing/restoring the focus explicitly before/after the dialog is shown. But the fix did not apply to the print dialog which does not use the code I added my fix in. This CL reverts that previous fix and comes with a simpler solution: if when we are about to restore focus the window is disabled, we delay the focus restoration untill the window is enabled again. BUG=3380 TEST=Set the focus on a page with scroll-bars, right-click to do a 'save as'. Close the dialog. The arrow keys should let you scroll the page. Accelerators such as Ctrl-T should still work. Test 'open a file', 'print' and the font selection dialog (in the options). When closing the dialog the focus should return to the view that last had focus. Review URL: http://codereview.chromium.org/199106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26135 0039d316-1c4b-4281-b951-d872f2087c98
* Landing oshima patch.jcampan@chromium.org2009-09-101-0/+5
| | | | | | | | | | | Disable NOTREACHED assertion for Linux. A view in WidgetGtk with TYPE_CHILD crashes at this assertion. A bug http://crbug.com/21335 is filed to keep track of this. BUG=None TEST=None Review URL: http://codereview.chromium.org/195056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25919 0039d316-1c4b-4281-b951-d872f2087c98
* Use Scoped[Bstr,ComPtr,Variant] instead of their ATL equivalents to reduce ↵jhawkins@chromium.org2009-09-102-2/+3
| | | | | | | | | | dependencies on ATL. BUG=5027 TEST=none Review URL: http://codereview.chromium.org/200045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25879 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at implementation of FindBar for views / gtkdavemoore@chromium.org2009-09-092-6/+14
| | | | | | | Also had to implement change notification for TextField on views / gtk Review URL: http://codereview.chromium.org/200035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25819 0039d316-1c4b-4281-b951-d872f2087c98
* Use gfx::Point instead of GET_X/Y_LPARAM to reduce a dependency on ATL.jhawkins@chromium.org2009-09-091-8/+6
| | | | | | | | BUG=5027 TEST=none Review URL: http://codereview.chromium.org/195035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25788 0039d316-1c4b-4281-b951-d872f2087c98
* Fleshes out the tooltip implementation for views on Gtk. It doesn'tsky@chromium.org2009-09-088-103/+329
| | | | | | | | | | | | support explicit positioning of the tooltip as windows does. That'll have to be added later. BUG=none TEST=make sure tooltips still work correctly on windows Review URL: http://codereview.chromium.org/197031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25635 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in views on gtk where we wouldn't necessarily paintsky@chromium.org2009-09-081-5/+13
| | | | | | | | | | | | | | | correctly on an expose. This happened if between the time we told Gtk we needed to paint and the time we got the expose event more paints were scheduled. In this case, because we were double buffered, GTK would clip to the original region we scheduled the paint for. The fix is to turn off double buffering as we're double buffering ourself. BUG=none TEST=none Review URL: http://codereview.chromium.org/198036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25621 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some gcc 4.4 issues when compiling with toolkit_views.craig.schlenter@chromium.org2009-09-071-1/+1
| | | | | | | | | | | | | | | | | | | | | Most of these squash harmless compiler warnings but the custom_button.cc change fixes a real problem with the accelerator key bitmask calculation (+ preceeds << in terms of operator precedence) The change to tab_strip.cc is ugly but it fixes the following error: chrome/browser/views/tabs/tab_strip.cc: In member function ‘void TabStrip::StartRemoveTabAnimation(int, TabContents*)’: chrome/browser/views/tabs/tab_strip.cc:201: error: assuming signed overflow does not occur when assuming that (X - c) > X is always false As an added bonus, this makes the Linux shared build of toolkit_views work too. Review URL: http://codereview.chromium.org/199025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25602 0039d316-1c4b-4281-b951-d872f2087c98
* A couple comment changes -- update an out of date comment and add a note ↵pkasting@chromium.org2009-09-032-2/+7
| | | | | | | | | | about some awful behavior that dates back to the earliest days. BUG=none TEST=none Review URL: http://codereview.chromium.org/185002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25338 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/172098 for Oshima:sky@chromium.org2009-09-021-1/+1
| | | | | | | | | | | | * fix typo in WidgetGtk * re-organize method in combobox for chrome convention BUG=none TEST=none Review URL: http://codereview.chromium.org/188009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25186 0039d316-1c4b-4281-b951-d872f2087c98
* The FocusManager stores/restores focus when the top window becomes ↵jcampan@chromium.org2009-09-013-15/+24
| | | | | | | | | | | | inactive/active. BUG=None TEST=Run the focus manager unit-tests. Review URL: http://codereview.chromium.org/164448 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25108 0039d316-1c4b-4281-b951-d872f2087c98
* Porting textfield to toolkit_views Gtk.jcampan@chromium.org2009-09-012-11/+3
| | | | | | | | | | | BUG=None TEST=Run the view unit-tests. See original review: http://codereview.chromium.org/165512/show Review URL: http://codereview.chromium.org/180061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25063 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where the tooltip would not be erased if it had been non-empty and ↵pkasting@chromium.org2009-08-311-4/+4
| | | | | | | | | | then was updated to be empty. BUG=none TEST=Start Chrome, type a letter in the omnibox, hover the Go button and wait for the tooltip. Then delete the character and move the mouse pointer a tiny bit. The tooltip should disappear. Review URL: http://codereview.chromium.org/175032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24918 0039d316-1c4b-4281-b951-d872f2087c98
* Make the views bookmark bubble work on GTK.brettw@chromium.org2009-08-281-1/+1
| | | | | | | | | | | The combobox still isn't implemented, but this makes TextBox work, and also does some changes around the info_bubble to make sure it get created properly. TEST=none BUG=none. Review URL: http://codereview.chromium.org/177026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24821 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for initiating drags from bookmark menus.sky@chromium.org2009-08-285-14/+148
| | | | | | | | | BUG=none TEST=make sure bookmark menus work on Windows. Review URL: http://codereview.chromium.org/176006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24801 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at landing bookmark menus.sky@chromium.org2009-08-261-1/+4
| | | | | | | | | | | | | The build breakage was the result of a bad ifdef in MenuController, specifically around the OnKeyDown method. BUG=none TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/173517 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24526 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts menu patch.sky@chromium.org2009-08-261-4/+1
| | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/173508 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24509 0039d316-1c4b-4281-b951-d872f2087c98
* Gets bookmark menu working on linux. There are just a handful ofsky@chromium.org2009-08-261-1/+4
| | | | | | | | | | | | NOTIMPLEMENTEDs to resolve (initiating drags is the biggest remaining issue). I'll tackle the remaining issues separately. BUG=none TEST=make sure bookmark menus work well on windows still. Review URL: http://codereview.chromium.org/173431 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24501 0039d316-1c4b-4281-b951-d872f2087c98
* Further refactoring of menus for GTK. I've now separated outsky@chromium.org2009-08-242-8/+24
| | | | | | | | | | | | | | | | | everything and menus some what work on GTK. I need to get painting working and I'm sure there will be fine tuning, but I want to check in all this splitting of files before someone else needs change one of these files. Thankfully I wrote an interactive ui test that exercises much of this code, and it still passes:) BUG=none TEST=thoroughly test bookmark menus on windows to make sure I didn't break them. Review URL: http://codereview.chromium.org/174274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24098 0039d316-1c4b-4281-b951-d872f2087c98
* Relands drop support:sky@chromium.org2009-08-195-12/+655
| | | | | | | | | | | | Adds drop support for views on gtk. As X lazily provides drop data I needed to tweak the views API a bit. BUG=none TEST=none Review URL: http://codereview.chromium.org/173025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23690 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23645.jhawkins@chromium.org2009-08-182-6/+10
| | | | | | | Crashing the reliability bot. Review URL: http://codereview.chromium.org/174029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23674 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts recent patch as broke build on toolkit_views.sky@chromium.org2009-08-185-655/+12
| | | | | | | | | TBR=ben BUG=none TEST=none Review URL: http://codereview.chromium.org/174023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23658 0039d316-1c4b-4281-b951-d872f2087c98
* Adds drop support for views on gtk. As X lazily provides drop data Isky@chromium.org2009-08-185-12/+655
| | | | | | | | | | | needed to tweak the views API a bit. BUG=none TEST=none Review URL: http://codereview.chromium.org/165407 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23653 0039d316-1c4b-4281-b951-d872f2087c98
* Make NativeControl inherit from base::WindowImpl instead of CWindowImpl to ↵jhawkins@chromium.org2009-08-182-10/+6
| | | | | | | | | | reduce a dependency on ATL. BUG=5027 TEST=none Review URL: http://codereview.chromium.org/169015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23645 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Reverting 23406" as it didn't break any tests.jhawkins@chromium.org2009-08-141-33/+33
| | | | | | | | | | | | | | Change PluginInstallImpl to use base::WindowImpl instead of CWindowImpl to reduce a dependency on ATL. BUG=5023 TEST=Uninstall flash. Visit hulu.com and install the flash plugin. Original review: http://codereview.chromium.org/165469 TBR=levin Review URL: http://codereview.chromium.org/165543 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23454 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23406.levin@chromium.org2009-08-141-33/+33
| | | | | | | | | | | | It seems that Tab2OutOfTabStrip is failing consistently after this change. BUG=None TEST=None TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/164543 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23411 0039d316-1c4b-4281-b951-d872f2087c98
* Change PluginInstallImpl to use base::WindowImpl instead of CWindowImpl to ↵jhawkins@chromium.org2009-08-141-33/+33
| | | | | | | | | | reduce a dependency on ATL. BUG=5023 TEST=Uninstall flash. Visit hulu.com and install the flash plugin. Review URL: http://codereview.chromium.org/165469 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23406 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors OSExchangeData for easier portability.sky@chromium.org2009-08-121-3/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/164401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23230 0039d316-1c4b-4281-b951-d872f2087c98
* Implements WidgetGtk::SetOpacity.sky@chromium.org2009-08-122-3/+13
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/164346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23169 0039d316-1c4b-4281-b951-d872f2087c98
* Removes bogus comments in WidgetGtk::GetBounds.sky@chromium.org2009-08-111-9/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/165306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23062 0039d316-1c4b-4281-b951-d872f2087c98
* Removes calls to RootView methods that were removed.sky@chromium.org2009-08-111-3/+0
| | | | | | | | | BUG=none TEST=none TBR=jcampan Review URL: http://codereview.chromium.org/164320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23022 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors RootViewDropTarget into a platform independent part,sky@chromium.org2009-08-1114-239/+382
| | | | | | | | | | | | | | DropHelper, and the platform specific part DropTarget. I've also moved ownership/creation of the DropTarget to Widget. This makes it alot easier for the windows side, in which DropTarget must implement IDataObject. BUG=none TEST=none Review URL: http://codereview.chromium.org/165155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23020 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out window creation into base::WindowImpl. This class will be used ↵jhawkins@chromium.org2009-08-072-238/+47
| | | | | | | | | | in place of CWindowImpl to reduce our dependency on ATL. BUG=none TEST=none Review URL: http://codereview.chromium.org/165022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22787 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a BAD_OVERRIDE defect reported by Coverity. Change thewtc@chromium.org2009-08-061-1/+1
| | | | | | | | | | | | | prototype of the GetDefaultThemeProvider method in the base class to match the prototypes of the GetDefaultThemeProvider methods in the subclasses BrowserFrameWin and BrowserFrameGtk. R=glen BUG=17104 TEST=none Review URL: http://codereview.chromium.org/159479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22568 0039d316-1c4b-4281-b951-d872f2087c98
* Make the DOMUIThemeSource load and pass through a PNG, rather than relying ↵glen@chromium.org2009-08-051-0/+3
| | | | | | | | | | | on decode/encode. BUG=18427 TEST=Install a giant theme, load the NNTP, verify that you can type in the omnibox without delay while the page is loading. Review URL: http://codereview.chromium.org/159891 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22457 0039d316-1c4b-4281-b951-d872f2087c98
* Status bubble limping in TOOLKIT_VIEWS.ben@chromium.org2009-08-017-108/+131
| | | | | | | | | | | Add CreateTransparentFloatingWidget method to Widget and add Init/SetContentsView methods. BUG=none TEST=none Review URL: http://codereview.chromium.org/160474 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22229 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds accelerators to the Linux toolkit views.jcampan@chromium.org2009-07-314-76/+23
| | | | | | | | | | | The MessageLoop had to be modified to support Dispatchers on Linux. BUG=None TEST=On Windows and Linux, make sure the accelerators still work as expected. On Linux toolkit views, build and run the unit-tests. Review URL: http://codereview.chromium.org/159046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22210 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Omnibox cursor flicker by deleting a bunch of useless code in WindowWin.pkasting@chromium.org2009-07-241-5/+0
| | | | | | | | | | I tested running the app in Vista non-Aero, and I still got resize cursors on all edges and was able to resize the window. BUG=13926 TEST=Mouse around on the omnibox; the cursor should not flicker. Review URL: http://codereview.chromium.org/159245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21485 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 10:14:00 +0000