| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles, run manually
Review URL: http://codereview.chromium.org/6975051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/7129022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
by ChromeOS' window manager.
BUG=chromium-os:16323
TEST=none
Review URL: http://codereview.chromium.org/7129033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Tests will be re-enabled when appropriate changes are made to support GL compositor testing.
BUG=unit tests not ready for GL compositor at this time.
TEST=unit tests run to completion.
Review URL: http://codereview.chromium.org/7104039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
All of the changes in this CL are to shut up the warning, not because of real problems (I fixed these in separate CLs).
See the bug for a disussion of this change.
BUG=84424
TEST=none
Review URL: http://codereview.chromium.org/6995085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/7054052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Wait showing html dialog until renderre finish painting after page is loaded.
This change keeps track of state transition to make sure we only show the window on the paint after page load.
minor change; use gdk's debug paint. Views no longer manage the damaged rect by itself so we can simply use gdk's debug paint.
Note to mazda. Please consider adding fade-in animation. I believe it will make it much nicer.
BUG=chromium-os:15809
TEST=open keyboard overlay on device. no white flicker should be observed.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88271
Review URL: http://codereview.chromium.org/7024032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/chromeos/login/screen_locker.cc:225:16:error: 'ClearNativeFocus' marked 'override' but does not override any member functions
virtual void ClearNativeFocus() OVERRIDE {
^
CXX(target) out/Debug/obj.target/browser/chrome/browser/chromeos/login/take_photo_view.o
1 error generated.
Looks like a real bug in the CL.
88271 - Wait showing html dialog until renderre finish painting after page is loaded.
This change keeps track of state transition to make sure we only show the window on the paint after page load.
minor change; use gdk's debug paint. Views no longer manage the damaged rect by itself so we can simply use gdk's debug paint.
Note to mazda. Please consider adding fade-in animation. I believe it will make it much nicer.
BUG=chromium-os:15809
TEST=open keyboard overlay on device. no white flicker should be observed.
Review URL: http://codereview.chromium.org/7024032
TBR=oshima@google.com
Review URL: http://codereview.chromium.org/6995067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change keeps track of state transition to make sure we only show the window on the paint after page load.
minor change; use gdk's debug paint. Views no longer manage the damaged rect by itself so we can simply use gdk's debug paint.
Note to mazda. Please consider adding fade-in animation. I believe it will make it much nicer.
BUG=chromium-os:15809
TEST=open keyboard overlay on device. no white flicker should be observed.
Review URL: http://codereview.chromium.org/7024032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
been changed.
BUG=none
TEST=Manual test for now. Will add test coverage when I add test for PanelManager.
Review URL: http://codereview.chromium.org/7076036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/7058019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
notification appears
BUG=84529
TEST=Manual test by verifying the browser does not lose focus
Review URL: http://codereview.chromium.org/7024010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also fixes leak of default WidgetDelegate by replacing it with a DefaultWidgetDelegate subclass that overrides DeleteDelegate and deletes itself. This required moving the destruction logic from Window down onto Widget.
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/7033049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fixes leak of default WidgetDelegate by replacing it with a DefaultWidgetDelegate subclass that overrides DeleteDelegate and deletes itself. This required moving the destruction logic from Window down onto Widget.
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/7033049
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/7109028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also fixes leak of default WidgetDelegate by replacing it with a DefaultWidgetDelegate subclass that overrides DeleteDelegate and deletes itself. This required moving the destruction logic from Window down onto Widget.
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/7033049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Widget will make a default one.
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/7080068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/7080060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:15129
TEST=tests
Review URL: http://codereview.chromium.org/7105017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/7105003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/7078008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a revert of http://codereview.chromium.org/6932034.
It is no longer needed after NativeWidgetGtk deletes itself immediately, not using DeleteSoon(): crosbug.com/15129.
BUG=chromium-os:14885
TEST=Sign in as a new user, sign out works fine.
Review URL: http://codereview.chromium.org/7054039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a retry of http://codereview.chromium.org/7002029/ after it has been reverted because of the failing test BrowserTest.CloseWithAppMenuOpen (failed only on buildbot)
BUG=chromium-os:15129
TEST=tests
Review URL: http://codereview.chromium.org/7082042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6976047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86914
Review URL: http://codereview.chromium.org/7075019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many tests in browser_tests crashed with a LOG(DFATAL) message on Chrome OS:
[28862:28862:0526/153905:3290241082989:FATAL:browser_main.cc(955)] GLib-GObject: invalid (NULL) pointer instance
Backtrace:
base::debug::StackTrace::StackTrace() [0x33308d6]
logging::LogMessage::~LogMessage() [0x334df2e]
(anonymous namespace)::GLibLogHandler() [0x7c7d45]
0x2ab2a37a7fb9
0x2ab2a37a83d3
0x2ab2a313302a
0x2ab2a31315c5
views::NativeWidgetGtk::InitNativeWidget() [0x1a30dcf]
views::Widget::Init() [0x1a37fa7]
NativeTabContentsViewGtk::InitNativeTabContentsView() [0x10c6b83]
TabContentsViewViews::CreateView() [0x397ac46]
TabContents::TabContents() [0x1501e09]
Browser::TabContentsFactory() [0xc84725]
browser::Navigate() [0xc954c7]
Browser::AddSelectedTabWithURL() [0xc76d9e]
(anonymous namespace)::InitializeBrowser() [0x70be3d]
InProcessBrowserTest::CreateBrowser() [0x70d178]
InProcessBrowserTest::RunTestOnMainThreadLoop() [0x70d34a]
[...snipped...]
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/7075019
R=msw@chromium.org
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/6976040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/7075019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/84070
TEST=none
Review URL: http://codereview.chromium.org/7071017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of PlatformDevice within Chrome. The Skia library now provides multiple back-ends for the SkDevice class, so PlatformDevice's inheritance of SkDevice, and the assumption of instances of PlatformDevice limits the use of these new back-ends.
A new set of helper functions is provided for the PlatformDevice entry points. Upon construction of a PlatformDevice, a pointer to the interface is cached in the parent SkDevice's SkMetaData. The new helper functions forward calls to the interface cached in the metadata.
BUG=NONE
TEST=NONE
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86625
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=86625
Review URL: http://codereview.chromium.org/7019013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
wrong.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6992086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/83663
TEST=none
Review URL: http://codereview.chromium.org/7069022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/7031053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the dependency of PlatformDevice within Chrome. The Skia library now provides multiple back-ends for the SkDevice class, so PlatformDevice's inheritance of SkDevice, and the assumption of instances of PlatformDevice limits the use of these new back-ends.
A new set of helper functions is provided for the PlatformDevice entry points. Upon construction of a PlatformDevice, a pointer to the interface is cached in the parent SkDevice's SkMetaData. The new helper functions forward calls to the interface cached in the metadata.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/7019013
TBR=twiz@chromium.org
Review URL: http://codereview.chromium.org/6987019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
of PlatformDevice within Chrome. The Skia library now provides multiple back-ends for the SkDevice class, so PlatformDevice's inheritance of SkDevice, and the assumption of instances of PlatformDevice limits the use of these new back-ends.
A new set of helper functions is provided for the PlatformDevice entry points. Upon construction of a PlatformDevice, a pointer to the interface is cached in the parent SkDevice's SkMetaData. The new helper functions forward calls to the interface cached in the metadata.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/7019013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Move NativeWidgetView to its own file.
- Enhances the example to contain a button.
http://crbug.com/83663
TEST=none
Review URL: http://codereview.chromium.org/7065042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is just a prototype for us to play with. There are plenty of issues to
resolve before its made real, but I wanted to check something in for
others to play with rather than keeping it all local. To get it to
compile you need to set the GYP_DEFINE to views_compositor.
BUG=none
TEST=none
R=ben@chromium.org,apatrick@chromium.org
Review URL: http://codereview.chromium.org/7067029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to its parent NativeWidget.
http://crbug.com/83663
TEST=none
Review URL: http://codereview.chromium.org/6990048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6992027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ibus is not usable on lucid, so touchui build still needs to use ibus-gtk.
BUG=none
TEST=touchui compiles
TBR=hashimoto@chromium.org, oshima@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TouchUI)
Add switch "--enable-inputmethod-ibus" to enable InputMethodIBus on ChromeOS
Modify gyp files to link IBus
BUG=chromium-os:15566
TEST=manually
Review URL: http://codereview.chromium.org/7004029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
hidden tab host window isn't necessary... it was previously. Anyway, this fixes the flashing.
BUG=chromium-os:15507
TEST=see bug
Review URL: http://codereview.chromium.org/7059017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles with touchui
Review URL: http://codereview.chromium.org/6961020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Most people should not be using the RootView type. The few cases that do should static_cast for now, until I can find a way to expose the functionality they need on Widget.
BUG=72040
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/7040018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/7048006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/7039050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
code since I have found no way to avoid using it.
BUG=79640
TEST=see bug
Review URL: http://codereview.chromium.org/7038021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Consolidate ShouldUseNativeFrame/AlwaysUseNativeFrame/UseNativeFrame spaghetti. See earlier commit in log for full description.
THIS WILL BREAK chrome_frame_tests!
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7036011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I plan to use SystemMonitor in net/.
Fix up the Mac implementation not to use Cocoa APIs since @interface is not allowed in base.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85732
Review URL: http://codereview.chromium.org/7015017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I plan to use SystemMonitor in net/.
Fix up the Mac implementation not to use Cocoa APIs since @interface is not allowed in base.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7015017
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/7042003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85734 0039d316-1c4b-4281-b951-d872f2087c98
|