| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110949
Review URL: http://codereview.chromium.org/8598031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is largely a port of the existing X window manager's
code for drawing shadows around windows. It adds an
ImageGrid class for drawing a scaled 3x3 grid of gfx::Images
and a Shadow class (managed by aura_shell::ShadowController)
that uses ImageGrid to draw a shadow. Shadows can be
disabled via --aura-no-shadows.
BUG=101977
TEST=added unit tests; also manually checked that shadows get drawn
Review URL: http://codereview.chromium.org/8555025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8562003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8598031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WidgetOwnershipTest.Ownership_ViewsNativeWidgetOwnsWidget
WidgetOwnershipTest.Ownership_ViewsNativeWidgetOwnsWidget_NativeDestroy
TBR=ben@chromium.org
BUG=104945
TEST=views_unittests passed
Review URL: http://codereview.chromium.org/8547006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
based classes that are obsoleted by Aura. Also remove a bunch of Wayland stuff, since any future Wayland integration is likely done as an implementation detail of Aura, not Views.
Specifically:
- views-desktop (classes and NativeWidgetView[s])
- NativeWidgetViews subclasses in Chrome (Constrained Windows, NTCVV, NTCCV, BrowserFrameViews et al).
- RWHVV, NWKEV
- NativeViewHostViews
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8598024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8566052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fix HtmlDialogBrowserTest.SizeWindow for Linux + Aura + Chromeos==0.
- Remove minimum_size_ from auralWindow and add an OnBoundsChanging to aura::WindowDelegate so that a delegate can apply bounds constriant;
- NativeWidgetAura uses OnBoundsChanging to apply Widget's minimum size;
- Remove minimum_size_ member from Widget because it is only used for widget with no frame (i.e. no non_client_view_) and such widget should have no minimum size;
BUG=104412
TEST=Verify the HtmlDialogBrowserTest.SizeWindow should pass for Linux + Aura + Chromeos==0.
Review URL: http://codereview.chromium.org/8574049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Aura doesn't support minimized window.
BUG=104571
TEST=none
Review URL: http://codereview.chromium.org/8585014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetRestoredBounds should Return normal bounds if window is normal mode.
BUG=103490
TEST=none
Review URL: http://codereview.chromium.org/8468029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=97845
TEST=none
Review URL: http://codereview.chromium.org/8450018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8570011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8581003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Switching to fullscreen on aura is synchronous. Use the same path as windows.
* Use dispatcher to run all pending in in_process_browser_tests.
* Check if the window is already destroyed in NatveWidgetAura::Hide
BUG=103485
TEST=following tests should pass with this patch on aura: BrowserTest.TestFullscreenBubbleMouseLockState
BrowserTest.TestNewTabExitsFullscreen
BrowserTest.TestTabExitsItselfFromFullscreen
Review URL: http://codereview.chromium.org/8571026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/93936
TEST=none yet
Review URL: http://codereview.chromium.org/8574033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8568022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a workaround for crbug.com/93530; caused by crrev.com/84823.
Windows creates a WM_PAINT storm without validation; even on empty regions.
BUG=93530
TEST=Issue does not repro; no regressions.
Review URL: http://codereview.chromium.org/8568016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed to fix some issues in tests exposed by the WebKit compositor. The
problem is that sometimes during the teardown paths, some layers have stale a
pointer to the compositor that has already been destroyed. The WebKit layer
(rightfully) calls ScheduleDraw when the layer hierarchy is changed, exposing
the issue.
We now always walk back to the root layer to find the compositor, and reset the
pointer when the compositor's root changes (or it gets destroyed).
BUG=99524
TEST=views_unittest, aura_unittest, compositor_unittests with (and without) use_webkit_compositor=1
Review URL: http://codereview.chromium.org/8510076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8524020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8536004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=97256,102582
TEST=AlwaysOnTop related tests in ShellTest should pass.
Review URL: http://codereview.chromium.org/8387043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes the use_wayland build which was broken by this commit:
http://codereview.chromium.org/8113028
Similar to win, we create a wayland namespace inside base
and define WaylandEvent there.
Historical note:
Wayland does not have a "native" event structure. Instead, the client
is made aware of events via a callback executed in the context
of display_run():
http://git.chromium.org/gitweb/?p=chromiumos/third_party/wayland-demos.git;a=blob;f=clients/window.c
So we create WaylandEvent structure which takes the parameters from
the callback and wraps them into a structure. For details, see:
src/ui/wayland/events/wayland_event.h
BUG=chromium:102903
TEST=Compiles but doesn't yet link with this change plus a series of
others I'm working on.
R=msw@chromium.org,oshima@chromium.org,mark@chromium.org
Review URL: http://codereview.chromium.org/8378005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8533010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104039
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8497067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first preliminary change for the support of global keyboard shortcut.
BUG=97255
TEST=None
Review URL: http://codereview.chromium.org/8508055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=103827
TEST=compiles on clang without warnings and passes tests
Review URL: http://codereview.chromium.org/8536036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes a NOTIMPLEMENTED() in
views::NativeWidgetPrivate::IsMouseButtonDown().
BUG=102577
TEST=added
Review URL: http://codereview.chromium.org/8526020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
visible. This matches windows and aura.
Also fixes bug where we were setting incorrect name on widget.
BUG=chromium-os:22592
TEST=see bug
R=ben@chromium.org,oshima@chromium.org
Review URL: http://codereview.chromium.org/8527008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=103831
TEST=Move window after typing text in omnibox
Review URL: http://codereview.chromium.org/8532001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
before).
For other configurations it can also be set by a command line option at run-time (also as before).
What changes is that we are removing use_only_pure_views as a separate GYP flag which we no longer really need.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8528014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
entirely.
- Creates StackingController in aura_shell to manage stacking and implement aura::StackingClient.
- Moves DesktopEventFilter to shell, since it's mostly shell-related anyway.
- Move relevant tests to shell, requiring some refactoring to move test utils around.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8505049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NativeWidgetAura now respects the Widget::InitParams flag for transparency with respect to setting its layer opaque. This means that Aura widgets are now opaque by default, including the main Chrome browser window.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8510023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=103637
TEST=Only affects Aura builds. Test status area menus (when added), notifications, tooltips, and general UI windows / features.
Review URL: http://codereview.chromium.org/8508030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Rename DesktopDelegate to StackingClient.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8508020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
+ Set the cursor in the desktop's event filter.
+ Add the ui::EF_IS_NON_CLIENT flag to mouse events when needed, so views doesn't override the cursor.
+ Move views/window/hit_test.h to ui/base/hit_test.h and remove the extra copy in ui/aura.
BUG=103298
TEST=move cursor over desktop, window edges, window client area
Review URL: http://codereview.chromium.org/8501018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- make type_bubble widget a gtk popup window, so that window manager will respect the popup placement. this is inline with how native_widget_win treats this widget type.
also add 'show even when screen locked code' in old bubble code into setting level bubble.
BUG=chromium-os:22429, chromium-os:22579,chromium-os:22546
TEST=on alex, with fix, volume and brightness shows up at bottom of screen, and when in screenlocked mode.
Review URL: http://codereview.chromium.org/8463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=102580 102578
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8477019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
add "native_view()" check in NativeTabContentsContainerAura
This is necessary as native_view gets destroyed when parent window gets destroyed before tab_contents detatches the native view.
type child should be added to parent.
BUG=99937
TEST=manual: open http auth dialog and close.
Review URL: http://codereview.chromium.org/8462001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Fixes Win dbg shared builder.
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8477039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement WidgetFocusChangeListener, close on deactivate.
DisableInactiveRendering on the parent's top level widget.
Notify widgets without non-client views of activation changes.
To ensure bubble owners get the first click event that closes the bubble:
Stop explicitly setting the owner as the foreground window on close.
To ensure that removing this code didn't regress crbug.com/75610:
Add WS_POPUP for modal dialogs and re-enable owners on close (allowing OS activation).
Note: Showing bubbles long after CreateBubble might break DisableInactiveRendering.
BUG=97248,98312
TEST=views_examples bubbles close on deactivate, example window never appears deactivated.
Review URL: http://codereview.chromium.org/8384020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=101505
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8334036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We currently don't support child popup windows on other platforms.
BUG=102585
TEST=views_unittests --gtest_filter=WidgetTest.Visibility
Review URL: http://codereview.chromium.org/8438040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NonClientView when inactive rendering disabled changes, but
implementations are relying on this to be sent when active state may
have changed too. This isn't the right fix, but gives us the old
behavior. We really need to persist active state in widget, then
notify the NonClientView when it changes, or the inactive rendering
disabled state changes.
BUG=102695
TEST=easiest to verify on windows in classic mode (non-aero). Create
two chrome windows, click between them and make sure the window losing
activation state looks inactive.
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8386064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/8372048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reduce dependencies amongst DCLM, ShowStateC, WorkspaceC and such.
I changed my mind and kept "WorkspaceController owns WorkspaceManager" as this seems to be better in long run. I decoupled DCLM from ShowStateC and WorkspaceC. I moved a layout_in_progress flag to WorkspaceManager as it really belongs there, and can reduce dependency.
BUG=84070
TEST=new test conditions for workspace observer are added to workspace_manager_unittests
Review URL: http://codereview.chromium.org/8430024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this CL, window is now correctly maximized/fullscreen'ed on aura desktop.
* Added OnPropertyChanged to WindowObserver
* Added Get/Set IntProperty to simplify handling int value properties.
* Remove IsOrContainsFullscreen. Added Workspace::ContainsFullscreen instead. We need this to autohide launcher.
BUG=97257,97259
TEST=new test for property change notification. existing tests are updated, except maximized/fullscreen drag test. I'll add it to new set of tests that verifies window dragging within workspace.
Review URL: http://codereview.chromium.org/8400063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
is needed for bubbles.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8351042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=97411
TEST=interactive_ui_tests --gtest_filter=ConstrainedWindowViewTest.FocusTest
Review URL: http://codereview.chromium.org/8052019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
better matches expectations.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8432001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also makes aura::DesktopHostLinux avoid generating Char
events when not appropriate, which avoids a problem that I
observed where arrow keys were moving <select> selections two
spaces instead of one.
There still appears to be an issue with the Enter key getting
double-counted in <select> popups, though (but if we avoid
sending a Char event for it, things like <textarea> break),
and fullscreen Flash windows aren't getting updated.
BUG=99757,101899,101848
TEST=manual
Review URL: http://codereview.chromium.org/8417008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108008 0039d316-1c4b-4281-b951-d872f2087c98
|