summaryrefslogtreecommitdiffstats
path: root/views/widget
Commit message (Collapse)AuthorAgeFilesLines
* Attempt 2 at:sky@chromium.org2010-06-152-0/+96
| | | | | | | | | | | | | | | | Changes the tab close button to a dot, unless you're near the button or the tab is selected. The only difference between this and the first is that I missed a remove from the set if the view was deleted, which resulted in a crash. I've added an interactive test case that covers this. BUG=45743 TEST=none Review URL: http://codereview.chromium.org/2863003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49828 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 49795 - Changes the tab close button to a dot, unless you're near the ↵sky@chromium.org2010-06-152-95/+0
| | | | | | | | | | | | | | | | | | | button or the tab is selected. I'm not to keen on the mouse near names, if you have better ideas please say so. BUG=45743 TEST=none Review URL: http://codereview.chromium.org/2796006 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/2823005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49801 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the tab close button to a dot, unless you're near the buttonsky@chromium.org2010-06-152-0/+95
| | | | | | | | | | | | | | or the tab is selected. I'm not to keen on the mouse near names, if you have better ideas please say so. BUG=45743 TEST=none Review URL: http://codereview.chromium.org/2796006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49795 0039d316-1c4b-4281-b951-d872f2087c98
* Notification balloons don't want the WS_EX_LAYOUTRTL style flag, since the ↵johnnyg@chromium.org2010-06-143-4/+18
| | | | | | | | | | | directionality of the content is specified already inside the HTML. BUG=46170 TEST=create a notification while using an RTL language for Chrome UI. Review URL: http://codereview.chromium.org/2794001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49723 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tooltip wrap problem per chromium-os:4042xiyuan@chromium.org2010-06-141-5/+0
| | | | | | | | | | | Remove the max width chars logic and let GtkLabel decide how to wrap. BUG=chromium-os:4042 TEST=Verify fix for chromium-os:4042 Review URL: http://codereview.chromium.org/2832003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49721 0039d316-1c4b-4281-b951-d872f2087c98
* Draw transparent background on window_content() only for TYPE_CHILD.oshima@chromium.org2010-06-111-2/+2
| | | | | | | | | | | Transparent background is draws on GtkWindow for window types. This was necessary only for TYPE_CHILD. BUG=43611 TEST=type something in address bar and you'll see no flicker on dropdown. Review URL: http://codereview.chromium.org/2797001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49581 0039d316-1c4b-4281-b951-d872f2087c98
* Draw composited widget's content only after something is drawn.oshima@chromium.org2010-06-091-5/+9
| | | | | | | | | | | This was causing ugly flicker when screen locker is shown. BUG=none TEST=none Review URL: http://codereview.chromium.org/2717002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49232 0039d316-1c4b-4281-b951-d872f2087c98
* MessageBubble which does not require separate window and does not grab input ↵oshima@chromium.org2010-06-072-13/+14
| | | | | | | | | | | | | | | | | | | | on mouse press event. * Added new constructor to InfoBubble for chromeos which takes WidgetGtk::Type parameter * Made DoGrab/HandleGrabBroke so that subclass can customize its behavior. * Added MessageBubble::ShowNoGrab that shows a child MessageBubble which does not grab input on mouse press event. * Explicitly remove accelerator when closed. This is necessary for child, but doing for all case as it's harmless to do so. * Moved HandleGrabBroke to protected and made virtual so that sub class can trap the event. ScreenLocker will use this event to detect this. This will be used for screen locker. BUG=none TEST=none Review URL: http://codereview.chromium.org/2682004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49068 0039d316-1c4b-4281-b951-d872f2087c98
* Add cross platform Widget::InitWithWidget(parent, const gfx::Rect& bounds);oshima@chromium.org2010-06-055-0/+28
| | | | | | | | | | | | | On linux, native parent has to be either window_contents or widget depending of the type of wiget. InitWithWidget takes a parent Widget instead of native and hides these details. I also cleaned up a few dead/duplicated code. BUG=none TEST=none Review URL: http://codereview.chromium.org/2355003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48990 0039d316-1c4b-4281-b951-d872f2087c98
* Create CompositePainter once for a widget instead of ref count.oshima@chromium.org2010-06-021-26/+14
| | | | | | | | | | | | | | | There is a issue in adding new composited child after the ref count of painter became zero. RefCount::Release does not tell if it's been deleted so it can't remove the painter key from G_OBJECT(widget). I could have changed RefCounted::Release to return true, but I took this approach because new child will be added later in most use case (like info bubble), and it's more efficient to keep the painter rather than creating and deleting each time. BUG=none TEST=none Review URL: http://codereview.chromium.org/2449010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48757 0039d316-1c4b-4281-b951-d872f2087c98
* views: implement a TODO to move WidgetGtk::GetWindowForNative to WindowGtk.tfarina@chromium.org2010-06-022-20/+1
| | | | | | | | | BUG=NONE TEST=compiles. Review URL: http://codereview.chromium.org/1640003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48717 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing AutoReset to be a template.gspencer@chromium.org2010-06-011-1/+1
| | | | | | | | | | | I've run into a couple of times this week when I needed one of these, for two different types besides bool. Time to fix the TODO. TEST=trybots FTW, and built locally. BUG=none Review URL: http://codereview.chromium.org/2394001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48644 0039d316-1c4b-4281-b951-d872f2087c98
* Elide the EV bubble when it's extremely long. This limits it to half the ↵pkasting@chromium.org2010-05-201-2/+2
| | | | | | | | | | location bar width, unless eliding to that would result in a width of less than 150 px. BUG=42856 TEST=Visit https://www.barbican.org.uk/eticketing/index.asp and make the window smaller. The EV bubble should shrink, eliding in middle, until it hits a minimum size. Review URL: http://codereview.chromium.org/2084012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47819 0039d316-1c4b-4281-b951-d872f2087c98
* Clear password field when navigating though users on the login screen.nkostylev@google.com2010-05-203-3/+12
| | | | | | | | | BUG=chromium-os:2319 TEST=Enter password on the login screen. Navigate to the left/right user window. Navigate back. Password field should be empty. Review URL: http://codereview.chromium.org/2132011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47785 0039d316-1c4b-4281-b951-d872f2087c98
* A crasher would sometimes happen when opening a selet file dialogjcivelli@chromium.org2010-05-191-0/+5
| | | | | | | | | | | | | | | | | | | (such as when loading an unpacled extension). This is because we would reinterpret cast the user data of the HWND to a WidgetWin, and in that case the Windows dialog has a user-data that we did not set. This CL checks that the HWND is at least a WindowImpl before attempting to retrieve the WidgetWin, ensuring we won't mess with windows we did not create directly. BUG=44312 TEST=Open the extension page. Move the focus by pressing TAB to the "Load unpacked extension..." button. Press ENTER many times quickly so it opens/closes the "Select dir" dialog. It should not crash. Review URL: http://codereview.chromium.org/2124009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47672 0039d316-1c4b-4281-b951-d872f2087c98
* Host cookie modal dialog and js modal modal dialog in NativeDialogHostxiyuan@chromium.org2010-05-061-5/+9
| | | | | | | | | | | | | | | | | | | | | - Enable modal dialog in NativeDialogHost. This is not fully work in ChromeOS because e.g. user could still alt-tab away. However, setting modal would block user from interacting with relevant browser window and avoid crashes; - Move dialog close code from NativeHostDialog's destructor to WindowClosing because a dialog's "response" signal handler could rely on the contents; - Add "check-resize" signal handler to make GtkExpander work nicely with NativeDialogHost; - Add ShowModalDialogWithMinLocalizedWidth to gtk_util for cookie and js modal dialog; - Change in WidgetGtk::SetBounds to call gtk_window_move/resize always to keep GtkWindow's geometry info up-to-date; BUG=none TEST=Verify cookie prompt and js dialog on ChromeOS is hosted in a Chrome window and not occupy the whole screen. Review URL: http://codereview.chromium.org/1995001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46619 0039d316-1c4b-4281-b951-d872f2087c98
* Add transparency to TYPE_CHILD WidgetGtk.oshima@chromium.org2010-05-052-48/+167
| | | | | | | | | | | | | | | * This does not work with renderer as parent yet.(I need to investigate renderer what it's doing) * gtk_widget_set_back_pixmap is not necessary and removed. * changed to use clear operation to fill a background with transparent color. BUG=none TEST=manual: added transparent widget example to view_examples. I also tested with chrome and confirmed that info bubble, app launcher and tab dragging works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46374 Review URL: http://codereview.chromium.org/1629024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46439 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add transparency to TYPE_CHILD WidgetGtk."oshima@chromium.org2010-05-042-164/+49
| | | | | | | | | | This reverts commit ddbb1a000db9a2e8ea0cb504877c48fd7838da1b. TBR=sky@chromium.org Review URL: http://codereview.chromium.org/1951003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46377 0039d316-1c4b-4281-b951-d872f2087c98
* Add transparency to TYPE_CHILD WidgetGtk.oshima@chromium.org2010-05-042-49/+164
| | | | | | | | | | | | | * This does not work with renderer as parent yet.(I need to investigate renderer what it's doing) * gtk_widget_set_back_pixmap is not necessary and removed. * changed to use clear operation to fill a background with transparent color. BUG=none TEST=manual: added transparent widget example to view_examples. I also tested with chrome and confirmed that info bubble, app launcher and tab dragging works. Review URL: http://codereview.chromium.org/1629024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46374 0039d316-1c4b-4281-b951-d872f2087c98
* Use customized RGBA-enabled tooltip window for tooltip on ChroemOSxiyuan@chromium.org2010-04-284-66/+155
| | | | | | | | | | | | | | | | - Add a TooltipWindowGtk which uses RGBA colormap and has a label; - Use TooltipWindowGtk for tooltip for both WidgetGtk and RenderWidgetHostViewGtk After this change, we will get back shadow and rounded corner for tooltip in theme engine. BUG=none TEST=none Review URL: http://codereview.chromium.org/1708015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45854 0039d316-1c4b-4281-b951-d872f2087c98
* This adds in the ability for Chrome to generate windows with snapshotsgspencer@chromium.org2010-04-281-1/+2
| | | | | | | | | | | | of all currently open tabs in all browsers. This is needed for overview mode on ChromeOS. BUG=http://code.google.com/p/chromium-os/issues/detail?id=1170 TEST=Ran Chrome under ChromeOS with updated window manager. Review URL: http://codereview.chromium.org/661237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45824 0039d316-1c4b-4281-b951-d872f2087c98
* Remove MessageLoopForUI::Observer in WidgetGtk.oshima@chromium.org2010-04-262-27/+0
| | | | | | | | | | | | | | | This seems to be inherited from windows code and not necessary. All worked fine without this. I left "#include "base/message_loop.h" in widget_gtk.h as many users of widget_gtk (and widget_win) expects it's included here. BUG=none TEST=manual: all painting shoudl work fine after this modification. Review URL: http://codereview.chromium.org/1705007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45623 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused local variables now that subclasses don't need to track their ↵pkasting@chromium.org2010-04-231-3/+0
| | | | | | | | | | own accessibile name. (In other words, I forgot to do this in r43558.) BUG=none TEST=none Review URL: http://codereview.chromium.org/1751018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45512 0039d316-1c4b-4281-b951-d872f2087c98
* Add a widget delegate handler for the WM_SETTINGCHANGE message in windows. ↵johnnyg@chromium.org2010-04-232-0/+6
| | | | | | | | | | | This is sent when the size/position of the taskbar changes, and we need to move the desktop notifications if that happens. BUG=35464 TEST=open notifications and move taskbar Review URL: http://codereview.chromium.org/1622018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45504 0039d316-1c4b-4281-b951-d872f2087c98
* Fix recursive calls to PaintNow under gtk2.18.3 and up.oshima@chromium.org2010-04-231-1/+8
| | | | | | | | | | | gdk_window_process_updates in gtk2.18.3 issues exposure events on its child gdkwindow (with update_children=true) and drives event loop. In current implementation, WidgetGtk::DidProcessEvent calls PaintNow no matter where the event was generated to, which causes recursive calls to PaintNow. This cl fix this issue by calling PaintNow only when the event was for the target WidgetGtk. BUG=42235 TEST=none Review URL: http://codereview.chromium.org/1741004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45461 0039d316-1c4b-4281-b951-d872f2087c98
* Add EnableDoubleBuffer to WidgetGtkoshima@chromium.org2010-04-212-3/+26
| | | | | | | | | | | | | This will be used to eliminate flicker issue in notification panel (and probably in settings when settings is moved to views). NativeViewHostGtk was creating Fixed with gdk window everytime it is repositioned with clipping. This was causing a lot of creation/deletion of fixed when moving a native control in scroll bar. BUG=23445 TEST=none Review URL: http://codereview.chromium.org/1725005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45252 0039d316-1c4b-4281-b951-d872f2087c98
* Defer WidgetGtk's focus manager destructionxiyuan@chromium.org2010-04-202-4/+21
| | | | | | | | | | | | | | | | | | This is for the case when a WidgetGtk is hosted in another WidgtGtk and holds a reference to its focus manager. When hosting widget is destroied, it gets the "destroy" signal before the contained widget and thus schedules its destruction before the contained widget. And currently, we are not clearing the focus manager reference in another root view and when contained widget destructs, we crash. By changing focus manager's release into another message, the focus manager remains valid during contained widget destruction. BUG=none TEST=In ChromeOS, bring up options dialog and then click on buttons such as language settings, networ config etc. Then dismiss the options dialog and Chrome should not crash. Review URL: http://codereview.chromium.org/1661003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45071 0039d316-1c4b-4281-b951-d872f2087c98
* UI Language switch implemented by propagating LocaleChanged()glotov@google.com2010-04-205-0/+31
| | | | | | | | | | | | | | | notification to all the views currently active. Before this CL, all views were recreated instead. That was very refactoring-unsafe. Note, this is first part of the change. It prepares overall architecture means and can be committed first. The other part contains implementation details and is here: http://codereview.chromium.org/1551029/show BUG=none TEST=none Review URL: http://codereview.chromium.org/1596023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45057 0039d316-1c4b-4281-b951-d872f2087c98
* Hover buttons for notification.oshima@chromium.org2010-04-161-6/+16
| | | | | | | | | | | | | | | * Chagned WidgetGtk so that any GtkFixed can be parent of WidgetGtk. * Close button and Options menu is moved to separate TYPE_CHILD WidgetGtk which is shown/hidden as mouse moves. TODO: host Widget is not transparent right now. I'll address this in separate CL. BUG=41011 TEST=none Review URL: http://codereview.chromium.org/1654006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44861 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash if the window hosting a menu was closed while thesky@chromium.org2010-04-161-0/+3
| | | | | | | | | | | | menu was showing. When this happens the window the menu creates is implicitly destroyed (because the parent is going away). BUG=25563 TEST=see bug Review URL: http://codereview.chromium.org/1664001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44807 0039d316-1c4b-4281-b951-d872f2087c98
* Use a widget as drag icon for proper transparency handling.xiyuan@chromium.org2010-04-141-5/+62
| | | | | | | | | | | | | | | gtk_drag_set_icon_pixbuf converts pixbuf with alpha into a pixmap and mask. It uses the pixmap as window back pixmap and shape the window with the mask. This should work theoretically. However, the underlying window's content get mixed into the drag icon and make it un-usable. So changing to use a drag icon widget of our own which would render everything correctly. BUG=none. TEST=Verify the drag-n-drop works correct without a messed up drag icon on bookmark bar and omnibox. Review URL: http://codereview.chromium.org/1630017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44483 0039d316-1c4b-4281-b951-d872f2087c98
* Allow SetAlwaysOnTop() before GtkWidget creation.oshima@chromium.org2010-04-072-3/+12
| | | | | | | | | | | like WidgetWin does. BUG=none TEST=manual: web notification in linux/toolkitview build will work. Review URL: http://codereview.chromium.org/1628006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43855 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate a lot of duplicated implementations of Get/SetAccessibleName() by ↵pkasting@chromium.org2010-04-032-14/+0
| | | | | | | | | | just putting it on the base class. Also cleans up a couple other misc. accessibility functions in view.h. BUG=none TEST=none Review URL: http://codereview.chromium.org/1512012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43558 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the change that was checked in by accident.oshima@chromium.org2010-04-032-17/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1560014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43550 0039d316-1c4b-4281-b951-d872f2087c98
* * WidgetGtk::OnKeyPressed never called on window because the signal handleroshima@chromium.org2010-04-022-4/+26
| | | | | | | | | | | | was connected to the content, but the focus was set to GtkWindow by FocusManager. * Enable IgnoreKeyupForAccelerators for linux. BUG=40140 TEST=IgnoreKeyupForAccelerators shoud pass now on linux. Review URL: http://codereview.chromium.org/1575001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43506 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/gfx/canvas and app/gfx/font to gfx/.ben@chromium.org2010-03-236-6/+6
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1132006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42312 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r41641 "Make DevTools open docked by default..."xiyuan@chromium.org2010-03-222-378/+98
| | | | | | | | | | | | | | - Fix DevToolsSanityTest time out. The timeout is because the tests wait for Browser closed notification. However, docked DevTools does not have its own Browser object and hence the wait times out. BUG=none TEST=none Review URL: http://codereview.chromium.org/1025005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42226 0039d316-1c4b-4281-b951-d872f2087c98
* Move RTL related functions from app/l10n_util to base/i18n/rtlben@chromium.org2010-03-201-2/+3
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1073005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42182 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes leak in WidgetGtk::OnWindowPaint.sky@chromium.org2010-03-191-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1155002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42135 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks for login panels:sky@chromium.org2010-03-191-2/+4
| | | | | | | | | | | | | | | . Allows widget to go transparent even if wm says it isn't supported. See comment I added as to why I'm allowing it. . Makes font bold. . Sets property on window so window manager knows chrome has painted. This avoids the gray flash. BUG=none TEST=none Review URL: http://codereview.chromium.org/1149001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42108 0039d316-1c4b-4281-b951-d872f2087c98
* Move text_elider from app/gfx to app/ben@chromium.org2010-03-191-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42090 0039d316-1c4b-4281-b951-d872f2087c98
* Move more files to toplevel gfx.ben@chromium.org2010-03-191-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42071 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more files to toplevel gfx dir.ben@chromium.org2010-03-174-4/+5
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41812 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Make DevTools open docked by default for chrome os."tony@chromium.org2010-03-162-98/+378
| | | | | | | | | | | This reverts commit r41641 because all the devtools interactive_ui_tests are failing. TBR=xiyuan Review URL: http://codereview.chromium.org/1007004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41691 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk views code touch upxiyuan@chromium.org2010-03-162-6/+22
| | | | | | | | | | | | | | | | | - Fix wrong mouse event coordinates in gtk event handlers. Gtk events could be propogate to parent if child does not handle it and we need to translate the coordinates in gtk event in this case; - Consume button pressed event if a widget is not transparent; - Move mouse cursor reset handling on mouse leave from WindowGtk into RootView. This is because once WindowGtk set a mouse cursor, it stucks there and RootView could not change it. BUG=None TEST=Verify the following two cases: 1. Click on top of a tab should not move chrome; 2. Dock devtools and mouse cursor should change correct on the split and change back to left pointer on leave the split; Review URL: http://codereview.chromium.org/997002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41681 0039d316-1c4b-4281-b951-d872f2087c98
* Make DevTools open docked by default for chrome os.xiyuan@chromium.org2010-03-152-378/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | - Change prefs::kDevToolsOpenDocked default to "true" for chrome os; - Fix a problem on chrome os that DevTools occupies the whole client area. This is because BrowserView::Show is called before gtk size allocated event and thus divider offset is calculated wrongly to 0. The fix is to move the "restore split offset" logic to UpdateDevToolsForContents before we do contents_split_ layout for show up DevTools; - Fix a problem that DevTools becomes invisible after undock then dock for linux toolkit_view/chromeos build. This is because browser/views/tab_contents/TabContentsViewGtk does not show/hide its contained TabContents like TabContentsViewWin. As mentioned in BrowserWindowGtk::UpdateDevToolsForContents, the fix is to hook up gtk show/hide signal and notify the contained TabContents about the visibility change. After the fix, remove the manual ShowContents for DevTools in BrowserWindowGtk::UpdateDevToolsForContents. <http://crosbug.com/333> BUG=333 TEST=Verify that DevTools show up as docked by default. Review URL: http://codereview.chromium.org/880003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41641 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/gfx contents to gfx/ben@chromium.org2010-03-145-5/+5
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41559 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-143-14/+20
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/851010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41539 0039d316-1c4b-4281-b951-d872f2087c98
* Initial focus fix on x11/gtkoshima@chromium.org2010-03-102-2/+9
| | | | | | | | | | | | | The initial focus on x11/gtk was not working propertly. It was jsut working by coincident, and chromeos's compact location bar revealed the bug. This CL fixes by setting a focus when the window itself gets focus. BUG=34159 TEST=on chromeos build, omnibox should have a focus on a new window. Review URL: http://codereview.chromium.org/756002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41187 0039d316-1c4b-4281-b951-d872f2087c98
* Final removal of the bad dependency of chrome/common on chrome/browserphajdan.jr@chromium.org2010-03-101-18/+19
| | | | | | | | | | | Also convert app/gtk_dnd_util.h from a class to a namespace for consistency with added app/gtk_util.h. TEST=none BUG=none Review URL: http://codereview.chromium.org/669268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41177 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-11 05:50:26 +0000