summaryrefslogtreecommitdiffstats
path: root/views/widget
Commit message (Collapse)AuthorAgeFilesLines
* Move app/gfx/canvas and app/gfx/font to gfx/.ben@chromium.org2010-03-236-6/+6
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1132006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42312 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r41641 "Make DevTools open docked by default..."xiyuan@chromium.org2010-03-222-378/+98
| | | | | | | | | | | | | | - Fix DevToolsSanityTest time out. The timeout is because the tests wait for Browser closed notification. However, docked DevTools does not have its own Browser object and hence the wait times out. BUG=none TEST=none Review URL: http://codereview.chromium.org/1025005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42226 0039d316-1c4b-4281-b951-d872f2087c98
* Move RTL related functions from app/l10n_util to base/i18n/rtlben@chromium.org2010-03-201-2/+3
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1073005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42182 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes leak in WidgetGtk::OnWindowPaint.sky@chromium.org2010-03-191-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1155002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42135 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks for login panels:sky@chromium.org2010-03-191-2/+4
| | | | | | | | | | | | | | | . Allows widget to go transparent even if wm says it isn't supported. See comment I added as to why I'm allowing it. . Makes font bold. . Sets property on window so window manager knows chrome has painted. This avoids the gray flash. BUG=none TEST=none Review URL: http://codereview.chromium.org/1149001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42108 0039d316-1c4b-4281-b951-d872f2087c98
* Move text_elider from app/gfx to app/ben@chromium.org2010-03-191-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42090 0039d316-1c4b-4281-b951-d872f2087c98
* Move more files to toplevel gfx.ben@chromium.org2010-03-191-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42071 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more files to toplevel gfx dir.ben@chromium.org2010-03-174-4/+5
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41812 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Make DevTools open docked by default for chrome os."tony@chromium.org2010-03-162-98/+378
| | | | | | | | | | | This reverts commit r41641 because all the devtools interactive_ui_tests are failing. TBR=xiyuan Review URL: http://codereview.chromium.org/1007004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41691 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk views code touch upxiyuan@chromium.org2010-03-162-6/+22
| | | | | | | | | | | | | | | | | - Fix wrong mouse event coordinates in gtk event handlers. Gtk events could be propogate to parent if child does not handle it and we need to translate the coordinates in gtk event in this case; - Consume button pressed event if a widget is not transparent; - Move mouse cursor reset handling on mouse leave from WindowGtk into RootView. This is because once WindowGtk set a mouse cursor, it stucks there and RootView could not change it. BUG=None TEST=Verify the following two cases: 1. Click on top of a tab should not move chrome; 2. Dock devtools and mouse cursor should change correct on the split and change back to left pointer on leave the split; Review URL: http://codereview.chromium.org/997002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41681 0039d316-1c4b-4281-b951-d872f2087c98
* Make DevTools open docked by default for chrome os.xiyuan@chromium.org2010-03-152-378/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | - Change prefs::kDevToolsOpenDocked default to "true" for chrome os; - Fix a problem on chrome os that DevTools occupies the whole client area. This is because BrowserView::Show is called before gtk size allocated event and thus divider offset is calculated wrongly to 0. The fix is to move the "restore split offset" logic to UpdateDevToolsForContents before we do contents_split_ layout for show up DevTools; - Fix a problem that DevTools becomes invisible after undock then dock for linux toolkit_view/chromeos build. This is because browser/views/tab_contents/TabContentsViewGtk does not show/hide its contained TabContents like TabContentsViewWin. As mentioned in BrowserWindowGtk::UpdateDevToolsForContents, the fix is to hook up gtk show/hide signal and notify the contained TabContents about the visibility change. After the fix, remove the manual ShowContents for DevTools in BrowserWindowGtk::UpdateDevToolsForContents. <http://crosbug.com/333> BUG=333 TEST=Verify that DevTools show up as docked by default. Review URL: http://codereview.chromium.org/880003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41641 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/gfx contents to gfx/ben@chromium.org2010-03-145-5/+5
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41559 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-143-14/+20
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/851010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41539 0039d316-1c4b-4281-b951-d872f2087c98
* Initial focus fix on x11/gtkoshima@chromium.org2010-03-102-2/+9
| | | | | | | | | | | | | The initial focus on x11/gtk was not working propertly. It was jsut working by coincident, and chromeos's compact location bar revealed the bug. This CL fixes by setting a focus when the window itself gets focus. BUG=34159 TEST=on chromeos build, omnibox should have a focus on a new window. Review URL: http://codereview.chromium.org/756002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41187 0039d316-1c4b-4281-b951-d872f2087c98
* Final removal of the bad dependency of chrome/common on chrome/browserphajdan.jr@chromium.org2010-03-101-18/+19
| | | | | | | | | | | Also convert app/gtk_dnd_util.h from a class to a namespace for consistency with added app/gtk_util.h. TEST=none BUG=none Review URL: http://codereview.chromium.org/669268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41177 0039d316-1c4b-4281-b951-d872f2087c98
* Modify WidgetWin::Init() such that it doesn't create the FocusManager if the ↵marshall@chromium.org2010-03-101-2/+5
| | | | | | | | | | | | window is style WS_CHILD and parented to the desktop. We intentionally set the parent to the desktop window to remove it from the FocusManager hierarchy while the window is hidden. BUG=37698 TEST=NONE Was: http://codereview.chromium.org/812004 Review URL: http://codereview.chromium.org/790005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41171 0039d316-1c4b-4281-b951-d872f2087c98
* Support popups that don't accept clicks in Views/Linuxdavemoore@chromium.org2010-03-092-1/+55
| | | | | | | | | | | | The status bubbles were accepting clicks in Linux, which prevented controls in the bottom left corner from being clicked on. BUG=None TEST=On cros open the calculator panel. The "0" should be clickable. Review URL: http://codereview.chromium.org/698001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41072 0039d316-1c4b-4281-b951-d872f2087c98
* svn prop fixes. Applied to all files not in third_party.pkasting@chromium.org2010-03-091-0/+0
| | | | | | | | | | | | * Removed eol-style, executable and mergeinfo from BMP/GIF/ICO/JPEG files, and set correct mime-type. * Removed executable and mergeinfo from .c/.cc/.cpp/.h/.m/.mm and .gyp files, and set eol-style to LF. TBR=evanm BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40991 0039d316-1c4b-4281-b951-d872f2087c98
* Replace lots of "int x, int y" with gfx::Point. Also use gfx::Size and ↵pkasting@chromium.org2010-03-085-26/+16
| | | | | | | | | | gfx::Rect in a few more places. BUG=none TEST=none Review URL: http://codereview.chromium.org/669130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40966 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break.johnnyg@chromium.org2010-03-041-2/+2
| | | | | | | | | | TBR=oshima BUG=none TEST=none Review URL: http://codereview.chromium.org/668095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40675 0039d316-1c4b-4281-b951-d872f2087c98
* On Windows, detect the WM_DISPLAYCHANGE message which indicates the desktop ↵johnnyg@chromium.org2010-03-046-2/+70
| | | | | | | | | | | size is changing. Pass this event using the NotificationService, and listen for it in desktop notification code in order to adjust metrics properly for the corner of the screen. BUG=35464 TEST=resize desktop after starting chrome; create notifications. Review URL: http://codereview.chromium.org/606007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40670 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up TooltipManagerWin a bit. Original patch by Jay Soffian (see ↵pkasting@chromium.org2010-03-043-36/+28
| | | | | | | | | http://codereview.chromium.org/668021 ), r=me. BUG=37368 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40662 0039d316-1c4b-4281-b951-d872f2087c98
* Correct positioning of tooltips in nonclient portion of Aero windows. ↵pkasting@chromium.org2010-03-041-0/+6
| | | | | | | | | Original patch by Jay Soffian (see http://codereview.chromium.org/652104 ), r=me. BUG=36489 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40656 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unititalized variables.finnur@chromium.org2010-03-031-2/+2
| | | | | | | | | | | | Should fix the build. TBR=denisromanov BUG=None TEST=None Review URL: http://codereview.chromium.org/669002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40561 0039d316-1c4b-4281-b951-d872f2087c98
* Checking in patch for Denis Romanov (originally reviewed here: ↵finnur@chromium.org2010-03-032-18/+64
| | | | | | | | | | | | | | http://codereview.chromium.org/651027). Make mouse wheel scroll contents of views::ScrollView control in Linux (GTK). BUG=26970 TEST=Make and run out/Debug/view_examples and scroll in ScrollView tab. TBR=denisromanov Review URL: http://codereview.chromium.org/667008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40555 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a Chrome crash, which occurs in a ChromeFrame instance in the destructor ↵ananta@chromium.org2010-03-021-2/+3
| | | | | | | | | | | | | | | | | | | | of the WidgetWin object for the ExternalTabContainer. Basically the crash happens while dereferencing the chrome ui message loop which has been destroyed. This could happen in a ChromeFrame instance as the message loop is destroyed when the module ref count drops to 0. The ref count is decremented in the destructor of the AutomationProvider which runs before the Widgetwin destructor. Fix is to move the code in the WidgetWin destructor to the code which processes WM_NCDESTROY Fixes bug http://code.google.com/p/chromium/issues/detail?id=37163 Bug=37163 Review URL: http://codereview.chromium.org/663001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40393 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in dragging from download manager on chrome os.sky@chromium.org2010-02-251-2/+2
| | | | | | | | | | BUG=36516 TEST=on chromeos drag from the download manager and make sure we don't crash. Review URL: http://codereview.chromium.org/660088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40040 0039d316-1c4b-4281-b951-d872f2087c98
* Landing Marshall Greenblatt change.jcampan@chromium.org2010-02-242-4/+33
| | | | | | | | | | | | | See review at: http://codereview.chromium.org/609010/show BUG=None TEST=None Review URL: http://codereview.chromium.org/657019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39827 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where on views/gtk we send an exit before every press. We'resky@chromium.org2010-02-191-13/+25
| | | | | | | | | | | | | still sending the exit before the press as I couldn't find any where to discern these events, but at least now we're sending an enter so that the sequence is exit enter press rather than exit press. BUG=none TEST=none Review URL: http://codereview.chromium.org/650054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39514 0039d316-1c4b-4281-b951-d872f2087c98
* Move compact navigation bar('s entry view) to main menu.oshima@chromium.org2010-02-111-4/+18
| | | | | | | | | | | | | | | | * Chagned main menu to use TYPE_WINDOW instead of POPUP. * Added hooks to close main menu when a user clicked non content area. (see MainMenuContainer::OnMousePressed and MainMenu::ActiveWindowChanged) * removed entry view from CompactNavigationBar view. We probably should rename this class (later). * Fixed a mouse coordinates issue in WidgetGtk: A location in the mouse event may not be in its gdk_window when it's originated from child gdk_window. * UIStyle's enum has to start with 0 * removed DLOG thas I checked in by accident. BUG=31766 TEST=manual: switch to compact navigation bar using ctrl-shift-c and confirm that no navigation entry in title bar. main menu has the navigation entry instead. Review URL: http://codereview.chromium.org/604015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38816 0039d316-1c4b-4281-b951-d872f2087c98
* CL implementing focus-dismissal of the chrome.experimental.popup set of ↵twiz@chromium.org2010-02-105-2/+49
| | | | | | | | | | | | | | | | | extension APIs. Specifically, these changes cause a displayed pop-up to be dismissed when the focus shifts away from both the pop-up view, and the extension-view that launched the pop-up.I had to do a lot of investigating and trial-and-error to converge to the solution present here. I was hoping to be able to piggy-back on the existing FocusManager's various listener routines, but because the pop-up is hosted in a BubbleWidget, which is a separate top-level window with its own focus manager, I could not rely on a given focus manager to take care of the focus change notifications. To get around the above issue, I added a new type of focus listener that can listen on native-window focus change events. I added invocations to this listener throughout the Widget classes in the system so that registered listeners will be notified on focus change. I found some of the focus change events problematic, as the system will arbitrarily reassign the focus to the main browser window when shifting activation between chrome windows. (SeefocusManagerWin::ClearNativeFocus). To prevent this focus bounce from confusing focus listeners, I added a means to suppress notification of focus change during these operations. I added GTK and Mac stubs for the new widget functions that will assert when called. GTK and Cocoa development is not my expertise, so I thought // TODO(port) would be wiser.I'm uncertain of the best means to unit-test these changes. Direction in this regard would be appreciated. BUG=None TEST=None Review URL: http://codereview.chromium.org/552167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38685 0039d316-1c4b-4281-b951-d872f2087c98
* Remove redundant casts in g_signal_connect() throughout all gtk code we have.erg@chromium.org2010-02-101-24/+24
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/600033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38629 0039d316-1c4b-4281-b951-d872f2087c98
* MoveAbove/SetAlwaysOnTop implementation for WidgetGtkoshima@chromium.org2010-01-271-2/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/548164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37312 0039d316-1c4b-4281-b951-d872f2087c98
* Makes WidgetGtk::GetBounds work if the widget_ is NULL (CloseNow hassky@chromium.org2010-01-111-1/+5
| | | | | | | | | | | | been invoked). We need to allow this so that GetBounds works if CloseNow is invoked but the destructor hasn't yet run. BUG=31975 TEST=see bug Review URL: http://codereview.chromium.org/536018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35971 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in WidgetGtk. WidgetGtk::GetBounds can end up crashing. Isky@chromium.org2010-01-081-1/+6
| | | | | | | | | | | | believe returning a location of 0x0 is effectively what Windows does too in this situation. BUG=none TEST=none Review URL: http://codereview.chromium.org/525105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35805 0039d316-1c4b-4281-b951-d872f2087c98
* Raise the window when showing the widget.oshima@chromium.org2010-01-071-1/+4
| | | | | | | | | | | | FindBar is behind other gdk window (i believe the tab content) when re-showing and is not visible. This fixed the issue. BUG=31735 TEST=None Review URL: http://codereview.chromium.org/519082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35752 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two related focus bugs on views/gtk:sky@chromium.org2010-01-072-3/+32
| | | | | | | | | | | | | | . Focus was inadvertently getting cleared when a window was shown because the focus-in event is received asynchronously. . In some situations we get multiple focus-out events in a row, this caused us to clear out who we thought would have focus. BUG=31140, 31130 TEST=see bugs Review URL: http://codereview.chromium.org/521045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35714 0039d316-1c4b-4281-b951-d872f2087c98
* Addded notification when ancestor gets changed. So windows that lack focus ↵georgey@chromium.org2010-01-075-0/+83
| | | | | | | | | | | | | manager, because of being created on inactive tab, could do the necessary work when focus manager is actually attached. This is relevant for Windows only, but some support functions (FindAllRootViews) could be useful for other architectures as well. BUG=22481 TEST=in the bug Review URL: http://codereview.chromium.org/492025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35675 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where recreating fixed in NativeViewHostGtk causes focus tosky@chromium.org2010-01-061-2/+7
| | | | | | | | | | | | | get lost. This caused problems when going in/out of fullscreen mode. I'm also improving the description of the WidgetGtk types. CHROMEOS_BUG=1020 TEST=see bug Review URL: http://codereview.chromium.org/518041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35594 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash/leak issue in native_view_host_gtk.cc.oshima@chromium.org2009-12-231-1/+4
| | | | | | | | | | | | | | | | * There are two path to NativeViewDetaching and we need to handle them differently. 1) Via gtk destroy signal. In this case, we should not try to remove the native view from parent because it's being deleted. 2) Through NativeViewHost::Detach(). In this case we need to remove the native view from parent because we added it to parent in NativeViewAttached(). * Fix NativeControlGtk not to destroy the native view because it's now destoryed by NativeViewHostGtk. * Fixed TabContentViewGtk so that it owns the nativew view. The native view was destroyed when Detached. * Added more checks so that test can catch regression. BUG=26154 TEST=The same procedure in bug should now pass. I added several checks that lead tests to fail if this problem exists. Review URL: http://codereview.chromium.org/510004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35220 0039d316-1c4b-4281-b951-d872f2087c98
* Change chromeos build to use viewsoshima@chromium.org2009-12-221-3/+0
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/508025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35186 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two related bugs:sky@chromium.org2009-12-153-5/+135
| | | | | | | | | | | | | | | | | | | . Native buttons were adding 8 pixels to each side of the preferred size. This isn't necessary on Gtk as the preferred size already includes padding. . I changed WidgetGtk so that it no longer needs to explicitly set a size request. Explicitly setting a size request is a bit of pain because it means you can't ask for the widget real size request without unsetting the explicit size request. Instead I've subclassed GtkFixed so that you can either have the default behavior, or use the allocated size rather than current size. CHROME_OS_BUG=1003 TEST=see bug Review URL: http://codereview.chromium.org/504003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34564 0039d316-1c4b-4281-b951-d872f2087c98
* A collection of fixes allowing the chrome.experimental.popup.* set of APIs ↵twiz@google.com2009-12-101-1/+3
| | | | | | | | to function in circumstances where there is no Browser instance present. This is a symptom of a tab-contents view hosted in an ExternalTabContainer.The major change here is the removal of the explicit dependency on a Browser instance across all of the delegates involved when showing a pop-up API. I modified the following delegates:- ExtensionPopupHost::Delegate- TabContentsDelegate- ExtensionFunctionDispatcher::DelegateBecause the pop-up requires a Profile, and a gfx::NativeWindow, I added methods to the above interfaces to provide them.BUG=noneTEST=ExtensionApiTest.FLAKY_Popup Review URL: http://codereview.chromium.org/434046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34219 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the menu model to live outside views/ so it can be sharedpinkerton@chromium.org2009-12-045-6/+9
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/465005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33827 0039d316-1c4b-4281-b951-d872f2087c98
* widget_gtk: Alphabetize CallXXX() functions.tony@chromium.org2009-12-032-114/+125
| | | | | | | | | | | BUG=None TEST=None Patch written by Thiago Farina <thiago.farina@gmail.com>. Review URL: http://codereview.chromium.org/451001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33745 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/449003/show for Thiago:sky@chromium.org2009-12-012-4/+5
| | | | | | | | | | | | | | views: replace the deprecated macro (DISALLOW_EVIL_CONSTRUCTORS). Use DISALLOW_COPY_AND_ASSIGN instead, also fix some style issues pointed by lint. BUG=none TEST=none Review URL: http://codereview.chromium.org/449075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33500 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in views/gtk tooltips. Gtk wraps text in labels atsky@chromium.org2009-12-013-14/+40
| | | | | | | | | | | | | | (screen_size + 1) / 2. I'm setting the max width of tooltips to match this else gtk can calculate more vertical white space than it ends up using. Simiarly when resetting the text in a label gtk doesn't reset wrap position. I'm forcing that by invoking set_max_width_chars. BUG=none TEST=none Review URL: http://codereview.chromium.org/454023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33494 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug that could lead to mouse motion events percolating up tosky@chromium.org2009-11-301-1/+1
| | | | | | | | | | | | next window when they shouldn't. This manifested itself as buttons highlighting when the mose wasn't over them. BUG=none TEST=none Review URL: http://codereview.chromium.org/454005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33321 0039d316-1c4b-4281-b951-d872f2087c98
* Make SystemMonitor not a Singleton and move it out of basephajdan.jr@chromium.org2009-11-262-2/+2
| | | | | | | | | | | | | SystemMonitor makes an assumption that through its lifetime a MessageLoop exists and stays the same. It is difficult and error-prone to satisfy that when it is a Singleton. It has caused problems in the past. Additionally, extract HighResoltionTimerManager out of time_win.cc, eliminating yet another Singleton. TEST=none BUG=none Review URL: http://codereview.chromium.org/431008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33214 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in tooltips. I was freeing a PangoFontDescription that Isky@chromium.org2009-11-252-11/+6
| | | | | | | | | | | | shouldn't have. I also added code to set the name of the widgets created by WidgetGtk. BUG=none TEST=none Review URL: http://codereview.chromium.org/443006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33117 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 12:51:24 +0000