| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
| |
what it was earlier on (around 11ish). I think Ben ended up putting
this code in the wrong place.
BUG=74604
TEST=best way to reproduce on current build is run in classic mode and
alt-tab between chrome and desktop windows window.
Review URL: http://codereview.chromium.org/7421004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it. Previously if we were going to maximize the window we would first
create it at the restored size, then maximize it. On slower machines
this could result in a noticeable relayout of the web page.
BUG=11229
TEST=see bug.
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7358005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7398014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7384017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/7349021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7374006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to remove it from all, but it's needed for the save. The reason I'm
doing this is I'm changing the calling order so that the delegate
won't know it's widget at the time GetSavedXXX is invoked. Turns out
we really only need the widget during the save calls anyway, so this
all still works.
BUG=none
TEST=none
R=ben@chromium.org,mirandac@chromium.org
Review URL: http://codereview.chromium.org/7377004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This involves having the GlassBrowserFrameView calculate its minimum size based on its sub-components as well as a change to NativeWidgetWin to adjust the reported minimum size by the native frame size to be consistent with the logic in NativeWidgetWin::ClientAreaSizeChanged().
BUG=9885
TEST=manual
Review URL: http://codereview.chromium.org/7277093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Setup hosting_widget_ before creating the View, because some of the steps
(e.g. SetBoundsRect) expect that there is a hosting widget.
* Unset capture_view_ when the captured view is destroyed.
BUG=none
TEST=run views-desktop, close a window, and there should be no crash.
Review URL: http://codereview.chromium.org/7358007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=nkostylev@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7372004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use Widget API to get FocusManager for native_view/window.
Move FocusNatieView to native widget impl.
This is necessary for NativeWidgetX
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7351008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create InputMethod object per Top level NativeWidgetView
- use MockInputMethod when IBUS is not available for now.
Call OnNativeWidgetActivationChanged when activation changed.
Handle InputFocus change when activation changed. This is temp solution until we have WM in place.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7353009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7315007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use this new observation technique to avoid a crash in views-desktop when the
active widget is closed.
BUG=none
TEST=Run views_desktop, close a window, click, it doesn't crash!
Review URL: http://codereview.chromium.org/7342015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=85417
TEST=Open webgl sample as indicated in bug, move mouse over tab strip and confirm that the tab contents do not freeze.
Review URL: http://codereview.chromium.org/7329031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gets mouse capture to work for menus with pure views. As part of this
I moved what was in menu_host_gtk into native_widget_gtk. Gtk supports
two grab types, both mouse and key. We only want key grab when showing
menus.
BUG=none
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/7354006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/7352001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
implementation.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7353007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of this
I moved what was in menu_host_gtk into native_widget_gtk. Gtk supports
two grab types, both mouse and key. We only want key grab when showing
menus.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7346003
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/7350008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I moved what was in menu_host_gtk into native_widget_gtk. Gtk supports
two grab types, both mouse and key. We only want key grab when showing
menus.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7346003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NativeWidgetView was owned by the view hierarchy which complicated the ownership of NativeWidgetViews since it would try to delete NativeWidgetViews from its destructor.
NativeWidgetView has been changed to schedule a close when it is removed from its containing hierarchy. This may be problematic for reparenting but should do for now. We will need to finesse the add/remove API to correct this type of issue.
NativeWidgetViews has been hardened in a few places that assumed they could reach up to a parent widget, even after the widget had been removed from its parent.
BUG=none
TEST=attached unittests should all pass for realz (verified in debugger, can be verified on linux views trybots too).
Review URL: http://codereview.chromium.org/7348011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 92074 - Revert 92071 - Fix a chrome browser crash which occurs when displaying the page info bubble in a ChromeFrame page.
The crash occurs while dereferencing a NULL NonClientView member in the widget code. This member
is only instantiated if the widget is of type InitParams::TYPE_WINDOW.
ChromeFrame always instantiates as a popup window and hence this member is always NULL.
Fix is to add a NULL check at the relevant places in the widget code.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=88960
BUG=88960
Review URL: http://codereview.chromium.org/7301028
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/7258008
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/7340007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
page info bubble in a ChromeFrame page.
The crash occurs while dereferencing a NULL NonClientView member in the widget code. This member
is only instantiated if the widget is of type InitParams::TYPE_WINDOW.
ChromeFrame always instantiates as a popup window and hence this member is always NULL.
Fix is to add a NULL check at the relevant places in the widget code.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=88960
BUG=88960
Review URL: http://codereview.chromium.org/7301028
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/7258008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in a ChromeFrame page.
The crash occurs while dereferencing a NULL NonClientView member in the widget code. This member
is only instantiated if the widget is of type InitParams::TYPE_WINDOW.
ChromeFrame always instantiates as a popup window and hence this member is always NULL.
Fix is to add a NULL check at the relevant places in the widget code.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=88960
BUG=88960
Review URL: http://codereview.chromium.org/7301028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=88716
TEST=none
Review URL: http://codereview.chromium.org/7331021
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/7340002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=88716
TEST=none
Review URL: http://codereview.chromium.org/7331021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
debug builds only if the clear is not done. Weird, since I was able to see glass when I tested this earlier.
Also converts one GetNativeView() check to native_widget() since they are now equivalent.
BUG=none
TEST=win7, glass mode, debug build, browser frame should not be green
TBR=sky
Review URL: http://codereview.chromium.org/7338002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:85585
TEST=run views_examples
Review URL: http://codereview.chromium.org/7237064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
environment.
Also removes the unnecessary clear from RootView since this is interfering with transparent Widgets.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7237040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CreateRenderWidgetHostView would delete the old RenderWidgetHostView.
Also fixes compile error in views_unittests.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7329027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a bug of hide key where the keyboard does now show up after the hide key is
pressed while Omnibox has the focus and Omnibox is touched.
I changed the way of retrieving the text input type to use
InputMethod::GetTextInputType rather than TextInputClient::GetTextInputType
because NULL is always set to touch_pressed_handler when omnibox is touched.
I also added code to check the touch event type so that the notification is sent
only when text element is touched.
BUG=none
TEST=manually
Review URL: http://codereview.chromium.org/7324029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
what windows does.
BUG=56650
TEST=press alt and release, focus should be on the wrench. press
space, make sure the window menu appears, not the wrench menu.
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7237032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
independent of any tfarina-induced bustage.
BUG=none
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/7313027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
level Window in the views desktop world.
Adds the beginning of a set of tests for this behavior.
Also fixes the leaks associated with destruction of NativeWidgetViews, and adds a moderately comprehensive set of tests for Widget ownership.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7273084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The previous implementation used to poll the environment for the window size every drawing cycle. On Linux this is an expensive operation because it requires a round trip to the X server. This CL pushes window size change to the compositor.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7212028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7280002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Basically having TOUCH_UI => pure-views exposed an issue when pure-views are enabled and deskop is not. Not that this last issue is fixed we can revert that workaround.
TBR=sky@chromium.org
BUG=none
TEST=TouchUi tests
Review URL: http://codereview.chromium.org/7294008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GTK sends fake enter/leave event when window activation changes.
This event has (0,0) coordinates, which confuses NativeWidgetGtk::TransformEvent
and ViewportWidget::OnMouseExited.
This is a dirty hack to deal with gtk's fake events. This will be
solved properly in NativeWidgetX + pure views.
BUG=none
TEST=click menu on notification. menu button on the notification shouldn't disappar
and does not cause gtk warning.
Review URL: http://codereview.chromium.org/7282020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7285007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ultimate goal is to eliminate TOOLKIT_USES_GTK. Once that migration is completed, TOOLKIT_VIEWS + OS_LINUX should be enough.
Until this happens, we need a binary that:
1) has both gtk and pure-views
2) can enable pure views components with --use-pure-views when possible (this is default in touchui=1).
If we could switch everything with --use-pure-views, that'd be nice, but the world is not perfect and there are things that cannot co-exist (such as message pump). For such component, we'll use GYP_DEFINES to switch.
1) TOOLKIT_USES_PURE_VIEWS is defined with toolkit_pure_views=1.
2) all (or most of) chrome features must be functional with toolkit_pure_views=1
3) both TOOLKIT_USES_GTK and TOOLKIT_USES_PURE_VIEWS are defined. The latter has higher priority (that is, if implementation can't co-exists, TOOLKIT_USE_PURE_VIEWS will take precedence).
4) As the migration proceeds, there will be less TOOLKIT_USES_GTK and more TOOLKIT_USES_PURE_VIEWS.
5) Once the migration is complete (that is, there is no TOOKIT_USES_GTK), we can remove TOOLKIT_USES_PURE_VIEWS or replace it with OS_LINUX when necessary.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7273079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
NativeWidgetView. This is why menu wasn't showing.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7248032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7282001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Eliminates leaks from NativeWidgetTest.*. Adds additional test target to valgrind wrapper script. Refactors native_widget_test_utils_{gtk|win}.cc to avoid duplication.
BUG=87805
TEST=tools/valgrind/chrome_tests.sh views --gtest_filter=NativeWidgetTest.*
Review URL: http://codereview.chromium.org/7272044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7253058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6982062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
rendering issues I believe.
Moves IsMouseButtonDown to a static method on Widget that is implemented by each platform. It needs to be static as it can be called before the NativeWidget is fully initialized, and does not depend on any NativeWidget state.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7253018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, make sure the touch_pressed_handler_ is the view being removed before resetting it to NULL.
BUG=none
TEST=things compile and existing tests continue to pass
Review URL: http://codereview.chromium.org/7276002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manually
Review URL: http://codereview.chromium.org/7244002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on top of the RootView using a transient decorator.
BUG=none.
TEST=none.
Review URL: http://codereview.chromium.org/7115001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/7170018/ causes this problem.
In CL 7170018, it will not create the input method until it
is requested by a child view. So in that time, a child view
may already be focused. So we need sync focus state with
input method.
BUG=Virtual keyboard does not work on Login screen
TEST=Seaboard
Review URL: http://codereview.chromium.org/7222007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90540 0039d316-1c4b-4281-b951-d872f2087c98
|