summaryrefslogtreecommitdiffstats
path: root/views/window
Commit message (Collapse)AuthorAgeFilesLines
* Add focused property to chrome.windows.create extension API.jennb@chromium.org2011-03-285-2/+24
| | | | | | | | | | | Add BrowserWindow::ShowInactive. BUG=None TEST=Added api test. Also tested manually on CR-48. Review URL: http://codereview.chromium.org/6688036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79620 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Add CreateParams to Widget, and replace CreatePopupWidget with CreateParams.ben@chromium.org2011-03-214-5/+12
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6712008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78893 0039d316-1c4b-4281-b951-d872f2087c98
* Fix window activation when closing a modal dialog box. It turns out ↵ben@chromium.org2011-03-162-12/+21
| | | | | | | | | | | | GetForegroundWindow() returns a different value when it's called from WM_DESTROY vs. WM_CLOSE. We need to do activation restoration earlier than WM_DESTROY. http://crbug.com/75610 TEST=see bug TBR=sky Review URL: http://codereview.chromium.org/6670054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78420 0039d316-1c4b-4281-b951-d872f2087c98
* Re-lands:ben@chromium.org2011-03-161-1/+1
| | | | | | | | | | | | Add native capture API to Widget, and fix a bug in Window where we wouldn't let the window be closed from the X. BUG=72040 TEST=none R=sky Review URL: http://codereview.chromium.org/6670049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78394 0039d316-1c4b-4281-b951-d872f2087c98
* Fix closing the window by clicking the X.ben@chromium.org2011-03-161-11/+1
| | | | | | | | | | | I'm splitting this change out from my earlier CL because it's a more serious regression and I am still solving the capture issues separately. http://crbug.com/76144 TEST=see bug TBR=sky Review URL: http://codereview.chromium.org/6677081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78387 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 78222 - Add native capture API to Widget, and fix a bug in Window ↵ben@chromium.org2011-03-151-2/+12
| | | | | | | | | | | | | | | where we wouldn't let the window be closed from the X. BUG=72040 TEST=none TBR=sky Review URL: http://codereview.chromium.org/6697016 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/6695028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78241 0039d316-1c4b-4281-b951-d872f2087c98
* Add native capture API to Widget, and fix a bug in Window where we wouldn't ↵ben@chromium.org2011-03-151-12/+2
| | | | | | | | | | | | let the window be closed from the X. BUG=72040 TEST=none TBR=sky Review URL: http://codereview.chromium.org/6697016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78222 0039d316-1c4b-4281-b951-d872f2087c98
* These files missed the last checkinben@chromium.org2011-03-151-8/+8
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78131 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 78062 with some NULL checks.ben@chromium.org2011-03-148-19/+70
| | | | | | | | | Revert 78062 - Migrate more of BrowserFrame's event handling down into WindowWin/WidgetWin and their delegate interfaces. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6683007 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/6686059 Review URL: http://codereview.chromium.org/6677029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78129 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 78062 - Migrate more of BrowserFrame's event handling down into ↵ben@chromium.org2011-03-149-75/+27
| | | | | | | | | | | | | | WindowWin/WidgetWin and their delegate interfaces. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6683007 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/6686059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78093 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate more of BrowserFrame's event handling down into WindowWin/WidgetWin ↵ben@chromium.org2011-03-149-27/+75
| | | | | | | | | | | and their delegate interfaces. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6683007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78062 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang build (tested on trybots this time!).dmazzoni@chromium.org2011-03-145-8/+10
| | | | | | | | | | | | | | | | | | | | | Move AccessibleViewState constructor into a .cc file. Add dependency on ui/base to views_unittests so that it actually compiles source files in ui/base. Rename WindowDelegate::GetAccessibleState to WindowDelegate::GetAccessibleWindowState so that it doesn't conflict with View::GetAccessibleState in BrowserView, which inherits from both. This was a real bug, introduced recently because both GetAccessibleState methods were renamed from previous non-conflicting method names. BUG=none TEST=none Review URL: http://codereview.chromium.org/6691009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78052 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 78040 - Fix clang build. (Made things worse...)dmazzoni@chromium.org2011-03-145-10/+8
| | | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6685053 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/6686048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78041 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang build.dmazzoni@chromium.org2011-03-145-8/+10
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6685053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78040 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land: Refactor Views accessibility.dmazzoni@chromium.org2011-03-1414-41/+57
| | | | | | | | | BUG=74988 TEST=none Review URL: http://codereview.chromium.org/6581010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78006 0039d316-1c4b-4281-b951-d872f2087c98
* Add Activation support to WindowDelegate.ben@chromium.org2011-03-119-5/+37
| | | | | | | | | | | | | WindowDelegate now sports two additional methods: CanActivate() and OnWindowActivated(). Converts BrowserView to implement these methods instead of requiring BrowserFrame to override WindowWin methods to handle activation events. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6679002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77848 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: Make BrowserFrame concrete, create NativeBrowserFrame and ↵ben@chromium.org2011-03-113-0/+16
| | | | | | | | | | | NativeBrowserFrameDelegate. BUG=72040 TEST=none TBR=sky git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77789 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 77773 and 77774.ben@chromium.org2011-03-113-16/+0
| | | | | | | | BUG=none TBR=sky git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77776 0039d316-1c4b-4281-b951-d872f2087c98
* Make BrowserFrame concrete, create NativeBrowserFrame and ↵ben@chromium.org2011-03-113-0/+16
| | | | | | | | | | | | NativeBrowserFrameDelegate. BUG=72040 TEST=none TBR=sky Review URL: http://codereview.chromium.org/6677003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77773 0039d316-1c4b-4281-b951-d872f2087c98
* Remove broken (and previously unused) OnMouseLeave overrides.msw@chromium.org2011-03-102-31/+0
| | | | | | | | | | | | | Both WindowWin and TabContentsViewWin had incorrect signatures to override WidgetWin::OnMouseLeave. crrev.com/77221 mistakenly 'fixed' WindowWin::OnMouseLeave to actually override that of WidgetWin. In this CL, remove the broken and previously unused overrides; add OVERRIDE keywords liberally. BUG=75334,75367 TEST=repro and similar mouse interaction. Review URL: http://codereview.chromium.org/6646053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77716 0039d316-1c4b-4281-b951-d872f2087c98
* Build out NativeWindow interface for Window method pass-thrus.ben@chromium.org2011-03-109-424/+443
| | | | | | | | | | BUG=72040 TEST=none TBR=sky Review URL: http://codereview.chromium.org/6659035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77671 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate more into Window.ben@chromium.org2011-03-098-212/+252
| | | | | | | | | | | - various window attributes BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6661003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77538 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate more into Window:ben@chromium.org2011-03-0914-90/+115
| | | | | | | | | | | | - inactive rendering disabling tracking - window icon updating BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6650031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77497 0039d316-1c4b-4281-b951-d872f2087c98
* This will help minimize the area we paint various views, including ↵davemoore@chromium.org2011-03-094-14/+15
| | | | | | | | | | | | | | | | | BrowserView in cros. Before the default when a child's preferred view size changed was to propagate it up and paint everything from the rootview down. This will limit the area to the parts that actually changed size. I expect we may find things that aren't being painted because they were assuming the behavior of Layout(). We should fix this as necessary. Also, a subsequent change will minimize our calls to SchedulePaint(). We frequently do it when we don't need to. BUG=None TEST=ViewTest.SetBoundsPaint Review URL: http://codereview.chromium.org/6531032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77481 0039d316-1c4b-4281-b951-d872f2087c98
* Update OnMouseActivate override signatures.msw@chromium.org2011-03-091-14/+23
| | | | | | | | | | | | Add OVERRIDE keyword liberally to some relevant overrides. Fix copyright dates. BUG=75366 TEST=Omnibox clicking, etc. Review URL: http://codereview.chromium.org/6648018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77431 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang build by renaming method ShowWindow()ben@chromium.org2011-03-096-7/+8
| | | | | | | | | BUG=72040 TEST=none TBR=thakis Review URL: http://codereview.chromium.org/6652016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77424 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate window showing into Window base class.ben@chromium.org2011-03-099-305/+313
| | | | | | | | | | | NativeWindow gets methods to update accessible state, title, Center and Show. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6647004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77421 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate some more stuff in Window. PreferredSize obtaining.ben@chromium.org2011-03-086-23/+31
| | | | | | | | | | | Move GetShowState to BrowserFrameWin rather than needlessly delegate to BrowserView. This removes a small amount of WIndows-specific code from BrowserView. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6627079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77306 0039d316-1c4b-4281-b951-d872f2087c98
* Add new MouseEvent ctors; update WidgetWin & WindowWin usage.msw@chromium.org2011-03-082-132/+125
| | | | | | | | | BUG=72040 TEST=Manual mouse event testing. Review URL: http://codereview.chromium.org/6591120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77221 0039d316-1c4b-4281-b951-d872f2087c98
* Move WindowDelegate and NonClientView creation and management to Window.ben@chromium.org2011-03-0714-184/+182
| | | | | | | | | | | This makes WindowGtk/WindowWin a little uglier for now, will improve with consolidation of more functions into Window. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6621033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77194 0039d316-1c4b-4281-b951-d872f2087c98
* Make Window class concrete (mostly).ben@chromium.org2011-03-058-40/+258
| | | | | | | | | | | | Create NativeWindow/NativeWindowDelegate interfaces. BUG=72040 TEST=none TBR=sky Review URL: http://codereview.chromium.org/6626036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77006 0039d316-1c4b-4281-b951-d872f2087c98
* Do all OOLing in the views code. linux_views now builds clean with the clang ↵erg@google.com2011-03-0414-75/+181
| | | | | | | | | | | plugin. BUG=carnitas TEST=compiles Review URL: http://codereview.chromium.org/6622002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76992 0039d316-1c4b-4281-b951-d872f2087c98
* Two things:ben@chromium.org2011-03-042-22/+1
| | | | | | | | | | | | - simplify root view sizing. - move focus manager creation/management to Widget BUG=72040 TEST=existing unittests Review URL: http://codereview.chromium.org/6609026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76963 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Window::SetBounds to SetWindowBounds, to uncofuse overrides.thakis@chromium.org2011-03-045-13/+13
| | | | | | | | | | BUG=70465,72205 TEST=none TBR=ben Review URL: http://codereview.chromium.org/6624011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76953 0039d316-1c4b-4281-b951-d872f2087c98
* Remove WindowGtk::Init() to InitWindow().thakis@chromium.org2011-03-042-3/+3
| | | | | | | | | | | | | This makes it clear that this is not an intended override of WidgetGtk::Init(). No intended functionality change. BUG=70465,72205 TEST=none TBR=ben git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76881 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 76825 - Refactor Views accessibility.jcivelli@chromium.org2011-03-047-48/+30
| | | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6581010 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/6612035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76844 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor Views accessibility.dmazzoni@chromium.org2011-03-037-30/+48
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6581010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76825 0039d316-1c4b-4281-b951-d872f2087c98
* Replace Widget::GetBounds with Widget::GetClientScreenBounds and ↵ben@chromium.org2011-03-032-6/+2
| | | | | | | | | | | GetWindowScreenBounds BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6615016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76759 0039d316-1c4b-4281-b951-d872f2087c98
* Convert some windows code to use the new Widget methods.ben@chromium.org2011-03-031-9/+5
| | | | | | | | | | | Continuation of: Land the new functions added by 76483 - but do not use them anywhere outside of their tests. This will help me incrementally re-deploy these functions and identify what is causing the buildbot test redness. BUG=72040 TEST=none TBR=sky (all code originally reviewed here: http://codereview.chromium.org/6598069/ ) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76703 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of most of the old method uses from WidgetGtk. I think this is safe.ben@chromium.org2011-03-031-1/+2
| | | | | | | | | | | | | Continuation of: Land the new functions added by 76483 - but do not use them anywhere outside of their tests. This will help me incrementally re-deploy these functions and identify what is causing the buildbot test redness. BUG=72040 TEST=none TBR=sky (all code originally reviewed here: http://codereview.chromium.org/6598069/ ) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76698 0039d316-1c4b-4281-b951-d872f2087c98
* Dont update title window for chromeososhima@google.com2011-03-021-1/+5
| | | | | | | | | | | Chromeos doesn't use them, but this takes 10ms to update the title string BUG=chromium-os:8632 TEST=none Review URL: http://codereview.chromium.org/6574054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76548 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting to fix builder redness. Please fix and reland.ananta@chromium.org2011-03-022-7/+10
| | | | | | | | | | | | | | Revert 76483 - Remove/replace RootView/Widget getters with new NativeWidget getters. BUG=72040 TEST=existing unittests. Review URL: http://codereview.chromium.org/6598069 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/6597099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76508 0039d316-1c4b-4281-b951-d872f2087c98
* Remove/replace RootView/Widget getters with new NativeWidget getters.ben@chromium.org2011-03-022-10/+7
| | | | | | | | | BUG=72040 TEST=existing unittests. Review URL: http://codereview.chromium.org/6598069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76483 0039d316-1c4b-4281-b951-d872f2087c98
* Use GetEventHandlerForPoint instead of GetViewForPoint.sadrul@chromium.org2011-02-252-4/+4
| | | | | | | | | BUG=74121 TEST=none Review URL: http://codereview.chromium.org/6575050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76102 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more direct uses of RootView to Widget.ben@chromium.org2011-02-242-2/+2
| | | | | | | | | | | | | | | | | | The idea is to remove RootView from the public API of Views and eventually move it into the internal namespace. It is really an implementation detail of event propagation into a view hierarchy. Anyone that calls GetRootView() and does something that isn't a View method should be calling that method on the Widget instead... e.g. instead of calling GetRootView()->NotifyThemeChanged(), call GetWidget()->ThemeChanged(). The RootView is a focus traversable, which is fine, but calling code should call GetWidget()->GetFocusTraversable() to obtain it, rather than knowing RootView is-a focus traversable and just calling GetRootView(). This also changes FocusManager::ContainsView to be simpler and cross platform. Since there is one FocusManager per view hierarchy (attached to the toplevel Widget), getting the view's focus manager and comparing it to the current focus manager is a sufficient test. BUG=72040 TEST=existing unittests, none Review URL: http://codereview.chromium.org/6577017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75940 0039d316-1c4b-4281-b951-d872f2087c98
* Dramatically simplify view painting by getting rid of RootView's redundant ↵ben@chromium.org2011-02-231-116/+5
| | | | | | | | knowledge of invalid rects.The OS is capable of doing this for us (see: InvalidateRect, etc.), so we should just defer to it.I was also able to remove all of the custom logic in WindowWin::OnNCPaint and replace it with a simple SetMsgHandled check.http://crbug.com/72040TEST=none Review URL: http://codereview.chromium.org/6469096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75758 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 75347 - Revert 75306 - Force native frames to repaint when ↵mirandac@chromium.org2011-02-181-12/+11
| | | | | | | | | | | | | | | | | | | OnNCActivate is called. With a profile menu button added to the GlassBrowserFrameView, failure to trigger the frame repaint means that the button will remain in the active state even when the frame has been deactivated. DesktopNotification tests failing on win full - speculative revert since this is the only CL in the range that seems possibly related. BUG=none TEST=frames behave normally in Aero mode, when activated and deactivated. Review URL: http://codereview.chromium.org/6507044 TBR=mirandac@chromium.org Review URL: http://codereview.chromium.org/6546006 TBR=mattm@chromium.org Review URL: http://codereview.chromium.org/6541023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75389 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 75306 - Force native frames to repaint when OnNCActivate is called. ↵mattm@chromium.org2011-02-181-11/+12
| | | | | | | | | | | | | | | | With a profile menu button added to the GlassBrowserFrameView, failure to trigger the frame repaint means that the button will remain in the active state even when the frame has been deactivated. DesktopNotification tests failing on win full - speculative revert since this is the only CL in the range that seems possibly related. BUG=none TEST=frames behave normally in Aero mode, when activated and deactivated. Review URL: http://codereview.chromium.org/6507044 TBR=mirandac@chromium.org Review URL: http://codereview.chromium.org/6546006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75347 0039d316-1c4b-4281-b951-d872f2087c98
* Force native frames to repaint when OnNCActivate is called. With a profile ↵mirandac@chromium.org2011-02-171-12/+11
| | | | | | | | | | | menu button added to the GlassBrowserFrameView, failure to trigger the frame repaint means that the button will remain in the active state even when the frame has been deactivated. BUG=none TEST=frames behave normally in Aero mode, when activated and deactivated. Review URL: http://codereview.chromium.org/6507044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75306 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-20 23:10:02 +0000