summaryrefslogtreecommitdiffstats
path: root/views/window
Commit message (Collapse)AuthorAgeFilesLines
* Add newline to EOF to fix CrOS builder.glen@chromium.org2010-04-091-1/+1
| | | | | | | | | TBR=sky BUG=NONE TEST=NONE git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44117 0039d316-1c4b-4281-b951-d872f2087c98
* Make the bottom edges of the opaque frame rounded.glen@chromium.org2010-04-093-18/+69
| | | | | | | | | BUG=40024 TEST=On a non-AeroGlass Windows machine, verify that the bottom edges of the Window are rounded. Review URL: http://codereview.chromium.org/1560021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44115 0039d316-1c4b-4281-b951-d872f2087c98
* Fix client edge insets for fullscreen mode. we were incorrectly insetting ↵ben@chromium.org2010-04-091-3/+4
| | | | | | | | | | | | | | the client area in fullscreen mode even though there are no non-client edges in fullscreen mode. This involves: 1. adding a check for IsFullscreen to the BrowserFrameWin code that calculates the client area insets for fullscreen state, just as it currently checks for maximized state. 2. bypass the WindowWin's sanity check for default insets in the Fullscreen case - in fullscreen mode the window should have zero non-client, not default restored non-client. http://crbug.com/37588 http://crbug.com/39076 Review URL: http://codereview.chromium.org/1618009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44029 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate a lot of duplicated implementations of Get/SetAccessibleName() by ↵pkasting@chromium.org2010-04-032-14/+0
| | | | | | | | | | just putting it on the base class. Also cleans up a couple other misc. accessibility functions in view.h. BUG=none TEST=none Review URL: http://codereview.chromium.org/1512012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43558 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-311-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43216 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting this CL to fix the interactive ui test failures.ananta@chromium.org2010-03-261-9/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert 42498 - Keyboard accessibility for the page and app menus. Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/1428001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42779 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-241-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42498 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42465 - Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-241-9/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reverting because newly added Test*MenuKeyboardAccess tests fail on some of the Windows buildbots, and possibly a XP Perf regression. Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/1257003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42468 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-241-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42465 0039d316-1c4b-4281-b951-d872f2087c98
* views: [accessibility] Add accessible names for Minimize, Maximize, Restore ↵ctguil@chromium.org2010-03-231-0/+6
| | | | | | | | | | | | | buttons in the top right corner of the Window. BUG=9614 TEST=TEST=open AccExplorer, open the main chrome window, point it to one of the three buttons in the top-right corner, see if it shows the correct accessible names for each one. Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1076009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42349 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/gfx/canvas and app/gfx/font to gfx/.ben@chromium.org2010-03-235-8/+8
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1132006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42312 0039d316-1c4b-4281-b951-d872f2087c98
* views: [accessibility] Add accessible name for the Close button in generic ↵ctguil@chromium.org2010-03-221-1/+5
| | | | | | | | | | | | Window. BUG=9614 TEST=open AccExplorer, open a dialog window, point it to the Close button in the top-right corner, see if it shows Close as the accessible name. Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1155005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42270 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Keyboard accessibility for the page and app menus.", rev 42234 and ↵maruel@chromium.org2010-03-221-9/+0
| | | | | | | | | | 42236. TBR=dmazzoni Review URL: http://codereview.chromium.org/1158004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42239 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-221-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42234 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r41641 "Make DevTools open docked by default..."xiyuan@chromium.org2010-03-222-3/+3
| | | | | | | | | | | | | | - Fix DevToolsSanityTest time out. The timeout is because the tests wait for Browser closed notification. However, docked DevTools does not have its own Browser object and hence the wait times out. BUG=none TEST=none Review URL: http://codereview.chromium.org/1025005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42226 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Keyboard accessibility for the page and app menus."maruel@chromium.org2010-03-221-9/+0
| | | | | | | | | | This reverts commit 42217. TBR=dmzazzoni Review URL: http://codereview.chromium.org/1154003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42218 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-221-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42217 0039d316-1c4b-4281-b951-d872f2087c98
* Move RTL related functions from app/l10n_util to base/i18n/rtlben@chromium.org2010-03-202-3/+5
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1073005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42182 0039d316-1c4b-4281-b951-d872f2087c98
* Move more files to toplevel gfx.ben@chromium.org2010-03-191-2/+3
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42071 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41882 - [Accessibility] Chrome's main window is missing an accessible ↵ctguil@chromium.org2010-03-171-3/+0
| | | | | | | | | | | | | | | | name checkdeps.py failed BUG=36732 TEST=Verify Chrome's main window has a name in AccExplorer or run the new test. Review URL: http://codereview.chromium.org/661054 TBR=ctguil@chromium.org Review URL: http://codereview.chromium.org/1063004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41885 0039d316-1c4b-4281-b951-d872f2087c98
* [Accessibility] Chrome's main window is missing an accessible namectguil@chromium.org2010-03-171-0/+3
| | | | | | | | | BUG=36732 TEST=Verify Chrome's main window has a name in AccExplorer or run the new test. Review URL: http://codereview.chromium.org/661054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41882 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more files to toplevel gfx dir.ben@chromium.org2010-03-174-4/+4
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41812 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Make DevTools open docked by default for chrome os."tony@chromium.org2010-03-162-3/+3
| | | | | | | | | | | This reverts commit r41641 because all the devtools interactive_ui_tests are failing. TBR=xiyuan Review URL: http://codereview.chromium.org/1007004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41691 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk views code touch upxiyuan@chromium.org2010-03-161-6/+14
| | | | | | | | | | | | | | | | | - Fix wrong mouse event coordinates in gtk event handlers. Gtk events could be propogate to parent if child does not handle it and we need to translate the coordinates in gtk event in this case; - Consume button pressed event if a widget is not transparent; - Move mouse cursor reset handling on mouse leave from WindowGtk into RootView. This is because once WindowGtk set a mouse cursor, it stucks there and RootView could not change it. BUG=None TEST=Verify the following two cases: 1. Click on top of a tab should not move chrome; 2. Dock devtools and mouse cursor should change correct on the split and change back to left pointer on leave the split; Review URL: http://codereview.chromium.org/997002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41681 0039d316-1c4b-4281-b951-d872f2087c98
* Make DevTools open docked by default for chrome os.xiyuan@chromium.org2010-03-152-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | - Change prefs::kDevToolsOpenDocked default to "true" for chrome os; - Fix a problem on chrome os that DevTools occupies the whole client area. This is because BrowserView::Show is called before gtk size allocated event and thus divider offset is calculated wrongly to 0. The fix is to move the "restore split offset" logic to UpdateDevToolsForContents before we do contents_split_ layout for show up DevTools; - Fix a problem that DevTools becomes invisible after undock then dock for linux toolkit_view/chromeos build. This is because browser/views/tab_contents/TabContentsViewGtk does not show/hide its contained TabContents like TabContentsViewWin. As mentioned in BrowserWindowGtk::UpdateDevToolsForContents, the fix is to hook up gtk show/hide signal and notify the contained TabContents about the visibility change. After the fix, remove the manual ShowContents for DevTools in BrowserWindowGtk::UpdateDevToolsForContents. <http://crosbug.com/333> BUG=333 TEST=Verify that DevTools show up as docked by default. Review URL: http://codereview.chromium.org/880003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41641 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/gfx contents to gfx/ben@chromium.org2010-03-142-5/+5
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41559 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-141-0/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/851010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41539 0039d316-1c4b-4281-b951-d872f2087c98
* Create a toplevel gfx/ dir and seed it with icon_util.ben@chromium.org2010-03-131-1/+1
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/915002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41528 0039d316-1c4b-4281-b951-d872f2087c98
* Last set of tweaks to icon positioning code. Clarifies positioning ↵pkasting@chromium.org2010-03-121-32/+21
| | | | | | | | | | algorithm, and for non-Windows, modifies sizing algorithm to just make the icon size be the same as the titlebar font size, minimum 16 px, since the old crazy code just seemed wrong. BUG=none TEST=none Review URL: http://codereview.chromium.org/807001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41382 0039d316-1c4b-4281-b951-d872f2087c98
* views: Make WindowGtk set transient-for hint before mapping.derat@chromium.org2010-03-091-3/+3
| | | | | | | | | | | | | | | Otherwise, there's a race as to whether the hint will be set when the window manager handles the window's MapNotify event. (The Chrome OS window manager currently ignores any attempts by clients to change transient-for hints on windows that have already been mapped, for instance.) BUG=chromium-os:1587 TEST=seems to work Review URL: http://codereview.chromium.org/686001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41036 0039d316-1c4b-4281-b951-d872f2087c98
* Use web app icon as ICON_BIG for Windowsxiyuan@chromium.org2010-03-083-1/+15
| | | | | | | | | | | | | | | | | - Add a WindowDelegate::GetWindowAppIcon for BrowserView to expose an icon to use as ICON_BIG; - Add an app_icon_ memeber and accessor functions to TabContents; - Update/Set the app_icon_ of TabContents when web app icon is downloaded for converting a tab to app or for chrome web app shortcuts update (this happens when chrome is opened as an app; - Use the app icon as ICON_BIG in WindowWin::UpdateWindowIcon; BUG=32039 TEST=Verify fix for issue 32039 and also Alt-Tab list on XP/Vista uses big icon. Review URL: http://codereview.chromium.org/668265 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40962 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up/fix more frame code. In general this is bringing the less-common ↵pkasting@chromium.org2010-03-082-142/+141
| | | | | | | | | | | | frame classes up to speed with recent changes in OpaqueBrowserFrameView, but there's also some other fixing of bustage, old patches that didn't make it into all the classes, etc. This isn't perfect yet: the calculations of icon and titlebar size/position for really large icons need to have more padding in them. But this change is already so large I'd rather get it in and then patch that up. BUG=6961 TEST=Sysmenu works on all frame types, app panels can be maximized, all frame types handle larger titlebar sizes and/or fonts Review URL: http://codereview.chromium.org/669291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40950 0039d316-1c4b-4281-b951-d872f2087c98
* Move skia_utils_gtk.cc/.h to app/gfx/. Original patch by Thiago Farina (see ↵pkasting@chromium.org2010-02-261-3/+3
| | | | | | | | | http://codereview.chromium.org/660063 ), r=me. BUG=22853 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40083 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in clear browsing data dialog where throbber would overlapsky@chromium.org2010-02-083-1/+19
| | | | | | | | | | | | flash link. BUG=35009 TEST=bring up clear browsing data, click clear browsing data and make sure throbber doesn't overlap flash link. Review URL: http://codereview.chromium.org/577054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38379 0039d316-1c4b-4281-b951-d872f2087c98
* Rework nonclient hittest plumbing so the NonClientFrameView is responsible ↵pkasting@chromium.org2010-02-064-13/+16
| | | | | | | | | | for the whole window's hit testing. Make use of this in the glass frame to add support for HTSYSMENU. Doing this in the opaque frame will be more complex, so that's coming next. BUG=6961 TEST=Single- and double-clicks on the upper left corner of a Chrome window in Aero glass mode should trigger the system menu and the window closing, respectively. Review URL: http://codereview.chromium.org/573042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38301 0039d316-1c4b-4281-b951-d872f2087c98
* Support app menu and double-click close on upper left corner of window, part ↵pkasting@chromium.org2010-02-058-128/+25
| | | | | | | | | | | | one. This makes things work right for windows that have an icon. The behavior of the main window is unchanged because right now it never returns HTSYSMENU anywhere. Part two of this change will be figuring out how to return that at the right place, which will make things Just Work. BUG=6961 TEST=Open an app or popup window. Single click the icon. The app menu should appear. Close it, then click-and-drag into the app menu. The item you release on should execute. Double-click the icon. The window should close. Review URL: http://codereview.chromium.org/577018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38187 0039d316-1c4b-4281-b951-d872f2087c98
* Adds link to flash settings on clear browser data panel.sky@chromium.org2010-02-043-18/+54
| | | | | | | | | | BUG=none TEST=bring up clear browsing data dialog and make sure it has a link to flash storage settings. Review URL: http://codereview.chromium.org/570030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38148 0039d316-1c4b-4281-b951-d872f2087c98
* Addded notification when ancestor gets changed. So windows that lack focus ↵georgey@chromium.org2010-01-072-11/+57
| | | | | | | | | | | | | manager, because of being created on inactive tab, could do the necessary work when focus manager is actually attached. This is relevant for Windows only, but some support functions (FindAllRootViews) could be useful for other architectures as well. BUG=22481 TEST=in the bug Review URL: http://codereview.chromium.org/492025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35675 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/466002 for Thiago:sky@chromium.org2009-12-042-5/+5
| | | | | | | | | | | Switch a CSize variable (WTL) to use the gfx::Size type. BUG=2186 TEST=compiles Review URL: http://codereview.chromium.org/466039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33877 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/449003/show for Thiago:sky@chromium.org2009-12-011-3/+3
| | | | | | | | | | | | | | views: replace the deprecated macro (DISALLOW_EVIL_CONSTRUCTORS). Use DISALLOW_COPY_AND_ASSIGN instead, also fix some style issues pointed by lint. BUG=none TEST=none Review URL: http://codereview.chromium.org/449075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33500 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash on double clicking in the upper right corner of thesky@chromium.org2009-11-241-4/+6
| | | | | | | | | | | | window. For some reason gtk_window_begin_move_drag crashes when invoked for double/triple clicks. BUG=none TEST=none Review URL: http://codereview.chromium.org/434045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32976 0039d316-1c4b-4281-b951-d872f2087c98
* Landing georgey CL.jcampan@chromium.org2009-11-112-5/+46
| | | | | | | | See http://codereview.chromium.org/384012 Review URL: http://codereview.chromium.org/387028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31717 0039d316-1c4b-4281-b951-d872f2087c98
* Move all the stuff relating to detached tab dragging out of BrowserFrameWin ↵ben@chromium.org2009-11-075-1/+37
| | | | | | | | and onto the TabStrip2 object. It was mostly cross platform anyway.Adds APIs to Widget that:- allow a Widget to be obtained for a given gfx::NativeView- allow native properties to be set on a Widget.Adds an API to Window that lets the caller convert the window's appearance into a lightly transparent transient looking thing for dragging.BUG=noneTEST=none Review URL: http://codereview.chromium.org/149440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31394 0039d316-1c4b-4281-b951-d872f2087c98
* Fix style issues in View class.maruel@chromium.org2009-11-071-1/+1
| | | | | | | | | | | BUG=None TEST=None Patch contributed by thiago.farina@gmail.com Review URL: http://codereview.chromium.org/338011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31360 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at:sky@chromium.org2009-11-042-3/+3
| | | | | | | | | | | | | | | Gets find bar animation/clipping to work on views/gtk. The only difference between this and the first version is fixing an include in extension_host that was triggering mac to build views, as well as an extraneous SetSlideDuration I had used for testing. BUG=none TEST=none TBR=ben Review URL: http://codereview.chromium.org/342116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30942 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 30903 - Gets find bar animation/clipping to work on views/gtk.sky@chromium.org2009-11-042-3/+3
| | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/340077 TBR=sky@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30913 0039d316-1c4b-4281-b951-d872f2087c98
* Gets find bar animation/clipping to work on views/gtk.sky@chromium.org2009-11-042-3/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/340077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30903 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the RootView is sized to the correct bounds when the opaque frame ↵ben@chromium.org2009-10-232-11/+77
| | | | | | | | is maximized.It seems that now, when an opaque frame is maximized we also need to add the SM_CXSIZEFRAME to the top of the client rect. I don't know why, it's just is.I reworked the way Widget allows subclasses to handle sizing of the RootView... I delegate responsibility for determining the RootView's bounds to a helper virtual function which BrowserFrameWin overrides. This seems cleaner to me. I make sure this handling only occurs when the window is not maximized.http://crbug.com/25227TEST=use to a theme or switch off glass on vista or use Xp. Maximize the browser window. The tabs should be entirely visible. Review URL: http://codereview.chromium.org/304007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29882 0039d316-1c4b-4281-b951-d872f2087c98
* Enable System Context Menu for linux views.oshima@chromium.org2009-10-223-7/+21
| | | | | | | | | | | | | | | | * Chagned WindowGtk to pass through right click mouse event for HTCAPTION so that ContextMenuController on Frame/Tab view works. * Added ContetMenuController to NonClientView. * Added "PointIsWithinWindowCaption to BrowserView to exclude chromeos specific components from Caption area. Fix a minor bug in NonClientView * GetViewForPoint was using wrong point. This wasn't causing any issue as the frame_view's origin was (0, 0) BUG=None TEST=run chromeos build and right click frame view and verify that you get system menu. Review URL: http://codereview.chromium.org/303014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29807 0039d316-1c4b-4281-b951-d872f2087c98
* When opening Chrome maximized with an application window alreadyjcampan@chromium.org2009-10-211-1/+1
| | | | | | | | | | | running, the Chrome window was not activated. BUG=19373 TEST=See bug Review URL: http://codereview.chromium.org/308008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29654 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 17:53:22 +0000