summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Move utility method for embedding links in texts from about_chrome_view to a ↵mirandac@chromium.org2010-04-053-0/+244
| | | | | | | | | | | generic class, for future use in other classes. BUG= none TEST= chrome "about" dialog still works the same, in ltr and rtl languages. Review URL: http://codereview.chromium.org/1508018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43634 0039d316-1c4b-4281-b951-d872f2087c98
* BookmarkBarView tests fixesoshima@chromium.org2010-04-051-1/+7
| | | | | | | | | | | | | | * Add BOOKMARK_CONTEXT_MENU_SHOWN notification. On Linux, event handling is asynchronous, but the showing context menu is blocking, so we can't use RunAllPending(). * Convert gtk keycode to Win when checking accelerator. BUG=39736 TEST=none (interactive_ui_tests should pass once enabled it'll be enabled by http://codereview.chromium.org/1576008 Review URL: http://codereview.chromium.org/1545011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43628 0039d316-1c4b-4281-b951-d872f2087c98
* Add options for controlling horizontal and vertical lines in TableView2.satorux@chromium.org2010-04-054-9/+78
| | | | | | | | | | | | | | | | | | | For now, this only works on Linux. Along the way, introduce TableView2::Options, so we can add new options without needing to modify the existing call sites. Additional benefit is that this makes client code more descriptive than having boolean parameters like true, true, false. The original motivation of the change is to get rid of horizontal lines from a table in the language configuration dialog in Chromium OS. TEST=view_examples BUG=crosbug.com/2349 Review URL: http://codereview.chromium.org/1528013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43602 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes leak in boundsanimator.sky@chromium.org2010-04-041-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/1576017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43592 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Regression for Accessible Names appearing as NAMELESS.mhm@chromium.org2010-04-046-22/+2
| | | | | | | | | | | The refactoring in r43558 caused SetAccessibleName and GetAccessibleName to be none virtual causing couple of components not having accessible names since they depend on overriding it. The following change sets the accessible name directly since view now stores it. BUG=40343 TEST=With AccExplorer32 check if accessible names have been resolved. Review URL: http://codereview.chromium.org/1616004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43584 0039d316-1c4b-4281-b951-d872f2087c98
* Changes tab strip to use BoundsAnimator for tab strip animations andsky@chromium.org2010-04-031-5/+5
| | | | | | | | | | | | | | | | adds a new animation when inserting a tab. I've changed the code to make it clear when an index is in terms of the model, and when it is in terms of tab_data_. I may replace using an index for tab data with an actual int wrapper class to avoid mistakes, but I'll do that separately. BUG=27783 TEST=thorougly test all animations in the tab strip, as well as dragging tabs in an out. Review URL: http://codereview.chromium.org/1553008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43582 0039d316-1c4b-4281-b951-d872f2087c98
* Adds 'default' check to profiles, allows opening/closing profile by clicking ↵georgey@chromium.org2010-04-031-1/+2
| | | | | | | | | | on the label BUG=38284,38263 TEST=in the bugs Review URL: http://codereview.chromium.org/1607005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43567 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate a lot of duplicated implementations of Get/SetAccessibleName() by ↵pkasting@chromium.org2010-04-0318-142/+26
| | | | | | | | | | just putting it on the base class. Also cleans up a couple other misc. accessibility functions in view.h. BUG=none TEST=none Review URL: http://codereview.chromium.org/1512012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43558 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the change that was checked in by accident.oshima@chromium.org2010-04-032-17/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1560014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43550 0039d316-1c4b-4281-b951-d872f2087c98
* * WidgetGtk::OnKeyPressed never called on window because the signal handleroshima@chromium.org2010-04-023-12/+76
| | | | | | | | | | | | was connected to the content, but the focus was set to GtkWindow by FocusManager. * Enable IgnoreKeyupForAccelerators for linux. BUG=40140 TEST=IgnoreKeyupForAccelerators shoud pass now on linux. Review URL: http://codereview.chromium.org/1575001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43506 0039d316-1c4b-4281-b951-d872f2087c98
* Adds AnimationContainer, which can be used to group a set ofsky@chromium.org2010-04-012-84/+291
| | | | | | | | | | | | | | | animations to have the same timer. By default each animation has one animationcontainer, but I'm going to change the tab renderer to share the animationcontainer so that the pulse effects happen in unison. Also updated the BoundsAnimator so that I can use it by the TabStrip. BUG=none TEST=none Review URL: http://codereview.chromium.org/1575011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43407 0039d316-1c4b-4281-b951-d872f2087c98
* Fix number of arguments to gtk callback macro.dmazzoni@chromium.org2010-04-012-7/+5
| | | | | | | | | BUG=none TEST=navigating menus using the keyboard no longer crashes. Review URL: http://codereview.chromium.org/1549011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43379 0039d316-1c4b-4281-b951-d872f2087c98
* views: Implement a TODO to test the Accessible Name feature for the ↵ctguil@chromium.org2010-03-311-1/+8
| | | | | | | | | | | | ProgressBar control. BUG=None TEST=out/Debug/unit_tests --gtest_filter=ProgressBarTest.* Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1531001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43267 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-3113-15/+301
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43216 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug that caused single-line labels to be line-wrapped with Views for ↵satorux@chromium.org2010-03-311-1/+7
| | | | | | | | | | | | | Linux. Change Label::GetTextSize() to compute |w| with std::numeric_limits<int>::max() in the single line mode, just like it used to be before r42527. BUG=39799 TEST=Confirmed labels are not line-wrapped in candidate_window with the fix. Review URL: http://codereview.chromium.org/1542005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43200 0039d316-1c4b-4281-b951-d872f2087c98
* Convert Label::GetFont() to unix_hacker style. Original patch by Thiago ↵pkasting@chromium.org2010-03-304-11/+12
| | | | | | | | | | Farina (see http://codereview.chromium.org/1580002 ), r=me. BUG=none TEST=none Review URL: http://codereview.chromium.org/1528009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43136 0039d316-1c4b-4281-b951-d872f2087c98
* [accessibility] Extension toolbar and infobar container views should not ↵ctguil@chromium.org2010-03-303-5/+8
| | | | | | | | | | | | | | | | | | | have state visible if they are not rendered on screen. Add the ROLE_PANE role to viewsaccessibility types. Provide accessible role and name for BrowserActionsContainer, InfoBarContainer, and InfoBar. Set BrowserActionsContainer view visibility to true only when it contains browser actions. Set ExtensionShelf vew visibility to true only when it has non-zero height. BUG=36224 TEST=Verify extension toolbar and infobar container accessibility info within AccExplore32.exe Review URL: http://codereview.chromium.org/669275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43044 0039d316-1c4b-4281-b951-d872f2087c98
* views: [accessibility] Add support for GetAccessibleValue in the combobox ↵ctguil@chromium.org2010-03-302-0/+8
| | | | | | | | | | | | | control. BUG=9614 TEST=open AccExplorer, open Report broken website dialog, point AccExplorer to the combobox, see if the string value contained in the 'Bug type'combobox is the currently selected on it. Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1521001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43039 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some TODOs. Original patch by Thiago Farina (see ↵pkasting@chromium.org2010-03-293-23/+20
| | | | | | | | | http://codereview.chromium.org/1523001 ), r=me. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42966 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix view_examples shared build by adding allocator dependency.craig.schlenter@chromium.org2010-03-291-7/+9
| | | | | | | | | | | Also clean up tabs and remove unnecessary duplicated dependency. TEST=compile with gcc 4.4, library=shared_library and toolkit_views=1 BUG=none Review URL: http://codereview.chromium.org/1519002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42948 0039d316-1c4b-4281-b951-d872f2087c98
* views: [accessibility] Add support for Accessibility Value.ctguil@chromium.org2010-03-265-10/+60
| | | | | | | | | | BUG=9604 TEST=point AccExplorer to Edit Bookmark dialog, see if everything has a MSAA information, like: Name, Role, State, Value. Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/928001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42831 0039d316-1c4b-4281-b951-d872f2087c98
* Re-apply r42703 which was reverted because of a conflict with another patch ↵estade@chromium.org2010-03-262-9/+9
| | | | | | | | | | | | | | | | | that was being reverted: TBR=ananta Views: fix a crash where in the browser actions container. This crash didn't actually affect linux/views (for some reason the RunContextMenu() call seems to never return). BUG=38964 TEST=crash an extension while the context menu for it is showing. original review: http://codereview.chromium.org/1237004/show Review URL: http://codereview.chromium.org/1449001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42813 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compiler warnings.chocobo@chromium.org2010-03-261-4/+4
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/1349005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42785 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting this CL to fix the interactive ui test failures.ananta@chromium.org2010-03-2613-305/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert 42498 - Keyboard accessibility for the page and app menus. Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/1428001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42779 0039d316-1c4b-4281-b951-d872f2087c98
* estade:- This revert is to fix interactive ui test failures which have been ↵ananta@chromium.org2010-03-262-16/+19
| | | | | | | | | | | | | | | | | | | | | broken since Wednesday. Your CL is not at fault though. 42498 seems to be the culprit. I had to revert your CL as it leads to conflicts while reverting 42498 Revert 42703 - Views: fix a crash where in the browser actions container. This crash didn't actually affect linux/views (for some reason the RunContextMenu() call seems to never return). BUG=38964 TEST=crash an extension while the context menu for it is showing. Review URL: http://codereview.chromium.org/1237004 TBR=estade@chromium.org Review URL: http://codereview.chromium.org/1423002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42778 0039d316-1c4b-4281-b951-d872f2087c98
* Added unit test for the views::ProgressBar::AddProgress method.denisromanov@chromium.org2010-03-261-0/+11
| | | | | | | | | BUG=37960 TEST=Run unit_tests. Review URL: http://codereview.chromium.org/1216007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42731 0039d316-1c4b-4281-b951-d872f2087c98
* Views: fix a crash where in the browser actions container.estade@chromium.org2010-03-262-19/+16
| | | | | | | | | | | This crash didn't actually affect linux/views (for some reason the RunContextMenu() call seems to never return). BUG=38964 TEST=crash an extension while the context menu for it is showing. Review URL: http://codereview.chromium.org/1237004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42703 0039d316-1c4b-4281-b951-d872f2087c98
* Reenabling some unit-tests on Linux, they seem to work fine now,jcivelli@chromium.org2010-03-251-6/+0
| | | | | | | | | | | even with the screen locked. BUG=23394 TEST=Run the tests. Review URL: http://codereview.chromium.org/1286005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42634 0039d316-1c4b-4281-b951-d872f2087c98
* Virtual LocaleChanged() callback added to views hierarchy to notifyglotov@google.com2010-03-252-2/+12
| | | | | | | | | | | views of the locale change so they could reload relevant data. BUG=none TEST=none Review URL: http://codereview.chromium.org/1145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42614 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression from Label fixes -- I forgot to make GetHeightForWidth() ↵pkasting@chromium.org2010-03-241-11/+18
| | | | | | | | | | actually care about the provided width for multi-line text. Oops. BUG=39104 TEST=About box should not be inordinately large Review URL: http://codereview.chromium.org/1293003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42527 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-2413-18/+305
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42498 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42465 - Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-2413-305/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reverting because newly added Test*MenuKeyboardAccess tests fail on some of the Windows buildbots, and possibly a XP Perf regression. Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/1257003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42468 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-2413-18/+305
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42465 0039d316-1c4b-4281-b951-d872f2087c98
* Add Accessibility name for native buttons.mhm@chromium.org2010-03-233-7/+3
| | | | | | | | | | | Remove the accessible name from Checkbox since it inherits from NativeButton. Dialogs with autogenerated buttons now have MSAA name attached to it, as well as all the checkboxes. BUG=38987 TEST=Ran it in AccExplorer Review URL: http://codereview.chromium.org/1102006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42401 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes ordering of includes.sky@chromium.org2010-03-231-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1075018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42377 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes compile error because gfx moved to src.sky@chromium.org2010-03-231-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/1150007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42359 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability to display text in a textfield when the text issky@chromium.org2010-03-237-17/+165
| | | | | | | | | | | empty. BUG=none TEST=none Review URL: http://codereview.chromium.org/1155008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42353 0039d316-1c4b-4281-b951-d872f2087c98
* views: [accessibility] Add accessible names for Minimize, Maximize, Restore ↵ctguil@chromium.org2010-03-231-0/+6
| | | | | | | | | | | | | buttons in the top right corner of the Window. BUG=9614 TEST=TEST=open AccExplorer, open the main chrome window, point it to one of the three buttons in the top-right corner, see if it shows the correct accessible names for each one. Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1076009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42349 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in my r42322.hbono@chromium.org2010-03-231-1/+1
| | | | | | | | | | | I landed a change that includes a typo. Sorry for your inconveniences. TBR=ben BUG=none TEST=build fix Review URL: http://codereview.chromium.org/1105013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42323 0039d316-1c4b-4281-b951-d872f2087c98
* This change adds shield icons to the buttons that need elevation to fix ↵hbono@chromium.org2010-03-233-10/+35
| | | | | | | | | | | | | | | | Issue 29631. This change adds a bool flag |need_elevation_| to notify when a button needs elevation to the NativeButton class and add shield icons to the following buttons. - on the "Start Chromium" button on the first-run dialog when the "Make Chromium the default browser" checkbox is enabled. - on the "Set as Default" button on the default browser infobar. - on the "Make Google Chrome my default browser" button on the Basics tab of options. BUG=29631 TEST=Launch Chrome when it is not set as a default browser and see the "Set as Default" button has a shield icon. TEST=Launch Chrome when it is not set as a default browser and open the "Options" dialog, and see its "Make Google Chrome my default browser" button has a shield icon. TEST=Launch Chrome with a '--first-run' option when it is not set as a default browser, and see its "Launch Chrome" button has a shield icon. Review URL: http://codereview.chromium.org/661165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42322 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/gfx/canvas and app/gfx/font to gfx/.ben@chromium.org2010-03-2358-70/+70
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1132006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42312 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix some GdkPixbuf leaks.mattm@chromium.org2010-03-231-0/+1
| | | | | | | | | | | | Also expand some documentation for functions that returned a GdkPixbuf about who owns the reference BUG=38895 TEST=manual test that nothing is broken, will watch bot for leak results Review URL: http://codereview.chromium.org/1075014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42302 0039d316-1c4b-4281-b951-d872f2087c98
* Allow Extensions to have MSAA information.mhm@chromium.org2010-03-222-1/+26
| | | | | | | | | | | | | The whole extension shelf and its items were missing MSAA information. Some of them were uninitialized due to the custom components not having any AccessibleRole. Some extensions have no name, this could happen where the user didn't put a name for their browser action in the manifest. If such case happens, we will use the extension name itself. BUG=36289 TEST=Extension shelf now has MSAA information according to Inspect32. Screenshot available on the issue tracker. Review URL: http://codereview.chromium.org/1105008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42289 0039d316-1c4b-4281-b951-d872f2087c98
* views: [accessibility] Add accessible name for the Close button in generic ↵ctguil@chromium.org2010-03-221-1/+5
| | | | | | | | | | | | Window. BUG=9614 TEST=open AccExplorer, open a dialog window, point it to the Close button in the top-right corner, see if it shows Close as the accessible name. Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1155005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42270 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite/clean up a bunch of label.cc to fix the following problems:pkasting@chromium.org2010-03-224-325/+220
| | | | | | | | | | | | | | | | | | * Focus rects on single-line labels could be the wrong height. Turns out SizeStringInt() doesn't adjust the height of a single-line string because it assumes you know your font's height. Passing in a default height of the font height fixed this. * Remove a bunch of confusing code/functions that did totally different things in single- and multi-line mode, and make things handle both modes and do what you'd expect. * Make functions be in the same order in the header and .cc files. * Make several things const. * Simplify. BUG=38679 TEST=Radio buttons in content blocked bubbles do not produce weird-looking focus rects when clicked. The third page of the Options dialog lays out correctly, and checkboxes don't produce too-wide focus rects when clicked. In RTL languages, the Options dialog still looks right, with no string clipping. Review URL: http://codereview.chromium.org/1072007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42256 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Keyboard accessibility for the page and app menus.", rev 42234 and ↵maruel@chromium.org2010-03-2213-214/+18
| | | | | | | | | | 42236. TBR=dmazzoni Review URL: http://codereview.chromium.org/1158004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42239 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-2213-18/+214
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42234 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug with native text field where if there's a visibility change, the ↵chocobo@chromium.org2010-03-223-26/+18
| | | | | | | | | | native control gets recreated without updating the properties. For chromeos login, the password field becomes a normal textfield. BUG=chromeos:2023 TEST=during login, we should not show the password in the clear. Review URL: http://codereview.chromium.org/1076008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42229 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r41641 "Make DevTools open docked by default..."xiyuan@chromium.org2010-03-224-381/+101
| | | | | | | | | | | | | | - Fix DevToolsSanityTest time out. The timeout is because the tests wait for Browser closed notification. However, docked DevTools does not have its own Browser object and hence the wait times out. BUG=none TEST=none Review URL: http://codereview.chromium.org/1025005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42226 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Keyboard accessibility for the page and app menus."maruel@chromium.org2010-03-2213-214/+18
| | | | | | | | | | This reverts commit 42217. TBR=dmzazzoni Review URL: http://codereview.chromium.org/1154003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42218 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-10 05:17:30 +0000