summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Merge 88897 - Disables tooltips if we can't create the tooltip window. I ↵sky@chromium.org2011-06-277-36/+26
| | | | | | | | | | | | | | | | | | still don't understand why we can't create tooltips for some folks, but this should at least keep us from crashing. BUG=82193 TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6995157 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/7253016 git-svn-id: svn://svn.chromium.org/chrome/branches/782/src@90644 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 87463 - Use the right version of IsEnabled() when updating the color ↵zork@chromium.org2011-06-091-3/+1
| | | | | | | | | | | | | | | of a TextButton BUG=chromium-os:15963 TEST=Manual Review URL: http://codereview.chromium.org/7080051 TBR=zork@chromium.org Review URL: http://codereview.chromium.org/7003075 git-svn-id: svn://svn.chromium.org/chrome/branches/782/src@88453 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 87810 - Fix bug 84529: Regression - The browser loses its focus when a ↵laforge@chromium.org2011-06-031-1/+1
| | | | | | | | | | | | | desktop notification appears BUG=84529 TEST=Manual test by verifying the browser does not lose focus Review URL: http://codereview.chromium.org/7024010 TBR=jianli@chromium.org Review URL: http://codereview.chromium.org/7024019 git-svn-id: svn://svn.chromium.org/chrome/branches/782/src@87811 0039d316-1c4b-4281-b951-d872f2087c98
* Move methods from WindowDelegate onto WidgetDelegate.ben@chromium.org2011-05-314-221/+232
| | | | | | | | | BUG=72040 TEST=none TBR=sky Review URL: http://codereview.chromium.org/7078008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87349 0039d316-1c4b-4281-b951-d872f2087c98
* views: Make View::GetVisibleBounds() a const method.tfarina@chromium.org2011-05-312-7/+5
| | | | | | | | | | | | | Note: This was a TODO for beng. BUG=72040 TEST=None R=ben@chromium.org Review URL: http://codereview.chromium.org/7083013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87312 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting explicit RemoveObserver in dtor of WidgetGtkglotov@google.com2011-05-311-3/+0
| | | | | | | | | | | | | This is a revert of http://codereview.chromium.org/6932034. It is no longer needed after NativeWidgetGtk deletes itself immediately, not using DeleteSoon(): crosbug.com/15129. BUG=chromium-os:14885 TEST=Sign in as a new user, sign out works fine. Review URL: http://codereview.chromium.org/7054039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87310 0039d316-1c4b-4281-b951-d872f2087c98
* Removing DeleteSoon() from WigetGtk so it behaves like WidgetWinglotov@google.com2011-05-314-14/+35
| | | | | | | | | | | | This is a retry of http://codereview.chromium.org/7002029/ after it has been reverted because of the failing test BrowserTest.CloseWithAppMenuOpen (failed only on buildbot) BUG=chromium-os:15129 TEST=tests Review URL: http://codereview.chromium.org/7082042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87294 0039d316-1c4b-4281-b951-d872f2087c98
* views: Make View::GetBaseline() a const method.tfarina@chromium.org2011-05-274-4/+4
| | | | | | | | | | | BUG=72040 TEST=None R=ben@chromium.org Review URL: http://codereview.chromium.org/7086008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87107 0039d316-1c4b-4281-b951-d872f2087c98
* views: Add OnEnabledChanged() method to View class.tfarina@chromium.org2011-05-2727-99/+89
| | | | | | | | | | | | | | | | | | | Changes done here: - Override OnEnabledChanged() in the derived classes from View instead of SetEnable(). - Make SetEnable() a member function not a virtual one. - Make |enabled_| a private data member variable not a protected one. - Some other misc cleanups. Note: The third item was a TODO for beng. BUG=72040 TEST=None R=ben@chromium.org Review URL: http://codereview.chromium.org/6976048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87080 0039d316-1c4b-4281-b951-d872f2087c98
* Move SetWindowBounds onto Widget.ben@chromium.org2011-05-2718-94/+105
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6976047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87073 0039d316-1c4b-4281-b951-d872f2087c98
* Makes rendering of selected disabled menu items match what windows does. As ↵sky@chromium.org2011-05-274-12/+26
| | | | | | | | | | | | well as disallowing opening disabled child menus by way of the keyboard. BUG=80837 TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/7062031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87064 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in updating only part of a texture and removes irrelevant TODO.sky@chromium.org2011-05-271-1/+0
| | | | | | | | | | BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6962042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87042 0039d316-1c4b-4281-b951-d872f2087c98
* Couple more wrench menu issues. The patch I sent around a couple ofsky@chromium.org2011-05-271-1/+7
| | | | | | | | | | | | | | | | | | days back didn't include these: . If other bookmarks folder is empty it wouldn't show a menu item for (empty). . Deleting the last item in the other folder would prematurely close the menu. . 'always show bookmark bar' wasn't rendering the check. BUG=84167 TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/7076027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87031 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of functions from Window onto Widget.ben@chromium.org2011-05-2718-409/+310
| | | | | | | | | BUG=72040 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86914 Review URL: http://codereview.chromium.org/7075019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87029 0039d316-1c4b-4281-b951-d872f2087c98
* views: Make |accessibility_focusable_| a private data member instead of a ↵tfarina@chromium.org2011-05-272-16/+12
| | | | | | | | | | | | | protected one. BUG=72040 TEST=None R=ben@chromium.org Review URL: http://codereview.chromium.org/7077016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86955 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 86914 - Move a bunch of functions from Window onto Widget.wtc@chromium.org2011-05-2718-310/+409
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Many tests in browser_tests crashed with a LOG(DFATAL) message on Chrome OS: [28862:28862:0526/153905:3290241082989:FATAL:browser_main.cc(955)] GLib-GObject: invalid (NULL) pointer instance Backtrace: base::debug::StackTrace::StackTrace() [0x33308d6] logging::LogMessage::~LogMessage() [0x334df2e] (anonymous namespace)::GLibLogHandler() [0x7c7d45] 0x2ab2a37a7fb9 0x2ab2a37a83d3 0x2ab2a313302a 0x2ab2a31315c5 views::NativeWidgetGtk::InitNativeWidget() [0x1a30dcf] views::Widget::Init() [0x1a37fa7] NativeTabContentsViewGtk::InitNativeTabContentsView() [0x10c6b83] TabContentsViewViews::CreateView() [0x397ac46] TabContents::TabContents() [0x1501e09] Browser::TabContentsFactory() [0xc84725] browser::Navigate() [0xc954c7] Browser::AddSelectedTabWithURL() [0xc76d9e] (anonymous namespace)::InitializeBrowser() [0x70be3d] InProcessBrowserTest::CreateBrowser() [0x70d178] InProcessBrowserTest::RunTestOnMainThreadLoop() [0x70d34a] [...snipped...] BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7075019 R=msw@chromium.org TBR=ben@chromium.org Review URL: http://codereview.chromium.org/6976040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86939 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of functions from Window onto Widget.ben@chromium.org2011-05-2618-409/+310
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7075019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86914 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move some protected data member variables to the private section instead.tfarina@chromium.org2011-05-262-14/+12
| | | | | | | | | | | | | Note: This was a TODO for beng. BUG=72040 TEST=None R=ben@chromium.org Review URL: http://codereview.chromium.org/7074014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86884 0039d316-1c4b-4281-b951-d872f2087c98
* Rough cut at window activation.ben@chromium.org2011-05-2611-12/+155
| | | | | | | | http://crbug.com/84070 TEST=none Review URL: http://codereview.chromium.org/7071017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86869 0039d316-1c4b-4281-b951-d872f2087c98
* views: Cleanup parent_owned getter/setter accessors.tfarina@chromium.org2011-05-262-17/+12
| | | | | | | | | | | BUG=72040 TEST=None R=ben@chromium.org Review URL: http://codereview.chromium.org/6962004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86848 0039d316-1c4b-4281-b951-d872f2087c98
* views: Run desktop on linux.sadrul@chromium.org2011-05-262-1/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7076017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86834 0039d316-1c4b-4281-b951-d872f2087c98
* Add a desktop test harness.ben@chromium.org2011-05-268-0/+522
| | | | | | | | http://crbug.com/83663 TEST=none Review URL: http://codereview.chromium.org/7068036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86831 0039d316-1c4b-4281-b951-d872f2087c98
* This change implements a first pass in the effort to remove the dependency ↵twiz@chromium.org2011-05-266-19/+18
| | | | | | | | | | | | | | of PlatformDevice within Chrome. The Skia library now provides multiple back-ends for the SkDevice class, so PlatformDevice's inheritance of SkDevice, and the assumption of instances of PlatformDevice limits the use of these new back-ends. A new set of helper functions is provided for the PlatformDevice entry points. Upon construction of a PlatformDevice, a pointer to the interface is cached in the parent SkDevice's SkMetaData. The new helper functions forward calls to the interface cached in the metadata. BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86625 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=86625 Review URL: http://codereview.chromium.org/7019013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86823 0039d316-1c4b-4281-b951-d872f2087c98
* views: Get rid of View::SetParent() method.tfarina@chromium.org2011-05-262-12/+3
| | | | | | | | | | | | | This method is private to View class, and thus can be removed. BUG=72040 TEST=None R=ben@chromium.org Review URL: http://codereview.chromium.org/7076002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86775 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in NativeWidgetWin::GetAcceleratedWidget. I had the ifdefsky@chromium.org2011-05-262-3/+2
| | | | | | | | | | | | wrong. BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6992086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86767 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a basic NativeWindowViews.ben@chromium.org2011-05-2511-7/+388
| | | | | | | | http://crbug.com/83663 TEST=none Review URL: http://codereview.chromium.org/7069022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86736 0039d316-1c4b-4281-b951-d872f2087c98
* Another clang build fix for r86677.rhashimoto@chromium.org2011-05-251-1/+1
| | | | | | | | | BUG=none TBR=sky Review URL: http://codereview.chromium.org/6992079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86691 0039d316-1c4b-4281-b951-d872f2087c98
* base/i18n: Pass |str| as const reference in BreakIterator::Init().tfarina@chromium.org2011-05-252-3/+3
| | | | | | | | | | | BUG=None TEST=out/Debug/base_unittests --gtest_filter=BreakIteratorTest.* R=tsepez@chromium.org,evan@chromium.org Review URL: http://codereview.chromium.org/7008005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86689 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang build for r86677.rhashimoto@chromium.org2011-05-252-3/+5
| | | | | | | | | BUG=none TBR=sky Review URL: http://codereview.chromium.org/7008015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86688 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang build for http://codereview.chromium.org/7067032/.rhashimoto@chromium.org2011-05-253-0/+13
| | | | | | | | | BUG=none TBR=sky Review URL: http://codereview.chromium.org/6987030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86686 0039d316-1c4b-4281-b951-d872f2087c98
* Add MenuModelAdapter to wrap ui::MenuModel with views::MenuDelegate interface.rhashimoto@chromium.org2011-05-257-2/+535
| | | | | | | | | | | | | | | | | - added ViewsDelegate::GetDispositionForEvent() pure virtual - added MenuModelAdapter - added unit test for MenuModelAdapter - added comment for MenuModel::GetFirstItemIndex() that callers may pass NULL for NativeMenu argument - fixed index offset bug in MenuModel::GetModelAndIndexForCommandId() - fixed spurious call to MenuDelegate::IsCommandEnabled() BUG=none TEST=included Review URL: http://codereview.chromium.org/7067032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86677 0039d316-1c4b-4281-b951-d872f2087c98
* Make Widget ownership a little clearer by expressing it in terms of an enum.ben@chromium.org2011-05-2511-33/+47
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7031053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86669 0039d316-1c4b-4281-b951-d872f2087c98
* views: Fix an operator precedence error found by PVS Studio.thakis@chromium.org2011-05-251-1/+1
| | | | | | | | | | BUG=83891 TEST=none Review URL: http://codereview.chromium.org/6987021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86652 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes couple of issues with bookmarks in wrench menu:sky@chromium.org2011-05-251-2/+7
| | | | | | | | | | | | | | | | | | | | . Crash when deleting via context menu. This was happening because BookmarkMenuDelegate didn't keep a handle to the menu item it added the items to. . If other bookmarks folder is empty it wouldn't show a menu item for (empty). . Deleting the last item in the other folder would prematurely close the menu. . Hit DCHECK when adding empty menu (long standing issue). BUG=83746 TEST=from the wrench menu on windows right click a bookmark, delete it, and make sure you don't crash. R=ben@chromium.org Review URL: http://codereview.chromium.org/7066034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86634 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 86625 - This change implements a first pass in the effort to remove ↵vandebo@chromium.org2011-05-256-18/+19
| | | | | | | | | | | | | | | the dependency of PlatformDevice within Chrome. The Skia library now provides multiple back-ends for the SkDevice class, so PlatformDevice's inheritance of SkDevice, and the assumption of instances of PlatformDevice limits the use of these new back-ends. A new set of helper functions is provided for the PlatformDevice entry points. Upon construction of a PlatformDevice, a pointer to the interface is cached in the parent SkDevice's SkMetaData. The new helper functions forward calls to the interface cached in the metadata. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7019013 TBR=twiz@chromium.org Review URL: http://codereview.chromium.org/6987019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86629 0039d316-1c4b-4281-b951-d872f2087c98
* This change implements a first pass in the effort to remove the dependency ↵twiz@chromium.org2011-05-256-19/+18
| | | | | | | | | | | | of PlatformDevice within Chrome. The Skia library now provides multiple back-ends for the SkDevice class, so PlatformDevice's inheritance of SkDevice, and the assumption of instances of PlatformDevice limits the use of these new back-ends. A new set of helper functions is provided for the PlatformDevice entry points. Upon construction of a PlatformDevice, a pointer to the interface is cached in the parent SkDevice's SkMetaData. The new helper functions forward calls to the interface cached in the metadata. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7019013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86625 0039d316-1c4b-4281-b951-d872f2087c98
* Chromeos: virtual destructors should have virtual keyword (part 4).hans@chromium.org2011-05-251-1/+1
| | | | | | | | | | | | | Nu functionality change: virtual is only added to destructors that are already implicitly virtual. BUG=83408 TEST=chromiumos clang bot goes green TBR=battre Review URL: http://codereview.chromium.org/7031049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86620 0039d316-1c4b-4281-b951-d872f2087c98
* Chromeos: virtual destructors should have virtual keyword (part 3).hans@chromium.org2011-05-252-2/+2
| | | | | | | | | | | | | Nu functionality change: virtual is only added to destructors that are already implicitly virtual. BUG=83408 TEST=chromiumos clang bot goes green TBR=battre Review URL: http://codereview.chromium.org/6979010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86615 0039d316-1c4b-4281-b951-d872f2087c98
* Chromeos: virtual destructors should have virtual keyword (part 2).hans@chromium.org2011-05-253-3/+3
| | | | | | | | | | | | | Nu functionality change: virtual is only added to destructors that are already implicitly virtual. BUG=83408 TEST=chromiumos clang bot goes green TBR=battre Review URL: http://codereview.chromium.org/7027006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86608 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SkIntToScalar conversion.battre@chromium.org2011-05-251-3/+3
| | | | | | | | | | This broke the Chrome OS bot http://build.chromium.org/p/chromium/builders/Linux%20Tests%20%28ChromiumOS%20dbg%29%281%29/builds/607/steps/browser_tests/logs/stdio BUG=no TEST=no TBR=ben@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86589 0039d316-1c4b-4281-b951-d872f2087c98
* Remove files that don't exist, and fix typos in gyp filessadrul@chromium.org2011-05-251-6/+0
| | | | | | | | | BUG=none TEST=things still work Review URL: http://codereview.chromium.org/6990028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86533 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up more of the NativeWidgetViews.ben@chromium.org2011-05-247-30/+248
| | | | | | | | | | | - Move NativeWidgetView to its own file. - Enhances the example to contain a button. http://crbug.com/83663 TEST=none Review URL: http://codereview.chromium.org/7065042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86527 0039d316-1c4b-4281-b951-d872f2087c98
* Prototype compositor to render views to a texture using d3d 10. Thissky@chromium.org2011-05-241-1/+4
| | | | | | | | | | | | | | | is just a prototype for us to play with. There are plenty of issues to resolve before its made real, but I wanted to check something in for others to play with rather than keeping it all local. To get it to compile you need to set the GYP_DEFINE to views_compositor. BUG=none TEST=none R=ben@chromium.org,apatrick@chromium.org Review URL: http://codereview.chromium.org/7067029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86516 0039d316-1c4b-4281-b951-d872f2087c98
* Add NativeWidgetViews. This is a stub implementation that mostly just defers ↵ben@chromium.org2011-05-247-0/+399
| | | | | | | | | | to its parent NativeWidget. http://crbug.com/83663 TEST=none Review URL: http://codereview.chromium.org/6990048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86488 0039d316-1c4b-4281-b951-d872f2087c98
* Make clicks work on views_examples with touchui.sadrul@chromium.org2011-05-242-2/+162
| | | | | | | | | BUG=none TEST=views_examples work with touchui Review URL: http://codereview.chromium.org/6990060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86457 0039d316-1c4b-4281-b951-d872f2087c98
* Makes Background only create a brush when needed. This avoidssky@chromium.org2011-05-242-5/+13
| | | | | | | | | | | | irrelevant DCHECKs if you use a color with alpha. BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/7065013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86454 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile on linux when ibus is available.sadrul@chromium.org2011-05-241-2/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6992027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86443 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes rounding bug in transform. This is needed to avoid roundingsky@chromium.org2011-05-241-0/+9
| | | | | | | | | | | | | something like -.9998 to 0 instead of -1. Without this a transformed views bounds would end up with an extra scale-1 pixels on the left edge. BUG=none TEST=covered by unit test R=ben@chromium.org,wjmaclean@chromium.org Review URL: http://codereview.chromium.org/7066010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86430 0039d316-1c4b-4281-b951-d872f2087c98
* Fix touch compile after r86390.sadrul@chromium.org2011-05-242-7/+2
| | | | | | | | | | ibus is not usable on lucid, so touchui build still needs to use ibus-gtk. BUG=none TEST=touchui compiles TBR=hashimoto@chromium.org, oshima@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86394 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to make InputMethodIBus usable on every ChromeOS device (even without ↵hashimoto@chromium.org2011-05-244-23/+51
| | | | | | | | | | | | | | TouchUI) Add switch "--enable-inputmethod-ibus" to enable InputMethodIBus on ChromeOS Modify gyp files to link IBus BUG=chromium-os:15566 TEST=manually Review URL: http://codereview.chromium.org/7004029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86390 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 11:19:53 +0000