summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Adds yet more debugging code.sky@chromium.org2011-04-131-1/+16
| | | | | | | | | | BUG=77651 TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6834006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81363 0039d316-1c4b-4281-b951-d872f2087c98
* Pull content from TabContentsViewViews into NativeTabContentsViewWin.ben@chromium.org2011-04-127-0/+32
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6824060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81328 0039d316-1c4b-4281-b951-d872f2087c98
* step 3 of native theme refactoringrogerta@chromium.org2011-04-124-89/+81
| | | | | | | | | | | | | | Moved all calls to old menu drawing api to new NativeTheme::Paint(). Moved all calls to old push/radio/check button api to new NativePaint::Paint(). BUG=None TEST=Affects windows platform only. All menus in chrome, such as wrench menu, should look and behave as before, with no change. All pushbuttons, radiobuttons, and checkbox in web page forms should look and behave as before. Review URL: http://codereview.chromium.org/6825007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81257 0039d316-1c4b-4281-b951-d872f2087c98
* Adds more debugging code in hopes of figuring out a crash. Most commonsky@chromium.org2011-04-112-3/+6
| | | | | | | | | | | | | | | | reason for crash appears to be because we can't find the WindowWin for an hwnd. I'm also removing a comment that is no longer relevant, and nuking a call in window_win to ui::SetWindowUserData that is already done in WindowImpl. BUG=77651 TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6825045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81150 0039d316-1c4b-4281-b951-d872f2087c98
* touch: identity for a finger is an int, not a bool.sadrul@chromium.org2011-04-111-1/+1
| | | | | | TBR=rjkroege@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81141 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Fix compile by initializing a variable.sadrul@chromium.org2011-04-111-1/+1
| | | | | | TBR=rogerta@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81139 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmitting change because original caused build breaks:rogerta@chromium.org2011-04-116-0/+507
| | | | | | | | | | | | | | | | | - clang build requires destructor in complex classes - chromeos build requires newline at end of files Adding a native theme painter, to allow Views to use NativeTheme to draw their background. Added example code to show it in use. I still have not hooked this into any existing View-based controls. BUG=None TEST=None R=ben@chromium.org Review URL: http://codereview.chromium.org/6820007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81128 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable FREEZE_UPDATE propertyoshima@google.com2011-04-113-5/+66
| | | | | | | | | | | | | | | This is a real fix for 13750. When the entire area of a WidgetGtk is covered by another GdkWindow, the WidgetGtk doesn't get expose event, which was causnig 13750. This fixes this issue by listening child widget's expose event and remove the FREEZE_UPDATE property. BUG=chromium-os:11514, chromium-os:13750 TEST=see bug for repro steps R=sky@chromium.org Review URL: http://codereview.chromium.org/6823017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81123 0039d316-1c4b-4281-b951-d872f2087c98
* Adds more debugging code in hopes of figuring out a crash. Sorry forsky@chromium.org2011-04-084-1/+67
| | | | | | | | | | | | | | | | | needing to add so much plumbing here. We're not creating the FocusManager for BrowserView. I can only think that either we're not getting the create event, or we're getting the wrong parent widget. This should help us nail down which one is happening. BUG=77651 TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6820009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81012 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r80952, http://codereview.chromium.org/6771056dmichael@chromium.org2011-04-086-501/+0
| | | | | | | | | BUG=None TEST=None TBR=rogerta Review URL: http://codereview.chromium.org/6823011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80957 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a native theme painter, to allow Views to use NativeTheme to drawrogerta@chromium.org2011-04-086-0/+501
| | | | | | | | | | | | | | | their background. Added example code to show it in use. I still have not hooked this into any existing View-based controls. This CL depends on changes currently being made to native theme, see http://codereview.chromium.org/6728029/ for details. BUG=None TEST=None Review URL: http://codereview.chromium.org/6771056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80952 0039d316-1c4b-4281-b951-d872f2087c98
* Combine WidgetWin KeyEvent handlers.msw@chromium.org2011-04-082-17/+6
| | | | | | | | | BUG=72040 TEST=Key Events on Widgets in Windows Review URL: http://codereview.chromium.org/6813033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80900 0039d316-1c4b-4281-b951-d872f2087c98
* Don't store/restore focus when window is activated/deactivated on linux.oshima@google.com2011-04-072-5/+6
| | | | | | | | | | | | GTK can restore focus if the native widget has a focus, and views always remembers the focused_view, so there is no need to store/restore on linux for this case. Opening it (like wrench menu) was causing the issues in bugs because it changes window activation. BUG=70032,chromium-os:8829 TEST=see bugs TEST= Review URL: http://codereview.chromium.org/6691052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80809 0039d316-1c4b-4281-b951-d872f2087c98
* Interpret double click events as mouse down on Windows.msw@chromium.org2011-04-072-8/+6
| | | | | | | | | | | Remove redundant code from a conditional block. BUG=78636 TEST=Double click to close neighboring tabs via (x) Review URL: http://codereview.chromium.org/6813014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80780 0039d316-1c4b-4281-b951-d872f2087c98
* RTL window styles was being set on too many HWNDs. This inverts the default. ↵ben@chromium.org2011-04-061-2/+2
| | | | | | | | | | There may be cases where the window styles are necessary however. Those I do not know and am going to rely on RTL QA to tell me about. http://crbug.com/77166 TEST=start chrome with --lang=he, content area should render and not be inverted, wrench menu should not be inverted. This change may cause some HWNDs to be incorrectly not flipped. Please let me know about those cases. Review URL: http://codereview.chromium.org/6804027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80701 0039d316-1c4b-4281-b951-d872f2087c98
* Fix WidgetWin MouseWheelEvent handling.msw@chromium.org2011-04-062-19/+4
| | | | | | | | | BUG=78569 TEST=Scroll over long bookmark menu. Review URL: http://codereview.chromium.org/6803015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80700 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in View::OnBoundsChange painting the old/new. The codesky@chromium.org2011-04-061-7/+18
| | | | | | | | | | | | wasn't adjusting for RTL. BUG=none TEST=none R=ben@chromium.org,davemoore@chromium.org Review URL: http://codereview.chromium.org/6793050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80663 0039d316-1c4b-4281-b951-d872f2087c98
* Added SchedulePaint in BrowserView::OnWindowActivationChangedwyck@chromium.org2011-04-061-1/+3
| | | | | | | | | | BUG=78463 TEST=None Review URL: http://codereview.chromium.org/6691065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80624 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disaling FREEZE_UPDATE propertyoshima@google.com2011-04-051-0/+4
| | | | | | | | | | | Panel has problem with FREEZE_UPDATE. I'm going to disable this for now as it will take some time to figure out and implement solution. BUG=chromium-os:13750 TEST=none Review URL: http://codereview.chromium.org/6735069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80548 0039d316-1c4b-4281-b951-d872f2087c98
* rename getBitmapDC to beginPlatformPaint and add calls to endPlatformPaintvandebo@chromium.org2011-04-051-1/+2
| | | | | | | | | | | This takes a step toward unifying the platform device interface between Windows and Linux and helps to make VectorPlatformDeviceSkia have less ifdefs. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/6677142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80474 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in menu that would clip to menu height instead of work area.sky@chromium.org2011-04-051-1/+1
| | | | | | | | | | BUG=78111 TEST=see bug R=ben@chromium.org Review URL: http://codereview.chromium.org/6792036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80463 0039d316-1c4b-4281-b951-d872f2087c98
* Transform GdkEvents for simpler MouseEvent construction.msw@chromium.org2011-04-056-68/+52
| | | | | | | | | | | Handle MouseWheelEvent in Widget::OnMouseEvent. BUG=72040 TEST=Mouse interaction on linux_views Review URL: http://codereview.chromium.org/6720025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80420 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate constrained window code into a cross platform base class.ben@chromium.org2011-04-041-1/+2
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6735041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80386 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for regressions caused by FREEZE_UPDATE propertyoshima@google.com2011-04-043-1/+16
| | | | | | | | | | | | * menu can be closed before being shown. (native_menu_gtk.cc) * virtual keyboard doesn't get expose event on window_contents_ due to renderer covering the entire area. BUG=chromium-os:13760, chromium-os:11514 TEST=refer to bugs. Review URL: http://codereview.chromium.org/6794026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80366 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor RenderWidgetHostViewViews to use the new input method API for Views.suzhe@google.com2011-04-019-740/+1234
| | | | | | | | | | | | | | | This CL also fixes some issues related to NULL host_ pointer in the original code. Hope the fixes are correct. Another side effect of this CL is: it converts views::KeyEvent to NativeWebKeyboardEvent by using the conversion table of Views instead of WebInputEventFactory provided by WebKit. See bug 54315. BUG=54315 BUG=75003 TEST=none Review URL: http://codereview.chromium.org/6713083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80238 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate cross platform logic into MenuHost.ben@chromium.org2011-04-0118-369/+288
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6690054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80232 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate the new input method API for Views into Chromium.suzhe@google.com2011-04-0124-323/+1439
| | | | | | | | | | | | | | | | | | This CL contains following changes: 1. Improve TextfieldViewsModel to support composition text. 2. Implement TextInputClient interface in NativeTextfieldViews. 3. Fix Textfield and native implementations to avoid calling TextfieldController::ContentsChanged() when the text is changed by calling Textfield::SetText() or AppendText(). 4. Fix a bug in FocusManager that causes NativeTextfieldViewsTest.FocusTraversalTest to fail. 5. Fix accelerator_handler_touch.cc to send key events to the top-level widget's input method instance instead of the root view. 6. Do the same fix in extension_input_api.cc. 7. Hook InputMethod into WidgetGtk and WidgetWin. BUG=75003 TEST=views_unittests --gtest_filter=NativeTextfieldViews* Review URL: http://codereview.chromium.org/6675005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80226 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Fix compile (regressed in r80024).sadrul@chromium.org2011-04-012-2/+6
| | | | | | TBR=saintlou@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80131 0039d316-1c4b-4281-b951-d872f2087c98
* Notify child widgets before and after a reparenting.asanka@chromium.org2011-03-313-21/+40
| | | | | | | | | | | | | | | | Attaching a native view to a NativeViewHostWin may cause that view to be disassociated from a view hierarchy with a different FocusManager. Notifying the widgets that they are about to be removed from their current parent gives them the opportunity to disassociate themselves from their current FocusManager. BUG=77447 TEST=none Review URL: http://codereview.chromium.org/6776025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80096 0039d316-1c4b-4281-b951-d872f2087c98
* Add newline to end of file.ben@chromium.org2011-03-311-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80087 0039d316-1c4b-4281-b951-d872f2087c98
* New InputMethod api for Views.suzhe@google.com2011-03-3118-1/+1746
| | | | | | | | | | | | | | This CL adds: 1. Interfaces: InputMethod, InputMethodDelegate, TextInputClient. 2. InputMethodGtk: an InputMethod implementation based on GtkIMContext. 3. MockInputMethod: a mock InputMethod implementation for unit tests. BUG=75003 TEST=none Review URL: http://codereview.chromium.org/6688049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80076 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang failure; out-of-line a virtual.msw@chromium.org2011-03-312-1/+5
| | | | | | | | | BUG=none TEST=linux clang build fix. Review URL: http://codereview.chromium.org/6780040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80073 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate Widget Event code, other cleanup.msw@chromium.org2011-03-3121-516/+295
| | | | | | | | | | | | | Rename *NativeCapture to *MouseCapture. Rename and move ShouldReleaseCaptureOnMouseReleased. Move static flag function to Event. BUG=72040 TEST=Mouse interaction on win & linux_views. Review URL: http://codereview.chromium.org/6756043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80065 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for paint issue on initial screen.oshima@google.com2011-03-314-10/+96
| | | | | | | | | | | | | It turns out that the sync counter that we used to rely on to synchronize window painting doesn't work for the initial screen as gtk may ignore and simply update the count without painting if the configure notify doesn't change the window size. This change uses FREEZE_UPDATES to notify WM to guarantee that WM will show only after the window is painted. I also removed gdk_window_process_updates from login code because this fixes crosbug.com/12566. I confirmed that gdk_widnow_process_update in map handler is necessary for touch. This is due to a bug in touch code but since this path will be removed in near future, i'll keep this workaround as is for touch. BUG=chromium-os:11514 TEST=see bug description. Review URL: http://codereview.chromium.org/6698063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80056 0039d316-1c4b-4281-b951-d872f2087c98
* TextButton inside NativeButton for the touch casesaintlou@chromium.org2011-03-3110-57/+140
| | | | | | | | | | | | | | | | | | This CL wraps TextButton inside NativeButton for the touch case. The reason for the added intermediate class is that RadioButton is derived from CheckBox which is derived from NativeButton. This is transitional code this approach is simpler and more importantly contained to the views/controls/button/, the rest of the code can continue to use NativeButton transparently as before. BUG=none TEST=none Review URL: http://codereview.chromium.org/6756017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80024 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustageben@chromium.org2011-03-311-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80021 0039d316-1c4b-4281-b951-d872f2087c98
* Make MenuHost concrete, hide platform specific implementation behind ↵ben@chromium.org2011-03-3111-70/+234
| | | | | | | | | | | | NativeMenuHost. This is the first step, creating this structure. Will consolidate common functionality and state next. BUG=72040 TEST=all menu tests for bookmark bar, wrench menu Review URL: http://codereview.chromium.org/6740022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80015 0039d316-1c4b-4281-b951-d872f2087c98
* The native tabbed pane was not showing its content window upon creation,rogerta@chromium.org2011-03-311-1/+1
| | | | | | | | | | | | | resulting in the views_examples tools to display blank tabs. Child windows should be made visible by default. BUG=None TEST=make sure the views_examples.exe tool show the correct content for all its tabs R=ben@chromium.org Review URL: http://codereview.chromium.org/6670123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79998 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a comment to explain a non-obvious fallthrough to another case statement.finnur@chromium.org2011-03-311-0/+1
| | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6675046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79983 0039d316-1c4b-4281-b951-d872f2087c98
* In preparation for NativeTheme refactoring, renaming the class NativeThemerogerta@chromium.org2011-03-3011-57/+56
| | | | | | | | | | | | to NativeThemeWin, since it is windows specific anyway. BUG=None TEST=None R=xiyuan@chromium.org Review URL: http://codereview.chromium.org/6778009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79874 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 79762 - This CL wraps TextButton inside NativeButton for the touch case. dhollowa@chromium.org2011-03-3010-143/+57
| | | | | | | | | | | | | | | | | | | | | The reason for the added intermediate class is that RadioButton is derived from CheckBox which is derived from NativeButton. This is just transitional code this approach is simpler and more importantly contained to the views/controls/button/, the rest of the code can continue to use NativeButton transparently as before. Note: the Windows trybot seems to fail on flaky test BUG=none TEST=none Review URL: http://codereview.chromium.org/6770014 TBR=saintlou@chromium.org Review URL: http://codereview.chromium.org/6731075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79770 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 79768 - Fixed Clang error to http://codereview.chromium.org/6770014/dhollowa@chromium.org2011-03-301-2/+5
| | | | | | | | | | | | | BUG=none TEST=none TBR=sky@chromium.org Review URL: http://codereview.chromium.org/6749046 TBR=dhollowa@chromium.org Review URL: http://codereview.chromium.org/6749047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79769 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed Clang error to http://codereview.chromium.org/6770014/dhollowa@chromium.org2011-03-301-5/+2
| | | | | | | | | | BUG=none TEST=none TBR=sky@chromium.org Review URL: http://codereview.chromium.org/6749046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79768 0039d316-1c4b-4281-b951-d872f2087c98
* This CL wraps TextButton inside NativeButton for the touch case. saintlou@chromium.org2011-03-2910-57/+143
| | | | | | | | | | | | | | | | | | The reason for the added intermediate class is that RadioButton is derived from CheckBox which is derived from NativeButton. This is just transitional code this approach is simpler and more importantly contained to the views/controls/button/, the rest of the code can continue to use NativeButton transparently as before. Note: the Windows trybot seems to fail on flaky test BUG=none TEST=none Review URL: http://codereview.chromium.org/6770014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79762 0039d316-1c4b-4281-b951-d872f2087c98
* Disambiguate OnMouseCaptureLost from OnMouseReleased.msw@chromium.org2011-03-2935-213/+205
| | | | | | | | | | | | | Nix RenderWidgetHostViewViews' OnMouseCaptureLost forwarding. Consolidate code, remove unnecessary overrides, etc. Fix up test, |event| args, OVERRIDEs, and (c) dates. BUG=72040 TEST=Views mouse button release, cancelling mouse down/drag. Review URL: http://codereview.chromium.org/6685069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79640 0039d316-1c4b-4281-b951-d872f2087c98
* Add focused property to chrome.windows.create extension API.jennb@chromium.org2011-03-285-2/+24
| | | | | | | | | | | Add BrowserWindow::ShowInactive. BUG=None TEST=Added api test. Also tested manually on CR-48. Review URL: http://codereview.chromium.org/6688036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79620 0039d316-1c4b-4281-b951-d872f2087c98
* Changes windows menu to strip out tabs in the string. Windowssky@chromium.org2011-03-281-0/+4
| | | | | | | | | | | | | | interprets tabs as an accelerator. This means if the menu text has tabs in it we get weird behavior, and possibly trigger bugs in windows. BUG=77151 TEST=see bug R=ben@chromium.org Review URL: http://codereview.chromium.org/6745002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79614 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage by initializing variable.ben@chromium.org2011-03-281-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79587 0039d316-1c4b-4281-b951-d872f2087c98
* Convert more WidgetWin/WidgetGtk creations to use a new cross-platform ↵ben@chromium.org2011-03-2811-57/+75
| | | | | | | | | | static ctor on Widget: CreateWidget(). BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6732028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79586 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-2826-44/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 09:33:30 +0000