summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Revert 92059 - Adds a test for parented synthetic widgets.ben@chromium.org2011-07-111-32/+6
| | | | | | | | | | | BUG=88716 TEST=none Review URL: http://codereview.chromium.org/7331021 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/7340002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92063 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a test for parented synthetic widgets.ben@chromium.org2011-07-111-6/+32
| | | | | | | | BUG=88716 TEST=none Review URL: http://codereview.chromium.org/7331021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92059 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the comments setting emands and vim tab width and expansion variables.tony@chromium.org2011-07-111-6/+0
| | | | | | | | | | | | | | | | | These were added in r28089 (http://codereview.chromium.org/256059) but are unnecessary bloat for everyone to carry around, even those that don't use emacs or vim. In an earlier change, I added editor config files in src/tools/emacs/ and src/tools/vim/ so users of the appropriate editor can source those instead. BUG=none TEST=none Review URL: http://codereview.chromium.org/7310019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92046 0039d316-1c4b-4281-b951-d872f2087c98
* Revert clear removal from last week. It turns out the window is green in ↵ben@chromium.org2011-07-112-2/+7
| | | | | | | | | | | | | debug builds only if the clear is not done. Weird, since I was able to see glass when I tested this earlier. Also converts one GetNativeView() check to native_widget() since they are now equivalent. BUG=none TEST=win7, glass mode, debug build, browser frame should not be green TBR=sky Review URL: http://codereview.chromium.org/7338002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92041 0039d316-1c4b-4281-b951-d872f2087c98
* Fix NativeWidgetViews enough to run views_examples without segfaulting.rhashimoto@google.com2011-07-114-9/+20
| | | | | | | | | BUG=chromium:85585 TEST=run views_examples Review URL: http://codereview.chromium.org/7237064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92039 0039d316-1c4b-4281-b951-d872f2087c98
* Multi-Profiles: Add icon chooser to profiles menusail@chromium.org2011-07-094-17/+36
| | | | | | | | | | | | This change adds an icon chooser grid to the profiles menu. This is only implemented for toolkit views for now. Screenshots: http://www.dropmocks.com/mXGba BUG= TEST= Review URL: http://codereview.chromium.org/7331017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91958 0039d316-1c4b-4281-b951-d872f2087c98
* Minor improvements to views accessibility. Improves notification for admazzoni@chromium.org2011-07-083-0/+14
| | | | | | | | | | | | few classes, and replaces an ugly view class name comparison with a clean switch based on the view's role. BUG=none TEST=none Review URL: http://codereview.chromium.org/7328027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91913 0039d316-1c4b-4281-b951-d872f2087c98
* views: Some views tests should use EXPECT_* rather than ASSERT_*.tfarina@chromium.org2011-07-081-32/+32
| | | | | | | | | | | | | | | | ASSERT should be used in cases where we are going to rely in pointer being not NULL in the next test or an array having determinate numbers of elements because we are going to access an element of it in the next step. But these aren't the cases here. BUG=None TEST=views_unittests R=sky@chromium.org Review URL: http://codereview.chromium.org/7330021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91900 0039d316-1c4b-4281-b951-d872f2087c98
* Correct implementation of View::ConvertPointToScreen for the views-desktop ↵ben@chromium.org2011-07-084-6/+2
| | | | | | | | | | | | environment. Also removes the unnecessary clear from RootView since this is interfering with transparent Widgets. BUG=none TEST=none Review URL: http://codereview.chromium.org/7237040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91890 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in views desktop. The problem wassky@chromium.org2011-07-085-4/+14
| | | | | | | | | | | | | CreateRenderWidgetHostView would delete the old RenderWidgetHostView. Also fixes compile error in views_unittests. BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/7329027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91888 0039d316-1c4b-4281-b951-d872f2087c98
* Use SkMatrix44 for the underlying implementation of ui::Transformbacker@chromium.org2011-07-082-24/+47
| | | | | | | | | | BUG= TEST=ui_unittest Review URL: http://codereview.chromium.org/7044062 Patch from Ian Vollick <vollick@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91855 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the bug of the hide key on Omnibox.mazda@chromium.org2011-07-081-2/+0
| | | | | | | | | | | | | | | | | | Fix a bug of hide key where the keyboard does now show up after the hide key is pressed while Omnibox has the focus and Omnibox is touched. I changed the way of retrieving the text input type to use InputMethod::GetTextInputType rather than TextInputClient::GetTextInputType because NULL is always set to touch_pressed_handler when omnibox is touched. I also added code to check the touch event type so that the notification is sent only when text element is touched. BUG=none TEST=manually Review URL: http://codereview.chromium.org/7324029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91854 0039d316-1c4b-4281-b951-d872f2087c98
* CL for readability reviewhashimoto@chromium.org2011-07-084-112/+198
| | | | | | | | | BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7264015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91808 0039d316-1c4b-4281-b951-d872f2087c98
* Makes views menu open submenus immediately when pressing a key. Wesky@chromium.org2011-07-081-1/+1
| | | | | | | | | | | | | need to do this immediately, otherwise if the user types fast enough the accelerator goes to the wrong menu. BUG=84442 TEST=see bug R=ben@chromium.org Review URL: http://codereview.chromium.org/7328004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91806 0039d316-1c4b-4281-b951-d872f2087c98
* Changes wrench menu button to show system menu on space. This matchessky@chromium.org2011-07-081-7/+1
| | | | | | | | | | | | | what windows does. BUG=56650 TEST=press alt and release, focus should be on the wrench. press space, make sure the window menu appears, not the wrench menu. R=ben@chromium.org Review URL: http://codereview.chromium.org/7237032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91805 0039d316-1c4b-4281-b951-d872f2087c98
* Try two for flicker free drawingdavemoore@chromium.org2011-07-072-50/+79
| | | | | | | | | | | patch from issue 7171025 BUG=84721 TEST=Switch tabs...no flicker Review URL: http://codereview.chromium.org/7327002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91762 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crashes in EnterpriseEnrollmentScreenTest.TestCancel. This is ↵ben@chromium.org2011-07-073-5/+8
| | | | | | | | | | | independent of any tfarina-induced bustage. BUG=none TEST=none TBR=sky Review URL: http://codereview.chromium.org/7313027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91738 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing signed/unsigned char bug on ARM for TouchFactorymiletus@chromium.org2011-07-071-1/+1
| | | | | | | | | | | | | | | | | | | | Change the type of valuator_lookup_[kMaxDeviceNum][TP_LAST_ENTRY] from "char" to "signed char". -1 is set for valuator_lookup_[][] for invalid entry. Some ARM platform/cross-compiler defaults "char" as "unsigned char" which does not accommodate negative value -1. Fixing it by specifically setting the type to "signed char". BUG= TEST= Review URL: http://codereview.chromium.org/7312028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91736 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 91710 - Fix flicker on tab switch on chromeos.johnme@google.com2011-07-072-67/+48
| | | | | | | | | | | | | | | | Caused test failures in views_unittests. ---- BUG=84721 TEST=Switch tabs...no flicker Review URL: http://codereview.chromium.org/7171025 TBR=davemoore@chromium.org Review URL: http://codereview.chromium.org/7312027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91720 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 91716 - Temporarily disable these tests while I repro the crashes.ben@chromium.org2011-07-071-4/+4
| | | | | | | TBR=ben@chromium.org Review URL: http://codereview.chromium.org/7307038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91719 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable these tests while I repro the crashes.ben@chromium.org2011-07-071-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91716 0039d316-1c4b-4281-b951-d872f2087c98
* Fix flicker on tab switch on chromeos.davemoore@chromium.org2011-07-072-48/+67
| | | | | | | | | BUG=84721 TEST=Switch tabs...no flicker Review URL: http://codereview.chromium.org/7171025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91710 0039d316-1c4b-4281-b951-d872f2087c98
* Change the meaning of "Widget::GetTopLevelWidget()" to mean the logical top ↵ben@chromium.org2011-07-0712-9/+436
| | | | | | | | | | | | | | level Window in the views desktop world. Adds the beginning of a set of tests for this behavior. Also fixes the leaks associated with destruction of NativeWidgetViews, and adds a moderately comprehensive set of tests for Widget ownership. BUG=none TEST=none Review URL: http://codereview.chromium.org/7273084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91706 0039d316-1c4b-4281-b951-d872f2087c98
* Rename app_strings to ui_strings.tfarina@chromium.org2011-07-0711-11/+11
| | | | | | | | | | | BUG=72317 TEST=None R=rsesek@chromium.org, tony@chromium.org Review URL: http://codereview.chromium.org/7210060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91704 0039d316-1c4b-4281-b951-d872f2087c98
* Add a test to verify that the data in gtkimcontextsimpleseqs.h is correctly ↵hashimoto@chromium.org2011-07-071-0/+47
| | | | | | | | | | | ordered BUG=chromium-os:17307 TEST=views_unittests success Review URL: http://codereview.chromium.org/7307016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91675 0039d316-1c4b-4281-b951-d872f2087c98
* Changes menu button to not show the menu on alt-space. alt-spacesky@chromium.org2011-07-061-0/+3
| | | | | | | | | | | | | | should show the window menu, so that if menu button consumes this event the window menu is never shown. BUG=56650 TEST=press alt and release, focus should be on the wrench. press alt-space, make sure the window menu appears, not the wrench menu. R=ben@chromium.org Review URL: http://codereview.chromium.org/7315002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91604 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify views/views.gypthakis@chromium.org2011-07-061-18/+0
| | | | | | | | | | | | | These rules are in build/common.gypi already, which is included through the chromium_code: 1 variable. BUG=none TEST=none Review URL: http://codereview.chromium.org/7312007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91597 0039d316-1c4b-4281-b951-d872f2087c98
* Push (not pull) window geometry for the compositor.backer@chromium.org2011-07-063-5/+23
| | | | | | | | | | | The previous implementation used to poll the environment for the window size every drawing cycle. On Linux this is an expensive operation because it requires a round trip to the X server. This CL pushes window size change to the compositor. BUG=none TEST=none Review URL: http://codereview.chromium.org/7212028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91572 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed issue with layers being deleted upon SetVisible with an argument of truebacker@chromium.org2011-07-062-2/+25
| | | | | | | | | | | | | | | Steps for Repro. From a touch build 1) Goto google.com 2) Type into text field 3) Typed text does not show up BUG=87840 TEST=views_unittest (ToggleVisibilityWithLayer) Review URL: http://codereview.chromium.org/7273067 Patch from Peter Kotwicz <pkotwicz@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91563 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to make data in gtkimcontextsimpleseqs.h correctly orderedhashimoto@chromium.org2011-07-061-1/+1
| | | | | | | | | | | | Keycode value of dead_stroke was overwritten with a wrong value in compose-parse.py. This makes the ordering of the data broken. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7278038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91539 0039d316-1c4b-4281-b951-d872f2087c98
* views: Override Label::HitTest with the default View::HitTest for Link.sadrul@chromium.org2011-07-042-0/+7
| | | | | | | | | BUG='Remove' link in the bookmark bubble doesn't work TEST=manually Review URL: http://codereview.chromium.org/7248064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91475 0039d316-1c4b-4281-b951-d872f2087c98
* Labels don't need to respond to mouse clicks and doing so can interfere with ↵finnur@chromium.org2011-07-022-0/+7
| | | | | | | | | | button clicks, for example if the label width extends over a button (in some cases invisibly). BUG=87439 TEST=None. The problem that prompted this has been fixed by Scott, but similar problems might occur in the future so I think it is good to fix the underlying problem as well (since the symptoms are so weird: half a button non-clickable). Review URL: http://codereview.chromium.org/7298009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91421 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary includes of menu_2.h.rhashimoto@chromium.org2011-07-011-1/+0
| | | | | | | | | | BUG=chromium-os:13887 TEST=all platforms still compile Review URL: http://codereview.chromium.org/7273085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91370 0039d316-1c4b-4281-b951-d872f2087c98
* Set has_border = true for NativeTextButton.xiyuan@chromium.org2011-07-012-0/+10
| | | | | | | | | | | | This enables button border for NativeTextButton on Linux/Chromeos. BUG=chromium-os:17202 TEST=Verify fix for chromium-os:17202. Review URL: http://codereview.chromium.org/7210033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91353 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where transform wasn't reset on layer correctly.sky@chromium.org2011-07-012-0/+21
| | | | | | | | | | BUG=none TEST=covered by unit test. R=wjmaclean@chromium.org Review URL: http://codereview.chromium.org/7210048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91317 0039d316-1c4b-4281-b951-d872f2087c98
* Gets compositor working for embedded widgets.sky@chromium.org2011-07-0119-172/+401
| | | | | | | | | | BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/7280002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91312 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to pure view test on touch.saintlou@chromium.org2011-06-301-1/+3
| | | | | | | | | | TBR=ben@chromium.org BUG=none TEST=AccessibilityEventRouterViewsTest.TestFocusNotification Review URL: http://codereview.chromium.org/7278010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91233 0039d316-1c4b-4281-b951-d872f2087c98
* Reverted 7285007 now that r91197 has landedsaintlou@chromium.org2011-06-301-2/+4
| | | | | | | | | | | | Basically having TOUCH_UI => pure-views exposed an issue when pure-views are enabled and deskop is not. Not that this last issue is fixed we can revert that workaround. TBR=sky@chromium.org BUG=none TEST=TouchUi tests Review URL: http://codereview.chromium.org/7294008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91203 0039d316-1c4b-4281-b951-d872f2087c98
* Makes NativeTextButton take focus.motek@chromium.org2011-06-301-0/+1
| | | | | | | | BUG=88029 TEST=none Review URL: http://codereview.chromium.org/7289018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91200 0039d316-1c4b-4281-b951-d872f2087c98
* Handle fake GTK events gracefully.oshima@google.com2011-06-301-1/+6
| | | | | | | | | | | | | | | | GTK sends fake enter/leave event when window activation changes. This event has (0,0) coordinates, which confuses NativeWidgetGtk::TransformEvent and ViewportWidget::OnMouseExited. This is a dirty hack to deal with gtk's fake events. This will be solved properly in NativeWidgetX + pure views. BUG=none TEST=click menu on notification. menu button on the notification shouldn't disappar and does not cause gtk warning. Review URL: http://codereview.chromium.org/7282020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91189 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed for touch buildsaintlou@chromium.org2011-06-301-4/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7285007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91172 0039d316-1c4b-4281-b951-d872f2087c98
* As per oshima:saintlou@chromium.org2011-06-301-0/+4
| | | | | | | | | | | | | | | | | | | | | | | The ultimate goal is to eliminate TOOLKIT_USES_GTK. Once that migration is completed, TOOLKIT_VIEWS + OS_LINUX should be enough. Until this happens, we need a binary that: 1) has both gtk and pure-views 2) can enable pure views components with --use-pure-views when possible (this is default in touchui=1). If we could switch everything with --use-pure-views, that'd be nice, but the world is not perfect and there are things that cannot co-exist (such as message pump). For such component, we'll use GYP_DEFINES to switch. 1) TOOLKIT_USES_PURE_VIEWS is defined with toolkit_pure_views=1. 2) all (or most of) chrome features must be functional with toolkit_pure_views=1 3) both TOOLKIT_USES_GTK and TOOLKIT_USES_PURE_VIEWS are defined. The latter has higher priority (that is, if implementation can't co-exists, TOOLKIT_USE_PURE_VIEWS will take precedence). 4) As the migration proceeds, there will be less TOOLKIT_USES_GTK and more TOOLKIT_USES_PURE_VIEWS. 5) Once the migration is complete (that is, there is no TOOKIT_USES_GTK), we can remove TOOLKIT_USES_PURE_VIEWS or replace it with OS_LINUX when necessary. BUG=none TEST=none Review URL: http://codereview.chromium.org/7273079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91164 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize InputMethodBase after initializing the platforms.sadrul@chromium.org2011-06-303-6/+6
| | | | | | | | | | | | | InputMethodBase::Init does things (e.g. FocusedViewDidChange etc.) that can expect that the platform specific code has already been initialized. So initialize the platforms first. BUG=none TEST=none Review URL: http://codereview.chromium.org/7281025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91126 0039d316-1c4b-4281-b951-d872f2087c98
* views: Remove app from DEPS file.tfarina@chromium.org2011-06-301-1/+0
| | | | | | | | | | | BUG=72317 TEST=None R=sky@chromium.org Review URL: http://codereview.chromium.org/7281019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91069 0039d316-1c4b-4281-b951-d872f2087c98
* views: Fix comment pointing to app/gfx/ instead of ui/gfx.tfarina@chromium.org2011-06-301-3/+3
| | | | | | | | | | | BUG=72317 TEST=None R=sky@chromium.org Review URL: http://codereview.chromium.org/7284019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91068 0039d316-1c4b-4281-b951-d872f2087c98
* Views views_unittests Views and NativeTextFields tests leakdhollowa@chromium.org2011-06-302-26/+28
| | | | | | | | | | | Fixes leaks in ViewTest.* and NativeTextFieldViewsTest.*. BUG=87904 TEST=tools/valgrind/chrome_tests.sh views --gtest_filter=ViewTest.*:NativeTextFieldViewsTest.* Review URL: http://codereview.chromium.org/7280008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91064 0039d316-1c4b-4281-b951-d872f2087c98
* Switch FocusManager to using ObserverList instead of keeping its listeners ↵pkasting@chromium.org2011-06-292-52/+16
| | | | | | | | | | in a simple vector. BUG=none TEST=none Review URL: http://codereview.chromium.org/7280013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91052 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/resources/* to ui/resources/ directory.tfarina@chromium.org2011-06-2913-30/+30
| | | | | | | | | | | BUG=72317 TEST=None R=rsesek@chromium.org Review URL: http://codereview.chromium.org/7253057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91010 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where NativeWidgetViews wasn't setting bounds ofsky@chromium.org2011-06-291-0/+1
| | | | | | | | | | | | NativeWidgetView. This is why menu wasn't showing. BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/7248032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91000 0039d316-1c4b-4281-b951-d872f2087c98
* Rename DesktopWindow to DesktopWindowView.ben@chromium.org2011-06-297-56/+60
| | | | | | | | | BUG=none TEST=none TBR=sky Review URL: http://codereview.chromium.org/7281012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90997 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-06 11:39:45 +0000