summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* bsds: views/ and webkit/ support for FreeBSD/OpenBSDevan@chromium.org2009-12-312-4/+4
| | | | | | | | | - add a TOOLKIT_USES_GTK #define to catch GTK and Views+GTK - lots of ifdef twiddling Review URL: http://codereview.chromium.org/519030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35402 0039d316-1c4b-4281-b951-d872f2087c98
* linux: reduce header interdependenciesevan@chromium.org2009-12-291-0/+4
| | | | | | | | | | | | By analyzing gcc -H output, I found some of our worst offenders for headers bringing in other headers. native_web_keyboard_event.h was responsible for just under 60,000 extra includes! This change will in theory make the build faster. Review URL: http://codereview.chromium.org/524004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35326 0039d316-1c4b-4281-b951-d872f2087c98
* Clarify licenses on a bunch of files.evan@chromium.org2009-12-291-1/+1
| | | | | | | | | | | In this process, I also filed bugs on various projects we depend on that also have unclear licenses. BUG=28291 Review URL: http://codereview.chromium.org/521009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35323 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash/leak issue in native_view_host_gtk.cc.oshima@chromium.org2009-12-239-15/+40
| | | | | | | | | | | | | | | | * There are two path to NativeViewDetaching and we need to handle them differently. 1) Via gtk destroy signal. In this case, we should not try to remove the native view from parent because it's being deleted. 2) Through NativeViewHost::Detach(). In this case we need to remove the native view from parent because we added it to parent in NativeViewAttached(). * Fix NativeControlGtk not to destroy the native view because it's now destoryed by NativeViewHostGtk. * Fixed TabContentViewGtk so that it owns the nativew view. The native view was destroyed when Detached. * Added more checks so that test can catch regression. BUG=26154 TEST=The same procedure in bug should now pass. I added several checks that lead tests to fail if this problem exists. Review URL: http://codereview.chromium.org/510004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35220 0039d316-1c4b-4281-b951-d872f2087c98
* Add GridLayout::SetInsets(const gfx::Insets& insets).satorux@chromium.org2009-12-232-0/+10
| | | | | | | | | | | | | | | | | Per the style guide, function overloading like this is allowed. http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Function_Overloading#Function_Overloading I wanted this API so I could define and use a constant like: const gfx::Insets kSomeInsets(1, 2, 3, 4); layout->SetInsets(kSomeInsets); BUG=none TEST=try Review URL: http://codereview.chromium.org/509027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35209 0039d316-1c4b-4281-b951-d872f2087c98
* Change chromeos build to use viewsoshima@chromium.org2009-12-221-3/+0
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/508025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35186 0039d316-1c4b-4281-b951-d872f2087c98
* Fix radio items in views::Menu2 for Linux.satorux@chromium.org2009-12-161-0/+10
| | | | | | | | | | | | | | | Suppose there are three radio items A, B, C, and A is now being checked. If you click C, commands associated with A and C are both executed. This is because A also receives the "activate" signal, before C receives it. We want only the command associated with A to get executed. BUG=30310 TEST=try; manually with view_examples Review URL: http://codereview.chromium.org/491076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34644 0039d316-1c4b-4281-b951-d872f2087c98
* Add views/examples/menu_example.hsatorux@chromium.org2009-12-163-1/+209
| | | | | | | | | | | | | The example demonstrates how to create a menu with regular, radio, and check items. The example revealed a bug: http://crbug.com/30310. I have a separate change to fix the bug. TEST=try; manually BUG=30310 Review URL: http://codereview.chromium.org/495017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34640 0039d316-1c4b-4281-b951-d872f2087c98
* Give classes with virtual methods virtual protected destructors instead of ↵jamesr@chromium.org2009-12-162-2/+13
| | | | | | | | | | | | | | | | | | | | | | implicit non-virtual public destructors. Was originally: Replace public nonvirtual destructors in classes with virtual members with protected nonvirtual destructors where possible, and with public virtual destructors where destruction of a derived class occurs. (Excluding chrome/browser/...) (Part 4 of http://www.gotw.ca/publications/mill18.htm has a rationale for why public nonvirtual destructors in classes with virtual members is dangerous.) Patch by: Jacob Mandelson (jlmjln@gmail.com) BUG=none TEST=base_unittests & app_unittests Review URL: http://codereview.chromium.org/200106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34633 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two related bugs:sky@chromium.org2009-12-155-7/+143
| | | | | | | | | | | | | | | | | | | . Native buttons were adding 8 pixels to each side of the preferred size. This isn't necessary on Gtk as the preferred size already includes padding. . I changed WidgetGtk so that it no longer needs to explicitly set a size request. Explicitly setting a size request is a bit of pain because it means you can't ask for the widget real size request without unsetting the explicit size request. Instead I've subclassed GtkFixed so that you can either have the default behavior, or use the allocated size rather than current size. CHROME_OS_BUG=1003 TEST=see bug Review URL: http://codereview.chromium.org/504003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34564 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a hidden dependency from view_examples to chrome on Linux.satorux@chromium.org2009-12-122-2/+1
| | | | | | | | | | | | | We no longer need to build chrome first just for the resource files. Adding a dependency to "packed_resources" is sufficient. TEST=try; locally clean built view_examples on linux BUG=29969 Review URL: http://codereview.chromium.org/487020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34412 0039d316-1c4b-4281-b951-d872f2087c98
* Add views/examples/slider_example.hsatorux@chromium.org2009-12-102-2/+63
| | | | | | | | | | | | | The example demonstrates how to use the Slider class. BUG=none TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34142 Review URL: http://codereview.chromium.org/466055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34223 0039d316-1c4b-4281-b951-d872f2087c98
* A collection of fixes allowing the chrome.experimental.popup.* set of APIs ↵twiz@google.com2009-12-101-1/+3
| | | | | | | | to function in circumstances where there is no Browser instance present. This is a symptom of a tab-contents view hosted in an ExternalTabContainer.The major change here is the removal of the explicit dependency on a Browser instance across all of the delegates involved when showing a pop-up API. I modified the following delegates:- ExtensionPopupHost::Delegate- TabContentsDelegate- ExtensionFunctionDispatcher::DelegateBecause the pop-up requires a Profile, and a gfx::NativeWindow, I added methods to the above interfaces to provide them.BUG=noneTEST=ExtensionApiTest.FLAKY_Popup Review URL: http://codereview.chromium.org/434046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34219 0039d316-1c4b-4281-b951-d872f2087c98
* Uses X mechanisms to get the screen size in the event that there's no window ↵cmasone@google.com2009-12-091-2/+27
| | | | | | | | manager to query. Review URL: http://codereview.chromium.org/460134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34159 0039d316-1c4b-4281-b951-d872f2087c98
* Compute where to place a popup widget in WidgetExample.satorux@chromium.org2009-12-091-1/+12
| | | | | | | | | | | This is to demonstrate how to compute a position. TEST=manually BUG=none Review URL: http://codereview.chromium.org/460104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34149 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34142 - Add views/examples/slider_example.hjrg@chromium.org2009-12-092-57/+1
| | | | | | | | | | | | | | The example demonstrates how to use the Slider class. BUG=none TEST=manually Review URL: http://codereview.chromium.org/466055 TBR=satorux@chromium.org Review URL: http://codereview.chromium.org/467062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34144 0039d316-1c4b-4281-b951-d872f2087c98
* Add views/examples/slider_example.hsatorux@chromium.org2009-12-092-1/+57
| | | | | | | | | | | The example demonstrates how to use the Slider class. BUG=none TEST=manually Review URL: http://codereview.chromium.org/466055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34142 0039d316-1c4b-4281-b951-d872f2087c98
* Spruce up the notification UI to much more closely match the mocks, ↵johnnyg@chromium.org2009-12-052-11/+67
| | | | | | | | | | | | | including a new stylesheet from Glen for text+icon notifications, and little icons for the buttons. Part of the CL includes new features for TextButton class to control icon placement and appearance on hover. BUG=none TEST=notifications Review URL: http://codereview.chromium.org/450045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33899 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in textfield on views/gtk where we weren't properlysky@chromium.org2009-12-042-21/+23
| | | | | | | | | | | | | accounting for border size if not specified by style. Also changes button on views/gtk not to fix the pref height at 29. There is no reason for us to do this. BUG=none TEST=none Review URL: http://codereview.chromium.org/462036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33882 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/466002 for Thiago:sky@chromium.org2009-12-042-5/+5
| | | | | | | | | | | Switch a CSize variable (WTL) to use the gfx::Size type. BUG=2186 TEST=compiles Review URL: http://codereview.chromium.org/466039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33877 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the menu model to live outside views/ so it can be sharedpinkerton@chromium.org2009-12-0420-473/+67
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/465005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33827 0039d316-1c4b-4281-b951-d872f2087c98
* Downward drag after mouse-down is now causing bookmark bar folders to open, ↵zelidrag@google.com2009-12-042-2/+16
| | | | | | | | | | | | | | rather than drag. The bar folder can still be dragged in any other direction. Please note that this change is already reviews in http://codereview.chromium.org/463001, hence TBR field here. I needed to move to a different client to check it in. BUG=9016 TEST=Open bookmark bar. Select folder button and try to drag it down. Observe that now if dragged straight downward, the folder button will open its menu. TBR=sky Review URL: http://codereview.chromium.org/467017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33805 0039d316-1c4b-4281-b951-d872f2087c98
* Implement keyboard access between bookmarks and main toolbar.mhm@chromium.org2009-12-042-0/+15
| | | | | | | | | | | | | | | | Allow ALT+SHIFT+T and TAB to traverse between bookmarks bar and main toolbar, same thing goes for SHIFT+TAB. Once any toolbar is focused, the arrow keys are used to traverse its children views. Any toolbar that needs to be traversable needs to extend "AccessibleToolbarView", that class will deal with all the toolbar accessibility needs such as handling ESC, Left/Right arrows, Enter, Drop downs, and traversals with Tab/Shift+Tab. There is one abstract method that the views who are extending this would need to implement if needed which allows the toolbar to skip views that are being traversed: bool IsAccessibleViewTraversable(views::View* view) BUG=25625 TEST=Test to see if the main toolbar and bookmarks bar is traversable. Review URL: http://codereview.chromium.org/333010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33793 0039d316-1c4b-4281-b951-d872f2087c98
* widget_gtk: Alphabetize CallXXX() functions.tony@chromium.org2009-12-032-114/+125
| | | | | | | | | | | BUG=None TEST=None Patch written by Thiago Farina <thiago.farina@gmail.com>. Review URL: http://codereview.chromium.org/451001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33745 0039d316-1c4b-4281-b951-d872f2087c98
* Makes views not draw focus for native controls on Gtk. As Gtk renderssky@chromium.org2009-12-0314-12/+63
| | | | | | | | | | | the focus for us, this resulted in double the focus indicators. BUG=none TEST=none Review URL: http://codereview.chromium.org/468004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33739 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/449003/show for Thiago:sky@chromium.org2009-12-0117-36/+39
| | | | | | | | | | | | | | views: replace the deprecated macro (DISALLOW_EVIL_CONSTRUCTORS). Use DISALLOW_COPY_AND_ASSIGN instead, also fix some style issues pointed by lint. BUG=none TEST=none Review URL: http://codereview.chromium.org/449075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33500 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in views/gtk tooltips. Gtk wraps text in labels atsky@chromium.org2009-12-013-14/+40
| | | | | | | | | | | | | | (screen_size + 1) / 2. I'm setting the max width of tooltips to match this else gtk can calculate more vertical white space than it ends up using. Simiarly when resetting the text in a label gtk doesn't reset wrap position. I'm forcing that by invoking set_max_width_chars. BUG=none TEST=none Review URL: http://codereview.chromium.org/454023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33494 0039d316-1c4b-4281-b951-d872f2087c98
* Porting the table view to Linux toolkit views.jcampan@chromium.org2009-12-0110-33/+465
| | | | | | | | | | | | | | It is the initial implementation, it is still missing: - row focusing - resizable columns - autosize columns BUG=None TEST=Run the unit-tests, play with the TableView2 tab in the view examples. Review URL: http://codereview.chromium.org/434066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33400 0039d316-1c4b-4281-b951-d872f2087c98
* Adds link to bookmark bar that when clicked imports bookmarks. I alsosky@chromium.org2009-11-306-15/+81
| | | | | | | | | | | | added support for baselines to GridLayout. BUG=4374 TEST=On a new profile make sure the bookmark bar has a link to import bookmarks, click the link and make sure you can import your bookmarks. Review URL: http://codereview.chromium.org/440029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33336 0039d316-1c4b-4281-b951-d872f2087c98
* Makes sure gtk menus fit on screen before showing them.sky@chromium.org2009-11-301-4/+12
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/434106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33328 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug that could lead to mouse motion events percolating up tosky@chromium.org2009-11-301-1/+1
| | | | | | | | | | | | next window when they shouldn't. This manifested itself as buttons highlighting when the mose wasn't over them. BUG=none TEST=none Review URL: http://codereview.chromium.org/454005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33321 0039d316-1c4b-4281-b951-d872f2087c98
* Make SystemMonitor not a Singleton and move it out of basephajdan.jr@chromium.org2009-11-262-2/+2
| | | | | | | | | | | | | SystemMonitor makes an assumption that through its lifetime a MessageLoop exists and stays the same. It is difficult and error-prone to satisfy that when it is a Singleton. It has caused problems in the past. Additionally, extract HighResoltionTimerManager out of time_win.cc, eliminating yet another Singleton. TEST=none BUG=none Review URL: http://codereview.chromium.org/431008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33214 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in tooltips. I was freeing a PangoFontDescription that Isky@chromium.org2009-11-252-11/+6
| | | | | | | | | | | | shouldn't have. I also added code to set the name of the widgets created by WidgetGtk. BUG=none TEST=none Review URL: http://codereview.chromium.org/443006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33117 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid double freeing image list in TableView.mal@chromium.org2009-11-252-13/+0
| | | | | | | | | | | Committing http://codereview.chromium.org/387056 on behalf of Dan. BUG=27729 TEST=run NullModelTableViewTest.NullModel in app verifier or wine TBR= dank,jhawkins Review URL: http://codereview.chromium.org/437054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33055 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two bugs in tree view:sky@chromium.org2009-11-251-4/+9
| | | | | | | | | | | | | | | | | . Invoking SetRootShown before the tree was created resulted in updating internal structures with wrong info. This caused problems if you later tried to delete. I've added a DCHECK to make sure we don't hit this again. . Adding a node to the root when the root wasn't shown silently failed. BUG=none TEST=make sure bookmark manager doesn't have any problems when adding/removing nodes. Review URL: http://codereview.chromium.org/434053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33023 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash on double clicking in the upper right corner of thesky@chromium.org2009-11-241-4/+6
| | | | | | | | | | | | window. For some reason gtk_window_begin_move_drag crashes when invoked for double/triple clicks. BUG=none TEST=none Review URL: http://codereview.chromium.org/434045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32976 0039d316-1c4b-4281-b951-d872f2087c98
* Group Menu2Model::TYPE_RADIO menu items correctly. Currently an ↵yusukes@google.com2009-11-242-9/+26
| | | | | | | | | | | | | | implementation of the Menu2Model::GetGroupIdAt() interface seems to be ignored. This change is necessary in order to implement the menu for Chrome OS Text Input: https://sites.google.com/a/google.com/chromium-developer-central/chromiumos-1/chromiumos-design-docs/text-input/input.png?attredirects=0 BUG=none TEST=none Review URL: http://codereview.chromium.org/414031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32903 0039d316-1c4b-4281-b951-d872f2087c98
* views: remove some unnecessary static_cast<int>.maruel@chromium.org2009-11-232-6/+5
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/429004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32837 0039d316-1c4b-4281-b951-d872f2087c98
* Use AutoReset (formerly ScopedBool) where possible.pkasting@chromium.org2009-11-202-4/+4
| | | | | | | | | | This frequently saves a tiny bit of code, but even when it doesn't I think it's more future-proof (less error-prone). BUG=none TEST=none Review URL: http://codereview.chromium.org/399096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32708 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two issues from valgrind, and some cleanup:sky@chromium.org2009-11-204-10/+17
| | | | | | | | | | | | | | | . Makes it so observer installed by WidgetGtk is cleaned up and not leaked. . Removes unnecessary static_cast<int> in view. . Fixes some leaks in textfield and button. . Removes AutocompletePopupViewGTK's copy of PangoFontFromGfxFont. BUG=none TEST=none Review URL: http://codereview.chromium.org/420005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32686 0039d316-1c4b-4281-b951-d872f2087c98
* Making grd dependencies more correct for grds in app.bradnelson@google.com2009-11-201-1/+1
| | | | | | | | | BUG=17706 TEST=None Review URL: http://codereview.chromium.org/414006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32602 0039d316-1c4b-4281-b951-d872f2087c98
* Add examples/widget_example.h to sources of view_examples.satorux@chromium.org2009-11-201-0/+1
| | | | | | | view_examples is just built fine without the line, but good to explicit. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32592 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a comment in views/border.h.satorux@chromium.org2009-11-201-1/+1
| | | | | | | | | | | | | | | | Change views->SetBorder(...) to views->set_border(...). The latter is the right function name in views/view.h: // The border object is owned by this object and may be NULL. void set_border(Border* b) { border_.reset(b); } const Border* border() const { return border_.get(); } BUG=none TEST=none Review URL: http://codereview.chromium.org/405032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32590 0039d316-1c4b-4281-b951-d872f2087c98
* Add views/examples/widget_example.h.satorux@google.com2009-11-192-1/+93
| | | | | | | | | | | | | The example demonstrates how to create a popup widget. BUG=none TEST=manually tested on a linux machine. Review URL: http://codereview.chromium.org/406001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32490 0039d316-1c4b-4281-b951-d872f2087c98
* Add an option to tree_view for whether to show lines from the root nodeian@chromium.org2009-11-182-3/+33
| | | | | | | | | | | | | to children nodes (sets TVS_LINESATROOT). Set this to false by default (maintaining existing behaviour by default), except for cookies_view where we set it to true. BUG=27657 TEST=open cookies dialog, make sure the origins have a + box next to them, and that expanding these also expands the cookies folder beneath them. Review URL: http://codereview.chromium.org/399030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32334 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for BookmarkManager Test Crash test.oshima@chromium.org2009-11-181-1/+5
| | | | | | | | | | | | | | | * Test was failing because the key events were sent even after the window has been destroyed. * Make sure browser window is closed before the end of test. Test fails in BookmarkBarView without this. I think this requires a fix on browser side. Filed a bug 28046. BUG=None Test=run browser_tests --gtest_filter=*Bookmark* Review URL: http://codereview.chromium.org/397034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32286 0039d316-1c4b-4281-b951-d872f2087c98
* Fix race conditions where an object's constructor uses PostTask on itself. ↵jam@chromium.org2009-11-172-4/+9
| | | | | | | | | This isn't safe since the posted task can execute before the constructor returns, leading to destruction of the object. BUG=27944 Review URL: http://codereview.chromium.org/399016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32213 0039d316-1c4b-4281-b951-d872f2087c98
* Remove new tabstrip code. Going to try doing this a different way.ben@chromium.org2009-11-173-264/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/400005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32197 0039d316-1c4b-4281-b951-d872f2087c98
* Make the char encoding indicator visible again on Windowsjshin@chromium.org2009-11-161-1/+2
| | | | | | | | | | | BUG=26438 TEST=Go to any web page and see if the character encoding is indicated in Page menu - Encoding. Patch by Satoshi.Matsuzaki with a slight modification.`(see the bug) Review URL: http://codereview.chromium.org/391066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32064 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 32012-32017mhm@chromium.org2009-11-152-15/+0
| | | | | | | | | | | git cl dcommit somehow committed all my local changes in cygwin TBR=evan BUG=none Review URL: http://codereview.chromium.org/396006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32019 0039d316-1c4b-4281-b951-d872f2087c98