summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* [Accessibility] Chrome's main window is missing an accessible namectguil@chromium.org2010-03-172-0/+4
| | | | | | | | | BUG=36732 TEST=Verify Chrome's main window has a name in AccExplorer or run the new test. Review URL: http://codereview.chromium.org/661054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41882 0039d316-1c4b-4281-b951-d872f2087c98
* Implement selection of rows on mouse clicks in TableView2 for GTK.satorux@chromium.org2010-03-173-2/+29
| | | | | | | | | | | | Before this change, clicking rows in TableView2 for GTK did not select the clicked rows. TEST=manually with view_examples. BUG=none Review URL: http://codereview.chromium.org/1015005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41825 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more files to toplevel gfx dir.ben@chromium.org2010-03-1737-38/+39
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41812 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Make DevTools open docked by default for chrome os."tony@chromium.org2010-03-164-101/+381
| | | | | | | | | | | This reverts commit r41641 because all the devtools interactive_ui_tests are failing. TBR=xiyuan Review URL: http://codereview.chromium.org/1007004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41691 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply r41640.ajwong@chromium.org2010-03-166-3/+57
| | | | | | | | | | Original patch by thiago.farina@gmail.com Revision r41640 was reverted in r41676 because it looked like it might have been responsible for Interactive UI test failures in linux and windows. However, reverting didn't fix, so I'm reapplying it. Review URL: http://codereview.chromium.org/982004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41683 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk views code touch upxiyuan@chromium.org2010-03-163-12/+36
| | | | | | | | | | | | | | | | | - Fix wrong mouse event coordinates in gtk event handlers. Gtk events could be propogate to parent if child does not handle it and we need to translate the coordinates in gtk event in this case; - Consume button pressed event if a widget is not transparent; - Move mouse cursor reset handling on mouse leave from WindowGtk into RootView. This is because once WindowGtk set a mouse cursor, it stucks there and RootView could not change it. BUG=None TEST=Verify the following two cases: 1. Click on top of a tab should not move chrome; 2. Dock devtools and mouse cursor should change correct on the split and change back to left pointer on leave the split; Review URL: http://codereview.chromium.org/997002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41681 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Landing tfarina CL. " because it broke Interactive UI tests on Linux ↵ajwong@chromium.org2010-03-166-57/+3
| | | | | | | | | | and Windows. This reverts r41640. Review URL: http://codereview.chromium.org/1037001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41676 0039d316-1c4b-4281-b951-d872f2087c98
* Provide Web Contents accessibility info.ctguil@chromium.org2010-03-162-1/+25
| | | | | | | | | BUG=36286 TEST=Verify accessibility info in AccExplorer32.exe. Review URL: http://codereview.chromium.org/652199 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41662 0039d316-1c4b-4281-b951-d872f2087c98
* Make DevTools open docked by default for chrome os.xiyuan@chromium.org2010-03-154-381/+101
| | | | | | | | | | | | | | | | | | | | | | | | | | - Change prefs::kDevToolsOpenDocked default to "true" for chrome os; - Fix a problem on chrome os that DevTools occupies the whole client area. This is because BrowserView::Show is called before gtk size allocated event and thus divider offset is calculated wrongly to 0. The fix is to move the "restore split offset" logic to UpdateDevToolsForContents before we do contents_split_ layout for show up DevTools; - Fix a problem that DevTools becomes invisible after undock then dock for linux toolkit_view/chromeos build. This is because browser/views/tab_contents/TabContentsViewGtk does not show/hide its contained TabContents like TabContentsViewWin. As mentioned in BrowserWindowGtk::UpdateDevToolsForContents, the fix is to hook up gtk show/hide signal and notify the contained TabContents about the visibility change. After the fix, remove the manual ShowContents for DevTools in BrowserWindowGtk::UpdateDevToolsForContents. <http://crosbug.com/333> BUG=333 TEST=Verify that DevTools show up as docked by default. Review URL: http://codereview.chromium.org/880003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41641 0039d316-1c4b-4281-b951-d872f2087c98
* Landing tfarina CL. ctguil@chromium.org2010-03-156-3/+57
| | | | | | | | | | | | | Original patch by thiago.farina@gmail.com See original review at: http://codereview.chromium.org/820001/show BUG=9616, 36281 TEST=point AccExplorer to the clear browsing data dialog, every control should be identified and should have the correct values. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41640 0039d316-1c4b-4281-b951-d872f2087c98
* Switched progress bar to integral positions (from 0 to 100).avayvod@google.com2010-03-153-33/+26
| | | | | | | | | | | BUG=none TEST=Launch with --login-manager --login-screen=update and verify that progress bar shows increasing progress and login screen is shown at the end. Review URL: http://codereview.chromium.org/945003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41580 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/gfx contents to gfx/ben@chromium.org2010-03-1417-23/+23
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41559 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-1411-26/+42
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/851010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41539 0039d316-1c4b-4281-b951-d872f2087c98
* Create a toplevel gfx/ dir and seed it with icon_util.ben@chromium.org2010-03-135-8/+9
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/915002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41528 0039d316-1c4b-4281-b951-d872f2087c98
* remove itself from parent when deleted.oshima@chromium.org2010-03-121-2/+4
| | | | | | | | | | | | | | In most case, this won't happen because the parent view sets child view's parent to NULL before deletion. This is necessary to safely delete view that is not owned by parent. BUG=none TEST=none Review URL: http://codereview.chromium.org/872006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41485 0039d316-1c4b-4281-b951-d872f2087c98
* Autoslide/hide notifications after timeout.oshima@chromium.org2010-03-122-0/+9
| | | | | | | | | | | | | | * Introduced panel's state to manage which notifications will be shown.' * Added "OnPanelStateChanged" to PanelController::Delegate method to monitor the panel's state. * Removed unnecessary SetSize in BalloonViewImpl. The size is set in BalloonViewImpl::Layout. BUG=33306 TEST=This requires chromeos's wm and system notification to test (which does not exit yet). None for now but I am writing unittest now. Review URL: http://codereview.chromium.org/874004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41484 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of a progress bar control.finnur@chromium.org2010-03-124-0/+348
| | | | | | | | | | | | BUG=37960 TEST=Unit tests provided, run chrome_tests. Checking in patch from Denis Romanov, reviewed as: http://codereview.chromium.org/889001/show Review URL: http://codereview.chromium.org/842007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41436 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a hack that, as far as I can tell, isn't needed.pkasting@chromium.org2010-03-121-5/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/871005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41383 0039d316-1c4b-4281-b951-d872f2087c98
* Last set of tweaks to icon positioning code. Clarifies positioning ↵pkasting@chromium.org2010-03-121-32/+21
| | | | | | | | | | algorithm, and for non-Windows, modifies sizing algorithm to just make the icon size be the same as the titlebar font size, minimum 16 px, since the old crazy code just seemed wrong. BUG=none TEST=none Review URL: http://codereview.chromium.org/807001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41382 0039d316-1c4b-4281-b951-d872f2087c98
* Unblock focus signal handlers only when they're blocked.oshima@chromium.org2010-03-111-11/+18
| | | | | | | | | | | | Unblocking fails when handlers are not blocked. Minor fix. use correct data type for signal handler id. BUG=none TEST=none Review URL: http://codereview.chromium.org/844003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41318 0039d316-1c4b-4281-b951-d872f2087c98
* win: string_util.h -> utf_string_conversions.h fix.jhawkins@google.com2010-03-117-6/+7
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/830002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41292 0039d316-1c4b-4281-b951-d872f2087c98
* Initial focus fix on x11/gtkoshima@chromium.org2010-03-102-2/+9
| | | | | | | | | | | | | The initial focus on x11/gtk was not working propertly. It was jsut working by coincident, and chromeos's compact location bar revealed the bug. This CL fixes by setting a focus when the window itself gets focus. BUG=34159 TEST=on chromeos build, omnibox should have a focus on a new window. Review URL: http://codereview.chromium.org/756002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41187 0039d316-1c4b-4281-b951-d872f2087c98
* Landing tfarina CL. ctguil@chromium.org2010-03-106-10/+32
| | | | | | | | | | | | | | Original patch by thiago.farina@gmail.com See original review at: http://codereview.chromium.org/668225/show BUG=9616 TEST=opens AccExplorer2, opens clear browsing data, select the a checkbox+label with the AccExplorer2 tool, see if the role for this control is checkbox. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41178 0039d316-1c4b-4281-b951-d872f2087c98
* Final removal of the bad dependency of chrome/common on chrome/browserphajdan.jr@chromium.org2010-03-101-18/+19
| | | | | | | | | | | Also convert app/gtk_dnd_util.h from a class to a namespace for consistency with added app/gtk_util.h. TEST=none BUG=none Review URL: http://codereview.chromium.org/669268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41177 0039d316-1c4b-4281-b951-d872f2087c98
* Modify WidgetWin::Init() such that it doesn't create the FocusManager if the ↵marshall@chromium.org2010-03-101-2/+5
| | | | | | | | | | | | window is style WS_CHILD and parented to the desktop. We intentionally set the parent to the desktop window to remove it from the FocusManager hierarchy while the window is hidden. BUG=37698 TEST=NONE Was: http://codereview.chromium.org/812004 Review URL: http://codereview.chromium.org/790005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41171 0039d316-1c4b-4281-b951-d872f2087c98
* Add a gyp target for Xext to linux/system so that Views can depend on it. A ↵davemoore@chromium.org2010-03-101-0/+1
| | | | | | | | recent change added a code dependency within Views on linux on this library. Chrome was linking with it but other Views apps (candidate_window) weren't Review URL: http://codereview.chromium.org/758002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41097 0039d316-1c4b-4281-b951-d872f2087c98
* Support popups that don't accept clicks in Views/Linuxdavemoore@chromium.org2010-03-092-1/+55
| | | | | | | | | | | | The status bubbles were accepting clicks in Linux, which prevented controls in the bottom left corner from being clicked on. BUG=None TEST=On cros open the calculator panel. The "0" should be clickable. Review URL: http://codereview.chromium.org/698001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41072 0039d316-1c4b-4281-b951-d872f2087c98
* views: Make WindowGtk set transient-for hint before mapping.derat@chromium.org2010-03-091-3/+3
| | | | | | | | | | | | | | | Otherwise, there's a race as to whether the hint will be set when the window manager handles the window's MapNotify event. (The Chrome OS window manager currently ignores any attempts by clients to change transient-for hints on windows that have already been mapped, for instance.) BUG=chromium-os:1587 TEST=seems to work Review URL: http://codereview.chromium.org/686001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41036 0039d316-1c4b-4281-b951-d872f2087c98
* Move wtl from chrome/third_party to third_party/. Thistony@chromium.org2010-03-091-4/+3
| | | | | | | | | | | breaks dependencies on chrome from webkit, app, views and base. BUG=37649 TEST=compiles Review URL: http://codereview.chromium.org/699001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41001 0039d316-1c4b-4281-b951-d872f2087c98
* svn prop fixes. Applied to all files not in third_party.pkasting@chromium.org2010-03-092-0/+0
| | | | | | | | | | | | * Removed eol-style, executable and mergeinfo from BMP/GIF/ICO/JPEG files, and set correct mime-type. * Removed executable and mergeinfo from .c/.cc/.cpp/.h/.m/.mm and .gyp files, and set eol-style to LF. TBR=evanm BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40991 0039d316-1c4b-4281-b951-d872f2087c98
* Replace lots of "int x, int y" with gfx::Point. Also use gfx::Size and ↵pkasting@chromium.org2010-03-0850-366/+281
| | | | | | | | | | gfx::Rect in a few more places. BUG=none TEST=none Review URL: http://codereview.chromium.org/669130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40966 0039d316-1c4b-4281-b951-d872f2087c98
* Use web app icon as ICON_BIG for Windowsxiyuan@chromium.org2010-03-083-1/+15
| | | | | | | | | | | | | | | | | - Add a WindowDelegate::GetWindowAppIcon for BrowserView to expose an icon to use as ICON_BIG; - Add an app_icon_ memeber and accessor functions to TabContents; - Update/Set the app_icon_ of TabContents when web app icon is downloaded for converting a tab to app or for chrome web app shortcuts update (this happens when chrome is opened as an app; - Use the app icon as ICON_BIG in WindowWin::UpdateWindowIcon; BUG=32039 TEST=Verify fix for issue 32039 and also Alt-Tab list on XP/Vista uses big icon. Review URL: http://codereview.chromium.org/668265 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40962 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up/fix more frame code. In general this is bringing the less-common ↵pkasting@chromium.org2010-03-082-142/+141
| | | | | | | | | | | | frame classes up to speed with recent changes in OpaqueBrowserFrameView, but there's also some other fixing of bustage, old patches that didn't make it into all the classes, etc. This isn't perfect yet: the calculations of icon and titlebar size/position for really large icons need to have more padding in them. But this change is already so large I'd rather get it in and then patch that up. BUG=6961 TEST=Sysmenu works on all frame types, app panels can be maximized, all frame types handle larger titlebar sizes and/or fonts Review URL: http://codereview.chromium.org/669291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40950 0039d316-1c4b-4281-b951-d872f2087c98
* Don't mirror menu position for RTL because on Windows we set RLT window ↵dpolukhin@google.com2010-03-063-23/+22
| | | | | | | | | | | | | flags and Window does it for us. Place mirroring changes from http://codereview.chromium.org/601032 to GTK specific part. TEST=In TRL layout check drop down menus on Windows, Linux and Chrome OS - on all platforms menu should be inside Chrome window. BUG=36627 Review URL: http://codereview.chromium.org/660376 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40838 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break.johnnyg@chromium.org2010-03-041-2/+2
| | | | | | | | | | TBR=oshima BUG=none TEST=none Review URL: http://codereview.chromium.org/668095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40675 0039d316-1c4b-4281-b951-d872f2087c98
* On Windows, detect the WM_DISPLAYCHANGE message which indicates the desktop ↵johnnyg@chromium.org2010-03-046-2/+70
| | | | | | | | | | | size is changing. Pass this event using the NotificationService, and listen for it in desktop notification code in order to adjust metrics properly for the corner of the screen. BUG=35464 TEST=resize desktop after starting chrome; create notifications. Review URL: http://codereview.chromium.org/606007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40670 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up TooltipManagerWin a bit. Original patch by Jay Soffian (see ↵pkasting@chromium.org2010-03-043-36/+28
| | | | | | | | | http://codereview.chromium.org/668021 ), r=me. BUG=37368 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40662 0039d316-1c4b-4281-b951-d872f2087c98
* Correct positioning of tooltips in nonclient portion of Aero windows. ↵pkasting@chromium.org2010-03-041-0/+6
| | | | | | | | | Original patch by Jay Soffian (see http://codereview.chromium.org/652104 ), r=me. BUG=36489 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40656 0039d316-1c4b-4281-b951-d872f2087c98
* Removes static storage of menu-marker bitmap. Tiny change.glotov@google.com2010-03-042-15/+13
| | | | | | | | | | | | | | | | | The problem was when I change the language (current locale), I reset (delete and re-create) all views to make sure they don't reference old locale still. This menu-marker bitmap was the only object that remained to reference old, deleted locale after resetting. As ResourceBundle::GetBitmapNamed() caches its resources, I believe that this CL doesn't cause bitmaps bloat. BUG=none TEST=none Review URL: http://codereview.chromium.org/668067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40640 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unititalized variables.finnur@chromium.org2010-03-031-2/+2
| | | | | | | | | | | | Should fix the build. TBR=denisromanov BUG=None TEST=None Review URL: http://codereview.chromium.org/669002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40561 0039d316-1c4b-4281-b951-d872f2087c98
* Checking in patch for Denis Romanov (originally reviewed here: ↵finnur@chromium.org2010-03-034-21/+69
| | | | | | | | | | | | | | http://codereview.chromium.org/651027). Make mouse wheel scroll contents of views::ScrollView control in Linux (GTK). BUG=26970 TEST=Make and run out/Debug/view_examples and scroll in ScrollView tab. TBR=denisromanov Review URL: http://codereview.chromium.org/667008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40555 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/652010 for Thiago:sky@chromium.org2010-03-022-2/+68
| | | | | | | | | | | | | views: refactor out the "Alt" TableView feature. BUG=34181 TEST=open bookmarks manager, type something in the search text-field, see if a message is showed when there is no match and see if everything still works as before. Review URL: http://codereview.chromium.org/660380 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40406 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a Chrome crash, which occurs in a ChromeFrame instance in the destructor ↵ananta@chromium.org2010-03-021-2/+3
| | | | | | | | | | | | | | | | | | | | of the WidgetWin object for the ExternalTabContainer. Basically the crash happens while dereferencing the chrome ui message loop which has been destroyed. This could happen in a ChromeFrame instance as the message loop is destroyed when the module ref count drops to 0. The ref count is decremented in the destructor of the AutomationProvider which runs before the Widgetwin destructor. Fix is to move the code in the WidgetWin destructor to the code which processes WM_NCDESTROY Fixes bug http://code.google.com/p/chromium/issues/detail?id=37163 Bug=37163 Review URL: http://codereview.chromium.org/663001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40393 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile error "error: #elif with no expression"nsylvain@chromium.org2010-02-271-1/+1
| | | | | | Review URL: http://codereview.chromium.org/660190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40195 0039d316-1c4b-4281-b951-d872f2087c98
* Move skia_utils_gtk.cc/.h to app/gfx/. Original patch by Thiago Farina (see ↵pkasting@chromium.org2010-02-263-10/+10
| | | | | | | | | http://codereview.chromium.org/660063 ), r=me. BUG=22853 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40083 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in dragging from download manager on chrome os.sky@chromium.org2010-02-251-2/+2
| | | | | | | | | | BUG=36516 TEST=on chromeos drag from the download manager and make sure we don't crash. Review URL: http://codereview.chromium.org/660088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40040 0039d316-1c4b-4281-b951-d872f2087c98
* Changes grid layout such that if a view that spans columns preferredsky@chromium.org2010-02-242-9/+48
| | | | | | | | | | | | | width is bigger than the sum of preferred width of the views that don't span columns, then the extra space is distributed using the resize percent rather than evenly distributed. BUG=34156 TEST=none (covered by unit tests) Review URL: http://codereview.chromium.org/660001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39933 0039d316-1c4b-4281-b951-d872f2087c98
* Landing Marshall Greenblatt change.jcampan@chromium.org2010-02-244-8/+93
| | | | | | | | | | | | | See review at: http://codereview.chromium.org/609010/show BUG=None TEST=None Review URL: http://codereview.chromium.org/657019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39827 0039d316-1c4b-4281-b951-d872f2087c98
* New network menu button UI for ChromeOS.chocobo@chromium.org2010-02-191-0/+11
| | | | | | | | | Added ability to change label font in gtk menu item. TEST=none BUG=none Review URL: http://codereview.chromium.org/650074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39516 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where on views/gtk we send an exit before every press. We'resky@chromium.org2010-02-191-13/+25
| | | | | | | | | | | | | still sending the exit before the press as I couldn't find any where to discern these events, but at least now we're sending an enter so that the sequence is exit enter press rather than exit press. BUG=none TEST=none Review URL: http://codereview.chromium.org/650054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39514 0039d316-1c4b-4281-b951-d872f2087c98