summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Make the first-run search engine choice dialog accessible todmazzoni@chromium.org2010-09-303-1/+25
| | | | | | | | | | | Windows screenreaders. BUG=none TEST=manual testing with and without JAWS and NVDA screenreaders. Review URL: http://codereview.chromium.org/3598003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61090 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor RadioButton Image code for linux/gtkoshima@chromium.org2010-09-294-76/+124
| | | | | | | | | | | so that DOMUI menu can use the same image. BUG=none TEST=none Review URL: http://codereview.chromium.org/3435033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60972 0039d316-1c4b-4281-b951-d872f2087c98
* Add SetMinimumWidth to Menu2 for chromeos.oshima@chromium.org2010-09-297-0/+20
| | | | | | | | | | | | | This is to remove gtk dependency from menu2 code in chromeos and to make DOMUI transition smooth (crosbug.com/6497) Removed LanguageSwitchModel::GetFirstLevelMenuWidth as this does not seem to be used by anyone. BUG=none TEST=none Review URL: http://codereview.chromium.org/3533001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60961 0039d316-1c4b-4281-b951-d872f2087c98
* Allow chrome to be customized for screen reader users.ctguil@chromium.org2010-09-297-8/+54
| | | | | | | | | | | Add Widget::IsAccessibleWidget() that will return true when Chrome can be customized screen reader users. BUG=37357,55902 TEST=JAWS or NVDA users have "(Incognito)" in their window title. Tablet users are unaffected. Review URL: http://codereview.chromium.org/3427026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60888 0039d316-1c4b-4281-b951-d872f2087c98
* Make accessible getters return values instead of accepting an output ↵ctguil@chromium.org2010-09-2853-297/+157
| | | | | | | | | | | parameter. GetAccessibleName still needs to be converted. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/3416033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60828 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor AppModalDialog to more clearly isolate platform specific UI pieces ↵ben@chromium.org2010-09-281-0/+2
| | | | | | | | | | | and eliminate the dependency on individual frontends from cross platform code. BUG=none TEST=none Review URL: http://codereview.chromium.org/3398015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60785 0039d316-1c4b-4281-b951-d872f2087c98
* Set WidgetGtk.delegate_ = NULL in CloseNow() to fix chromium-os:5604.stevenjb@google.com2010-09-271-2/+4
| | | | | | | | | BUG=http://code.google.com/p/chromium-os/issues/detail?id=5604 TEST=Ensure opening and closing widgets behaves normally. Check for further crashes in WidgetGtk::IsActiveChanged(). Review URL: http://codereview.chromium.org/3452025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60668 0039d316-1c4b-4281-b951-d872f2087c98
* Append "(Incognito)" to the accessible title of the browser window.ctguil@chromium.org2010-09-273-4/+10
| | | | | | | | | | | This actual window title remains the same. BUG=37357 TEST=Screen readers read "Incognito" for browser windows that are off the record. Review URL: http://codereview.chromium.org/3400028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60658 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r60342.dtseng@chromium.org2010-09-242-0/+6
| | | | | | | TBR=dmazzoni. Review URL: http://codereview.chromium.org/3444021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60474 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 45091.hbono@chromium.org2010-09-241-1/+5
| | | | | | | | | | This change checks the states of ctrl and shift keys when proceesing acclerators to prevent FocusManager from consuming ctrl+alt keys and shift+alt keys. Windows sends SC_KEYMENU commands not only when we type only an alt key but also when we type ctrl+alt keys and shift+alt keys, both are used for changing input languages and keyboard layouts. To prevent these keys from being accidentally consumed by FocusManager, we check the states of these keys and send them to FocusManager. BUG=45091 TEST=interactive_ui_tests.exe --gtest_filter=KeyboardAccessTest.TestShiftAltMenuKeyboardAccess. Review URL: http://codereview.chromium.org/3318022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60433 0039d316-1c4b-4281-b951-d872f2087c98
* base: Finish moving the SplitString functions from string_util.h to ↵tfarina@chromium.org2010-09-241-0/+1
| | | | | | | | | | | string_split.h BUG=None TEST=trybos Review URL: http://codereview.chromium.org/3447008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60422 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move virtual methods to implementation files.erg@google.com2010-09-232-3/+5
| | | | | | | | | | | Remove logging.h and other headers where possible. BUG=none TEST=none Review URL: http://codereview.chromium.org/3461019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60369 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Set focus to a ConfirmInfoBar. This serves to alerts screen reader ↵maruel@chromium.org2010-09-232-6/+0
| | | | | | | | | | | | | | users ..." This reverts commit 60342. TBR=dtseng BUG=none TEST=none Review URL: http://codereview.chromium.org/3472008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60348 0039d316-1c4b-4281-b951-d872f2087c98
* Set focus to a ConfirmInfoBar. This serves to alerts screen reader users ↵dtseng@chromium.org2010-09-232-0/+6
| | | | | | | | | | that the confirmation has appeared and alleviates the need to hunt for these controls. BUG=37360 TEST=Confirm that focus lands correctly on the "save" button when logging into a site and offer to save passwords is enabled. Review URL: http://codereview.chromium.org/3405026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60342 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing the problem where accessibility events for password fields did not ↵chaitanyag@chromium.org2010-09-212-0/+5
| | | | | | | | set the password boolean field. Review URL: http://codereview.chromium.org/3353005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60106 0039d316-1c4b-4281-b951-d872f2087c98
* Make windows menu accelerators work in owner-draw mode.asargent@chromium.org2010-09-151-9/+5
| | | | | | | | | | | | | | | | | For items added to context menus by extensions, we display the extension's icon next to the top-level item. To display this icon, we use owner-draw mode, and it turns out that our code was assuming that we didn't need to tell windows about the labels of items in owner-draw mode. BUG=54497 TEST=Steps are outlined in the bug. Also all things menu related should be tested on windows.(wrench menu, context menus in web content, bookmark bar items, browser actions, etc.) Review URL: http://codereview.chromium.org/3402005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59560 0039d316-1c4b-4281-b951-d872f2087c98
* Fix focus traversal order in dialogs.jcivelli@chromium.org2010-09-141-1/+3
| | | | | | | | | | | | | | In a dialog, the contents view is added after the buttons have been added. That would mess up the focus traversal order. The problem was particularly visible in the basic auth dialog. This CL ensures the contents is added as the first view so the focus chain is right. BUG=42803 TEST=Open the options dialog. Make sure pressing Tab/Shift-Tab moves the focus correctly. Visit http://handle.library.cornell.edu/control/authBasic/authTest/ a basic auth dialog is shown. Make sure Tab/Shift-Tab moves the focus as expected. Review URL: http://codereview.chromium.org/3403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59432 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in bookmark menus where using arrow keys would selectsky@chromium.org2010-09-132-3/+29
| | | | | | | | | | | invisible menu items. BUG=54800 TEST=see bug Review URL: http://codereview.chromium.org/3315021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59226 0039d316-1c4b-4281-b951-d872f2087c98
* The fix for http://code.google.com/p/chromium-os/issues/detail?id=5987scottbyer@google.com2010-09-101-1/+5
| | | | | | | | | | | | | | sets the initial allocation for a widget when a size is passed in to WidgetGtk::Init(). The timing of the init call as part of creating a new tab contents view means that the arrangment of the hierarchy isn't complete yet, so incorrect contents get shown. This goes back to the original behavior which is to ignore the initial size request (it's now ignored at the TabContentsViewGtk::CreateView level instead of being implicitly ignored in the WidgetGtk::Init code). BUG=53870 TEST=Create new tabs, no flash of old tabs seen. Review URL: http://codereview.chromium.org/3290016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59122 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in changing to side tabs that could result in making windowsky@chromium.org2010-09-091-0/+11
| | | | | | | | | | | | | | | | bigger. When you switch to side tabs we end up in a situations where if you ask for the computed requested size you'll get a larger value than the current bounds of the window. Gtk sees this and sizes the window. We really don't want to derive the requested size of WidgetGtk when used a window from the contents, instead we want it to be empty or use an explicitly set value. BUG=53654 TEST=see bug Review URL: http://codereview.chromium.org/3300023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58972 0039d316-1c4b-4281-b951-d872f2087c98
* [Win] Add per-plugin exceptions to content settings.bauerb@chromium.org2010-09-092-15/+26
| | | | | | | | | | | Screenshot: http://imgur.com/yxEzO.png BUG=39252 TEST=PluginExceptionsTableModel.* Review URL: http://codereview.chromium.org/3307014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58929 0039d316-1c4b-4281-b951-d872f2087c98
* views: Add initial Throbber example.tfarina@chromium.org2010-09-094-1/+104
| | | | | | | | | | | | BUG=None TEST=export GYP_DEFINES="toolkit_views", gclient runhooks, make -k view_examples, out/Debug/view_examples Go to the Trobber tab, see the throbber spinning. Review URL: http://codereview.chromium.org/3345010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58901 0039d316-1c4b-4281-b951-d872f2087c98
* Added entry points to view/View to dispatch and process TouchEvents.rjkroege@google.com2010-09-089-9/+401
| | | | | | | | | | | | This change is part of a series of changes to bring TouchEvent processing to views. BUG=na TESTED=compiled with and without touchui Review URL: http://codereview.chromium.org/3192002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58823 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the max width for bookmark menus back to 400 and leaves themsky@chromium.org2010-09-072-9/+10
| | | | | | | | | | | | at 800 for the wrench menu. Apparently folks don't like wide bookmark menus. BUG=50653 TEST=see bug Review URL: http://codereview.chromium.org/3317011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58771 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bookmark menus to deal with multiple menus sharing the samesky@chromium.org2010-09-072-48/+123
| | | | | | | | | | | mnemonic. BUG=49728 TEST=see bug Review URL: http://codereview.chromium.org/3325015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58745 0039d316-1c4b-4281-b951-d872f2087c98
* Alway return interface from ViewAccessibility::get_accChild.ctguil@chromium.org2010-09-032-168/+71
| | | | | | | | | BUG=none TEST=Verify screen reader accessibility during events like nagivating toolbar or menus. Review URL: http://codereview.chromium.org/3292007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58547 0039d316-1c4b-4281-b951-d872f2087c98
* Factoring out views related unit-tests in their own exe.jcivelli@chromium.org2010-09-032-0/+90
| | | | | | | | | BUG=None TEST=Run view_unit_tests should run successfully on Windows and Linux toolkit views. Review URL: http://codereview.chromium.org/3256008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58439 0039d316-1c4b-4281-b951-d872f2087c98
* Re-lands 58186:bryeung@chromium.org2010-09-0344-210/+215
| | | | | | | | | | | | | | | | | | | | Original message: """ Move the keyboard files from base/ to app/. Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 """ TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3354005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58438 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58388 - Revert 58215 - Revert 58186 - Move the keyboard files from ↵akalin@chromium.org2010-09-0244-215/+210
| | | | | | | | | | | | | | | | | | | | | base/ to app/. Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 TBR=bryeung@chromium.org TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3361003 TBR=bryeung@chromium.org Review URL: http://codereview.chromium.org/3337006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58390 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58215 - Revert 58186 - Move the keyboard files from base/ to app/.bryeung@chromium.org2010-09-0244-210/+215
| | | | | | | | | | | | | | | | Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 TBR=bryeung@chromium.org TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3361003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58388 0039d316-1c4b-4281-b951-d872f2087c98
* Connect native view accessibles back to the accessibility tree.ctguil@chromium.org2010-09-021-5/+4
| | | | | | | | | BUG=none TEST=interactive_ui_tests:AccessibilityWinBrowserTest.ContainsRendererAccessibilityTree Review URL: http://codereview.chromium.org/3244011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58314 0039d316-1c4b-4281-b951-d872f2087c98
* Sending try jobs to linux_view is a strong signal that we should also send ↵thestig@chromium.org2010-09-021-2/+2
| | | | | | | | | | the try jobs to linux_chromeos, and vice versa. BUG=none TEST=none Review URL: http://codereview.chromium.org/3291005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58294 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for invisible menu items to bookmark menus and wires itsky@chromium.org2010-09-011-4/+7
| | | | | | | | | | | up for the wrench menu. BUG=46221, 54017 TEST=see bug Review URL: http://codereview.chromium.org/3289001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58218 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58186 - Move the keyboard files from base/ to app/.phajdan.jr@chromium.org2010-09-0144-215/+210
| | | | | | | | | | | | | Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 TBR=bryeung@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58215 0039d316-1c4b-4281-b951-d872f2087c98
* Move the keyboard files from base/ to app/.bryeung@chromium.org2010-09-0144-210/+215
| | | | | | | | | | | Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58186 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression in r56766oshima@chromium.org2010-09-011-0/+2
| | | | | | | | | | | CustomButton::OnKeyEvent should return false when the event is not handled BUG=chromium-os:6290 TEST=none Review URL: http://codereview.chromium.org/3276007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58111 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 7)thestig@chromium.org2010-08-2710-29/+33
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3176026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57737 0039d316-1c4b-4281-b951-d872f2087c98
* Misc. minor cleanup.pkasting@chromium.org2010-08-271-2/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3107041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57710 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Make our handling of Windows pre-processor symbols more consistent.phajdan.jr@chromium.org2010-08-261-5/+0
| | | | | | | | | | | | | | For example, there are differences between unit_tests and browser_tests, which cause ridiculous problems when moving a test between those. We're using the symbols anyway, so let's centralize it for maintainability. TEST=compile BUG=none Review URL: http://codereview.chromium.org/3173044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57555 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the download shelf auto-close after the user opens all downloadssky@chromium.org2010-08-262-11/+32
| | | | | | | | | | | | and moves mouse off the shelf. BUG=27797 TEST=on windows download an item, open it, move the mouse off the download shelf and make sure it closes. Review URL: http://codereview.chromium.org/3177034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57541 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression caused by http://codereview.chromium.org/2768006/showscottbyer@chromium.org2010-08-251-0/+9
| | | | | | | | | | | | | Using the new preferred size attributes for non-GtkViewsFixed widgets won't do very much. Put the gtk_widget_size_allocation call back for those widgets. Add in a small check into the ScreenLockerTest.TestBasic to prevent any future such regression. BUG=chromium-os:5987 TEST=ScreenLockerTest.TestBasic Review URL: http://codereview.chromium.org/3181039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57373 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed error message bubbles according to the latest mocksdpolukhin@chromium.org2010-08-232-0/+9
| | | | | | | | | BUG=chromium-os:5762, chromium-os:5761 TEST=Enter wrong password on Chrome OS login screen. Review URL: http://codereview.chromium.org/3201003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57060 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstrings from bookmarks, part 12.viettrungluu@chromium.org2010-08-225-12/+17
| | | | | | | | | | | | | | - This changes RecentlyUsedFoldersComboModel::GetItemAt() to return a string16 instead of a wstring. - This entailed changing the base class, ComboboxModel, and shaving a herd of yaks. BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3159031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57021 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the stop button when the user is hovering it and the page finishes ↵pkasting@chromium.org2010-08-203-4/+29
| | | | | | | | | | | | | | loading, so we don't look like we stay loading forever. This change only does this for Mac and Windows, as GTK is going to be trickier. This also fixes a pair of other bugs on Windows and Linux: * Because we were setting the timer after telling the browser to reload, and the browser was calling us back synchronously, the timer had no effect. * Because the timer firing changed modes with |force| set to true, if the page finished loading before the timer fired, the timer would flip the button back to reload. BUG=46981 TEST=Hover the reload button and hit F5. When the page finishes loading, the stop button should become disabled. Mousing away should change it to an enabled reload button. Review URL: http://codereview.chromium.org/3198005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56925 0039d316-1c4b-4281-b951-d872f2087c98
* Add in a browser test for dialog resizing, which was catching an issue with ↵scottbyer@chromium.org2010-08-206-20/+75
| | | | | | | | | | | | | the way we were using GTK in toolkit views. Possibly related to 27365 or 38785. http://code.google.com/p/chromium-os/issues/detail?id=4126 BUG=chromium-os:4126 TEST=HtmlDialogBrowserTest.SizeWindow Review URL: http://codereview.chromium.org/2768006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56919 0039d316-1c4b-4281-b951-d872f2087c98
* Display an infobar when content settings were created.jochen@chromium.org2010-08-204-21/+31
| | | | | | | | | | | | | | | The xib changes add a gradient view with an icon and a text field that is displayed as infobar. The text field is set to truncate. The blocked cookies label is set to wrap. The various views are connected to the new outlets. win: http://imgur.com/OmTxr.png linux: http://imgur.com/OmTxr mac: http://imgur.com/VbwFp BUG=49826 TEST=unit_tests Review URL: http://codereview.chromium.org/3108029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56913 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove dead code, use early returns to reduce indenting, shorten.pkasting@chromium.org2010-08-192-112/+70
| | | | | | | | | | This makes one behavioral change: a mouse release with a successful HitTest and |canceled| true will set the state to HOT instead of NORMAL. This seemed more correct to me. BUG=none TEST=none Review URL: http://codereview.chromium.org/3175027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56766 0039d316-1c4b-4281-b951-d872f2087c98
* Another take on menu's. This uses the hosting menu scroll view container as ↵dtseng@chromium.org2010-08-195-4/+22
| | | | | | | | | | | | | | | | | a menubar on which we can fire MENUSTART and MENUEND events. The end result is that we now have the following scenario when a user opens a menu. 1. focus lands on the menu button. 2. down arrow. 3. A "chromium" menu item appears. 4. down arrow (or enter). 5. The first menu item gets focused. The only differences from what we currently have is Jaws/NVDA no longer say "context menu opened" or "applications". The first real menuitem also doesn't get focused when the menu shows. BUG=none. TEST=use NVDA and Jaws to navigate the menu's (opening, closing, submenus, accelerators). Review URL: http://codereview.chromium.org/3155029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56715 0039d316-1c4b-4281-b951-d872f2087c98
* Convert FillRect(... SkPaint) to DrawRect() since it doesn't necessarily ↵pkasting@chromium.org2010-08-181-1/+1
| | | | | | | | | | fill, it just draws with the provided paint. BUG=none TEST=none Review URL: http://codereview.chromium.org/3165032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56589 0039d316-1c4b-4281-b951-d872f2087c98
* Convert GetDisplayStringInLTRDirectionality from wstring to string16.tony@chromium.org2010-08-181-1/+2
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/3108027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56535 0039d316-1c4b-4281-b951-d872f2087c98