summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Revert 66784 - Converts usage of SetProp/GetProp to a map. Even after making ↵sky@chromium.org2010-11-1914-86/+93
| | | | | | | | | | | | | | | | | sure we clean up props we still leak in a handful of cases that are causing test grief. By and large our usage of properties is for inside the application, so that a map works fine. BUG=61528 44991 Review URL: http://codereview.chromium.org/5075003 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/5184009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66786 0039d316-1c4b-4281-b951-d872f2087c98
* Converts usage of SetProp/GetProp to a map. Even after making sure wesky@chromium.org2010-11-1914-93/+86
| | | | | | | | | | | | clean up props we still leak in a handful of cases that are causing test grief. By and large our usage of properties is for inside the application, so that a map works fine. BUG=61528 44991 Review URL: http://codereview.chromium.org/5075003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66784 0039d316-1c4b-4281-b951-d872f2087c98
* More animation cleanup.sky@chromium.org2010-11-183-3/+7
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5154006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66683 0039d316-1c4b-4281-b951-d872f2087c98
* Add 1px black border for ChromeOS status button.xiyuan@chromium.org2010-11-182-0/+24
| | | | | | | | | | | | | | - Move Linux's CanvasSkia::DrawStringInt into DrawStringWithHalo and added code to support text halo and change DrawStringInt to use it; - Make views::TextButton support text halo; - Use the text halo for chromeos::StatusButton; BUG=chromium-os:8657 TEST=Verify 1px black border is added to ChromeOS status buttons. Review URL: http://codereview.chromium.org/5071002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66632 0039d316-1c4b-4281-b951-d872f2087c98
* Fix context menus for touchui=1sadrul@chromium.org2010-11-181-1/+1
| | | | | | | | | | | | | Nested tasks are generally allowed for context menus (e.g. in MenuController::Run, NativeMenuDOMUI::RunMenuAt). Do the same here. This fixes a X-freeze caused by context menus when touchui=1 with the X message-pump. BUG=none TEST=manual, context menus in web-pages should work and not freeze X. Review URL: http://codereview.chromium.org/5206002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66621 0039d316-1c4b-4281-b951-d872f2087c98
* Pulls AnimationDelegate out into its own header.sky@chromium.org2010-11-172-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5121004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66541 0039d316-1c4b-4281-b951-d872f2087c98
* Adding capslock flag to KeyEvent class. Without this flag, when converting frombryeung@google.com2010-11-172-7/+14
| | | | | | | | | | | | | GDK event to KeyEvent, the case information is lost (see keyboard_code_conversion_gtk.cc). BUG=none. TEST=none. Patch from Varun Jain <varunjain@chromium.org> Review URL: http://codereview.chromium.org/3226015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66496 0039d316-1c4b-4281-b951-d872f2087c98
* Dont composite if rgba is not supported.oshima@chromium.org2010-11-171-1/+2
| | | | | | | | | | TBR=derat@chromium.org BUG=none TEST=ScreenLockerTest.TestBasic passes. Review URL: http://codereview.chromium.org/5121003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66443 0039d316-1c4b-4281-b951-d872f2087c98
* Fix style nit.sky@chromium.org2010-11-171-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=rjkroege@chromium.org Review URL: http://codereview.chromium.org/5155001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66388 0039d316-1c4b-4281-b951-d872f2087c98
* Removes unneeded forward declaration.sky@chromium.org2010-11-171-1/+0
| | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/5145002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66385 0039d316-1c4b-4281-b951-d872f2087c98
* Handful of related instant changes:sky@chromium.org2010-11-151-5/+5
| | | | | | | | | | | | | | | | | | | | . Makes the code for running the promo more real. We're not ready to flip it on yet, so it isn't enabled. . Nukes verbatim from about:flags and instead randomly chooses verbatim/predictive when the user opts in. We're doing this to try and see if we get feedback as to which one folks like more. Windows preferences shows you which one you get (by way of an obscure label). I'll change gtk do to that shortly too. . Adds metrics. And a couple of random style issues I encountered in some files. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/5023001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66187 0039d316-1c4b-4281-b951-d872f2087c98
* Implement new task manager mocks on windows.atwilson@chromium.org2010-11-153-3/+16
| | | | | | | | | | | | | Added API to differentiate between background resources and normal foreground tabs, and added support for grouping processes containing background resources in a separate section of task manager. BUG=63140 TEST=bring up task manager on windows Review URL: http://codereview.chromium.org/4987001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66132 0039d316-1c4b-4281-b951-d872f2087c98
* Adding style notion to the TextButton.glotov@google.com2010-11-132-4/+3
| | | | | | | | | | | Welcome screen uses different style of buttons. BUG=chromium-os:8468 TEST=none Review URL: http://codereview.chromium.org/4402001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66061 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: First pass at XInput2 message pump.sadrul@chromium.org2010-11-122-3/+143
| | | | | | | | | | | Capture X events using XInput2. BUG=None TEST=None Review URL: http://codereview.chromium.org/4186004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65959 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 65938 (arm compile fail) - touchui: First pass at XInput2 message pump.sadrul@chromium.org2010-11-122-143/+3
| | | | | | | | | | | | | | | | Capture X events using XInput2. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65888 Review URL: http://codereview.chromium.org/4186004 TBR=sadrul@chromium.org Review URL: http://codereview.chromium.org/4894001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65940 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: First pass at XInput2 message pump.sadrul@chromium.org2010-11-122-3/+143
| | | | | | | | | | | | | Capture X events using XInput2. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65888 Review URL: http://codereview.chromium.org/4186004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65938 0039d316-1c4b-4281-b951-d872f2087c98
* gtk views: NULL-check fixed_ before hidingevan@chromium.org2010-11-121-1/+2
| | | | | | | | | | | | Due to a bug in the test setup, these critical errors were not causing DCHECKs. Fixing that bug caused this bug to become more visible. BUG=62868 TEST=no more critical errors in ExtensionApiTest.GetViews and others Review URL: http://codereview.chromium.org/4856001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65891 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "touchui: First pass at XInput2 message pump."evan@chromium.org2010-11-122-143/+3
| | | | | | This reverts commit r65888, build breakage. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65890 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: First pass at XInput2 message pump.sadrul@chromium.org2010-11-122-3/+143
| | | | | | | | | | | Capture X events using XInput2. BUG=None TEST=None Review URL: http://codereview.chromium.org/4186004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65888 0039d316-1c4b-4281-b951-d872f2087c98
* views: Override gtk-menu-images=0 for menu items with icons.derat@chromium.org2010-11-111-0/+6
| | | | | | | | | | | | | | This lets us disable icons by default, which gets rid of the ugly GTK+ copy/cut/paste icons in stock menus while still showing icons for Views menu items that have explicitly asked for them, like the ones in the Chrome OS network menu. BUG=chromium-os:4345 TEST=built and ran it Review URL: http://codereview.chromium.org/4708008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65828 0039d316-1c4b-4281-b951-d872f2087c98
* Implements vertical margins setter for textfield.altimofeev@chromium.org2010-11-107-11/+106
| | | | | | | | | | | | | After bug fix #r64550, changing horizontal margin doesn't change vertical margins. Unfortunately FindBar has used this bug, so explicit vertical setter was implemented to deal with this issue. BUG=chromium-os:8536 TEST=In chrome use 'ctrl+f' to invoke find bar. Notice that the border is inplace. Review URL: http://codereview.chromium.org/4246002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65686 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability for classes other than native control to processsky@chromium.org2010-11-106-39/+118
| | | | | | | | | | | | messages bounced to the parent and wires it up for autocompleteedit, which I'm going to need shortly. BUG=none TEST=none Review URL: http://codereview.chromium.org/4637002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65612 0039d316-1c4b-4281-b951-d872f2087c98
* Fix menu click bug.oshima@chromium.org2010-11-101-1/+1
| | | | | | | | | | TBR=chocobo@chromium.org BUG=chromium-os:8718 TEST=open context/status menu and test if mouse click selects the menu item. Review URL: http://codereview.chromium.org/4692002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65600 0039d316-1c4b-4281-b951-d872f2087c98
* Do not send many requests to flimflam when network chagned.oshima@chromium.org2010-11-092-2/+25
| | | | | | | | | | | | | | | Send sync request to flimflam only if new request didn't come in 50ms. Network menu was updating menu twice when opening. BUG=chromium-os:8435 TEST=manual: enable vlog (--vlog=1) and observe that chrome log reports one "UpdateNetworkStatus" when network changes (disable, enable ethernet etc) There may be two when wifi is enabled as different wifi source may be recognized at different timing. Review URL: http://codereview.chromium.org/4229005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65478 0039d316-1c4b-4281-b951-d872f2087c98
* Re-insert IP address in Network Menu.stevenjb@chromium.org2010-11-082-5/+7
| | | | | | | | | BUG=chromium-os:8476 TEST=Open the network menu on ChromeOS; the IP address should be at the bottom of the menu. Review URL: http://codereview.chromium.org/4544001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65398 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 65109 - Adds the ability for classes other than native control to processsky@chromium.org2010-11-046-118/+39
| | | | | | | | | | | | | | | messages bounced to the parent and wires it up for autocompleteedit, which I'm going to need shortly. BUG=none TEST=none Review URL: http://codereview.chromium.org/4470001 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/4528001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65122 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability for classes other than native control to processsky@chromium.org2010-11-046-39/+118
| | | | | | | | | | | | messages bounced to the parent and wires it up for autocompleteedit, which I'm going to need shortly. BUG=none TEST=none Review URL: http://codereview.chromium.org/4470001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65109 0039d316-1c4b-4281-b951-d872f2087c98
* [ChromeOS] Implement new progress bar mock.xiyuan@chromium.org2010-11-031-24/+150
| | | | | | | | | BUG=chromium-os:8465 TEST=Verify progress bar has new look now per chromium-os:8465. Review URL: http://codereview.chromium.org/4236001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64924 0039d316-1c4b-4281-b951-d872f2087c98
* Not all text-sizing calls took the insets into account, leading to ↵pkasting@chromium.org2010-11-021-4/+5
| | | | | | | | | | inconsistent eliding. BUG=none TEST=none Review URL: http://codereview.chromium.org/4233003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64830 0039d316-1c4b-4281-b951-d872f2087c98
* Textfield draws the right part of its parent's background as its background.avayvod@chromium.org2010-11-021-1/+11
| | | | | | | | | | | Set the right background for existing user controls view. BUG=chromium-os:8101 TEST=Check username and password text fields on existing or new user pods for light gray borders around them. Borders should not be visible. Review URL: http://codereview.chromium.org/4127009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64715 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing leaks from SetProp. Apparently there is a finitesky@chromium.org2010-11-019-49/+87
| | | | | | | | | | | | | | | | | | amount of memory reserved for properties and Windows doesn't always automatically free up the memory if the window is deleted without an explicit remove. For the time being I've made it easier to track SetProp leaks, but we may want to move to using something other than SetProp in the future that isn't as fragile. I didn't fix a couple of places that were trickier. I'm going to file separate bugs on them. BUG=44991 TEST=none Review URL: http://codereview.chromium.org/4195003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64619 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent needless vertical margin change.altimofeev@chromium.org2010-10-301-1/+2
| | | | | | | | | | | | When one change horizontal margin, vertical margin is also changed to zero. BUG=chromium-os:8081 TEST=none Review URL: http://codereview.chromium.org/4151012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64550 0039d316-1c4b-4281-b951-d872f2087c98
* Adds GtkLabel to GtkButton to allow font changing.altimofeev@chromium.org2010-10-301-6/+16
| | | | | | | | | BUG=chromeos:8234 TEST=none Review URL: http://codereview.chromium.org/4136006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64549 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Add Ctrl-/ accelerator for help app.derat@chromium.org2010-10-291-1/+9
| | | | | | | | | | | | | | This adds Ctrl-/ and Ctrl-Shift-/ (Ctrl-?) accelerators for the help command in Views GTK, updates the help URL for Chrome OS, and makes us print "/" explicitly in accelerator descriptions instead of "slash" (the string we get from GDK). BUG=chromium-os:7835 TEST=built and ran it Review URL: http://codereview.chromium.org/4156004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64495 0039d316-1c4b-4281-b951-d872f2087c98
* Make icon-text spacing configurable.oshima@chromium.org2010-10-292-7/+15
| | | | | | | | | | | | This is to implement shutdown button on login/locker screen, which has wider icon-text spacing 10 than 5. See crosbug.com/974 for the mock. BUG=chromium-os:974, chromium-os:5763 TEST=none Review URL: http://codereview.chromium.org/4192004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64475 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove base/gtk_util.h by moving its methods tojhawkins@chromium.org2010-10-291-2/+1
| | | | | | | | | | | gfx/gtk_util.h BUG=none TEST=none Review URL: http://codereview.chromium.org/4150006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64348 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add Shutdown button to login/locker screen."oshima@chromium.org2010-10-282-15/+7
| | | | | | | | | | | This reverts commit c2bafbefa8022337ba9520fd9a2f64fd2cd4c52f. BUG=none TEST=build bot should cycle green Review URL: http://codereview.chromium.org/4119015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64282 0039d316-1c4b-4281-b951-d872f2087c98
* Add Shutdown button to login/locker screen.oshima@chromium.org2010-10-282-7/+15
| | | | | | | | | | | * cleaned up code that are no longer in use. BUG=chromium-os:5763 TEST=maual. pressing shutdown button on login/locker will shutdown the system. Review URL: http://codereview.chromium.org/4054001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64272 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Relanding - Fix UI issues on SignIn/user pod.nkostylev@chromium.org2010-10-281-1/+1
| | | | | | | | | | | | | | | | | | Original CL: http://codereview.chromium.org/4179001/show 7. Textfield - focus border issue 9. Textfield - font size 11. Sign in - h padding 13,14 Link text & color. Button minimal width - 90px. BUG=chromium-os:8101 TEST=manual Review URL: http://codereview.chromium.org/4156005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64242 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64225 - [cros] Fix UI issues on SignIn pod/user pod.jochen@chromium.org2010-10-281-1/+1
| | | | | | | | | | | | | | | | | | | 7. Textfield - focus border issue 9. Textfield - font size 11. Sign in - h padding 13,14 Link text & color. Button minimal width - 90px. BUG=chromium-os:8101 TEST=manual Review URL: http://codereview.chromium.org/4179001 TBR=nkostylev@chromium.org Review URL: http://codereview.chromium.org/4189005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64227 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Fix UI issues on SignIn pod/user pod.nkostylev@chromium.org2010-10-281-1/+1
| | | | | | | | | | | | | | | | 7. Textfield - focus border issue 9. Textfield - font size 11. Sign in - h padding 13,14 Link text & color. Button minimal width - 90px. BUG=chromium-os:8101 TEST=manual Review URL: http://codereview.chromium.org/4179001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64225 0039d316-1c4b-4281-b951-d872f2087c98
* Convert ElideUrl to return a string16 instead of a wstring.tony@chromium.org2010-10-271-1/+2
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/4115003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64156 0039d316-1c4b-4281-b951-d872f2087c98
* Grab keyboard input when showing domui/views menu.oshima@chromium.org2010-10-272-16/+21
| | | | | | | | | | BUG=chromium-os:8118 TEST=manual: open more than 2 windows, then open wrench menu and hit alt-tab. It will not switch to other window. Review URL: http://codereview.chromium.org/4189002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64103 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: Directly process key and mouse events.rjkroege@google.com2010-10-2614-279/+274
| | | | | | | | | | | | | | | | Capture the keyboard and mouse events directly from X, create a corresponding views::Event out of it, and send it to the associated RootView. Includes Chad's (wyck) function FindRootViewForGdkEvent (from #3704005) slightly modified (called FindRootViewForGdkWindow). BUG=None TEST=Click/Keypress events in a webpage should work correctly. Review URL: http://codereview.chromium.org/3801011 Patch from Sadrul Chowdhury <sadrul@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63916 0039d316-1c4b-4281-b951-d872f2087c98
* Update gtk/menu2 without closing menuoshima@chromium.org2010-10-261-8/+15
| | | | | | | | | | | | | | | * ResetMenu now simply remove all menu items. * This will closes all submenus opened. It require a lot more work to update submenus correctly. Since there is no scenario that requires this so this is good enough for our use case. BUG=chromium-os:8106 TEST=manual: on chromeos device, open network menu and change network settings. (plug-unplug ethernet) Review URL: http://codereview.chromium.org/4120002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63899 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where we would some times not layout when we needed to.sky@chromium.org2010-10-251-3/+8
| | | | | | | | | BUG=59720 TEST=see bug Review URL: http://codereview.chromium.org/3960004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63793 0039d316-1c4b-4281-b951-d872f2087c98
* Menu crash fix for domui/gtk menu that is caused by multiple context menu ↵oshima@chromium.org2010-10-225-2/+114
| | | | | | | | | | | | | | | | | | | requests. Renderer may issue multiple ContextMenu request even if the menu is open.(this happenes when renderer receives mouse events before context menu is actually opened by previous request.) This is causing a crash in menu2 (both domiu/gtk impl) because menu2 has nested message loop, and the menu object gets deleted by 2nd request while it's handling message loop. This CL addresses this issue by creating separate object to handle the nested loop. Use only variables on stack and do not touch instance variable if the menu is already deleted. BUG=chromium-os:7929, chromium-os:7228 TEST=manual. on a page, continously click mouse to open/close context menu. It used to crash at some point, but shouldn't crash with this patch. Review URL: http://codereview.chromium.org/4046004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63576 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63478 - Adds CHECKs in hopes of figuring out why we're crashing on ↵sky@chromium.org2010-10-221-8/+3
| | | | | | | | | | | | | | | | some test bots. BUG=44991 TEST=none Review URL: http://codereview.chromium.org/3992005 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/4028002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63480 0039d316-1c4b-4281-b951-d872f2087c98
* Adds CHECKs in hopes of figuring out why we're crashing on some testsky@chromium.org2010-10-221-3/+8
| | | | | | | | | | | bots. BUG=44991 TEST=none Review URL: http://codereview.chromium.org/3992005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63478 0039d316-1c4b-4281-b951-d872f2087c98
* Some cleanup of view accessibility and view accessibility wrapper.ctguil@chromium.org2010-10-2210-373/+132
| | | | | | | | | | | | | | | 1. Remove the ViewAccessibilityWrapper class. The view can directly manage it's ViewAccessibility. 2. Always use GetAccessibleForView to retrieve a view's associated accessibility object. This ensures that the correct accessibility object is returned for native view host objects. 3. Update get_accFocus to use FocusManager. 4. Move oleacc guid definitions to view_win.cc. BUG=none TEST=interactive_ui_tests:BrowserViewsAccessibilityTest.TestBrowserRootViewAccObj TEST=Manual: I can select the accessibility object of a native view host within AccExplorer32.exe. Review URL: http://codereview.chromium.org/4047001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63451 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 16:05:39 +0000