summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* some more fixes for ignored scoped_ptr::release() callsestade@chromium.org2010-05-064-23/+10
| | | | | | | | | BUG=42904 TEST=bots Review URL: http://codereview.chromium.org/1982001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46622 0039d316-1c4b-4281-b951-d872f2087c98
* Host cookie modal dialog and js modal modal dialog in NativeDialogHostxiyuan@chromium.org2010-05-061-5/+9
| | | | | | | | | | | | | | | | | | | | | - Enable modal dialog in NativeDialogHost. This is not fully work in ChromeOS because e.g. user could still alt-tab away. However, setting modal would block user from interacting with relevant browser window and avoid crashes; - Move dialog close code from NativeHostDialog's destructor to WindowClosing because a dialog's "response" signal handler could rely on the contents; - Add "check-resize" signal handler to make GtkExpander work nicely with NativeDialogHost; - Add ShowModalDialogWithMinLocalizedWidth to gtk_util for cookie and js modal dialog; - Change in WidgetGtk::SetBounds to call gtk_window_move/resize always to keep GtkWindow's geometry info up-to-date; BUG=none TEST=Verify cookie prompt and js dialog on ChromeOS is hosted in a Chrome window and not occupy the whole screen. Review URL: http://codereview.chromium.org/1995001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46619 0039d316-1c4b-4281-b951-d872f2087c98
* Make Font::GetStringWidth() a shortcut for gfx::Canvas::SizeStringInt() on ↵pkasting@chromium.org2010-05-051-2/+4
| | | | | | | | | | | | Windows. These two functions already did the same thing on Mac and Linux. If they ever returned different results on Windows, it would lead to subtle bugs, since measurement and drawing would slightly disagree. Clean up a few other things so that all three implementations of GetStringWidth() are identical. BUG=38717 TEST=none Review URL: http://codereview.chromium.org/1928003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46492 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 41985 - The focus frames are out of range on the Options ↵xji@chromium.org2010-05-053-14/+329
| | | | | | | | | | | | | | | | | | | | : RTL. Previously, Label::CalculateDrawStringParams() computes the text boundary for signle-line and multi-line texts differently, so the boundary of focus rectangle is computed differently too inside Label::Paint(). Now, Label::CalculateDrawStringParams() computes text boundary without differentiate single-line and multi-line text, the boundary itself always takes mirror into consideration. So, the boundary of focus rectangle no longer need mirroring for both cases. BUG=http://crbug.com/41985 TEST= 1. Launch Chrome with RTL languages UI (ex: chrome.exe --lang=he) 2. click Wrench => Options Under the Hood 3. click or press tab to focus any string there. 4. the focus should be around the text, not out of the text range. Review URL: http://codereview.chromium.org/1694012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46484 0039d316-1c4b-4281-b951-d872f2087c98
* Close menu on grab broke event.oshima@chromium.org2010-05-053-2/+17
| | | | | | | | | | | This is necessary for screen locker to grab the input event. Technically, this can happen when another part of chrome tries to grab the input, so this is safer to handle this. BUG=none TEST=none Review URL: http://codereview.chromium.org/1900002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46441 0039d316-1c4b-4281-b951-d872f2087c98
* Add transparency to TYPE_CHILD WidgetGtk.oshima@chromium.org2010-05-053-57/+196
| | | | | | | | | | | | | | | * This does not work with renderer as parent yet.(I need to investigate renderer what it's doing) * gtk_widget_set_back_pixmap is not necessary and removed. * changed to use clear operation to fill a background with transparent color. BUG=none TEST=manual: added transparent widget example to view_examples. I also tested with chrome and confirmed that info bubble, app launcher and tab dragging works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46374 Review URL: http://codereview.chromium.org/1629024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46439 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors animation to allow for cleaner subclassing. I'm doing thissky@chromium.org2010-05-054-5/+5
| | | | | | | | | | | | for creating a different animation subclass (which you'll see shortly). BUG=none TEST=none Review URL: http://codereview.chromium.org/1961001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46433 0039d316-1c4b-4281-b951-d872f2087c98
* Use GetDisplayStringInLTRDirectionality() in more places to simplify code.pkasting@chromium.org2010-05-051-2/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1928004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46427 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting two files that has been included in revert by mistake.oshima@chromium.org2010-05-042-9/+1
| | | | | | | | | | TBR=sky@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/1941002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46378 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add transparency to TYPE_CHILD WidgetGtk."oshima@chromium.org2010-05-045-194/+67
| | | | | | | | | | This reverts commit ddbb1a000db9a2e8ea0cb504877c48fd7838da1b. TBR=sky@chromium.org Review URL: http://codereview.chromium.org/1951003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46377 0039d316-1c4b-4281-b951-d872f2087c98
* Add transparency to TYPE_CHILD WidgetGtk.oshima@chromium.org2010-05-043-58/+193
| | | | | | | | | | | | | * This does not work with renderer as parent yet.(I need to investigate renderer what it's doing) * gtk_widget_set_back_pixmap is not necessary and removed. * changed to use clear operation to fill a background with transparent color. BUG=none TEST=manual: added transparent widget example to view_examples. I also tested with chrome and confirmed that info bubble, app launcher and tab dragging works. Review URL: http://codereview.chromium.org/1629024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46374 0039d316-1c4b-4281-b951-d872f2087c98
* Skip accelerator handling if there is a grabbed widget.xiyuan@chromium.org2010-05-031-1/+4
| | | | | | | | | | | | Grabbed widget in gtk should get all the mouse and keyboard events and we should respect that. BUG=<http://crosbug.com/2355> TEST=Verify 2nd issue of 2355 that combobox dropdown should not disappear after mouse release. Also verify that 1st ESC should clear off combo's dropdown and 2nd ESC should dismiss the dialog. Please also pay attention to other regressions related to accelerator keys on gtk (linux, linux_chromeos builds). Review URL: http://codereview.chromium.org/1727020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46229 0039d316-1c4b-4281-b951-d872f2087c98
* Do not show Vista elevation shield if UAC is disabled.mirandac@google.com2010-04-301-1/+2
| | | | | | | | | BUG=42571 TEST=disable UAC and run Chrome as first run, with import. check "make chrome your default browser" box. see no shield. Review URL: http://codereview.chromium.org/1732013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46142 0039d316-1c4b-4281-b951-d872f2087c98
* Implement UI automation on the Mac.jrg@chromium.org2010-04-291-2/+7
| | | | | | | | | | | | | | | | | | | Code is untested. From gChat: me: do you have a good test I can use to make sure mac impl of ui_controls for sending events works OK? Or would you prefer I send you CLs to play with and we iterate by hand? Joe: I would like the CL to play with to see if I can get it to work with the code I wrote Warning to Joe: mouse moved events currently use the Mac coordinate frame (0,0 is bottom-left not top-left). That's easy to switch; I'd like to do whatever is easiest to get WebDriver working. BUG=26102 Review URL: http://codereview.chromium.org/1701006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46005 0039d316-1c4b-4281-b951-d872f2087c98
* views: Make use of gtk_signal macros in more places.erg@chromium.org2010-04-294-15/+14
| | | | | | | | | | | BUG=None TEST=compiles, and manually. Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1648016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45942 0039d316-1c4b-4281-b951-d872f2087c98
* Use customized RGBA-enabled tooltip window for tooltip on ChroemOSxiyuan@chromium.org2010-04-285-66/+157
| | | | | | | | | | | | | | | | - Add a TooltipWindowGtk which uses RGBA colormap and has a label; - Use TooltipWindowGtk for tooltip for both WidgetGtk and RenderWidgetHostViewGtk After this change, we will get back shadow and rounded corner for tooltip in theme engine. BUG=none TEST=none Review URL: http://codereview.chromium.org/1708015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45854 0039d316-1c4b-4281-b951-d872f2087c98
* This adds in the ability for Chrome to generate windows with snapshotsgspencer@chromium.org2010-04-281-1/+2
| | | | | | | | | | | | of all currently open tabs in all browsers. This is needed for overview mode on ChromeOS. BUG=http://code.google.com/p/chromium-os/issues/detail?id=1170 TEST=Ran Chrome under ChromeOS with updated window manager. Review URL: http://codereview.chromium.org/661237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45824 0039d316-1c4b-4281-b951-d872f2087c98
* Show spinner on network response in OOBE welcome screen, account creation ↵nkostylev@google.com2010-04-272-8/+27
| | | | | | | | | | | | | screen. Block buttons/keyboard on login window when sign in is in process. BUG= http://crosbug.com/2573, http://crosbug.com/2528 TEST=Run through OOBE screens and observe spinner when network response is more than 0.5 seconds. Review URL: http://codereview.chromium.org/1755006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45683 0039d316-1c4b-4281-b951-d872f2087c98
* Remove svn:executable property from the last few files that don't need it.thestig@chromium.org2010-04-271-0/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1746010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45665 0039d316-1c4b-4281-b951-d872f2087c98
* Remove MessageLoopForUI::Observer in WidgetGtk.oshima@chromium.org2010-04-262-27/+0
| | | | | | | | | | | | | | | This seems to be inherited from windows code and not necessary. All worked fine without this. I left "#include "base/message_loop.h" in widget_gtk.h as many users of widget_gtk (and widget_win) expects it's included here. BUG=none TEST=manual: all painting shoudl work fine after this modification. Review URL: http://codereview.chromium.org/1705007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45623 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing crash in BoundsAnimator. This patch largely justsky@chromium.org2010-04-263-59/+67
| | | | | | | | | | | | cleans things up and fixes some possible usage problems by TabStrip. I'm not confident this fixes the crash, but we'll see. BUG=41538 TEST=none Review URL: http://codereview.chromium.org/1710003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45602 0039d316-1c4b-4281-b951-d872f2087c98
* Add a first run bubble to show after installing an extension app.finnur@chromium.org2010-04-242-1/+15
| | | | | | | | | | | | | | | | | | | | | This is similar to what we show when installing a page action or browser action, albeit with a slightly different text. Also disable the install warning for extension apps, for the time being. And finally, in tab_strip.cc I accidentally checked in a comment, which I had commented out during testing. It was supposed to be on (related to my last cl). BUG=None TEST=Install an extension app, notice a first run bubble instead of a installation warning. The first run bubble should have a checkbox allowing you to create a desktop shortcut. Review URL: http://codereview.chromium.org/1693008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45537 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused local variables now that subclasses don't need to track their ↵pkasting@chromium.org2010-04-238-22/+0
| | | | | | | | | | own accessibile name. (In other words, I forgot to do this in r43558.) BUG=none TEST=none Review URL: http://codereview.chromium.org/1751018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45512 0039d316-1c4b-4281-b951-d872f2087c98
* Add a widget delegate handler for the WM_SETTINGCHANGE message in windows. ↵johnnyg@chromium.org2010-04-232-0/+6
| | | | | | | | | | | This is sent when the size/position of the taskbar changes, and we need to move the desktop notifications if that happens. BUG=35464 TEST=open notifications and move taskbar Review URL: http://codereview.chromium.org/1622018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45504 0039d316-1c4b-4281-b951-d872f2087c98
* Re-instate the temporary revert from r45267. That reverted certainshess@chromium.org2010-04-239-102/+329
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Omnibox, toolbar, tab animations, and other UI changes for purposes of testing and merging into mstone-5. Additionally reverts these CLs to fix the earlier revert: r45271: [Mac] Image references missing from Omnibox revert. r45268: GTK fix merge failure in uber-revert. Additional revert which fixed a bug for the branch: r45381: [Mac] Omnibox popup icons and text lined up under toolbar. Slight merge conflict which should be good: r45322: GTK: Implement OnDragCanceled() for autocomplete... Also ++kThemePackVersion and regenerate the cached theme pak. Re-instated changes: r45213: GTK: Override cursor colors in chrome-theme mode. r45103: Support drawing nano tabs in the tabstrip. r45084: GTK: Position the EV certificate stuff inside a green bubble. r44979: Subclassing the InfoBubble to handle anchoring bubbles basedon... r44957: GTK: Tint the geolocation icons in gtk mode. r44943: Changes FormatURL to not strip http if the host starts with ft... r44930: Remove an icon that is no longer used. r44929: SSL UI changes, Windows, code side (images are separate). r44859: SSL UI changes (icons). TBRed since trybots hate binary patches. r44822: GTK: Select better greens in the native omnibox popup. r44814: GTK: navigate to URL on PRIMARY when middle-clicking the locat... r44789: [Mac] Bookmark star missing on NTP and BMM. r44775: [Mac] Centralize hack to make tests work with AutocompleteClas... r44678: Display the SECURITY_WARNING status in the location bar for the r44648: [Mac] Add an arrow cursor rect for the location image. r44615: Revert r44611 because it may have broken "unit_tests" on "Vist... r44611: Display the SECURITY_WARNING status in the location bar for the r44577: Revert 44572 - [Mac] Update locationbar icon as user types. r44572: [Mac] Update location-bar icon as user types. r44555: GTK: Use correct button mask on reload button. r44545: [Mac] Omnibox text drag drag URL when select-all. r44523: GTK: Prevent inappropriate drag of location bar location icon. r44519: GTK: make the primary selection include the url's scheme when ... r44492: [Mac] Fix search icon in keyword search to be right-side-up. r44415: GTK: Update top padding on icons in the autocomplete popup. r44401: GTK: Tint omnibox icons in GTK mode differently. r44380: GTK: Move reload in gtk mode and fix omnibox popup location. r44282: Fixes crash in autocomplete when typing some URLs. The problem r44273: [Mac] PDF icons for omnibox nits. r44269: Fix build break due to bad merge resolve r44268: Shift omnibox dropdown in and up on Windows, and square off th... r44178: GTK: fix TTS padding. r44177: Round the top left and right edges of the toolbar. r44171: Images only checkin for try server goodness. r44163: GTK: fix padding of autocomplete popup. r44152: [Mac] PDF icons for omnibox. r44145: GTK: Theme the icons in the location bar and use GTK colors fo... r44140: Strips http from the omnibox r44131: Fixes bugs in new tab strip animations where they weren't doin... r44116: Change the default theme colors. r44117: Add newline to EOF to fix CrOS builder. r44115: Make the bottom edges of the opaque frame rounded. r44091: [Mac] No star icon or page actions in omnibox on popups. r44087: Don't allow drag or click on location icon when editing in omn... r44021: [GTK] Add TTS lens graphic to linux TTS box. r44008: [Mac] Tweak location icon spacing in omnibox. r43977: GTK: don't show the star or page actions in ShouldOnlyShowLoca... r43972: Make the firstrun bubble point at a better spot now that the l... r43971: [Mac] Location icon in omnibox as drag source. r43970: Make the star and page action icons not appear on popup windows. r43954: Fixes bug in TabStrip where dragging tab out then back in rapidly r43864: Tweaks to BoundsAnimator/SlideAnimation and TabStrip: r43787: Allow location icon to be dragged & dropped. This also fixes ... r43759: Changes end cap of tab-to-search images. r43740: Change bookmark bar toggle to ctrl-shift-b. r43723: Show Page Info dialog on mouse up, not mouse down. r43677: Fix Mac build failure. r43676: Replace omnibox icons with new set that are all the same size ... r43596: Fix browser test TestStarButtonAccObj. r43593: Disables TestStarButtonAccObj. r43582: Changes tab strip to use BoundsAnimator for tab strip animatio... r43563: GTK: don't show reload button for popup/app windows. r43562: Star/reload shuffle, Windows version. r43540: [Mac] Magnifying glass in keyword-search bubble. r43482: Adds images needed for new tab animation. I'm separating this ... r43422: Add reload mask resource. r43392: GTK: make the location icon a drag source. r43376: [Mac] Move star button into page-actions area of omnibox. r43357: [Mac] Line up omnibox popup under field. r43290: gtk: fix display of icons in omnibox popup r43269: GTK: fix reload button. r43249: [Mac] Rearrange SSL status icon/label in omnibox. r43248: BrowserThemePack: Adds persistant ids for the reload endcaps. r43241: GTK: more location bar updates. r43191: Fix memory leak in BrowserThemePack. r43154: GTK: set the new star button's ID r43151: Fix bad conflict resolution for r43146. r43146: GTK: toolbar reload/star shuffle. r43025: Show the location bar icon (almost) all the time, and have its... r43023: Add new images for new reload button. No code change. r42782: Remove this icon, now that it's no longer used (due to my secu... r42502: Omnibox M5 work, part 1: Security changes r42245: Check in new icons for omnibox security changes alone, so that... BUG=none TEST=People go back to complaining about missing http://. R=pkasting@chromium.org,beng@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45474 0039d316-1c4b-4281-b951-d872f2087c98
* Fix recursive calls to PaintNow under gtk2.18.3 and up.oshima@chromium.org2010-04-231-1/+8
| | | | | | | | | | | gdk_window_process_updates in gtk2.18.3 issues exposure events on its child gdkwindow (with update_children=true) and drives event loop. In current implementation, WidgetGtk::DidProcessEvent calls PaintNow no matter where the event was generated to, which causes recursive calls to PaintNow. This cl fix this issue by calling PaintNow only when the event was for the target WidgetGtk. BUG=42235 TEST=none Review URL: http://codereview.chromium.org/1741004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45461 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting for dtseng. Ensure that the variant out param gets properlydmazzoni@chromium.org2010-04-231-0/+3
| | | | | | | | | | | | initialized as the variant isn't guaranteed to have been zeroed. Original issue: 1689011 BUG=36086 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45460 0039d316-1c4b-4281-b951-d872f2087c98
* Gets rid of the annoying white dot in the upper left corner of allsky@chromium.org2010-04-232-1/+2
| | | | | | | | | | | | | | | | chromeos windows. This white dot was a gtkfixed that should not have been visible. It was being made visible by the show_all in WindowGtk. There may be some regressions from this change, but we should individually be doing show/show_all for hierarchies rather than in window. BUG=none TEST=none Review URL: http://codereview.chromium.org/1730008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45442 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily revert certain Omnibox, toolbar, tab animations, and othershess@chromium.org2010-04-229-329/+102
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | UI changes for purposes of testing and merging into mstone-5. Also ++kThemePackVersion and regenerate the cached theme pak. Reverted changes: r45213: GTK: Override cursor colors in chrome-theme mode. r45103: Support drawing nano tabs in the tabstrip. r45084: GTK: Position the EV certificate stuff inside a green bubble. r44979: Subclassing the InfoBubble to handle anchoring bubbles basedon... r44957: GTK: Tint the geolocation icons in gtk mode. r44943: Changes FormatURL to not strip http if the host starts with ft... r44930: Remove an icon that is no longer used. r44929: SSL UI changes, Windows, code side (images are separate). r44859: SSL UI changes (icons). TBRed since trybots hate binary patches. r44822: GTK: Select better greens in the native omnibox popup. r44814: GTK: navigate to URL on PRIMARY when middle-clicking the locat... r44789: [Mac] Bookmark star missing on NTP and BMM. r44775: [Mac] Centralize hack to make tests work with AutocompleteClas... r44678: Display the SECURITY_WARNING status in the location bar for the r44648: [Mac] Add an arrow cursor rect for the location image. r44615: Revert r44611 because it may have broken "unit_tests" on "Vist... r44611: Display the SECURITY_WARNING status in the location bar for the r44577: Revert 44572 - [Mac] Update locationbar icon as user types. r44572: [Mac] Update location-bar icon as user types. r44555: GTK: Use correct button mask on reload button. r44545: [Mac] Omnibox text drag drag URL when select-all. r44523: GTK: Prevent inappropriate drag of location bar location icon. r44519: GTK: make the primary selection include the url's scheme when ... r44492: [Mac] Fix search icon in keyword search to be right-side-up. r44415: GTK: Update top padding on icons in the autocomplete popup. r44401: GTK: Tint omnibox icons in GTK mode differently. r44380: GTK: Move reload in gtk mode and fix omnibox popup location. r44282: Fixes crash in autocomplete when typing some URLs. The problem r44273: [Mac] PDF icons for omnibox nits. r44269: Fix build break due to bad merge resolve r44268: Shift omnibox dropdown in and up on Windows, and square off th... r44178: GTK: fix TTS padding. r44177: Round the top left and right edges of the toolbar. r44171: Images only checkin for try server goodness. r44163: GTK: fix padding of autocomplete popup. r44152: [Mac] PDF icons for omnibox. r44145: GTK: Theme the icons in the location bar and use GTK colors fo... r44140: Strips http from the omnibox r44131: Fixes bugs in new tab strip animations where they weren't doin... r44116: Change the default theme colors. r44117: Add newline to EOF to fix CrOS builder. r44115: Make the bottom edges of the opaque frame rounded. r44091: [Mac] No star icon or page actions in omnibox on popups. r44087: Don't allow drag or click on location icon when editing in omn... r44021: [GTK] Add TTS lens graphic to linux TTS box. r44008: [Mac] Tweak location icon spacing in omnibox. r43977: GTK: don't show the star or page actions in ShouldOnlyShowLoca... r43972: Make the firstrun bubble point at a better spot now that the l... r43971: [Mac] Location icon in omnibox as drag source. r43970: Make the star and page action icons not appear on popup windows. r43954: Fixes bug in TabStrip where dragging tab out then back in rapidly r43864: Tweaks to BoundsAnimator/SlideAnimation and TabStrip: r43787: Allow location icon to be dragged & dropped. This also fixes ... r43759: Changes end cap of tab-to-search images. r43740: Change bookmark bar toggle to ctrl-shift-b. r43723: Show Page Info dialog on mouse up, not mouse down. r43677: Fix Mac build failure. r43676: Replace omnibox icons with new set that are all the same size ... r43596: Fix browser test TestStarButtonAccObj. r43593: Disables TestStarButtonAccObj. r43582: Changes tab strip to use BoundsAnimator for tab strip animatio... r43563: GTK: don't show reload button for popup/app windows. r43562: Star/reload shuffle, Windows version. r43540: [Mac] Magnifying glass in keyword-search bubble. r43482: Adds images needed for new tab animation. I'm separating this ... r43422: Add reload mask resource. r43392: GTK: make the location icon a drag source. r43376: [Mac] Move star button into page-actions area of omnibox. r43357: [Mac] Line up omnibox popup under field. r43290: gtk: fix display of icons in omnibox popup r43269: GTK: fix reload button. r43249: [Mac] Rearrange SSL status icon/label in omnibox. r43248: BrowserThemePack: Adds persistant ids for the reload endcaps. r43241: GTK: more location bar updates. r43191: Fix memory leak in BrowserThemePack. r43154: GTK: set the new star button's ID r43151: Fix bad conflict resolution for r43146. r43146: GTK: toolbar reload/star shuffle. r43025: Show the location bar icon (almost) all the time, and have its... r43023: Add new images for new reload button. No code change. r42782: Remove this icon, now that it's no longer used (due to my secu... r42502: Omnibox M5 work, part 1: Security changes r42245: Check in new icons for omnibox security changes alone, so that... BUG=none TEST=Eyjafjallajokull R=pkasting@chromium.org,beng@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45267 0039d316-1c4b-4281-b951-d872f2087c98
* Add EnableDoubleBuffer to WidgetGtkoshima@chromium.org2010-04-213-10/+35
| | | | | | | | | | | | | This will be used to eliminate flicker issue in notification panel (and probably in settings when settings is moved to views). NativeViewHostGtk was creating Fixed with gdk window everytime it is repositioned with clipping. This was causing a lot of creation/deletion of fixed when moving a native control in scroll bar. BUG=23445 TEST=none Review URL: http://codereview.chromium.org/1725005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45252 0039d316-1c4b-4281-b951-d872f2087c98
* Fix valgrind memory leak complain in ViewTestxiyuan@chromium.org2010-04-211-0/+6
| | | | | | | | | BUG=42199 TEST=Verify valgrind issue in 42199 is fixed. Review URL: http://codereview.chromium.org/1761001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45207 0039d316-1c4b-4281-b951-d872f2087c98
* Polish ChromeOS options dialog:xiyuan@chromium.org2010-04-215-4/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | - Add a chromeos OptionsWindowView that hosts options pages in a ChromeWindow so that it has a frame; This piece of code is based on Chrome's OptionsWindowView. Ideally, we should use Chrome's options view but we still missing underlying controls such as Tree and Table. - Use last active browser window as options dialog's parent; This makes optiosn dialog transient for the browser window and window manager will no longer treat it as top-level window and will not move and resize it; - If user switches to a new browser window and invokes options dialog again, close the existing one and re-opens it for the current browser window. This is currently supported by window manager; - Update CustomerFrameView and WindowDelegate to make client edge optionaly; Options dialog has no client area padding and does not have a client edge per UI mock; - Make NativeViewHost respects its background. This solves the problem that tab pane background is not properly cleared when hosting a native GtkVBox pane in TabbedPane; BUG=<http://crosbug.com/1885> TEST=Verify ChromeOS settings dialog looks like the mocks in http://www.chromium.org/chromium-os/user-experience/settings Review URL: http://codereview.chromium.org/1672003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45204 0039d316-1c4b-4281-b951-d872f2087c98
* Defer WidgetGtk's focus manager destructionxiyuan@chromium.org2010-04-204-5/+124
| | | | | | | | | | | | | | | | | | This is for the case when a WidgetGtk is hosted in another WidgtGtk and holds a reference to its focus manager. When hosting widget is destroied, it gets the "destroy" signal before the contained widget and thus schedules its destruction before the contained widget. And currently, we are not clearing the focus manager reference in another root view and when contained widget destructs, we crash. By changing focus manager's release into another message, the focus manager remains valid during contained widget destruction. BUG=none TEST=In ChromeOS, bring up options dialog and then click on buttons such as language settings, networ config etc. Then dismiss the options dialog and Chrome should not crash. Review URL: http://codereview.chromium.org/1661003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45071 0039d316-1c4b-4281-b951-d872f2087c98
* UI Language switch implemented by propagating LocaleChanged()glotov@google.com2010-04-207-6/+40
| | | | | | | | | | | | | | | notification to all the views currently active. Before this CL, all views were recreated instead. That was very refactoring-unsafe. Note, this is first part of the change. It prepares overall architecture means and can be committed first. The other part contains implementation details and is here: http://codereview.chromium.org/1551029/show BUG=none TEST=none Review URL: http://codereview.chromium.org/1596023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45057 0039d316-1c4b-4281-b951-d872f2087c98
* Enable CustomButton users to call SetEnabled(false) even when ↵yusukes@google.com2010-04-204-20/+23
| | | | | | | | | | | | | |show_highlighted_| of the button is set to false. This change is necessary for http://codereview.chromium.org/1645012 . Note that SetShowHighlited(false) is used only in two classes, chrome/browser/chromeos/status/language_menu_button.cc and chrome/browser/chromeos/status/clock_menu_button.cc. So I believe the impact of this change should be minimal. BUG=none TEST=none Review URL: http://codereview.chromium.org/1539040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45001 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Chrome overlapping an autohide taskbar in certain cases. Original patch ↵pkasting@chromium.org2010-04-191-0/+17
| | | | | | | | | by Satish Sampath (see http://codereview.chromium.org/1566054 ), r=me. BUG=28042 TEST=Set taskbar to autohide and open a maximized Chrome window. Toggle visibility of the Chrome window using the appropriate taskbar button, make sure that the taskbar stays up on screen after many attempts and never hides. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44941 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 34970.hbono@chromium.org2010-04-197-4/+34
| | | | | | | | | | This issue is caused by r34322 that changes text composed by an IME. (It makes Windows reset the IME.) As a quick fix, this changes adds a new method TextField::IMEIsComposing() and call it before changing text in FindBarView::UpdateForResult(). BUG=34970 TEST=Type Ctrl+F, enable a Japanese IME, and type shift+a, return, and shift+a. Verify if the find box has two As, i.e. 'AA'. Review URL: http://codereview.chromium.org/1630014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44904 0039d316-1c4b-4281-b951-d872f2087c98
* Hover buttons for notification.oshima@chromium.org2010-04-161-6/+16
| | | | | | | | | | | | | | | * Chagned WidgetGtk so that any GtkFixed can be parent of WidgetGtk. * Close button and Options menu is moved to separate TYPE_CHILD WidgetGtk which is shown/hidden as mouse moves. TODO: host Widget is not transparent right now. I'll address this in separate CL. BUG=41011 TEST=none Review URL: http://codereview.chromium.org/1654006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44861 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash if the window hosting a menu was closed while thesky@chromium.org2010-04-1617-202/+354
| | | | | | | | | | | | menu was showing. When this happens the window the menu creates is implicitly destroyed (because the parent is going away). BUG=25563 TEST=see bug Review URL: http://codereview.chromium.org/1664001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44807 0039d316-1c4b-4281-b951-d872f2087c98
* Add style to clip children which reduces flashing when the tab control is ↵jcivelli@google.com2010-04-161-1/+2
| | | | | | | | | | | | | | | | resized. The tab control still flashes a little bit but it is only the outer area and not the large content area/child controls. Fixing that probably requires drawing the tab control on our own which is perhaps overkill. BUG=28383 TEST=follow steps given in the bug and resize password manager window, tab should not flicker as much as it did earlier. Original patch by Satish: http://codereview.chromium.org/1646009/show Review URL: http://codereview.chromium.org/1622029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44785 0039d316-1c4b-4281-b951-d872f2087c98
* views: Implement a TODO to convert all the callers of the deprecatedsatorux@chromium.org2010-04-163-26/+2
| | | | | | | | | | | | | constructor of TableView2 to the new one. BUG=None TEST=out/Debug/unit_tests --gtest_filter=TableView2Test.* Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1530026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44771 0039d316-1c4b-4281-b951-d872f2087c98
* Use a widget as drag icon for proper transparency handling.xiyuan@chromium.org2010-04-141-5/+62
| | | | | | | | | | | | | | | gtk_drag_set_icon_pixbuf converts pixbuf with alpha into a pixmap and mask. It uses the pixmap as window back pixmap and shape the window with the mask. This should work theoretically. However, the underlying window's content get mixed into the drag icon and make it un-usable. So changing to use a drag icon widget of our own which would render everything correctly. BUG=none. TEST=Verify the drag-n-drop works correct without a messed up drag icon on bookmark bar and omnibox. Review URL: http://codereview.chromium.org/1630017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44483 0039d316-1c4b-4281-b951-d872f2087c98
* Make views menu have a similar look and feel of native menu on ChromeOS:xiyuan@chromium.org2010-04-133-0/+42
| | | | | | | | | | | | | | - Mark menu host popup with GDK_WINDOW_TYPE_HINT_MENU so that window manager would add drop shadow and border to it; - Use the same gradient fill as menu's background; - Use the same selection color and text color; BUG=<http://crosbug.com/1885> TEST=Verify bookmark menu have a similar look and feel as other menus (e.g. wrench menu). Review URL: http://codereview.chromium.org/1547030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44370 0039d316-1c4b-4281-b951-d872f2087c98
* Add more variations to Widget example.oshima@chromium.org2010-04-132-55/+180
| | | | | | | | | | | | | Transparent POPUP, CHILD and Transparent child example has been added. Transparent child is not working yet (it will crash) Changed ScrollView example so that scrollable view has view components BUG=none TEST=none Review URL: http://codereview.chromium.org/1521025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44365 0039d316-1c4b-4281-b951-d872f2087c98
* Shift omnibox dropdown in and up on Windows, and square off the top, so it ↵pkasting@chromium.org2010-04-122-50/+34
| | | | | | | | | | | | connects to the location bar. Also fix info bubble positioning against location bar icons to put the arrow "up against the icon edge" (fixes the arrow overlapping some page action icons). Remove BubblePositioner, which is now no longer needed. BUG=27570,40730 TEST=Omnibox dropdown should line up with editable area edges, icons and text should line up with icon and text in the omnibox. Info bubbles should still be positioned correctly Review URL: http://codereview.chromium.org/1578021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44268 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux Views] Handle focus in event of native views and controls correctly.suzhe@chromium.org2010-04-124-22/+24
| | | | | | | | | BUG=http://crosbug.com/1800 TEST=Build chromium with toolkit_views=1, and run it with ibus input method, then try if the input method can be enabled inside find bar. Review URL: http://codereview.chromium.org/1547027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44260 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bugs in new tab strip animations where they weren't doing thesky@chromium.org2010-04-091-0/+3
| | | | | | | | | | | | right thing when rtl. BUG=40920 TEST=make sure the tabstrip draws correctly when running rtl and closing/moving/inserting tabs. Review URL: http://codereview.chromium.org/1613009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44131 0039d316-1c4b-4281-b951-d872f2087c98
* Add newline to EOF to fix CrOS builder.glen@chromium.org2010-04-091-1/+1
| | | | | | | | | TBR=sky BUG=NONE TEST=NONE git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44117 0039d316-1c4b-4281-b951-d872f2087c98
* Make the bottom edges of the opaque frame rounded.glen@chromium.org2010-04-094-18/+71
| | | | | | | | | BUG=40024 TEST=On a non-AeroGlass Windows machine, verify that the bottom edges of the Window are rounded. Review URL: http://codereview.chromium.org/1560021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44115 0039d316-1c4b-4281-b951-d872f2087c98
* [accessibility] Allow views to have multiple accessibility states and add ↵mhm@chromium.org2010-04-0921-45/+141
| | | | | | | | | | | | | correct roles. Allow views to contain multiple accessibility states since states are not mutually exclusive, we treat them as an uint32. Add missing roles to couple of views. BUG=None TEST=Run unit tests, and check accessibility tree. Review URL: http://codereview.chromium.org/1527019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44054 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 05:43:03 +0000