summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Add "pushed" as a state a TextButton can show (alongside "normal" and "hover").pkasting@chromium.org2010-07-272-22/+34
| | | | | | | | BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3058011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53847 0039d316-1c4b-4281-b951-d872f2087c98
* Add undeclared virtual destructors part 2ziadh@chromium.org2010-07-278-0/+23
| | | | | | | | | | | | | Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. r=jar BUG=47469 Review URL: http://codereview.chromium.org/3032024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53831 0039d316-1c4b-4281-b951-d872f2087c98
* Fix code path in TabbedPane::RemoveTabAtIndex()mnissler@chromium.org2010-07-271-1/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3044022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53781 0039d316-1c4b-4281-b951-d872f2087c98
* Make theme change notifications auto-propagate through the view hierarchy, ↵pkasting@chromium.org2010-07-275-21/+25
| | | | | | | | | | | | instead of forcing subclasses to manually call their superclass implementation. This fixes some problems where not all views would get notified of a theme change. Make naming for theme and locale changes consistent and clear. BUG=50107 TEST=none Review URL: http://codereview.chromium.org/2878055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53736 0039d316-1c4b-4281-b951-d872f2087c98
* Make the resize gripper invisible.pkasting@chromium.org2010-07-274-145/+100
| | | | | | | | BUG=50107 TEST=Resize gripper nest to browser actions container should no longer appear Review URL: http://codereview.chromium.org/3052011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53732 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-26154-0/+154
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression that stopped properly restoring focus to tab contents.dmazzoni@chromium.org2010-07-231-3/+16
| | | | | | | | | | | | | | | | | | | | The bug in r51262 was that native_tab_contents_container_win overrides RequestFocus, so it can't be *reliably* focused just using SetFocus. This is a simple, straightforward fix that should be merged for M6. Afterwards, I think a better solution for the dev channel would be to get rid of the hacky RequestFocus overrides and add a View::HasNativeFocus method so that FocusManager can tell when it thinks a view already has focus, but the native focus might need to be set again. Thoughts? BUG=48917 BUG=49061 TEST=none Review URL: http://codereview.chromium.org/3013023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53471 0039d316-1c4b-4281-b951-d872f2087c98
* Implement initial ClipRect.ben@chromium.org2010-07-211-20/+6
| | | | | | | | | | | Move IntersectsClipRectInt and GetClipRect functions to CanvasSkia private, since they are only used internally. BUG=none TEST=see unittest. Review URL: http://codereview.chromium.org/2959014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53218 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in links ending up too small. The problem is that wesky@chromium.org2010-07-218-39/+44
| | | | | | | | | | | | | | | | | | | | changed IsFocusable to check IsVisibleInRootView. This meant that any views (like label) whose preferred size takes into account focusable and cached the preferred size before they were visible in the root view would end up with the wrong size because they didn't recalculate when IsVisibleInRootView changed. I've separated out the two states so that IsFocusable no longer checks IsVisibleInRootView and is protected. All consumers now call IsFocusableInRootView which checks IsFocusable and IsVisibleInRootView. BUG=49635 TEST=see bug. Review URL: http://codereview.chromium.org/3046008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53187 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux Views]Handle focus traversing correctly.suzhe@chromium.org2010-07-205-3/+98
| | | | | | | | | | | | This CL adds a wrapper window class on top of GtkWindow to intercept its move_focus method, so that we can handle focus traversing by ourselves. BUG=49204: Chrome/views toolbar "tab" accessibility broken. TEST=See bug report. Review URL: http://codereview.chromium.org/3013006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53123 0039d316-1c4b-4281-b951-d872f2087c98
* Use the WS_EX_NOACTIVATE flag for popup widgets. This is essentially a ↵johnnyg@chromium.org2010-07-201-1/+1
| | | | | | | | | | | no-op for the views which are contained within Chrome, but for desktop notifications which are shown when other applications are active, this prevents clicking the notification from changing the active window. BUG=47334 TEST=focus another application, close a notification. look for no flicker. Review URL: http://codereview.chromium.org/3029010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53050 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in views/gtk when pressing space bar on a menu button.sky@chromium.org2010-07-181-0/+6
| | | | | | | | | BUG=49366 TEST=see bug Review URL: http://codereview.chromium.org/3046002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52874 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure to only handle real visiblity changes in NativeViewHost.mnissler@chromium.org2010-07-161-3/+7
| | | | | | | | | BUG=49100 TEST=Open options dialog -> Personal Stuff. Turn on sync, turn off sync, switch to advanced page. Browser shouldn't crash. Review URL: http://codereview.chromium.org/2868048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52629 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 46492 to repair perf regression in XP single-core Moz Page Cyclerjar@chromium.org2010-07-161-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | Actually, this only reverts the windows specific portion of 46492. Initial revert and restore (see revisions 52456 and 52441) seemed to show that this was indeed the cause of the regression. There was some problem with the perf bot, so I'm landing again to confirm that this removes the regression. As pointed out by pkasting, this is all browser side computation, but on a single core (as noted by Darin), browser processing becomes critical path (and can impact perf). My suspicioun is that the original code did some caching of its font metrics, and this was not (to the same extent??) being done in the replacement (centralized) code. If this does not provide the perf fix I'm expecting, I'll revert it. BUG=47227 TBR=pkasting Review URL: http://codereview.chromium.org/3023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52599 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: Fix opacity of drag images.thakis@chromium.org2010-07-151-16/+11
| | | | | | | | | BUG=XXX TEST=Go to google.com, drag logo around. Preview image should now look nice. Review URL: http://codereview.chromium.org/2963009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52484 0039d316-1c4b-4281-b951-d872f2087c98
* Relayout content pref page properly upon sync status changes.mnissler@chromium.org2010-07-1512-5/+62
| | | | | | | | | | | | This fixes a layouting problem that resulted in the "Stop syncing this account" button not being sized properly after setting up sync. BUG=48807 TEST=Open options dialog in non-synced state, configure sync, check "Stop syncing this account" button after setup. Review URL: http://codereview.chromium.org/2980005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52463 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes focus placement after using ctrl+tab in dialogs.dtseng@chromium.org2010-07-141-7/+7
| | | | | | | | BUG=48986 TEST=none Review URL: http://codereview.chromium.org/2948010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52375 0039d316-1c4b-4281-b951-d872f2087c98
* This ensures ATs read the correct selected tab when the containing tabbed ↵dtseng@chromium.org2010-07-141-1/+6
| | | | | | | | | | pane gets focus. BUG=48885 TEST=none Review URL: http://codereview.chromium.org/2974006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52321 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 52249 - Windows: Fix opacity of drag images.nkostylev@google.com2010-07-141-27/+2
| | | | | | | | | | | | | | This CL broke Interactive Tests (dbg) buildbot. BUG=11457 TEST=Go to google.com, drag logo around. Preview image should now look nice. Review URL: http://codereview.chromium.org/2963009 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/2935010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52300 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent non-visible views from getting focused.mnissler@chromium.org2010-07-142-4/+56
| | | | | | | | | BUG=48719 TEST=FocusManagerTest.TraversalWithNonVisibleViews Review URL: http://codereview.chromium.org/2935005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52293 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: Fix opacity of drag images.thakis@chromium.org2010-07-141-2/+27
| | | | | | | | | BUG=11457 TEST=Go to google.com, drag logo around. Preview image should now look nice. Review URL: http://codereview.chromium.org/2963009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52249 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the announcement of combo boxes by excluding them from firing events on ↵dtseng@chromium.org2010-07-122-2/+8
| | | | | | | | | | our combobox IAccessible. Since we already call SetFocus on the native combo box, this event will go to the AT correctly, but this IAccessible won't be hooked up to the rest of the IAccessible tree. Also, any changes made in combobox.cc/h concerning accessibility won't show up when the combobox receives focus. BUG=48703 TEST=none Review URL: http://codereview.chromium.org/2937004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52132 0039d316-1c4b-4281-b951-d872f2087c98
* TTF: Re-enable ViewTest.RerouteMouseWheelTest by marking it as FAILS_.jhawkins@chromium.org2010-07-121-1/+1
| | | | | | | | | BUG=10572 TEST=ViewTest.RerouteMouseWheelTest Review URL: http://codereview.chromium.org/2946010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52131 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Minimize usage of gtk headers.erg@chromium.org2010-07-082-4/+14
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2891006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51898 0039d316-1c4b-4281-b951-d872f2087c98
* Ups the max size of bookmark menus to accommodate the wrench menu.sky@chromium.org2010-07-081-1/+3
| | | | | | | | | BUG=48309 TEST=see bug Review URL: http://codereview.chromium.org/2880019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51847 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo that caused wrong menu highlight color being used for ChromeOS.xiyuan@chromium.org2010-07-071-1/+1
| | | | | | | | | BUG=chromium-os:4580 TEST=Verify correct color 0xDCE4FA is used for menu highlight per chromium-os:4580. Review URL: http://codereview.chromium.org/2861049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51780 0039d316-1c4b-4281-b951-d872f2087c98
* Fire focus events when CustomButtons are hottracked.dtseng@chromium.org2010-07-074-4/+54
| | | | | | | | BUG=47585 TEST=none Review URL: http://codereview.chromium.org/2867040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51753 0039d316-1c4b-4281-b951-d872f2087c98
* Add some missing states for menu items. This allows AT's to know when a ↵dtseng@chromium.org2010-07-071-0/+13
| | | | | | | | | | menu item has a submenu (HASPOPUP) and is checked (either a radio or checkbox). BUG=47585 TEST=none Review URL: http://codereview.chromium.org/2858051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51751 0039d316-1c4b-4281-b951-d872f2087c98
* Fix column sizing in views::TableView.mnissler@chromium.org2010-07-072-2/+8
| | | | | | | | | | | | r51628 accidentally broke the sizing logic to only work if autosize_columns_ is set. Use a flag to track whether an initial sizing operation is required. BUG=48373 TEST=Open Content Settings Exceptions dialog, close, reopen. Columns in the table should be sized reasonably instead of being all clumped up at the left edge. Review URL: http://codereview.chromium.org/2888001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51749 0039d316-1c4b-4281-b951-d872f2087c98
* Makes menu draw disabled arrow the correct color for classic windows.sky@chromium.org2010-07-072-6/+19
| | | | | | | | | BUG=48099 TEST=see bug Review URL: http://codereview.chromium.org/2835033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51721 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes menus when shown by way of pressing alt-f. I need to turn onsky@chromium.org2010-07-073-15/+8
| | | | | | | | | | | | | | | | nested tasks as in some situations the menu may be shown when the message loop is processing a task. If the message loop is processing a taskand we don't set nested tasks allowed to true then none of the tasks scheduled by the menu (paints, delays...) are processed and the menu appears totally broken. BUG=48102 TEST=give focus to the page, press alt-f, press arrow keys and make sure the menu updates appropriately. Review URL: http://codereview.chromium.org/2836044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51719 0039d316-1c4b-4281-b951-d872f2087c98
* Bye bye tab close dot, we hardly knew you.sky@chromium.org2010-07-076-163/+21
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2813045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51718 0039d316-1c4b-4281-b951-d872f2087c98
* Display warning banner in Win preferences dialog for managed options.mnissler@chromium.org2010-07-067-83/+232
| | | | | | | | | BUG=43423 TEST=box_layout_unittest.cc, manual UI tests. Review URL: http://codereview.chromium.org/2738002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51655 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land r51526mnissler@chromium.org2010-07-0523-81/+362
| | | | | | | | | | | | | | | | | | Auto-size the views version of the options dialog. This adds support for auto-sizing tab controls, adjusts the options dialog to use it and takes care of any fallout due to the new layout handling. Also fixes a couple of small bugs in the views Layout() machinery and sanitizes layouting of options pages. BUG=36497 TEST=unit tests in tabbed_pane_unittest.cc and grid_layout_unittest.cc, as well as checking the options dialog in any supported language. original issuse: http://codereview.chromium.org/2812026/show Review URL: http://codereview.chromium.org/2883022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51628 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the menu code to show mnemonics if the alt key is down.sky@chromium.org2010-07-021-2/+13
| | | | | | | | | BUG=46445 TEST=press alt-f on windows and make sure the mnemonics are shown. Review URL: http://codereview.chromium.org/2842041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51561 0039d316-1c4b-4281-b951-d872f2087c98
* Move WindowImpl to gfx so I can use it there for canvas unit tests.ben@chromium.org2010-07-023-6/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2813042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51554 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r51526 (Auto-size the views version of the options dialog.)mnissler@chromium.org2010-07-0223-361/+81
| | | | | | | | Unexpected unit_tests crash on chromeos. TBR: mnissler git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51529 0039d316-1c4b-4281-b951-d872f2087c98
* Auto-size the views version of the options dialog.mnissler@chromium.org2010-07-0223-81/+361
| | | | | | | | | | | | | | This adds support for auto-sizing tab controls, adjusts the options dialog to use it and takes care of any fallout due to the new layout handling. Also fixes a couple of small bugs in the views Layout() machinery and sanitizes layouting of options pages. BUG=36497 TEST=unit tests in tabbed_pane_unittest.cc and grid_layout_unittest.cc, as well as checking the options dialog in any supported language. Review URL: http://codereview.chromium.org/2812026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51526 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate more old filepath functions.evan@chromium.org2010-07-011-1/+1
| | | | | | | | | | | | These still exist on Windows due to being used by the installer, but by moving them into the Windows-only block we prevent them from being used in new code. BUG=24672 Review URL: http://codereview.chromium.org/2861042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51453 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the MenuViewItem objects to a widget so that they may send ↵dtseng@chromium.org2010-07-013-3/+49
| | | | | | | | | | accessibility focus events. BUG=47585 TEST=none Review URL: http://codereview.chromium.org/2872022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51436 0039d316-1c4b-4281-b951-d872f2087c98
* Moves gtk accelerator processing functions to base/gtk_util so I cansky@chromium.org2010-07-011-20/+2
| | | | | | | | | | | | | use them from views and gfx. Sorry for the new patch on this and not an update. Not sure what happened. BUG=none TEST=none Review URL: http://codereview.chromium.org/2809047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51409 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the bookmark menu.pkasting@chromium.org2010-07-011-4/+0
| | | | | | | | BUG=none TEST=--bookmark-menu no longer does anything Review URL: http://codereview.chromium.org/2853024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51403 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in showing menus. This is less likely now thatsky@chromium.org2010-07-012-11/+67
| | | | | | | | | | | | | | | | | | main menu is using the bookmark menu, but still worth trying to fix. We run a nested message loop when showing a menu. When a click occurs outside the menu gtk closes the menu and we exit the nested message loop. The problem is that click is dispatched from the nested message loop, meaning it's possible to attempt to spawn another menu or do other things from the nested message loop. To fix it I'm manually closing the popup and not dispatching the event. BUG=40492 TEST=see bug, but in general make sure chrome specific menus (time, network ...) continue to work. Review URL: http://codereview.chromium.org/2861037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51372 0039d316-1c4b-4281-b951-d872f2087c98
* Adding support for ChromeOS snapshot window titles and favicons.gspencer@chromium.org2010-06-302-69/+92
| | | | | | | | | TEST=build and ran with chromeos-wm BUG=chromium-os:2866, chromium-os:2867 Review URL: http://codereview.chromium.org/2857005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51305 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring phase 4b:ben@chromium.org2010-06-305-12/+12
| | | | | | | | | | | Add BeginPlatformPaint/EndPlatformPaint calls to gfx::Canvas. BeginPlatformPaint() returns a gfx::NativeDrawingContext. BUG=none TEST=none Review URL: http://codereview.chromium.org/2840029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51297 0039d316-1c4b-4281-b951-d872f2087c98
* Minor fixes to toolbar keyboard accessibility: focusing the location bardmazzoni@chromium.org2010-06-302-8/+43
| | | | | | | | | | | | | | | should select all, accessibility focus should be preserved when the whole window loses and regains focus, and clicking on the location bar should exit accessibility focus mode. BUG=47380 BUG=36070 BUG=47784 TEST=none Review URL: http://codereview.chromium.org/2833040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51262 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: Replace tabs in content settings with a listbox.thakis@chromium.org2010-06-301-4/+4
| | | | | | | | | | | Depends on http://codereview.chromium.org/2815034 BUG=45546 TEST=Open content settings dialog. Should have a list on the left instead of tabs on top. Other than that, the dialog should work as before. Review URL: http://codereview.chromium.org/2799042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51205 0039d316-1c4b-4281-b951-d872f2087c98
* Win: Add listbox view.thakis@chromium.org2010-06-307-10/+375
| | | | | | | | | | | | | See http://codereview.chromium.org/2799042 for how I intend to use this. BUG=45546 TEST=None BUG=45546 TEST=None Review URL: http://codereview.chromium.org/2815034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51196 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring Phase 4a:ben@chromium.org2010-06-294-14/+13
| | | | | | | | | | | Move Save, SaveLayerAlpha and Restore onto gfx::Canvas. BUG=none TEST=none Review URL: http://codereview.chromium.org/2846035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51179 0039d316-1c4b-4281-b951-d872f2087c98
* Disables another crashing test.sky@chromium.org2010-06-281-1/+2
| | | | | | | | | | BUG=45015 TEST=none TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/2880004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51020 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 00:50:34 +0000