| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=None
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7281019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=None
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7284019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes leaks in ViewTest.* and NativeTextFieldViewsTest.*.
BUG=87904
TEST=tools/valgrind/chrome_tests.sh views --gtest_filter=ViewTest.*:NativeTextFieldViewsTest.*
Review URL: http://codereview.chromium.org/7280008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
in a simple vector.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7280013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=None
R=rsesek@chromium.org
Review URL: http://codereview.chromium.org/7253057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
NativeWidgetView. This is why menu wasn't showing.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7248032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/7281012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7282001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Eliminates leaks from NativeWidgetTest.*. Adds additional test target to valgrind wrapper script. Refactors native_widget_test_utils_{gtk|win}.cc to avoid duplication.
BUG=87805
TEST=tools/valgrind/chrome_tests.sh views --gtest_filter=NativeWidgetTest.*
Review URL: http://codereview.chromium.org/7272044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7253058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7276053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=86979
Review URL: http://codereview.chromium.org/7276040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6982062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
rendering issues I believe.
Moves IsMouseButtonDown to a static method on Widget that is implemented by each platform. It needs to be static as it can be called before the NativeWidget is fully initialized, and does not depend on any NativeWidget state.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7253018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=views_unittest --gtest_filter=ViewTest.OnBoundsChanged
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7274012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=sky@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=clang bot
TEST=none
TBR=sky@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, make sure the touch_pressed_handler_ is the view being removed before resetting it to NULL.
BUG=none
TEST=things compile and existing tests continue to pass
Review URL: http://codereview.chromium.org/7276002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the layer we force the complete bounds to be painted. This way the
Compositors don't have to worry about partial update of a size they've
never seen. This matches old logic I removed thinking it was no longer
needed.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7272013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manually
Review URL: http://codereview.chromium.org/7244002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=views_unittests --gtest_filter=ViewTest.GetViewByID
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7272003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on top of the RootView using a transient decorator.
BUG=none.
TEST=none.
Review URL: http://codereview.chromium.org/7115001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=84791
TEST=Test the checkbox in the uninstaller as mentioned in the bug, but also
all checkboxes in chrome too.
Review URL: http://codereview.chromium.org/7196002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=None
R=rsesek@chromium.org
Review URL: http://codereview.chromium.org/7262013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7242025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/7170018/ causes this problem.
In CL 7170018, it will not create the input method until it
is requested by a child view. So in that time, a child view
may already be focused. So we need sync focus state with
input method.
BUG=Virtual keyboard does not work on Login screen
TEST=Seaboard
Review URL: http://codereview.chromium.org/7222007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a crash when running chrome with --use-pure-views --views-desktop
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7263017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pump and an X message pump.
The changes:
* Rename MessagePumpGlibX to MessagePumpX.
* Rename MessagePumpForUI to MessagePumpGlib.
* Move some stuff out of MessagePumpGlib, and into MessagePumpGtk and MessagePumpX.
* Rename MessagePumpForUI::Observer to MessageObserver, moved the platform-specific implementations into MessagePumpGtk and MessagePumpX. Ditto for MessagePumpForUI::Dispatcher.
MessagePumpX is independent of MessagePumpGtk. At the moment, MessagePumpX does process some GDK event, but once we have a complete native_widget_x, we can take out the GDK processing and things should continue to work.
BUG=none
TEST=existing message-pump tests.
Review URL: http://codereview.chromium.org/7250001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The use case for this is the ChromiumOS OOBE network menu. This menu is dynamic - access points may be added or removed while the menu is open so the number of items in the menu can change. At a certain threshold, the menu will "hop" between above and below the button. This CL provides a way to disable repositioning so the menu is always displayed below the button.
BUG=chromium-os:16720
TEST=open OOBE network menu with a lot of WiFi access points around, check that the menu is drawn below the button
Review URL: http://codereview.chromium.org/7217026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will be used to display texture produced by the GPU process for the RWHVV via the browser compositor.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7231012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=build success
Review URL: http://codereview.chromium.org/7240007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
in a couple of cases.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7247020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org,wjmaclean@chromium.org
Review URL: http://codereview.chromium.org/7242005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a BrowserFrameViews stub.
- Add a NativeTabContentsViewViews stub.
- Allow the omnibox to run in pure-views mode on Windows too.
- Make the RenderWidgetHostViewViews build on Windows.
chrome --use-pure-views --views-desktop runs, shows a browser window, but doesn't really do anything else.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7206055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=None
R=ben@chromium.org,sky@chromium.org
Review URL: http://codereview.chromium.org/7238006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
class NativeButtonBase which is no longer needed.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7218035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72317
TEST=views_unittests, views_desktop, views_examples
R=sky@chromium.org,phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/7200022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
instead of the master device to determine if we should process the event or not.
BUG=none
TEST=test that there is only one mousedown event for a mouseclick
Review URL: http://codereview.chromium.org/7232022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change addresses review feedback from:
http://codereview.chromium.org/7003080/
BUG=
TEST=
Review URL: http://codereview.chromium.org/7229014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org,tony@chromium.org
Review URL: http://codereview.chromium.org/7215022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=sky@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
R=rvargas@chromium.org, hashimoto@chromium.org
Review URL: http://codereview.chromium.org/7233002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Implemented character composition from key strokes starting with dead keys or compose key
BUG=chromium-os:13882, chromium-os:15925
TEST=
Review URL: http://codereview.chromium.org/6979023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the second definition of the ObserverView class, that was added
by the merge conflict.
This reverts commit 2a16ddfe7e09bec206daf6bdab3ef6d1a573dbfd.
BUG=None
TEST=views_unittests --gtest_filter=ViewTest.ViewHierarchyChanged
TBR=sky@chromium.org
Original Review URL: http://codereview.chromium.org/7184031
Review URL: http://codereview.chromium.org/7206060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=None
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7202015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Extract the code from TestView class.
- Move the code into a new class called ObserverView.
- Rename the test case from AddRemoveNotifications to ViewHierarchyChanged.
- Use ObserverView class instead of TestView.
- Improve the checks, make them more clearer.
- Use EXPECT_TRUE instead of EXPECT_EQ(true, something); same thing for the false case.
BUG=None
TEST=views_unittests --gtest_filter=ViewTest.ViewHierarchyChanged
Review URL: http://codereview.chromium.org/7184031
TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/7218025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Extract the code from TestView class.
- Move the code into a new class called ObserverView.
- Rename the test case from AddRemoveNotifications to ViewHierarchyChanged.
- Use ObserverView class instead of TestView.
- Improve the checks, make them more clearer.
- Use EXPECT_TRUE instead of EXPECT_EQ(true, something); same thing for the false case.
BUG=None
TEST=views_unittests --gtest_filter=ViewTest.ViewHierarchyChanged
Review URL: http://codereview.chromium.org/7184031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org,wjmaclean@chromium.org
Review URL: http://codereview.chromium.org/7189067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
non-const one.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7214001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89838 0039d316-1c4b-4281-b951-d872f2087c98
|