summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* views: Add table2_example to views_examples target.tfarina@chromium.org2011-01-233-150/+196
| | | | | | | | | | | Also move the implementation from header to the source file. BUG=None TEST=run out/Debug/views_examples, everything should works as before. Review URL: http://codereview.chromium.org/6264010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72300 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move box_layout.[cc,h] into the new layout directory.tfarina@chromium.org2011-01-225-13/+13
| | | | | | | | | | | The other layout files under views directory will be moved later. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6380010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72243 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to ui/baseben@chromium.org2011-01-2123-28/+28
| | | | | | | | | BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72227 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move the implementation of TabbedPaneExample from the header file to ↵tfarina@chromium.org2011-01-213-76/+107
| | | | | | | | | | | the source file. BUG=None TEST=run out/Debug/views_examples, it should work as before. Review URL: http://codereview.chromium.org/6283008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72211 0039d316-1c4b-4281-b951-d872f2087c98
* Fix range comparison. Get space to accept keyword work.oshima@google.com2011-01-211-3/+3
| | | | | | | | | | | I overlooked this placeholder code to fix. BUG=none TEST=enabled AcceptKeywordBySpaceTest for views-implementation Review URL: http://codereview.chromium.org/6266015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72185 0039d316-1c4b-4281-b951-d872f2087c98
* views: Make CreatePanelGridLayout a static method of GridLayout class.tfarina@chromium.org2011-01-214-15/+16
| | | | | | | | | | | Move it from standard_layout.h and rename to just CreatePanel. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6384002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72128 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move the implementation of SingleSplitViewExample from the header ↵tfarina@chromium.org2011-01-213-49/+82
| | | | | | | | | | | file to the source file. BUG=None TEST=run out/Debug/views_examples, it should work as before. Review URL: http://codereview.chromium.org/6377004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72086 0039d316-1c4b-4281-b951-d872f2087c98
* Add OWNERS files for accessibility directories.dmazzoni@chromium.org2011-01-211-0/+3
| | | | | | Review URL: http://codereview.chromium.org/6272013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72058 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in menus. The crash would happen because we weresky@chromium.org2011-01-211-0/+1
| | | | | | | | | | | incorrectly clearing the selection. BUG=62872 TEST=none Review URL: http://codereview.chromium.org/6275009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72048 0039d316-1c4b-4281-b951-d872f2087c98
* Move ResourceBundle, DataPack to ui/baseben@chromium.org2011-01-2021-20/+28
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6263008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72038 0039d316-1c4b-4281-b951-d872f2087c98
* Make uneditable when readonly.oshima@google.com2011-01-205-20/+105
| | | | | | | | | | | | | This change makes the textfield uneditable. The text can still be updated via API (which is necessary to show URL in popup). BUG=none TEST=uadded new ReadOnlyTest Review URL: http://codereview.chromium.org/6314012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72022 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression in submenus not working.jam@chromium.org2011-01-201-2/+15
| | | | | | | BUG=69797 Review URL: http://codereview.chromium.org/6304013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72005 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Allow grabbing/ungrabbing touch devices for XInput2.sadrul@chromium.org2011-01-205-32/+195
| | | | | | | | | | | | | | | This allows touch devices to be grabbed when events from the mouse/keyboard are grabbed. This also exposes TouchFactory, which will eventually be used in more places. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71879 Review URL: http://codereview.chromium.org/6300007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72002 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustageben@chromium.org2011-01-201-2/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71971 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of random other files to src/ui/baseben@chromium.org2011-01-2028-65/+79
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6257006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71970 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 71879 due to compile failure - touch: Allow grabbing/ungrabbing touch ↵sadrul@chromium.org2011-01-205-170/+32
| | | | | | | | | | | | | | | | | | devices for XInput2. This allows touch devices to be grabbed when events from the mouse/keyboard are grabbed. This also exposes TouchFactory, which will eventually be used in more places. BUG=none TEST=none Review URL: http://codereview.chromium.org/6300007 TBR=sadrul@chromium.org Review URL: http://codereview.chromium.org/6349008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71885 0039d316-1c4b-4281-b951-d872f2087c98
* Move BiDiLineIterator to base/i18n/ directory.tfarina@chromium.org2011-01-201-3/+3
| | | | | | | | | BUG=23581 TEST=trybots Review URL: http://codereview.chromium.org/6249007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71884 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Allow grabbing/ungrabbing touch devices for XInput2.sadrul@chromium.org2011-01-205-32/+170
| | | | | | | | | | | | | This allows touch devices to be grabbed when events from the mouse/keyboard are grabbed. This also exposes TouchFactory, which will eventually be used in more places. BUG=none TEST=none Review URL: http://codereview.chromium.org/6300007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71879 0039d316-1c4b-4281-b951-d872f2087c98
* Move UI-relevant Windows files to ui/base.ben@chromium.org2011-01-1913-38/+37
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6254011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71854 0039d316-1c4b-4281-b951-d872f2087c98
* Move more dnd related files to ui/baseben@chromium.org2011-01-1914-68/+59
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6250014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71828 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Gesture manager receives the touch-sequence status.sadrul@chromium.org2011-01-194-21/+28
| | | | | | | | | | | | | OnTouchEvent now returns the status of the touch sequence, instead of a simple bool. The gesture manager can presumably make a better decision if this information is available to it. For more details: http://codereview.chromium.org/6347002/ BUG=none TEST=ViewTest.TouchEvent Review URL: http://codereview.chromium.org/6253005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71824 0039d316-1c4b-4281-b951-d872f2087c98
* Add TextRange and GetSelectedRange, SelectRange and GetCursorPosition, which ↵oshima@google.com2011-01-1912-26/+325
| | | | | | | | | | | | | | | are necessary to implement ominibox. I'm adding them as Views only and left win/gtk blank because we don't use win/gtk impl for omnibox. I also didn't add TextRange variable to Textfield as its state is kept in Model. Let me know if you want to add it in Textfield class as well. BUG=none TEST=added new tests RangeTest, SelectRangeTest Review URL: http://codereview.chromium.org/6318004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71811 0039d316-1c4b-4281-b951-d872f2087c98
* Move SystemMonitor to src/ui/base/system_monitor. Move HiResTimerManager to ↵ben@chromium.org2011-01-191-2/+2
| | | | | | | | | | | | | src/chrome/common. BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6361002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71797 0039d316-1c4b-4281-b951-d872f2087c98
* views: Implement NativeTableGtk::RemoveColumn method.tfarina@chromium.org2011-01-191-3/+13
| | | | | | | | | | | | | | | Also fix the following error when we try to get the width of column that does not exist anymore. (views_examples:3921): Gtk-CRITICAL **: gtk_tree_view_column_get_width: assertion `GTK_IS_TREE_VIEW_COLUMN (tree_column)' failed BUG=None TEST=export GYP_DEFINES="toolkit_views" && gclient runhooks && make -j4 -k views_examples out/Debug/views_examples, go to the table tab. Now clicking in one of the checkboxes, the corresponded column should be removed. Review URL: http://codereview.chromium.org/6256004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71786 0039d316-1c4b-4281-b951-d872f2087c98
* Make the code for unmaximizing the window during SetBounds much simpler.levin@chromium.org2011-01-192-4/+4
| | | | | | | | | | | | | | This still fixes the original bug and does it in a much simpler (and faster) way. I was previously attempting to use an API to do this rather than just setting the style directly but that API may have hidden side effects like causing a window activation on some versions of Windows. BUG=69724 TEST=WidgetWinTest::SetBoundsForZoomedWindow Review URL: http://codereview.chromium.org/6331006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71767 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Return an enum from OnTouchEvent.sadrul@chromium.org2011-01-187-20/+44
| | | | | | | | | | | The enum returned from OnTouchEvent reflects the current status of the touch-sequence. This can be used by the RootView to determine when the touch-event-handler should be reset. BUG=none TEST=none Review URL: http://codereview.chromium.org/6347002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71677 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where if preferred size of button was asked for while theresky@chromium.org2011-01-181-1/+1
| | | | | | | | | | | was no native view we would cache the wrong size leading to clipping. BUG=51007 TEST=see bug for repro steps (specifically comment 6). Review URL: http://codereview.chromium.org/6268004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71675 0039d316-1c4b-4281-b951-d872f2087c98
* Some wstring -> string16 conversion in src/app.tony@chromium.org2011-01-181-1/+1
| | | | | | | | | | | | | | | It looks like l10n_util_dummy.cc isn't needed anymore: The function in the file doesn't match any functions in l10n_util.h. Convert BidiLineIterator to use string16. I don't see any unittests for this file. :( BUG=23581 TEST=None Review URL: http://codereview.chromium.org/6315002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71667 0039d316-1c4b-4281-b951-d872f2087c98
* Allow printing/saving a plugin through right click menu, even if it's in a ↵jam@chromium.org2011-01-151-17/+22
| | | | | | | | | frame or an embed element. BUG=50285 Review URL: http://codereview.chromium.org/6142013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71519 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the check for the window being active after SetBounds because it ↵levin@chromium.org2011-01-151-1/+3
| | | | | | | | | | | fails on some platforms. BUG=69724 TEST=WidgetWinTest.SetBoundsForZoomedWindow Review URL: http://codereview.chromium.org/6259004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71516 0039d316-1c4b-4281-b951-d872f2087c98
* Support accDoDefaultAction for NativeButton in ViewAccessibility.ctguil@chromium.org2011-01-142-7/+20
| | | | | | | | | BUG=none TEST=Manual Review URL: http://codereview.chromium.org/6310002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71512 0039d316-1c4b-4281-b951-d872f2087c98
* Removed executable bit from two files where it should not have been set.levin@chromium.org2011-01-142-0/+0
| | | | | | | | | | TBR=ben@chromium.org TEST=check perms test BUG=None Review URL: http://codereview.chromium.org/6341002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71504 0039d316-1c4b-4281-b951-d872f2087c98
* WidgetWin::SetBound on a maximized window leaves the window in the ↵levin@chromium.org2011-01-143-2/+86
| | | | | | | | | | | | | | 'maximized' state. Now when SetBounds is called, we detect the maximized state and take the window out of this state. BUG=69618 TEST=WidgetWinTest.SetBoundsForZoomedWindow (added) Review URL: http://codereview.chromium.org/6268002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71499 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 71487 - Move SystemMonitor to src/ui/base/system_monitor.ben@chromium.org2011-01-141-2/+2
| | | | | | | | | | | | | | Move HiResTimerManager to src/chrome/common. BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6361002 TBR=ben@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71489 0039d316-1c4b-4281-b951-d872f2087c98
* Move SystemMonitor to src/ui/base/system_monitor.ben@chromium.org2011-01-141-2/+2
| | | | | | | | | | | | Move HiResTimerManager to src/chrome/common. BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6361002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71487 0039d316-1c4b-4281-b951-d872f2087c98
* Add some OWNERS files.ben@chromium.org2011-01-142-0/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6320004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71484 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for broken buildvarunjain@chromium.org2011-01-143-9/+9
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6287002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71469 0039d316-1c4b-4281-b951-d872f2087c98
* Implementing context menu for the new views textfield.varunjain@chromium.org2011-01-147-38/+177
| | | | | | | | | BUG=none TEST=right click on the new textfield should show the context menu and all commands on the menu should work. Review URL: http://codereview.chromium.org/6155011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71467 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from views. Part 3: Switch accessibility strings to string16.avi@chromium.org2011-01-1425-63/+66
| | | | | | | | | BUG=68267 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6192007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71461 0039d316-1c4b-4281-b951-d872f2087c98
* Move models from app to ui/base/modelsben@chromium.org2011-01-1442-142/+189
| | | | | | | | | BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71446 0039d316-1c4b-4281-b951-d872f2087c98
* Clang: enable -Wbool-conversions and -Wunused-variables on Linux.hans@chromium.org2011-01-141-4/+4
| | | | | | | | | | | | | | | -Wbool-conversion warns about EXPECT_EQ(false, blah), so replace that with EXPECT_FALSE(blah). Do the same with EXPECT_EQ(true, blah) for good measure (even though that doesn't generate warnings). Also remove the one instance of an unused variable. BUG=69421 TEST=buildbots all compile and all tests pass Review URL: http://codereview.chromium.org/6300001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71431 0039d316-1c4b-4281-b951-d872f2087c98
* Adds some debugging in code in hopes of figuring out a crash in thesky@chromium.org2011-01-132-90/+121
| | | | | | | | | | | | | | menu code. It seems like we end up getting mouse events from a widget that is no longer visible. Additionally it seems possible that the selection is cleared before we expect it. Hopefully both of these CHECKs will help figure out what is going on. BUG=62872 TEST=none Review URL: http://codereview.chromium.org/6288002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71371 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove SetAppearsAsDefault() since it is no longer called ↵pkasting@chromium.org2011-01-132-14/+5
| | | | | | | | | | externally. Inline its functionality into the lone internal caller. BUG=none TEST=none Review URL: http://codereview.chromium.org/6133011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71333 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/key* to ui/base/keycodes/*ben@chromium.org2011-01-1348-357/+358
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6246001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71330 0039d316-1c4b-4281-b951-d872f2087c98
* Delete test view delegate at end of testjochen@chromium.org2011-01-131-1/+4
| | | | | | | | | BUG=none TEST=leak 000000002551055A goes away Review URL: http://codereview.chromium.org/6132009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71309 0039d316-1c4b-4281-b951-d872f2087c98
* views: Implement NativeTableGtk::SetColumnWidth method.tfarina@chromium.org2011-01-131-1/+7
| | | | | | | | | | BUG=None TEST=export GYP_DEFINES="toolkit_views" && gclient runhooks && make -j4 -k views_examples out/Debug/views_examples, everything should work as before. Review URL: http://codereview.chromium.org/6166011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71262 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land 71230.eroman@chromium.org2011-01-135-59/+328
| | | | | | | | | | | | | | | | | | | | | | This restores 71230 which was reverted in 71252 by sheriff (to see if it was responsible for a linux test failure -- it was not). Original change by alekseys: Streamline the layout of the BrowserView's children TabContents views. Modify SingleSplitView to calculate its children view's bounds, but do not actually resize them and change BrowserViewLayout accordingly (BrowserViewLayout resizes all views now). Do all reserved contents rect calculations before resizing TabContents views. Rationale: to do all BrowserView layout related actions in the context of BrowserViewLayout::Layout call and to minimize actual contents re-layouts. BUG=51084 TEST=All tests should pass Review URL: http://codereview.chromium.org/5606012 Review URL: http://codereview.chromium.org/6247001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71259 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 71230 to see if it is related to hang on linux interactive_ui_tests.eroman@chromium.org2011-01-125-328/+59
| | | | | | | | | | | | | | | | | | | | | | Original CL description: Streamline the layout of the BrowserView's children TabContents views. Modify SingleSplitView to calculate its children view's bounds, but do not actually resize them and change BrowserViewLayout accordingly (BrowserViewLayout resizes all views now). Do all reserved contents rect calculations before resizing TabContents views. Rationale: to do all BrowserView layout related actions in the context of BrowserViewLayout::Layout call and to minimize actual contents re-layouts. BUG=51084 TEST=All tests should pass Review URL: http://codereview.chromium.org/5606012 TBR=alekseys@chromium.org Review URL: http://codereview.chromium.org/6121007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71252 0039d316-1c4b-4281-b951-d872f2087c98
* Streamline the layout of the BrowserView's children TabContents views.alekseys@chromium.org2011-01-125-59/+328
| | | | | | | | | | | | | | | | Modify SingleSplitView to calculate its children view's bounds, but do not actually resize them and change BrowserViewLayout accordingly (BrowserViewLayout resizes all views now). Do all reserved contents rect calculations before resizing TabContents views. Rationale: to do all BrowserView layout related actions in the context of BrowserViewLayout::Layout call and to minimize actual contents re-layouts. BUG=51084 TEST=All tests should pass Review URL: http://codereview.chromium.org/5606012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71230 0039d316-1c4b-4281-b951-d872f2087c98
* Handle WM_SYSKEYDOWN in NativeTextfieldWin.oshima@google.com2011-01-121-0/+3
| | | | | | | | | BUG=69248 TEST=Manual: open find bar and hit alt on debug build. Review URL: http://codereview.chromium.org/6156009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71206 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 13:00:27 +0000