summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* focus reverse traversal was not working for TextfieldViews.oshima@chromium.org2011-01-0610-63/+230
| | | | | | | | | | | | | | Both Textfield and TextfieldViews were focusable and alt-tab was setting the focus back to the Textfield, which sets the focus to the its TextfieldViews. This fixes the issue by making Textfield non focusable. BUG=none TEST=FocusTest is added to unittest. Review URL: http://codereview.chromium.org/5988010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70624 0039d316-1c4b-4281-b951-d872f2087c98
* Replace Textfield::Keystroke with views::KeyEvent.oshima@chromium.org2011-01-0510-92/+65
| | | | | | | | | | | | | It looks big, but most of change is simple signature change. Note: I need your advice on how to deal with WM_CHAR event on Win. Please see my comment below. BUG=none TEST=no new functionality. All tests should still pass. Review URL: http://codereview.chromium.org/6034002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70553 0039d316-1c4b-4281-b951-d872f2087c98
* views: Improve cursor movements on word boundaries.sadrul@chromium.org2011-01-053-12/+69
| | | | | | | | | | | | | | | | | | | | (1) When there's blank space at the end of the string in the textfield and the cursor is at the end, 'move cursor to previous word' should move the cursor at the beginning of the last word. (2) When there's blank space at the end of the string, and the cursor is at the end of the last word, 'move cursor to next word' should move the cursor at the end. (3) Moving the cursor should make the cursor immediately visible. This is more inline with how GTK+ cursors behave. For example, constantly pressing the home-key in a GTK+ textfield makes the cursor visible for the duration of the keypress. BUG=none TEST=NativeTextfieldViewsTest.CursorMovement Review URL: http://codereview.chromium.org/5972008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70468 0039d316-1c4b-4281-b951-d872f2087c98
* views (linux): Fix keyboard shortcuts.sadrul@chromium.org2011-01-041-19/+1
| | | | | | | | | | | | | | BUG=Pressing backspace in a textfield in a web-page triggers the 'navigate back' action in the browser. This is because the accelerator gets triggered before the renderer has a chance to get to the key. To fix this bug, rearrange the keypress event handler for RenderWidgetHostViewViews. The views-way of keypress handling is more similar on windows and linux with this change. TEST=see bug Review URL: http://codereview.chromium.org/6002007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70456 0039d316-1c4b-4281-b951-d872f2087c98
* views: Fix shifted keyevents in textfield.sadrul@chromium.org2011-01-042-4/+22
| | | | | | | | | | | | Pressing 0-9 in a textfield with caps lock turned on would generate shifted keyevents, which it shouldn't. So distinguish between caps-lock and shift. BUG=none TEST=none Review URL: http://codereview.chromium.org/6068005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70452 0039d316-1c4b-4281-b951-d872f2087c98
* Change Font.GetStringWidth() to take string16 instead of wstring.estade@chromium.org2011-01-048-20/+25
| | | | | | | | | | | do a bunch of string fixes along the way. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/5985007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70440 0039d316-1c4b-4281-b951-d872f2087c98
* OnKeyPress was not returning true when keypress is handled.oshima@chromium.org2011-01-042-4/+14
| | | | | | | | | BUG=none TEST=TestOnKeyPressReturnValue is added. Review URL: http://codereview.chromium.org/5964013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70424 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from l10n_util. Part 4.avi@chromium.org2011-01-047-41/+51
| | | | | | | | | BUG=9911 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/5958017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70423 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/win_util to app/win and fix the namespace usage.brettw@google.com2010-12-316-24/+26
| | | | | | | | | | | | | | Split out the two classes: ScopedComInitializer and ScopedCOMem (which I renamed) to separate files. I removed the win_util_path file which had one function in it and moved the function to win_util. Somehow, this was getting picked up by the nacl64 build and the call in sandbox_policy was then not being defined. I just implemented the function in-plcae since it's just a simple wrapper around a Windows API call. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6013009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70343 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/win_util to the base/win directory and use the base::win namespace.brettw@google.com2010-12-318-16/+13
| | | | | | | | | Fix up includes, many files including base/win_util don't actually need it. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70341 0039d316-1c4b-4281-b951-d872f2087c98
* Move some functions out of win_util and into hwnd_util, and into a new ↵brettw@google.com2010-12-302-7/+56
| | | | | | | | | | | | win/shell file. This also moves two functions that were only called once from win_util and inwo window_win and download_util, respectively. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6035011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70321 0039d316-1c4b-4281-b951-d872f2087c98
* Remove win_util::FormatMessage and FormatLastWin32Error. These were only ↵brettw@google.com2010-12-3012-32/+32
| | | | | | | | | | | | | | used in a couple of diagnostic places and one can always use the "Error Lookup" utility. Move window HWND-specific functions from base/win_util.h to a new file app/win/hwnd_util.h. I plan to put some more stuff from app/win_util into this file as well. Move gfx/window_impl.h into app/win TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6019007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70312 0039d316-1c4b-4281-b951-d872f2087c98
* Leftover wstring removal from r70290sadrul@chromium.org2010-12-301-13/+18
| | | | | | | | | | | This should fix compile in the touch buildbot. BUG=touch buildbot is broken TEST=see bug Review URL: http://codereview.chromium.org/6038006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70297 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from TableModel.avi@chromium.org2010-12-302-12/+13
| | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6044007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70290 0039d316-1c4b-4281-b951-d872f2087c98
* Remove more 'using' declarations of Scoped* from scoped_handle_win.htfarina@chromium.org2010-12-291-2/+3
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6040002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70286 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Fix buildbot.sadrul@chromium.org2010-12-281-2/+4
| | | | | | | | | BUG=the touch buildbot fails TEST=see bug Review URL: http://codereview.chromium.org/6035004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70231 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilePath::BaseName instead of the deprecated file_util::GetFilenameFromPath.tfarina@chromium.org2010-12-232-4/+3
| | | | | | | | | BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/6070008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70006 0039d316-1c4b-4281-b951-d872f2087c98
* Notify the root widget the the Theme changes when FrameTypeChanged() is evokedzork@chromium.org2010-12-221-3/+3
| | | | | | | | | BUG=chromium-os:9922 TEST=Change the theme. Check that the buttons are the right color. Review URL: http://codereview.chromium.org/5861002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69934 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Fix switching focus among fields in webpages.sadrul@chromium.org2010-12-211-10/+18
| | | | | | | | | | | | | | | | | If Tab is pressed, then the RootView needs to process it first, because the focus-manager will move the focus to the next focusable view, without letting the currently focused view process it (which means, for example, tab-ing to move focus between fields/links in a RenderWidgetHostViewViews won't work). For all other keys, let the focus manager process it first so that the keyboard accelerators can be triggered. BUG=pressing tab in a textfield in a touch-build doesn't move focus out of it. TEST=see bug Review URL: http://codereview.chromium.org/6016002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69846 0039d316-1c4b-4281-b951-d872f2087c98
* Add base:: prefix to the calls to StringAppendV.tfarina@chromium.org2010-12-211-2/+3
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6055003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69785 0039d316-1c4b-4281-b951-d872f2087c98
* A NativeHostViewViews class for embedding views inside NativeHostView instances.anicolao@google.com2010-12-175-3/+158
| | | | | | | | | BUG=none TEST=manually on touchui build Review URL: http://codereview.chromium.org/5785001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69551 0039d316-1c4b-4281-b951-d872f2087c98
* no native implementation of Textfield.oshima@chromium.org2010-12-1714-31/+1838
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is based on the original CL http://codereview.chromium.org/3142008. The key difference is * This uses Textfield framework and NativeTextfieldView implements NativeTextfieldWrapper. This allows us to swap the implementation without recompling the tree and can start testing on bots. * Changed the name of the model to TextfieldViewModel as TextfieldModel may be confusing as other Textfield implementations are not using it. I also changed to use string16 instead of gap buffer as it's enough for single line text. We can update the model to use GapBuffer when necessary. * Changed to use string16 as that's what chrome codebase should use. * Added a switch to turn on TextfieldView. I also filled a couple of features such as: * selection by key * mouse actions (move cursor, selection) * used WordIterator, which is i18n compatible, to move cursor by word * blinking cursor This is only for linux based build due to KeyStroke difference. I'm going to move some of test utlity function in chrome/browser/automation/ui_controls to app/test and will add more test once the migration is done. BUG=none TEST=new unit tests are added : NativeTestfieldViewTest and TextfieldViewModelTest. Review URL: http://codereview.chromium.org/5857002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69523 0039d316-1c4b-4281-b951-d872f2087c98
* Commiting second word iterator patch for tsepez. this was originally ↵cdn@chromium.org2010-12-151-3/+3
| | | | | | | | reviewed at http://codereview.chromium.org/5796003/ Review URL: http://codereview.chromium.org/5707011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69278 0039d316-1c4b-4281-b951-d872f2087c98
* Forward unhandled KeyEvents to WidgetGtk's HandleKeyboardEvent() in native ↵zork@chromium.org2010-12-152-2/+39
| | | | | | | | | | | textfields. BUG=chromium-os:6990,chromium-os:9738 TEST=Click on the omnibox's star. Press enter. Check that the bookmark bubble closes. Review URL: http://codereview.chromium.org/5254011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69241 0039d316-1c4b-4281-b951-d872f2087c98
* Change menus on OSX to update the icon dynamically.atwilson@chromium.org2010-12-152-2/+5
| | | | | | | | | | | | | | | | | Change MenuModel::IsLabelDynamicAt() to IsItemDynamicAt() to reflect its true purpose. Add SimpleMenuModel::GetIconForCommandId() to enable dynamic icons. Update OSX menu_controller code to update the icon for dynamic menu items when the menu is opened, to match the windows behavior. BUG=66508 TEST=MenuControllerTest.Dynamic Review URL: http://codereview.chromium.org/5697005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69234 0039d316-1c4b-4281-b951-d872f2087c98
* Fix GestureManager Singleton implementationbryeung@google.com2010-12-143-3/+3
| | | | | | | | | | | | | | | This fix makes GestureManager conform to the new way of doing Singletons. As per satish@'s email Tue, Dec 14, 2010. "Changes to Singleton<T> pattern usage" This affects the touchui build only. Original CL is http://codereview.chromium.org/3192002 BUG= TEST= Review URL: http://codereview.chromium.org/5696005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69133 0039d316-1c4b-4281-b951-d872f2087c98
* Make members of Singleton<T> private and only visible to the singleton type. ↵satish@chromium.org2010-12-142-1/+10
| | | | | | | | | | | | | | | This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69107 0039d316-1c4b-4281-b951-d872f2087c98
* Rename all methods accessing Singleton<T> as GetInstance().satish@chromium.org2010-12-131-2/+2
| | | | | | | | | | | | | | | This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton. This primarily covers files in chrome os and other directories, missed in the previous CL. In a couple of files i changed Singleton<T> usage to LazyInstance<T>, because changing the method name to GetInstance() in there would require a whole lot of updates throughout the chrome os codebase. BUG=65298 TEST=all existing tests should pass. Review URL: http://codereview.chromium.org/5734002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69007 0039d316-1c4b-4281-b951-d872f2087c98
* Rename all methods accessing Singleton<T> as GetInstance().satish@chromium.org2010-12-136-9/+9
| | | | | | | | | | | | | This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton. I also moved pepper::ResourceTracker to a lazy instance since there were too many places in code where this class was being accessed from and this was a smaller change than renaming methods in that case. BUG=65298 TEST=all existing tests should pass. Review URL: http://codereview.chromium.org/5685007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68982 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68932 - Make members of Singleton<T> private and only visible to the ↵satish@chromium.org2010-12-112-10/+1
| | | | | | | | | | | | | | | | | | singleton type. This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 TBR=satish@chromium.org Review URL: http://codereview.chromium.org/5721005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68936 0039d316-1c4b-4281-b951-d872f2087c98
* Make members of Singleton<T> private and only visible to the singleton type. ↵satish@chromium.org2010-12-112-1/+10
| | | | | | | | | | | | | | | This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68932 0039d316-1c4b-4281-b951-d872f2087c98
* views: Include base/win/scope_comptr.h instead of base/scoped_comptr_win.htfarina@chromium.org2010-12-106-15/+15
| | | | | | | | | | | Also add base::win:: to ScopedComPtr where necessary. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/5625006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68910 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new GetInstance() method for singleton classes, take 2.satish@chromium.org2010-12-082-3/+6
| | | | | | | | | | | | | | | | | | This is a small step towards making all singleton classes use the Singleton<T> pattern within their code and not expect the callers to know about it. This CL includes all files except those under chrome/browser, chrome/net, chrome/service and third_party/WebKit (these will be done in future CLs). Suggested files to focus for reviewers: - joi@ for files under src/ceee - tommi@ for files under src/chrome_frame - maruel@ for the rest of the files. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5581008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68577 0039d316-1c4b-4281-b951-d872f2087c98
* Fix static compile with touchui on chromeos.sadrul@chromium.org2010-12-061-0/+2
| | | | | | | | | BUG=static compile doesn't work with 'touchui=1 chromeos=1' TEST=static compile should work with 'touchui=1 chromeos=1' Review URL: http://codereview.chromium.org/5515007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68373 0039d316-1c4b-4281-b951-d872f2087c98
* A non-GTK version of menus for touchui.sadrul@chromium.org2010-12-0511-20/+296
| | | | | | | | | | | | For the menus to work correctly, the X messge pump also needs updating to allow nested event dispatching. BUG=None TEST=On a touchui build, non-GTK context menus in web-pages should work correctly. Review URL: http://codereview.chromium.org/5110011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68309 0039d316-1c4b-4281-b951-d872f2087c98
* Handle shift-selection in GroupTables.atwilson@chromium.org2010-12-033-21/+110
| | | | | | | | | | | | | | Change the shift-click support in TableView so shift-clicks that span multiple groups are prohibited. Clicking in one group, then shift-clicking in another group will cause the shift-click to be treated as a normal click (i.e. just select the item in the second group). BUG=63787 TEST=Open task manager, click on item in one group, shift click on item in another group. Review URL: http://codereview.chromium.org/5504001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68123 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 67662 - FBTF: Remove unneeded headers from base/ (part 10)thestig@chromium.org2010-11-302-3/+4
| | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5139006 TBR=thestig@chromium.org Review URL: http://codereview.chromium.org/5270010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67674 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 10)thestig@chromium.org2010-11-302-4/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5139006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67662 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup AdjustStringForLocaleDirection() to modify input parameter in place.jeremy@chromium.org2010-11-247-24/+11
| | | | | | | | | | | As described in the bug, the current behavior is confusing and bug-prone. BUG=47194 TEST=Check that there are no visible regressions in RTL and LTR language UIs on Linux & Windows. Review URL: http://codereview.chromium.org/5154009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67237 0039d316-1c4b-4281-b951-d872f2087c98
* Determine the theme for a widget in gtk from its parent,zork@chromium.org2010-11-245-14/+54
| | | | | | | | | | | instead of just using the defaul BUG=chromium-os:4890 TEST=On ChromeOS, enable a theme, and open the find box. Check that the theme is applied. Review URL: http://codereview.chromium.org/4705005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67210 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: Create touch-events.sadrul@chromium.org2010-11-235-6/+120
| | | | | | | | | | | | | | | | | | | | Create and process touch-events. The touch-events are created from pointer-events. The way to decide whether a 'pointer event' originated from a touch-device is not yet well-defined. So for now, use the --touch-devices command line parameter to specify which pointer devices should be treated as touch-device. For example, you can run: ./out/Debug/chrome --touch-devices=7,8 to treat the events coming in from devices with id 7 and 8 as touch events. (these are the slave ids you get from 'xinput list') BUG=None TEST=None Review URL: http://codereview.chromium.org/4738001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67133 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Use WideButton for all screens, increase textfield vmargin on login ↵nkostylev@chromium.org2010-11-231-0/+3
| | | | | | | | | | | screen. BUG=chromium-os:8101 TEST=Manual. Review URL: http://codereview.chromium.org/5338002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67123 0039d316-1c4b-4281-b951-d872f2087c98
* Change the name of the tests and examples projects to be more consistent.ben@chromium.org2010-11-231-2/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5341002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67119 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 66982 - [cros] Use WideButton on EULA, Sign In screens.nkostylev@chromium.org2010-11-231-3/+0
| | | | | | | | | | | | | | Adjust "sign in" button height. BUG=chromium-os:8101 TEST=Manual Review URL: http://codereview.chromium.org/5192005 TBR=nkostylev@chromium.org Review URL: http://codereview.chromium.org/5331001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67080 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring of cursor usage (primarily for linux).sadrul@chromium.org2010-11-235-11/+18
| | | | | | | | | | | | | | Add API to WebCursor to return a native-cursor, and implementation for windows, linux and mac. For linux: Move gtk_util::GetCursor into gfx:: namespace. Also, get rid of ref/unref'ing the cursors from everywhere. Instead, do almost all of it in one place (in gfx). Also, show proper cursors for web-pages with touchui=1 (i.e. add support for updating cursor in RenderWidgetHostViewViews). Review URL: http://codereview.chromium.org/5110010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67034 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Use WideButton on EULA, Sign In screens.nkostylev@chromium.org2010-11-221-0/+3
| | | | | | | | | | | Adjust "sign in" button height. BUG=chromium-os:8101 TEST=Manual Review URL: http://codereview.chromium.org/5192005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66982 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mouse-wheel scrolling and shifted/capslocked keyevents for touchui.sadrul@chromium.org2010-11-223-6/+26
| | | | | | | | | BUG=None TEST=Mouse wheel should work in a webpage, and shift+a should show up as 'A' in a textfield. Caps-lock should also work. Review URL: http://codereview.chromium.org/4341001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66977 0039d316-1c4b-4281-b951-d872f2087c98
* Convert SizeStringInt from taking a wstring to a string16.tony@chromium.org2010-11-223-5/+9
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/5158006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66973 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at:sky@chromium.org2010-11-2114-93/+84
| | | | | | | | | | | | | | | Converts usage of SetProp/GetProp to a map. Even after making sure we clean up props we still leak in a handful of cases that are causing test grief. By and large our usage of properties is for inside the application, so that a map works fine. BUG=61528 44991 TEST=none TBR=cpu@chromium.org Review URL: http://codereview.chromium.org/5144005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66920 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in focus that occurs if Focus ends up deleting/removingsky@chromium.org2010-11-191-1/+5
| | | | | | | | | | | the view. BUG=61963 TEST=see bug Review URL: http://codereview.chromium.org/5227003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66809 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-13 06:56:35 +0000