summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* [cros] Fix accelerator keys when using non-US/Latin keyboard layouts.suzhe@google.com2011-03-171-2/+2
| | | | | | | | | BUG=chromium-os:10120 TEST=Switch to Russian keyboard layout, try accelerators like ctrl-t, ctrl-w, etc. Review URL: http://codereview.chromium.org/6674052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78565 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug with drop arrow updating on the tabstrip. See comment in widget_win.ccben@chromium.org2011-03-172-3/+16
| | | | | | | | | http://crbug.com/74764 TEST=none Review URL: http://codereview.chromium.org/6665050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78545 0039d316-1c4b-4281-b951-d872f2087c98
* Force an expose event from the "show" callback.sadrul@chromium.org2011-03-171-0/+6
| | | | | | | | | | | | This fixes the delayed display of menus, where the menu (wrench menu, context menus) shows up some time (sometimes 10+ seconds) after clicking. BUG=76085 TEST=none Review URL: http://codereview.chromium.org/6665030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78481 0039d316-1c4b-4281-b951-d872f2087c98
* Add an exception wrapper to the WindowProc functions sorvargas@google.com2011-03-171-2/+3
| | | | | | | | | | | that we receive crash reports when something goes wrong. BUG=63702 TEST=base_unittests Review URL: http://codereview.chromium.org/6697004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78475 0039d316-1c4b-4281-b951-d872f2087c98
* Moving over to other folder button while opening folder menu should open the ↵oshima@google.com2011-03-164-24/+48
| | | | | | | | | | | | | | | folder menu. It was failing with DCHECK instead. This CL fix this issue by Canceling menu only when the menu has x grab. I also separated grk grab broke and X grab broke because gtk broke require releasing x grab for this case. BUG=chromium-os:13151 TEST=see bug description. Review URL: http://codereview.chromium.org/6676032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78447 0039d316-1c4b-4281-b951-d872f2087c98
* Fix window activation when closing a modal dialog box. It turns out ↵ben@chromium.org2011-03-162-12/+21
| | | | | | | | | | | | GetForegroundWindow() returns a different value when it's called from WM_DESTROY vs. WM_CLOSE. We need to do activation restoration earlier than WM_DESTROY. http://crbug.com/75610 TEST=see bug TBR=sky Review URL: http://codereview.chromium.org/6670054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78420 0039d316-1c4b-4281-b951-d872f2087c98
* Reorder some views::View overrides & other functions.msw@chromium.org2011-03-1616-517/+487
| | | | | | | | | | | | | Follow base class ordering and access specifiers. Add OVERRIDE keyword where applicable. Define BaseTab::set_animation_container out of line, update includes. Limit RenderWidgetHostViewViews::OnTouchEvent to TOUCH_UI. Make RenderWidgetHostViewViews::GetCursorForPoint a virtual override. Review URL: http://codereview.chromium.org/6673070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78416 0039d316-1c4b-4281-b951-d872f2087c98
* Re-lands:ben@chromium.org2011-03-169-85/+82
| | | | | | | | | | | | Add native capture API to Widget, and fix a bug in Window where we wouldn't let the window be closed from the X. BUG=72040 TEST=none R=sky Review URL: http://codereview.chromium.org/6670049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78394 0039d316-1c4b-4281-b951-d872f2087c98
* Fix closing the window by clicking the X.ben@chromium.org2011-03-161-11/+1
| | | | | | | | | | | I'm splitting this change out from my earlier CL because it's a more serious regression and I am still solving the capture issues separately. http://crbug.com/76144 TEST=see bug TBR=sky Review URL: http://codereview.chromium.org/6677081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78387 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bad memory access in MenuHostGtk::HandleGrabBroke when the menu isdmazzoni@chromium.org2011-03-151-4/+6
| | | | | | | | | | | | being destroyed. BUG=76023 TEST=Re-enables interactive_ui_test that was failing. Review URL: http://codereview.chromium.org/6686047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78293 0039d316-1c4b-4281-b951-d872f2087c98
* Replace views::TextRange with ui::Range.suzhe@google.com2011-03-1514-125/+61
| | | | | | | | | BUG=none TEST=original unittests. Review URL: http://codereview.chromium.org/6695021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78280 0039d316-1c4b-4281-b951-d872f2087c98
* Add a TODO, remove NOTIMPLEMENTED to quiet things down.sadrul@chromium.org2011-03-151-1/+1
| | | | | | TBR=ben@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78251 0039d316-1c4b-4281-b951-d872f2087c98
* Have a helper class to automatically save and restore the canvas ↵sadrul@chromium.org2011-03-151-18/+41
| | | | | | | | | | | transformation state. BUG= TEST= Review URL: http://codereview.chromium.org/6677035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78250 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 78222 - Add native capture API to Widget, and fix a bug in Window ↵ben@chromium.org2011-03-159-82/+95
| | | | | | | | | | | | | | | where we wouldn't let the window be closed from the X. BUG=72040 TEST=none TBR=sky Review URL: http://codereview.chromium.org/6697016 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/6695028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78241 0039d316-1c4b-4281-b951-d872f2087c98
* Add native capture API to Widget, and fix a bug in Window where we wouldn't ↵ben@chromium.org2011-03-159-95/+82
| | | | | | | | | | | | let the window be closed from the X. BUG=72040 TEST=none TBR=sky Review URL: http://codereview.chromium.org/6697016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78222 0039d316-1c4b-4281-b951-d872f2087c98
* fav icon -> favicon. Pass 3: kFavIconSize -> kFaviconSizeavi@chromium.org2011-03-153-4/+4
| | | | | | | | | BUG=76073 TEST=none; no visible change Review URL: http://codereview.chromium.org/6681041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78209 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang build, failure caused by r78149.sadrul@chromium.org2011-03-155-5/+5
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/6697013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78154 0039d316-1c4b-4281-b951-d872f2087c98
* Start working on compositor tree painting.sadrul@chromium.org2011-03-1511-31/+180
| | | | | | | | | | | | | As a first step, maintain a skia canvas in each transformed view. Each transformed view will acquire a texture-id for the canvas it owns. Whenever the canvas is updated, it will trigger a refresh in the compositor tree. BUG=none TEST=none Review URL: http://codereview.chromium.org/6594125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78149 0039d316-1c4b-4281-b951-d872f2087c98
* These files missed the last checkinben@chromium.org2011-03-152-9/+9
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78131 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 78062 with some NULL checks.ben@chromium.org2011-03-1410-29/+89
| | | | | | | | | Revert 78062 - Migrate more of BrowserFrame's event handling down into WindowWin/WidgetWin and their delegate interfaces. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6683007 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/6686059 Review URL: http://codereview.chromium.org/6677029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78129 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up some event code:msw@chromium.org2011-03-1425-299/+284
| | | | | | | | | | | Update some RootView event construction. Fixup some *MouseExited/OnLeaveNotify codepaths. Normalize event argument names. Move View::ConvertPoint*Ancestor defs to private section. Review URL: http://codereview.chromium.org/6685018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78121 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 78062 - Migrate more of BrowserFrame's event handling down into ↵ben@chromium.org2011-03-1412-93/+38
| | | | | | | | | | | | | | WindowWin/WidgetWin and their delegate interfaces. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6683007 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/6686059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78093 0039d316-1c4b-4281-b951-d872f2087c98
* Tuned the MouseRelease handler in the Dropdown Button to not un-depress the ↵stevet@google.com2011-03-142-21/+127
| | | | | | | | | | | button when the menu opens (in particular for when the menu is opened by dragging down). Ensured that the button is undepressed every time the menu is closed. Added a couple unit tests to verify this behaviour. Fixed a typo in a test helper. BUG=49240 TEST=Navigate to a couple different web pages so the Back button is enabled. Click on the Back button and immediately drag down. Ensure that when the context menu is show, the back button remains depressed. Ensure that dismissing the context menu always un-depresses the button. Ensure that normal clicking on the buttons still work (navigates forwards or backwards in history). Review URL: http://codereview.chromium.org/6530005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78064 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate more of BrowserFrame's event handling down into WindowWin/WidgetWin ↵ben@chromium.org2011-03-1412-38/+93
| | | | | | | | | | | and their delegate interfaces. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6683007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78062 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang build (tested on trybots this time!).dmazzoni@chromium.org2011-03-146-8/+11
| | | | | | | | | | | | | | | | | | | | | Move AccessibleViewState constructor into a .cc file. Add dependency on ui/base to views_unittests so that it actually compiles source files in ui/base. Rename WindowDelegate::GetAccessibleState to WindowDelegate::GetAccessibleWindowState so that it doesn't conflict with View::GetAccessibleState in BrowserView, which inherits from both. This was a real bug, introduced recently because both GetAccessibleState methods were renamed from previous non-conflicting method names. BUG=none TEST=none Review URL: http://codereview.chromium.org/6691009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78052 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Fix touch events bubbling up the hierarchy.sadrul@chromium.org2011-03-142-15/+34
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6690003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78045 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 78040 - Fix clang build. (Made things worse...)dmazzoni@chromium.org2011-03-145-10/+8
| | | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6685053 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/6686048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78041 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang build.dmazzoni@chromium.org2011-03-145-8/+10
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6685053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78040 0039d316-1c4b-4281-b951-d872f2087c98
* Remove NativeViewAccessibilityWin from the views namespace becausedmazzoni@chromium.org2011-03-143-12/+10
| | | | | | | | | | | VS2005 doesn't allow an ATL::CComObject symbol in a namespace. BUG=none TEST=build on VS2005, VS2008 Review URL: http://codereview.chromium.org/6685049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78038 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land: Refactor Views accessibility.dmazzoni@chromium.org2011-03-1484-646/+606
| | | | | | | | | BUG=74988 TEST=none Review URL: http://codereview.chromium.org/6581010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78006 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid dangling references to Views from FocusManager.asanka@chromium.org2011-03-125-14/+32
| | | | | | | | | | | | | When handling a native view hierarchy change, make sure any Views that are going to become disassociated from the FocusManager are removed from focus. BUG=75172 TEST=none Review URL: http://codereview.chromium.org/6670010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77918 0039d316-1c4b-4281-b951-d872f2087c98
* Show details about allowed and blocked cookies in a tabbed pane. Also reworksrogerta@chromium.org2011-03-112-25/+83
| | | | | | | | | | | | | | | | the UI to show allowed and blocked cookies in differnt tabs. This implement only addresses the windows build. BUG=63650 TEST=Block all cookies, and visit a site that uses cookies. Click on the broken cookie icon that appears in the URL bar, and then click to see the cookies for this page. The UI now shows the allowed and blocked cookies in separate tabs, with an area below showing information about specific cookies selected in the tree control. Review URL: http://codereview.chromium.org/6639013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77851 0039d316-1c4b-4281-b951-d872f2087c98
* Add Activation support to WindowDelegate.ben@chromium.org2011-03-119-5/+37
| | | | | | | | | | | | | WindowDelegate now sports two additional methods: CanActivate() and OnWindowActivated(). Converts BrowserView to implement these methods instead of requiring BrowserFrame to override WindowWin methods to handle activation events. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6679002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77848 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: Make BrowserFrame concrete, create NativeBrowserFrame and ↵ben@chromium.org2011-03-113-0/+16
| | | | | | | | | | | NativeBrowserFrameDelegate. BUG=72040 TEST=none TBR=sky git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77789 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 77773 and 77774.ben@chromium.org2011-03-113-16/+0
| | | | | | | | BUG=none TBR=sky git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77776 0039d316-1c4b-4281-b951-d872f2087c98
* Make BrowserFrame concrete, create NativeBrowserFrame and ↵ben@chromium.org2011-03-113-0/+16
| | | | | | | | | | | | NativeBrowserFrameDelegate. BUG=72040 TEST=none TBR=sky Review URL: http://codereview.chromium.org/6677003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77773 0039d316-1c4b-4281-b951-d872f2087c98
* Remove broken (and previously unused) OnMouseLeave overrides.msw@chromium.org2011-03-102-31/+0
| | | | | | | | | | | | | Both WindowWin and TabContentsViewWin had incorrect signatures to override WidgetWin::OnMouseLeave. crrev.com/77221 mistakenly 'fixed' WindowWin::OnMouseLeave to actually override that of WidgetWin. In this CL, remove the broken and previously unused overrides; add OVERRIDE keywords liberally. BUG=75334,75367 TEST=repro and similar mouse interaction. Review URL: http://codereview.chromium.org/6646053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77716 0039d316-1c4b-4281-b951-d872f2087c98
* Build out NativeWindow interface for Window method pass-thrus.ben@chromium.org2011-03-1014-431/+456
| | | | | | | | | | BUG=72040 TEST=none TBR=sky Review URL: http://codereview.chromium.org/6659035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77671 0039d316-1c4b-4281-b951-d872f2087c98
* Fix final nits on linux_viewserg@google.com2011-03-107-39/+88
| | | | | | | | | BUG=carnitas TEST=compiles Review URL: http://codereview.chromium.org/6612047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77584 0039d316-1c4b-4281-b951-d872f2087c98
* views: Moves TextfieldController/TextRange into their own headers.tfarina@chromium.org2011-03-1015-121/+153
| | | | | | | | | BUG=None TEST=existing unit_tests Review URL: http://codereview.chromium.org/6628037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77571 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate more into Window.ben@chromium.org2011-03-098-212/+252
| | | | | | | | | | | - various window attributes BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6661003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77538 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate more into Window:ben@chromium.org2011-03-0916-108/+120
| | | | | | | | | | | | - inactive rendering disabling tracking - window icon updating BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6650031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77497 0039d316-1c4b-4281-b951-d872f2087c98
* Add check for window on view in MouseObserverdavemoore@chromium.org2011-03-091-1/+5
| | | | | | | | | BUG=chromium-os:12119 TEST=None Review URL: http://codereview.chromium.org/6612039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77492 0039d316-1c4b-4281-b951-d872f2087c98
* This will help minimize the area we paint various views, including ↵davemoore@chromium.org2011-03-0919-129/+175
| | | | | | | | | | | | | | | | | BrowserView in cros. Before the default when a child's preferred view size changed was to propagate it up and paint everything from the rootview down. This will limit the area to the parts that actually changed size. I expect we may find things that aren't being painted because they were assuming the behavior of Layout(). We should fix this as necessary. Also, a subsequent change will minimize our calls to SchedulePaint(). We frequently do it when we don't need to. BUG=None TEST=ViewTest.SetBoundsPaint Review URL: http://codereview.chromium.org/6531032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77481 0039d316-1c4b-4281-b951-d872f2087c98
* Fix obsolete dependencies that create needless recompiling. jeanluc@chromium.org2011-03-091-1/+0
| | | | | | | | BUG=71130 Review URL: http://codereview.chromium.org/6529025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77462 0039d316-1c4b-4281-b951-d872f2087c98
* Update OnMouseActivate override signatures.msw@chromium.org2011-03-096-26/+38
| | | | | | | | | | | | Add OVERRIDE keyword liberally to some relevant overrides. Fix copyright dates. BUG=75366 TEST=Omnibox clicking, etc. Review URL: http://codereview.chromium.org/6648018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77431 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang build by renaming method ShowWindow()ben@chromium.org2011-03-096-7/+8
| | | | | | | | | BUG=72040 TEST=none TBR=thakis Review URL: http://codereview.chromium.org/6652016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77424 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate window showing into Window base class.ben@chromium.org2011-03-0914-305/+326
| | | | | | | | | | | NativeWindow gets methods to update accessible state, title, Center and Show. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6647004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77421 0039d316-1c4b-4281-b951-d872f2087c98
* Fix last_mouse_move_*_ check, doh!msw@chromium.org2011-03-091-1/+1
| | | | | | | | | BUG=75367 TEST=Hover mouse on/off bookmarks for glow toggle, etc. Review URL: http://codereview.chromium.org/6649014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77418 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed spelling and typos.wyck@chromium.org2011-03-091-3/+3
| | | | | | | | | | | Only comments were changed. No code was harmed in the making of this CL. BUG=None TEST=None Review URL: http://codereview.chromium.org/6625015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77410 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 16:55:13 +0000