summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Another take on menu's. This uses the hosting menu scroll view container as ↵dtseng@chromium.org2010-08-195-4/+22
| | | | | | | | | | | | | | | | | a menubar on which we can fire MENUSTART and MENUEND events. The end result is that we now have the following scenario when a user opens a menu. 1. focus lands on the menu button. 2. down arrow. 3. A "chromium" menu item appears. 4. down arrow (or enter). 5. The first menu item gets focused. The only differences from what we currently have is Jaws/NVDA no longer say "context menu opened" or "applications". The first real menuitem also doesn't get focused when the menu shows. BUG=none. TEST=use NVDA and Jaws to navigate the menu's (opening, closing, submenus, accelerators). Review URL: http://codereview.chromium.org/3155029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56715 0039d316-1c4b-4281-b951-d872f2087c98
* Convert FillRect(... SkPaint) to DrawRect() since it doesn't necessarily ↵pkasting@chromium.org2010-08-181-1/+1
| | | | | | | | | | fill, it just draws with the provided paint. BUG=none TEST=none Review URL: http://codereview.chromium.org/3165032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56589 0039d316-1c4b-4281-b951-d872f2087c98
* Convert GetDisplayStringInLTRDirectionality from wstring to string16.tony@chromium.org2010-08-181-1/+2
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/3108027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56535 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors mouse watching out of TabStrip into a standalone class.sky@chromium.org2010-08-173-0/+230
| | | | | | | | | BUG=27797 TEST=none Review URL: http://codereview.chromium.org/3140008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56424 0039d316-1c4b-4281-b951-d872f2087c98
* Status menu change per chromium-os:5517xiyuan@chromium.org2010-08-172-2/+19
| | | | | | | | | | | | | | | | | | | | - Apply 10% white to selected menu button; - Remove the menu offset so that the menu is top aligned with toolbar; - Make all status area buttons derive from StatusAreaButton; - Move ClockMenuButton's text size logic into StatusAreaButton to share the logic with LanguageMenuButton; - Strip unused space from LanguageMenuButton so that it looks good with 10% white highlight; - Make LanguageMenuButton and ClockMenuButton center aligned; - Add 1-pixel padding at top when the vertical space is odd number so that text looks properly aligned with the icons; BUG=chromium-os:5517 TEST=Verify fix for chromium-os:5517. Review URL: http://codereview.chromium.org/3141019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56369 0039d316-1c4b-4281-b951-d872f2087c98
* Misc. cleanup: simplify some code, add a few commentspkasting@chromium.org2010-08-131-9/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3143016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56106 0039d316-1c4b-4281-b951-d872f2087c98
* Rework gfx::Font by moving platform-specific code into inner classes.ben@chromium.org2010-08-1328-65/+74
| | | | | | | | | | | | | gfx::Font is a platform-neutral API shim that exists as a wrapper object to allow for the creation and lifetime of gfx::Font objects to remain consistent with past usage. gfx::PlatformFont is an interface implemented by the platform-specific inner classes (gfx::PlatformFontWin,Mac,Gtk). BUG=none TEST=existing unittests Review URL: http://codereview.chromium.org/3083022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56040 0039d316-1c4b-4281-b951-d872f2087c98
* Implement BrowserWindow deactivate on Linux (views and GTK).jcivelli@chromium.org2010-08-121-1/+1
| | | | | | | | | | | This is needed for pages to be able to deactivate the browser's or popup windows with window.blur(). BUG=51364 TEST=Open a page that calls window.blur(), it should move the browser window to the back of the Z order. Review URL: http://codereview.chromium.org/3159007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55907 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/3167002 for rjkroege:sky@chromium.org2010-08-112-0/+85
| | | | | | | | | | | Adds a TouchEvent class for views. BUG= TEST=compiled with and without touchui Review URL: http://codereview.chromium.org/3117010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55776 0039d316-1c4b-4281-b951-d872f2087c98
* Land 55232 again - Dispatch key event to bindings processing.xiyuan@chromium.org2010-08-111-0/+4
| | | | | | | | | | | | | This reverts http://src.chromium.org/viewvc/chrome?view=rev&revision=55284 BUG=chromium-os:4005 TEST=Default button of hosted native dialogs in ChromeOS should work. TBR=suzhe@chromium.org Review URL: http://codereview.chromium.org/2873109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55753 0039d316-1c4b-4281-b951-d872f2087c98
* Making window.focus() work in Chrome.jcivelli@chromium.org2010-08-115-2/+18
| | | | | | | | | | | | | | | | A patch on the WebKit side https://bugs.webkit.org/show_bug.cgi?id=43542 ensures we get the correct notification when window.focus()/blur() is called. This CL makes the browser active/unactive in response to the focus/blur message. BUG=29643 TEST=Visit gmail. Open an IM conversation window and pop-it out. Focus the browser (so the IM window is in the back). Click on the person name in the IM section of gmail. The conversation window should be brought back to the front. Repeat but this time minimize the conversation window. Review URL: http://codereview.chromium.org/3060045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55678 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Get rid of TreeNodeChildrenReordered.tfarina@chromium.org2010-08-112-41/+3
| | | | | | | | | | | | Reason: This function was never implemented by TreeNodeModel and is unlike it will be. Also it proved to not be necessary at all. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3091016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55657 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize most_recent_profile_ in constructor.ctguil@chromium.org2010-08-101-1/+1
| | | | | | | | | BUG=51631 TEST=Ensure chrome --first-run don't crash when opening the wrench menu. Review URL: http://codereview.chromium.org/3139002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55606 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 5)thestig@chromium.org2010-08-071-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3041049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55349 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 55232 - Dispatch key event to bindings processing.nsylvain@chromium.org2010-08-061-4/+0
| | | | | | | | | | | | | | This properly activates the default widget on a GtkWindow. BUG=chromium-os:4005 TEST=Default button of hosted native dialogs in ChromeOS should work. Review URL: http://codereview.chromium.org/3087011 TBR=xiyuan@chromium.org Review URL: http://codereview.chromium.org/3038053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55284 0039d316-1c4b-4281-b951-d872f2087c98
* Dispatch key event to bindings processing.xiyuan@chromium.org2010-08-061-0/+4
| | | | | | | | | | | This properly activates the default widget on a GtkWindow. BUG=chromium-os:4005 TEST=Default button of hosted native dialogs in ChromeOS should work. Review URL: http://codereview.chromium.org/3087011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55232 0039d316-1c4b-4281-b951-d872f2087c98
* Improvements to accessibility extension api support for "views":dmazzoni@chromium.org2010-08-067-20/+20
| | | | | | | | | | | | | 1. Handles the new wrench menu. 2. Uses NotifyAccessibilityEvent to find out when focus changes, rather than installing focus change listeners that need to be cleaned up. BUG=none TEST=Updated AccessibilityEventRouterViewsTest.TestFocusNotification Review URL: http://codereview.chromium.org/3056045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55196 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 3)thestig@chromium.org2010-08-061-2/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3037044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55192 0039d316-1c4b-4281-b951-d872f2087c98
* Enable better NVDA support for custom menus.ctguil@chromium.org2010-08-066-11/+29
| | | | | | | | | | | | - Send the popupmenu events on the MenuScrollViewContainer since it is the View with the ROLE_MENUPOPUP role. - Return AccessibilityTypes::STATE_FOCUSED for MenuScrollViewContainer since it's not focused by MenuHostWin::ShowMenuHost. NVDA won't process children menu item's focus events unless a parent claims to have focus. TEST=The wrench menu and it's menu items are read aloud when using NVDA. BUG=49360 Review URL: http://codereview.chromium.org/3015055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55163 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 1)thestig@chromium.org2010-08-051-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3071012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55034 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux views]Fix the return value of WidgetGtk::HandleKeyboardEvent().suzhe@chromium.org2010-08-051-1/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3063025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55028 0039d316-1c4b-4281-b951-d872f2087c98
* Add view class names to some classes used in the Wrench menu.dmazzoni@chromium.org2010-08-046-0/+45
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2832106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54960 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux Views] Refactor accelerator handler related code.suzhe@chromium.org2010-08-048-141/+105
| | | | | | | | | | | | | | | | | This CL removes the accelerator handling logic in accelerator_handler_gtk.cc and implements a much simpler solution in WidgetGtk. The new approach always sends a key event to the focused View and native GtkWidget first and only sends it to the focus manager if it's not handled by any View or native GtkWidget. BUG=23383 AcceleratorHandler on Windows should not dispatch the KEYUP messages eaten by the FocusManager BUG=40966 BrowserKeyEventsTest.AccessKeys is crashy BUG=49701 [Linux Views]Some Emacs keybindings are broken in omnibox and find in page box. TEST=Press Alt key in different place (web page, omnibox, find bar, etc.) to see if menu bar can be focused correctly. Press alt-F to popup wrench menu and Escape to close it, then try alt key again. Review URL: http://codereview.chromium.org/3046041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54947 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a deprecated wstring ToLower function.tony@chromium.org2010-08-042-3/+6
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/3044043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54946 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstrings from l10n_util/ResourceBundle locale functions.evan@chromium.org2010-08-042-3/+3
| | | | | | Review URL: http://codereview.chromium.org/3069026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54917 0039d316-1c4b-4281-b951-d872f2087c98
* Makes cut/copy/paste buttons centered with respect to thesky@chromium.org2010-08-032-7/+11
| | | | | | | | | | | | | separator. This proves a bit tricky as normally separators are closer to the bottom of the space provided. I've centered them now so that the buttons look centered too. BUG=50099 TEST=see bug Review URL: http://codereview.chromium.org/3072015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54772 0039d316-1c4b-4281-b951-d872f2087c98
* Add #include utf_string_conversions.h to all files that use ASCIIToWide andbrettw@chromium.org2010-08-031-0/+1
| | | | | | | | | | | | | | | ASCIIToUTF16. I removed string_util includes from a few places where it obviously wasn't needed. In a separate pass, I'm going to remove ASCIITo* from string_util, then I'm going to do an even later pass to find the unnecessary string_util.h includes and remove them. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3058027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54746 0039d316-1c4b-4281-b951-d872f2087c98
* Add undeclared virtual destructors part 5ziadh@chromium.org2010-08-022-0/+12
| | | | | | | | | | | | | | | Preventative maintenance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. These files were discovered using the -Wnon-virtual-dtor flag in g++. r=jar BUG=47469 Review URL: http://codereview.chromium.org/3080013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54540 0039d316-1c4b-4281-b951-d872f2087c98
* Convert more callers of the integer/string functions to usingbrettw@chromium.org2010-07-312-4/+5
| | | | | | | | | | string_number_conversions.h TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3013046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54454 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/ (part 2)thestig@chromium.org2010-07-3118-26/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3066014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54437 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r54074.dtseng@chromium.org2010-07-306-11/+50
| | | | | | Review URL: http://codereview.chromium.org/3010040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54334 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to reland code reverted in r52599, to take another look at the page ↵pkasting@chromium.org2010-07-301-2/+4
| | | | | | | | | | | cycler data. There was a lot of noise in the previous data, and since the current page cycler t and t_ref times are close, I'm hoping to see something more conclusive. TBR=jar BUG=47227 TEST=none Review URL: http://codereview.chromium.org/3026032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54236 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54074 - Add initial tests for keyboard access (tabbing in some dialogs).rohitrao@chromium.org2010-07-296-50/+11
| | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3015026 TBR=dtseng@chromium.org Review URL: http://codereview.chromium.org/3046031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54093 0039d316-1c4b-4281-b951-d872f2087c98
* Add initial tests for keyboard access (tabbing in some dialogs).dtseng@chromium.org2010-07-286-11/+50
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3015026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54074 0039d316-1c4b-4281-b951-d872f2087c98
* views: Fix bad license headers found in some filestfarina@chromium.org2010-07-2814-57/+51
| | | | | | | | | BUG=50266 TEST=None Review URL: http://codereview.chromium.org/3017036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53974 0039d316-1c4b-4281-b951-d872f2087c98
* base/ header cleanup. Forward declaration instead of including.erg@google.com2010-07-281-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3068004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53969 0039d316-1c4b-4281-b951-d872f2087c98
* Set the initial focus when the task manager first activates and shows. ↵dtseng@chromium.org2010-07-281-0/+1
| | | | | | | | | | Also, send our custom accessibility events in NativeControl's Focus() method. BUG=50401 TEST=interactive UI tests BrowserKeyboardAccessibility.TabInTaskManager Review URL: http://codereview.chromium.org/3038031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53959 0039d316-1c4b-4281-b951-d872f2087c98
* Add "pushed" as a state a TextButton can show (alongside "normal" and "hover").pkasting@chromium.org2010-07-272-22/+34
| | | | | | | | BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3058011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53847 0039d316-1c4b-4281-b951-d872f2087c98
* Add undeclared virtual destructors part 2ziadh@chromium.org2010-07-278-0/+23
| | | | | | | | | | | | | Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. r=jar BUG=47469 Review URL: http://codereview.chromium.org/3032024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53831 0039d316-1c4b-4281-b951-d872f2087c98
* Fix code path in TabbedPane::RemoveTabAtIndex()mnissler@chromium.org2010-07-271-1/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3044022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53781 0039d316-1c4b-4281-b951-d872f2087c98
* Make theme change notifications auto-propagate through the view hierarchy, ↵pkasting@chromium.org2010-07-275-21/+25
| | | | | | | | | | | | instead of forcing subclasses to manually call their superclass implementation. This fixes some problems where not all views would get notified of a theme change. Make naming for theme and locale changes consistent and clear. BUG=50107 TEST=none Review URL: http://codereview.chromium.org/2878055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53736 0039d316-1c4b-4281-b951-d872f2087c98
* Make the resize gripper invisible.pkasting@chromium.org2010-07-274-145/+100
| | | | | | | | BUG=50107 TEST=Resize gripper nest to browser actions container should no longer appear Review URL: http://codereview.chromium.org/3052011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53732 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-26154-0/+154
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression that stopped properly restoring focus to tab contents.dmazzoni@chromium.org2010-07-231-3/+16
| | | | | | | | | | | | | | | | | | | | The bug in r51262 was that native_tab_contents_container_win overrides RequestFocus, so it can't be *reliably* focused just using SetFocus. This is a simple, straightforward fix that should be merged for M6. Afterwards, I think a better solution for the dev channel would be to get rid of the hacky RequestFocus overrides and add a View::HasNativeFocus method so that FocusManager can tell when it thinks a view already has focus, but the native focus might need to be set again. Thoughts? BUG=48917 BUG=49061 TEST=none Review URL: http://codereview.chromium.org/3013023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53471 0039d316-1c4b-4281-b951-d872f2087c98
* Implement initial ClipRect.ben@chromium.org2010-07-211-20/+6
| | | | | | | | | | | Move IntersectsClipRectInt and GetClipRect functions to CanvasSkia private, since they are only used internally. BUG=none TEST=see unittest. Review URL: http://codereview.chromium.org/2959014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53218 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in links ending up too small. The problem is that wesky@chromium.org2010-07-218-39/+44
| | | | | | | | | | | | | | | | | | | | changed IsFocusable to check IsVisibleInRootView. This meant that any views (like label) whose preferred size takes into account focusable and cached the preferred size before they were visible in the root view would end up with the wrong size because they didn't recalculate when IsVisibleInRootView changed. I've separated out the two states so that IsFocusable no longer checks IsVisibleInRootView and is protected. All consumers now call IsFocusableInRootView which checks IsFocusable and IsVisibleInRootView. BUG=49635 TEST=see bug. Review URL: http://codereview.chromium.org/3046008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53187 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux Views]Handle focus traversing correctly.suzhe@chromium.org2010-07-205-3/+98
| | | | | | | | | | | | This CL adds a wrapper window class on top of GtkWindow to intercept its move_focus method, so that we can handle focus traversing by ourselves. BUG=49204: Chrome/views toolbar "tab" accessibility broken. TEST=See bug report. Review URL: http://codereview.chromium.org/3013006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53123 0039d316-1c4b-4281-b951-d872f2087c98
* Use the WS_EX_NOACTIVATE flag for popup widgets. This is essentially a ↵johnnyg@chromium.org2010-07-201-1/+1
| | | | | | | | | | | no-op for the views which are contained within Chrome, but for desktop notifications which are shown when other applications are active, this prevents clicking the notification from changing the active window. BUG=47334 TEST=focus another application, close a notification. look for no flicker. Review URL: http://codereview.chromium.org/3029010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53050 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in views/gtk when pressing space bar on a menu button.sky@chromium.org2010-07-181-0/+6
| | | | | | | | | BUG=49366 TEST=see bug Review URL: http://codereview.chromium.org/3046002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52874 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure to only handle real visiblity changes in NativeViewHost.mnissler@chromium.org2010-07-161-3/+7
| | | | | | | | | BUG=49100 TEST=Open options dialog -> Personal Stuff. Turn on sync, turn off sync, switch to advanced page. Browser shouldn't crash. Review URL: http://codereview.chromium.org/2868048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52629 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 14:49:04 +0000