summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Use text input type to control visibility of virtual keyboardpenghuang@chromium.org2011-08-241-1/+2
| | | | | | | | | | BUG=None TEST=On linux desktop Review URL: http://codereview.chromium.org/7553016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97998 0039d316-1c4b-4281-b951-d872f2087c98
* Reapplies code that fixed 90860 without debugging code. This is thesky@chromium.org2011-08-241-0/+8
| | | | | | | | | | | | | | | | same as you reviewed at http://codereview.chromium.org/7631048 minus debugging code. As mentioned in revert cl I'm going this route so that I can get a clean cl to apply to the 14 branch. As this is the same as the last patch I'm TBRing. BUG=90860 TEST=none TBR=ben@chromium.org R=ben@chromium.org Review URL: http://codereview.chromium.org/7719021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97975 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts debugging code added for 90860. The change to MenuItemViewsky@chromium.org2011-08-244-17/+2
| | | | | | | | | | | | | | | | | | seems to have fixed the bug. I'm not quite sure why, but I'll track it down separately. For now I'm going to revert the patch you last reviewed, then land the change the fixes the bug separately so that it can merge over cleanly. I'm TBRing since this is just a revert. BUG=90860 TEST=none R=ben@chromium.org TBR=ben@chromium.org Review URL: http://codereview.chromium.org/7718007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97972 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Switch to using .pak files for locale data on Windows." (r97941)mattm@chromium.org2011-08-241-1/+1
| | | | | | | | | | | Revert "Fix a bug where windows can't find the locale paks." (r97951) Revert "Fix the windows build." (r97954) TBR=tony@chromium.org Review URL: http://codereview.chromium.org/7717017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97968 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using .pak files for locale data on Windows.tony@chromium.org2011-08-231-1/+1
| | | | | | | | | | | | | | | We were using .dlls, but the .pak files are smaller and this will allow us to share more code across platforms. - Remove app/locales.gyp (used on win to generate the locale dlls) and references to it in other gyp(i) files. - Update various packaging scripts. - Move functions from resource_bundle_posix.cc to resource_bundle.cc (LoadResourcesDataPak, UnloadLocaleResources, GetLocalizedString, LoadLocaleResources) and delete the corresponding functions from resource_bundle_win.cc. BUG=92724 Review URL: http://codereview.chromium.org/7677004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97941 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "This is a redo of http://codereview.chromium.org/7629009/"saintlou@chromium.org2011-08-234-637/+0
| | | | | | | | | | | | This reverts commit 59e1c15b1ee0e29742a2479527de09715a2e5525. TBR=saintlou@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/7720010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97914 0039d316-1c4b-4281-b951-d872f2087c98
* This is a redo of http://codereview.chromium.org/7629009/saintlou@chromium.org2011-08-234-0/+637
| | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/7719001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97906 0039d316-1c4b-4281-b951-d872f2087c98
* views: Propagate visibility-notification down the view hierarchy when the ↵sadrul@chromium.org2011-08-231-0/+1
| | | | | | | | | | | widget visibility changes. BUG=none TEST=none Review URL: http://codereview.chromium.org/7706023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97878 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r97856 "move bubble border code and update references to it."maruel@chromium.org2011-08-233-635/+0
| | | | | | | | | | TBR=saintlou@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7685057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97857 0039d316-1c4b-4281-b951-d872f2087c98
* move bubble border code and update references to it.saintlou@chromium.org2011-08-233-0/+635
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/7629009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97856 0039d316-1c4b-4281-b951-d872f2087c98
* Move input_method to widgetoshima@google.com2011-08-2324-233/+359
| | | | | | | | | BUG=none TEST=none. no new functionality. all tests should pass. Review URL: http://codereview.chromium.org/7371007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97819 0039d316-1c4b-4281-b951-d872f2087c98
* Minor fix to touch selection logic.varunjain@chromium.org2011-08-232-14/+6
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7696013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97810 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts debugging code added @ 97412 as it uncovered reason for crash.sky@chromium.org2011-08-221-9/+1
| | | | | | | | | | | R=ben@chromium.org TBR=ben@chromium.org BUG=89439 TEST=none Review URL: http://codereview.chromium.org/7710003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97777 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression (and crash) in instant. The crash would happen ifsky@chromium.org2011-08-222-1/+10
| | | | | | | | | | | | | | | instant is enabled, you go to a page with an auth dialog, then click on one of the login buttons. This previously worked because focus was going to either the widget for the TabContentsView or RWHV (not sure which). Now that focus always goes to the topmost widget, it broke. BUG=89439 TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/7706003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97734 0039d316-1c4b-4281-b951-d872f2087c98
* Converts a DCHECK into a CHECK in hopes of tracking why the menu codesky@chromium.org2011-08-191-1/+2
| | | | | | | | | | | | thinks the current menu is NULL. BUG=93471 TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/7686001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97521 0039d316-1c4b-4281-b951-d872f2087c98
* Fix shlib build breakageoshima@google.com2011-08-191-1/+2
| | | | | | | | | | TBR=motownavi@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/7694009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97493 0039d316-1c4b-4281-b951-d872f2087c98
* Simple WindowManager that can move/resize window.oshima@google.com2011-08-1920-79/+540
| | | | | | | | | | | | | | Fixes TouchFrame's NonClientHitTest to ignore VirtualKeyboard area. Move mouse capture logic to Window Manager so that nested mouse capture with nested NWVs works correctly. Note1: This is a tentative WM that allows us to move/resize window in views desktop until we have real window manager based on aura/layer API. Note2: There is an compositor related issue and doesn't work well when compositor is enabled. I'll look into it after this CL. Review URL: http://codereview.chromium.org/7530017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97492 0039d316-1c4b-4281-b951-d872f2087c98
* Disable NativeTextfieldViews drag and drop on TOUCHUI.msw@chromium.org2011-08-191-3/+15
| | | | | | | | | | | This is a temporary workaround for views drag and drop pain. BUG=none TEST=drag from omnibox in TOUCHUI does nothing, no problems. Review URL: http://codereview.chromium.org/7669063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97424 0039d316-1c4b-4281-b951-d872f2087c98
* Adds some debugging code to track crash. It seems as thoughsky@chromium.org2011-08-191-1/+9
| | | | | | | | | | | | | | | ClearNativeFocus in View::OnFocus is triggering 'this' to be deleted. I couldn't readily find any views that do anything interesting when the native focus changes, but this should help us find out if that's true. BUG=89439 TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/7670077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97412 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce FORCE_LTR_DIRECTIONALTY in Canvas.xji@chromium.org2011-08-182-42/+45
| | | | | | | | | | | | | For strings coming from webpage (such as alert in JS), its directionality is set according to the directionality of its first strong character's directionality. For chrome's UI string, its directionality is set as RTL if the UI is RTL and the string contains strong RTL characters. BUG=91698 TEST=start chrome in RTL locale, check about:crash, "!" should be displayed at very left. check the directionality of alert() with bidi text in LTR and RTL chrome, the directionality should be determined by its first strong directionality character. Review URL: http://codereview.chromium.org/7655037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97392 0039d316-1c4b-4281-b951-d872f2087c98
* Adds some debugging code in hopes of finding why 90860 is happening.sky@chromium.org2011-08-184-2/+17
| | | | | | | | | | BUG=90860 TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/7631048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97375 0039d316-1c4b-4281-b951-d872f2087c98
* Add Unicode support to ibus_input_method.cc.yusukes@google.com2011-08-181-0/+8
| | | | | | | | | | | We should copy |character_| and |unmodified_| character values to the PengingKeyEvent object so that we can type Unicode characters (>= 0x80) even when ibus-daemon is running. BUG=None (internal bug) TEST=manually done: login, switch to the French virtual keyboard, press Shift, press More, then press √, ÷, etc. Review URL: http://codereview.chromium.org/7599022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97303 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: base/scoped_ptr.h -> base/memory/scoped_ptr.h. (part 4)thestig@chromium.org2011-08-182-2/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7670016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97286 0039d316-1c4b-4281-b951-d872f2087c98
* widget: Look at the 'maximize' initialization param on creation.sadrul@chromium.org2011-08-182-2/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7655020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97259 0039d316-1c4b-4281-b951-d872f2087c98
* Implement NativeWidgetViews::CenterWindow().rhashimoto@chromium.org2011-08-171-2/+4
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7655023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97240 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Purify and Quantify.Doing so will reduce substantially the size of ↵jeanluc@chromium.org2011-08-172-2/+2
| | | | | | | | | the project files. BUG=92102 Review URL: http://codereview.chromium.org/7528010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97156 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure dialog window gets closed at the end of test.oshima@google.com2011-08-171-5/+27
| | | | | | | | | | | | | Fix memory leak (test_dialog_) This fixes issues in other tests that are caused by unclosed dialog windows. BUG=none TEST=none Review URL: http://codereview.chromium.org/7670021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97154 0039d316-1c4b-4281-b951-d872f2087c98
* Remove PREVIOUS_GRAPHEME_TRAILING. xji@google.com2011-08-162-44/+13
| | | | | | | | | | | | Remove const from GetIndexOfPreviousGrapheme() so the override function could update local data. Construct SelectionModel correctly in unittest. BUG=90426 TEST=--use-pure-view. Review URL: http://codereview.chromium.org/7607018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97029 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Improve brightness and volume animations.derat@chromium.org2011-08-153-127/+104
| | | | | | | | | | | | | | Make the onscreen brightness and volume indicators not be janky. Also change views::ProgressBar to permit specifying min and max double values, instead of just using a hardcoded integer range between 0 and 100. BUG=chromium-os:19141,chromium-os:8473 TEST=manual: held volume keys and checked that animation is smooth Review URL: http://codereview.chromium.org/7646004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96853 0039d316-1c4b-4281-b951-d872f2087c98
* views-desktop: Fix updating the cursor for windows.sadrul@chromium.org2011-08-153-1/+13
| | | | | | | | | | | It is necessary to remember the cursor set for the associated widget in the NativeWidgetView so that it can return the correct cursor when the parent Widget requests for it. BUG=none TEST=manually (launch chrome with views-desktop, move cursor over a link/textfield and see the cursor change properly) Review URL: http://codereview.chromium.org/7633018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96852 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented nicer battery statusdavemoore@chromium.org2011-08-127-4/+49
| | | | | | | | | BUG=chromium-os:17469 TEST=Click battery icon, confirm it meets spec Review URL: http://codereview.chromium.org/7491083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96643 0039d316-1c4b-4281-b951-d872f2087c98
* Dropping non-existant sources.bradnelson@google.com2011-08-111-1/+0
| | | | | | | | | | BUG=None TEST=None R=jeanluc@chromium.org Review URL: http://codereview.chromium.org/7612011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96432 0039d316-1c4b-4281-b951-d872f2087c98
* Fix RenderText cached bounds and offset logic; update clients.msw@chromium.org2011-08-112-17/+6
| | | | | | | | | | | | | | | | | | Ensure the display offset and cursor bounds are valid on use. Build in offset logic to RenderText display and hit-testing. Implement simpler temporary GetStringWidth and GetCursorBounds. Fix SetDisplayRect signature, code file ordering, invalidation. Rename and refactor a bit, update comments. Fixes adornment display & hit testing on text field overflows. Increases abstraction/encapsulation for easier client use. BUG=90426 TEST=--use-pure-views / touch_ui textfield use with overflow. Review URL: http://codereview.chromium.org/7466048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96334 0039d316-1c4b-4281-b951-d872f2087c98
* views-desktop: Fix sending mousewheel events to the correct view.sadrul@chromium.org2011-08-111-2/+12
| | | | | | | | | | | | | | Mousewheel events, like keyboard events and unlike other mouseevents, are sent to the focused view from the focus-manager, instead of sending to the view at the location of the LocatedEvent. So This needs to be handled from the dekstop/window-manager to send the events to the focused window. BUG=none TEST=none Review URL: http://codereview.chromium.org/7462017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96271 0039d316-1c4b-4281-b951-d872f2087c98
* views: Force child views to paint into their own texture when the parent has ↵sadrul@chromium.org2011-08-101-5/+10
| | | | | | | | | | | an external texture. BUG=none TEST=none Review URL: http://codereview.chromium.org/7605024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96177 0039d316-1c4b-4281-b951-d872f2087c98
* views-desktop: Add the desktop-window as an observer for a widget when it ↵sadrul@chromium.org2011-08-101-1/+7
| | | | | | | | | | | | | | gets added to the desktop. This fixes sending keyboard events to the browser in views-desktop. TBR=sky@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/7604024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96126 0039d316-1c4b-4281-b951-d872f2087c98
* NativeWidgetPrivate::CreateNativeWidget should check for NULL on views_delegatevarunjain@chromium.org2011-08-091-1/+1
| | | | | | | | | | | as views_delegate may not be initialized when touchui is set BUG=none. TEST=none. Review URL: http://codereview.chromium.org/7529031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95940 0039d316-1c4b-4281-b951-d872f2087c98
* Tests for TouchSelectoinControllerImpl.varunjain@chromium.org2011-08-085-0/+219
| | | | | | | | | | BUG=none. TEST=none. Review URL: http://codereview.chromium.org/7491090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95847 0039d316-1c4b-4281-b951-d872f2087c98
* NativeWidgetViews: Implement widget activation/deactivation.sadrul@chromium.org2011-08-084-12/+25
| | | | | | | | | BUG=none TEST=WidgetObserverTest.ActivationChange Review URL: http://codereview.chromium.org/7585028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95828 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in SelectRect().xji@google.com2011-08-061-1/+1
| | | | | | | TEST=build with touchui=1, drag selection handles. Review URL: http://codereview.chromium.org/7569024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95701 0039d316-1c4b-4281-b951-d872f2087c98
* Rename VIEWS_API to VIEWS_EXPORT.darin@chromium.org2011-08-05104-255/+256
| | | | | | | R=rvargas@chromium.org Review URL: http://codereview.chromium.org/7550038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95651 0039d316-1c4b-4281-b951-d872f2087c98
* extend RenderText for inheritance. Itxji@google.com2011-08-045-66/+142
| | | | | | | | | | | | | 1. Moves temporary color definition to gfx, declares some function as virtual for override, removes const from some functions so that the override function is able to modify local data. 2. Cache cursor bounds and compute it (along with display_offset_) when necessary. 3. Introduce SelectionModel (not derivable) for visual cursor positioning. BUG=90426 TEST=--use-pure-views text editing Review URL: http://codereview.chromium.org/7461102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95508 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing OnCaretBoundsChanged() hooks to NativeTextfieldViews.varunjain@chromium.org2011-08-031-0/+4
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7465091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95282 0039d316-1c4b-4281-b951-d872f2087c98
* Add proper drag position to TouchSelectionController::SelectionHandleDragged.varunjain@chromium.org2011-08-032-5/+6
| | | | | | | | | | | | | This is necessary for updating selection on multiline text such as on a webpage. BUG=none TEST=none Review URL: http://codereview.chromium.org/7508018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95279 0039d316-1c4b-4281-b951-d872f2087c98
* Make NetworkMenuModel a ui::MenuModel again.rhashimoto@chromium.org2011-08-034-7/+15
| | | | | | | | | | | | This is a necessary refactoring to a single menu model to define both views menu and WebUI menu. BUG=chromium-os:17892 TEST=none Review URL: http://codereview.chromium.org/7541002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95244 0039d316-1c4b-4281-b951-d872f2087c98
* views: Properly exclude native_menu_x when touchui==0 and toolkit_uses_gtk=1mnissler@chromium.org2011-08-031-2/+2
| | | | | | | | | BUG=None TEST=gold doesn't complaint about multiple definitions for views::MenuWrapper::CreateWrapper when linking libviews.so Review URL: http://codereview.chromium.org/7466054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95233 0039d316-1c4b-4281-b951-d872f2087c98
* Implement text selection widgets for controlling text selection on touchvarunjain@chromium.org2011-08-037-10/+426
| | | | | | | | | | | | | | | interface. We want this functionality on views textfields as well as the webpage. This CL lays out the ground work and implements the text selection interface for view textfield. In a later CL, I intend to implement the TextSelection Interface for RenderWidgetHostViewViews. BUG=none TEST=none Review URL: http://codereview.chromium.org/7465045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95186 0039d316-1c4b-4281-b951-d872f2087c98
* Alwas set saved maximized state for panels to 'false'.stevenjb@google.com2011-08-021-1/+8
| | | | | | | | | | | | | | For reasonss that are not entirely clear, Browser::GetSavedMaximizedState() is sometimes setting maximized to true for panels created by an extension on ChromeOS. Since panels have no concept of a maximized state, fix this by always returning 'false'. This also includes a patch to widget.cc that is not necessary to fix this behavior, but it fixes the case where ShowInactive gets called when the widget is maximized (which shouldn't normally happen). BUG=chromium-os:18534 TEST=See issue + test opening panels from an extension Review URL: http://codereview.chromium.org/7551002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95141 0039d316-1c4b-4281-b951-d872f2087c98
* Fix font and selection issues for RenderText temporary code.msw@chromium.org2011-08-021-0/+7
| | | | | | | | | | | | | Remove unnecessary gfx namespace specifiers. This should restore the large font size, and render the cursor and selection in their correct positions. BUG=90426 TEST=touchui omnibox text interaction. Review URL: http://codereview.chromium.org/7540036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95118 0039d316-1c4b-4281-b951-d872f2087c98
* Nix GetFocusManagerForNativeView|Window.msw@chromium.org2011-08-0210-65/+45
| | | | | | | | | | | | Use Widget|View::GetFocusManager instead. Use Widget::Get[TopLevel]WidgetForNativeView|Window as necessary. BUG=88718 TEST=none Review URL: http://codereview.chromium.org/7532015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95111 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 01:39:10 +0000