summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Add highlight color support to label text.erikkay@google.com2009-05-153-3/+46
| | | | | | | | | BUG=none TEST=--gtest_filter=LabelTest.* Review URL: http://codereview.chromium.org/113466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16202 0039d316-1c4b-4281-b951-d872f2087c98
* Reland this change. Registers paths for the testing exe, too.ben@chromium.org2009-05-151-1/+0
| | | | | | | | | | Move/Copy paths used by app to app_paths. http://crbug.com/11387 Review URL: http://codereview.chromium.org/115420 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16200 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 16173beng@google.com2009-05-151-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16176 0039d316-1c4b-4281-b951-d872f2087c98
* Move/Copy paths used by app to app_paths.beng@google.com2009-05-151-1/+0
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/113452 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16173 0039d316-1c4b-4281-b951-d872f2087c98
* Displaying consecutive alerts from plugins should not hang the browser. The ↵ananta@chromium.org2009-05-153-3/+14
| | | | | | | | | | | | | | | | | | plugins display alerts via the NPN_Evaluate API. The browser signals an event handle to ensure that the plugin starts peeking for messages while waiting for the NPN_Evaluate call to return. When the dialog is dismissed by the user, windows does send some messages to the plugin window underneath, like activation messages, etc. These don't get dispatched as the event is reset when the dialog is dismissed, i.e. much before the window is actually destroyed. The fix is to reset the event handle after the window is actually destroyed. To achieve this I added an OnClose virtual function to the DialogDelegate interface, which is overridden by the JavascriptMessageBoxDialog class which eventually ensures that the event is reset. This fixes http://code.google.com/p/chromium/issues/detail?id=10799 I updated the AlertInWindowMessage npapi test to display two alerts instead of one. Bug=10799 Review URL: http://codereview.chromium.org/113464 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16172 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeCanvas->gfx::Canvasben@chromium.org2009-05-1557-195/+203
| | | | | | | | | | | Rename files too. TBR=brettw http://crbug.com/11387 Review URL: http://codereview.chromium.org/113443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16148 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFont->gfx::Fontbeng@google.com2009-05-1522-62/+64
| | | | | | | | | | Does not rename the files yet. http://crbug.com/11387 Review URL: http://codereview.chromium.org/113441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16141 0039d316-1c4b-4281-b951-d872f2087c98
* Change the way button width is calculated for the button. Currently, for the ↵jshin@chromium.org2009-05-151-2/+4
| | | | | | | | | | | | | | | | | | | | default button (for which GetDialogButtonLabel returns an empty string), the width is always set to kDialogMinButtonWidth. It's sufficiently large for 'Ok', 'Close' and 'Cancel' in most languages, but not large enough for some languages. For those languages, this CL sets the button width to max(preferred_width, kDialogMinButtoWidth), the former of which is calculated using the translated strings for Ok/Close/Cancel. This needs to be merged to 2.0 branch (the location of views has moved from under chrome\ to the top-level source directory in the trunk) http://crbug.com/11710 TEST: Start Chrome with '--lang=ml' cmd line flag. Open up the option dialog and see 'Close' button at the bottom is large enough for the label ('Close' in Malayalam) and some space around it. Review URL: http://codereview.chromium.org/113250 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16131 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fix issue 11907 -- RTL: Focus is not on the text after checking ↵xji@chromium.org2009-05-141-2/+11
| | | | | | | | | | | "Delete all profile data" Since the text_bounds computed in Label::CalculateDrawStringParams() are different for mutl-line text and single line text. Draw focus rectangle need to be handled differently (mirroring or no mirroring) as well. BUG=http://crbug.com/11907 Review URL: http://codereview.chromium.org/115370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16111 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage... some more traces of always-on-top I forgot to remove.beng@google.com2009-05-142-6/+0
| | | | | | | TBR=jcampan Review URL: http://codereview.chromium.org/114028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16108 0039d316-1c4b-4281-b951-d872f2087c98
* Move Always On Top setting out of Window/WindowDelegate and into task ↵beng@google.com2009-05-149-146/+30
| | | | | | | | | manager. It's the only one who uses this setting and the UI for exposing it is very specific to the task manager. Window retains a setter to set always on top state, but persistence and the system menu is Task Manager's responsbility. This allows us to sever the second-to-last chrome dependency from views. http://crbug.com/11674 Review URL: http://codereview.chromium.org/115378 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16107 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors menus so that I can create a MenuGtk implementation, and moves it intosky@chromium.org2009-05-148-654/+768
| | | | | | | | | | | | the namespace views. BUG=none TEST=make sure I haven't broken any menus. This impacts all menus in Chrome, except bookmark ones. Review URL: http://codereview.chromium.org/113410 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16100 0039d316-1c4b-4281-b951-d872f2087c98
* Add basic checkbox support for GTK.brettw@chromium.org2009-05-143-0/+36
| | | | | | | | This also makes the Checkbox check for the native wrapper just like NativeButton does, to prevent crashes if it hasn't been initialized yet. Review URL: http://codereview.chromium.org/113408 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16094 0039d316-1c4b-4281-b951-d872f2087c98
* Remove even more ATL dependencies.maruel@chromium.org2009-05-1423-88/+112
| | | | | | Review URL: http://codereview.chromium.org/115309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16088 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15832 since this test is finished.hbono@chromium.org2009-05-143-3/+3
| | | | | | | BUG=11046 "Need to back out hbono's test fix" Review URL: http://codereview.chromium.org/112021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16047 0039d316-1c4b-4281-b951-d872f2087c98
* Clean-up of the accelerator code.jcampan@chromium.org2009-05-148-57/+61
| | | | | | | | | | | | | | | The View::CanProcessTabKeyEvents and View::ShouldLookUpAccelerator have both been replaced with a new method, SkipDefaultKeyEventProcessing. This new method provides for a view that has focus a way to prevent a key event from being processed for tab traversal or accelerators. Also, fixed a regression where the Ctrl-Tab accelerator was not working anymore when the omnibox was focused. BUG=11538 TEST=Thoroughly test accelerators, making sure they work when the page, the omnibox and the find-bar text-field have focus. Also test that tab traversal still work as expected in the browser and in the option dialog. Review URL: http://codereview.chromium.org/113307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16037 0039d316-1c4b-4281-b951-d872f2087c98
* Make WidgetWin redraw child windows that are in a different process ↵jam@chromium.org2009-05-141-3/+30
| | | | | | | | | | | asynchronously. This helps with jank (i.e. bug 11701 which I couldn't repro with this) and also with deadlocks (fixes 11421 for painting). BUG=11421,11701 Review URL: http://codereview.chromium.org/115216 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16027 0039d316-1c4b-4281-b951-d872f2087c98
* Move tree-related classes that Linux code depends on from views/ to app/phajdan.jr@chromium.org2009-05-136-502/+1
| | | | | | | | | | TEST=If it compiles and unit_tests pass, it's ok. Just moving files around. http://crbug.com/11066 Review URL: http://codereview.chromium.org/115185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15982 0039d316-1c4b-4281-b951-d872f2087c98
* The dialogs would size their width to their contents (and a minimum size).jcampan@chromium.org2009-05-131-0/+20
| | | | | | | | | | | In some cases, the dialog buttons can be wider than the contents and were clipped. This CL size the dialog to its contents or buttons, whatever is wider. BUG=11855 TEST=Visit pages with alerts/confirm dialogs, make sure dialog are shown properly. Test the case described in the bug. Review URL: http://codereview.chromium.org/115314 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15981 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 15965. I wasn't supposed to check that in since it still doesn't ↵maruel@chromium.org2009-05-1323-99/+75
| | | | | | | | | compile on linux and mac! TBR=sky Review URL: http://codereview.chromium.org/113351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15967 0039d316-1c4b-4281-b951-d872f2087c98
* Remove even more ATL dependencies.maruel@chromium.org2009-05-1323-75/+99
| | | | | | Review URL: http://codereview.chromium.org/115309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15965 0039d316-1c4b-4281-b951-d872f2087c98
* This CL updates chrome to the latest version of skia, retrieved via DEPS, andsenorblanco@chromium.org2009-05-1320-22/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | placed in third_party. All relevant skia changes (for all 3 platforms) have been upstreamed. Most of this CL is mind-numbingly repetitive. Things of interest are: skia.gyp (now points at third_party versions), DEPS, and SkUserConfig.h. stdint.h: Skia now requires C99 integer types, which MSVC doesn't support natively. I have put typedefs in config/win/stdint.h. Note that the new version of skia appears to render rects whose coordinates are "backwards" (ie., x2 < x1 or y2 < y1), which were formerly culled. There were a couple obvious instances of this in the code which I fixed, but there may be more. There were ~35 layout test failures due to minor pixel differences which I rebaselined on Windows and Linux, and 8 genuine failures related to masks and stroked text, which I have put in text_expectations.txt and assigned to myself. (There was another change which broke ~1700 tests on each platform, but I put that change behind an #ifdef for now). R=brettw Review URL: http://codereview.chromium.org/65012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15949 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a trivial typo: key for copy is 'c', not 'v'.hamaji@chromium.org2009-05-121-1/+1
| | | | | | Review URL: http://codereview.chromium.org/115253 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15896 0039d316-1c4b-4281-b951-d872f2087c98
* An experimental fix for Issue 11046.hbono@chromium.org2009-05-123-3/+3
| | | | | | | | | This change replaces some ImmAssociateContextEx() calls with a LoadLibrary() call and a GetProcAddress() call to prevent Chrome from loading "imm32.dll" on a PC which doesn't have valid "imm32.dll" installed. (Since I have not been able to reproduce this issue on my XP box, this is just a blind fix.) BUG=11046 "repeated crash on launch" Review URL: http://codereview.chromium.org/113096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15832 0039d316-1c4b-4281-b951-d872f2087c98
* Removing floating views, they are not used anymore.jcampan@chromium.org2009-05-117-635/+44
| | | | | | | | | BUG=None TEST=Run unit_tests, ui_tests, interactive ui_tests. Make sure focus traversal still works. Review URL: http://codereview.chromium.org/113215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15817 0039d316-1c4b-4281-b951-d872f2087c98
* Adds back some code removed during Ben's landing of views renaming.sky@chromium.org2009-05-117-3/+424
| | | | | | | | | | | Adds support for GTK buttons. BUG=none TEST=none Review URL: http://codereview.chromium.org/113212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15793 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot to add these files as part of last change.ben@chromium.org2009-05-101-0/+64
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15734 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new ViewsDelegate interface and implementation in the windows browser UI.ben@chromium.org2009-05-107-53/+35
| | | | | | | | | | | | Provides a way for saving and restoring window placement, obtaining system helpers etc. http://crbug.com/11633 TEST=make sure window placement saving works, clipboard, and that windows in the taskbar have a chrome icon. Review URL: http://codereview.chromium.org/113173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15733 0039d316-1c4b-4281-b951-d872f2087c98
* Use the non-native frame when using themes even on Aero Glass.ben@chromium.org2009-05-091-0/+2
| | | | | | Review URL: http://codereview.chromium.org/113183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15725 0039d316-1c4b-4281-b951-d872f2087c98
* Random cleanups and stubs to get cross platform build going.glen@chromium.org2009-05-092-0/+6
| | | | | | | | TBR=beng Review URL: http://codereview.chromium.org/115158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15712 0039d316-1c4b-4281-b951-d872f2087c98
* Revert custom frame view to resourcebundle to get the tests passing. Convert ↵glen@chromium.org2009-05-091-37/+37
| | | | | | | | | | to ThemeProvider later. TBR=beng Review URL: http://codereview.chromium.org/115155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15707 0039d316-1c4b-4281-b951-d872f2087c98
* This is the first pass at themes.glen@chromium.org2009-05-0910-198/+207
| | | | | | | | | | | | This CL is paired with http://codereview.chromium.org/67284 This CL (for commit purposes) includes http://codereview.chromium.org/67284 BUG=4463,11232,11233,11234,11235 Review URL: http://codereview.chromium.org/99030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15704 0039d316-1c4b-4281-b951-d872f2087c98
* Move win_util.h from common to app.ben@chromium.org2009-05-089-11/+7
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/113169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15694 0039d316-1c4b-4281-b951-d872f2087c98
* Move color_utils, text_elider, drag_utils, accessibility_types, ↵ben@chromium.org2009-05-0813-50/+382
| | | | | | | | | standard_layout to new locations in app/ and views/ http://crbug.com/11387 Review URL: http://codereview.chromium.org/113143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15687 0039d316-1c4b-4281-b951-d872f2087c98
* fix checkdeps bustageben@chromium.org2009-05-081-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15684 0039d316-1c4b-4281-b951-d872f2087c98
* Add PreferredSizeChanged() to View to allow subviews to notify their parents ↵erikkay@google.com2009-05-086-4/+24
| | | | | | | | that they'd really like another layout.R=skyTEST=none Review URL: http://codereview.chromium.org/113133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15680 0039d316-1c4b-4281-b951-d872f2087c98
* Resurrect Scott's WindowGtk changes.ben@chromium.org2009-05-0816-116/+643
| | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/115143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15678 0039d316-1c4b-4281-b951-d872f2087c98
* A new DEPS file for views, designed to reduce dependencies. Removes some ↵ben@chromium.org2009-05-083-22/+44
| | | | | | | | | | unnecessary includes too. http://crbug.com/11387 Review URL: http://codereview.chromium.org/115114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15610 0039d316-1c4b-4281-b951-d872f2087c98
* Move src/chrome/views to src/views. RS=darin http://crbug.com/11387ben@chromium.org2009-05-08154-0/+41087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15604 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-19 23:29:22 +0000