summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Fix NativeViewHostGtk clipping.ben@chromium.org2009-07-238-75/+156
| | | | | | | | | | | | | Basically, I introduce an additional GtkFixed into the GtkWidget hierarchy. When clipping is required, this is re-created with a X Window and clipping is performed. For some reason, Gtk+Cairo won't clip rendering to the parent GtkWidget if there isn't an associated X Window. This also fixes the GetPreferredSize implementation for NativeButtonGtk which would return ever increasing values of size each time it was called. BUG=none TEST=none Review URL: http://codereview.chromium.org/159153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21423 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two crashers with TOOLKIT_VIEWS build:ben@chromium.org2009-07-211-2/+7
| | | | | | | | | | | - NativeViewHostGtk::RemovedFromWidget crashes due to WidgetGtk::window_contents_ being NULL... basically when RemovedFromWidget is called from the RootView's dtor, the window_contents_ and widget_ properties of the containing WidgetGtk are NULL. It seems acceptable to not clean up in this case. - TabContentsViewGtk dtor needs to call CloseNow(). This is similar to ~TabContents() calling DestroyWindow on the view's HWND. Without this, the TabContentsViewGtk object was destroyed but the corresponding GtkWidget wasn't, and so subsequent signal handlers would crash. BUG=none TEST=none Review URL: http://codereview.chromium.org/159130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21202 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring of tabbed-pane component so it can be ported to Linux toolkit_view.jcampan@chromium.org2009-07-217-121/+386
| | | | | | | | BUG=None TEST=Make sure the Options dialog still works as expected (tab selection, focus traversal...) Review URL: http://codereview.chromium.org/155668 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21189 0039d316-1c4b-4281-b951-d872f2087c98
* Resurrect toolkit_views build.ben@chromium.org2009-07-211-0/+2
| | | | | | Review URL: http://codereview.chromium.org/155797 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21132 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash on older versions of windows that don't have DWM APIs.ben@chromium.org2009-07-201-8/+12
| | | | | | | | | http://crbug.com/17290 TEST=none Review URL: http://codereview.chromium.org/155798 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21112 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage.erg@chromium.org2009-07-192-0/+5
| | | | | | | | TBR=mirandac Review URL: http://codereview.chromium.org/155760 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21067 0039d316-1c4b-4281-b951-d872f2087c98
* Fix frame turning black when reseting theme. Also simplifies the frameben@chromium.org2009-07-181-32/+27
| | | | | | | | | | | | | | type changed code somewhat. It turns out the frame still needs to be hidden for WM_DWMCOMPOSITIONCHANGED message handlers however. Not sure why, but this is the simplest/least buggy this code has been so far so I can live with it. http://crbug.com/14578 TEST=see bug Review URL: http://codereview.chromium.org/159050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21045 0039d316-1c4b-4281-b951-d872f2087c98
* Converts a couple of by value return types to const ref returnssky@chromium.org2009-07-171-4/+3
| | | | | | | | | | | types. Also expands on the documentation of GetViewForPoint. BUG=none TEST=none Review URL: http://codereview.chromium.org/149723 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20969 0039d316-1c4b-4281-b951-d872f2087c98
* SingleSplitView: survive minimize / restore when resize changes leading bounds.pfeldman@chromium.org2009-07-161-8/+18
| | | | | | | | BUG=16855 Review URL: http://codereview.chromium.org/155629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20872 0039d316-1c4b-4281-b951-d872f2087c98
* This makes the unit-tests pass with toolkit_views on Linux.jcampan@chromium.org2009-07-152-34/+52
| | | | | | | | | | It also make them run the view tests. BUG=None TEST=Run the unit-tests on Linux with toolkit_views=1 Review URL: http://codereview.chromium.org/149649 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20794 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt fixing a crash. Looks like NativeMenuWin was getting leaked by ↵ben@chromium.org2009-07-151-2/+3
| | | | | | | | | | | Menu2... meaning a NativeMenuWin could outlive its model potentially! http://crbug.com/14594 TEST=none Review URL: http://codereview.chromium.org/149635 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20692 0039d316-1c4b-4281-b951-d872f2087c98
* Make native_menu_win be 'owner_drawn' when the UI font/size is overriden for ↵jshin@chromium.org2009-07-141-2/+2
| | | | | | | | | | | | | Indian languages. This is a regression with a new menu implementation. BUG=7319 (http://crbug.com/7319 ) TEST=Run Chrome with --lang=ml or --lang=bn and see if labels in PageMenu or AppMenu are readable. Review URL: http://codereview.chromium.org/155403 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20675 0039d316-1c4b-4281-b951-d872f2087c98
* Allow TabContentsDelegates to process unhandled keyboard messages coming ↵ananta@chromium.org2009-07-143-75/+0
| | | | | | | | | | | | | | | | | | | back from the renderer. This is required for ExternalTabContainer to be able to pass unhandled keyboard accelerator messages back to the external host. This worked before as the focus manager would hand off these messages to keystroke listeners like the ExternalTabContainer. However with the ExternalTabContainer no longer using the focus manager this does not work anymore. Removed the keystroke listener code from the focus manager as the ExternalTabContainer was the only consumer and it does not use it anymore. This fixes bug http://b/issue?id=1975749 Bug=1975749 Review URL: http://codereview.chromium.org/149520 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20600 0039d316-1c4b-4281-b951-d872f2087c98
* Add 'resize_leading_on_bounds_change' property into the SingleSplitView.pfeldman@chromium.org2009-07-092-1/+28
| | | | | | | | When it is turned on, leading component is resized when split view gets new bounds. Review URL: http://codereview.chromium.org/155214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20258 0039d316-1c4b-4281-b951-d872f2087c98
* Fix: Position always off-screen when starting upyuzo@chromium.org2009-07-091-1/+2
| | | | | | | | | | | | | | Fixed the offset-by-taskbar logic. Tested with dual monitors, trying left-right and up-down monitor layouts. TEST=Use dual monitors (first:left, second:right) and open, close, and reopen Chromium in the second (right) window. Without this change, the window appears far to the right from the last location. BUG=15199 Review URL: http://codereview.chromium.org/155201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20246 0039d316-1c4b-4281-b951-d872f2087c98
* Replace instances of LINUX2 with OS_CHROMEOS and linux2 with chromeos.brettw@chromium.org2009-07-081-1/+1
| | | | | | Review URL: http://codereview.chromium.org/149367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20210 0039d316-1c4b-4281-b951-d872f2087c98
* Remove svn:executable property from files that don't need it.thestig@chromium.org2009-07-084-0/+0
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/155199 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20161 0039d316-1c4b-4281-b951-d872f2087c98
* Use different cursors for horizontal and vertical splits. (cursor was static ↵pfeldman@chromium.org2009-07-081-3/+3
| | | | | | | | local). Review URL: http://codereview.chromium.org/149317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20138 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in ImageButton exposed by r20028.mirandac@chromium.org2009-07-082-6/+6
| | | | | | | | | BUG= none. TEST= none. Review URL: http://codereview.chromium.org/149313 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20134 0039d316-1c4b-4281-b951-d872f2087c98
* Add the keys used by the back/forward menu items to the accelerator map so ↵ben@chromium.org2009-07-081-0/+9
| | | | | | | | | | | that we can locate sensible shortcut text for them rather than asking Windows. http://crbug.com/14070 TEST=see bug Review URL: http://codereview.chromium.org/149302 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20121 0039d316-1c4b-4281-b951-d872f2087c98
* Inverted logic in UseNativeFrame meant all constrained windows were opened ↵ben@chromium.org2009-07-081-1/+1
| | | | | | | | | | | with double-window frames. http://crbug.com/14476 TEST=see bug, or visit any page with HTTP basic auth Review URL: http://codereview.chromium.org/149294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20105 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Views GTK build.brettw@chromium.org2009-07-073-6/+8
| | | | | | | | I mvoed the implementation of the previously-inline amimate function to the .cc file so we don't have to depend on STL includes in the header. Review URL: http://codereview.chromium.org/155170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20091 0039d316-1c4b-4281-b951-d872f2087c98
* Basics of a new TabStrip.It's very, very rough, but I wanted to check it in ↵ben@chromium.org2009-07-078-1/+289
| | | | | | | | so I don't have to keep typing svn pset as I pass patches back and forth between machines.Behind a command line flag --enable-tabtastic2.I'm trying to split the TabContents specific stuff off of the TabStrip so it's more generic (and more easily mocked for unit testing of various layout conditions). Hence TabStrip vs. BrowserTabStrip. TabStrip may move into views/ once this process is complete.Animator is a utility that can be associated with a View that (at this point) animates that View's bounds from wherever it is now to somewhere else. The TabStrip uses this to do animations for individual Tabs that are independent of each other - a limitation of the old TabStrip is that only one animation is ever active at a time so its animations are a little jumpy compared to other products.Also, detached tab dragging shows the live contents, with all animations/video/etc.Like I said, this is really rough, but I didn't want it to grow any bigger. I will write up a design doc later.http://crbug.com/9032TEST=TBD... will finally be doing some for TabStrip layout! Review URL: http://codereview.chromium.org/42490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20053 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the current remaining Views-GTK compile and linker errors.brettw@chromium.org2009-07-062-1/+2
| | | | | | | | Chrome still doesn't run. Review URL: http://codereview.chromium.org/155026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19977 0039d316-1c4b-4281-b951-d872f2087c98
* Convert menu strings to UTF16, fix some views-GTK build errors.brettw@chromium.org2009-07-027-29/+25
| | | | | | Review URL: http://codereview.chromium.org/150171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19820 0039d316-1c4b-4281-b951-d872f2087c98
* Add layout support for invisible SingleSplitView children.pfeldman@chromium.org2009-07-011-12/+25
| | | | | | Review URL: http://codereview.chromium.org/150120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19737 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in ~WidgetGtk. This was caused by your change to no longersky@chromium.org2009-06-302-6/+6
| | | | | | | | | | | set RootView::widget_ = NULL in RootView::OnWidgetDestroyed. BUG=none TEST=none Review URL: http://codereview.chromium.org/150137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19684 0039d316-1c4b-4281-b951-d872f2087c98
* Makes WidgetGtk specify a size before realizing the window. Withoutsky@chromium.org2009-06-302-3/+11
| | | | | | | | | | | this we might not end up with the correct size. BUG=none TEST=none Review URL: http://codereview.chromium.org/149111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19657 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes compile bugs for views on gtk.sky@chromium.org2009-06-302-5/+4
| | | | | | | | | | TBR=jcampan BUG=none TEST=none Review URL: http://codereview.chromium.org/151099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19656 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing a breakage in the GTK toolkit build that my last check-in caused.jcampan@chromium.org2009-06-301-1/+1
| | | | | | | | | BUG=None TEST=None TBR=brettw Review URL: http://codereview.chromium.org/150133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19650 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compilation error in the focus manager by returning NULL from ↵brettw@chromium.org2009-06-301-0/+1
| | | | | | | | unimplemented function. Review URL: http://codereview.chromium.org/152001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19649 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Views combobox on GTK by adding a new function.brettw@chromium.org2009-06-302-1/+6
| | | | | | Review URL: http://codereview.chromium.org/150127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19631 0039d316-1c4b-4281-b951-d872f2087c98
* This CL removes the last (major) Windows specific part out of the focus ↵jcampan@chromium.org2009-06-3022-353/+172
| | | | | | | | | | | | | | | | | | | | | | | manager. It was previously landed and reverted because it broke the reliability tests. http://codereview.chromium.org/125148 The breakage was caused by constrained windows not getting a hold of the FocusManager when in unparented tabs. The fix is to ensure unparented tab still have a way to access their FocusManager for proper closure. Files changed from the previous patch that need reviewing: native_tab_contents_container_win.cc tab_contents_view_win.h tab_contents_view_win.cc BUG=None TEST=Run all tests (unit, ui, interactive). Extensively test the focus in Chrome. Review URL: http://codereview.chromium.org/146093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19617 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/150051jcampan@chromium.org2009-06-3012-55/+49
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19582 0039d316-1c4b-4281-b951-d872f2087c98
* Rework a loop in the native menu code to iterate over the vector of items we ↵ben@chromium.org2009-06-291-4/+5
| | | | | | | | | | | | | have, rather than the actual system menu. I believe this may fix a crash where the code indexes out of bounds in the vector. The trouble is the assumption that the native menu index matches the index into the vector. If someone has installed a windows addon this may not be true. It's safer to restrict the iteration to the bounds of the vector and index into the menu based on that. http://crbug.com/14600 TEST=none Review URL: http://codereview.chromium.org/150061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19558 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a menu crash.ben@chromium.org2009-06-261-0/+1
| | | | | | | | | | | The menu's host window, the message window that receives notifications from the native menu about selection changes, is destroyed, however if the menu is still active it will continue to send messages to it. SDK docs say properties set with SetProp should be removed with RemoveProp before a window is finally NCDESTROYed. The code wasn't doing this, so it was still theoretically possible for the code in the message window's window procedure to locate "something" on that property. http://crbug.com/14594 TEST=none Review URL: http://codereview.chromium.org/147230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19411 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in RootViewGtk where we we might not paint correctly ifsky@chromium.org2009-06-261-1/+12
| | | | | | | | | | | | SchedulePaint is invoked consecutively with different regions. Windows has similar code. BUG=none TEST=none Review URL: http://codereview.chromium.org/147170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19338 0039d316-1c4b-4281-b951-d872f2087c98
* Update Skia transfer modes to match changes in Skia as of r239amanda@chromium.org2009-06-255-6/+6
| | | | | | Review URL: http://codereview.chromium.org/146131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19213 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for vertical split into SingleSplitView.pfeldman@chromium.org2009-06-242-40/+91
| | | | | | Review URL: http://codereview.chromium.org/146036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19107 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ifdef that was triggering a NOTIMPLEMENTED in browser tests.jcampan@chromium.org2009-06-231-2/+2
| | | | | | | | BUG=None TEST=Run the browser tests Review URL: http://codereview.chromium.org/146049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19068 0039d316-1c4b-4281-b951-d872f2087c98
* Add Linux support for getting the thumbnail and wire into the switcher.brettw@chromium.org2009-06-231-1/+3
| | | | | | Review URL: http://codereview.chromium.org/144006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19064 0039d316-1c4b-4281-b951-d872f2087c98
* For consistency, stop using the workarea coordinate inyuzo@chromium.org2009-06-232-15/+34
| | | | | | | | | | | | | saving/retrieving/adjusting window positions. TEST=Open Chrome windows and see if they are placed properly. TESTED=gcl try, manually BUG=none Review URL: http://codereview.chromium.org/141039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19012 0039d316-1c4b-4281-b951-d872f2087c98
* Fix dialog edges - error was because we made the top edges the same height ↵glen@chromium.org2009-06-231-6/+2
| | | | | | | | | | but didn't update the code that compensated for their previously-different heights. BUG=13812 Review URL: http://codereview.chromium.org/145017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18993 0039d316-1c4b-4281-b951-d872f2087c98
* Revert :nsylvain@chromium.org2009-06-2222-169/+353
| | | | | | | | | | | | | | | | | | Changed by: jcampan@chromium.org Changed at: Fri 19 Jun 2009 21:22:47 Branch: src Revision: 18889 Comments: Relanding focus manager refactoring with build fix, see:http://codereview.chromium.org/125148BUG=NoneTEST=NoneTBR=ben Review URL: http://codereview.chromium.org/141013 Because it creates hundreds of new reliability crashes. TBR:jcampan Review URL: http://codereview.chromium.org/140064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18904 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding focus manager refactoring with build fix, ↵jcampan@chromium.org2009-06-2022-353/+169
| | | | | | | | see:http://codereview.chromium.org/125148BUG=NoneTEST=NoneTBR=ben Review URL: http://codereview.chromium.org/141013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18889 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 18872.jcampan@chromium.org2009-06-1922-169/+353
| | | | | | | | | | | | Broke the Windows build. BUG=None TEST=None TBR=ben Review URL: http://codereview.chromium.org/140023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18873 0039d316-1c4b-4281-b951-d872f2087c98
* Removed the last Windows specific part out of the focus manager. HWNDs are ↵jcampan@chromium.org2009-06-1922-353/+169
| | | | | | | | not subclassed anymore.The FocusManager is now created and owned by top-level WidgetWins.BUG=NoneTEST=Run the unit tests, UI tests, interactive UI tests. Fully test the focus behavior in the browser: activate/deactivate the browser windows, make sure focus is remembered. Switch tabs, make sure focus is remembered for each tab. make sure accelerators work as expected. Test focus traversal in a web page, in the option dialog. Review URL: http://codereview.chromium.org/125148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18872 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/131064 for tedoc2000.sky@chromium.org2009-06-181-0/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/132041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18771 0039d316-1c4b-4281-b951-d872f2087c98
* Call Layout directly from SetContentsView. In the case where the Widget is ↵ben@chromium.org2009-06-182-5/+10
| | | | | | | | | | | | | | created with bounds, SetContentsView never causes a subsequent Layout because the bounds won't have changed. Fixes interactive UI tests. TBR=sky BUG=none TEST=interactive ui tests don't crash. Review URL: http://codereview.chromium.org/132029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18729 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up "clear browsing data" dialog. It looks like ass right now. The ↵ben@chromium.org2009-06-184-27/+53
| | | | | | | | | | intent is to be able to debug problems with NativeControls under Gtk. BUG=none TEST=none Review URL: http://codereview.chromium.org/131027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18715 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 03:05:48 +0000