summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Fix compiler warnings.chocobo@chromium.org2010-03-261-4/+4
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/1349005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42785 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting this CL to fix the interactive ui test failures.ananta@chromium.org2010-03-2613-305/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert 42498 - Keyboard accessibility for the page and app menus. Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/1428001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42779 0039d316-1c4b-4281-b951-d872f2087c98
* estade:- This revert is to fix interactive ui test failures which have been ↵ananta@chromium.org2010-03-262-16/+19
| | | | | | | | | | | | | | | | | | | | | broken since Wednesday. Your CL is not at fault though. 42498 seems to be the culprit. I had to revert your CL as it leads to conflicts while reverting 42498 Revert 42703 - Views: fix a crash where in the browser actions container. This crash didn't actually affect linux/views (for some reason the RunContextMenu() call seems to never return). BUG=38964 TEST=crash an extension while the context menu for it is showing. Review URL: http://codereview.chromium.org/1237004 TBR=estade@chromium.org Review URL: http://codereview.chromium.org/1423002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42778 0039d316-1c4b-4281-b951-d872f2087c98
* Added unit test for the views::ProgressBar::AddProgress method.denisromanov@chromium.org2010-03-261-0/+11
| | | | | | | | | BUG=37960 TEST=Run unit_tests. Review URL: http://codereview.chromium.org/1216007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42731 0039d316-1c4b-4281-b951-d872f2087c98
* Views: fix a crash where in the browser actions container.estade@chromium.org2010-03-262-19/+16
| | | | | | | | | | | This crash didn't actually affect linux/views (for some reason the RunContextMenu() call seems to never return). BUG=38964 TEST=crash an extension while the context menu for it is showing. Review URL: http://codereview.chromium.org/1237004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42703 0039d316-1c4b-4281-b951-d872f2087c98
* Reenabling some unit-tests on Linux, they seem to work fine now,jcivelli@chromium.org2010-03-251-6/+0
| | | | | | | | | | | even with the screen locked. BUG=23394 TEST=Run the tests. Review URL: http://codereview.chromium.org/1286005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42634 0039d316-1c4b-4281-b951-d872f2087c98
* Virtual LocaleChanged() callback added to views hierarchy to notifyglotov@google.com2010-03-252-2/+12
| | | | | | | | | | | views of the locale change so they could reload relevant data. BUG=none TEST=none Review URL: http://codereview.chromium.org/1145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42614 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression from Label fixes -- I forgot to make GetHeightForWidth() ↵pkasting@chromium.org2010-03-241-11/+18
| | | | | | | | | | actually care about the provided width for multi-line text. Oops. BUG=39104 TEST=About box should not be inordinately large Review URL: http://codereview.chromium.org/1293003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42527 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-2413-18/+305
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42498 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42465 - Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-2413-305/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reverting because newly added Test*MenuKeyboardAccess tests fail on some of the Windows buildbots, and possibly a XP Perf regression. Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/1257003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42468 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-2413-18/+305
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42465 0039d316-1c4b-4281-b951-d872f2087c98
* Add Accessibility name for native buttons.mhm@chromium.org2010-03-233-7/+3
| | | | | | | | | | | Remove the accessible name from Checkbox since it inherits from NativeButton. Dialogs with autogenerated buttons now have MSAA name attached to it, as well as all the checkboxes. BUG=38987 TEST=Ran it in AccExplorer Review URL: http://codereview.chromium.org/1102006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42401 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes ordering of includes.sky@chromium.org2010-03-231-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1075018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42377 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes compile error because gfx moved to src.sky@chromium.org2010-03-231-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/1150007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42359 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability to display text in a textfield when the text issky@chromium.org2010-03-237-17/+165
| | | | | | | | | | | empty. BUG=none TEST=none Review URL: http://codereview.chromium.org/1155008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42353 0039d316-1c4b-4281-b951-d872f2087c98
* views: [accessibility] Add accessible names for Minimize, Maximize, Restore ↵ctguil@chromium.org2010-03-231-0/+6
| | | | | | | | | | | | | buttons in the top right corner of the Window. BUG=9614 TEST=TEST=open AccExplorer, open the main chrome window, point it to one of the three buttons in the top-right corner, see if it shows the correct accessible names for each one. Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1076009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42349 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in my r42322.hbono@chromium.org2010-03-231-1/+1
| | | | | | | | | | | I landed a change that includes a typo. Sorry for your inconveniences. TBR=ben BUG=none TEST=build fix Review URL: http://codereview.chromium.org/1105013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42323 0039d316-1c4b-4281-b951-d872f2087c98
* This change adds shield icons to the buttons that need elevation to fix ↵hbono@chromium.org2010-03-233-10/+35
| | | | | | | | | | | | | | | | Issue 29631. This change adds a bool flag |need_elevation_| to notify when a button needs elevation to the NativeButton class and add shield icons to the following buttons. - on the "Start Chromium" button on the first-run dialog when the "Make Chromium the default browser" checkbox is enabled. - on the "Set as Default" button on the default browser infobar. - on the "Make Google Chrome my default browser" button on the Basics tab of options. BUG=29631 TEST=Launch Chrome when it is not set as a default browser and see the "Set as Default" button has a shield icon. TEST=Launch Chrome when it is not set as a default browser and open the "Options" dialog, and see its "Make Google Chrome my default browser" button has a shield icon. TEST=Launch Chrome with a '--first-run' option when it is not set as a default browser, and see its "Launch Chrome" button has a shield icon. Review URL: http://codereview.chromium.org/661165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42322 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/gfx/canvas and app/gfx/font to gfx/.ben@chromium.org2010-03-2358-70/+70
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1132006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42312 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix some GdkPixbuf leaks.mattm@chromium.org2010-03-231-0/+1
| | | | | | | | | | | | Also expand some documentation for functions that returned a GdkPixbuf about who owns the reference BUG=38895 TEST=manual test that nothing is broken, will watch bot for leak results Review URL: http://codereview.chromium.org/1075014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42302 0039d316-1c4b-4281-b951-d872f2087c98
* Allow Extensions to have MSAA information.mhm@chromium.org2010-03-222-1/+26
| | | | | | | | | | | | | The whole extension shelf and its items were missing MSAA information. Some of them were uninitialized due to the custom components not having any AccessibleRole. Some extensions have no name, this could happen where the user didn't put a name for their browser action in the manifest. If such case happens, we will use the extension name itself. BUG=36289 TEST=Extension shelf now has MSAA information according to Inspect32. Screenshot available on the issue tracker. Review URL: http://codereview.chromium.org/1105008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42289 0039d316-1c4b-4281-b951-d872f2087c98
* views: [accessibility] Add accessible name for the Close button in generic ↵ctguil@chromium.org2010-03-221-1/+5
| | | | | | | | | | | | Window. BUG=9614 TEST=open AccExplorer, open a dialog window, point it to the Close button in the top-right corner, see if it shows Close as the accessible name. Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1155005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42270 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite/clean up a bunch of label.cc to fix the following problems:pkasting@chromium.org2010-03-224-325/+220
| | | | | | | | | | | | | | | | | | * Focus rects on single-line labels could be the wrong height. Turns out SizeStringInt() doesn't adjust the height of a single-line string because it assumes you know your font's height. Passing in a default height of the font height fixed this. * Remove a bunch of confusing code/functions that did totally different things in single- and multi-line mode, and make things handle both modes and do what you'd expect. * Make functions be in the same order in the header and .cc files. * Make several things const. * Simplify. BUG=38679 TEST=Radio buttons in content blocked bubbles do not produce weird-looking focus rects when clicked. The third page of the Options dialog lays out correctly, and checkboxes don't produce too-wide focus rects when clicked. In RTL languages, the Options dialog still looks right, with no string clipping. Review URL: http://codereview.chromium.org/1072007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42256 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Keyboard accessibility for the page and app menus.", rev 42234 and ↵maruel@chromium.org2010-03-2213-214/+18
| | | | | | | | | | 42236. TBR=dmazzoni Review URL: http://codereview.chromium.org/1158004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42239 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-2213-18/+214
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42234 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug with native text field where if there's a visibility change, the ↵chocobo@chromium.org2010-03-223-26/+18
| | | | | | | | | | native control gets recreated without updating the properties. For chromeos login, the password field becomes a normal textfield. BUG=chromeos:2023 TEST=during login, we should not show the password in the clear. Review URL: http://codereview.chromium.org/1076008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42229 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r41641 "Make DevTools open docked by default..."xiyuan@chromium.org2010-03-224-381/+101
| | | | | | | | | | | | | | - Fix DevToolsSanityTest time out. The timeout is because the tests wait for Browser closed notification. However, docked DevTools does not have its own Browser object and hence the wait times out. BUG=none TEST=none Review URL: http://codereview.chromium.org/1025005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42226 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Keyboard accessibility for the page and app menus."maruel@chromium.org2010-03-2213-214/+18
| | | | | | | | | | This reverts commit 42217. TBR=dmzazzoni Review URL: http://codereview.chromium.org/1154003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42218 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-2213-18/+214
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42217 0039d316-1c4b-4281-b951-d872f2087c98
* tweak translate infobar uikuan@chromium.org2010-03-221-1/+5
| | | | | | | | | | | | | | | | - remove button from options menu and only show it on hover - allow MenuButton to be created with or without border for normal state - make font size and color of all labels, buttons and dropdowns black and medium font respectively - extract creation of label into private function to reduce code - use new special image for all menu drop arrows - modify base class MenuButton's menu_marker_ image to a non-const and allow it to be set BUG=38296 TEST=verify per bug report. Review URL: http://codereview.chromium.org/1150002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42210 0039d316-1c4b-4281-b951-d872f2087c98
* Move RTL related functions from app/l10n_util to base/i18n/rtlben@chromium.org2010-03-2017-36/+43
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1073005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42182 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes leak in WidgetGtk::OnWindowPaint.sky@chromium.org2010-03-191-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1155002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42135 0039d316-1c4b-4281-b951-d872f2087c98
* Add ability to show/hide password in login dialog.chocobo@chromium.org2010-03-197-7/+34
| | | | | | | | BUG=none TEST=open login dialog, type in password, and click on the lock image to toggle showing password. Review URL: http://codereview.chromium.org/1113004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42133 0039d316-1c4b-4281-b951-d872f2087c98
* views: Add accessibility support to the Textfield control.ctguil@chromium.org2010-03-192-2/+47
| | | | | | | | | BUG=9619 TEST=open AccExplorer.exe, open bookmarks manager dialog, point it to the search Textfield (edit box) and see it if has the correct information for role (editable text), name (the label within it's connected) and state (read only). Review URL: http://codereview.chromium.org/1058002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42128 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks for login panels:sky@chromium.org2010-03-191-2/+4
| | | | | | | | | | | | | | | . Allows widget to go transparent even if wm says it isn't supported. See comment I added as to why I'm allowing it. . Makes font bold. . Sets property on window so window manager knows chrome has painted. This avoids the gray flash. BUG=none TEST=none Review URL: http://codereview.chromium.org/1149001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42108 0039d316-1c4b-4281-b951-d872f2087c98
* Move text_elider from app/gfx to app/ben@chromium.org2010-03-192-2/+2
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42090 0039d316-1c4b-4281-b951-d872f2087c98
* Move more files to toplevel gfx.ben@chromium.org2010-03-1922-25/+27
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42071 0039d316-1c4b-4281-b951-d872f2087c98
* views: Implement accessibility issue that was a TODO in the new progress bar ↵ctguil@chromium.org2010-03-182-2/+13
| | | | | | | | | | | control. BUG=None TEST=compiles Review URL: http://codereview.chromium.org/930001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42017 0039d316-1c4b-4281-b951-d872f2087c98
* Added actual GoogleUpdate functionality to the OOBE update screen.denisromanov@chromium.org2010-03-182-0/+6
| | | | | | | | | | | Added AddProgress method to the progress bar control. BUG=35249 TEST=Run out/Debug/chrome --login-manager --login-screen=update. Update screen should remain visible for at least 3 seconds. As there is no network available in this mode yet, login wizard should return back to the network selection screen. Review URL: http://codereview.chromium.org/1061004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41920 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41882 - [Accessibility] Chrome's main window is missing an accessible ↵ctguil@chromium.org2010-03-172-4/+0
| | | | | | | | | | | | | | | | name checkdeps.py failed BUG=36732 TEST=Verify Chrome's main window has a name in AccExplorer or run the new test. Review URL: http://codereview.chromium.org/661054 TBR=ctguil@chromium.org Review URL: http://codereview.chromium.org/1063004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41885 0039d316-1c4b-4281-b951-d872f2087c98
* [Accessibility] Chrome's main window is missing an accessible namectguil@chromium.org2010-03-172-0/+4
| | | | | | | | | BUG=36732 TEST=Verify Chrome's main window has a name in AccExplorer or run the new test. Review URL: http://codereview.chromium.org/661054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41882 0039d316-1c4b-4281-b951-d872f2087c98
* Implement selection of rows on mouse clicks in TableView2 for GTK.satorux@chromium.org2010-03-173-2/+29
| | | | | | | | | | | | Before this change, clicking rows in TableView2 for GTK did not select the clicked rows. TEST=manually with view_examples. BUG=none Review URL: http://codereview.chromium.org/1015005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41825 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more files to toplevel gfx dir.ben@chromium.org2010-03-1737-38/+39
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41812 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Make DevTools open docked by default for chrome os."tony@chromium.org2010-03-164-101/+381
| | | | | | | | | | | This reverts commit r41641 because all the devtools interactive_ui_tests are failing. TBR=xiyuan Review URL: http://codereview.chromium.org/1007004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41691 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply r41640.ajwong@chromium.org2010-03-166-3/+57
| | | | | | | | | | Original patch by thiago.farina@gmail.com Revision r41640 was reverted in r41676 because it looked like it might have been responsible for Interactive UI test failures in linux and windows. However, reverting didn't fix, so I'm reapplying it. Review URL: http://codereview.chromium.org/982004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41683 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk views code touch upxiyuan@chromium.org2010-03-163-12/+36
| | | | | | | | | | | | | | | | | - Fix wrong mouse event coordinates in gtk event handlers. Gtk events could be propogate to parent if child does not handle it and we need to translate the coordinates in gtk event in this case; - Consume button pressed event if a widget is not transparent; - Move mouse cursor reset handling on mouse leave from WindowGtk into RootView. This is because once WindowGtk set a mouse cursor, it stucks there and RootView could not change it. BUG=None TEST=Verify the following two cases: 1. Click on top of a tab should not move chrome; 2. Dock devtools and mouse cursor should change correct on the split and change back to left pointer on leave the split; Review URL: http://codereview.chromium.org/997002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41681 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Landing tfarina CL. " because it broke Interactive UI tests on Linux ↵ajwong@chromium.org2010-03-166-57/+3
| | | | | | | | | | and Windows. This reverts r41640. Review URL: http://codereview.chromium.org/1037001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41676 0039d316-1c4b-4281-b951-d872f2087c98
* Provide Web Contents accessibility info.ctguil@chromium.org2010-03-162-1/+25
| | | | | | | | | BUG=36286 TEST=Verify accessibility info in AccExplorer32.exe. Review URL: http://codereview.chromium.org/652199 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41662 0039d316-1c4b-4281-b951-d872f2087c98
* Make DevTools open docked by default for chrome os.xiyuan@chromium.org2010-03-154-381/+101
| | | | | | | | | | | | | | | | | | | | | | | | | | - Change prefs::kDevToolsOpenDocked default to "true" for chrome os; - Fix a problem on chrome os that DevTools occupies the whole client area. This is because BrowserView::Show is called before gtk size allocated event and thus divider offset is calculated wrongly to 0. The fix is to move the "restore split offset" logic to UpdateDevToolsForContents before we do contents_split_ layout for show up DevTools; - Fix a problem that DevTools becomes invisible after undock then dock for linux toolkit_view/chromeos build. This is because browser/views/tab_contents/TabContentsViewGtk does not show/hide its contained TabContents like TabContentsViewWin. As mentioned in BrowserWindowGtk::UpdateDevToolsForContents, the fix is to hook up gtk show/hide signal and notify the contained TabContents about the visibility change. After the fix, remove the manual ShowContents for DevTools in BrowserWindowGtk::UpdateDevToolsForContents. <http://crosbug.com/333> BUG=333 TEST=Verify that DevTools show up as docked by default. Review URL: http://codereview.chromium.org/880003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41641 0039d316-1c4b-4281-b951-d872f2087c98
* Landing tfarina CL. ctguil@chromium.org2010-03-156-3/+57
| | | | | | | | | | | | | Original patch by thiago.farina@gmail.com See original review at: http://codereview.chromium.org/820001/show BUG=9616, 36281 TEST=point AccExplorer to the clear browsing data dialog, every control should be identified and should have the correct values. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41640 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-06-08 01:59:23 +0000