summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Fixes crash in disabling browser action from context menu onsky@chromium.org2010-02-023-5/+33
| | | | | | | | | | | | | | | | views/gtk. The crash occurred because on views we dispatch the menu action immediately (well, after the nested message loop exits), but on windows the action is posted after a delay. The code wasn't written to deal with immediate dispatch, so I changed the gtk code to post a task to dispatch activation. I've also added a warning that menu2 won't work on the stack, which has always been the case, just not stated. BUG=33619 TEST=see bug report. Review URL: http://codereview.chromium.org/557065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37835 0039d316-1c4b-4281-b951-d872f2087c98
* Get the initial selection work. and removed unnecessary initialization.oshima@chromium.org2010-02-024-7/+5
| | | | | | | | | BUG=33609 TEST=added the initial selected item in combobox example. Review URL: http://codereview.chromium.org/567004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37808 0039d316-1c4b-4281-b951-d872f2087c98
* Fix submenu leak in menu2.oshima@chromium.org2010-02-012-10/+34
| | | | | | | | | | | | Added "destroy" signal handler to delete menu2 only when the native gtk widget gets destroyed first. BUG=33475 TEST=chromeos valgrind tests passes without suppression. Review URL: http://codereview.chromium.org/557058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37708 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix linux views, part I don't even know how manypkasting@chromium.org2010-01-301-1/+0
| | | | | | | | | TBR=sky BUG=33314 TEST=none Review URL: http://codereview.chromium.org/558059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37619 0039d316-1c4b-4281-b951-d872f2087c98
* Try to add a useful comment about a case I hit today, at Scott's urging.pkasting@chromium.org2010-01-291-1/+6
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/558031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37554 0039d316-1c4b-4281-b951-d872f2087c98
* Suppressing a known leak erroroshima@chromium.org2010-01-291-0/+1
| | | | | | | | | | | | Seems like this was never executed in the test. TBR=viettrungluu@chromium.org BUG=33475 TEST=valgrind test should cycle green Review URL: http://codereview.chromium.org/553146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37495 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it so deleting a bookmark from the context menu doesn't closesky@chromium.org2010-01-287-24/+108
| | | | | | | | | | | | | the bookmark menu. BUG=2469 TEST=click on a bookmark folder on the bookmark bar, right click on an item and chose delete. Make sure the folder stays up and still works correctly (and the item you deleted isn't there). Review URL: http://codereview.chromium.org/551178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37424 0039d316-1c4b-4281-b951-d872f2087c98
* MoveAbove/SetAlwaysOnTop implementation for WidgetGtkoshima@chromium.org2010-01-271-2/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/548164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37312 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes unintialized read in networkmenu. Menu's constructor calls intosky@chromium.org2010-01-271-0/+6
| | | | | | | | | | | | | the delegate, making using 'this' in the member intializer list for creating a menu problematic. I've changed it to a scoped_ptr and created as needed. BUG=none TEST=none Review URL: http://codereview.chromium.org/552187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37298 0039d316-1c4b-4281-b951-d872f2087c98
* implement infobars and delegates placeholders for translate feature.kuan@chromium.org2010-01-272-64/+84
| | | | | | Review URL: http://codereview.chromium.org/546132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37281 0039d316-1c4b-4281-b951-d872f2087c98
* Add overflow menu to the browser action container (part 2 offinnur@chromium.org2010-01-272-11/+21
| | | | | | | | | | | | | | | | | supporting resize for the container). Also improved RTL support a bit (the divider wasn't drawn on the right side of the container and resizing was reversed). BUG=32101 TEST=Overflow menu for browser action container should now work. Make sure to test also right-clicking on a menu item in the overflow menu to bring up a context menu for that item. And resizing the container in RTL locales should work. Review URL: http://codereview.chromium.org/557006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37232 0039d316-1c4b-4281-b951-d872f2087c98
* Don't emit focus event when moving focus around when re-creating fixed widget.oshima@chromium.org2010-01-271-5/+75
| | | | | | | | | | | | - This fixes the crash in compact navigation bar without a adjustment. - I didn't remove the adjustment because ths is necessary to make the compact navigation bar transparent. (currently, the clipping code assumes that the fixed widget and the actual opaque child have the same side, which is not the case for AutocompleteEditView. BUG=chromium-os:1010 TEST=manual: compact nav bar does not crash. Review URL: http://codereview.chromium.org/548151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37198 0039d316-1c4b-4281-b951-d872f2087c98
* SingleSplitView exampleoshima@chromium.org2010-01-253-0/+89
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/555078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37031 0039d316-1c4b-4281-b951-d872f2087c98
* Resize and overflow for browser actions (part 1).finnur@chromium.org2010-01-223-0/+147
| | | | | | | | | | | | | | | | | | | | | | | | | This changelist implements the following: - A resize gripper and chevron in the browser action container - Overflow when icons don't fit - Snap to multiple of icon size (no excess pixels) - Animation when resizing container / adding&removing icons (disable, enable). - Persists the last width of the browser action container. Known issues: - No menu (yes, the chevron button doesn't do anything yet). BUG=32101 TEST=Install and uninstall browser actions & make sure install bubble appears in the right location. Make sure browser action container does not expand if chevron is showing when you add browser action. Make sure container loses chevron when no overflow occurs. Make sure browser action icons never disappear due to shrinking when you release the mouse (when resizing). Make sure snapping works. Review URL: http://codereview.chromium.org/553039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36905 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where submenus weren't working on views/gtk. Submenus end upsky@chromium.org2010-01-213-12/+52
| | | | | | | | | | | | | creating nested menus. This means that the menu Run is invoked on isn't necessarily the selected menu. I need to push up state to the menu run is invoked on, otherwise nothing happens when a menu is selected. BUG=32662 TEST=see bug Review URL: http://codereview.chromium.org/545142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36782 0039d316-1c4b-4281-b951-d872f2087c98
* submenu exampleoshima@chromium.org2010-01-201-1/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/549101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36663 0039d316-1c4b-4281-b951-d872f2087c98
* Tab-modal dialog improvements:zelidrag@google.com2010-01-151-1/+1
| | | | | | | | | | | | | | | | - treat constrained dialogs as tab-modal - only one shows at the time - added visual indication (tab pulsing) to the tab strip when a tab is blocked by a tab-modal dialog - blocked all UI activity from rendrer host and forced refocusing on constrained (tab-modal) dialogs This CL reverts http://codereview.chromium.org/384113 and instead incorporates the changes from http://codereview.chromium.org/392018. BUG=456,27585,27620 TEST=Go to http://www/~thakis/cgi-bin/test.html, hit esc. Review URL: http://codereview.chromium.org/541056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36415 0039d316-1c4b-4281-b951-d872f2087c98
* Makes WidgetGtk::GetBounds work if the widget_ is NULL (CloseNow hassky@chromium.org2010-01-111-1/+5
| | | | | | | | | | | | been invoked). We need to allow this so that GetBounds works if CloseNow is invoked but the destructor hasn't yet run. BUG=31975 TEST=see bug Review URL: http://codereview.chromium.org/536018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35971 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in WidgetGtk. WidgetGtk::GetBounds can end up crashing. Isky@chromium.org2010-01-081-1/+6
| | | | | | | | | | | | believe returning a location of 0x0 is effectively what Windows does too in this situation. BUG=none TEST=none Review URL: http://codereview.chromium.org/525105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35805 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most uses of EmptyString(), EmptyWString(), EmptyString16(), and ↵pkasting@chromium.org2010-01-081-2/+2
| | | | | | | | | | EmptyGURL(), since the code in question can just use the default constructor. BUG=none TEST=none Review URL: http://codereview.chromium.org/517054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35766 0039d316-1c4b-4281-b951-d872f2087c98
* Raise the window when showing the widget.oshima@chromium.org2010-01-071-1/+4
| | | | | | | | | | | | FindBar is behind other gdk window (i believe the tab content) when re-showing and is not visible. This fixed the issue. BUG=31735 TEST=None Review URL: http://codereview.chromium.org/519082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35752 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in menus on views/gtk. The crash would happen ifsky@chromium.org2010-01-072-5/+21
| | | | | | | | | | | | | | | between the time we called into the model when the user selected an item and the time MessageLoop::Quit is processed the menu was destroyed, we would crash. As MessageLoop::Quit isn't immediate, and we really don't want to call out from a nested message loop, we wait until the quit is processed, then notify the model. CROS_BUG=1108 TEST=see bug Review URL: http://codereview.chromium.org/521063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35746 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts change to native_view_host_gtk. This fixes the bug, but isn'tsky@chromium.org2010-01-071-2/+0
| | | | | | | | | | | | the right fix. Current code is correct. BUG=31132 TEST=none TBR=oshima Review URL: http://codereview.chromium.org/523141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35745 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug that resulted in background tabs not getting sizedsky@chromium.org2010-01-071-1/+3
| | | | | | | | | | | | | correctly. When using fixed like we are we need to explicitly call allocate, otherwise the child won't get a size allocate and correctly update itself. BUG=31132 TEST=see bug Review URL: http://codereview.chromium.org/525093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35719 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two related focus bugs on views/gtk:sky@chromium.org2010-01-073-3/+35
| | | | | | | | | | | | | | . Focus was inadvertently getting cleared when a window was shown because the focus-in event is received asynchronously. . In some situations we get multiple focus-out events in a row, this caused us to clear out who we thought would have focus. BUG=31140, 31130 TEST=see bugs Review URL: http://codereview.chromium.org/521045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35714 0039d316-1c4b-4281-b951-d872f2087c98
* Addded notification when ancestor gets changed. So windows that lack focus ↵georgey@chromium.org2010-01-0711-31/+380
| | | | | | | | | | | | | manager, because of being created on inactive tab, could do the necessary work when focus manager is actually attached. This is relevant for Windows only, but some support functions (FindAllRootViews) could be useful for other architectures as well. BUG=22481 TEST=in the bug Review URL: http://codereview.chromium.org/492025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35675 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a bunch of unnecessary .c_str() calls.pkasting@chromium.org2010-01-061-22/+22
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/527010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35657 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where recreating fixed in NativeViewHostGtk causes focus tosky@chromium.org2010-01-063-2/+46
| | | | | | | | | | | | | get lost. This caused problems when going in/out of fullscreen mode. I'm also improving the description of the WidgetGtk types. CHROMEOS_BUG=1020 TEST=see bug Review URL: http://codereview.chromium.org/518041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35594 0039d316-1c4b-4281-b951-d872f2087c98
* bsds: views/ and webkit/ support for FreeBSD/OpenBSDevan@chromium.org2009-12-312-4/+4
| | | | | | | | | - add a TOOLKIT_USES_GTK #define to catch GTK and Views+GTK - lots of ifdef twiddling Review URL: http://codereview.chromium.org/519030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35402 0039d316-1c4b-4281-b951-d872f2087c98
* linux: reduce header interdependenciesevan@chromium.org2009-12-291-0/+4
| | | | | | | | | | | | By analyzing gcc -H output, I found some of our worst offenders for headers bringing in other headers. native_web_keyboard_event.h was responsible for just under 60,000 extra includes! This change will in theory make the build faster. Review URL: http://codereview.chromium.org/524004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35326 0039d316-1c4b-4281-b951-d872f2087c98
* Clarify licenses on a bunch of files.evan@chromium.org2009-12-291-1/+1
| | | | | | | | | | | In this process, I also filed bugs on various projects we depend on that also have unclear licenses. BUG=28291 Review URL: http://codereview.chromium.org/521009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35323 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash/leak issue in native_view_host_gtk.cc.oshima@chromium.org2009-12-239-15/+40
| | | | | | | | | | | | | | | | * There are two path to NativeViewDetaching and we need to handle them differently. 1) Via gtk destroy signal. In this case, we should not try to remove the native view from parent because it's being deleted. 2) Through NativeViewHost::Detach(). In this case we need to remove the native view from parent because we added it to parent in NativeViewAttached(). * Fix NativeControlGtk not to destroy the native view because it's now destoryed by NativeViewHostGtk. * Fixed TabContentViewGtk so that it owns the nativew view. The native view was destroyed when Detached. * Added more checks so that test can catch regression. BUG=26154 TEST=The same procedure in bug should now pass. I added several checks that lead tests to fail if this problem exists. Review URL: http://codereview.chromium.org/510004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35220 0039d316-1c4b-4281-b951-d872f2087c98
* Add GridLayout::SetInsets(const gfx::Insets& insets).satorux@chromium.org2009-12-232-0/+10
| | | | | | | | | | | | | | | | | Per the style guide, function overloading like this is allowed. http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Function_Overloading#Function_Overloading I wanted this API so I could define and use a constant like: const gfx::Insets kSomeInsets(1, 2, 3, 4); layout->SetInsets(kSomeInsets); BUG=none TEST=try Review URL: http://codereview.chromium.org/509027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35209 0039d316-1c4b-4281-b951-d872f2087c98
* Change chromeos build to use viewsoshima@chromium.org2009-12-221-3/+0
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/508025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35186 0039d316-1c4b-4281-b951-d872f2087c98
* Fix radio items in views::Menu2 for Linux.satorux@chromium.org2009-12-161-0/+10
| | | | | | | | | | | | | | | Suppose there are three radio items A, B, C, and A is now being checked. If you click C, commands associated with A and C are both executed. This is because A also receives the "activate" signal, before C receives it. We want only the command associated with A to get executed. BUG=30310 TEST=try; manually with view_examples Review URL: http://codereview.chromium.org/491076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34644 0039d316-1c4b-4281-b951-d872f2087c98
* Add views/examples/menu_example.hsatorux@chromium.org2009-12-163-1/+209
| | | | | | | | | | | | | The example demonstrates how to create a menu with regular, radio, and check items. The example revealed a bug: http://crbug.com/30310. I have a separate change to fix the bug. TEST=try; manually BUG=30310 Review URL: http://codereview.chromium.org/495017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34640 0039d316-1c4b-4281-b951-d872f2087c98
* Give classes with virtual methods virtual protected destructors instead of ↵jamesr@chromium.org2009-12-162-2/+13
| | | | | | | | | | | | | | | | | | | | | | implicit non-virtual public destructors. Was originally: Replace public nonvirtual destructors in classes with virtual members with protected nonvirtual destructors where possible, and with public virtual destructors where destruction of a derived class occurs. (Excluding chrome/browser/...) (Part 4 of http://www.gotw.ca/publications/mill18.htm has a rationale for why public nonvirtual destructors in classes with virtual members is dangerous.) Patch by: Jacob Mandelson (jlmjln@gmail.com) BUG=none TEST=base_unittests & app_unittests Review URL: http://codereview.chromium.org/200106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34633 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two related bugs:sky@chromium.org2009-12-155-7/+143
| | | | | | | | | | | | | | | | | | | . Native buttons were adding 8 pixels to each side of the preferred size. This isn't necessary on Gtk as the preferred size already includes padding. . I changed WidgetGtk so that it no longer needs to explicitly set a size request. Explicitly setting a size request is a bit of pain because it means you can't ask for the widget real size request without unsetting the explicit size request. Instead I've subclassed GtkFixed so that you can either have the default behavior, or use the allocated size rather than current size. CHROME_OS_BUG=1003 TEST=see bug Review URL: http://codereview.chromium.org/504003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34564 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a hidden dependency from view_examples to chrome on Linux.satorux@chromium.org2009-12-122-2/+1
| | | | | | | | | | | | | We no longer need to build chrome first just for the resource files. Adding a dependency to "packed_resources" is sufficient. TEST=try; locally clean built view_examples on linux BUG=29969 Review URL: http://codereview.chromium.org/487020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34412 0039d316-1c4b-4281-b951-d872f2087c98
* Add views/examples/slider_example.hsatorux@chromium.org2009-12-102-2/+63
| | | | | | | | | | | | | The example demonstrates how to use the Slider class. BUG=none TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34142 Review URL: http://codereview.chromium.org/466055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34223 0039d316-1c4b-4281-b951-d872f2087c98
* A collection of fixes allowing the chrome.experimental.popup.* set of APIs ↵twiz@google.com2009-12-101-1/+3
| | | | | | | | to function in circumstances where there is no Browser instance present. This is a symptom of a tab-contents view hosted in an ExternalTabContainer.The major change here is the removal of the explicit dependency on a Browser instance across all of the delegates involved when showing a pop-up API. I modified the following delegates:- ExtensionPopupHost::Delegate- TabContentsDelegate- ExtensionFunctionDispatcher::DelegateBecause the pop-up requires a Profile, and a gfx::NativeWindow, I added methods to the above interfaces to provide them.BUG=noneTEST=ExtensionApiTest.FLAKY_Popup Review URL: http://codereview.chromium.org/434046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34219 0039d316-1c4b-4281-b951-d872f2087c98
* Uses X mechanisms to get the screen size in the event that there's no window ↵cmasone@google.com2009-12-091-2/+27
| | | | | | | | manager to query. Review URL: http://codereview.chromium.org/460134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34159 0039d316-1c4b-4281-b951-d872f2087c98
* Compute where to place a popup widget in WidgetExample.satorux@chromium.org2009-12-091-1/+12
| | | | | | | | | | | This is to demonstrate how to compute a position. TEST=manually BUG=none Review URL: http://codereview.chromium.org/460104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34149 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34142 - Add views/examples/slider_example.hjrg@chromium.org2009-12-092-57/+1
| | | | | | | | | | | | | | The example demonstrates how to use the Slider class. BUG=none TEST=manually Review URL: http://codereview.chromium.org/466055 TBR=satorux@chromium.org Review URL: http://codereview.chromium.org/467062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34144 0039d316-1c4b-4281-b951-d872f2087c98
* Add views/examples/slider_example.hsatorux@chromium.org2009-12-092-1/+57
| | | | | | | | | | | The example demonstrates how to use the Slider class. BUG=none TEST=manually Review URL: http://codereview.chromium.org/466055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34142 0039d316-1c4b-4281-b951-d872f2087c98
* Spruce up the notification UI to much more closely match the mocks, ↵johnnyg@chromium.org2009-12-052-11/+67
| | | | | | | | | | | | | including a new stylesheet from Glen for text+icon notifications, and little icons for the buttons. Part of the CL includes new features for TextButton class to control icon placement and appearance on hover. BUG=none TEST=notifications Review URL: http://codereview.chromium.org/450045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33899 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in textfield on views/gtk where we weren't properlysky@chromium.org2009-12-042-21/+23
| | | | | | | | | | | | | accounting for border size if not specified by style. Also changes button on views/gtk not to fix the pref height at 29. There is no reason for us to do this. BUG=none TEST=none Review URL: http://codereview.chromium.org/462036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33882 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/466002 for Thiago:sky@chromium.org2009-12-042-5/+5
| | | | | | | | | | | Switch a CSize variable (WTL) to use the gfx::Size type. BUG=2186 TEST=compiles Review URL: http://codereview.chromium.org/466039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33877 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the menu model to live outside views/ so it can be sharedpinkerton@chromium.org2009-12-0420-473/+67
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/465005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33827 0039d316-1c4b-4281-b951-d872f2087c98
* Downward drag after mouse-down is now causing bookmark bar folders to open, ↵zelidrag@google.com2009-12-042-2/+16
| | | | | | | | | | | | | | rather than drag. The bar folder can still be dragged in any other direction. Please note that this change is already reviews in http://codereview.chromium.org/463001, hence TBR field here. I needed to move to a different client to check it in. BUG=9016 TEST=Open bookmark bar. Select folder button and try to drag it down. Observe that now if dragged straight downward, the folder button will open its menu. TBR=sky Review URL: http://codereview.chromium.org/467017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33805 0039d316-1c4b-4281-b951-d872f2087c98