summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Removes accidental gyp change from another cl.sky@chromium.org2009-05-261-2/+0
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/113852 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16900 0039d316-1c4b-4281-b951-d872f2087c98
* Gets a couple of download classes to compile on linux. Updates thesky@chromium.org2009-05-261-2/+2
| | | | | | | | | | | views build so that we only include the gtk classes we need. BUG=none TEST=none Review URL: http://codereview.chromium.org/115788 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16899 0039d316-1c4b-4281-b951-d872f2087c98
* Change the native type passed to Menu to get the system menu. The system menubrettw@chromium.org2009-05-262-2/+2
| | | | | | | | is associated with a window, so it should be a NativeWindow instead of NativeWidget. Review URL: http://codereview.chromium.org/113850 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16895 0039d316-1c4b-4281-b951-d872f2087c98
* Implement IsMinimized() and IsMaximized() for view gtkdavemoore@chromium.org2009-05-252-4/+28
| | | | | | Review URL: http://codereview.chromium.org/115745 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16859 0039d316-1c4b-4281-b951-d872f2087c98
* Gets link to compile on linux.sky@chromium.org2009-05-233-3/+21
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/113797 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16831 0039d316-1c4b-4281-b951-d872f2087c98
* Makes FindBarWin buildable on linux. FindBarWin should be renamed tosky@chromium.org2009-05-235-10/+48
| | | | | | | | | | | FindBarViews, but I'm leaving it as is for now. BUG=none TEST=none Review URL: http://codereview.chromium.org/113793 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16830 0039d316-1c4b-4281-b951-d872f2087c98
* Some more porting of browser_views.brettw@chromium.org2009-05-221-6/+3
| | | | | | Review URL: http://codereview.chromium.org/113794 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16809 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some dependencies on Windows-specific files in BrowserView. The usagebrettw@chromium.org2009-05-222-0/+9
| | | | | | | | of WindowWin was unnecessary so I removed it. I created a function in Menu go get the system menu so that can be ported inside views. Review URL: http://codereview.chromium.org/113785 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16797 0039d316-1c4b-4281-b951-d872f2087c98
* Middle clicking on a bookmark from the bookmark manager nowbrettw@google.com2009-05-222-0/+24
| | | | | | | | | | opens that bookmark in a new foreground tab. http://crbug.com/7788 Checked in for Meelap Shah Original review = http://codereview.chromium.org/115665 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16760 0039d316-1c4b-4281-b951-d872f2087c98
* Parts of my previous changelist didn't make it through.ben@chromium.org2009-05-219-24/+11
| | | | | | | http://crbug.com/11387 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16678 0039d316-1c4b-4281-b951-d872f2087c98
* Add forgotted files from previous change. This makes a semi-cross-platformbrettw@chromium.org2009-05-212-4/+49
| | | | | | keyboard object for implementors of TextField::Controller. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16579 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes toolkit_views build on linux.sky@chromium.org2009-05-211-3/+1
| | | | | | | | | | BUG=none TEST=none TBR=ben Review URL: http://codereview.chromium.org/115604 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16578 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 16567.ben@chromium.org2009-05-219-8/+23
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16575 0039d316-1c4b-4281-b951-d872f2087c98
* views/ should use resources from app/resources. Move dependent images to ↵ben@chromium.org2009-05-219-23/+8
| | | | | | | | | this location. http://crbug.com/11387 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16567 0039d316-1c4b-4281-b951-d872f2087c98
* Minor gtk-views cleanup:sky@chromium.org2009-05-209-23/+177
| | | | | | | | | | | | | . Makes closing widget work. . Makes clicking button send action. . Fixes ownership of native controls. BUG=none TEST=none Review URL: http://codereview.chromium.org/113657 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16532 0039d316-1c4b-4281-b951-d872f2087c98
* Update views deps to reflect new string source.ben@chromium.org2009-05-201-1/+1
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/113658 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16521 0039d316-1c4b-4281-b951-d872f2087c98
* Make views/ use strings from app_strings.ben@chromium.org2009-05-2011-67/+66
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/113612 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16512 0039d316-1c4b-4281-b951-d872f2087c98
* revert this change, svn seems to have committed it with my property-edit.ben@chromium.org2009-05-2011-66/+67
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16509 0039d316-1c4b-4281-b951-d872f2087c98
* Add generated files to svn:ignore list for views subdir.ben@chromium.org2009-05-2011-67/+66
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16508 0039d316-1c4b-4281-b951-d872f2087c98
* Convert views to gyp.ben@chromium.org2009-05-202-915/+291
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/113618 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16490 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TRACK_HWND_CREATION/TRACK_HWND_DESTRUCTION macro since the bug it was ↵jam@chromium.org2009-05-204-24/+0
| | | | | | | | created for has long been closed. This code causes crashes when the browser is closed with the task manager open (in debug builds at the very least). Review URL: http://codereview.chromium.org/115553 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16462 0039d316-1c4b-4281-b951-d872f2087c98
* Adds propagation and handling of render-side focus events, for the benefit ↵klink@chromium.org2009-05-201-4/+0
| | | | | | | | of assistive technologies (accessibility). Also cleans up the handling of WM_GETOBJECT in RenderWidgetHostViewWin and WidgetWin, as well as in BrowserAccessibilityManager. Review URL: http://codereview.chromium.org/115374 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16449 0039d316-1c4b-4281-b951-d872f2087c98
* Fix painting problems that came up after manually calling RedrawWindow on ↵jam@chromium.org2009-05-201-3/+6
| | | | | | | | | | child windows so that we can paint out of process HWNDs asynchronously. The problem is that the function parameter that was passed in to the first RedrawWindow was modified since it's a member variable of the class. OnPaint would empty the rectangle, and so nothing was painted for children. BUG=12010 TEST=unsafe downloads should have their save/discard buttons painted normally. Review URL: http://codereview.chromium.org/115545 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16446 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes delivery of mouse events in WidgetGtk. Also fixes GetRootWidgetsky@chromium.org2009-05-193-52/+156
| | | | | | | | | | | and GetWidget to match windows. BUG=none TEST=none Review URL: http://codereview.chromium.org/113603 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16431 0039d316-1c4b-4281-b951-d872f2087c98
* Removes some dead code from WidgetWin.sky@chromium.org2009-05-192-8/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115528 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16407 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out a BrowserFrame interface, and move the existing Windows-based codebrettw@chromium.org2009-05-195-15/+44
| | | | | | | | | | | to a new class: BrowserFrameWin. The major other change I had to make was the way that the TabStrip is set in the BrowserRootView. Now there is a method on the frame that the view can call when it creats the tabstrip that will set the tabstrip on the root view. Review URL: http://codereview.chromium.org/113511 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16373 0039d316-1c4b-4281-b951-d872f2087c98
* Makes chrome_menu able to compile of Linux (the header that is). I'msky@chromium.org2009-05-182-38/+53
| | | | | | | | | | | | going to do some major surgery to chrome_menu to get the rest compiling on linux. BUG=none TEST=none Review URL: http://codereview.chromium.org/115431 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16281 0039d316-1c4b-4281-b951-d872f2087c98
* Paint dialog frames in maxmized viewglen@chromium.org2009-05-161-3/+6
| | | | | | | | | BUG=12038 TEST=Open the bookmark manager (Ctrl+Shift+B), them maximize it and verify that the titlebar is painted when active and inactive. Review URL: http://codereview.chromium.org/113478 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16238 0039d316-1c4b-4281-b951-d872f2087c98
* Add highlight color support to label text.erikkay@google.com2009-05-153-3/+46
| | | | | | | | | BUG=none TEST=--gtest_filter=LabelTest.* Review URL: http://codereview.chromium.org/113466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16202 0039d316-1c4b-4281-b951-d872f2087c98
* Reland this change. Registers paths for the testing exe, too.ben@chromium.org2009-05-151-1/+0
| | | | | | | | | | Move/Copy paths used by app to app_paths. http://crbug.com/11387 Review URL: http://codereview.chromium.org/115420 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16200 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 16173beng@google.com2009-05-151-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16176 0039d316-1c4b-4281-b951-d872f2087c98
* Move/Copy paths used by app to app_paths.beng@google.com2009-05-151-1/+0
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/113452 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16173 0039d316-1c4b-4281-b951-d872f2087c98
* Displaying consecutive alerts from plugins should not hang the browser. The ↵ananta@chromium.org2009-05-153-3/+14
| | | | | | | | | | | | | | | | | | plugins display alerts via the NPN_Evaluate API. The browser signals an event handle to ensure that the plugin starts peeking for messages while waiting for the NPN_Evaluate call to return. When the dialog is dismissed by the user, windows does send some messages to the plugin window underneath, like activation messages, etc. These don't get dispatched as the event is reset when the dialog is dismissed, i.e. much before the window is actually destroyed. The fix is to reset the event handle after the window is actually destroyed. To achieve this I added an OnClose virtual function to the DialogDelegate interface, which is overridden by the JavascriptMessageBoxDialog class which eventually ensures that the event is reset. This fixes http://code.google.com/p/chromium/issues/detail?id=10799 I updated the AlertInWindowMessage npapi test to display two alerts instead of one. Bug=10799 Review URL: http://codereview.chromium.org/113464 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16172 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeCanvas->gfx::Canvasben@chromium.org2009-05-1557-195/+203
| | | | | | | | | | | Rename files too. TBR=brettw http://crbug.com/11387 Review URL: http://codereview.chromium.org/113443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16148 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFont->gfx::Fontbeng@google.com2009-05-1522-62/+64
| | | | | | | | | | Does not rename the files yet. http://crbug.com/11387 Review URL: http://codereview.chromium.org/113441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16141 0039d316-1c4b-4281-b951-d872f2087c98
* Change the way button width is calculated for the button. Currently, for the ↵jshin@chromium.org2009-05-151-2/+4
| | | | | | | | | | | | | | | | | | | | default button (for which GetDialogButtonLabel returns an empty string), the width is always set to kDialogMinButtonWidth. It's sufficiently large for 'Ok', 'Close' and 'Cancel' in most languages, but not large enough for some languages. For those languages, this CL sets the button width to max(preferred_width, kDialogMinButtoWidth), the former of which is calculated using the translated strings for Ok/Close/Cancel. This needs to be merged to 2.0 branch (the location of views has moved from under chrome\ to the top-level source directory in the trunk) http://crbug.com/11710 TEST: Start Chrome with '--lang=ml' cmd line flag. Open up the option dialog and see 'Close' button at the bottom is large enough for the label ('Close' in Malayalam) and some space around it. Review URL: http://codereview.chromium.org/113250 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16131 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fix issue 11907 -- RTL: Focus is not on the text after checking ↵xji@chromium.org2009-05-141-2/+11
| | | | | | | | | | | "Delete all profile data" Since the text_bounds computed in Label::CalculateDrawStringParams() are different for mutl-line text and single line text. Draw focus rectangle need to be handled differently (mirroring or no mirroring) as well. BUG=http://crbug.com/11907 Review URL: http://codereview.chromium.org/115370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16111 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage... some more traces of always-on-top I forgot to remove.beng@google.com2009-05-142-6/+0
| | | | | | | TBR=jcampan Review URL: http://codereview.chromium.org/114028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16108 0039d316-1c4b-4281-b951-d872f2087c98
* Move Always On Top setting out of Window/WindowDelegate and into task ↵beng@google.com2009-05-149-146/+30
| | | | | | | | | manager. It's the only one who uses this setting and the UI for exposing it is very specific to the task manager. Window retains a setter to set always on top state, but persistence and the system menu is Task Manager's responsbility. This allows us to sever the second-to-last chrome dependency from views. http://crbug.com/11674 Review URL: http://codereview.chromium.org/115378 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16107 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors menus so that I can create a MenuGtk implementation, and moves it intosky@chromium.org2009-05-148-654/+768
| | | | | | | | | | | | the namespace views. BUG=none TEST=make sure I haven't broken any menus. This impacts all menus in Chrome, except bookmark ones. Review URL: http://codereview.chromium.org/113410 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16100 0039d316-1c4b-4281-b951-d872f2087c98
* Add basic checkbox support for GTK.brettw@chromium.org2009-05-143-0/+36
| | | | | | | | This also makes the Checkbox check for the native wrapper just like NativeButton does, to prevent crashes if it hasn't been initialized yet. Review URL: http://codereview.chromium.org/113408 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16094 0039d316-1c4b-4281-b951-d872f2087c98
* Remove even more ATL dependencies.maruel@chromium.org2009-05-1423-88/+112
| | | | | | Review URL: http://codereview.chromium.org/115309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16088 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15832 since this test is finished.hbono@chromium.org2009-05-143-3/+3
| | | | | | | BUG=11046 "Need to back out hbono's test fix" Review URL: http://codereview.chromium.org/112021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16047 0039d316-1c4b-4281-b951-d872f2087c98
* Clean-up of the accelerator code.jcampan@chromium.org2009-05-148-57/+61
| | | | | | | | | | | | | | | The View::CanProcessTabKeyEvents and View::ShouldLookUpAccelerator have both been replaced with a new method, SkipDefaultKeyEventProcessing. This new method provides for a view that has focus a way to prevent a key event from being processed for tab traversal or accelerators. Also, fixed a regression where the Ctrl-Tab accelerator was not working anymore when the omnibox was focused. BUG=11538 TEST=Thoroughly test accelerators, making sure they work when the page, the omnibox and the find-bar text-field have focus. Also test that tab traversal still work as expected in the browser and in the option dialog. Review URL: http://codereview.chromium.org/113307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16037 0039d316-1c4b-4281-b951-d872f2087c98
* Make WidgetWin redraw child windows that are in a different process ↵jam@chromium.org2009-05-141-3/+30
| | | | | | | | | | | asynchronously. This helps with jank (i.e. bug 11701 which I couldn't repro with this) and also with deadlocks (fixes 11421 for painting). BUG=11421,11701 Review URL: http://codereview.chromium.org/115216 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16027 0039d316-1c4b-4281-b951-d872f2087c98
* Move tree-related classes that Linux code depends on from views/ to app/phajdan.jr@chromium.org2009-05-136-502/+1
| | | | | | | | | | TEST=If it compiles and unit_tests pass, it's ok. Just moving files around. http://crbug.com/11066 Review URL: http://codereview.chromium.org/115185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15982 0039d316-1c4b-4281-b951-d872f2087c98
* The dialogs would size their width to their contents (and a minimum size).jcampan@chromium.org2009-05-131-0/+20
| | | | | | | | | | | In some cases, the dialog buttons can be wider than the contents and were clipped. This CL size the dialog to its contents or buttons, whatever is wider. BUG=11855 TEST=Visit pages with alerts/confirm dialogs, make sure dialog are shown properly. Test the case described in the bug. Review URL: http://codereview.chromium.org/115314 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15981 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 15965. I wasn't supposed to check that in since it still doesn't ↵maruel@chromium.org2009-05-1323-99/+75
| | | | | | | | | compile on linux and mac! TBR=sky Review URL: http://codereview.chromium.org/113351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15967 0039d316-1c4b-4281-b951-d872f2087c98
* Remove even more ATL dependencies.maruel@chromium.org2009-05-1323-75/+99
| | | | | | Review URL: http://codereview.chromium.org/115309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15965 0039d316-1c4b-4281-b951-d872f2087c98
* This CL updates chrome to the latest version of skia, retrieved via DEPS, andsenorblanco@chromium.org2009-05-1320-22/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | placed in third_party. All relevant skia changes (for all 3 platforms) have been upstreamed. Most of this CL is mind-numbingly repetitive. Things of interest are: skia.gyp (now points at third_party versions), DEPS, and SkUserConfig.h. stdint.h: Skia now requires C99 integer types, which MSVC doesn't support natively. I have put typedefs in config/win/stdint.h. Note that the new version of skia appears to render rects whose coordinates are "backwards" (ie., x2 < x1 or y2 < y1), which were formerly culled. There were a couple obvious instances of this in the code which I fixed, but there may be more. There were ~35 layout test failures due to minor pixel differences which I rebaselined on Windows and Linux, and 8 genuine failures related to masks and stroked text, which I have put in text_expectations.txt and assigned to myself. (There was another change which broke ~1700 tests on each platform, but I put that change behind an #ifdef for now). R=brettw Review URL: http://codereview.chromium.org/65012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15949 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-10 01:03:06 +0000