summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* views: remove some unnecessary static_cast<int>.maruel@chromium.org2009-11-232-6/+5
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/429004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32837 0039d316-1c4b-4281-b951-d872f2087c98
* Use AutoReset (formerly ScopedBool) where possible.pkasting@chromium.org2009-11-202-4/+4
| | | | | | | | | | This frequently saves a tiny bit of code, but even when it doesn't I think it's more future-proof (less error-prone). BUG=none TEST=none Review URL: http://codereview.chromium.org/399096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32708 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two issues from valgrind, and some cleanup:sky@chromium.org2009-11-204-10/+17
| | | | | | | | | | | | | | | . Makes it so observer installed by WidgetGtk is cleaned up and not leaked. . Removes unnecessary static_cast<int> in view. . Fixes some leaks in textfield and button. . Removes AutocompletePopupViewGTK's copy of PangoFontFromGfxFont. BUG=none TEST=none Review URL: http://codereview.chromium.org/420005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32686 0039d316-1c4b-4281-b951-d872f2087c98
* Making grd dependencies more correct for grds in app.bradnelson@google.com2009-11-201-1/+1
| | | | | | | | | BUG=17706 TEST=None Review URL: http://codereview.chromium.org/414006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32602 0039d316-1c4b-4281-b951-d872f2087c98
* Add examples/widget_example.h to sources of view_examples.satorux@chromium.org2009-11-201-0/+1
| | | | | | | view_examples is just built fine without the line, but good to explicit. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32592 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a comment in views/border.h.satorux@chromium.org2009-11-201-1/+1
| | | | | | | | | | | | | | | | Change views->SetBorder(...) to views->set_border(...). The latter is the right function name in views/view.h: // The border object is owned by this object and may be NULL. void set_border(Border* b) { border_.reset(b); } const Border* border() const { return border_.get(); } BUG=none TEST=none Review URL: http://codereview.chromium.org/405032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32590 0039d316-1c4b-4281-b951-d872f2087c98
* Add views/examples/widget_example.h.satorux@google.com2009-11-192-1/+93
| | | | | | | | | | | | | The example demonstrates how to create a popup widget. BUG=none TEST=manually tested on a linux machine. Review URL: http://codereview.chromium.org/406001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32490 0039d316-1c4b-4281-b951-d872f2087c98
* Add an option to tree_view for whether to show lines from the root nodeian@chromium.org2009-11-182-3/+33
| | | | | | | | | | | | | to children nodes (sets TVS_LINESATROOT). Set this to false by default (maintaining existing behaviour by default), except for cookies_view where we set it to true. BUG=27657 TEST=open cookies dialog, make sure the origins have a + box next to them, and that expanding these also expands the cookies folder beneath them. Review URL: http://codereview.chromium.org/399030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32334 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for BookmarkManager Test Crash test.oshima@chromium.org2009-11-181-1/+5
| | | | | | | | | | | | | | | * Test was failing because the key events were sent even after the window has been destroyed. * Make sure browser window is closed before the end of test. Test fails in BookmarkBarView without this. I think this requires a fix on browser side. Filed a bug 28046. BUG=None Test=run browser_tests --gtest_filter=*Bookmark* Review URL: http://codereview.chromium.org/397034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32286 0039d316-1c4b-4281-b951-d872f2087c98
* Fix race conditions where an object's constructor uses PostTask on itself. ↵jam@chromium.org2009-11-172-4/+9
| | | | | | | | | This isn't safe since the posted task can execute before the constructor returns, leading to destruction of the object. BUG=27944 Review URL: http://codereview.chromium.org/399016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32213 0039d316-1c4b-4281-b951-d872f2087c98
* Remove new tabstrip code. Going to try doing this a different way.ben@chromium.org2009-11-173-264/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/400005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32197 0039d316-1c4b-4281-b951-d872f2087c98
* Make the char encoding indicator visible again on Windowsjshin@chromium.org2009-11-161-1/+2
| | | | | | | | | | | BUG=26438 TEST=Go to any web page and see if the character encoding is indicated in Page menu - Encoding. Patch by Satoshi.Matsuzaki with a slight modification.`(see the bug) Review URL: http://codereview.chromium.org/391066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32064 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 32012-32017mhm@chromium.org2009-11-152-15/+0
| | | | | | | | | | | git cl dcommit somehow committed all my local changes in cygwin TBR=evan BUG=none Review URL: http://codereview.chromium.org/396006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32019 0039d316-1c4b-4281-b951-d872f2087c98
* rebasemhm@chromium.org2009-11-152-0/+15
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32012 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing a bug where the textfield would paint outside of its boundsjcampan@chromium.org2009-11-131-1/+2
| | | | | | | | | | | when scrolled. BUG=26867 TEST=See steps in bug. Review URL: http://codereview.chromium.org/391055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31947 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the build of view_examples for Linux.yusukes@google.com2009-11-131-0/+6
| | | | | | | | | | | | | | TableView and TableView2 are not yet ported to Linux. #ifdef out the related code for Linux. BUG=none TEST=manually built and ran view_examples on Linux Original patch by satorux@chromium.org via: http://codereview.chromium.org/384117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31894 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in treeview. The code for removing a node was notsky@chromium.org2009-11-121-2/+3
| | | | | | | | | | | | | | correctly updating internal data structures, which could lead to a future crash. When recursively deleting items we need to get the next item before removing from the tree, otherwise the tree returns null. BUG=27290 TEST=make sure no problems in using bookmark manager, especially when adding/removing urls/folders. Review URL: http://codereview.chromium.org/384092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31850 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring of the TableView so it uses NativeViewControl.jcampan@chromium.org2009-11-1212-3/+2249
| | | | | | | | | | | | | At this point it does not support grouping or sorting. Mostly refactoring things from TableView to TableView2 and NativeTableWin. BUG=None TEST=Unit-tests and view examples for now. R=sky Review URL: http://codereview.chromium.org/387021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31741 0039d316-1c4b-4281-b951-d872f2087c98
* Landing georgey CL.jcampan@chromium.org2009-11-112-5/+46
| | | | | | | | See http://codereview.chromium.org/384012 Review URL: http://codereview.chromium.org/387028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31717 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for issue 27210, show bookmarks bar menu is out of sync with the ↵oshima@chromium.org2009-11-112-24/+38
| | | | | | | | | | | | | | | | | browser's status. * Update the states of menu before showing menu like Window's menu does. * Don't fire activate signal when the state is chagned via API. * Eliminated UpdateStateData and replace it with the NativeMenuGtk and the position stored in the gtk widget. * Fixed StateAreaView to check bookmark bar status. BUG=27210 TEST=Run linux builds (gtk/views/chromeos) check if the bookmark bar menu's status is in sync with the bookmark bar. Review URL: http://codereview.chromium.org/383012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31654 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 31646.pkasting@chromium.org2009-11-112-16/+13
| | | | | | Review URL: http://codereview.chromium.org/386006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31648 0039d316-1c4b-4281-b951-d872f2087c98
* Try to make widgets clean up after themselves a bit better:pkasting@chromium.org2009-11-112-13/+16
| | | | | | | | | | | * When they get "destroy" window manager messages, clean up internal state so nothing will call into them and in theory someone could re-Init() successfully * When they're deleted, ensure they're also "destroyed" from the window manager point of view BUG=27347 TEST=none Review URL: http://codereview.chromium.org/391010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31646 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in showing bookmark menus where the wrong menu wouldsky@chromium.org2009-11-111-1/+1
| | | | | | | | | | | appear when rtl. BUG=26376 TEST=see bug Review URL: http://codereview.chromium.org/384021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31624 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a couple of missing parts for extensios on linux/views.oshima@chromium.org2009-11-111-2/+3
| | | | | | | | | | | | | | | | * Creating RenderWidgetHostView for gtk * Fix assertion failure in BrowserBubble * Don't change the window size if the size is empty, which causes gtk assertion error. With this change, most of extension tests in browser passes except for toolstrip. Given that toolstrip is obsolete, may be we should just remove it from test. BUG=None TEST=Run browesr_tests. All tests for extension must pass except for ExtensionApiTest.Toolstrip Review URL: http://codereview.chromium.org/390006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31622 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in showing bookmark menu. The problem occurredsky@chromium.org2009-11-102-21/+21
| | | | | | | | | | | | | | when you clicked on one top level menu on the bookmark bar, moused over another menu and then we loaded favicons for the first menu. The code needs to figure out which menu has the icon instead of invoking set icon on menu_. BUG=27067 TEST=make sure bookmark menus work ok. Review URL: http://codereview.chromium.org/388007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31603 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up function ordering in WidgetGtk.ben@chromium.org2009-11-093-239/+235
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/379001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31471 0039d316-1c4b-4281-b951-d872f2087c98
* Fix toolkit_views buildben@chromium.org2009-11-082-6/+7
| | | | | | Review URL: http://codereview.chromium.org/375021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31397 0039d316-1c4b-4281-b951-d872f2087c98
* blind fix for toolkit_viewsben@chromium.org2009-11-073-4/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31395 0039d316-1c4b-4281-b951-d872f2087c98
* Move all the stuff relating to detached tab dragging out of BrowserFrameWin ↵ben@chromium.org2009-11-0710-69/+189
| | | | | | | | and onto the TabStrip2 object. It was mostly cross platform anyway.Adds APIs to Widget that:- allow a Widget to be obtained for a given gfx::NativeView- allow native properties to be set on a Widget.Adds an API to Window that lets the caller convert the window's appearance into a lightly transparent transient looking thing for dragging.BUG=noneTEST=none Review URL: http://codereview.chromium.org/149440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31394 0039d316-1c4b-4281-b951-d872f2087c98
* Fix style issues in View class.maruel@chromium.org2009-11-075-65/+37
| | | | | | | | | | | BUG=None TEST=None Patch contributed by thiago.farina@gmail.com Review URL: http://codereview.chromium.org/338011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31360 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when GetOleInterface returns NULL. The replaced class, ↵jhawkins@chromium.org2009-11-061-2/+4
| | | | | | | | | | CComQIPtr, handles attaching to a NULL pointer, but ScopedComPtr does not, so check for a non-NULL ole_interface before calling QueryFrom. BUG=22829 TEST=none Review URL: http://codereview.chromium.org/374012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31271 0039d316-1c4b-4281-b951-d872f2087c98
* Converting the Cookies options page from a TableView to a TreeViewian@chromium.org2009-11-061-1/+20
| | | | | | | | | | | | so that we can add in Database, LocalStorage, and Appcache next to the cookies for an origin. BUG=26713 TEST=cookies_tree_model_unittest.cc Review URL: http://codereview.chromium.org/365005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31207 0039d316-1c4b-4281-b951-d872f2087c98
* First patch in making destructors of refcounted objects private.jam@chromium.org2009-11-051-0/+4
| | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/360042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31136 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in removing nodes from tree. Specifically if the root is notsky@chromium.org2009-11-041-4/+14
| | | | | | | | | | | | | | | | shown and you remove a node that is a child of the root, we silently fail as there is no tree item for the root. Not having a tree item for a node is typically fine (it usually means it hasn't been expanded), but in this case it's wrong. We need to special case removing from the root here. BUG=26606 TEST=see bug, but also make sure no regression in removing nodes from bookmark manager's tree. Review URL: http://codereview.chromium.org/360021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31022 0039d316-1c4b-4281-b951-d872f2087c98
* While changing the label class I added a DCHECK tofinnur@chromium.org2009-11-041-1/+6
| | | | | | | | | | | | | | | | | | | | | make sure the function I was changing was never called for multiline labels (it never was supposed to work for multiline labels, even before my change). Turns out, this flushed out a caller who calls it for multiline labels, and gets the wrong results. BUG=None TEST=Trigger a javascript alert with multiple lines. Make sure no DCHECK happens. If you set a breakpoint on the function I'm changing and hover over the label, when you step through the code, you'll see that it now correctly computes the bounds of the label based on the width and calls SetContainsMouse with true instead of false. Review URL: http://codereview.chromium.org/361001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30993 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at:sky@chromium.org2009-11-048-17/+13
| | | | | | | | | | | | | | | Gets find bar animation/clipping to work on views/gtk. The only difference between this and the first version is fixing an include in extension_host that was triggering mac to build views, as well as an extraneous SetSlideDuration I had used for testing. BUG=none TEST=none TBR=ben Review URL: http://codereview.chromium.org/342116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30942 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 30903 - Gets find bar animation/clipping to work on views/gtk.sky@chromium.org2009-11-048-13/+17
| | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/340077 TBR=sky@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30913 0039d316-1c4b-4281-b951-d872f2087c98
* Gets find bar animation/clipping to work on views/gtk.sky@chromium.org2009-11-048-17/+13
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/340077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30903 0039d316-1c4b-4281-b951-d872f2087c98
* Fullscreen Exit Bubble should not elide its label.finnur@chromium.org2009-11-031-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | When drawing a Label it is important to adjust for RTL not just when drawing, but also when computing the size of the string. Before this change, we'd compute using Font::GetStringWidth (which uses ::GetTextExtentPoint32 *without* adjusting the string for RTL) and draw using DoDrawText (which adjusts for RTL and then draws using ::DrawText). After this change, we now use SizeStringInt for computing (so we now compute and draw using the same ::DrawText function, thereby adjusting the string for RTL in both cases). BUG=17949 TEST=Run chrome with --lang=he, press F11 and the string in the bubble at the top should not be elided. Review URL: http://codereview.chromium.org/354014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30863 0039d316-1c4b-4281-b951-d872f2087c98
* Remove themes/default.dll and merge the resources into chrome.dll.tc@google.com2009-11-022-1/+2
| | | | | | | | | | | This gives us one less file to load on startup. This does mean that some tests need to explicitly include theme_resources.rc. BUG=24035 Review URL: http://codereview.chromium.org/348033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30755 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression introduced in fixing 19597. This change effectivelysky@chromium.org2009-10-301-2/+6
| | | | | | | | | | | | | | reverts menu_button to what it was before the fix. This way 19597 is still fixed, and we don't have this crash. I'm working on a regression test for coverage of this, but I don't want to hold up anything with the fix. BUG=26279 TEST=see bug Review URL: http://codereview.chromium.org/344043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30651 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tab and button tooltips being truncated with ellipsis.simonrad@chromium.org2009-10-301-2/+4
| | | | | | | | | | | | | | Tooltips were shortened to 1/4 the width of the screen. We do not currently word-wrap, so these tooltips were truncated. This meant that you could not see the full title of some webpages. Worse, the tooltips for the Back and Forward buttons were truncated in some languages. This change increases the max tooltip width to almost the width of the screen. An even better solution would be to word-wrap the text onto multiple lines, but that requires more sweeping changes to the TooltipManagers. R=sky BUG=25522,22840 TEST=Load a webpage with a very long title (eg. Google search for something super long), and mouse over the tab to get a tooltip displaying the webpage title. If long enough, it should stretch across the whole screen (minus a few pixels), and then end with an ellipsis. No tab or button tooltips should be truncated unless they reach screen width. Review URL: http://codereview.chromium.org/343054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30596 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed view example. It was failing because some of view classes requires ↵oshima@chromium.org2009-10-3011-112/+142
| | | | | | | | | | | | | | | | | | WidgetGTK in view hierarchy to call methods on it. * added ContainerExamlpeBase that defers the creation of such views after WidgetGTK available. minor fixes * replaced unnecessary includes with forward decls. * make sure we don't try to set negative hight to viewport. BUG=None TEST=build & run view_examples Review URL: http://codereview.chromium.org/347010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30586 0039d316-1c4b-4281-b951-d872f2087c98
* Gets AutomationProxyVisibleTest.WindowGetViewBounds to pass onsky@chromium.org2009-10-284-30/+65
| | | | | | | | | | | views/gtk. BUG=none TEST=none Review URL: http://codereview.chromium.org/338067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30403 0039d316-1c4b-4281-b951-d872f2087c98
* CompactLocationBar 1st step:oshima@chromium.org2009-10-282-2/+2
| | | | | | | | | | | | | | | | | | | | | * Added OnMouseXXXTab methods to BrowserExtender to handle on tabs. * Changed tab to call above methods. * Added GetSelectedTab to TabStrip Minor changes along with the major changes above * Removed unnecessary file entries in chrome.gyp * Fixed a few method's const. * Removed unnecessary class declarations and includes. Know issue: keyboard focus is not working. In 2nd step, I'm going to eliminate popup and use whatever that FindBar is using to show compact location bar. I'll fix the issue above after this migration. (if it still persists) BUG=None Test=None Review URL: http://codereview.chromium.org/341008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30386 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/291006 for Pierre:sky@chromium.org2009-10-272-3/+7
| | | | | | | | | | | | Open all bookmarks in a bookmark menu folder according to the window disposition derived from the event flags. This is currently only possible with a middle click on the top level bookmark bar button. BUG=19597 TEST=Control click a folder on your bookmark bar, and thorougly test bookmark bar, especially with folders. Review URL: http://codereview.chromium.org/334047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30281 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor widget methods to support desktop notifications, including GTK stubs.johnnyg@chromium.org2009-10-265-12/+68
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/307030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30074 0039d316-1c4b-4281-b951-d872f2087c98
* Assertion failure fixoshima@chromium.org2009-10-261-3/+5
| | | | | | | | | | | | * Closing a submenu was hitting NOTREACHED in OnMenuHidden. * Changed to register OnMenuHidden callback only when we're about to open the menu, then disconnect it when closed. This is safer as the same menu can be used as submenu (although that's probably not great style) Review URL: http://codereview.chromium.org/328002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30061 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it so that when a folder is open on the bookmark bar and thesky@chromium.org2009-10-2614-84/+202
| | | | | | | | | | | | mouse moves over another folder, the menu for that folder is shown. BUG=355 TEST=thorougly test all possible permutations of bookmark menus you can think of, including drag and drop to the menus. Review URL: http://codereview.chromium.org/328012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30049 0039d316-1c4b-4281-b951-d872f2087c98
* Previous change to label caused incorrect layout in Windows.davemoore@chromium.org2009-10-241-6/+1
| | | | | | Review URL: http://codereview.chromium.org/337018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30011 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-22 18:12:34 +0000