| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
to View.
Clean up the API a little. Adds a BoundsChanged() processing function to View that does default processing for bounds-changed events, including notifying the view via OnBoundsChanged() and potentially notifying of visible bounds changing. Adds a unit test for OnVisibleBoundsChanged.
http://crbug.com/72040
TEST=unit test
Review URL: http://codereview.chromium.org/6534001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=RectTest.SkRectToRect
Review URL: http://codereview.chromium.org/6525031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make OnPaint* methods protected.
http://crbug.com/72040
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/6529037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/72040
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/6499030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a first cut at the transformable views. Skia transformation matrices are used to apply transformation (rotate, scale, translation). Support for clipping is also added (but not through the matrix). Currently, the transformation is applied only for painting. A future CL will apply the transformation for various events.
BUG=none
TEST=ViewTest.TransformPaint
Review URL: http://codereview.chromium.org/6500008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
plans.
http://crbug.com/72040
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/6525024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/72040
TEST=existing tests
Review URL: http://codereview.chromium.org/6480076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WM_CHAR is a translated WM_KEYDOWN, so we map it to ui::ET_KEY_PRESSED
http://crbug.com/73006
TEST=see bug
Review URL: http://codereview.chromium.org/6528018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71130
Review URL: http://codereview.chromium.org/6523009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This brings over code from ui/views, and bandaids it into compiling with the existing RootView/Widget interface. It compiles but probably doesn't run, which is OK since no one uses it.
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6523008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
added to the set of available extension APIs.
I also removed some of the plumbing associated with the popup api:
- Drop-shadow support removed from BrowserBubble. This had only been supported on Windows.
- Removed the ExtensionPopup::PopupChrome type. Only popups from the popup API supported rectangle chrome.
- Removed the activate-on-show parameter from ExtensionPopup. This was only used for the popup API. All popups activate on show, by default.
- Removed the AddRef/Release magic from ExtensionPopup. The API required these semantics because of the complex, asynchronous lifetime management required by the popup API. See ExtensionPopup::Observer::ExtensionPopupClosed.
- Removed unneeded methods from ExtensionPopup::Observer, and ExtensionFunctionDispatcher::Delegate.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6334101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25628
TEST=Compile all.sln cleanly
Review URL: http://codereview.chromium.org/6512012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The last references to src/gfx/* have been updated so it's safe to delete the stub headers.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6474031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=tested on Linux desktop
oshima landed for penghuang
Review URL: http://codereview.chromium.org/6480036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for Widget, and will merge the common functionality between NativeWidgetWin and WidgetGtk.
Right now it does nothing other than implement Widget (for compatibility) and the new NativeWidgetListener interface, imported from ui/views/widget. This new interface is the NativeWidget's way of notifying the Widget of events.
Also bring across the NativeWidget interface from ui/views/widget, which will be implemented by NativeWidgetWin in a future changelist.
BUG=72040
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/6510008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6489015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/6510001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary to get context menus working in Pepper.
MenuClosed is called on views+win and native gtk, so this seems like the right thing to do.
BUG=none
TEST=Ran Pepper Flash on a Chrome OS build, made sure context menus work
Review URL: http://codereview.chromium.org/6250098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
After talking to jar, it seems impossible to reliably get a reasonable MSG from Windows given native nested message loops etc. So I am making this do what my prototype did and just generate a synthetic MSG from the information supplied to the WndProc. It turns out this is what ATL does too for its GetCurrentMessage implementation.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6500003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
from the place it was being registered in all cases, so I am moving the message tracking to use the existing widget message loop observer which is added post-window-create. Need to talk to jar/darin about exposing this functionality on MessageLoop.
BUG=none
TEST=views_unittests passes
TBR=sky
Review URL: http://codereview.chromium.org/6474042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=ben@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
some code to use it.
Removes some of the Windows-specific stuff from KeyEvent.
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6487002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This fixes an error clang shows with -Woverloaded-virtual.
BUG=72575
TEST=none
Review URL: http://codereview.chromium.org/6487004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
A few files were missed in a previous refactor (http://codereview.chromium.org/6480001/).
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6488006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The other constants will be moved in future patches.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/6480016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few files were missed in a previous refactor (http://codereview.chromium.org/6480001/).
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6488006
TBR=backer@chromium.org
Review URL: http://codereview.chromium.org/6488012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
A few files were missed in a previous refactor (http://codereview.chromium.org/6480001/).
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6488006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-landing, moving the bits Mac uses to ui/base/events.h
BUG=72040
TEST=none
TBR=sky
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74377
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6480001
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/6469014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6480001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The other constants will be moved in future patches.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/6458014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Flip the direction of submenu arrow for RTL
BUG=chromium-os:5593
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74171
Review URL: http://codereview.chromium.org/6428001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/6459024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ben@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
move PrintViewHierarchy/PrintFocusHierarchy out into a separate header.
BUG=72040
TEST=None
Review URL: http://codereview.chromium.org/6452011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
invert everything.
This fixes the painting bugs in the omnibox and bookmark bar, and probably countless other glitches in rendering.
BUG=none
TEST=omnibox popup should render properly
TBR=sky
Review URL: http://codereview.chromium.org/6462022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also reverted SubmenuView scroll direction change in r73996.
BUG=chromium:72320
TEST=Views scroll should be consistent on all platforms per chromium:72320
Review URL: http://codereview.chromium.org/6453008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 37d4bc610b675ab94dd1d696fbdd474cbfc46208.
TBR=dmazzoni@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/6462006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Flip the direction of submenu arrow for RTL
BUG=chromium-os:5593
TEST=none
Review URL: http://codereview.chromium.org/6428001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
then press escape (with space still down) and release we end up
notifying the delegate twice. The first the time the delegate is
notified causes some action so that the second time through we end up
crashing (delegate deleted). The fix is to only notify delegate once.
BUG=71940
TEST=see bug
Review URL: http://codereview.chromium.org/6429001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
No one used the non-RTL version of GetBounds(), so I renamed it GetMirroredBounds() and got rid of the enum.
Same for GetX(), consolidated with MirroredX() into GetMirroredX().
GetPosition() already took into account mirroring, so renamed GetMirroredPosition() for symmetry.
Renamed the other functions to be getters. De-inlined a few that were doing complex looking stuff.
http://crbug.com/72040
TEST=none
Review URL: http://codereview.chromium.org/6334152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=wheel scrolling doesn't work
TEST=wheel scrolling scrolls the page when possible
Review URL: http://codereview.chromium.org/6250195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The other constants will be moved in future patches.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/6250186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SetBounds(const gfx::Rect& rect) -> SetBoundsRect();
DidChangeBounds()->OnBoundsChanged()
GetLocalBounds(false)->GetLocalBounds()
GetLocalBounds(true)->GetContentsBounds()
Moved GetBounds(), GetX(), and GetPosition into RTL section.
http://crbug.com/72040
TEST=none
Review URL: http://codereview.chromium.org/6410109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=run out/Debug/views_examples, everything should works as before.
Review URL: http://codereview.chromium.org/6368122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mouse wheel scrolling eventually calls each MenuItemView's
GetPreferredSize for every row moved. This change added a preferred
size cache to make it more efficient.
Also flipped scroll direction to be consistent with the scrolling direction in other places.
BUG=chromium-os:11057
TEST=Verify mouse wheel scrolling is smooth per chromium-os:11057.
Review URL: http://codereview.chromium.org/6368105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73996 0039d316-1c4b-4281-b951-d872f2087c98
|