summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Move functions from skia/ext to app/gfx where possible: most of skia_utils.* ↵pkasting@chromium.org2009-09-241-7/+6
| | | | | | | | | | | | | and image_operations.* can be moved because they are not used by WebKit code. This also fixes the spelling of "Convolusion" to "Convolution" and updates some copyrights. This is a re-do of r26975, this time with WebKit update and some fixes to compile on Mac and Linux. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27031 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor window impl of scroll bar for future linux implementation.oshima@chromium.org2009-09-238-327/+544
| | | | | | | | | | | | | | | | | - Changed NativeScrollBar to use native wrapper - Added NativeScrollBarWapper for NativeScrollBar to delegate operations to native control. - Moved window specific impl in NativeScrollBar to NativeScrollBarWin class which is a native wrapper. - Fixed a bug in native_control_win. need to call Layout when view visibility is changed after native contol is created. BUG=none TEST=none Review URL: http://codereview.chromium.org/214048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27013 0039d316-1c4b-4281-b951-d872f2087c98
* Implements file contents support in OSExchangeData and DropTargetsky@chromium.org2009-09-234-27/+37
| | | | | | | | | | | | | for gtk. Makes html and file contents support in OSExchangeData only for windows (as that is the only place we need it), and makes dragging files work. BUG=none TEST=none Review URL: http://codereview.chromium.org/232002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26995 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 26975.pkasting@chromium.org2009-09-231-6/+7
| | | | | | Review URL: http://codereview.chromium.org/222011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26979 0039d316-1c4b-4281-b951-d872f2087c98
* Move functions from skia/ext to app/gfx where possible: most of skia_utils.* ↵pkasting@chromium.org2009-09-231-7/+6
| | | | | | | | | | | | and image_operations.* can be moved because they are not used by WebKit code. This also fixes the spelling of "Convolusion" to "Convolution" and updates some copyrights. BUG=none TEST=none Review URL: http://codereview.chromium.org/207059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26975 0039d316-1c4b-4281-b951-d872f2087c98
* removing unnecessary invocations of super class constructoroshima@chromium.org2009-09-232-4/+2
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/220012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26963 0039d316-1c4b-4281-b951-d872f2087c98
* Add icon support to gtk menu items.chocobo@google.com2009-09-231-4/+16
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/227005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26958 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for a focus related NOTREACHED when closing Chromejcampan@chromium.org2009-09-231-4/+9
| | | | | | | | | | | | | | | | | A focus related asserion was hit when closing Chrome. It was caused by the top level widget being destroyed and deleting itself before its children. When deleted it would delete the focus manager without giving child widgets a chance to remove focus change listener causing the assert. We now delay the deletion of the WidgetGtk so child widget get the destroy message when the top WidgetGtk is still alive. BUG=None TEST=Close Chrome toolkit views. It should not assert because of the focus manager. Review URL: http://codereview.chromium.org/231003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26952 0039d316-1c4b-4281-b951-d872f2087c98
* More examples:oshima@chromium.org2009-09-235-4/+287
| | | | | | | | | | | MessageBox, TabbedPane and RadioButton BUG=none TEST=none Review URL: http://codereview.chromium.org/214053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26937 0039d316-1c4b-4281-b951-d872f2087c98
* Implements a couple of NOTIMPLEMENTEDs in window_gtk and comments onsky@chromium.org2009-09-223-17/+16
| | | | | | | | | | | why we're not going to implement some. BUG=none TEST=none Review URL: http://codereview.chromium.org/207057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26864 0039d316-1c4b-4281-b951-d872f2087c98
* Implements a NOTIMPLEMENTED in GoButton.sky@chromium.org2009-09-223-0/+14
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/216045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26832 0039d316-1c4b-4281-b951-d872f2087c98
* Fix code to get widget position on screen.chocobo@google.com2009-09-221-12/+12
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/215053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26829 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling a focus related unit test on Linux (toolkit_views).jcampan@chromium.org2009-09-221-6/+4
| | | | | | | | | | | | This test fails when the screen is locked. BUG=None TEST=None TBR=nsylvain Review URL: http://codereview.chromium.org/214052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26813 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling label unittest on linuxoshima@chromium.org2009-09-221-1/+26
| | | | | | | | | | | | * disabled a few conditions that are failing on linux. I'll look into more detail after it is checked in (including whether or not it really has to be fixed). * added ariel FontProperty test with Ariel font, which seems to be available on linux. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26795 0039d316-1c4b-4281-b951-d872f2087c98
* Fix possible null pointer dereference.mattm@chromium.org2009-09-221-1/+2
| | | | | | | | | CID=6295 BUG=none Review URL: http://codereview.chromium.org/216041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26789 0039d316-1c4b-4281-b951-d872f2087c98
* View examples:oshima@chromium.org2009-09-228-1/+381
| | | | | | | | I'm planning to move these to unit_test using Jay's testing framework, but let's check in it first, and then I will refactor and move them to unittest. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26780 0039d316-1c4b-4281-b951-d872f2087c98
* Decolated window support in WidgetGtk. oshima@chromium.org2009-09-222-6/+11
| | | | | | | Will be used primarily for testing. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26778 0039d316-1c4b-4281-b951-d872f2087c98
* When adding a TabbedPane to anther TabbedPane at 2nd place or later,oshima@chromium.org2009-09-193-35/+85
| | | | | | | | | | a wrapper is not created b/c the content is added to the hieracy only when the content is visible. This cause a crash when a tab is added to this child tabbed pane. This CL fix this case. Review URL: http://codereview.chromium.org/211018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26645 0039d316-1c4b-4281-b951-d872f2087c98
* Fix BrowserFrameWin::OnMoving bad_override coverity error.mattm@chromium.org2009-09-181-1/+1
| | | | | | | | BUG=17104 Review URL: http://codereview.chromium.org/208019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26633 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Chexkbox::SetLabel on windows, which uses view's label instead ofoshima@chromium.org2009-09-183-1/+10
| | | | | | | | native one. Review URL: http://codereview.chromium.org/208018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26632 0039d316-1c4b-4281-b951-d872f2087c98
* Home/End were being forwarded to the page from the find box.finnur@chromium.org2009-09-181-2/+3
| | | | | | | | | BUG=22271 TEST=Open find-in-page on a page that contains a vertical scrollbar. Press Home and End and the page should not scroll. Review URL: http://codereview.chromium.org/209036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26612 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/211002 for Charlie:sky@chromium.org2009-09-176-0/+458
| | | | | | | | | | | | Add touchpad speed factor setting to Chrome OS touchpad settings page. Created slider widget with native gtk widget. TEST=none BUG=none Review URL: http://codereview.chromium.org/209016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26511 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing lame bug in radiobutton. oshima@chromium.org2009-09-161-1/+1
| | | | | | | | | The UsesNativeRatioButtonGropu condition was inverse. RadioButton should use its own grouping logic when native grouping is not used. (on windows) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26411 0039d316-1c4b-4281-b951-d872f2087c98
* Land http://codereview.chromium.org/206025 for Charlie:sky@chromium.org2009-09-163-4/+10
| | | | | | | | | | | | Fix settings page transparent background issue Also comment out focus manager check due to bug: http://crbug.com/21378 TEST=none BUG=none Review URL: http://codereview.chromium.org/194128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26370 0039d316-1c4b-4281-b951-d872f2087c98
* Force inclusion of build/common.gypi for all chromium gyp files.yaar@chromium.org2009-09-151-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | Why: Simpler build code. If everybody includes it, it should be included automatically. Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi. What was done: 1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi 2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi. 3. lots of gyp files were fixed to not refer to build/common.gypi any more. 4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too. 5. build/common.gypi was left empty, because there are some external projects that still refer to it. Things that are left to do after this patch is in: 1. The following external files (in other repositories) need to stop include common.gypi ./third_party/hunspell/hunspell.gyp ./third_party/icu/icu.gyp ./v8/tools/gyp/v8.gyp 2. Once nobody refers to common.gypi anymore, delete common.gypi -or- Delete gyp_chromium.gypi and move its content back to common.gypi Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify. Review URL: http://codereview.chromium.org/206006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26302 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/193032 for Charlie:sky@chromium.org2009-09-153-13/+20
| | | | | | | | | | | | | | | First pass at adding ChromeOS settings - a mock wifi selector combobox - touchpad settings that makes calls to synclient - on startup, touchpad settings are initialized to what's stored in preferences TEST=none BUG=none Review URL: http://codereview.chromium.org/203073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26259 0039d316-1c4b-4281-b951-d872f2087c98
* Removes some dead NOTIMPLEMENTEDs and enables some code that no longersky@chromium.org2009-09-141-1/+0
| | | | | | | | | | | needs to be ifdef'd out. BUG=none TEST=none Review URL: http://codereview.chromium.org/196111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26177 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes the focus remembered across tab switches for Chrome Linux with ↵jcampan@chromium.org2009-09-144-5/+41
| | | | | | | | | | | | | | | toolkit views. It also contains clean-ups and implementation of different minor focus related things. BUG=None TEST=Open several tabs. Focus the location bar for some tabs, the page for others. Make sure that when switching between tabs the focus is restored to the last focused place (location bar or page) for each tab. Also test that deactivating/reactivating the browser window still restores focus properly. Review URL: http://codereview.chromium.org/194041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26153 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up a few tiny things I noticed.pkasting@chromium.org2009-09-141-2/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/196110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26144 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts linux font change again. Slow down isn't as bad as before. Butsky@chromium.org2009-09-142-2/+6
| | | | | | | | | | | | still not ideal. BUG=none TEST=none TBR=agl Review URL: http://codereview.chromium.org/194105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26141 0039d316-1c4b-4281-b951-d872f2087c98
* The focus is not restored properly when a Windows modal dialogjcampan@chromium.org2009-09-142-1/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (such as "open file', 'print'...) is closed. We are running these dialogs from a different thread and they cause the browser window to get activated before it has been enabled. This causes the focus restoration to fail as the window is not enabled. In an earlier patch, I fixed it by storing/restoring the focus explicitly before/after the dialog is shown. But the fix did not apply to the print dialog which does not use the code I added my fix in. This CL reverts that previous fix and comes with a simpler solution: if when we are about to restore focus the window is disabled, we delay the focus restoration untill the window is enabled again. BUG=3380 TEST=Set the focus on a page with scroll-bars, right-click to do a 'save as'. Close the dialog. The arrow keys should let you scroll the page. Accelerators such as Ctrl-T should still work. Test 'open a file', 'print' and the font selection dialog (in the options). When closing the dialog the focus should return to the view that last had focus. Review URL: http://codereview.chromium.org/199106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26135 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/201102 for Oshima:sky@chromium.org2009-09-142-0/+4
| | | | | | | | | | | | | Don't allow updating group id once it's set. BUG=none TEST=none Review URL: http://codereview.chromium.org/205001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26132 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/200102 for Oshima:sky@chromium.org2009-09-147-27/+166
| | | | | | | | | | | | | | RadioButton implementation. - gtk implementation uses gkt's grouping mechanism, which was hard to replace. A small refactoring. - changed to use virtual functions instead of if/IsCheckbox - Removed checkbox's CallClicked BUG=none TEST=none Review URL: http://codereview.chromium.org/194102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26117 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at converting font from Skia to Pango. The slow down appears to be ↵sky@chromium.org2009-09-142-6/+2
| | | | | | | | | | | | entirely attributed to asking for the metrics. To get back the performance I did the following: . Only ask for the metrics when needed. We appear to create 6 or so fonts very early on without needing the metrics. This ensures we only take the metrics load hit when needed. . Keep a cache of the metrics around. This ensures that we only load the metrics once. I didn't dig through the Pango source to see why Pango is slow at getting metrics. I suspect it's the first person to ask for metrics incurs a penalty as Pango accesses the disk. The code we have now is the same as that as Gtk. Review URL: http://codereview.chromium.org/199101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26116 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts r26015. It caused a startup regression:(sky@chromium.org2009-09-112-2/+6
| | | | | | | | | | BUG=20823 TEST=none TBR=agl Review URL: http://codereview.chromium.org/203041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26030 0039d316-1c4b-4281-b951-d872f2087c98
* Nukes font_skia and converts font_gtk to use pango. This wassky@chromium.org2009-09-112-6/+2
| | | | | | | | | | | | | | | | | | | | | | necessitated by Pango and Skia differing on how the fonts are sized, resulting in lots of clipping in views. The only iffy part of this is I've made Font::nativeFont() win/mac only (it isn't used on Linux). I did this to avoid folks accidentally modifying the underlying font out from under Font. That said, I could certainly nuke GetPangoFontDescription in favor of nativeFont() and make it return the PangoFontDescription (not a copy). Let me know if you feel strongly about converting this. Assuming your ok with this, I'll watch the perf tests to make sure this doesn't impact startup. BUG=20823 TEST=none Review URL: http://codereview.chromium.org/195058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26015 0039d316-1c4b-4281-b951-d872f2087c98
* Removes an extraneous NOTIMPLEMENTED in native_control_gtk.sky@chromium.org2009-09-101-1/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/202051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25938 0039d316-1c4b-4281-b951-d872f2087c98
* Landing oshima patch.jcampan@chromium.org2009-09-102-0/+11
| | | | | | | | | | | Disable NOTREACHED assertion for Linux. A view in WidgetGtk with TYPE_CHILD crashes at this assertion. A bug http://crbug.com/21335 is filed to keep track of this. BUG=None TEST=None Review URL: http://codereview.chromium.org/195056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25919 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/194014 for Oshima:sky@chromium.org2009-09-104-9/+64
| | | | | | | | | | | | | | | * enable MessageBoxView convert wstring to string16 when necessary using WideToUTF16Hack, which is no-op on Windows. * updated checkbox to get state update working state handing is a bit hacky, esp. b/c gtk sends signal even when the state is changed via API. If there is better way, please let me know. BUG=none TEST=none Review URL: http://codereview.chromium.org/201079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25896 0039d316-1c4b-4281-b951-d872f2087c98
* Use Scoped[Bstr,ComPtr,Variant] instead of their ATL equivalents to reduce ↵jhawkins@chromium.org2009-09-107-15/+22
| | | | | | | | | | dependencies on ATL. BUG=5027 TEST=none Review URL: http://codereview.chromium.org/200045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25879 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at implementation of FindBar for views / gtkdavemoore@chromium.org2009-09-099-66/+136
| | | | | | | Also had to implement change notification for TextField on views / gtk Review URL: http://codereview.chromium.org/200035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25819 0039d316-1c4b-4281-b951-d872f2087c98
* Use base::WindowImpl instead of CWindowImpl to remove a dependency on ATL.jhawkins@chromium.org2009-09-091-14/+9
| | | | | | | | BUG=5027 TEST=none Review URL: http://codereview.chromium.org/199070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25817 0039d316-1c4b-4281-b951-d872f2087c98
* Use base::WindowImpl instead of CWindowImpl to remove a dependency on ATL.jhawkins@chromium.org2009-09-091-62/+38
| | | | | | | | BUG=5027 TEST=none Review URL: http://codereview.chromium.org/199067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25799 0039d316-1c4b-4281-b951-d872f2087c98
* Use gfx::Point instead of GET_X/Y_LPARAM to reduce a dependency on ATL.jhawkins@chromium.org2009-09-092-14/+10
| | | | | | | | BUG=5027 TEST=none Review URL: http://codereview.chromium.org/195035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25788 0039d316-1c4b-4281-b951-d872f2087c98
* Use RECT instead of CRect to reduce dependencies on ATL.jhawkins@chromium.org2009-09-091-20/+22
| | | | | | | | BUG=5027 TEST=none Review URL: http://codereview.chromium.org/195036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25780 0039d316-1c4b-4281-b951-d872f2087c98
* Implements WindowGtk::CloseAllSecondaryWindows.sky@chromium.org2009-09-094-16/+30
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/197063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25768 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/198010 for Oshima:sky@chromium.org2009-09-092-5/+14
| | | | | | | | | | | | * Fix seg fault in deleting view from RemoveTabAtIndex * move initialization of tabbed page to NativeControlCreated TEST=none BUG=none Review URL: http://codereview.chromium.org/196055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25730 0039d316-1c4b-4281-b951-d872f2087c98
* Replace icu38/icu38.gyp with icu/icu.gyp in gyp files replace all the ↵jshin@chromium.org2009-09-091-2/+2
| | | | | | | | | | | | | | | | | | references to third_party/icu38 and icudt38.dll with third_party/icu and icudt42.dll in vsprops and cc files. Also, update the icu data module name and the icu data symbol in icu_util.cc In addition, add a dummy C++ source file (xmldummy_mac.cc) to libxml to work around an Xcode bug (xmllint and xmlcatalog are linked with gcc rather than g++ even though it's linked to a "C++ library", libicuuc.a). Also updated is the test results for net_util_unittests. This will not be landed until deps/third_party/icu42 is ready for all 3 platforms (Windows VS build files are not yet updated there). BUG=8198 TEST=On all platforms, all the targets are built fine. Review URL: http://codereview.chromium.org/172031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25708 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up drag and drop for bookmark menus and cleans up a couple ofsky@chromium.org2009-09-098-27/+67
| | | | | | | | | | | minor painting issues. BUG=none TEST=none Review URL: http://codereview.chromium.org/199050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25701 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit deps 48155:48185 and remove a couple of passing tests from ↵japhet@chromium.org2009-09-082-8/+9
| | | | | | | | | | | | | | | test_expectations.txt. Also, merge in http://codereview.chromium.org/174367 (original author: vandebo@chromium.org), which is the downstream half of r48168. BUG=4360 BUG=21228 BUG=18792 TEST=none TBR=eroman git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25669 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 17:41:56 +0000