summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Attempt at fixing leaks from SetProp. Apparently there is a finitesky@chromium.org2010-11-019-49/+87
| | | | | | | | | | | | | | | | | | amount of memory reserved for properties and Windows doesn't always automatically free up the memory if the window is deleted without an explicit remove. For the time being I've made it easier to track SetProp leaks, but we may want to move to using something other than SetProp in the future that isn't as fragile. I didn't fix a couple of places that were trickier. I'm going to file separate bugs on them. BUG=44991 TEST=none Review URL: http://codereview.chromium.org/4195003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64619 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent needless vertical margin change.altimofeev@chromium.org2010-10-301-1/+2
| | | | | | | | | | | | When one change horizontal margin, vertical margin is also changed to zero. BUG=chromium-os:8081 TEST=none Review URL: http://codereview.chromium.org/4151012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64550 0039d316-1c4b-4281-b951-d872f2087c98
* Adds GtkLabel to GtkButton to allow font changing.altimofeev@chromium.org2010-10-301-6/+16
| | | | | | | | | BUG=chromeos:8234 TEST=none Review URL: http://codereview.chromium.org/4136006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64549 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Add Ctrl-/ accelerator for help app.derat@chromium.org2010-10-291-1/+9
| | | | | | | | | | | | | | This adds Ctrl-/ and Ctrl-Shift-/ (Ctrl-?) accelerators for the help command in Views GTK, updates the help URL for Chrome OS, and makes us print "/" explicitly in accelerator descriptions instead of "slash" (the string we get from GDK). BUG=chromium-os:7835 TEST=built and ran it Review URL: http://codereview.chromium.org/4156004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64495 0039d316-1c4b-4281-b951-d872f2087c98
* Make icon-text spacing configurable.oshima@chromium.org2010-10-292-7/+15
| | | | | | | | | | | | This is to implement shutdown button on login/locker screen, which has wider icon-text spacing 10 than 5. See crosbug.com/974 for the mock. BUG=chromium-os:974, chromium-os:5763 TEST=none Review URL: http://codereview.chromium.org/4192004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64475 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove base/gtk_util.h by moving its methods tojhawkins@chromium.org2010-10-291-2/+1
| | | | | | | | | | | gfx/gtk_util.h BUG=none TEST=none Review URL: http://codereview.chromium.org/4150006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64348 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add Shutdown button to login/locker screen."oshima@chromium.org2010-10-282-15/+7
| | | | | | | | | | | This reverts commit c2bafbefa8022337ba9520fd9a2f64fd2cd4c52f. BUG=none TEST=build bot should cycle green Review URL: http://codereview.chromium.org/4119015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64282 0039d316-1c4b-4281-b951-d872f2087c98
* Add Shutdown button to login/locker screen.oshima@chromium.org2010-10-282-7/+15
| | | | | | | | | | | * cleaned up code that are no longer in use. BUG=chromium-os:5763 TEST=maual. pressing shutdown button on login/locker will shutdown the system. Review URL: http://codereview.chromium.org/4054001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64272 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Relanding - Fix UI issues on SignIn/user pod.nkostylev@chromium.org2010-10-281-1/+1
| | | | | | | | | | | | | | | | | | Original CL: http://codereview.chromium.org/4179001/show 7. Textfield - focus border issue 9. Textfield - font size 11. Sign in - h padding 13,14 Link text & color. Button minimal width - 90px. BUG=chromium-os:8101 TEST=manual Review URL: http://codereview.chromium.org/4156005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64242 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64225 - [cros] Fix UI issues on SignIn pod/user pod.jochen@chromium.org2010-10-281-1/+1
| | | | | | | | | | | | | | | | | | | 7. Textfield - focus border issue 9. Textfield - font size 11. Sign in - h padding 13,14 Link text & color. Button minimal width - 90px. BUG=chromium-os:8101 TEST=manual Review URL: http://codereview.chromium.org/4179001 TBR=nkostylev@chromium.org Review URL: http://codereview.chromium.org/4189005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64227 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Fix UI issues on SignIn pod/user pod.nkostylev@chromium.org2010-10-281-1/+1
| | | | | | | | | | | | | | | | 7. Textfield - focus border issue 9. Textfield - font size 11. Sign in - h padding 13,14 Link text & color. Button minimal width - 90px. BUG=chromium-os:8101 TEST=manual Review URL: http://codereview.chromium.org/4179001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64225 0039d316-1c4b-4281-b951-d872f2087c98
* Convert ElideUrl to return a string16 instead of a wstring.tony@chromium.org2010-10-271-1/+2
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/4115003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64156 0039d316-1c4b-4281-b951-d872f2087c98
* Grab keyboard input when showing domui/views menu.oshima@chromium.org2010-10-272-16/+21
| | | | | | | | | | BUG=chromium-os:8118 TEST=manual: open more than 2 windows, then open wrench menu and hit alt-tab. It will not switch to other window. Review URL: http://codereview.chromium.org/4189002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64103 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: Directly process key and mouse events.rjkroege@google.com2010-10-2614-279/+274
| | | | | | | | | | | | | | | | Capture the keyboard and mouse events directly from X, create a corresponding views::Event out of it, and send it to the associated RootView. Includes Chad's (wyck) function FindRootViewForGdkEvent (from #3704005) slightly modified (called FindRootViewForGdkWindow). BUG=None TEST=Click/Keypress events in a webpage should work correctly. Review URL: http://codereview.chromium.org/3801011 Patch from Sadrul Chowdhury <sadrul@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63916 0039d316-1c4b-4281-b951-d872f2087c98
* Update gtk/menu2 without closing menuoshima@chromium.org2010-10-261-8/+15
| | | | | | | | | | | | | | | * ResetMenu now simply remove all menu items. * This will closes all submenus opened. It require a lot more work to update submenus correctly. Since there is no scenario that requires this so this is good enough for our use case. BUG=chromium-os:8106 TEST=manual: on chromeos device, open network menu and change network settings. (plug-unplug ethernet) Review URL: http://codereview.chromium.org/4120002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63899 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where we would some times not layout when we needed to.sky@chromium.org2010-10-251-3/+8
| | | | | | | | | BUG=59720 TEST=see bug Review URL: http://codereview.chromium.org/3960004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63793 0039d316-1c4b-4281-b951-d872f2087c98
* Menu crash fix for domui/gtk menu that is caused by multiple context menu ↵oshima@chromium.org2010-10-225-2/+114
| | | | | | | | | | | | | | | | | | | requests. Renderer may issue multiple ContextMenu request even if the menu is open.(this happenes when renderer receives mouse events before context menu is actually opened by previous request.) This is causing a crash in menu2 (both domiu/gtk impl) because menu2 has nested message loop, and the menu object gets deleted by 2nd request while it's handling message loop. This CL addresses this issue by creating separate object to handle the nested loop. Use only variables on stack and do not touch instance variable if the menu is already deleted. BUG=chromium-os:7929, chromium-os:7228 TEST=manual. on a page, continously click mouse to open/close context menu. It used to crash at some point, but shouldn't crash with this patch. Review URL: http://codereview.chromium.org/4046004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63576 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63478 - Adds CHECKs in hopes of figuring out why we're crashing on ↵sky@chromium.org2010-10-221-8/+3
| | | | | | | | | | | | | | | | some test bots. BUG=44991 TEST=none Review URL: http://codereview.chromium.org/3992005 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/4028002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63480 0039d316-1c4b-4281-b951-d872f2087c98
* Adds CHECKs in hopes of figuring out why we're crashing on some testsky@chromium.org2010-10-221-3/+8
| | | | | | | | | | | bots. BUG=44991 TEST=none Review URL: http://codereview.chromium.org/3992005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63478 0039d316-1c4b-4281-b951-d872f2087c98
* Some cleanup of view accessibility and view accessibility wrapper.ctguil@chromium.org2010-10-2210-373/+132
| | | | | | | | | | | | | | | 1. Remove the ViewAccessibilityWrapper class. The view can directly manage it's ViewAccessibility. 2. Always use GetAccessibleForView to retrieve a view's associated accessibility object. This ensures that the correct accessibility object is returned for native view host objects. 3. Update get_accFocus to use FocusManager. 4. Move oleacc guid definitions to view_win.cc. BUG=none TEST=interactive_ui_tests:BrowserViewsAccessibilityTest.TestBrowserRootViewAccObj TEST=Manual: I can select the accessibility object of a native view host within AccExplorer32.exe. Review URL: http://codereview.chromium.org/4047001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63451 0039d316-1c4b-4281-b951-d872f2087c98
* Convert gfx::ElideText from using wstrings to string16.tony@chromium.org2010-10-212-2/+5
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/3885003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63433 0039d316-1c4b-4281-b951-d872f2087c98
* Make the Windows location bar send accessibility events to thedmazzoni@chromium.org2010-10-214-2/+24
| | | | | | | | | | | | accessibility extension API on Windows. This adds a few more accessibility events to views accessibility while we're at it. BUG=none TEST=none Review URL: http://codereview.chromium.org/3999001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63394 0039d316-1c4b-4281-b951-d872f2087c98
* Hijack mouse-related events for TOUCH_UI buildsbryeung@google.com2010-10-216-7/+307
| | | | | | | | | | | | | | | | | | With this change, which is specifically for TOUCH_UI builds, mouse-related messages are hijacked from the normal Gdk event dispatcher and processed manually in the file touchui/touchui.cc. GdkEvents are converted directly to views events, and dispatched to the RootView. This is preliminary work that will be followed by more elaborate message pump changes, and ultimately is in the spirit of removing Gtk entirely for TOUCH_UI (Chromium-Views-Gtk). Patch from Chad Faragher <wyck@chromium.org> BUG=none TEST=none Review URL: http://codereview.chromium.org/3704005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63368 0039d316-1c4b-4281-b951-d872f2087c98
* Make the Downloads Shelf keyboard-accessible (via F6) and accessible todmazzoni@chromium.org2010-10-212-1/+4
| | | | | | | | | | | | | screenreaders. Rename AccessibleToolbarView to AccessiblePaneView to reflect that it covers more than just toolbars. Also add infobars to the F6 pane traversal. BUG=372 TEST=none Review URL: http://codereview.chromium.org/3722004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63358 0039d316-1c4b-4281-b951-d872f2087c98
* Return the IAccessible interface of the deepest descent that contains the ↵ctguil@chromium.org2010-10-201-39/+16
| | | | | | | | | | | | | | | | speficied point in view accessibility's accHitTest. Previously accHitTest would 1. Only return a direct child that contained the specified point (accHitTest was called repeatedly until it returned CHILDID_SELF). 2. Always return a VT_I4 variant for a view that has no children instead of returing an IAccessible interface (which didn't work with the AT programs for some reason). BUG=none TEST=Manual: NVDA reads views on mouse overwith no children on mouse over like toolbar buttons. TEST=Manual: AccExplorer32 and Inspect32 can select views with no children. Review URL: http://codereview.chromium.org/3890003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63273 0039d316-1c4b-4281-b951-d872f2087c98
* Convert LOG(INFO) to VLOG(1) - views/.pkasting@chromium.org2010-10-205-71/+19
| | | | | | | | | | This also removes DEBUG_MENU. I don't think the extra ints are a big deal. They should be optimized away in release mode. Also fixes a spelling error and converts some silly code to using early returns. BUG=none TEST=none Review URL: http://codereview.chromium.org/3908004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63150 0039d316-1c4b-4281-b951-d872f2087c98
* Makes NativeFrameView implement GetPreferredSize. Without this wesky@chromium.org2010-10-186-14/+40
| | | | | | | | | | | | | | | | | | | don't correctly return a preferred/minimum size and the options dialog can end up getting clipped (because the cached size is too small). Also, makes the options window always use the minimum size when showing. This way if we happen to remove an option such that the dialog is smaller the dialog won't end up too big. BUG=59122 TEST=With aero enabled bring up the options dialog on M6/M7. Then bring up the options dialog with this fix enabled and make sure you don't get any clipping. Review URL: http://codereview.chromium.org/3825006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62937 0039d316-1c4b-4281-b951-d872f2087c98
* Move BaseDropTarget and BaseDragSource from base to app/win. Remove the ↵brettw@chromium.org2010-10-173-7/+7
| | | | | | | | | | "Base" class name prefix and put in the app::win namespace. TEST=none BUG=none Review URL: http://codereview.chromium.org/3822007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62900 0039d316-1c4b-4281-b951-d872f2087c98
* Move windows version-related stuff out of base/win_util and into ↵brettw@chromium.org2010-10-154-7/+9
| | | | | | | | | | | | | | base/win/windows_version. Many files now only need to include this instead of all of win_util. Remove a bunch of unused code from base/win_util. There was a surprising amount. Replace the AppUserModel property key with the one from the SDK now that we use the Win7 SDK. Move GetLogonSessionOnlyDACL from win_util to ipc since it's only used in that one place. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62694 0039d316-1c4b-4281-b951-d872f2087c98
* [Win] Enable groups in list views when updating groups.bauerb@chromium.org2010-10-141-2/+4
| | | | | | | | | | | It seems ListView_RemoveAllGroups disables groups on Win XP, so we re-enable them afterwards. BUG=55452 TEST=Group headers in table views should be visible on XP Review URL: http://codereview.chromium.org/3760002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62516 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move SplitString functions into the base namespace and update the callers.tfarina@chromium.org2010-10-141-1/+1
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3750001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62483 0039d316-1c4b-4281-b951-d872f2087c98
* The start of the instant opt-in mocks.sky@chromium.org2010-10-082-5/+14
| | | | | | | | | | | I also had to make it so you can turn off animations in CustomButton. BUG=54833 TEST=none Review URL: http://codereview.chromium.org/3544015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62009 0039d316-1c4b-4281-b951-d872f2087c98
* Add CreateWrapper to views/examples/examples_base.ccstevenjb@chromium.org2010-10-061-0/+17
| | | | | | | | | | | Necessary for view_examples to compile with GYP_DEFINES="chromeos=1". BUG=http://code.google.com/p/chromium-os/issues/detail?id=7409 (temporary fix) TEST=build all in chrome repo with chromeos=1 Review URL: http://codereview.chromium.org/3614008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61691 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes another gray rect. This problem occurred because NativeViewHostsky@chromium.org2010-10-061-0/+2
| | | | | | | | | | | | | | was not correctly resetting state when the child was switched. In particular it wouldn't remove the clip when switching, which meant that if we switched back to an hwnd we had installed a clip we wouldn't reset the clip when we should have. BUG=57573 TEST=see bug Review URL: http://codereview.chromium.org/3605010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61688 0039d316-1c4b-4281-b951-d872f2087c98
* Use BubbleWindow for JSModalDialogViews on ChromeOS.xiyuan@chromium.org2010-10-051-1/+1
| | | | | | | | | | | | Also make BubbleWindow title left aligned per mock and fix wrong background color for DialogClientView by setting bg color to widget style. BUG=chromeium-os:6305 TEST=Verify js dialog on chrome os is in new bubble look again. Review URL: http://codereview.chromium.org/3598008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61522 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in wrench menu where closing with menu open could triggersky@chromium.org2010-10-051-0/+1
| | | | | | | | | | | crash. BUG=56842 TEST=see bug Review URL: http://codereview.chromium.org/3552008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61474 0039d316-1c4b-4281-b951-d872f2087c98
* Only enable renderer accessibility when an active screen reader is detected.ctguil@chromium.org2010-10-051-1/+1
| | | | | | | | | BUG=55902 TEST=Renderer accessibility is not enabled on stock windows tablets. Review URL: http://codereview.chromium.org/3575013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61460 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI implementation of Menu2.oshima@chromium.org2010-10-041-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | A few key design points. * Uses DOMView to render menu content. * MenuUI (subclass of DOMUI) uses GtkWiget tree to access WidgetGtk and MenuModel. Alternative way was to change TabContents::GetDOMUIForCurrentState() public and pass them throught it, but this seems to work fine. * Input/Focus is controlled by gtk_grab_add. Input is grabbed by the root widget, and then sent to each active menu widget via gtk_grab_add. * Menu gets shown after the renderer rendered the content (thus has some size) to avoid showing small/empty menu. Mouse processing is blocked until the menu is shown (see Dispatcher). A few issues that will be addressed in separate CL * RTL (will be after beta) * menu scroll. working on it now. * menu sometimes show scroll bar. (I just need to disable it) * unit test for native_menu_domui BUG=chromiun-os:6497 TEST=manual for now. all menu2 based meus should work as before (web pages's context menu, system menu, forward/back menu and several chromeos specific one) except for following two: * mnemonic should work now on context menus. * menu larger than screen does not scroll. I'll implement this in separate CL Review URL: http://codereview.chromium.org/3442018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61445 0039d316-1c4b-4281-b951-d872f2087c98
* Remove mnemonic and add keyboard shortcut text to the accessible name of ↵ctguil@chromium.org2010-10-013-21/+38
| | | | | | | | | | | | | text buttons in the wrench menu. Add breaks to GetAccessibleState switch statements. BUG=51738 TEST=Verify in NVDA and JAWS that text buttons are read without mnemonic and with keyboard shortcut. Review URL: http://codereview.chromium.org/3612001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61201 0039d316-1c4b-4281-b951-d872f2087c98
* Working on removing GTK for touch UI, by introducing a newanicolao@chromium.org2010-09-301-0/+6
| | | | | | | | | | | | | | | RenderWidgetHostViewViews class to replace RenderWidgetHostViewGtk in the case of TOUCH_UI. This change shouldn't affect non-TOUCH_UI builds and is not yet complete for a number of event types and corner cases, but is sufficient to get in so that work on the touch keyboard and touch events can proceed in parallel with GTK removal. BUG=none TEST=none Review URL: http://codereview.chromium.org/3415005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61118 0039d316-1c4b-4281-b951-d872f2087c98
* Make the first-run search engine choice dialog accessible todmazzoni@chromium.org2010-09-303-1/+25
| | | | | | | | | | | Windows screenreaders. BUG=none TEST=manual testing with and without JAWS and NVDA screenreaders. Review URL: http://codereview.chromium.org/3598003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61090 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor RadioButton Image code for linux/gtkoshima@chromium.org2010-09-294-76/+124
| | | | | | | | | | | so that DOMUI menu can use the same image. BUG=none TEST=none Review URL: http://codereview.chromium.org/3435033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60972 0039d316-1c4b-4281-b951-d872f2087c98
* Add SetMinimumWidth to Menu2 for chromeos.oshima@chromium.org2010-09-297-0/+20
| | | | | | | | | | | | | This is to remove gtk dependency from menu2 code in chromeos and to make DOMUI transition smooth (crosbug.com/6497) Removed LanguageSwitchModel::GetFirstLevelMenuWidth as this does not seem to be used by anyone. BUG=none TEST=none Review URL: http://codereview.chromium.org/3533001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60961 0039d316-1c4b-4281-b951-d872f2087c98
* Allow chrome to be customized for screen reader users.ctguil@chromium.org2010-09-297-8/+54
| | | | | | | | | | | Add Widget::IsAccessibleWidget() that will return true when Chrome can be customized screen reader users. BUG=37357,55902 TEST=JAWS or NVDA users have "(Incognito)" in their window title. Tablet users are unaffected. Review URL: http://codereview.chromium.org/3427026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60888 0039d316-1c4b-4281-b951-d872f2087c98
* Make accessible getters return values instead of accepting an output ↵ctguil@chromium.org2010-09-2853-297/+157
| | | | | | | | | | | parameter. GetAccessibleName still needs to be converted. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/3416033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60828 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor AppModalDialog to more clearly isolate platform specific UI pieces ↵ben@chromium.org2010-09-281-0/+2
| | | | | | | | | | | and eliminate the dependency on individual frontends from cross platform code. BUG=none TEST=none Review URL: http://codereview.chromium.org/3398015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60785 0039d316-1c4b-4281-b951-d872f2087c98
* Set WidgetGtk.delegate_ = NULL in CloseNow() to fix chromium-os:5604.stevenjb@google.com2010-09-271-2/+4
| | | | | | | | | BUG=http://code.google.com/p/chromium-os/issues/detail?id=5604 TEST=Ensure opening and closing widgets behaves normally. Check for further crashes in WidgetGtk::IsActiveChanged(). Review URL: http://codereview.chromium.org/3452025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60668 0039d316-1c4b-4281-b951-d872f2087c98
* Append "(Incognito)" to the accessible title of the browser window.ctguil@chromium.org2010-09-273-4/+10
| | | | | | | | | | | This actual window title remains the same. BUG=37357 TEST=Screen readers read "Incognito" for browser windows that are off the record. Review URL: http://codereview.chromium.org/3400028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60658 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r60342.dtseng@chromium.org2010-09-242-0/+6
| | | | | | | TBR=dmazzoni. Review URL: http://codereview.chromium.org/3444021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60474 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 45091.hbono@chromium.org2010-09-241-1/+5
| | | | | | | | | | This change checks the states of ctrl and shift keys when proceesing acclerators to prevent FocusManager from consuming ctrl+alt keys and shift+alt keys. Windows sends SC_KEYMENU commands not only when we type only an alt key but also when we type ctrl+alt keys and shift+alt keys, both are used for changing input languages and keyboard layouts. To prevent these keys from being accidentally consumed by FocusManager, we check the states of these keys and send them to FocusManager. BUG=45091 TEST=interactive_ui_tests.exe --gtest_filter=KeyboardAccessTest.TestShiftAltMenuKeyboardAccess. Review URL: http://codereview.chromium.org/3318022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60433 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-01 07:49:19 +0000