summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* wstring: remove wstring functions from base/i18n/rtl.hevan@chromium.org2011-04-252-5/+7
| | | | | | | | | | And update callers. BUG=23581 Review URL: http://codereview.chromium.org/6883140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82924 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Change status button menu"saintlou@chromium.org2011-04-256-37/+7
| | | | | | | | | | | This reverts commit d73c5c63912ce402c82777bee1ec8f1a31544d9f. BUG=none TEST=none Review URL: http://codereview.chromium.org/6904003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82906 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move LinkController into its own header file.tfarina@chromium.org2011-04-256-38/+45
| | | | | | | | | | | | | | | | | | | While I'm here, did some changes: - Rename the LinkController interface to LinkListener. - Move the interface to link_listener.h - Rename the event from LinkActivated to LinkClicked. - Changed the get/set accessors to listener()/set_listener(). - Add OVERRIDE to LinkClicked methods. BUG=None TEST=None R=sky@chromium.org Review URL: http://codereview.chromium.org/6881099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82885 0039d316-1c4b-4281-b951-d872f2087c98
* views: Add Link example.tfarina@chromium.org2011-04-254-0/+82
| | | | | | | | | | | | BUG=None TEST=compile with toolkit_views=1, run out/Debug/views_examples. You should see a link tab, and a link with "Click me!" and make sure it works. R=oshima@chromium.org,sky@chromium.org Review URL: http://codereview.chromium.org/6883122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82870 0039d316-1c4b-4281-b951-d872f2087c98
* Fix painting glitch by suppressing non-client painting for WindowWins only ↵ben@chromium.org2011-04-243-3/+20
| | | | | | | | | | | when resizing, and forcing a NCPaint after the size/move ends. http://crbug.com/79640 TEST=classic mode, see bug Review URL: http://codereview.chromium.org/6897031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82804 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82751 - Add NativeWidgetDelegate/Widget::OnKeyEvent post-IME ↵msw@chromium.org2011-04-2211-45/+87
| | | | | | | | | handling.Refactor XEvent code and InputMethodGtk::DispatchKeyEvent.Nix WidgetWin::GetFocusedViewRootView, rename RootView::OnKeyEvent.Cleanup headers and refactor code in extension_input_api.cc.BUG=72040TEST=Key event handling in win/linux_views/touch; extension input API SendKeyboardEventInputFunction use.Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82713Review URL: http://codereview.chromium.org/6823055 TBR=msw@chromium.org Review URL: http://codereview.chromium.org/6897033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82752 0039d316-1c4b-4281-b951-d872f2087c98
* Add NativeWidgetDelegate/Widget::OnKeyEvent post-IME handling.msw@chromium.org2011-04-2211-87/+45
| | | | | | | | | | | | | | | Refactor XEvent code and InputMethodGtk::DispatchKeyEvent. Nix WidgetWin::GetFocusedViewRootView, rename RootView::OnKeyEvent. Cleanup headers and refactor code in extension_input_api.cc. BUG=72040 TEST=Key event handling in win/linux_views/touch; extension input API SendKeyboardEventInputFunction use. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82713 Review URL: http://codereview.chromium.org/6823055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82751 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting since caused compile failures on Linux.amit@chromium.org2011-04-2210-41/+83
| | | | | | | | Revert 82713 - Add NativeWidgetDelegate/Widget::OnKeyEvent post-IME handling.Refactor XEvent code and InputMethodGtk::DispatchKeyEvent.Nix WidgetWin::GetFocusedViewRootView, rename RootView::OnKeyEvent.Cleanup headers and refactor code in extension_input_api.cc.BUG=72040TEST=Key event handling in win/linux_views/touch; extension input API SendKeyboardEventInputFunction use.Review URL: http://codereview.chromium.org/6823055 TBR=msw@chromium.org Review URL: http://codereview.chromium.org/6894035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82718 0039d316-1c4b-4281-b951-d872f2087c98
* Add NativeWidgetDelegate/Widget::OnKeyEvent post-IME handling.msw@chromium.org2011-04-2210-83/+41
| | | | | | | | | | | | | Refactor XEvent code and InputMethodGtk::DispatchKeyEvent. Nix WidgetWin::GetFocusedViewRootView, rename RootView::OnKeyEvent. Cleanup headers and refactor code in extension_input_api.cc. BUG=72040 TEST=Key event handling in win/linux_views/touch; extension input API SendKeyboardEventInputFunction use. Review URL: http://codereview.chromium.org/6823055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82713 0039d316-1c4b-4281-b951-d872f2087c98
* Change status button menu (ClockMenu, NetworkMenu, PowerMenu) implementation ↵rhashimoto@chromium.org2011-04-226-7/+37
| | | | | | | | | | | | | | | | from Menu2 to MenuItemView. This required modifying MenuItemView to support per-item fonts, which are needed to display the currently associated network in boldface. This CL depends on http://codereview.chromium.org/6870016/ to work properly on the ChromeOS login screen. BUG=chromium-os:13887 TEST=none Review URL: http://codereview.chromium.org/6811025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82676 0039d316-1c4b-4281-b951-d872f2087c98
* Add SubmenuView::magic_token_ and checks.msw@chromium.org2011-04-224-26/+53
| | | | | | | | | | | | | | | Add MenuHostRootView::destroyed_flag_ and check. May help identify the cause of crbug.com/78792. Minor refactoring / code consolidation. BUG=78792 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82385 Review URL: http://codereview.chromium.org/6879059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82596 0039d316-1c4b-4281-b951-d872f2087c98
* Select on slave pointers instead of master pointers.saintlou@chromium.org2011-04-211-5/+7
| | | | | | | | | BUG=80193 TEST=none Review URL: http://codereview.chromium.org/6891005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82544 0039d316-1c4b-4281-b951-d872f2087c98
* remove unused classsaintlou@chromium.org2011-04-219-554/+0
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6880081 Patch from Emmanuel Saint-Loubert <saintlou@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82488 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the set_delete_on_destroy setter now that we have CreateParams.ben@chromium.org2011-04-216-51/+54
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6883104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82486 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82385 - this might be breaking the interactive_ui_tests on windows ↵nsylvain@chromium.org2011-04-214-51/+25
| | | | | | | | | | | and browser_tests on windows. The blamelist is big, so this is a guess. Original description: Add SubmenuView::magic_token_ and checks.Add MenuHostRootView::destroyed_flag_ and check.May help identify the cause of crbug.com/78792.Minor refactoring / code consolidation.BUG=78792TEST=noneReview URL: http://codereview.chromium.org/6879059 TBR=msw@chromium.org Review URL: http://codereview.chromium.org/6882117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82466 0039d316-1c4b-4281-b951-d872f2087c98
* Adds widget_delegate.cc to appease the clang bot.sky@chromium.org2011-04-203-5/+35
| | | | | | | | | | | R=ben@chromium.org TBR=ben@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/6878085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82391 0039d316-1c4b-4281-b951-d872f2087c98
* Add SubmenuView::magic_token_ and checks.msw@chromium.org2011-04-204-25/+51
| | | | | | | | | | | | | Add MenuHostRootView::destroyed_flag_ and check. May help identify the cause of crbug.com/78792. Minor refactoring / code consolidation. BUG=78792 TEST=none Review URL: http://codereview.chromium.org/6879059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82385 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors login window widget creation methods into platform specific methods.sky@chromium.org2011-04-2011-41/+51
| | | | | | | | | | BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6877064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82384 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the device list is kept up-to-date.sadrul@chromium.org2011-04-203-19/+53
| | | | | | | | | | | | A device can be loaded at times after chrome has already started. So make sure the list of devices is kept up-to-date. BUG=none TEST=none Review URL: http://codereview.chromium.org/6877061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82316 0039d316-1c4b-4281-b951-d872f2087c98
* Maintain the list of devices all in one place.sadrul@chromium.org2011-04-203-16/+137
| | | | | | | | | | | | This effectively moves a bunch of code from the message-pump to the touch-factory. This way, the list of devices is maintained in one place. BUG=none TEST=none Review URL: http://codereview.chromium.org/6882083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82307 0039d316-1c4b-4281-b951-d872f2087c98
* Revert workaround. This was problematic because it is relyingsaintlou@chromium.org2011-04-201-5/+1
| | | | | | | | | | | | on an unrelated constant (kFavicon) which now has a different value for the touch case. BUG=none TEST=none Review URL: http://codereview.chromium.org/6879053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82294 0039d316-1c4b-4281-b951-d872f2087c98
* Removing unused class. Deprecated when we moved to web ui prefssaintlou@chromium.org2011-04-206-371/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6877065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82293 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the overview classes not to subclass WidgetGtk.sky@chromium.org2011-04-201-0/+2
| | | | | | | | | | BUG=none TEST=none R=gspencer@chromium.org,ben@chromium.org Review URL: http://codereview.chromium.org/6878056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82287 0039d316-1c4b-4281-b951-d872f2087c98
* Centralizes checking for non-null return from CreateWindow.sky@chromium.org2011-04-1912-8/+33
| | | | | | | | | | BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6880034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82137 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing menu crashes. I'm trying to fix three things:sky@chromium.org2011-04-192-8/+44
| | | | | | | | | | | | | | | | . Its possible the hook function may end up getting invoked when open_native_menu_win_ is NULL. . If ~NativeMenuWin runs before the menu has closed, we crash. . Delays notifying model until using a task after the nested message loop returns. This better matches what WM_MENUCOMMAND does. BUG=79810 TEST=none, make sure menus on windows haven't regressed. R=ben@chromium.org Review URL: http://codereview.chromium.org/6879020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82107 0039d316-1c4b-4281-b951-d872f2087c98
* Add extra touch information and related API to views::TouchEvent.miletus@chromium.org2011-04-186-34/+231
| | | | | | | | | | | | | | | | | | | Some touch devices provide, other than (x,y) location, extra touch information. views::TouchEvent is changed to keep track of touch radius, touch angle and ratio between major and minor touch axis. To be able to query what extra touch data is supported by the device, bookkeeping of the device supported TouchParams is added to views::TouchFactory. Next step will be routing these touch information to WebKit. BUG= TEST= Review URL: http://codereview.chromium.org/6820004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81963 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some infobar drawing glitches:pkasting@chromium.org2011-04-161-0/+1
| | | | | | | | | | | * Glass mode popups used the wrong separator color, making the arrow look weird * The stroke/fill were not being drawn quite correctly due to some subtle AA-related issues BUG=none TEST=none Review URL: http://codereview.chromium.org/6875017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81846 0039d316-1c4b-4281-b951-d872f2087c98
* Removes code added to track down crash. The crash seems to havesky@chromium.org2011-04-156-103/+2
| | | | | | | | | | | | | | | | | | | | occurred for two reasons: . window class name changing out from under us. . CreateWindow returning NULL because we're out of memory. I've changed the following: . Left in CHECK on return from CreateWindow. . Removed dependency on class name. We don't really need it anyway. I've also changed View::PaintFocusableBorder to check focusable last, as that requires looking up the FocusManager BUG=77651 TEST=none Review URL: http://codereview.chromium.org/6865023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81812 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing bug where occassionally clicks on context menus aresky@chromium.org2011-04-152-36/+97
| | | | | | | | | | | | | | | | dropped. I believe this is a bug in windows, and I'm just working around it. The work around is to extend the hook function we have to watch for LBUTTONUP events over menu items, exit the menu and notify the model, in effect doing our own mouse processing. BUG=5212 TEST=thoroughly test context menus to make sure you don't get any weird behavior. R=ben@chromium.org Review URL: http://codereview.chromium.org/6861003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81696 0039d316-1c4b-4281-b951-d872f2087c98
* Call OnVisibleBoundsChanged on the view itself as well as child views.oshima@google.com2011-04-141-0/+5
| | | | | | | | | | | This fixes crosbug.com/14079 BUG=chromium-os:14079, chromium-os:79269 TEST=none Review URL: http://codereview.chromium.org/6837010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81641 0039d316-1c4b-4281-b951-d872f2087c98
* Make the usage stats checkbox on EULA screen speak and focus.chaitanyag@chromium.org2011-04-141-0/+1
| | | | | | | | BUG=chromium-os:14128 TEST=Test manually, see issue 14128 Review URL: http://codereview.chromium.org/6852008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81636 0039d316-1c4b-4281-b951-d872f2087c98
* Some style changes (for readability).sadrul@chromium.org2011-04-143-8/+11
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6675048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81623 0039d316-1c4b-4281-b951-d872f2087c98
* Prefer UTF8 strings over ASCII strings when requesting text from azork@chromium.org2011-04-141-9/+9
| | | | | | | | | | | | | drag and drop operation BUG=chromium-os:12275 TEST=Manual Review URL: http://codereview.chromium.org/6825035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81523 0039d316-1c4b-4281-b951-d872f2087c98
* Adds yet more debugging code.sky@chromium.org2011-04-131-1/+16
| | | | | | | | | | BUG=77651 TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6834006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81363 0039d316-1c4b-4281-b951-d872f2087c98
* Pull content from TabContentsViewViews into NativeTabContentsViewWin.ben@chromium.org2011-04-127-0/+32
| | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6824060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81328 0039d316-1c4b-4281-b951-d872f2087c98
* step 3 of native theme refactoringrogerta@chromium.org2011-04-124-89/+81
| | | | | | | | | | | | | | Moved all calls to old menu drawing api to new NativeTheme::Paint(). Moved all calls to old push/radio/check button api to new NativePaint::Paint(). BUG=None TEST=Affects windows platform only. All menus in chrome, such as wrench menu, should look and behave as before, with no change. All pushbuttons, radiobuttons, and checkbox in web page forms should look and behave as before. Review URL: http://codereview.chromium.org/6825007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81257 0039d316-1c4b-4281-b951-d872f2087c98
* Adds more debugging code in hopes of figuring out a crash. Most commonsky@chromium.org2011-04-112-3/+6
| | | | | | | | | | | | | | | | reason for crash appears to be because we can't find the WindowWin for an hwnd. I'm also removing a comment that is no longer relevant, and nuking a call in window_win to ui::SetWindowUserData that is already done in WindowImpl. BUG=77651 TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6825045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81150 0039d316-1c4b-4281-b951-d872f2087c98
* touch: identity for a finger is an int, not a bool.sadrul@chromium.org2011-04-111-1/+1
| | | | | | TBR=rjkroege@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81141 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Fix compile by initializing a variable.sadrul@chromium.org2011-04-111-1/+1
| | | | | | TBR=rogerta@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81139 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmitting change because original caused build breaks:rogerta@chromium.org2011-04-116-0/+507
| | | | | | | | | | | | | | | | | - clang build requires destructor in complex classes - chromeos build requires newline at end of files Adding a native theme painter, to allow Views to use NativeTheme to draw their background. Added example code to show it in use. I still have not hooked this into any existing View-based controls. BUG=None TEST=None R=ben@chromium.org Review URL: http://codereview.chromium.org/6820007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81128 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable FREEZE_UPDATE propertyoshima@google.com2011-04-113-5/+66
| | | | | | | | | | | | | | | This is a real fix for 13750. When the entire area of a WidgetGtk is covered by another GdkWindow, the WidgetGtk doesn't get expose event, which was causnig 13750. This fixes this issue by listening child widget's expose event and remove the FREEZE_UPDATE property. BUG=chromium-os:11514, chromium-os:13750 TEST=see bug for repro steps R=sky@chromium.org Review URL: http://codereview.chromium.org/6823017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81123 0039d316-1c4b-4281-b951-d872f2087c98
* Adds more debugging code in hopes of figuring out a crash. Sorry forsky@chromium.org2011-04-084-1/+67
| | | | | | | | | | | | | | | | | needing to add so much plumbing here. We're not creating the FocusManager for BrowserView. I can only think that either we're not getting the create event, or we're getting the wrong parent widget. This should help us nail down which one is happening. BUG=77651 TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6820009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81012 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r80952, http://codereview.chromium.org/6771056dmichael@chromium.org2011-04-086-501/+0
| | | | | | | | | BUG=None TEST=None TBR=rogerta Review URL: http://codereview.chromium.org/6823011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80957 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a native theme painter, to allow Views to use NativeTheme to drawrogerta@chromium.org2011-04-086-0/+501
| | | | | | | | | | | | | | | their background. Added example code to show it in use. I still have not hooked this into any existing View-based controls. This CL depends on changes currently being made to native theme, see http://codereview.chromium.org/6728029/ for details. BUG=None TEST=None Review URL: http://codereview.chromium.org/6771056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80952 0039d316-1c4b-4281-b951-d872f2087c98
* Combine WidgetWin KeyEvent handlers.msw@chromium.org2011-04-082-17/+6
| | | | | | | | | BUG=72040 TEST=Key Events on Widgets in Windows Review URL: http://codereview.chromium.org/6813033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80900 0039d316-1c4b-4281-b951-d872f2087c98
* Don't store/restore focus when window is activated/deactivated on linux.oshima@google.com2011-04-072-5/+6
| | | | | | | | | | | | GTK can restore focus if the native widget has a focus, and views always remembers the focused_view, so there is no need to store/restore on linux for this case. Opening it (like wrench menu) was causing the issues in bugs because it changes window activation. BUG=70032,chromium-os:8829 TEST=see bugs TEST= Review URL: http://codereview.chromium.org/6691052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80809 0039d316-1c4b-4281-b951-d872f2087c98
* Interpret double click events as mouse down on Windows.msw@chromium.org2011-04-072-8/+6
| | | | | | | | | | | Remove redundant code from a conditional block. BUG=78636 TEST=Double click to close neighboring tabs via (x) Review URL: http://codereview.chromium.org/6813014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80780 0039d316-1c4b-4281-b951-d872f2087c98
* RTL window styles was being set on too many HWNDs. This inverts the default. ↵ben@chromium.org2011-04-061-2/+2
| | | | | | | | | | There may be cases where the window styles are necessary however. Those I do not know and am going to rely on RTL QA to tell me about. http://crbug.com/77166 TEST=start chrome with --lang=he, content area should render and not be inverted, wrench menu should not be inverted. This change may cause some HWNDs to be incorrectly not flipped. Please let me know about those cases. Review URL: http://codereview.chromium.org/6804027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80701 0039d316-1c4b-4281-b951-d872f2087c98
* Fix WidgetWin MouseWheelEvent handling.msw@chromium.org2011-04-062-19/+4
| | | | | | | | | BUG=78569 TEST=Scroll over long bookmark menu. Review URL: http://codereview.chromium.org/6803015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80700 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in View::OnBoundsChange painting the old/new. The codesky@chromium.org2011-04-061-7/+18
| | | | | | | | | | | | wasn't adjusting for RTL. BUG=none TEST=none R=ben@chromium.org,davemoore@chromium.org Review URL: http://codereview.chromium.org/6793050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80663 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 03:19:01 +0000