| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Attaching a native view to a NativeViewHostWin may cause that
view to be disassociated from a view hierarchy with a different
FocusManager. Notifying the widgets that they are about to be
removed from their current parent gives them the opportunity to
disassociate themselves from their current FocusManager.
BUG=77447
TEST=none
Review URL: http://codereview.chromium.org/6776025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds:
1. Interfaces: InputMethod, InputMethodDelegate, TextInputClient.
2. InputMethodGtk: an InputMethod implementation based on GtkIMContext.
3. MockInputMethod: a mock InputMethod implementation for unit tests.
BUG=75003
TEST=none
Review URL: http://codereview.chromium.org/6688049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=linux clang build fix.
Review URL: http://codereview.chromium.org/6780040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename *NativeCapture to *MouseCapture.
Rename and move ShouldReleaseCaptureOnMouseReleased.
Move static flag function to Event.
BUG=72040
TEST=Mouse interaction on win & linux_views.
Review URL: http://codereview.chromium.org/6756043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out that the sync counter that we used to rely on to synchronize window painting doesn't work for the initial screen as gtk may ignore and simply update the count without painting if the configure notify doesn't change the window size. This change uses FREEZE_UPDATES to notify WM to guarantee that WM will show only after the window is painted.
I also removed gdk_window_process_updates from login code because this fixes crosbug.com/12566.
I confirmed that gdk_widnow_process_update in map handler is necessary for touch. This is due to a bug in touch code but since this path will be removed in near future, i'll keep this workaround as is for touch.
BUG=chromium-os:11514
TEST=see bug description.
Review URL: http://codereview.chromium.org/6698063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL wraps TextButton inside NativeButton for the touch case.
The reason for the added intermediate class is that RadioButton
is derived from CheckBox which is derived from NativeButton.
This is transitional code this approach is simpler and more
importantly contained to the views/controls/button/, the rest
of the code can continue to use NativeButton transparently as before.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6756017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
NativeMenuHost.
This is the first step, creating this structure. Will consolidate common functionality and state next.
BUG=72040
TEST=all menu tests for bookmark bar, wrench menu
Review URL: http://codereview.chromium.org/6740022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resulting in the views_examples tools to display blank tabs. Child windows
should be made visible by default.
BUG=None
TEST=make sure the views_examples.exe tool show the correct content for all
its tabs
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6670123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6675046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
to NativeThemeWin, since it is windows specific anyway.
BUG=None
TEST=None
R=xiyuan@chromium.org
Review URL: http://codereview.chromium.org/6778009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The reason for the added intermediate class is that RadioButton
is derived from CheckBox which is derived from NativeButton.
This is just transitional code this approach is simpler and more
importantly contained to the views/controls/button/, the rest of
the code can continue to use NativeButton transparently as before.
Note: the Windows trybot seems to fail on flaky test
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6770014
TBR=saintlou@chromium.org
Review URL: http://codereview.chromium.org/6731075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/6749046
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/6749047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/6749046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The reason for the added intermediate class is that RadioButton
is derived from CheckBox which is derived from NativeButton.
This is just transitional code this approach is simpler and more
importantly contained to the views/controls/button/, the rest of
the code can continue to use NativeButton transparently as before.
Note: the Windows trybot seems to fail on flaky test
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6770014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nix RenderWidgetHostViewViews' OnMouseCaptureLost forwarding.
Consolidate code, remove unnecessary overrides, etc.
Fix up test, |event| args, OVERRIDEs, and (c) dates.
BUG=72040
TEST=Views mouse button release, cancelling mouse down/drag.
Review URL: http://codereview.chromium.org/6685069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add BrowserWindow::ShowInactive.
BUG=None
TEST=Added api test. Also tested manually on CR-48.
Review URL: http://codereview.chromium.org/6688036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interprets tabs as an accelerator. This means if the menu text has
tabs in it we get weird behavior, and possibly trigger bugs in
windows.
BUG=77151
TEST=see bug
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6745002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
static ctor on Widget: CreateWidget().
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6732028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
raw_scoped_refptr_mismatch_checker.h
ref_counted.cc
ref_counted.h
ref_counted_memory.cc
ref_counted_memory.h
ref_counted_unittest.cc
scoped_callback_factory.h
scoped_comptr_win.h
scoped_handle.h
scoped_native_library.cc
scoped_native_library.h
scoped_native_library_unittest.cc
scoped_nsobject.h
scoped_open_process.h
scoped_ptr.h
scoped_ptr_unittest.cc
scoped_temp_dir.cc
scoped_temp_dir.h
scoped_temp_dir_unittest.cc
scoped_vector.h
singleton.h
singleton_objc.h
singleton_unittest.cc
linked_ptr.h
linked_ptr_unittest.cc
weak_ptr.cc
weak_ptr.h
weak_ptr_unittest.cc
BUG=None
TEST=Compile
Review URL: http://codereview.chromium.org/6714032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6733058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Combine MessagePumpGlibXs masters_ and floats_ fields into a single pointer_devices_ field. This is to make it easier for us to select the pointer devices of interest in one place.
Also, don't attempt to call XFreeDeviceList if XListInputDevices returns null. This should only happen when XInput2 isn't supported, which isn't a real touchui scenario, but is useful for development scenarios.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6736029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6676120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
R=erg@chromium.org,estade@chromium.org
Review URL: http://codereview.chromium.org/6719006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6719006
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/6696053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6719006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes made by this CL:
1. Adds OnBeforeUserAction() and OnAfterUserAction() in TextfieldController.
2. Adds Textfield::HasSelection().
3. Changes NativeTextfieldViews to use KeyEvent::GetCharacter().
3. Refactors AutocompleteEditViewViews to use new TextfieldController methods.
BUG=75003
TEST=views_unittests --gtest_filter=*Textfield* and interactive_ui_tests --gtest_filter=AutocompleteEditViewViews*
Review URL: http://codereview.chromium.org/6685082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=76976
TEST=none
Review URL: http://codereview.chromium.org/6705028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6724025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
compositor_gl.cc (in gfx) depends on app_base (for gl_bindings), but app_base depends on gfx. This gets rid of the cyclic dependency. It is part of the larger effort to move app/gfx/gl to ui/gfx/gl.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/6718034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(note this is a resubmit of Issue 6718004)
BUG=76919, 76976
TEST=none
Review URL: http://codereview.chromium.org/6716024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Loads favicons when openning back/forward menu for any urls that don't
have favicons.
BUG=5679
TEST=Restore a tab with a navigation history, check favicons.
Review URL: http://codereview.chromium.org/6708029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
R=sky@chromium.org
Review URL: http://codereview.chromium.org/6715020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=75003
TEST=views_unittests --gtest_filter=EventTest.*
Review URL: http://codereview.chromium.org/6713027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gives 'out of the box' compatability with VC2008 express - i.e. no modifications needed to system headers or .gyp* files or related hacks. Just set the GYP_MSVS_VERSION to 200Xe (e for express, same as the linked blog on the issue and first google hit as well).
1) Changes to build\common.gypi to turn off to define COMPILER_MSVC_EXPRESS if a express is detected (through the GYP_MSVC_VERSION environment variable), turn off the _SECURE_ATL define (which is flagged as an error with WinDDK's ATL, _SECURE_ATL adds [more] CRT checks to other ATL versions) and hard to link to the atl stdthunk library with express editions. Also, explicitly link to the base WinSDK libraries in common.gypi and mini_installer.gypi for MSVC 2005 express.
2) Fixes a few .cc files that have the wrong include order with the ATL headers when using the Windows DDK ATL. The Windows DDK ATL brings in intsafe.h (WinSDK, not WinDDK) with atlwin.h and generates multiple INTXX_MIN/MAX def warnings which get
flagged as errors with the warnings as errors flag if not included before other libraries that have the same definitions like ICU.
3) Changes to .rc files to avoid pulling in afxres.h (an MFC header -
it's available in the WinDDK) and winres.h which VCExpress doesn't have (it's available in a WinSDK sample, but that kind of the purpose of it). The main Chromium .rc files are already structured this way, I just changed the rest and changed the output of grit to do the same.
4) Removes the memset obj file linking in mini_installer.gyp and simply implements memset for mini_installer.cc.
Only changes to the chromium branch now. There are some .rc files in the Python26, Native Client, and Angle in samples that could #3 changes. They are not required for Chromium, however.
------
VC2005SP1 can be downloaded at
http://www.microsoft.com/downloads/en/details.aspx?FamilyId=7B0B0339-613A-46E6-AB4D-080D4D4A8C4E&displaylang=en
(or non-SP1 at http://download.microsoft.com/download/8/3/a/83aad8f9-38ba-4503-b3cd-ba28c360c27b/ENU/vcsetup.exe)
VC2008SP1 can be downloaded at
http://www.microsoft.com/downloads/en/details.aspx?FamilyId=F3FBB04E-92C2-4701-B4BA-92E26E408569&displaylang=en
currently.
The base developer instructions work fine afterwards with a couple tweaks for express versions:
http://www.chromium.org/developers/how-tos/build-instructions-windows
Under "Additional (free) downloads" under step 2:
X) Only the first 3 Non-SP KB Patches are needed for express. Don't forget to forget GYP_MSVS_VERSION environment as appropriate - 2008e for Visual C++ 2008 Express, for example.
Under "Additional (free) downloads" after step 5
[These only apply to 2008 express, 2005 works fine out of the box]:
6A) Download the WinDDK for the atl headers and libs -
http://msdn.microsoft.com/en-us/windows/hardware/gg487463.aspx. It works fine, but you do not need to install the whole DDK. In the WDK directory just install headers.msi, libs_x86fre.msi, and libs_x64fre.msi; just grab the atl headers and atl*.lib libs; right click the installers and uninstall afterwards. Add the appropriate include and lib paths to your global settings.
6B) To build x64 targets (x64 Native Client) download:
http://www.cppblog.com/Files/xcpp/VCE64BIT_WIN7SDK.zip
Follow the readme instructions.
Further information behind that and x64 target building with express:
- http://jenshuebel.wordpress.com/2009/02/12/visual-c-2008-express-edition-and-64-bit-targets/
- http://www.cppblog.com/xcpp/archive/2009/09/09/vc2008express_64bit_win7sdk.html
----------------
BUG=1433, 5026, 72885
TEST=Compiles in both Debug and Release mode in Visual C++ Express 2008/2005 and does not effect other build setups. In addition, the WinDDK ATL compiles with the secure_atl=0 in the GYP_DEFINES environment variable on non-express versions of MSVC.
Review URL: http://codereview.chromium.org/6676030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WS_EX_TRANSPARENT if accept_events is false.
BUG=none
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/6708064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6712008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mouse wheel wasn't working for submenus on chromeos.
This CL fixes this issue by forwarding events to submenu, like other mouse events.
BUG=chromium-os:11834
TEST=see bug for repro step.
Review URL: http://codereview.chromium.org/6673105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=views_examples, and existing views_unittests
R=sky@chromium.org
Review URL: http://codereview.chromium.org/6685039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a GtkWidget is gtk_widget_show'n before its parent widget, then the child
widget will not have a GdkWindow when "show" triggers. "map" is a more
appropriate signal to do something on the GdkWindow after it's created and
drawable.
BUG=76573
TEST=CollectedCookiesTest.*
Review URL: http://codereview.chromium.org/6688028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
place.
BUG=30572
TEST=none, just make sure tab selection isn't broken.
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6712012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
folder we wouldn't throb the right view. To get this to work I changed
the order of when we apply edits (change the model) to before the
bubble is closed. Previously we closed the bubble, then applied the
edits. We need to apply the edits first as bookmark bar stops
throbbing when the bubble is closed.
BUG=41082
TEST=see bug
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6677050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:10120
TEST=Switch to Russian keyboard layout, try accelerators like ctrl-t, ctrl-w, etc.
Review URL: http://codereview.chromium.org/6674052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/74764
TEST=none
Review URL: http://codereview.chromium.org/6665050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the delayed display of menus, where the menu (wrench menu, context
menus) shows up some time (sometimes 10+ seconds) after clicking.
BUG=76085
TEST=none
Review URL: http://codereview.chromium.org/6665030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
that we receive crash reports when something goes wrong.
BUG=63702
TEST=base_unittests
Review URL: http://codereview.chromium.org/6697004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
folder menu.
It was failing with DCHECK instead.
This CL fix this issue by Canceling menu only when the menu has x grab.
I also separated grk grab broke and X grab broke because gtk broke require releasing x grab for this case.
BUG=chromium-os:13151
TEST=see bug description.
Review URL: http://codereview.chromium.org/6676032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetForegroundWindow() returns a different value when it's called from WM_DESTROY vs. WM_CLOSE. We need to do activation restoration earlier than WM_DESTROY.
http://crbug.com/75610
TEST=see bug
TBR=sky
Review URL: http://codereview.chromium.org/6670054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78420 0039d316-1c4b-4281-b951-d872f2087c98
|