summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* GTK: Minimize usage of gtk headers.erg@chromium.org2010-07-082-4/+14
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2891006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51898 0039d316-1c4b-4281-b951-d872f2087c98
* Ups the max size of bookmark menus to accommodate the wrench menu.sky@chromium.org2010-07-081-1/+3
| | | | | | | | | BUG=48309 TEST=see bug Review URL: http://codereview.chromium.org/2880019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51847 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo that caused wrong menu highlight color being used for ChromeOS.xiyuan@chromium.org2010-07-071-1/+1
| | | | | | | | | BUG=chromium-os:4580 TEST=Verify correct color 0xDCE4FA is used for menu highlight per chromium-os:4580. Review URL: http://codereview.chromium.org/2861049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51780 0039d316-1c4b-4281-b951-d872f2087c98
* Fire focus events when CustomButtons are hottracked.dtseng@chromium.org2010-07-074-4/+54
| | | | | | | | BUG=47585 TEST=none Review URL: http://codereview.chromium.org/2867040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51753 0039d316-1c4b-4281-b951-d872f2087c98
* Add some missing states for menu items. This allows AT's to know when a ↵dtseng@chromium.org2010-07-071-0/+13
| | | | | | | | | | menu item has a submenu (HASPOPUP) and is checked (either a radio or checkbox). BUG=47585 TEST=none Review URL: http://codereview.chromium.org/2858051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51751 0039d316-1c4b-4281-b951-d872f2087c98
* Fix column sizing in views::TableView.mnissler@chromium.org2010-07-072-2/+8
| | | | | | | | | | | | r51628 accidentally broke the sizing logic to only work if autosize_columns_ is set. Use a flag to track whether an initial sizing operation is required. BUG=48373 TEST=Open Content Settings Exceptions dialog, close, reopen. Columns in the table should be sized reasonably instead of being all clumped up at the left edge. Review URL: http://codereview.chromium.org/2888001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51749 0039d316-1c4b-4281-b951-d872f2087c98
* Makes menu draw disabled arrow the correct color for classic windows.sky@chromium.org2010-07-072-6/+19
| | | | | | | | | BUG=48099 TEST=see bug Review URL: http://codereview.chromium.org/2835033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51721 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes menus when shown by way of pressing alt-f. I need to turn onsky@chromium.org2010-07-073-15/+8
| | | | | | | | | | | | | | | | nested tasks as in some situations the menu may be shown when the message loop is processing a task. If the message loop is processing a taskand we don't set nested tasks allowed to true then none of the tasks scheduled by the menu (paints, delays...) are processed and the menu appears totally broken. BUG=48102 TEST=give focus to the page, press alt-f, press arrow keys and make sure the menu updates appropriately. Review URL: http://codereview.chromium.org/2836044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51719 0039d316-1c4b-4281-b951-d872f2087c98
* Bye bye tab close dot, we hardly knew you.sky@chromium.org2010-07-076-163/+21
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2813045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51718 0039d316-1c4b-4281-b951-d872f2087c98
* Display warning banner in Win preferences dialog for managed options.mnissler@chromium.org2010-07-067-83/+232
| | | | | | | | | BUG=43423 TEST=box_layout_unittest.cc, manual UI tests. Review URL: http://codereview.chromium.org/2738002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51655 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land r51526mnissler@chromium.org2010-07-0523-81/+362
| | | | | | | | | | | | | | | | | | Auto-size the views version of the options dialog. This adds support for auto-sizing tab controls, adjusts the options dialog to use it and takes care of any fallout due to the new layout handling. Also fixes a couple of small bugs in the views Layout() machinery and sanitizes layouting of options pages. BUG=36497 TEST=unit tests in tabbed_pane_unittest.cc and grid_layout_unittest.cc, as well as checking the options dialog in any supported language. original issuse: http://codereview.chromium.org/2812026/show Review URL: http://codereview.chromium.org/2883022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51628 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the menu code to show mnemonics if the alt key is down.sky@chromium.org2010-07-021-2/+13
| | | | | | | | | BUG=46445 TEST=press alt-f on windows and make sure the mnemonics are shown. Review URL: http://codereview.chromium.org/2842041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51561 0039d316-1c4b-4281-b951-d872f2087c98
* Move WindowImpl to gfx so I can use it there for canvas unit tests.ben@chromium.org2010-07-023-6/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2813042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51554 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r51526 (Auto-size the views version of the options dialog.)mnissler@chromium.org2010-07-0223-361/+81
| | | | | | | | Unexpected unit_tests crash on chromeos. TBR: mnissler git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51529 0039d316-1c4b-4281-b951-d872f2087c98
* Auto-size the views version of the options dialog.mnissler@chromium.org2010-07-0223-81/+361
| | | | | | | | | | | | | | This adds support for auto-sizing tab controls, adjusts the options dialog to use it and takes care of any fallout due to the new layout handling. Also fixes a couple of small bugs in the views Layout() machinery and sanitizes layouting of options pages. BUG=36497 TEST=unit tests in tabbed_pane_unittest.cc and grid_layout_unittest.cc, as well as checking the options dialog in any supported language. Review URL: http://codereview.chromium.org/2812026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51526 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate more old filepath functions.evan@chromium.org2010-07-011-1/+1
| | | | | | | | | | | | These still exist on Windows due to being used by the installer, but by moving them into the Windows-only block we prevent them from being used in new code. BUG=24672 Review URL: http://codereview.chromium.org/2861042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51453 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the MenuViewItem objects to a widget so that they may send ↵dtseng@chromium.org2010-07-013-3/+49
| | | | | | | | | | accessibility focus events. BUG=47585 TEST=none Review URL: http://codereview.chromium.org/2872022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51436 0039d316-1c4b-4281-b951-d872f2087c98
* Moves gtk accelerator processing functions to base/gtk_util so I cansky@chromium.org2010-07-011-20/+2
| | | | | | | | | | | | | use them from views and gfx. Sorry for the new patch on this and not an update. Not sure what happened. BUG=none TEST=none Review URL: http://codereview.chromium.org/2809047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51409 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the bookmark menu.pkasting@chromium.org2010-07-011-4/+0
| | | | | | | | BUG=none TEST=--bookmark-menu no longer does anything Review URL: http://codereview.chromium.org/2853024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51403 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in showing menus. This is less likely now thatsky@chromium.org2010-07-012-11/+67
| | | | | | | | | | | | | | | | | | main menu is using the bookmark menu, but still worth trying to fix. We run a nested message loop when showing a menu. When a click occurs outside the menu gtk closes the menu and we exit the nested message loop. The problem is that click is dispatched from the nested message loop, meaning it's possible to attempt to spawn another menu or do other things from the nested message loop. To fix it I'm manually closing the popup and not dispatching the event. BUG=40492 TEST=see bug, but in general make sure chrome specific menus (time, network ...) continue to work. Review URL: http://codereview.chromium.org/2861037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51372 0039d316-1c4b-4281-b951-d872f2087c98
* Adding support for ChromeOS snapshot window titles and favicons.gspencer@chromium.org2010-06-302-69/+92
| | | | | | | | | TEST=build and ran with chromeos-wm BUG=chromium-os:2866, chromium-os:2867 Review URL: http://codereview.chromium.org/2857005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51305 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring phase 4b:ben@chromium.org2010-06-305-12/+12
| | | | | | | | | | | Add BeginPlatformPaint/EndPlatformPaint calls to gfx::Canvas. BeginPlatformPaint() returns a gfx::NativeDrawingContext. BUG=none TEST=none Review URL: http://codereview.chromium.org/2840029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51297 0039d316-1c4b-4281-b951-d872f2087c98
* Minor fixes to toolbar keyboard accessibility: focusing the location bardmazzoni@chromium.org2010-06-302-8/+43
| | | | | | | | | | | | | | | should select all, accessibility focus should be preserved when the whole window loses and regains focus, and clicking on the location bar should exit accessibility focus mode. BUG=47380 BUG=36070 BUG=47784 TEST=none Review URL: http://codereview.chromium.org/2833040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51262 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: Replace tabs in content settings with a listbox.thakis@chromium.org2010-06-301-4/+4
| | | | | | | | | | | Depends on http://codereview.chromium.org/2815034 BUG=45546 TEST=Open content settings dialog. Should have a list on the left instead of tabs on top. Other than that, the dialog should work as before. Review URL: http://codereview.chromium.org/2799042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51205 0039d316-1c4b-4281-b951-d872f2087c98
* Win: Add listbox view.thakis@chromium.org2010-06-307-10/+375
| | | | | | | | | | | | | See http://codereview.chromium.org/2799042 for how I intend to use this. BUG=45546 TEST=None BUG=45546 TEST=None Review URL: http://codereview.chromium.org/2815034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51196 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring Phase 4a:ben@chromium.org2010-06-294-14/+13
| | | | | | | | | | | Move Save, SaveLayerAlpha and Restore onto gfx::Canvas. BUG=none TEST=none Review URL: http://codereview.chromium.org/2846035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51179 0039d316-1c4b-4281-b951-d872f2087c98
* Disables another crashing test.sky@chromium.org2010-06-281-1/+2
| | | | | | | | | | BUG=45015 TEST=none TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/2880004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51020 0039d316-1c4b-4281-b951-d872f2087c98
* Disables TableViewTest.PersistMultiSelectionOnChangeWithSort as it issky@chromium.org2010-06-281-1/+1
| | | | | | | | | | | | crashing. BUG=45015 TEST=none TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/2821021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50989 0039d316-1c4b-4281-b951-d872f2087c98
* Mark TreeViewTests.PersistMultiSelectionOnSort as DISABLED_. glotov@chromium.org2010-06-281-1/+1
| | | | | | | | | | Test crashes on Vista bot. BUG=4354 TEST="Vista Tests (dbg)(1)" should cycle green. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50974 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring part 3.ben@chromium.org2010-06-2521-89/+89
| | | | | | | | | | | | | | - Replace Canvas instance users with CanvasSkia users. - Rename Canvas2 to Canvas. - Delete Canvas subclass of CanvasSkia. This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50854 0039d316-1c4b-4281-b951-d872f2087c98
* Changes mnemonics for bookmark menus to show the mnemonics if eithersky@chromium.org2010-06-253-14/+58
| | | | | | | | | | | | | the os says we should, or focus was on the button that triggered showing the menu. Also changes mnemonic processing to not guess at mnemonic if menu has mnemonics. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2831031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50852 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome/win: Show preview images when dragging images.thakis@chromium.org2010-06-254-6/+27
| | | | | | | | | BUG=11457 TEST=Go to google.com, drag logo around. Should be attached to cursor. Review URL: http://codereview.chromium.org/2870026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50830 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50784 - Canvas refactoring part 3.ben@chromium.org2010-06-2422-89/+89
| | | | | | | | | | | | | | | | | | - Replace Canvas instance users with CanvasSkia users. - Rename Canvas2 to Canvas. - Delete Canvas subclass of CanvasSkia. This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API. BUG=none TEST=none Review URL: http://codereview.chromium.org/2825018 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/2811032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50790 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring part 3.ben@chromium.org2010-06-2422-89/+89
| | | | | | | | | | | | | | | - Replace Canvas instance users with CanvasSkia users. - Rename Canvas2 to Canvas. - Delete Canvas subclass of CanvasSkia. This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API. BUG=none TEST=none Review URL: http://codereview.chromium.org/2825018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50784 0039d316-1c4b-4281-b951-d872f2087c98
* Fix radiobuttons and connect up child widgets again.dtseng@chromium.org2010-06-245-3/+19
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2806030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50778 0039d316-1c4b-4281-b951-d872f2087c98
* Default to GTK_WRAP_WORD_CHAR for multiline textfield on Gtk.xiyuan@chromium.org2010-06-241-0/+3
| | | | | | | | | BUG=chromium-os:4258 TEST=Verify fix for chromium-os:4258. Review URL: http://codereview.chromium.org/2824026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50723 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring part 2.ben@chromium.org2010-06-2313-33/+40
| | | | | | | | | | | | - Rename Canvas to CanvasSkia. - Create a subclass Canvas that inherits from CanvasSkia for compatibility. BUG=none TEST=none Review URL: http://codereview.chromium.org/2862025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50664 0039d316-1c4b-4281-b951-d872f2087c98
* Replace wstring with string16 in history. The only time wstring is used now ↵brettw@chromium.org2010-06-231-2/+4
| | | | | | | | | | | | in history is for bookmark-related stuff (the bookmarks system is still wstring-based). The substantial change here is in RTL to make a string16 variant of the functions and in changing the WordIterator to use string16 (this cleaned up some weird utf-32 code). TEST=none BUG=none Review URL: http://codereview.chromium.org/2808017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50597 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring part 1.ben@chromium.org2010-06-221-5/+5
| | | | | | | | | | | - Introduce a new Canvas2 interface. This will become the way that everyone talks to Canvas. It is populated primarily with the cross-platform methods from Canvas. - Make Canvas implement this interface. - Hook it up to the Windows RootView. Review URL: http://codereview.chromium.org/2866010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50543 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in menus and makes widgetgtk not send outsky@chromium.org2010-06-223-5/+17
| | | | | | | | | | | mousemove if the event is the result of a grab. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2841018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50529 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the extension resize gripper only visible when the mouse is oversky@chromium.org2010-06-223-5/+45
| | | | | | | | | | | it. BUG=45750 TEST=see bug Review URL: http://codereview.chromium.org/2800022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50515 0039d316-1c4b-4281-b951-d872f2087c98
* Small tweaks to improve toolbar keyboard accessibility: Put focus rectsdmazzoni@chromium.org2010-06-224-14/+9
| | | | | | | | | | | | | around more controls (including location bar, only when in full keyboard access mode). Fix accessible names. Fix spacebar to activate menu buttons. Remove methods for child focus, they're not needed anymore. BUG=none TEST=none Review URL: http://codereview.chromium.org/2817022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50462 0039d316-1c4b-4281-b951-d872f2087c98
* *Add WidgetGtk::ClearNativeFocus so that subclass can implement cutomized ↵oshima@chromium.org2010-06-193-9/+13
| | | | | | | | | | | | | | behavior when clearning native focus. This is necessary in ScreenLocker as the focus has to be set to the widget that is grabbing all input focus. * PasswordField that will set focus it itself when mouse is clicked. This is necessary again when the input is grabbed by other widget because the gtk textfield will never receive mouse event. * fix minor bug : locating the grab widget in wrong place. Review URL: http://codereview.chromium.org/2811015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50303 0039d316-1c4b-4281-b951-d872f2087c98
* Keep a cache of all views that have sent notifications. This ensures that ↵dtseng@chromium.org2010-06-189-8/+136
| | | | | | | | | | AccessibleObjectFromEvent works properly. BUG=9601 TEST=none Review URL: http://codereview.chromium.org/2823009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50302 0039d316-1c4b-4281-b951-d872f2087c98
* Mark TableViewTest.PersistSelectionOnSort and PersistMultiSelectionOnSort as ↵mattm@chromium.org2010-06-181-2/+2
| | | | | | | | | | | | | fails. (They were re-enabled in 50245) BUG=45015 TBR=nkostylev Review URL: http://codereview.chromium.org/2807008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50282 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for radio menu items to bookmark menus.sky@chromium.org2010-06-186-26/+141
| | | | | | | | | BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2846014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50246 0039d316-1c4b-4281-b951-d872f2087c98
* TableViewTests.Sort* started crashing. Marking as DISABLED_.nkostylev@google.com2010-06-181-10/+10
| | | | | | | | | | | | | | Revert 48168 - Mark TreeViewTests as FAILS_ rather than DISABLED_ TBR=jcivelli BUG=45015 Review URL: http://codereview.chromium.org/2171006 TBR=rafaelw@chromium.org Review URL: http://codereview.chromium.org/2824016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50245 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for click-drag-release on views embedded in a menu tosky@chromium.org2010-06-182-5/+124
| | | | | | | | | | | behave as if the user initially clicked on the view. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2841009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50244 0039d316-1c4b-4281-b951-d872f2087c98
* Mark TreeViewTests.Sort as DISABLED_.nkostylev@google.com2010-06-181-1/+1
| | | | | | | | | | | Test crashes on Vista bot. BUG=45015 TBR=rafaelw Review URL: http://codereview.chromium.org/2870013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50241 0039d316-1c4b-4281-b951-d872f2087c98
* Improve toolbar keyboard accessibility.dmazzoni@chromium.org2010-06-1818-381/+715
| | | | | | | | | | | | Design doc: https://docs.google.com/a/google.com/Doc?docid=0ATICCjR-gNReY2djdjkyNnNfNzl4ZnpiODQ2Mg&hl=en BUG=40745 BUG=36728 BUG=36222 TEST=New test added to focus_manager_unittest.cc Review URL: http://codereview.chromium.org/2737010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50234 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 08:48:00 +0000