summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Fix some gcc 4.4 issues when compiling with toolkit_views.craig.schlenter@chromium.org2009-09-072-3/+3
| | | | | | | | | | | | | | | | | | | | | Most of these squash harmless compiler warnings but the custom_button.cc change fixes a real problem with the accelerator key bitmask calculation (+ preceeds << in terms of operator precedence) The change to tab_strip.cc is ugly but it fixes the following error: chrome/browser/views/tabs/tab_strip.cc: In member function ‘void TabStrip::StartRemoveTabAnimation(int, TabContents*)’: chrome/browser/views/tabs/tab_strip.cc:201: error: assuming signed overflow does not occur when assuming that (X - c) > X is always false As an added bonus, this makes the Linux shared build of toolkit_views work too. Review URL: http://codereview.chromium.org/199025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25602 0039d316-1c4b-4281-b951-d872f2087c98
* Adds views::Screen::GetMonitorAreaNearestPoint.sky@chromium.org2009-09-043-3/+30
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/199023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25476 0039d316-1c4b-4281-b951-d872f2087c98
* Removing ATL dependencies from two files.finnur@chromium.org2009-09-032-12/+7
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/201010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25398 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 9867: Activating the previous/next buttons with the keyboard in the find ↵finnur@chromium.org2009-09-0312-26/+92
| | | | | | | | | | | | | bar should not change the focus. Add param const Event& event to ButtonPressed, so that recipients can find out more about the event that generated the ButtonPress message. BUG=9687 TEST=Open www.google.com and open Find-in-page, search for 'e'. Press FindNext button with mouse and note that the focus should be on the textfield. Now press Tab twice to put focus on the FindNext button and press SpaceBar a few times. Note that the focus should stay on the FindNext button. Review URL: http://codereview.chromium.org/188016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25367 0039d316-1c4b-4281-b951-d872f2087c98
* Uses POINT instead of CPoint to reduce the dependency in ATL.scherkus@chromium.org2009-09-037-14/+10
| | | | | | | | | | | | | Patch submitted by Thiago Farina: http://codereview.chromium.org/188017 BUG= http://crbug.com/2185 TEST=None Review URL: http://codereview.chromium.org/199009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25365 0039d316-1c4b-4281-b951-d872f2087c98
* A couple comment changes -- update an out of date comment and add a note ↵pkasting@chromium.org2009-09-032-2/+7
| | | | | | | | | | about some awful behavior that dates back to the earliest days. BUG=none TEST=none Review URL: http://codereview.chromium.org/185002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25338 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Back and Forwards button broken in 23101idanan@chromium.org2009-09-031-4/+4
| | | | | | | | | | | | | | | | Issue 165318 was accepted but caused the back and forwards button to become unresponsive to middle-clicks. This should fix the issue but if there is a problem, we should revert 23101 because it causes a major regression while only providing a cosmetic enhancement. BUG=20323 TEST=none Review URL: http://codereview.chromium.org/199007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25313 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/185003 for Oshima:sky@chromium.org2009-09-023-0/+237
| | | | | | | | | | | | * gtk implemenation of tabbed pane * focus is not handled as Jay is working on it. BUG=none TEST=none Review URL: http://codereview.chromium.org/171120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25222 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/172098 for Oshima:sky@chromium.org2009-09-023-6/+9
| | | | | | | | | | | | * fix typo in WidgetGtk * re-organize method in combobox for chrome convention BUG=none TEST=none Review URL: http://codereview.chromium.org/188009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25186 0039d316-1c4b-4281-b951-d872f2087c98
* The FocusManager stores/restores focus when the top window becomes ↵jcampan@chromium.org2009-09-0111-79/+199
| | | | | | | | | | | | inactive/active. BUG=None TEST=Run the focus manager unit-tests. Review URL: http://codereview.chromium.org/164448 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25108 0039d316-1c4b-4281-b951-d872f2087c98
* Porting textfield to toolkit_views Gtk.jcampan@chromium.org2009-09-0111-64/+126
| | | | | | | | | | | BUG=None TEST=Run the view unit-tests. See original review: http://codereview.chromium.org/165512/show Review URL: http://codereview.chromium.org/180061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25063 0039d316-1c4b-4281-b951-d872f2087c98
* Make native button wrapper construction return the new wrapper rather thanbrettw@chromium.org2009-09-016-19/+30
| | | | | | | | | | | | | | | | | setting it on the class. I did this for the textbox and I think it's a bit better. The old way set it, but that function didn't add it to the view hierarchy. This means that the pointer is technically "unowned" when the CreateWrapper function returns. This new way makes pointer ownership more clear. It becomes the caller's problem, and the caller immediately inserts it into the view hierarchy which then manages the lifetime. TEST=none BUG=none Review URL: http://codereview.chromium.org/180041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25043 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where the tooltip would not be erased if it had been non-empty and ↵pkasting@chromium.org2009-08-311-4/+4
| | | | | | | | | | then was updated to be empty. BUG=none TEST=Start Chrome, type a letter in the omnibox, hover the Go button and wait for the tooltip. Then delete the character and move the mouse pointer a tiny bit. The tooltip should disappear. Review URL: http://codereview.chromium.org/175032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24918 0039d316-1c4b-4281-b951-d872f2087c98
* Lands 176025 from Oshima:sky@chromium.org2009-08-315-15/+86
| | | | | | | | | | | | | Combobox implemenation for GTK Removed const from GetPreferredSize, as GTK implementation has cache to update. TEST=none BUG=none Review URL: http://codereview.chromium.org/183015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24904 0039d316-1c4b-4281-b951-d872f2087c98
* Make the views bookmark bubble work on GTK.brettw@chromium.org2009-08-285-8/+76
| | | | | | | | | | | The combobox still isn't implemented, but this makes TextBox work, and also does some changes around the info_bubble to make sure it get created properly. TEST=none BUG=none. Review URL: http://codereview.chromium.org/177026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24821 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for initiating drags from bookmark menus.sky@chromium.org2009-08-2811-61/+168
| | | | | | | | | BUG=none TEST=make sure bookmark menus work on Windows. Review URL: http://codereview.chromium.org/176006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24801 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix a ton of compiler warnings."tony@chromium.org2009-08-283-14/+3
| | | | | | | | | | | This reverts commit r24792. TBR=estade Review URL: http://codereview.chromium.org/179028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ton of compiler warnings.estade@chromium.org2009-08-283-3/+14
| | | | | | | | | | | | | | | Most of these are classes with virtual methods lacking virtual destructors or NULL used in non-pointer context. BUG=none TEST=app_unittests && base_unittests --gtest_filter=-ConditionVariableTest.LargeFastTaskTest patch by Jacob Mandelson <jlmjlm [at] gmail> http://codereview.chromium.org/171028/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
* Reafactor Textfield to bring the native widget handling more in line with whatbrettw@chromium.org2009-08-284-20/+48
| | | | | | | | we do in button. We still don't have NativeTextfieldWin deriving from NativeControlWin, which is what the addition of the hack function works around. Review URL: http://codereview.chromium.org/173588 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24783 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at landing bookmark menus.sky@chromium.org2009-08-2614-65/+227
| | | | | | | | | | | | | The build breakage was the result of a bad ifdef in MenuController, specifically around the OnKeyDown method. BUG=none TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/173517 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24526 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts menu patch.sky@chromium.org2009-08-2614-227/+65
| | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/173508 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24509 0039d316-1c4b-4281-b951-d872f2087c98
* Gets bookmark menu working on linux. There are just a handful ofsky@chromium.org2009-08-2613-63/+227
| | | | | | | | | | | | NOTIMPLEMENTEDs to resolve (initiating drags is the biggest remaining issue). I'll tackle the remaining issues separately. BUG=none TEST=make sure bookmark menus work well on windows still. Review URL: http://codereview.chromium.org/173431 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24501 0039d316-1c4b-4281-b951-d872f2087c98
* Further refactoring of menus for GTK. I've now separated outsky@chromium.org2009-08-2426-4419/+1127
| | | | | | | | | | | | | | | | | everything and menus some what work on GTK. I need to get painting working and I'm sure there will be fine tuning, but I want to check in all this splitting of files before someone else needs change one of these files. Thankfully I wrote an interactive ui test that exercises much of this code, and it still passes:) BUG=none TEST=thoroughly test bookmark menus on windows to make sure I didn't break them. Review URL: http://codereview.chromium.org/174274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24098 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix the ChromeOS build. This tries to add a views dependency for ↵brettw@chromium.org2009-08-221-3/+4
| | | | | | | | browser_tests, and fixes some simple errors in the focus unit test. Review URL: http://codereview.chromium.org/173243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24061 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the unused WTL::CRect from window_delegate.h.maruel@chromium.org2009-08-221-5/+0
| | | | | | | | | | | | Patch contributed by thiago.farina@gmail.com BUG=None TEST=None Review: http://codereview.chromium.org/171027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24058 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support and exposure of additional accessibility roles. Includes naming ↵klink@chromium.org2009-08-224-1/+22
| | | | | | | | | | of the LocationBar, and correctly exposing MSAA/ARIA roles for Documents, Graphics, Menubars and Toolbars. BUG=13291,19982 TEST=Assign @role menubar or toolbar to any dom element, and use Inspect32 (or similar tool) to see it exposed correctly. In the same way, <html> tag is exposed as role document. Review URL: http://codereview.chromium.org/174252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24049 0039d316-1c4b-4281-b951-d872f2087c98
* Splits the menu classes into individual files in anticipation ofsky@chromium.org2009-08-2010-3/+3971
| | | | | | | | | | | porting them. BUG=none TEST=make sure to thorougly test bookmark menus on windows. Review URL: http://codereview.chromium.org/173091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23801 0039d316-1c4b-4281-b951-d872f2087c98
* Makes Path::CreateGdkRegion return NULL for empty paths. Without thissky@chromium.org2009-08-191-1/+4
| | | | | | | | | | | gdk_region_polygon asserts. And adds the null check in WindowGtk. BUG=none TEST=none Review URL: http://codereview.chromium.org/164441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23691 0039d316-1c4b-4281-b951-d872f2087c98
* Relands drop support:sky@chromium.org2009-08-198-20/+688
| | | | | | | | | | | | Adds drop support for views on gtk. As X lazily provides drop data I needed to tweak the views API a bit. BUG=none TEST=none Review URL: http://codereview.chromium.org/173025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23690 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23645.jhawkins@chromium.org2009-08-183-28/+39
| | | | | | | Crashing the reliability bot. Review URL: http://codereview.chromium.org/174029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23674 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts recent patch as broke build on toolkit_views.sky@chromium.org2009-08-188-688/+20
| | | | | | | | | TBR=ben BUG=none TEST=none Review URL: http://codereview.chromium.org/174023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23658 0039d316-1c4b-4281-b951-d872f2087c98
* Adds drop support for views on gtk. As X lazily provides drop data Isky@chromium.org2009-08-188-20/+688
| | | | | | | | | | | needed to tweak the views API a bit. BUG=none TEST=none Review URL: http://codereview.chromium.org/165407 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23653 0039d316-1c4b-4281-b951-d872f2087c98
* Make NativeControl inherit from base::WindowImpl instead of CWindowImpl to ↵jhawkins@chromium.org2009-08-183-39/+28
| | | | | | | | | | reduce a dependency on ATL. BUG=5027 TEST=none Review URL: http://codereview.chromium.org/169015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23645 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out views::Combobox::Model so that it can be used cross-platform.mattm@chromium.org2009-08-184-22/+18
| | | | | | | | | | This removes the Combobox* source arg from the Model methods, which wasn't really used by anything. BUG=none TEST=none Review URL: http://codereview.chromium.org/165514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23603 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Reverting 23406" as it didn't break any tests.jhawkins@chromium.org2009-08-141-33/+33
| | | | | | | | | | | | | | Change PluginInstallImpl to use base::WindowImpl instead of CWindowImpl to reduce a dependency on ATL. BUG=5023 TEST=Uninstall flash. Visit hulu.com and install the flash plugin. Original review: http://codereview.chromium.org/165469 TBR=levin Review URL: http://codereview.chromium.org/165543 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23454 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23406.levin@chromium.org2009-08-141-33/+33
| | | | | | | | | | | | It seems that Tab2OutOfTabStrip is failing consistently after this change. BUG=None TEST=None TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/164543 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23411 0039d316-1c4b-4281-b951-d872f2087c98
* Change PluginInstallImpl to use base::WindowImpl instead of CWindowImpl to ↵jhawkins@chromium.org2009-08-141-33/+33
| | | | | | | | | | reduce a dependency on ATL. BUG=5023 TEST=Uninstall flash. Visit hulu.com and install the flash plugin. Review URL: http://codereview.chromium.org/165469 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23406 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors OSExchangeData for easier portability.sky@chromium.org2009-08-124-14/+20
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/164401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23230 0039d316-1c4b-4281-b951-d872f2087c98
* Implements WidgetGtk::SetOpacity.sky@chromium.org2009-08-122-3/+13
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/164346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23169 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/159838 for Pierre-Antoine. From him:sky@chromium.org2009-08-114-11/+41
| | | | | | | | | | | | | | | | | | | Right clicking the back and forward buttons is buggy. A single right click opens the drop down menu, however the button does not enter the PUSHED state. If you double right click then click on the tab content area, the button stays in a PUSHED state until you mouseover it. The fix should replicate the intuitive behavior. On a single right click, the button enters the PUSHED state and the drop down appears immediately. As soon as the user clicks on another View, the drop down closes and the button returns to the NORMAL state. Double right click behaves similarly. BUG=9717 TEST=none Review URL: http://codereview.chromium.org/165318 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23101 0039d316-1c4b-4281-b951-d872f2087c98
* Removes bogus comments in WidgetGtk::GetBounds.sky@chromium.org2009-08-111-9/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/165306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23062 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/165271 for tedoc. From tedoc:sky@chromium.org2009-08-111-1/+1
| | | | | | | | | | | Fix set_x to set_y for vertical scrolling BUG=NONE TEST=none Review URL: http://codereview.chromium.org/164321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23028 0039d316-1c4b-4281-b951-d872f2087c98
* Removes calls to RootView methods that were removed.sky@chromium.org2009-08-111-3/+0
| | | | | | | | | BUG=none TEST=none TBR=jcampan Review URL: http://codereview.chromium.org/164320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23022 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors RootViewDropTarget into a platform independent part,sky@chromium.org2009-08-1115-241/+386
| | | | | | | | | | | | | | DropHelper, and the platform specific part DropTarget. I've also moved ownership/creation of the DropTarget to Widget. This makes it alot easier for the windows side, in which DropTarget must implement IDataObject. BUG=none TEST=none Review URL: http://codereview.chromium.org/165155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23020 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in previous change. In AcceleratorHandler if there is nosky@chromium.org2009-08-111-0/+1
| | | | | | | | | | | WidgetGtk we should dispatch the event, not eat it. BUG=none TEST=none Review URL: http://codereview.chromium.org/165183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23009 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in AcceleratorHandler. It's possible to get events for GtkWidgetssky@chromium.org2009-08-071-0/+5
| | | | | | | | | | | | outside of those created by Chrome that we need to ignore. I saw this with drag and drop. BUG=none TEST=none Review URL: http://codereview.chromium.org/165150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22801 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out window creation into base::WindowImpl. This class will be used ↵jhawkins@chromium.org2009-08-072-238/+47
| | | | | | | | | | in place of CWindowImpl to reduce our dependency on ATL. BUG=none TEST=none Review URL: http://codereview.chromium.org/165022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22787 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that popups windows are not themed.mirandac@chromium.org2009-08-072-1/+16
| | | | | | | | | BUG= http://crbug.com/18093 TEST= While running Chrome with a theme installed, and force a popup. Note that the popup window is not themed. Review URL: http://codereview.chromium.org/159871 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22783 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a BAD_OVERRIDE defect reported by Coverity. Change thewtc@chromium.org2009-08-061-1/+1
| | | | | | | | | | | | | prototype of the GetDefaultThemeProvider method in the base class to match the prototypes of the GetDefaultThemeProvider methods in the subclasses BrowserFrameWin and BrowserFrameGtk. R=glen BUG=17104 TEST=none Review URL: http://codereview.chromium.org/159479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22568 0039d316-1c4b-4281-b951-d872f2087c98
* Make the DOMUIThemeSource load and pass through a PNG, rather than relying ↵glen@chromium.org2009-08-051-0/+3
| | | | | | | | | | | on decode/encode. BUG=18427 TEST=Install a giant theme, load the NNTP, verify that you can type in the omnibox without delay while the page is loading. Review URL: http://codereview.chromium.org/159891 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22457 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-20 09:04:05 +0000