summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Move compact navigation bar('s entry view) to main menu.oshima@chromium.org2010-02-111-4/+18
| | | | | | | | | | | | | | | | * Chagned main menu to use TYPE_WINDOW instead of POPUP. * Added hooks to close main menu when a user clicked non content area. (see MainMenuContainer::OnMousePressed and MainMenu::ActiveWindowChanged) * removed entry view from CompactNavigationBar view. We probably should rename this class (later). * Fixed a mouse coordinates issue in WidgetGtk: A location in the mouse event may not be in its gdk_window when it's originated from child gdk_window. * UIStyle's enum has to start with 0 * removed DLOG thas I checked in by accident. BUG=31766 TEST=manual: switch to compact navigation bar using ctrl-shift-c and confirm that no navigation entry in title bar. main menu has the navigation entry instead. Review URL: http://codereview.chromium.org/604015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38816 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed alignment of button dropdowns for RTL languages.avayvod@chromium.org2010-02-113-10/+26
| | | | | | | | | | | BUG=none TEST=Run chrome with LANGUAGE=ar or with --lang=ar. Verify that all status area menus as well as main menu are aligned properly (go to the right, not to the left). Review URL: http://codereview.chromium.org/601032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38807 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a simple class for animating a views bounds from one location tosky@chromium.org2010-02-113-0/+200
| | | | | | | | | | | | | another. This is just a starting point, I need to integrate a lot of other things to make this really useful, but it's a start and something I'm going to use for the login manager. BUG=none TEST=none Review URL: http://codereview.chromium.org/593051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38742 0039d316-1c4b-4281-b951-d872f2087c98
* CL implementing focus-dismissal of the chrome.experimental.popup set of ↵twiz@chromium.org2010-02-1011-5/+194
| | | | | | | | | | | | | | | | | extension APIs. Specifically, these changes cause a displayed pop-up to be dismissed when the focus shifts away from both the pop-up view, and the extension-view that launched the pop-up.I had to do a lot of investigating and trial-and-error to converge to the solution present here. I was hoping to be able to piggy-back on the existing FocusManager's various listener routines, but because the pop-up is hosted in a BubbleWidget, which is a separate top-level window with its own focus manager, I could not rely on a given focus manager to take care of the focus change notifications. To get around the above issue, I added a new type of focus listener that can listen on native-window focus change events. I added invocations to this listener throughout the Widget classes in the system so that registered listeners will be notified on focus change. I found some of the focus change events problematic, as the system will arbitrarily reassign the focus to the main browser window when shifting activation between chrome windows. (SeefocusManagerWin::ClearNativeFocus). To prevent this focus bounce from confusing focus listeners, I added a means to suppress notification of focus change during these operations. I added GTK and Mac stubs for the new widget functions that will assert when called. GTK and Cocoa development is not my expertise, so I thought // TODO(port) would be wiser.I'm uncertain of the best means to unit-test these changes. Direction in this regard would be appreciated. BUG=None TEST=None Review URL: http://codereview.chromium.org/552167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38685 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a bug where if there are only localstorage nodes, but nocookies nodes, ↵ian@chromium.org2010-02-101-4/+4
| | | | | | | | | the Remove and Remove All buttons are disabled.BUG=34886 TEST=clear all cookies, go to www.ianfette.com/localstorage.html and open cookies dialog, check that remove button is enabled. Review URL: http://codereview.chromium.org/596002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38640 0039d316-1c4b-4281-b951-d872f2087c98
* Remove redundant casts in g_signal_connect() throughout all gtk code we have.erg@chromium.org2010-02-108-39/+37
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/600033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38629 0039d316-1c4b-4281-b951-d872f2087c98
* Disable lables for disabled checkboxes. Original patch by Philippe Beaudoin ↵pkasting@chromium.org2010-02-092-6/+13
| | | | | | | | | (see http://codereview.chromium.org/567026 ), r=ben,me. BUG=22982 TEST=Go to Options->Personal Stuff->Import data from another browser...->From "Google Toolbar". Labels for disabled checkboxes should also look disabled. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38523 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in clear browsing data dialog where throbber would overlapsky@chromium.org2010-02-083-1/+19
| | | | | | | | | | | | flash link. BUG=35009 TEST=bring up clear browsing data, click clear browsing data and make sure throbber doesn't overlap flash link. Review URL: http://codereview.chromium.org/577054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38379 0039d316-1c4b-4281-b951-d872f2087c98
* Need to update enabled state of gtk wrapper even if native view hasn't been ↵davemoore@chromium.org2010-02-071-2/+0
| | | | | | | | | | | created Bug=None Test=None Review URL: http://codereview.chromium.org/577043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38321 0039d316-1c4b-4281-b951-d872f2087c98
* Rework nonclient hittest plumbing so the NonClientFrameView is responsible ↵pkasting@chromium.org2010-02-064-13/+16
| | | | | | | | | | for the whole window's hit testing. Make use of this in the glass frame to add support for HTSYSMENU. Doing this in the opaque frame will be more complex, so that's coming next. BUG=6961 TEST=Single- and double-clicks on the upper left corner of a Chrome window in Aero glass mode should trigger the system menu and the window closing, respectively. Review URL: http://codereview.chromium.org/573042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38301 0039d316-1c4b-4281-b951-d872f2087c98
* Rebuild app menu in ToolbarView::RunAppMenuxiyuan@chromium.org2010-02-061-3/+5
| | | | | | | | | | | | When "enable-udd-profiles" switch is set, update profile submenu and rebuild app menu if necessary. BUG=30417 TEST=Verify that comment 5 in issue 30417 is fixed. Review URL: http://codereview.chromium.org/571015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38281 0039d316-1c4b-4281-b951-d872f2087c98
* linux: build with -Wextraevan@chromium.org2010-02-052-5/+5
| | | | | | | | | | | | 95% of this is removing "const" from return types, but turning this on found one bug! (A "for" loop that expected its iterator to go negative but which was using an unsigned type.) BUG=34160 Review URL: http://codereview.chromium.org/570012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38266 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call View::DidChangeBounds() when the bounds didn't changedavemoore@chromium.org2010-02-051-6/+7
| | | | | | | | | Bug: None Test: Views based UI should still layout correctly Review URL: http://codereview.chromium.org/574013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38231 0039d316-1c4b-4281-b951-d872f2087c98
* Support app menu and double-click close on upper left corner of window, part ↵pkasting@chromium.org2010-02-058-128/+25
| | | | | | | | | | | | one. This makes things work right for windows that have an icon. The behavior of the main window is unchanged because right now it never returns HTSYSMENU anywhere. Part two of this change will be figuring out how to return that at the right place, which will make things Just Work. BUG=6961 TEST=Open an app or popup window. Single click the icon. The app menu should appear. Close it, then click-and-drag into the app menu. The item you release on should execute. Double-click the icon. The window should close. Review URL: http://codereview.chromium.org/577018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38187 0039d316-1c4b-4281-b951-d872f2087c98
* Adds link to flash settings on clear browser data panel.sky@chromium.org2010-02-043-18/+54
| | | | | | | | | | BUG=none TEST=bring up clear browsing data dialog and make sure it has a link to flash storage settings. Review URL: http://codereview.chromium.org/570030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38148 0039d316-1c4b-4281-b951-d872f2087c98
* Adding drag-drop support in and out of the Browser Action overflow menu.finnur@chromium.org2010-02-044-4/+27
| | | | | | | | | BUG=26990 TEST=Drag icons into and out of (and within) both the Browser Action container and its overflow menu. Review URL: http://codereview.chromium.org/570014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38135 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in disabling browser action from context menu onsky@chromium.org2010-02-023-5/+33
| | | | | | | | | | | | | | | | views/gtk. The crash occurred because on views we dispatch the menu action immediately (well, after the nested message loop exits), but on windows the action is posted after a delay. The code wasn't written to deal with immediate dispatch, so I changed the gtk code to post a task to dispatch activation. I've also added a warning that menu2 won't work on the stack, which has always been the case, just not stated. BUG=33619 TEST=see bug report. Review URL: http://codereview.chromium.org/557065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37835 0039d316-1c4b-4281-b951-d872f2087c98
* Get the initial selection work. and removed unnecessary initialization.oshima@chromium.org2010-02-024-7/+5
| | | | | | | | | BUG=33609 TEST=added the initial selected item in combobox example. Review URL: http://codereview.chromium.org/567004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37808 0039d316-1c4b-4281-b951-d872f2087c98
* Fix submenu leak in menu2.oshima@chromium.org2010-02-012-10/+34
| | | | | | | | | | | | Added "destroy" signal handler to delete menu2 only when the native gtk widget gets destroyed first. BUG=33475 TEST=chromeos valgrind tests passes without suppression. Review URL: http://codereview.chromium.org/557058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37708 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix linux views, part I don't even know how manypkasting@chromium.org2010-01-301-1/+0
| | | | | | | | | TBR=sky BUG=33314 TEST=none Review URL: http://codereview.chromium.org/558059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37619 0039d316-1c4b-4281-b951-d872f2087c98
* Try to add a useful comment about a case I hit today, at Scott's urging.pkasting@chromium.org2010-01-291-1/+6
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/558031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37554 0039d316-1c4b-4281-b951-d872f2087c98
* Suppressing a known leak erroroshima@chromium.org2010-01-291-0/+1
| | | | | | | | | | | | Seems like this was never executed in the test. TBR=viettrungluu@chromium.org BUG=33475 TEST=valgrind test should cycle green Review URL: http://codereview.chromium.org/553146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37495 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it so deleting a bookmark from the context menu doesn't closesky@chromium.org2010-01-287-24/+108
| | | | | | | | | | | | | the bookmark menu. BUG=2469 TEST=click on a bookmark folder on the bookmark bar, right click on an item and chose delete. Make sure the folder stays up and still works correctly (and the item you deleted isn't there). Review URL: http://codereview.chromium.org/551178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37424 0039d316-1c4b-4281-b951-d872f2087c98
* MoveAbove/SetAlwaysOnTop implementation for WidgetGtkoshima@chromium.org2010-01-271-2/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/548164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37312 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes unintialized read in networkmenu. Menu's constructor calls intosky@chromium.org2010-01-271-0/+6
| | | | | | | | | | | | | the delegate, making using 'this' in the member intializer list for creating a menu problematic. I've changed it to a scoped_ptr and created as needed. BUG=none TEST=none Review URL: http://codereview.chromium.org/552187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37298 0039d316-1c4b-4281-b951-d872f2087c98
* implement infobars and delegates placeholders for translate feature.kuan@chromium.org2010-01-272-64/+84
| | | | | | Review URL: http://codereview.chromium.org/546132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37281 0039d316-1c4b-4281-b951-d872f2087c98
* Add overflow menu to the browser action container (part 2 offinnur@chromium.org2010-01-272-11/+21
| | | | | | | | | | | | | | | | | supporting resize for the container). Also improved RTL support a bit (the divider wasn't drawn on the right side of the container and resizing was reversed). BUG=32101 TEST=Overflow menu for browser action container should now work. Make sure to test also right-clicking on a menu item in the overflow menu to bring up a context menu for that item. And resizing the container in RTL locales should work. Review URL: http://codereview.chromium.org/557006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37232 0039d316-1c4b-4281-b951-d872f2087c98
* Don't emit focus event when moving focus around when re-creating fixed widget.oshima@chromium.org2010-01-271-5/+75
| | | | | | | | | | | | - This fixes the crash in compact navigation bar without a adjustment. - I didn't remove the adjustment because ths is necessary to make the compact navigation bar transparent. (currently, the clipping code assumes that the fixed widget and the actual opaque child have the same side, which is not the case for AutocompleteEditView. BUG=chromium-os:1010 TEST=manual: compact nav bar does not crash. Review URL: http://codereview.chromium.org/548151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37198 0039d316-1c4b-4281-b951-d872f2087c98
* SingleSplitView exampleoshima@chromium.org2010-01-253-0/+89
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/555078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37031 0039d316-1c4b-4281-b951-d872f2087c98
* Resize and overflow for browser actions (part 1).finnur@chromium.org2010-01-223-0/+147
| | | | | | | | | | | | | | | | | | | | | | | | | This changelist implements the following: - A resize gripper and chevron in the browser action container - Overflow when icons don't fit - Snap to multiple of icon size (no excess pixels) - Animation when resizing container / adding&removing icons (disable, enable). - Persists the last width of the browser action container. Known issues: - No menu (yes, the chevron button doesn't do anything yet). BUG=32101 TEST=Install and uninstall browser actions & make sure install bubble appears in the right location. Make sure browser action container does not expand if chevron is showing when you add browser action. Make sure container loses chevron when no overflow occurs. Make sure browser action icons never disappear due to shrinking when you release the mouse (when resizing). Make sure snapping works. Review URL: http://codereview.chromium.org/553039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36905 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where submenus weren't working on views/gtk. Submenus end upsky@chromium.org2010-01-213-12/+52
| | | | | | | | | | | | | creating nested menus. This means that the menu Run is invoked on isn't necessarily the selected menu. I need to push up state to the menu run is invoked on, otherwise nothing happens when a menu is selected. BUG=32662 TEST=see bug Review URL: http://codereview.chromium.org/545142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36782 0039d316-1c4b-4281-b951-d872f2087c98
* submenu exampleoshima@chromium.org2010-01-201-1/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/549101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36663 0039d316-1c4b-4281-b951-d872f2087c98
* Tab-modal dialog improvements:zelidrag@google.com2010-01-151-1/+1
| | | | | | | | | | | | | | | | - treat constrained dialogs as tab-modal - only one shows at the time - added visual indication (tab pulsing) to the tab strip when a tab is blocked by a tab-modal dialog - blocked all UI activity from rendrer host and forced refocusing on constrained (tab-modal) dialogs This CL reverts http://codereview.chromium.org/384113 and instead incorporates the changes from http://codereview.chromium.org/392018. BUG=456,27585,27620 TEST=Go to http://www/~thakis/cgi-bin/test.html, hit esc. Review URL: http://codereview.chromium.org/541056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36415 0039d316-1c4b-4281-b951-d872f2087c98
* Makes WidgetGtk::GetBounds work if the widget_ is NULL (CloseNow hassky@chromium.org2010-01-111-1/+5
| | | | | | | | | | | | been invoked). We need to allow this so that GetBounds works if CloseNow is invoked but the destructor hasn't yet run. BUG=31975 TEST=see bug Review URL: http://codereview.chromium.org/536018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35971 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in WidgetGtk. WidgetGtk::GetBounds can end up crashing. Isky@chromium.org2010-01-081-1/+6
| | | | | | | | | | | | believe returning a location of 0x0 is effectively what Windows does too in this situation. BUG=none TEST=none Review URL: http://codereview.chromium.org/525105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35805 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most uses of EmptyString(), EmptyWString(), EmptyString16(), and ↵pkasting@chromium.org2010-01-081-2/+2
| | | | | | | | | | EmptyGURL(), since the code in question can just use the default constructor. BUG=none TEST=none Review URL: http://codereview.chromium.org/517054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35766 0039d316-1c4b-4281-b951-d872f2087c98
* Raise the window when showing the widget.oshima@chromium.org2010-01-071-1/+4
| | | | | | | | | | | | FindBar is behind other gdk window (i believe the tab content) when re-showing and is not visible. This fixed the issue. BUG=31735 TEST=None Review URL: http://codereview.chromium.org/519082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35752 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in menus on views/gtk. The crash would happen ifsky@chromium.org2010-01-072-5/+21
| | | | | | | | | | | | | | | between the time we called into the model when the user selected an item and the time MessageLoop::Quit is processed the menu was destroyed, we would crash. As MessageLoop::Quit isn't immediate, and we really don't want to call out from a nested message loop, we wait until the quit is processed, then notify the model. CROS_BUG=1108 TEST=see bug Review URL: http://codereview.chromium.org/521063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35746 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts change to native_view_host_gtk. This fixes the bug, but isn'tsky@chromium.org2010-01-071-2/+0
| | | | | | | | | | | | the right fix. Current code is correct. BUG=31132 TEST=none TBR=oshima Review URL: http://codereview.chromium.org/523141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35745 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug that resulted in background tabs not getting sizedsky@chromium.org2010-01-071-1/+3
| | | | | | | | | | | | | correctly. When using fixed like we are we need to explicitly call allocate, otherwise the child won't get a size allocate and correctly update itself. BUG=31132 TEST=see bug Review URL: http://codereview.chromium.org/525093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35719 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two related focus bugs on views/gtk:sky@chromium.org2010-01-073-3/+35
| | | | | | | | | | | | | | . Focus was inadvertently getting cleared when a window was shown because the focus-in event is received asynchronously. . In some situations we get multiple focus-out events in a row, this caused us to clear out who we thought would have focus. BUG=31140, 31130 TEST=see bugs Review URL: http://codereview.chromium.org/521045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35714 0039d316-1c4b-4281-b951-d872f2087c98
* Addded notification when ancestor gets changed. So windows that lack focus ↵georgey@chromium.org2010-01-0711-31/+380
| | | | | | | | | | | | | manager, because of being created on inactive tab, could do the necessary work when focus manager is actually attached. This is relevant for Windows only, but some support functions (FindAllRootViews) could be useful for other architectures as well. BUG=22481 TEST=in the bug Review URL: http://codereview.chromium.org/492025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35675 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a bunch of unnecessary .c_str() calls.pkasting@chromium.org2010-01-061-22/+22
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/527010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35657 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where recreating fixed in NativeViewHostGtk causes focus tosky@chromium.org2010-01-063-2/+46
| | | | | | | | | | | | | get lost. This caused problems when going in/out of fullscreen mode. I'm also improving the description of the WidgetGtk types. CHROMEOS_BUG=1020 TEST=see bug Review URL: http://codereview.chromium.org/518041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35594 0039d316-1c4b-4281-b951-d872f2087c98
* bsds: views/ and webkit/ support for FreeBSD/OpenBSDevan@chromium.org2009-12-312-4/+4
| | | | | | | | | - add a TOOLKIT_USES_GTK #define to catch GTK and Views+GTK - lots of ifdef twiddling Review URL: http://codereview.chromium.org/519030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35402 0039d316-1c4b-4281-b951-d872f2087c98
* linux: reduce header interdependenciesevan@chromium.org2009-12-291-0/+4
| | | | | | | | | | | | By analyzing gcc -H output, I found some of our worst offenders for headers bringing in other headers. native_web_keyboard_event.h was responsible for just under 60,000 extra includes! This change will in theory make the build faster. Review URL: http://codereview.chromium.org/524004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35326 0039d316-1c4b-4281-b951-d872f2087c98
* Clarify licenses on a bunch of files.evan@chromium.org2009-12-291-1/+1
| | | | | | | | | | | In this process, I also filed bugs on various projects we depend on that also have unclear licenses. BUG=28291 Review URL: http://codereview.chromium.org/521009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35323 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash/leak issue in native_view_host_gtk.cc.oshima@chromium.org2009-12-239-15/+40
| | | | | | | | | | | | | | | | * There are two path to NativeViewDetaching and we need to handle them differently. 1) Via gtk destroy signal. In this case, we should not try to remove the native view from parent because it's being deleted. 2) Through NativeViewHost::Detach(). In this case we need to remove the native view from parent because we added it to parent in NativeViewAttached(). * Fix NativeControlGtk not to destroy the native view because it's now destoryed by NativeViewHostGtk. * Fixed TabContentViewGtk so that it owns the nativew view. The native view was destroyed when Detached. * Added more checks so that test can catch regression. BUG=26154 TEST=The same procedure in bug should now pass. I added several checks that lead tests to fail if this problem exists. Review URL: http://codereview.chromium.org/510004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35220 0039d316-1c4b-4281-b951-d872f2087c98
* Add GridLayout::SetInsets(const gfx::Insets& insets).satorux@chromium.org2009-12-232-0/+10
| | | | | | | | | | | | | | | | | Per the style guide, function overloading like this is allowed. http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Function_Overloading#Function_Overloading I wanted this API so I could define and use a constant like: const gfx::Insets kSomeInsets(1, 2, 3, 4); layout->SetInsets(kSomeInsets); BUG=none TEST=try Review URL: http://codereview.chromium.org/509027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35209 0039d316-1c4b-4281-b951-d872f2087c98
* Change chromeos build to use viewsoshima@chromium.org2009-12-221-3/+0
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/508025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35186 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 21:09:53 +0000