| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Capture the keyboard and mouse events directly from X, create a corresponding
views::Event out of it, and send it to the associated RootView.
Includes Chad's (wyck) function FindRootViewForGdkEvent (from #3704005) slightly
modified (called FindRootViewForGdkWindow).
BUG=None
TEST=Click/Keypress events in a webpage should work correctly.
Review URL: http://codereview.chromium.org/3801011
Patch from Sadrul Chowdhury <sadrul@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* ResetMenu now simply remove all menu items.
* This will closes all submenus opened. It require
a lot more work to update submenus correctly.
Since there is no scenario that requires this so
this is good enough for our use case.
BUG=chromium-os:8106
TEST=manual: on chromeos device, open network menu and change network settings. (plug-unplug ethernet)
Review URL: http://codereview.chromium.org/4120002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59720
TEST=see bug
Review URL: http://codereview.chromium.org/3960004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
requests.
Renderer may issue multiple ContextMenu request even if the menu is open.(this happenes when renderer receives mouse events before context menu is actually opened by previous request.)
This is causing a crash in menu2 (both domiu/gtk impl) because menu2 has nested message loop, and the menu object gets deleted by 2nd request while it's handling message loop.
This CL addresses this issue by creating separate object to handle
the nested loop. Use only variables on stack and do not touch
instance variable if the menu is already deleted.
BUG=chromium-os:7929, chromium-os:7228
TEST=manual. on a page, continously click mouse to open/close context menu.
It used to crash at some point, but shouldn't crash with this patch.
Review URL: http://codereview.chromium.org/4046004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
some test
bots.
BUG=44991
TEST=none
Review URL: http://codereview.chromium.org/3992005
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/4028002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
bots.
BUG=44991
TEST=none
Review URL: http://codereview.chromium.org/3992005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Remove the ViewAccessibilityWrapper class. The view can directly manage it's ViewAccessibility.
2. Always use GetAccessibleForView to retrieve a view's associated accessibility object. This ensures that the correct accessibility object is returned for native view host objects.
3. Update get_accFocus to use FocusManager.
4. Move oleacc guid definitions to view_win.cc.
BUG=none
TEST=interactive_ui_tests:BrowserViewsAccessibilityTest.TestBrowserRootViewAccObj
TEST=Manual: I can select the accessibility object of a native view host within AccExplorer32.exe.
Review URL: http://codereview.chromium.org/4047001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23581
Review URL: http://codereview.chromium.org/3885003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
accessibility extension API on Windows. This adds a few more
accessibility events to views accessibility while we're at it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3999001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, which is specifically for TOUCH_UI builds, mouse-related
messages are hijacked from the normal Gdk event dispatcher and processed
manually in the file touchui/touchui.cc. GdkEvents are converted directly
to views events, and dispatched to the RootView. This is preliminary work
that will be followed by more elaborate message pump changes, and ultimately
is in the spirit of removing Gtk entirely for TOUCH_UI (Chromium-Views-Gtk).
Patch from Chad Faragher <wyck@chromium.org>
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3704005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
screenreaders. Rename AccessibleToolbarView to AccessiblePaneView to reflect
that it covers more than just toolbars. Also add infobars to the F6 pane
traversal.
BUG=372
TEST=none
Review URL: http://codereview.chromium.org/3722004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
speficied point in view accessibility's accHitTest.
Previously accHitTest would
1. Only return a direct child that contained the specified point (accHitTest was called repeatedly until it returned CHILDID_SELF).
2. Always return a VT_I4 variant for a view that has no children instead of returing an IAccessible interface (which didn't work with the AT programs for some reason).
BUG=none
TEST=Manual: NVDA reads views on mouse overwith no children on mouse over like toolbar buttons.
TEST=Manual: AccExplorer32 and Inspect32 can select views with no children.
Review URL: http://codereview.chromium.org/3890003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This also removes DEBUG_MENU. I don't think the extra ints are a big deal. They should be optimized away in release mode. Also fixes a spelling error and converts some silly code to using early returns.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3908004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
don't correctly return a preferred/minimum size and the options dialog
can end up getting clipped (because the cached size is too
small).
Also, makes the options window always use the minimum size when
showing. This way if we happen to remove an option such that the
dialog is smaller the dialog won't end up too big.
BUG=59122
TEST=With aero enabled bring up the options dialog on M6/M7. Then bring up
the options dialog with this fix enabled and make sure you don't get
any clipping.
Review URL: http://codereview.chromium.org/3825006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
"Base" class name prefix and put in the app::win namespace.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3822007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base/win/windows_version. Many files now only need to include this instead of all of win_util.
Remove a bunch of unused code from base/win_util. There was a surprising amount.
Replace the AppUserModel property key with the one from the SDK now that we use the Win7 SDK. Move GetLogonSessionOnlyDACL from win_util to ipc since it's only used in that one place.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3823002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It seems ListView_RemoveAllGroups disables groups on Win XP, so we re-enable them afterwards.
BUG=55452
TEST=Group headers in table views should be visible on XP
Review URL: http://codereview.chromium.org/3760002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3750001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I also had to make it so you can turn off animations in CustomButton.
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3544015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Necessary for view_examples to compile with GYP_DEFINES="chromeos=1".
BUG=http://code.google.com/p/chromium-os/issues/detail?id=7409 (temporary fix)
TEST=build all in chrome repo with chromeos=1
Review URL: http://codereview.chromium.org/3614008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
was not correctly resetting state when the child was switched. In
particular it wouldn't remove the clip when switching, which meant that
if we switched back to an hwnd we had installed a clip we wouldn't
reset the clip when we should have.
BUG=57573
TEST=see bug
Review URL: http://codereview.chromium.org/3605010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also make BubbleWindow title left aligned per mock and fix wrong
background color for DialogClientView by setting bg color to widget style.
BUG=chromeium-os:6305
TEST=Verify js dialog on chrome os is in new bubble look again.
Review URL: http://codereview.chromium.org/3598008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
crash.
BUG=56842
TEST=see bug
Review URL: http://codereview.chromium.org/3552008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=55902
TEST=Renderer accessibility is not enabled on stock windows tablets.
Review URL: http://codereview.chromium.org/3575013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few key design points.
* Uses DOMView to render menu content.
* MenuUI (subclass of DOMUI) uses GtkWiget tree to access
WidgetGtk and MenuModel. Alternative way was to change
TabContents::GetDOMUIForCurrentState() public and pass them throught it, but this seems to work fine.
* Input/Focus is controlled by gtk_grab_add. Input is grabbed by the root widget, and then sent to each active menu widget via gtk_grab_add.
* Menu gets shown after the renderer rendered the content
(thus has some size) to avoid showing small/empty menu.
Mouse processing is blocked until the menu is shown (see Dispatcher).
A few issues that will be addressed in separate CL
* RTL (will be after beta)
* menu scroll. working on it now.
* menu sometimes show scroll bar. (I just need to disable it)
* unit test for native_menu_domui
BUG=chromiun-os:6497
TEST=manual for now. all menu2 based meus should work as before (web pages's context menu, system menu, forward/back menu and several chromeos specific one) except for following two:
* mnemonic should work now on context menus.
* menu larger than screen does not scroll. I'll implement this in separate CL
Review URL: http://codereview.chromium.org/3442018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
text buttons in the wrench menu.
Add breaks to GetAccessibleState switch statements.
BUG=51738
TEST=Verify in NVDA and JAWS that text buttons are read without mnemonic and with keyboard shortcut.
Review URL: http://codereview.chromium.org/3612001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderWidgetHostViewViews class to replace RenderWidgetHostViewGtk in
the case of TOUCH_UI. This change shouldn't affect non-TOUCH_UI builds
and is not yet complete for a number of event types and corner cases,
but is sufficient to get in so that work on the touch keyboard and touch
events can proceed in parallel with GTK removal.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3415005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Windows screenreaders.
BUG=none
TEST=manual testing with and without JAWS and NVDA screenreaders.
Review URL: http://codereview.chromium.org/3598003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
so that DOMUI menu can use the same image.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3435033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to remove gtk dependency from menu2 code in chromeos and to make DOMUI transition smooth (crosbug.com/6497)
Removed LanguageSwitchModel::GetFirstLevelMenuWidth as this does not seem to be used by anyone.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3533001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add Widget::IsAccessibleWidget() that will return true when Chrome can be customized screen reader users.
BUG=37357,55902
TEST=JAWS or NVDA users have "(Incognito)" in their window title. Tablet users are unaffected.
Review URL: http://codereview.chromium.org/3427026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
parameter. GetAccessibleName still needs to be converted.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/3416033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and eliminate the dependency on individual frontends from cross platform code.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3398015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/chromium-os/issues/detail?id=5604
TEST=Ensure opening and closing widgets behaves normally. Check for further crashes in WidgetGtk::IsActiveChanged().
Review URL: http://codereview.chromium.org/3452025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This actual window title remains the same.
BUG=37357
TEST=Screen readers read "Incognito" for browser windows that are off the record.
Review URL: http://codereview.chromium.org/3400028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=dmazzoni.
Review URL: http://codereview.chromium.org/3444021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change checks the states of ctrl and shift keys when proceesing acclerators to prevent FocusManager from consuming ctrl+alt keys and shift+alt keys. Windows sends SC_KEYMENU commands not only when we type only an alt key but also when we type ctrl+alt keys and shift+alt keys, both are used for changing input languages and keyboard layouts. To prevent these keys from being accidentally consumed by FocusManager, we check the states of these keys and send them to FocusManager.
BUG=45091
TEST=interactive_ui_tests.exe --gtest_filter=KeyboardAccessTest.TestShiftAltMenuKeyboardAccess.
Review URL: http://codereview.chromium.org/3318022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
string_split.h
BUG=None
TEST=trybos
Review URL: http://codereview.chromium.org/3447008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove logging.h and other headers where possible.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3461019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
users ..."
This reverts commit 60342.
TBR=dtseng
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3472008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
that the confirmation has appeared and alleviates the need to hunt for these controls.
BUG=37360
TEST=Confirm that focus lands correctly on the "save" button when logging into a site and offer to save passwords is enabled.
Review URL: http://codereview.chromium.org/3405026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
set the password boolean field.
Review URL: http://codereview.chromium.org/3353005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For items added to context menus by extensions, we display the extension's
icon next to the top-level item. To display this icon, we use owner-draw
mode, and it turns out that our code was assuming that we didn't
need to tell windows about the labels of items in owner-draw mode.
BUG=54497
TEST=Steps are outlined in the bug. Also all things menu related should be
tested on windows.(wrench menu, context menus in web content, bookmark bar
items, browser actions, etc.)
Review URL: http://codereview.chromium.org/3402005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In a dialog, the contents view is added after the buttons have been added. That would mess up the focus traversal order.
The problem was particularly visible in the basic auth dialog.
This CL ensures the contents is added as the first view so the focus chain is right.
BUG=42803
TEST=Open the options dialog. Make sure pressing Tab/Shift-Tab moves the focus correctly.
Visit http://handle.library.cornell.edu/control/authBasic/authTest/ a basic auth dialog is shown. Make sure Tab/Shift-Tab moves the focus as expected.
Review URL: http://codereview.chromium.org/3403002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
invisible menu items.
BUG=54800
TEST=see bug
Review URL: http://codereview.chromium.org/3315021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sets the initial allocation for a widget when a size is passed in to
WidgetGtk::Init(). The timing of the init call as part of creating a
new tab contents view means that the arrangment of the hierarchy isn't
complete yet, so incorrect contents get shown. This goes back to the original behavior which is to ignore the initial size request (it's now ignored at the TabContentsViewGtk::CreateView level instead of being implicitly ignored in the WidgetGtk::Init code).
BUG=53870
TEST=Create new tabs, no flash of old tabs seen.
Review URL: http://codereview.chromium.org/3290016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bigger. When you switch to side tabs we end up in a situations where
if you ask for the computed requested size you'll get a larger
value than the current bounds of the window. Gtk sees this and sizes
the window. We really don't want to derive the requested size of
WidgetGtk when used a window from the contents, instead we want it to
be empty or use an explicitly set value.
BUG=53654
TEST=see bug
Review URL: http://codereview.chromium.org/3300023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Screenshot: http://imgur.com/yxEzO.png
BUG=39252
TEST=PluginExceptionsTableModel.*
Review URL: http://codereview.chromium.org/3307014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=export GYP_DEFINES="toolkit_views", gclient runhooks,
make -k view_examples,
out/Debug/view_examples
Go to the Trobber tab, see the throbber spinning.
Review URL: http://codereview.chromium.org/3345010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is part of a series of changes to bring TouchEvent
processing to views.
BUG=na
TESTED=compiled with and without touchui
Review URL: http://codereview.chromium.org/3192002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58823 0039d316-1c4b-4281-b951-d872f2087c98
|