summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Canvas refactoring Phase 4a:ben@chromium.org2010-06-294-14/+13
| | | | | | | | | | | Move Save, SaveLayerAlpha and Restore onto gfx::Canvas. BUG=none TEST=none Review URL: http://codereview.chromium.org/2846035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51179 0039d316-1c4b-4281-b951-d872f2087c98
* Disables another crashing test.sky@chromium.org2010-06-281-1/+2
| | | | | | | | | | BUG=45015 TEST=none TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/2880004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51020 0039d316-1c4b-4281-b951-d872f2087c98
* Disables TableViewTest.PersistMultiSelectionOnChangeWithSort as it issky@chromium.org2010-06-281-1/+1
| | | | | | | | | | | | crashing. BUG=45015 TEST=none TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/2821021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50989 0039d316-1c4b-4281-b951-d872f2087c98
* Mark TreeViewTests.PersistMultiSelectionOnSort as DISABLED_. glotov@chromium.org2010-06-281-1/+1
| | | | | | | | | | Test crashes on Vista bot. BUG=4354 TEST="Vista Tests (dbg)(1)" should cycle green. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50974 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring part 3.ben@chromium.org2010-06-2521-89/+89
| | | | | | | | | | | | | | - Replace Canvas instance users with CanvasSkia users. - Rename Canvas2 to Canvas. - Delete Canvas subclass of CanvasSkia. This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50854 0039d316-1c4b-4281-b951-d872f2087c98
* Changes mnemonics for bookmark menus to show the mnemonics if eithersky@chromium.org2010-06-253-14/+58
| | | | | | | | | | | | | the os says we should, or focus was on the button that triggered showing the menu. Also changes mnemonic processing to not guess at mnemonic if menu has mnemonics. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2831031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50852 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome/win: Show preview images when dragging images.thakis@chromium.org2010-06-254-6/+27
| | | | | | | | | BUG=11457 TEST=Go to google.com, drag logo around. Should be attached to cursor. Review URL: http://codereview.chromium.org/2870026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50830 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50784 - Canvas refactoring part 3.ben@chromium.org2010-06-2422-89/+89
| | | | | | | | | | | | | | | | | | - Replace Canvas instance users with CanvasSkia users. - Rename Canvas2 to Canvas. - Delete Canvas subclass of CanvasSkia. This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API. BUG=none TEST=none Review URL: http://codereview.chromium.org/2825018 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/2811032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50790 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring part 3.ben@chromium.org2010-06-2422-89/+89
| | | | | | | | | | | | | | | - Replace Canvas instance users with CanvasSkia users. - Rename Canvas2 to Canvas. - Delete Canvas subclass of CanvasSkia. This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API. BUG=none TEST=none Review URL: http://codereview.chromium.org/2825018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50784 0039d316-1c4b-4281-b951-d872f2087c98
* Fix radiobuttons and connect up child widgets again.dtseng@chromium.org2010-06-245-3/+19
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2806030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50778 0039d316-1c4b-4281-b951-d872f2087c98
* Default to GTK_WRAP_WORD_CHAR for multiline textfield on Gtk.xiyuan@chromium.org2010-06-241-0/+3
| | | | | | | | | BUG=chromium-os:4258 TEST=Verify fix for chromium-os:4258. Review URL: http://codereview.chromium.org/2824026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50723 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring part 2.ben@chromium.org2010-06-2313-33/+40
| | | | | | | | | | | | - Rename Canvas to CanvasSkia. - Create a subclass Canvas that inherits from CanvasSkia for compatibility. BUG=none TEST=none Review URL: http://codereview.chromium.org/2862025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50664 0039d316-1c4b-4281-b951-d872f2087c98
* Replace wstring with string16 in history. The only time wstring is used now ↵brettw@chromium.org2010-06-231-2/+4
| | | | | | | | | | | | in history is for bookmark-related stuff (the bookmarks system is still wstring-based). The substantial change here is in RTL to make a string16 variant of the functions and in changing the WordIterator to use string16 (this cleaned up some weird utf-32 code). TEST=none BUG=none Review URL: http://codereview.chromium.org/2808017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50597 0039d316-1c4b-4281-b951-d872f2087c98
* Canvas refactoring part 1.ben@chromium.org2010-06-221-5/+5
| | | | | | | | | | | - Introduce a new Canvas2 interface. This will become the way that everyone talks to Canvas. It is populated primarily with the cross-platform methods from Canvas. - Make Canvas implement this interface. - Hook it up to the Windows RootView. Review URL: http://codereview.chromium.org/2866010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50543 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in menus and makes widgetgtk not send outsky@chromium.org2010-06-223-5/+17
| | | | | | | | | | | mousemove if the event is the result of a grab. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2841018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50529 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the extension resize gripper only visible when the mouse is oversky@chromium.org2010-06-223-5/+45
| | | | | | | | | | | it. BUG=45750 TEST=see bug Review URL: http://codereview.chromium.org/2800022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50515 0039d316-1c4b-4281-b951-d872f2087c98
* Small tweaks to improve toolbar keyboard accessibility: Put focus rectsdmazzoni@chromium.org2010-06-224-14/+9
| | | | | | | | | | | | | around more controls (including location bar, only when in full keyboard access mode). Fix accessible names. Fix spacebar to activate menu buttons. Remove methods for child focus, they're not needed anymore. BUG=none TEST=none Review URL: http://codereview.chromium.org/2817022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50462 0039d316-1c4b-4281-b951-d872f2087c98
* *Add WidgetGtk::ClearNativeFocus so that subclass can implement cutomized ↵oshima@chromium.org2010-06-193-9/+13
| | | | | | | | | | | | | | behavior when clearning native focus. This is necessary in ScreenLocker as the focus has to be set to the widget that is grabbing all input focus. * PasswordField that will set focus it itself when mouse is clicked. This is necessary again when the input is grabbed by other widget because the gtk textfield will never receive mouse event. * fix minor bug : locating the grab widget in wrong place. Review URL: http://codereview.chromium.org/2811015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50303 0039d316-1c4b-4281-b951-d872f2087c98
* Keep a cache of all views that have sent notifications. This ensures that ↵dtseng@chromium.org2010-06-189-8/+136
| | | | | | | | | | AccessibleObjectFromEvent works properly. BUG=9601 TEST=none Review URL: http://codereview.chromium.org/2823009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50302 0039d316-1c4b-4281-b951-d872f2087c98
* Mark TableViewTest.PersistSelectionOnSort and PersistMultiSelectionOnSort as ↵mattm@chromium.org2010-06-181-2/+2
| | | | | | | | | | | | | fails. (They were re-enabled in 50245) BUG=45015 TBR=nkostylev Review URL: http://codereview.chromium.org/2807008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50282 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for radio menu items to bookmark menus.sky@chromium.org2010-06-186-26/+141
| | | | | | | | | BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2846014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50246 0039d316-1c4b-4281-b951-d872f2087c98
* TableViewTests.Sort* started crashing. Marking as DISABLED_.nkostylev@google.com2010-06-181-10/+10
| | | | | | | | | | | | | | Revert 48168 - Mark TreeViewTests as FAILS_ rather than DISABLED_ TBR=jcivelli BUG=45015 Review URL: http://codereview.chromium.org/2171006 TBR=rafaelw@chromium.org Review URL: http://codereview.chromium.org/2824016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50245 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for click-drag-release on views embedded in a menu tosky@chromium.org2010-06-182-5/+124
| | | | | | | | | | | behave as if the user initially clicked on the view. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2841009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50244 0039d316-1c4b-4281-b951-d872f2087c98
* Mark TreeViewTests.Sort as DISABLED_.nkostylev@google.com2010-06-181-1/+1
| | | | | | | | | | | Test crashes on Vista bot. BUG=45015 TBR=rafaelw Review URL: http://codereview.chromium.org/2870013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50241 0039d316-1c4b-4281-b951-d872f2087c98
* Improve toolbar keyboard accessibility.dmazzoni@chromium.org2010-06-1818-381/+715
| | | | | | | | | | | | Design doc: https://docs.google.com/a/google.com/Doc?docid=0ATICCjR-gNReY2djdjkyNnNfNzl4ZnpiODQ2Mg&hl=en BUG=40745 BUG=36728 BUG=36222 TEST=New test added to focus_manager_unittest.cc Review URL: http://codereview.chromium.org/2737010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50234 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks for the merged menu:sky@chromium.org2010-06-178-27/+75
| | | | | | | | | | | | | | | | | | | | | . makes the menu show the same fonts regardless of whether the item has children. . adds text color to MenuConfig. I'm going to use this for the buttons added to the menu. . Changes TextButton to update text_size_ when the font changes. . Changes TextButton to allow you to specify how accelerators are shown. . Nukes TextButton::OnMousePressed as it's not needed (super implementation does the right thing and updates state the TextButton::OnMousePressed wasn't). . Changes accelerator to have constructor taking keycode and modifiers. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2833013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50108 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for UI issues on AutoFill dialog on Windows.georgey@chromium.org2010-06-162-2/+10
| | | | | | | | BUG=46525 TEST=In the bug. Review URL: http://codereview.chromium.org/2802005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50040 0039d316-1c4b-4281-b951-d872f2087c98
* Add accessibility support for Textfields in Windows.dtseng@chromium.org2010-06-162-0/+84
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2791003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49955 0039d316-1c4b-4281-b951-d872f2087c98
* Allow widgets to have keyboard shortcuts.avayvod@chromium.org2010-06-163-24/+7
| | | | | | | | | BUG=cros:3956 TEST=Check that keyboard shortcuts work on login screens. Review URL: http://codereview.chromium.org/2857004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49929 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at:sky@chromium.org2010-06-156-21/+163
| | | | | | | | | | | | | | | | Changes the tab close button to a dot, unless you're near the button or the tab is selected. The only difference between this and the first is that I missed a remove from the set if the view was deleted, which resulted in a crash. I've added an interactive test case that covers this. BUG=45743 TEST=none Review URL: http://codereview.chromium.org/2863003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49828 0039d316-1c4b-4281-b951-d872f2087c98
* Unicode bidi mirroring characters are not correctly mirrored in textfield ↵xji@chromium.org2010-06-152-12/+74
| | | | | | | | | | | | | | | | | | | | | | | | | | | | and omnibox (which use CRichEditCtrl) while *inputting*. Since bidi mirroring characters are correctly mirrored when rendering the whole text, fix it by re-rendering the whole text every time the text changes. NOTE: this change will mess up the undo queue. The continuous keystroke wont be treated as one undo event. Every single keystroke is treated as a undo state. Using the following as example: 1. paste string "abcd " into find-in-page; 2. type in 'e', 'f', and ' '. 3. paste string "xyz". When undo, the string sequence will be: "abcd ef xyz" => "abcd ef " ==> "abcd ef" ==> "abcd e" ==> "abcd " =>"". Without the change, the string sequence is: "abcd ef xyz" => "abcd ef " => "abcd " =>"". BUG=46298 TEST=follow the steps described in the bug. Review URL: http://codereview.chromium.org/2741007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49811 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 49795 - Changes the tab close button to a dot, unless you're near the ↵sky@chromium.org2010-06-156-162/+21
| | | | | | | | | | | | | | | | | | | button or the tab is selected. I'm not to keen on the mouse near names, if you have better ideas please say so. BUG=45743 TEST=none Review URL: http://codereview.chromium.org/2796006 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/2823005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49801 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the tab close button to a dot, unless you're near the buttonsky@chromium.org2010-06-156-21/+162
| | | | | | | | | | | | | | or the tab is selected. I'm not to keen on the mouse near names, if you have better ideas please say so. BUG=45743 TEST=none Review URL: http://codereview.chromium.org/2796006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49795 0039d316-1c4b-4281-b951-d872f2087c98
* Notification balloons don't want the WS_EX_LAYOUTRTL style flag, since the ↵johnnyg@chromium.org2010-06-144-5/+20
| | | | | | | | | | | directionality of the content is specified already inside the HTML. BUG=46170 TEST=create a notification while using an RTL language for Chrome UI. Review URL: http://codereview.chromium.org/2794001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49723 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tooltip wrap problem per chromium-os:4042xiyuan@chromium.org2010-06-141-5/+0
| | | | | | | | | | | Remove the max width chars logic and let GtkLabel decide how to wrap. BUG=chromium-os:4042 TEST=Verify fix for chromium-os:4042 Review URL: http://codereview.chromium.org/2832003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49721 0039d316-1c4b-4281-b951-d872f2087c98
* Draw transparent background on window_content() only for TYPE_CHILD.oshima@chromium.org2010-06-111-2/+2
| | | | | | | | | | | Transparent background is draws on GtkWindow for window types. This was necessary only for TYPE_CHILD. BUG=43611 TEST=type something in address bar and you'll see no flicker on dropdown. Review URL: http://codereview.chromium.org/2797001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49581 0039d316-1c4b-4281-b951-d872f2087c98
* Same issue as in omnibox, keyboard layout change inside DefWindowProc() inxji@chromium.org2010-06-101-2/+23
| | | | | | | | | | | | NativeTextfieldWin::HandleKeystroke(). Restore keyboard layout after DefWindowProc(). BUG=14049 TEST=open find-in-page, type in pure Hebrew, press HOME/END/shift-HOME/shift-END, keyboard layout should not be changed. Review URL: http://codereview.chromium.org/2738008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49455 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for showing accelerators in bookmark menus.sky@chromium.org2010-06-0910-25/+122
| | | | | | | | | BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2742003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49335 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup of about boxseanparent@google.com2010-06-093-1/+14
| | | | | | | | | | | | | | | | | Removed redundent version from update string. Added a line break to the ChromeOS version on test builds to improve appearence (select and drag to see complete version). Added margins to multiline edit fields without borders to make them match single line edit fields in positioning. Fixed an issue with setting the initial focus for GTK based windows. This fixes the problem of the cursor showing up in the version field. BUG=chromium-os:3571 1589 2967 TEST=none Review URL: http://codereview.chromium.org/2620003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49322 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it so child views of menuitemview can be traversed with thesky@chromium.org2010-06-0915-56/+250
| | | | | | | | | | | | | keyboard. Because I don't want the menu to actually get focus I'm using SetHotTracked when traversing and AcceleratorPressed from enter/return. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2741004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49270 0039d316-1c4b-4281-b951-d872f2087c98
* Draw composited widget's content only after something is drawn.oshima@chromium.org2010-06-091-5/+9
| | | | | | | | | | | This was causing ugly flicker when screen locker is shown. BUG=none TEST=none Review URL: http://codereview.chromium.org/2717002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49232 0039d316-1c4b-4281-b951-d872f2087c98
* MessageBubble which does not require separate window and does not grab input ↵oshima@chromium.org2010-06-072-13/+14
| | | | | | | | | | | | | | | | | | | | on mouse press event. * Added new constructor to InfoBubble for chromeos which takes WidgetGtk::Type parameter * Made DoGrab/HandleGrabBroke so that subclass can customize its behavior. * Added MessageBubble::ShowNoGrab that shows a child MessageBubble which does not grab input on mouse press event. * Explicitly remove accelerator when closed. This is necessary for child, but doing for all case as it's harmless to do so. * Moved HandleGrabBroke to protected and made virtual so that sub class can trap the event. ScreenLocker will use this event to detect this. This will be used for screen locker. BUG=none TEST=none Review URL: http://codereview.chromium.org/2682004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49068 0039d316-1c4b-4281-b951-d872f2087c98
* views: Use FRIEND_TEST_ALL_PREFIXES.tfarina@chromium.org2010-06-051-5/+5
| | | | | | | | | BUG=44549 TEST=trybots Review URL: http://codereview.chromium.org/2699003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49011 0039d316-1c4b-4281-b951-d872f2087c98
* Add cross platform Widget::InitWithWidget(parent, const gfx::Rect& bounds);oshima@chromium.org2010-06-057-10/+32
| | | | | | | | | | | | | On linux, native parent has to be either window_contents or widget depending of the type of wiget. InitWithWidget takes a parent Widget instead of native and hides these details. I also cleaned up a few dead/duplicated code. BUG=none TEST=none Review URL: http://codereview.chromium.org/2355003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48990 0039d316-1c4b-4281-b951-d872f2087c98
* Create CompositePainter once for a widget instead of ref count.oshima@chromium.org2010-06-021-26/+14
| | | | | | | | | | | | | | | There is a issue in adding new composited child after the ref count of painter became zero. RefCount::Release does not tell if it's been deleted so it can't remove the painter key from G_OBJECT(widget). I could have changed RefCounted::Release to return true, but I took this approach because new child will be added later in most use case (like info bubble), and it's more efficient to keep the painter rather than creating and deleting each time. BUG=none TEST=none Review URL: http://codereview.chromium.org/2449010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48757 0039d316-1c4b-4281-b951-d872f2087c98
* Added const to image parameters for ImageButton class.avayvod@google.com2010-06-022-10/+13
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2418003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48748 0039d316-1c4b-4281-b951-d872f2087c98
* Process accelerators if grabbed widget is a window.xiyuan@chromium.org2010-06-021-4/+17
| | | | | | | | | | | Update the gtk event filtering logic to process key events for grabbed window (i.e. modal dialog). BUG=chromium-os:3701 TEST=Verify fix for chromium-os:3701. Review URL: http://codereview.chromium.org/2455004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48742 0039d316-1c4b-4281-b951-d872f2087c98
* views: implement a TODO to move WidgetGtk::GetWindowForNative to WindowGtk.tfarina@chromium.org2010-06-025-25/+24
| | | | | | | | | BUG=NONE TEST=compiles. Review URL: http://codereview.chromium.org/1640003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48717 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing AutoReset to be a template.gspencer@chromium.org2010-06-012-2/+2
| | | | | | | | | | | I've run into a couple of times this week when I needed one of these, for two different types besides bool. Time to fix the TODO. TEST=trybots FTW, and built locally. BUG=none Review URL: http://codereview.chromium.org/2394001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48644 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move BoxLayout class into views/examples directory.tfarina@chromium.org2010-05-284-58/+95
| | | | | | | | | | | Also add horizontal support as well. BUG=None TEST=out/Debug/view_examples, see Widget tab. Review URL: http://codereview.chromium.org/2145001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48460 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-27 11:58:00 +0000