summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Adds code to reset cursor on leave. We need to do this or cursor cansky@chromium.org2009-10-132-0/+9
| | | | | | | | | | | get stuck. BUG=none TEST=none Review URL: http://codereview.chromium.org/274008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28787 0039d316-1c4b-4281-b951-d872f2087c98
* Misc. cleanup for theme provider code, including:pkasting@chromium.org2009-10-132-18/+9
| | | | | | | | | | | | | | | | | | | | | * Use correct indentation/alignment in a number of places * Use early-return to avoid long code block indenting * Use for() instead of while() in cases where that's what the code is actually doing * Consistent naming for iterators ("foo_iter", "bar_iter" instead of sometimes that way and sometimes "found") * Use {} when needed, don't use when not * Do not use "else" after "return" * Shorten overly-verbose code * Pull some trivial functions into the header * Eliminate unused function * Use STLDeleteValues() helper where appropriate Some of this was originally in my patch that modified constness, but I've split it out to make that more sane. BUG=none TEST=none Review URL: http://codereview.chromium.org/272033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28771 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 28716 - Gets blocked popups to work on views/gtk. I had to fix a ↵nsylvain@chromium.org2009-10-133-19/+1
| | | | | | | | | | | | | | | | | | | | | | | couple of additional things here: . Avoid doing anything in OnSizeAllocation if the size hasn't changed. Because of how gtk works I was getting stuck in a loop if I OnSizeAllocate did anything if the size hadn't changed. . Applied similar shortcut to TabContentsViewGtk. . Made SimpleMenuModel only ask delegate for checked state if the item is a check. BUG=none TEST=none Review URL: http://codereview.chromium.org/261051 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/267069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28768 0039d316-1c4b-4281-b951-d872f2087c98
* Add explicit dependency to x11. This comes from webkit as well, but ↵oshima@chromium.org2009-10-121-1/+1
| | | | | | | | | | | | | views/gtk depends on this, and a program that uses views without webkit fails to link. BUG=None TEST=None Review URL: http://codereview.chromium.org/270054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28763 0039d316-1c4b-4281-b951-d872f2087c98
* Converts some uses of native_view to native_window. This is necessitatedsky@chromium.org2009-10-1211-41/+34
| | | | | | | | | | | | by wanting to parent bookmarkeditor to browserwindow, which returns a native_window. BUG=none TEST=none Review URL: http://codereview.chromium.org/270067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28728 0039d316-1c4b-4281-b951-d872f2087c98
* AppendText was appending twice due to bad merge happened in the past.oshima@chromium.org2009-10-122-5/+8
| | | | | | | | | | | Added append scenario to view_examples BUG=None TEST=run unit_tests and verify with view_examples. Review URL: http://codereview.chromium.org/271055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28724 0039d316-1c4b-4281-b951-d872f2087c98
* Gets blocked popups to work on views/gtk. I had to fix a couple ofsky@chromium.org2009-10-123-1/+19
| | | | | | | | | | | | | | | | | additional things here: . Avoid doing anything in OnSizeAllocation if the size hasn't changed. Because of how gtk works I was getting stuck in a loop if I OnSizeAllocate did anything if the size hadn't changed. . Applied similar shortcut to TabContentsViewGtk. . Made SimpleMenuModel only ask delegate for checked state if the item is a check. BUG=none TEST=none Review URL: http://codereview.chromium.org/261051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28716 0039d316-1c4b-4281-b951-d872f2087c98
* Move native_widget_types and gtk_native_view_id_manager from base/gfx tobrettw@chromium.org2009-10-1119-25/+24
| | | | | | | | | | | | app/gfx in preparation for removing the base_gfx project. This also moves base/window_impl.cc to app/win/window_impl because this file shouldn't be in base. TEST=none BUG=none Review URL: http://codereview.chromium.org/273017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28691 0039d316-1c4b-4281-b951-d872f2087c98
* Partially revert r28629.craig.schlenter@chromium.org2009-10-101-1/+0
| | | | | | | | | | | | | | | | | | The chrome-os unit test 'TextField' is failing consistently after this commit: ViewTest.Textfield: /b/slave/chromium-rel-linux-chromeos/build/src/views/view_unittest.cc:644: Failure Value of: textfield->text() Actual: Reality is that which, when you stop believing it, doesn't go away.Pretty deep, Philip!Pretty deep, Philip! Expected: kText + kExtraText Which is: Reality is that which, when you stop believing it, doesn't go away.Pretty deep, Philip! TEST=commit and hope tree goes green. No try-bot to test on. Review URL: http://codereview.chromium.org/269047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28666 0039d316-1c4b-4281-b951-d872f2087c98
* Accessibility information from the renderer was not being returned to tools ↵ananta@chromium.org2009-10-105-1/+111
| | | | | | | | | | | | | | | | | | | | | | | | like screen readers, etc. This was because the object implementing the root IAccessible interface did not know how to navigate a native render view. To work around this, we now check if the underlying view is a native view in our root IAccessible::get_accChild function and if yes we send the WM_GETOBJECT message to the corresponding RenderWidgetHostViewWin class, which returns an IAccessible interface which then can expose information from the renderer. The other changes in the accessibility code are for some crashes I observed while testing the screen readers like nvda, the Windows screen reader which send a flurry of WM_GETOBJECT messages leading to some race conditions. We also ensure that the accessibility information for a view is torn down when the view is destroyed. Fixes portions of http://code.google.com/p/chromium/issues/detail?id=13291 Bug=13291 Review URL: http://codereview.chromium.org/261044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28655 0039d316-1c4b-4281-b951-d872f2087c98
* The textfield's text was not updated when text is updated by input.oshima@chromium.org2009-10-092-4/+29
| | | | | | | | | BUG=None TEST=view_examples now has button to show & update textfield's text. Review URL: http://codereview.chromium.org/267040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28629 0039d316-1c4b-4281-b951-d872f2087c98
* Convert gdk keycode to match base::KeyboardCode.oshima@chromium.org2009-10-091-1/+5
| | | | | | Review URL: http://codereview.chromium.org/268026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28568 0039d316-1c4b-4281-b951-d872f2087c98
* When a GtkWidget was destroyed the NVH would not be detached.jcampan@chromium.org2009-10-091-3/+3
| | | | | | | | | | | There was a hack in location_bar_view to prevent an assert, but it would cause an other assert. Also fixed a double delete with the find_bar_host. BUG=None TEST=Start Chrome Linux toolkit view. Close it. It should not assert. Review URL: http://codereview.chromium.org/266034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28556 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes compile error in NativeMenuGtk when building for 64 bit.sky@chromium.org2009-10-091-2/+2
| | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28544 0039d316-1c4b-4281-b951-d872f2087c98
* * Password style support for gtk's textfield impl.oshima@chromium.org2009-10-094-0/+87
| | | | | | | | | | | * Added x11 dependency to view_examples. Looks like dependency has changed a bit. BUG=none TEST=build & run view_examples target. Review URL: http://codereview.chromium.org/270032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28501 0039d316-1c4b-4281-b951-d872f2087c98
* Measure the sync wizard dialog in appropriate units:nick@chromium.org2009-10-082-6/+34
| | | | | | | | | | | | | | | | | | | | | | | | | specifically, units proportional to the fonts used inside of it. We approximate the font chosen by the wizard's CSS. In actuality, the CSS chooses a font-face "arial", "sans-serif". We just use the default sans serif font; arial is the default value for that property. This fixes an issue where changing to the "Windows Classic" theme on Vista would cause the dialog to be resized, clipping its contents, which are unaffected by the UI font size. Update the default GRIT sizes to closely match the old ones. Old vs new: http://www.corp.google.com/~ncarter/wizard-size-screenshots.png BUG=21828 TEST=verified old size against new size in Aero Theme with default settings; verified size stays the same under Classic theme. Review URL: http://codereview.chromium.org/261017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28465 0039d316-1c4b-4281-b951-d872f2087c98
* Implements Screen::GetMonitorAreaNearestPoint for views/gtk.sky@chromium.org2009-10-081-2/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/266019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28443 0039d316-1c4b-4281-b951-d872f2087c98
* Add about:memory link to task manager.thakis@chromium.org2009-10-081-1/+1
| | | | | | | | | | | | | Since about:memory DCHECK()s atm, the link is not completely hooked up. In the xib, I've added a square button with height 14 and the new HyperlinkCell, contained in a GTMWidthBasedResizer or how it's called. I made sure the baseline of link on the left and button on the right is at the same height. BUG=17989,13156 TEST=Open MainMenu.xib, click "Enable" for view->dev->taskman. Build&run chrome. Task manager should contain link. Review URL: http://codereview.chromium.org/255018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28426 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for gdk-CRITICAL message in gdk_window_process_updates of ↵oshima@chromium.org2009-10-081-1/+1
| | | | | | | | | | WidgetGtk::PaintNow method. This happens when View tries to draw a widget that is not yet drawable (not visible and mapped). Review URL: http://codereview.chromium.org/251108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28419 0039d316-1c4b-4281-b951-d872f2087c98
* Backspace should not be processed as an accelerator in textfield, so it ↵jcampan@chromium.org2009-10-081-3/+3
| | | | | | | | | | | really removes the previous character. BUG=11326 TEST=In Linux toolkit views, navigate few pages in a tab (so you have some history). Open the find box (Ctrl-F) type some text, then backspace. Pressing backspace should have the normal behavior and should not trigger a navigation back. Review URL: http://codereview.chromium.org/265038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28410 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling the default button behavior on Linux toolkit_views.jcampan@chromium.org2009-10-0812-161/+105
| | | | | | | | | | | | I had to make the KeyEvent constructor include the event flags. Also cleaned-up some unit-tests BUG=None TEST=Run the unit-tests. Review URL: http://codereview.chromium.org/266012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28397 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor cros library code into central location and have the UI elements ↵chocobo@google.com2009-10-084-1/+19
| | | | | | | | | | | | | | observe changes. - implemented power menu button showing remaining battery info. - implemented clock menu button showing detailed clock info. - also implemented monitoring of network status change. - don't show highlighted state for these menu buttons BUG=23923 TEST=none Review URL: http://codereview.chromium.org/251099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28366 0039d316-1c4b-4281-b951-d872f2087c98
* Move classes depending on Skia out of base/gfx and into app/gfx. Renamebrettw@chromium.org2009-10-0715-19/+21
| | | | | | | | | | native_theme to native_theme_win since its Windows-specific. BUG=none TEST=none Review URL: http://codereview.chromium.org/259047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28300 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up views/gtk to use the gtk bookmark editor.sky@chromium.org2009-10-072-0/+9
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/271001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28292 0039d316-1c4b-4281-b951-d872f2087c98
* Turns on the focus traversal unit-tests and fixed some focus traversal problem:jcampan@chromium.org2009-10-075-87/+92
| | | | | | | | | | | | | | | | - in TabbedPaneView, the focus traversable were not properly hooked-up - the NativeTextField was focusing the wrapper view instead of the actual Textfield view. Also in the FocusTraversal unit-test I had to select one of the radio-button that the test uses, as the behavior of focusing a disabled button is different on Windows (it forces any non disabled radio-button to become selected) than on Gtk. BUG=None TEST=Run the unit tests. Review URL: http://codereview.chromium.org/242163 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28263 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes compile warning. If you have a better suggestion for this, letsky@chromium.org2009-10-071-3/+3
| | | | | | | | | | | | | me know. Here's the warning I was getting without this: dereferencing type-punned pointer will break strict-aliasing rules BUG=none TEST=none TBR=derat Review URL: http://codereview.chromium.org/261005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28233 0039d316-1c4b-4281-b951-d872f2087c98
* Converts info bubbles on views/gtk from popups to normal windows tosky@chromium.org2009-10-075-50/+71
| | | | | | | | | | | avoid the focus problems. BUG=none TEST=none Review URL: http://codereview.chromium.org/246099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28228 0039d316-1c4b-4281-b951-d872f2087c98
* Gets preferred size of views textfields on gtk to work. Also madesky@chromium.org2009-10-067-19/+66
| | | | | | | | | | | turning off border work. BUG=none TEST=none Review URL: http://codereview.chromium.org/256080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28172 0039d316-1c4b-4281-b951-d872f2087c98
* This CL make the AcceleratorDispatcher eat the WM_KEYUP associated tojcampan@chromium.org2009-10-063-5/+158
| | | | | | | | | | | | WM_KEYDOWN that resulted in an accelerator, as they would cause orphaned KeyUp events to be sent to views. This is Windows only for now, still needs to be ported to Linux. BUG=23383 TEST=Run unit-tests. Ensure accelerators work as expected in Chrome. Review URL: http://codereview.chromium.org/246074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28096 0039d316-1c4b-4281-b951-d872f2087c98
* Add comments setting emacs and vim tab width and expansion variables.sgk@google.com2009-10-061-0/+6
| | | | | | | | BUG=none TEST=successful builds Review URL: http://codereview.chromium.org/256059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28089 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting the NativeViewHostWin focus refactoring.jcampan@chromium.org2009-10-0512-242/+96
| | | | | | | | | | | It seems the added subclassing is causing crashers in the field. BUG=23861 TEST=None TBR=beng Review URL: http://codereview.chromium.org/259052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28061 0039d316-1c4b-4281-b951-d872f2087c98
* More views on gtk paint tweaks. My previous attempt resulted in thesky@chromium.org2009-10-053-9/+26
| | | | | | | | | | | | ability to continually paint. I've tweaked it so that we only schedule a paint if the paint is happening from Gtk and not views. BUG=none TEST=none Review URL: http://codereview.chromium.org/251084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27998 0039d316-1c4b-4281-b951-d872f2087c98
* Update a file for the new clipboard location I missed in the last checkin.brettw@chromium.org2009-10-031-1/+1
| | | | | | | TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27939 0039d316-1c4b-4281-b951-d872f2087c98
* Move the clipboard stuff out of base and into app/clipboard. I renamedbrettw@chromium.org2009-10-032-5/+5
| | | | | | | | | | | clipboard_util to clipboard_util_win since it's Windows-only. This patch makes test_shell depend on app as well. There should be no logic change. TEST=none BUG=none Review URL: http://codereview.chromium.org/260003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27937 0039d316-1c4b-4281-b951-d872f2087c98
* Move the JPEG and PNG codecs from base/gfx to app/gfx/codec. Move the classesbrettw@chromium.org2009-10-031-17/+17
| | | | | | | | | | | | | | | into the gfx namespace. Combine the PNGEncoder and PNGDecoder. There were separate when we had different executables for the browser and renderer, and linked the encoder only in one of them (which saved us some space used by libpng). This hasn't been the case for years, so combining them (again) makes sense. TEST=none BUG=none Review URL: http://codereview.chromium.org/243076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27930 0039d316-1c4b-4281-b951-d872f2087c98
* Add simple popup support to browser actions. This will create a popup HTML ↵erikkay@chromium.org2009-10-021-1/+1
| | | | | | | | | | | window that extends below a browser action button when the browser is clicked. When it loses focus, it is automatically dismissed. BUG=23596 TEST=none Review URL: http://codereview.chromium.org/258011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27889 0039d316-1c4b-4281-b951-d872f2087c98
* When installing/uninstalling the clip on native buttons they would not be ↵jcampan@chromium.org2009-10-021-2/+2
| | | | | | | | | | | | | | painted properly. This is the case for animations, such as the dangerous download item animation. (For some unclear reasons this would happen only in aero and only in a popup browser frames.) Explicitly asking for a repaint when setting the clip fixes it. BUG=23087 TEST=Start a dangerous download from a popup (sorry, I don't have any public URL to repro). The dangerous download should display properly in the download shelf. Review URL: http://codereview.chromium.org/259005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27858 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding focus traversal on Linux toolkit views.jcampan@chromium.org2009-10-0113-9/+134
| | | | | | | | | | | | | | | | | | | | | It was previously breaking the interactive UI tests. That was because I changed the button base class to be focusable by default which led to many button beings added to the tab traversal order. I now explicitly make these buttons non focusable. Also because of the way we clear the native focus on Gtk (by setting focus to NULL on the top level window), views now default to clearing the focus when focused (so that views non backed by a native window don't leave the native focus on the previously native window). On Windows we used to focus the WidgetWin's HWND, and now we focus the top-level HWND. The WidgetWin class had to be changed to forward the key events to the root view that contains the focused view because of that. (otherwise it would send it to the top-level root-view, and if the focused view was in a child root-view it would not recieve the keyboard messages). Note that the mouse wheel does not need that, as the mouse-wheel Windows messages are sent to the HWND under the cursor. See: http://codereview.chromium.org/246030/show TEST=Run the tests BUG=NONE Review URL: http://codereview.chromium.org/255008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27723 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes painting problems with views on Gtk. In particular during asky@chromium.org2009-09-302-12/+21
| | | | | | | | | | | | | | | | | paint we would expand the region Gtk wants to paint to include the region views wants to paint. This is problematic if the views region isn't contained in the gtk region. In such a case any gtk widgets without windows aren't painted correctly. The correct thing to do is schedule the paint through gtk so that the child widgets are painted. Additionally I'm making WidgetGtk::PaintNow actually paint now, which helps avoid this situation. BUG=23430 TEST=see bug Review URL: http://codereview.chromium.org/246047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27648 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for a focus related unit-test on Linux toolkit views.jcampan@chromium.org2009-09-301-12/+13
| | | | | | | | | | | | | | | | The problem was caused by the way we were setting the focus, using grab_focus which does not work whenthe screen is locked. We now explicitly send a signal. Also make sure to give a good parent when building a child GtkWidget, as using the WidgetGtk native window would cause a Gtk error. BUG=23394 TEST=Run the unit-tests. R=oshima Review URL: http://codereview.chromium.org/242071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27629 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary disabling a unit test that fails on Linux toolkit views while I ↵jcampan@chromium.org2009-09-301-0/+6
| | | | | | | | | | | investigate. BUG=23394 TBR=huanr Review URL: http://codereview.chromium.org/251039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27570 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the NativeViewHost refactoring (it was breaking the ChromeOS build). jcampan@chromium.org2009-09-2912-96/+242
| | | | | | | | | | | | | | | Refactoring some of the NativeViewHost and NativeControl focus management so their consumers don't have to explicitly set the focused view. See original review: http://codereview.chromium.org/235011/show BUG=None TEST=Run all tests. Make sure focus is stored/restored properly in Chrome. TBR=ben Review URL: http://codereview.chromium.org/246032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27563 0039d316-1c4b-4281-b951-d872f2087c98
* style fix. the header for .cc has to be the 1st include.oshima@chromium.org2009-09-291-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/242045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27537 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in tool tip manager.sky@chromium.org2009-09-291-1/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/242051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27527 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed the header file not found issue of 222030. (The file has been renamed ↵oshima@chromium.org2009-09-296-5/+421
| | | | | | | | | | | | | after review) See http://codereview.chromium.org/222030 for the original review BUG=none TEST=compiled & tested chrome target on win/linux, view_examples target on linux. Review URL: http://codereview.chromium.org/242036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27513 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27504, it breaks the interactive ui tests on Windows.jcampan@chromium.org2009-09-2910-100/+8
| | | | | | | TBR=oshima Review URL: http://codereview.chromium.org/243034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27512 0039d316-1c4b-4281-b951-d872f2087c98
* See original review atjcampan@chromium.org2009-09-2910-8/+100
| | | | | | | | | | | | | | http://codereview.chromium.org/251001/show This CL hooks the focus traversal for the TabbedPaneView on Linux with toolkit views. It also has few focus related fixed (focus with buttons, clearing focus effectively in the focus manager). BUG=None TEST=Run the view_examples app. Press tab to move the focus. Try the different tabs. Review URL: http://codereview.chromium.org/246030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27504 0039d316-1c4b-4281-b951-d872f2087c98
* Add GetPreferredTrySlaves() to presubmit scripts.thestig@chromium.org2009-09-291-0/+13
| | | | | | | | BUG=23071 TEST=none Review URL: http://codereview.chromium.org/251024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27449 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding keyboard code refactoring:jcampan@chromium.org2009-09-2930-100/+113
| | | | | | | | | | | | | | | | http://codereview.chromium.org/248010/show Changing the KeyboardEvent to use a KeyboardCode instead of a w_char. Led to several places where I had to switch from VK_ to VKEY_. Also cleaned-up the table view OnKeyDown method. Since TableView is a NativeControl it can use the NativeControl::OnKeyDown directly. BUG=None TEST=Make sure short-cuts works as expected, especially in the omnibox. Review URL: http://codereview.chromium.org/251020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27444 0039d316-1c4b-4281-b951-d872f2087c98
* Refactored event handler method bodies from widget_win.h tokbr@google.com2009-09-282-99/+203
| | | | | | | | | | | | widget_win.cc. This significantly reduces build times when modifying the code of these event handlers during debugging. BUG=http://code.google.com/p/chromium/issues/detail?id=23274 TEST=none Review URL: http://codereview.chromium.org/254003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27435 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-07-22 18:01:59 +0000