| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Moved ui/base/gtk/gtk_integers.h to ui/base/glib/glib_integers.h since the header only contains typedefs in <glib/glibtypes.h> and does not depend Gtk+ at all.
- Moved the first half of ui/base/gtk/gtk_signal.h to ui/base/glib/glib_signal.h since it does not depend on Gtk+ as well.
This CL is part of the Gtk+ removal work (crbug.com/101422)
BUG=chromium:101422
TEST=ran try
Review URL: http://codereview.chromium.org/8494001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
add "native_view()" check in NativeTabContentsContainerAura
This is necessary as native_view gets destroyed when parent window gets destroyed before tab_contents detatches the native view.
type child should be added to parent.
BUG=99937
TEST=manual: open http auth dialog and close.
Review URL: http://codereview.chromium.org/8462001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Fixes Win dbg shared builder.
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8477039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement WidgetFocusChangeListener, close on deactivate.
DisableInactiveRendering on the parent's top level widget.
Notify widgets without non-client views of activation changes.
To ensure bubble owners get the first click event that closes the bubble:
Stop explicitly setting the owner as the foreground window on close.
To ensure that removing this code didn't regress crbug.com/75610:
Add WS_POPUP for modal dialogs and re-enable owners on close (allowing OS activation).
Note: Showing bubbles long after CreateBubble might break DisableInactiveRendering.
BUG=97248,98312
TEST=views_examples bubbles close on deactivate, example window never appears deactivated.
Review URL: http://codereview.chromium.org/8384020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on http://codereview.chromium.org/8395046
BUG=None
TEST=Visiting about:rotate?right, about:rotate?left, etc. should cause the appropriate screen rotations.
Review URL: http://codereview.chromium.org/8402002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8476016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also lets touch-events go to the activated widget if the activation
happened because of the touch.
BUG=101727
TEST=manually
Review URL: http://codereview.chromium.org/8481004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Linux CPU profiles indicate that at least 2.7% of CPU usage is spent in glib atomic operations. This used to be necessary in the browser process due to loading plugins which may invoke gtk/glib. Plugin loading has been moved out of process now, so this should no longer be necessary. I also removed dbus_g_thread_init() which *should* be safe too, although it's possible that we have unknown dbus-glib use off the UI thread.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8474012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This enables NVDA to provide more accessibility for the omnibox.
This code was previously implemented in BrowserAccessibilityWin,
so as much of the logic as possible is abstracted into
a new utility function in ui/base/accessibility.
BUG=102485
TEST=Explore omnibox with NVDA
Review URL: http://codereview.chromium.org/8437063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
Review URL: http://codereview.chromium.org/8334041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix invalid transition in custom_button.cc When the mouse is released on a custom button, the state is set to BS_NORMAL if the hit test fails.
The following two transitions should have the same final effect.
BS_PRESSED -> BS_HOT -> BS_NORMAL
BS_PRESSED -> BS_NORMAL
Review URL: http://codereview.chromium.org/8437003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=101505
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8334036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
nested menu brought up a dialog.
BUG=101881
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8447019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
Review URL: http://codereview.chromium.org/8450001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently when showing the avatar bubble the tip of the bubble points to the middle of the anchor control.
This can look weird so I'm changing it to be aligned with the edge of the anchor control.
BUG=98884
TEST=
Review URL: http://codereview.chromium.org/8439064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Factors out Chrome/Chromium resource generation into a separate
chrome_resources.gyp file.
2. Eliminates repetition between Mac and other platforms.
3. Breaks long "repack" actions out into separate files for greater readability.
4. Eliminates circular dependencies in the Aura shell, the Views components, and
the compositor when utilizing Chrome resources.
BUG=none
TEST=try bots run gyps and build correctly.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107967
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108466
Review URL: http://codereview.chromium.org/8425002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We currently don't support child popup windows on other platforms.
BUG=102585
TEST=views_unittests --gtest_filter=WidgetTest.Visibility
Review URL: http://codereview.chromium.org/8438040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Separate out code that depends on chrome/browser code to stay in the existing directory.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8417021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resource generation
1. Factors out Chrome/Chromium resource generation into a separate
chrome_resources.gyp file.
2. Eliminates repetition between Mac and other platforms.
3. Breaks long "repack" actions out into separate files for greater readability.
4. Eliminates circular dependencies in the Aura shell, the Views components, and
the compositor when utilizing Chrome resources.
BUG=none
TEST=try bots run gyps and build correctly.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107967
Review URL: http://codereview.chromium.org/8425002
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/8448001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Factors out Chrome/Chromium resource generation into a separate
chrome_resources.gyp file.
2. Eliminates repetition between Mac and other platforms.
3. Breaks long "repack" actions out into separate files for greater readability.
4. Eliminates circular dependencies in the Aura shell, the Views components, and
the compositor when utilizing Chrome resources.
BUG=none
TEST=try bots run gyps and build correctly.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107967
Review URL: http://codereview.chromium.org/8425002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NonClientView when inactive rendering disabled changes, but
implementations are relying on this to be sent when active state may
have changed too. This isn't the right fix, but gives us the old
behavior. We really need to persist active state in widget, then
notify the NonClientView when it changes, or the inactive rendering
disabled state changes.
BUG=102695
TEST=easiest to verify on windows in classic mode (non-aero). Create
two chrome windows, click between them and make sure the window losing
activation state looks inactive.
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8386064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The CL being reverted:
This patch lets the browser window punch a hole in the DesktopBackgroundView,
thus eliminating overdraw.
To do this, the hole punching logic was changed to look at the entire tree.
Drawing the screen is a preorder traversal through all the layers. Thus, to
compute the hole, we have to look at all of the layers after a particular layer
in the preorder traversal.
This is not an efficient algorithm, but it is simplest I could come up with.
Plus we will be moving to the WebKit compositor soon.
Hopefully this will improve the frame rate for the Aura demos
Note: I will put the changes to Transform into another patch.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107360
Review URL: http://codereview.chromium.org/8368013
TBR=pkotwicz@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/8372048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on http://codereview.chromium.org/8362006/
BUG=101595
TEST=None
Review URL: http://codereview.chromium.org/8395046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reduce dependencies amongst DCLM, ShowStateC, WorkspaceC and such.
I changed my mind and kept "WorkspaceController owns WorkspaceManager" as this seems to be better in long run. I decoupled DCLM from ShowStateC and WorkspaceC. I moved a layout_in_progress flag to WorkspaceManager as it really belongs there, and can reduce dependency.
BUG=84070
TEST=new test conditions for workspace observer are added to workspace_manager_unittests
Review URL: http://codereview.chromium.org/8430024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes views::TextButton so that the focus rect is drawn
with an appropriate inset.
TEST=Trigger an infobar (Translate, Save Password, etc.), type Ctrl+L to focus location bar, press Tab to focus controls in info bar.
Review URL: http://codereview.chromium.org/8439015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this CL, window is now correctly maximized/fullscreen'ed on aura desktop.
* Added OnPropertyChanged to WindowObserver
* Added Get/Set IntProperty to simplify handling int value properties.
* Remove IsOrContainsFullscreen. Added Workspace::ContainsFullscreen instead. We need this to autohide launcher.
BUG=97257,97259
TEST=new test for property change notification. existing tests are updated, except maximized/fullscreen drag test. I'll add it to new set of tests that verifies window dragging within workspace.
Review URL: http://codereview.chromium.org/8400063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8440018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
is needed for bubbles.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8351042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8440008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Should allow us to fully convert all bubbles (bookmark, etc.)
Use separate border and contents widgets (like old bubble).
Supports transparency/opacity with fading, etc.
Remove BubbleView remnants; update tests.
BUG=98312
TEST=No views_examples bubble problems.
Review URL: http://codereview.chromium.org/8368006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=97411
TEST=interactive_ui_tests --gtest_filter=ConstrainedWindowViewTest.FocusTest
Review URL: http://codereview.chromium.org/8052019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
control.
R=sky@chromium.org
Review URL: http://codereview.chromium.org/8351036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
Review URL: http://codereview.chromium.org/8429014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
better matches expectations.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8432001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also makes aura::DesktopHostLinux avoid generating Char
events when not appropriate, which avoids a problem that I
observed where arrow keys were moving <select> selections two
spaces instead of one.
There still appears to be an issue with the Enter key getting
double-counted in <select> popups, though (but if we avoid
sending a Char event for it, things like <textarea> break),
and fullscreen Flash windows aren't getting updated.
BUG=99757,101899,101848
TEST=manual
Review URL: http://codereview.chromium.org/8417008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
parents. This is needed otherwise the worskpace code tries to place
and position bubbles and other transient type windows.
BUG=none
TEST=none
R=ben@chromium.org,oshima@chromium.org
Review URL: http://codereview.chromium.org/8414035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resource generation
1. Factors out Chrome/Chromium resource generation into a separate
chrome_resources.gyp file.
2. Eliminates repetition between Mac and other platforms.
3. Breaks long "repack" actions out into separate files for greater readability.
4. Eliminates circular dependencies in the Aura shell, the Views components, and
the compositor when utilizing Chrome resources.
BUG=none
TEST=try bots run gyps and build correctly.
Review URL: http://codereview.chromium.org/8425002
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/8430011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Factors out Chrome/Chromium resource generation into a separate
chrome_resources.gyp file.
2. Eliminates repetition between Mac and other platforms.
3. Breaks long "repack" actions out into separate files for greater readability.
4. Eliminates circular dependencies in the Aura shell, the Views components, and
the compositor when utilizing Chrome resources.
BUG=none
TEST=try bots run gyps and build correctly.
Review URL: http://codereview.chromium.org/8425002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=45605
TEST=Tested it with Google Japanese Input method on Win7
Review URL: http://codereview.chromium.org/8294026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This refactors and improves a bunch of views accessibility
code on Windows and has the result of enabling NVDA to
announce the text selection in the omnibox.
The AutocompleteAccessibility class is removed; its
functionality is rolled into NativeViewAccessibilityWin.
NativeViewAccessibilityWin adds IAccessible2 and
IAccessibleText interfaces, allowing it to directly expose
the caret and selection to compatible assistive technology.
In addition, this gives each accessible object an unique id.
Finally, the reference from a View to its
NativeViewAccessibilityWin is changed from a scoped_refptr
to a ScopedComPtr, because another process may still have a
reference to the accessible COM object when the View is
deleted.
BUG=53380
TEST=Manually test the omnibox with NVDA on Windows. It should announce text that's selected, including autocompletions.
Review URL: http://codereview.chromium.org/8391010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=100898
R=pkasting@chromium.org
Review URL: http://codereview.chromium.org/8405002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=98322
TEST=None
Review URL: http://codereview.chromium.org/8319008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, each widget's tooltip-manager listens to every single X event in the system, all the time. This can get expensive as the number of windows increase. Instead of doing this, the change here makes a TooltipManagerViews only listen to the mouse-events on the corresponding Widget. It starts its timer when the mouse enters the widget, and stops the timer when the mouse leaves the widget. So at a single time, only one TooltipManagerViews will be activated, and looking to update the its tooltip.
BUG=97249
TEST=none
Review URL: http://codereview.chromium.org/8417025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also revert the previous attempt to fix this issue:
Revert "Aura build fix: Make TooltipManagerViews an observer of parent Widget and"
This reverts commit 6749813691870c8311c81c030bee9e1d4ad305ff.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8418028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=100232
TEST=Manual
Review URL: http://codereview.chromium.org/8341050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on http://codereview.chromium.org/8247009/
BUG=None
TEST=None
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107715
Review URL: http://codereview.chromium.org/8362006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also wires up GetRestoredBounds().
BUG=99729
TEST=manual: less spam
Review URL: http://codereview.chromium.org/8417014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on http://codereview.chromium.org/8247009/
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8362006
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/8400059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
Review URL: http://codereview.chromium.org/8413004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107716 0039d316-1c4b-4281-b951-d872f2087c98
|