summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Reverting 23406" as it didn't break any tests.jhawkins@chromium.org2009-08-141-33/+33
| | | | | | | | | | | | | | Change PluginInstallImpl to use base::WindowImpl instead of CWindowImpl to reduce a dependency on ATL. BUG=5023 TEST=Uninstall flash. Visit hulu.com and install the flash plugin. Original review: http://codereview.chromium.org/165469 TBR=levin Review URL: http://codereview.chromium.org/165543 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23454 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23406.levin@chromium.org2009-08-141-33/+33
| | | | | | | | | | | | It seems that Tab2OutOfTabStrip is failing consistently after this change. BUG=None TEST=None TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/164543 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23411 0039d316-1c4b-4281-b951-d872f2087c98
* Change PluginInstallImpl to use base::WindowImpl instead of CWindowImpl to ↵jhawkins@chromium.org2009-08-141-33/+33
| | | | | | | | | | reduce a dependency on ATL. BUG=5023 TEST=Uninstall flash. Visit hulu.com and install the flash plugin. Review URL: http://codereview.chromium.org/165469 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23406 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors OSExchangeData for easier portability.sky@chromium.org2009-08-124-14/+20
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/164401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23230 0039d316-1c4b-4281-b951-d872f2087c98
* Implements WidgetGtk::SetOpacity.sky@chromium.org2009-08-122-3/+13
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/164346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23169 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/159838 for Pierre-Antoine. From him:sky@chromium.org2009-08-114-11/+41
| | | | | | | | | | | | | | | | | | | Right clicking the back and forward buttons is buggy. A single right click opens the drop down menu, however the button does not enter the PUSHED state. If you double right click then click on the tab content area, the button stays in a PUSHED state until you mouseover it. The fix should replicate the intuitive behavior. On a single right click, the button enters the PUSHED state and the drop down appears immediately. As soon as the user clicks on another View, the drop down closes and the button returns to the NORMAL state. Double right click behaves similarly. BUG=9717 TEST=none Review URL: http://codereview.chromium.org/165318 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23101 0039d316-1c4b-4281-b951-d872f2087c98
* Removes bogus comments in WidgetGtk::GetBounds.sky@chromium.org2009-08-111-9/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/165306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23062 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/165271 for tedoc. From tedoc:sky@chromium.org2009-08-111-1/+1
| | | | | | | | | | | Fix set_x to set_y for vertical scrolling BUG=NONE TEST=none Review URL: http://codereview.chromium.org/164321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23028 0039d316-1c4b-4281-b951-d872f2087c98
* Removes calls to RootView methods that were removed.sky@chromium.org2009-08-111-3/+0
| | | | | | | | | BUG=none TEST=none TBR=jcampan Review URL: http://codereview.chromium.org/164320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23022 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors RootViewDropTarget into a platform independent part,sky@chromium.org2009-08-1115-241/+386
| | | | | | | | | | | | | | DropHelper, and the platform specific part DropTarget. I've also moved ownership/creation of the DropTarget to Widget. This makes it alot easier for the windows side, in which DropTarget must implement IDataObject. BUG=none TEST=none Review URL: http://codereview.chromium.org/165155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23020 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in previous change. In AcceleratorHandler if there is nosky@chromium.org2009-08-111-0/+1
| | | | | | | | | | | WidgetGtk we should dispatch the event, not eat it. BUG=none TEST=none Review URL: http://codereview.chromium.org/165183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23009 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in AcceleratorHandler. It's possible to get events for GtkWidgetssky@chromium.org2009-08-071-0/+5
| | | | | | | | | | | | outside of those created by Chrome that we need to ignore. I saw this with drag and drop. BUG=none TEST=none Review URL: http://codereview.chromium.org/165150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22801 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out window creation into base::WindowImpl. This class will be used ↵jhawkins@chromium.org2009-08-072-238/+47
| | | | | | | | | | in place of CWindowImpl to reduce our dependency on ATL. BUG=none TEST=none Review URL: http://codereview.chromium.org/165022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22787 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that popups windows are not themed.mirandac@chromium.org2009-08-072-1/+16
| | | | | | | | | BUG= http://crbug.com/18093 TEST= While running Chrome with a theme installed, and force a popup. Note that the popup window is not themed. Review URL: http://codereview.chromium.org/159871 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22783 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a BAD_OVERRIDE defect reported by Coverity. Change thewtc@chromium.org2009-08-061-1/+1
| | | | | | | | | | | | | prototype of the GetDefaultThemeProvider method in the base class to match the prototypes of the GetDefaultThemeProvider methods in the subclasses BrowserFrameWin and BrowserFrameGtk. R=glen BUG=17104 TEST=none Review URL: http://codereview.chromium.org/159479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22568 0039d316-1c4b-4281-b951-d872f2087c98
* Make the DOMUIThemeSource load and pass through a PNG, rather than relying ↵glen@chromium.org2009-08-051-0/+3
| | | | | | | | | | | on decode/encode. BUG=18427 TEST=Install a giant theme, load the NNTP, verify that you can type in the omnibox without delay while the page is loading. Review URL: http://codereview.chromium.org/159891 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22457 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing a compilation error in toolkit_views.jcampan@chromium.org2009-08-041-3/+5
| | | | | | | | | BUG=None TEST=None TBR=sky Review URL: http://codereview.chromium.org/160615 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22441 0039d316-1c4b-4281-b951-d872f2087c98
* Committing pierre.lafayette patch, see:jcampan@chromium.org2009-08-042-0/+32
| | | | | | | | | | | | | http://codereview.chromium.org/159804 Adding support for Ctrl+Tab and Ctrl+Shift+Tab navigation of TabbedPane tabs. This will make the tabbed dialogs consistent with the TabStrip functionality. BUG=6761 TEST=none Review URL: http://codereview.chromium.org/160607 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22440 0039d316-1c4b-4281-b951-d872f2087c98
* Making the focus manager unit-tests less Windows specific.jcampan@chromium.org2009-08-041-76/+56
| | | | | | | | | | This is part of the FocusManager port on toolkit_views. BUG=None TEST=All FocusManager unit-tests should pass. Review URL: http://codereview.chromium.org/160601 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22417 0039d316-1c4b-4281-b951-d872f2087c98
* Adding registration of accelerators for the browser in toolkit_views.jcampan@chromium.org2009-08-032-3/+3
| | | | | | | | | | | BUG=None TEST=Open Chrome built with toolkit_views, test that accelerators work. See review: http://codereview.chromium.org/160502 Review URL: http://codereview.chromium.org/159790 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22277 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak of GtkWidgets in NativeViewHost, and in doing so fix a crash on ↵ben@chromium.org2009-08-012-19/+18
| | | | | | | | | | | | | shutdown due to a check in OwnedWidgetGtk for unbalanced refcnt. The NativeViewHostGtk now owns the GtkWidget attached to it for the lifetime of its attachment. This removes my crazy ownership games from before and makes it a lot simpler. BUG=none TEST=none Review URL: http://codereview.chromium.org/159751 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22230 0039d316-1c4b-4281-b951-d872f2087c98
* Status bubble limping in TOOLKIT_VIEWS.ben@chromium.org2009-08-0111-122/+164
| | | | | | | | | | | Add CreateTransparentFloatingWidget method to Widget and add Init/SetContentsView methods. BUG=none TEST=none Review URL: http://codereview.chromium.org/160474 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22229 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds accelerators to the Linux toolkit views.jcampan@chromium.org2009-07-3115-217/+289
| | | | | | | | | | | The MessageLoop had to be modified to support Dispatchers on Linux. BUG=None TEST=On Windows and Linux, make sure the accelerators still work as expected. On Linux toolkit views, build and run the unit-tests. Review URL: http://codereview.chromium.org/159046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22210 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in bookmark menus. Specifically if you had a menusky@chromium.org2009-07-312-3/+10
| | | | | | | | | | | | | | | showing and brought up the context menu and clicked a separator we would do the wrong thing. We would try to show the first menu again, without cancelling out of the inner loop, which would most likely result in a crash. The right thing to do in this case is not close the context menu (this behavior can be seen in windows as well). BUG=17862 TEST=see bug, but also covered by ui test now. Review URL: http://codereview.chromium.org/160458 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22180 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes the Linux build break.klink@chromium.org2009-07-281-4/+0
| | | | | | | | TBR=jcampan Review URL: http://codereview.chromium.org/159543 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21897 0039d316-1c4b-4281-b951-d872f2087c98
* Adds additional MSAA information to fill in a few gaps in the hierarchy.klink@chromium.org2009-07-284-0/+30
| | | | | | | | | TEST=None BUG=None Review URL: http://codereview.chromium.org/160239 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21896 0039d316-1c4b-4281-b951-d872f2087c98
* Remove *.vsprops files that are no longer referenced (or only havesgk@google.com2009-07-281-12/+0
| | | | | | | | | references to each other) anywhere in the Chromium code base. BUG=none TEST=rebuild Review URL: http://codereview.chromium.org/159523 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21873 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Window modality in TOOLKIT_VIEWS, and allow windows to be centered ↵ben@chromium.org2009-07-252-16/+47
| | | | | | | | | | over their modal parent or the screen if there is no modal parent. This means child windows don't open at 0,0 anymore. BUG=none TEST=none Review URL: http://codereview.chromium.org/159335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21599 0039d316-1c4b-4281-b951-d872f2087c98
* Theme reset fixes.glen@chromium.org2009-07-241-4/+5
| | | | | | | | | BUG=16669 TEST=Make sure that resetting your theme to the default on Aero Glass causes you to see a black frame. Review URL: http://codereview.chromium.org/159332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21590 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for an error reported by Coverity.jcampan@chromium.org2009-07-242-8/+10
| | | | | | | | BUG=http://crbug.com/17409 TEST=None Review URL: http://codereview.chromium.org/160063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21544 0039d316-1c4b-4281-b951-d872f2087c98
* Make the bookmark buttons follow theme changes correctly.glen@chromium.org2009-07-241-9/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/160092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21518 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Omnibox cursor flicker by deleting a bunch of useless code in WindowWin.pkasting@chromium.org2009-07-243-47/+0
| | | | | | | | | | I tested running the app in Vista non-Aero, and I still got resize cursors on all edges and was able to resize the window. BUG=13926 TEST=Mouse around on the omnibox; the cursor should not flicker. Review URL: http://codereview.chromium.org/159245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21485 0039d316-1c4b-4281-b951-d872f2087c98
* Make the Clear Browsing Data dialog box look a little nicer.ben@chromium.org2009-07-248-25/+62
| | | | | | | | | | | | - Now use GtkCheckButton's own label instead of the hack one used only by windows. - Render a background for DialogClientView. BUG=none TEST=none Review URL: http://codereview.chromium.org/160066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21484 0039d316-1c4b-4281-b951-d872f2087c98
* Adds MSAA information to various (previously uncovered) bits of the UI, ↵klink@chromium.org2009-07-233-10/+22
| | | | | | | | | | | including Bookmark and Extensions infobars. This is to moving towards completing the hierarchy for the benefit of full screen reader support. BUG=None. Test=None. Review URL: http://codereview.chromium.org/155446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21476 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug introduced by my clipping changes - when you switched tabs the tab ↵ben@chromium.org2009-07-231-0/+1
| | | | | | | | | | | area would blank out - we weren't showing the NativeView in calls to ShowWidget, only the fixed. BUG=none TEST=none Review URL: http://codereview.chromium.org/160049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21452 0039d316-1c4b-4281-b951-d872f2087c98
* Fix NativeViewHostGtk clipping.ben@chromium.org2009-07-238-75/+156
| | | | | | | | | | | | | Basically, I introduce an additional GtkFixed into the GtkWidget hierarchy. When clipping is required, this is re-created with a X Window and clipping is performed. For some reason, Gtk+Cairo won't clip rendering to the parent GtkWidget if there isn't an associated X Window. This also fixes the GetPreferredSize implementation for NativeButtonGtk which would return ever increasing values of size each time it was called. BUG=none TEST=none Review URL: http://codereview.chromium.org/159153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21423 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two crashers with TOOLKIT_VIEWS build:ben@chromium.org2009-07-211-2/+7
| | | | | | | | | | | - NativeViewHostGtk::RemovedFromWidget crashes due to WidgetGtk::window_contents_ being NULL... basically when RemovedFromWidget is called from the RootView's dtor, the window_contents_ and widget_ properties of the containing WidgetGtk are NULL. It seems acceptable to not clean up in this case. - TabContentsViewGtk dtor needs to call CloseNow(). This is similar to ~TabContents() calling DestroyWindow on the view's HWND. Without this, the TabContentsViewGtk object was destroyed but the corresponding GtkWidget wasn't, and so subsequent signal handlers would crash. BUG=none TEST=none Review URL: http://codereview.chromium.org/159130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21202 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring of tabbed-pane component so it can be ported to Linux toolkit_view.jcampan@chromium.org2009-07-217-121/+386
| | | | | | | | BUG=None TEST=Make sure the Options dialog still works as expected (tab selection, focus traversal...) Review URL: http://codereview.chromium.org/155668 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21189 0039d316-1c4b-4281-b951-d872f2087c98
* Resurrect toolkit_views build.ben@chromium.org2009-07-211-0/+2
| | | | | | Review URL: http://codereview.chromium.org/155797 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21132 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash on older versions of windows that don't have DWM APIs.ben@chromium.org2009-07-201-8/+12
| | | | | | | | | http://crbug.com/17290 TEST=none Review URL: http://codereview.chromium.org/155798 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21112 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage.erg@chromium.org2009-07-192-0/+5
| | | | | | | | TBR=mirandac Review URL: http://codereview.chromium.org/155760 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21067 0039d316-1c4b-4281-b951-d872f2087c98
* Fix frame turning black when reseting theme. Also simplifies the frameben@chromium.org2009-07-181-32/+27
| | | | | | | | | | | | | | type changed code somewhat. It turns out the frame still needs to be hidden for WM_DWMCOMPOSITIONCHANGED message handlers however. Not sure why, but this is the simplest/least buggy this code has been so far so I can live with it. http://crbug.com/14578 TEST=see bug Review URL: http://codereview.chromium.org/159050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21045 0039d316-1c4b-4281-b951-d872f2087c98
* Converts a couple of by value return types to const ref returnssky@chromium.org2009-07-171-4/+3
| | | | | | | | | | | types. Also expands on the documentation of GetViewForPoint. BUG=none TEST=none Review URL: http://codereview.chromium.org/149723 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20969 0039d316-1c4b-4281-b951-d872f2087c98
* SingleSplitView: survive minimize / restore when resize changes leading bounds.pfeldman@chromium.org2009-07-161-8/+18
| | | | | | | | BUG=16855 Review URL: http://codereview.chromium.org/155629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20872 0039d316-1c4b-4281-b951-d872f2087c98
* This makes the unit-tests pass with toolkit_views on Linux.jcampan@chromium.org2009-07-152-34/+52
| | | | | | | | | | It also make them run the view tests. BUG=None TEST=Run the unit-tests on Linux with toolkit_views=1 Review URL: http://codereview.chromium.org/149649 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20794 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt fixing a crash. Looks like NativeMenuWin was getting leaked by ↵ben@chromium.org2009-07-151-2/+3
| | | | | | | | | | | Menu2... meaning a NativeMenuWin could outlive its model potentially! http://crbug.com/14594 TEST=none Review URL: http://codereview.chromium.org/149635 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20692 0039d316-1c4b-4281-b951-d872f2087c98
* Make native_menu_win be 'owner_drawn' when the UI font/size is overriden for ↵jshin@chromium.org2009-07-141-2/+2
| | | | | | | | | | | | | Indian languages. This is a regression with a new menu implementation. BUG=7319 (http://crbug.com/7319 ) TEST=Run Chrome with --lang=ml or --lang=bn and see if labels in PageMenu or AppMenu are readable. Review URL: http://codereview.chromium.org/155403 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20675 0039d316-1c4b-4281-b951-d872f2087c98
* Allow TabContentsDelegates to process unhandled keyboard messages coming ↵ananta@chromium.org2009-07-143-75/+0
| | | | | | | | | | | | | | | | | | | back from the renderer. This is required for ExternalTabContainer to be able to pass unhandled keyboard accelerator messages back to the external host. This worked before as the focus manager would hand off these messages to keystroke listeners like the ExternalTabContainer. However with the ExternalTabContainer no longer using the focus manager this does not work anymore. Removed the keystroke listener code from the focus manager as the ExternalTabContainer was the only consumer and it does not use it anymore. This fixes bug http://b/issue?id=1975749 Bug=1975749 Review URL: http://codereview.chromium.org/149520 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20600 0039d316-1c4b-4281-b951-d872f2087c98
* Add 'resize_leading_on_bounds_change' property into the SingleSplitView.pfeldman@chromium.org2009-07-092-1/+28
| | | | | | | | When it is turned on, leading component is resized when split view gets new bounds. Review URL: http://codereview.chromium.org/155214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20258 0039d316-1c4b-4281-b951-d872f2087c98
* Fix: Position always off-screen when starting upyuzo@chromium.org2009-07-091-1/+2
| | | | | | | | | | | | | | Fixed the offset-by-taskbar logic. Tested with dual monitors, trying left-right and up-down monitor layouts. TEST=Use dual monitors (first:left, second:right) and open, close, and reopen Chromium in the second (right) window. Without this change, the window appears far to the right from the last location. BUG=15199 Review URL: http://codereview.chromium.org/155201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20246 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-09-16 11:29:11 +0000