summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* fix know issues in RenderTextxji@google.com2011-09-203-12/+687
| | | | | | | | | | | | | | | 1. add tests. 2. change SelectWord() to use BreakIterator, so it works for Chinese and Complex script. 3. DELETE/ReplaceChar delete/replace a whole grapheme. ReplaceTextInternal should only replace one grapheme when there is no selection. 4. pointing to position outside of text returns HOME/END position. 5. based on Chrome Linux omnibox and gedit, given "abc| def", double click should select " " instead of "abc". Change test expectation. BUG=90426 TEST=compile with touchui=1 test omnibox. run views_unittests.NativeTextfieldViewsTest/TextfieldViewsModelTest Review URL: http://codereview.chromium.org/7841056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102006 0039d316-1c4b-4281-b951-d872f2087c98
* views: Add unittests for the TabbedPane operations.tfarina@chromium.org2011-09-201-1/+43
| | | | | | | | | R=sky@chromium.org TEST=views_unittests --gtest_filter=TabbedPaneTest.* Review URL: http://codereview.chromium.org/7934010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101984 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: Fix a crash when system notifications show up.sadrul@chromium.org2011-09-201-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7982008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101981 0039d316-1c4b-4281-b951-d872f2087c98
* A bunch of changes related to window z-index:ben@chromium.org2011-09-201-1/+1
| | | | | | | | | | | | | | | - Keeps toplevel windows constrained in z-index between the desktop background (bottom-most) and the launcher (topmost). - Renames WindowManager to EventFilter, and moves it to the parent Window... i.e. when a window receives a mouse event its parent's event filter will get the opportunity to process it before that window's delegate does. - WindowManager's content was mostly specific to toplevel window movement, so this content moved to an EventFilter subclass called ToplevelEventFilter. - Adds a name property to aura::Windows useful for debugging. - Prevent Windows with no delegate from taking part in event processing. - Initialize the Aura_Shell in DesktopWindow, provide a single exported method - aura_shell::InitDesktopWindow() - to initialize it from the exe main. BUG=none TEST=none Review URL: http://codereview.chromium.org/7970001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101974 0039d316-1c4b-4281-b951-d872f2087c98
* views: Do not convert GetItemAt() to wstring as it already returns string16.tfarina@chromium.org2011-09-201-3/+2
| | | | | | | | R=sky@chromium.org Review URL: http://codereview.chromium.org/7937001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101962 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding 100792oshima@google.com2011-09-2013-75/+133
| | | | | | | | | | | | | | | | | | Use TabContentsViewViews for RenderWidgetHostViweViews. * Removed TabContentsViewTouch. * Changed so that mouse and resize event goes through NativeWidgetViews so that NativeTabContentsViewViews can invoke NativeTabContentsViewDelegates. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100792 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100834 Review URL: http://codereview.chromium.org/7460001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101921 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in menu painting on windows. The regression happenedsky@chromium.org2011-09-204-4/+19
| | | | | | | | | | | | | | | from a change that resulted in shrinking the client area one pixel when it shouldn't have. I've changed the code to respect whether we should shrink the client area by one pixel. BUG=96505 TEST=make sure menus on windows aren't truncated anymore. Truncation is most noticable over remote desktop. R=ben@chromium.org Review URL: http://codereview.chromium.org/7974001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101914 0039d316-1c4b-4281-b951-d872f2087c98
* views: Remove unnecessary includes to views/window/window_resources.htfarina@chromium.org2011-09-202-2/+2
| | | | | | | | | | This include is only used/necessary in constrained_window_views.cc. R=sky@chromium.org Review URL: http://codereview.chromium.org/7936004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101913 0039d316-1c4b-4281-b951-d872f2087c98
* Make specifying a texture optional on a Layer.ben@chromium.org2011-09-192-6/+5
| | | | | | | | | | | | This is for Layers that participate in Draw() ordering, transforming and clipping, but do not themselves actually render anything. Also changes LayerTest to use RunAllPending() rather than using the weird QuitOnComposited test type I had. BUG=none TEST=see unittest Review URL: http://codereview.chromium.org/7941016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101829 0039d316-1c4b-4281-b951-d872f2087c98
* views/examples: Fix a typo, do not add widget_example twice.tfarina@chromium.org2011-09-191-1/+1
| | | | | | | | R=sky@chromium.org Review URL: http://codereview.chromium.org/7949003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101820 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build on Linux where warning for unused vars are treated as errors.saintlou@chromium.org2011-09-191-0/+1
| | | | | | | | | | TBR=ben@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/7941013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101796 0039d316-1c4b-4281-b951-d872f2087c98
* views/examples: Make it possible to maximize the examples window.tfarina@chromium.org2011-09-192-0/+10
| | | | | | | | | | Also show "Views Examples" in the window title. R=sadrul@chromium.org Review URL: http://codereview.chromium.org/7935005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101784 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Aura Windows bustage.ben@chromium.org2011-09-192-5/+9
| | | | | | | | | BUG=none TEST=none TBR=saintlou Review URL: http://codereview.chromium.org/7950002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101772 0039d316-1c4b-4281-b951-d872f2087c98
* re-checkin http://codereview.chromium.org/7720001/ to add bubble views.saintlou@chromium.org2011-09-1921-7/+923
| | | | | | | | | | | | The patch caused memory leak in views_unittests. added patch http://codereview.chromium.org/7858015/ to fix unittests memory leak. BUG=none TEST=none Review URL: http://codereview.chromium.org/7831071 Patch from Alice Tull <alicet@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101739 0039d316-1c4b-4281-b951-d872f2087c98
* views/examples: Rename ExamplesMain::CreateWindow() to Init().tfarina@chromium.org2011-09-192-3/+3
| | | | | | | | | | | | This should fix the windows build. CreateWindow conflicts with a win32 function. R=sky@chromium.org Review URL: http://codereview.chromium.org/7932023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101738 0039d316-1c4b-4281-b951-d872f2087c98
* views/examples: Initialize all the critical stuff in the main() function.tfarina@chromium.org2011-09-192-58/+54
| | | | | | | | R=sky@chromium.org Review URL: http://codereview.chromium.org/7931003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101736 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base/scoped_ptr.hakalin@chromium.org2011-09-182-2/+2
| | | | | | | | | | | Fix remaining users to use base/memory/scoped_ptr.h. BUG= TEST= Review URL: http://codereview.chromium.org/7930009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101715 0039d316-1c4b-4281-b951-d872f2087c98
* Aura under Linux is enabled with:saintlou@chromium.org2011-09-187-3/+21
| | | | | | | | | | | 'use_aura': 1, BUG=none TEST=none Review URL: http://codereview.chromium.org/7850026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101704 0039d316-1c4b-4281-b951-d872f2087c98
* views: Remove unnecessary include of combobox.h from native_control_win.htfarina@chromium.org2011-09-182-16/+19
| | | | | | | | | | | While I'm here also remove scoped_ptr.h include (which is also unused) and annotate with OVERRIDE the overridden methods. R=sky@chromium.org Review URL: http://codereview.chromium.org/7901026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101703 0039d316-1c4b-4281-b951-d872f2087c98
* More shell hookup:ben@chromium.org2011-09-172-4/+19
| | | | | | | | | | | - NULL window_ in NativeWidgetAura::OnWindowDestroyed before notifying its delegate, and add a NULL check in NativeWidgetAura::SchedulePaint to prevent calls triggered by the Widget's RootView's destruction from calling into it. There may be a better fix here but it probably involves destroying the RootView sooner which is scary. - Adds a mock status area. BUG=none TEST=none Review URL: http://codereview.chromium.org/7920016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101662 0039d316-1c4b-4281-b951-d872f2087c98
* Revise ScopedRedrawLock and the caption button workaround.msw@chromium.org2011-09-172-46/+84
| | | | | | | | | | | | | | | | | | | Additionally guard against operations on destroyed widgets. This CL incorporates and builds on changes from r101033. That original CL was reverted to ease merging this into M15. Add two guards against unlocking after Widget destruction. ScopedRedrawLock will check HWND validity with IsWindow(). DefWindowProcWithRedrawLock will check for destructor calls. Unify ScopedRedrawLock + DefWindowProc codepaths. BUG=84563,89820,95582,95727,93530 TEST=none Review URL: http://codereview.chromium.org/7926019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101642 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r101033 in preparation for a better patch.msw@chromium.org2011-09-172-50/+23
| | | | | | | | | | | | | | | | | | The original CL exposed problems with ScopedRedrawLock. The Widget/Window can be destroyed during DefWindowProc. Unlocking after destruction can result in crashes. My new CL guards against operations on destroyed widgets. I'm reverting the original CL to ease the M15 merge process. See http://codereview.chromium.org/7926019/ BUG=84563,89820,95582,95727,93530 TEST=none TBR=sky@chromium.org Review URL: http://codereview.chromium.org/7926020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101609 0039d316-1c4b-4281-b951-d872f2087c98
* views/examples: Change the return type of BoolToOnOff() function to char.tfarina@chromium.org2011-09-173-7/+8
| | | | | | | | R=sky@chromium.org Review URL: http://codereview.chromium.org/7918007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101605 0039d316-1c4b-4281-b951-d872f2087c98
* views: Remove unused Widget::WindowInitParams() function.tfarina@chromium.org2011-09-162-6/+0
| | | | | | | | R=ben@chromium.org Review URL: http://codereview.chromium.org/7925017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101553 0039d316-1c4b-4281-b951-d872f2087c98
* views: Change WidgetDelegate::GetWindowName() to use std::string.tfarina@chromium.org2011-09-167-15/+15
| | | | | | | | | | This save us some conversions to and from wide string. R=sky@chromium.org Review URL: http://codereview.chromium.org/7910012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101540 0039d316-1c4b-4281-b951-d872f2087c98
* Fix views_aura_desktop build on Linux.tfarina@chromium.org2011-09-162-3/+8
| | | | | | | | | R=sky@chromium.org,sadrul@chromium.org,ben@chromium.org TEST=build with GYP_DEFINES="toolkit_views=1 use_aura=1", notice that the target views_aura_desktop builds and runs. Review URL: http://codereview.chromium.org/7887039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101506 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for a crash and tweak tosky@chromium.org2011-09-162-5/+7
| | | | | | | | | | | | | | | | | | | | | menus. MenuButton::OnKeyPressed may run a nested message loop, which means by the time it returns 'this' may have been deleted (a couple of crashes seem to indicate this). In talking with Domnic the code after the call to Activate isn't necessary, so I'm removing it. I'm also changing the cancel call in MenuRunner to supply EXIT_DESTROYED, which means the menu code won't attempt to touch the button that was supplied to run. This is necessary as if MenuRunner is deleted the chances are the button supplied to it has also been deleted. BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/7890073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101500 0039d316-1c4b-4281-b951-d872f2087c98
* views: Fix unnamed namespace comments.tfarina@chromium.org2011-09-164-5/+5
| | | | | | | | R=sky@chromium.org Review URL: http://codereview.chromium.org/7921001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101498 0039d316-1c4b-4281-b951-d872f2087c98
* Adds some features to the shell:ben@chromium.org2011-09-164-1/+11
| | | | | | | | | | | | - desktop background - stub launcher - clicking the background opens test windows BUG=none TEST=none Review URL: http://codereview.chromium.org/7903018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101496 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land 98434 (http://codereview.chromium.org/7669028) which was reverted ↵oshima@google.com2011-09-1616-591/+1539
| | | | | | | | | | | | | | due to test failure. FocusTraversalTest::PaneTraversal was failing because scroll buttons/thums were getting focus, which should not. BUG=none TEST=none Review URL: http://codereview.chromium.org/7915002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101495 0039d316-1c4b-4281-b951-d872f2087c98
* * Call TooltipManager::Init onceyosin@chromium.org2011-09-161-7/+9
| | | | | | | | | | | | | | | | | | | | * Changes for cpplint.py * Set null to TOOLINFO.lpReserved according to MSDN ** http://msdn.microsoft.com/en-us/library/bb760256(v=VS.85).aspx Starting r88897, TooltipManager::Init is called twice and creates Tooltip control twice. This change removes one call of TooltipManager::Init in ctor. http://src.chromium.org/viewvc/chrome/trunk/src/views/widget/native_widget_win.cc?r1=88564&r2=88897&pathrev=88897 BUG=96226 TEST=Manual Review URL: http://codereview.chromium.org/7922003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101463 0039d316-1c4b-4281-b951-d872f2087c98
* External textures outlive layers.backer@chromium.org2011-09-155-14/+35
| | | | | | | | | | | | | | | When the View is hidden, we destroy the associated Layer, but the external texture should persist. Similarly, if a View is made visible, we create a Layer and the Layer should have that external texture. The solution is to push the external texture logic and state up into the LayerHelper, which persists. BUG=none TEST=none Review URL: http://codereview.chromium.org/7904024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101388 0039d316-1c4b-4281-b951-d872f2087c98
* Adds code for a new Aura shell.ben@chromium.org2011-09-152-5/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7890054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101374 0039d316-1c4b-4281-b951-d872f2087c98
* Clang fix.evan@chromium.org2011-09-151-2/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101333 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix.evan@chromium.org2011-09-151-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101331 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: remove wstrings from all tooltip-related codeevan@chromium.org2011-09-1527-79/+76
| | | | | | | | | This is a nearly-mechanical translation of wstring to string16. Removes a *ton* of string conversions. Review URL: http://codereview.chromium.org/7886023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101329 0039d316-1c4b-4281-b951-d872f2087c98
* views: Remove duplicated includes of widget.htfarina@chromium.org2011-09-153-7/+9
| | | | | | | | R=sky@chromium.org Review URL: http://codereview.chromium.org/7892046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101302 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed crash when a SinglesplitView gets embedded inside SingleSplitView.tfarina@chromium.org2011-09-155-1/+135
| | | | | | | | | | | | | | BUG=None TEST=Added test example double_split_view in views/examples. R=sky@chromium.org,oshima@chromium.org,tfarina@chromium.org Patch from Gajendra Singh <wxjg68@motorola.com> Review URL: http://codereview.chromium.org/7911001 Patch from Gajendra Singh <wxjg68@motorola.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101298 0039d316-1c4b-4281-b951-d872f2087c98
* Updated Wayland API in Chromiumdnicoara@chromium.org2011-09-152-9/+20
| | | | | | | | | | | | | | | Thanks to Kristian Høgsberg (krh@bitplanet.net) who submited the Wayland API changes. I've also updated the native_widget_wayland.* to match the current implementations. BUG= TEST= Review URL: http://codereview.chromium.org/7862021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101198 0039d316-1c4b-4281-b951-d872f2087c98
* views/examples: Simplify the process of adding a new example.tfarina@chromium.org2011-09-153-64/+61
| | | | | | | | R=sky@chromium.org Review URL: http://codereview.chromium.org/7890037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101196 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Checkdeps.ben@chromium.org2011-09-141-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101160 0039d316-1c4b-4281-b951-d872f2087c98
* Move Aura to UI subdir.ben@chromium.org2011-09-145-11/+14
| | | | | | | | | BUG=none TEST=none TBR=sky Review URL: http://codereview.chromium.org/7886042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101156 0039d316-1c4b-4281-b951-d872f2087c98
* fix build breakageoshima@google.com2011-09-141-1/+1
| | | | | | | | | | TBR=backer@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/7890043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101134 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Relanding 100792"oshima@google.com2011-09-1411-121/+73
| | | | | | | | | | | | This reverts commit 1de05c148460b26037b069501c19ee0c20aeb4ad. TBR=backer@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/7888049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101131 0039d316-1c4b-4281-b951-d872f2087c98
* Delete a bunch of redundant code for trimming tooltips.evan@chromium.org2011-09-145-55/+20
| | | | | | | | | | | | | It appears this code may predate base::SplitString. That function makes this code a lot simpler. Rather than trying to maintain Windows vs other newlines throughout, use newlines as the line separator everywhere and convert to CRLF only when calling Windows APIs. Review URL: http://codereview.chromium.org/7889016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101110 0039d316-1c4b-4281-b951-d872f2087c98
* Update the keyboard's bounds when the views desktop's bounds are changed.vollick@chromium.org2011-09-142-0/+31
| | | | | | | | | | | | This depends on (and builds upon) http://codereview.chromium.org/7864030/ BUG=None TEST=None Review URL: http://codereview.chromium.org/7889004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101109 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: Fix the maximization of a NativeWidgetGtk.sadrul@chromium.org2011-09-141-2/+2
| | | | | | | | | | | | | | | Using gtk_widget_set_size_request leaves the window in a very weird state: it changes the apparent size, but if the backing X window was larger before the request, then it doesn't get resized to the smaller size. So subsequent calls to get the bounds of the widget gets the pre-maximized larger size. So use the proper API (gtk_window_resize) to do the window resizing. BUG=none TEST=manually Review URL: http://codereview.chromium.org/7887019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101083 0039d316-1c4b-4281-b951-d872f2087c98
* views: Make use of ObserverList API to add/remove MenuListeners from NativeMenu.tfarina@chromium.org2011-09-144-32/+13
| | | | | | | | R=sky@chromium.org Review URL: http://codereview.chromium.org/7888032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101082 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for SetExternalTexture.backer@chromium.org2011-09-143-19/+4
| | | | | | | | | | | We don't want to SetCanvas (or prepare a canvas to be set), if the Layer is being updated externally. BUG=none TEST=TOUCH_UI build displays google.com Review URL: http://codereview.chromium.org/7889035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101080 0039d316-1c4b-4281-b951-d872f2087c98
* Revise caption button workaround and add crash debugging code.msw@chromium.org2011-09-142-23/+50
| | | | | | | | | | | | | | | | | | | | | | My caption workaround crrev.com/99498 caused some regressions. Update ScopedRedrawLock usage and functionality. Only adjust the visibility flag (not the aggregate window style). Only lock windows that are already visible, track the lock count. Force visibility on move/size WM_SYSCOMMAND for continuous feedback. Fixes the window disappearance on Win XP crbug.com/95582. May also fix the OnMouseRange crash crbug.com/95727. Add debugging code for OnMouseRange crash crbug.com/95727. Checks NativeWidgetWin destruction in DefWindowProc handling. Add VLOG to track nested ScopedRedrawLocks for crbug.com/93530. BUG=89820,95582,95727,93530 TEST=No problem on XP maximized title bar click. Review URL: http://codereview.chromium.org/7844016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101033 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-10-29 08:22:24 +0000