summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Fixes bug in textfield on views/gtk where we weren't properlysky@chromium.org2009-12-042-21/+23
| | | | | | | | | | | | | accounting for border size if not specified by style. Also changes button on views/gtk not to fix the pref height at 29. There is no reason for us to do this. BUG=none TEST=none Review URL: http://codereview.chromium.org/462036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33882 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/466002 for Thiago:sky@chromium.org2009-12-042-5/+5
| | | | | | | | | | | Switch a CSize variable (WTL) to use the gfx::Size type. BUG=2186 TEST=compiles Review URL: http://codereview.chromium.org/466039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33877 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the menu model to live outside views/ so it can be sharedpinkerton@chromium.org2009-12-0420-473/+67
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/465005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33827 0039d316-1c4b-4281-b951-d872f2087c98
* Downward drag after mouse-down is now causing bookmark bar folders to open, ↵zelidrag@google.com2009-12-042-2/+16
| | | | | | | | | | | | | | rather than drag. The bar folder can still be dragged in any other direction. Please note that this change is already reviews in http://codereview.chromium.org/463001, hence TBR field here. I needed to move to a different client to check it in. BUG=9016 TEST=Open bookmark bar. Select folder button and try to drag it down. Observe that now if dragged straight downward, the folder button will open its menu. TBR=sky Review URL: http://codereview.chromium.org/467017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33805 0039d316-1c4b-4281-b951-d872f2087c98
* Implement keyboard access between bookmarks and main toolbar.mhm@chromium.org2009-12-042-0/+15
| | | | | | | | | | | | | | | | Allow ALT+SHIFT+T and TAB to traverse between bookmarks bar and main toolbar, same thing goes for SHIFT+TAB. Once any toolbar is focused, the arrow keys are used to traverse its children views. Any toolbar that needs to be traversable needs to extend "AccessibleToolbarView", that class will deal with all the toolbar accessibility needs such as handling ESC, Left/Right arrows, Enter, Drop downs, and traversals with Tab/Shift+Tab. There is one abstract method that the views who are extending this would need to implement if needed which allows the toolbar to skip views that are being traversed: bool IsAccessibleViewTraversable(views::View* view) BUG=25625 TEST=Test to see if the main toolbar and bookmarks bar is traversable. Review URL: http://codereview.chromium.org/333010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33793 0039d316-1c4b-4281-b951-d872f2087c98
* widget_gtk: Alphabetize CallXXX() functions.tony@chromium.org2009-12-032-114/+125
| | | | | | | | | | | BUG=None TEST=None Patch written by Thiago Farina <thiago.farina@gmail.com>. Review URL: http://codereview.chromium.org/451001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33745 0039d316-1c4b-4281-b951-d872f2087c98
* Makes views not draw focus for native controls on Gtk. As Gtk renderssky@chromium.org2009-12-0314-12/+63
| | | | | | | | | | | the focus for us, this resulted in double the focus indicators. BUG=none TEST=none Review URL: http://codereview.chromium.org/468004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33739 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/449003/show for Thiago:sky@chromium.org2009-12-0117-36/+39
| | | | | | | | | | | | | | views: replace the deprecated macro (DISALLOW_EVIL_CONSTRUCTORS). Use DISALLOW_COPY_AND_ASSIGN instead, also fix some style issues pointed by lint. BUG=none TEST=none Review URL: http://codereview.chromium.org/449075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33500 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in views/gtk tooltips. Gtk wraps text in labels atsky@chromium.org2009-12-013-14/+40
| | | | | | | | | | | | | | (screen_size + 1) / 2. I'm setting the max width of tooltips to match this else gtk can calculate more vertical white space than it ends up using. Simiarly when resetting the text in a label gtk doesn't reset wrap position. I'm forcing that by invoking set_max_width_chars. BUG=none TEST=none Review URL: http://codereview.chromium.org/454023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33494 0039d316-1c4b-4281-b951-d872f2087c98
* Porting the table view to Linux toolkit views.jcampan@chromium.org2009-12-0110-33/+465
| | | | | | | | | | | | | | It is the initial implementation, it is still missing: - row focusing - resizable columns - autosize columns BUG=None TEST=Run the unit-tests, play with the TableView2 tab in the view examples. Review URL: http://codereview.chromium.org/434066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33400 0039d316-1c4b-4281-b951-d872f2087c98
* Adds link to bookmark bar that when clicked imports bookmarks. I alsosky@chromium.org2009-11-306-15/+81
| | | | | | | | | | | | added support for baselines to GridLayout. BUG=4374 TEST=On a new profile make sure the bookmark bar has a link to import bookmarks, click the link and make sure you can import your bookmarks. Review URL: http://codereview.chromium.org/440029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33336 0039d316-1c4b-4281-b951-d872f2087c98
* Makes sure gtk menus fit on screen before showing them.sky@chromium.org2009-11-301-4/+12
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/434106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33328 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug that could lead to mouse motion events percolating up tosky@chromium.org2009-11-301-1/+1
| | | | | | | | | | | | next window when they shouldn't. This manifested itself as buttons highlighting when the mose wasn't over them. BUG=none TEST=none Review URL: http://codereview.chromium.org/454005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33321 0039d316-1c4b-4281-b951-d872f2087c98
* Make SystemMonitor not a Singleton and move it out of basephajdan.jr@chromium.org2009-11-262-2/+2
| | | | | | | | | | | | | SystemMonitor makes an assumption that through its lifetime a MessageLoop exists and stays the same. It is difficult and error-prone to satisfy that when it is a Singleton. It has caused problems in the past. Additionally, extract HighResoltionTimerManager out of time_win.cc, eliminating yet another Singleton. TEST=none BUG=none Review URL: http://codereview.chromium.org/431008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33214 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in tooltips. I was freeing a PangoFontDescription that Isky@chromium.org2009-11-252-11/+6
| | | | | | | | | | | | shouldn't have. I also added code to set the name of the widgets created by WidgetGtk. BUG=none TEST=none Review URL: http://codereview.chromium.org/443006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33117 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid double freeing image list in TableView.mal@chromium.org2009-11-252-13/+0
| | | | | | | | | | | Committing http://codereview.chromium.org/387056 on behalf of Dan. BUG=27729 TEST=run NullModelTableViewTest.NullModel in app verifier or wine TBR= dank,jhawkins Review URL: http://codereview.chromium.org/437054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33055 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two bugs in tree view:sky@chromium.org2009-11-251-4/+9
| | | | | | | | | | | | | | | | | . Invoking SetRootShown before the tree was created resulted in updating internal structures with wrong info. This caused problems if you later tried to delete. I've added a DCHECK to make sure we don't hit this again. . Adding a node to the root when the root wasn't shown silently failed. BUG=none TEST=make sure bookmark manager doesn't have any problems when adding/removing nodes. Review URL: http://codereview.chromium.org/434053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33023 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash on double clicking in the upper right corner of thesky@chromium.org2009-11-241-4/+6
| | | | | | | | | | | | window. For some reason gtk_window_begin_move_drag crashes when invoked for double/triple clicks. BUG=none TEST=none Review URL: http://codereview.chromium.org/434045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32976 0039d316-1c4b-4281-b951-d872f2087c98
* Group Menu2Model::TYPE_RADIO menu items correctly. Currently an ↵yusukes@google.com2009-11-242-9/+26
| | | | | | | | | | | | | | implementation of the Menu2Model::GetGroupIdAt() interface seems to be ignored. This change is necessary in order to implement the menu for Chrome OS Text Input: https://sites.google.com/a/google.com/chromium-developer-central/chromiumos-1/chromiumos-design-docs/text-input/input.png?attredirects=0 BUG=none TEST=none Review URL: http://codereview.chromium.org/414031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32903 0039d316-1c4b-4281-b951-d872f2087c98
* views: remove some unnecessary static_cast<int>.maruel@chromium.org2009-11-232-6/+5
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/429004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32837 0039d316-1c4b-4281-b951-d872f2087c98
* Use AutoReset (formerly ScopedBool) where possible.pkasting@chromium.org2009-11-202-4/+4
| | | | | | | | | | This frequently saves a tiny bit of code, but even when it doesn't I think it's more future-proof (less error-prone). BUG=none TEST=none Review URL: http://codereview.chromium.org/399096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32708 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two issues from valgrind, and some cleanup:sky@chromium.org2009-11-204-10/+17
| | | | | | | | | | | | | | | . Makes it so observer installed by WidgetGtk is cleaned up and not leaked. . Removes unnecessary static_cast<int> in view. . Fixes some leaks in textfield and button. . Removes AutocompletePopupViewGTK's copy of PangoFontFromGfxFont. BUG=none TEST=none Review URL: http://codereview.chromium.org/420005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32686 0039d316-1c4b-4281-b951-d872f2087c98
* Making grd dependencies more correct for grds in app.bradnelson@google.com2009-11-201-1/+1
| | | | | | | | | BUG=17706 TEST=None Review URL: http://codereview.chromium.org/414006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32602 0039d316-1c4b-4281-b951-d872f2087c98
* Add examples/widget_example.h to sources of view_examples.satorux@chromium.org2009-11-201-0/+1
| | | | | | | view_examples is just built fine without the line, but good to explicit. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32592 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a comment in views/border.h.satorux@chromium.org2009-11-201-1/+1
| | | | | | | | | | | | | | | | Change views->SetBorder(...) to views->set_border(...). The latter is the right function name in views/view.h: // The border object is owned by this object and may be NULL. void set_border(Border* b) { border_.reset(b); } const Border* border() const { return border_.get(); } BUG=none TEST=none Review URL: http://codereview.chromium.org/405032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32590 0039d316-1c4b-4281-b951-d872f2087c98
* Add views/examples/widget_example.h.satorux@google.com2009-11-192-1/+93
| | | | | | | | | | | | | The example demonstrates how to create a popup widget. BUG=none TEST=manually tested on a linux machine. Review URL: http://codereview.chromium.org/406001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32490 0039d316-1c4b-4281-b951-d872f2087c98
* Add an option to tree_view for whether to show lines from the root nodeian@chromium.org2009-11-182-3/+33
| | | | | | | | | | | | | to children nodes (sets TVS_LINESATROOT). Set this to false by default (maintaining existing behaviour by default), except for cookies_view where we set it to true. BUG=27657 TEST=open cookies dialog, make sure the origins have a + box next to them, and that expanding these also expands the cookies folder beneath them. Review URL: http://codereview.chromium.org/399030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32334 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for BookmarkManager Test Crash test.oshima@chromium.org2009-11-181-1/+5
| | | | | | | | | | | | | | | * Test was failing because the key events were sent even after the window has been destroyed. * Make sure browser window is closed before the end of test. Test fails in BookmarkBarView without this. I think this requires a fix on browser side. Filed a bug 28046. BUG=None Test=run browser_tests --gtest_filter=*Bookmark* Review URL: http://codereview.chromium.org/397034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32286 0039d316-1c4b-4281-b951-d872f2087c98
* Fix race conditions where an object's constructor uses PostTask on itself. ↵jam@chromium.org2009-11-172-4/+9
| | | | | | | | | This isn't safe since the posted task can execute before the constructor returns, leading to destruction of the object. BUG=27944 Review URL: http://codereview.chromium.org/399016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32213 0039d316-1c4b-4281-b951-d872f2087c98
* Remove new tabstrip code. Going to try doing this a different way.ben@chromium.org2009-11-173-264/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/400005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32197 0039d316-1c4b-4281-b951-d872f2087c98
* Make the char encoding indicator visible again on Windowsjshin@chromium.org2009-11-161-1/+2
| | | | | | | | | | | BUG=26438 TEST=Go to any web page and see if the character encoding is indicated in Page menu - Encoding. Patch by Satoshi.Matsuzaki with a slight modification.`(see the bug) Review URL: http://codereview.chromium.org/391066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32064 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 32012-32017mhm@chromium.org2009-11-152-15/+0
| | | | | | | | | | | git cl dcommit somehow committed all my local changes in cygwin TBR=evan BUG=none Review URL: http://codereview.chromium.org/396006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32019 0039d316-1c4b-4281-b951-d872f2087c98
* rebasemhm@chromium.org2009-11-152-0/+15
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32012 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing a bug where the textfield would paint outside of its boundsjcampan@chromium.org2009-11-131-1/+2
| | | | | | | | | | | when scrolled. BUG=26867 TEST=See steps in bug. Review URL: http://codereview.chromium.org/391055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31947 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the build of view_examples for Linux.yusukes@google.com2009-11-131-0/+6
| | | | | | | | | | | | | | TableView and TableView2 are not yet ported to Linux. #ifdef out the related code for Linux. BUG=none TEST=manually built and ran view_examples on Linux Original patch by satorux@chromium.org via: http://codereview.chromium.org/384117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31894 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in treeview. The code for removing a node was notsky@chromium.org2009-11-121-2/+3
| | | | | | | | | | | | | | correctly updating internal data structures, which could lead to a future crash. When recursively deleting items we need to get the next item before removing from the tree, otherwise the tree returns null. BUG=27290 TEST=make sure no problems in using bookmark manager, especially when adding/removing urls/folders. Review URL: http://codereview.chromium.org/384092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31850 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring of the TableView so it uses NativeViewControl.jcampan@chromium.org2009-11-1212-3/+2249
| | | | | | | | | | | | | At this point it does not support grouping or sorting. Mostly refactoring things from TableView to TableView2 and NativeTableWin. BUG=None TEST=Unit-tests and view examples for now. R=sky Review URL: http://codereview.chromium.org/387021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31741 0039d316-1c4b-4281-b951-d872f2087c98
* Landing georgey CL.jcampan@chromium.org2009-11-112-5/+46
| | | | | | | | See http://codereview.chromium.org/384012 Review URL: http://codereview.chromium.org/387028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31717 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for issue 27210, show bookmarks bar menu is out of sync with the ↵oshima@chromium.org2009-11-112-24/+38
| | | | | | | | | | | | | | | | | browser's status. * Update the states of menu before showing menu like Window's menu does. * Don't fire activate signal when the state is chagned via API. * Eliminated UpdateStateData and replace it with the NativeMenuGtk and the position stored in the gtk widget. * Fixed StateAreaView to check bookmark bar status. BUG=27210 TEST=Run linux builds (gtk/views/chromeos) check if the bookmark bar menu's status is in sync with the bookmark bar. Review URL: http://codereview.chromium.org/383012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31654 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 31646.pkasting@chromium.org2009-11-112-16/+13
| | | | | | Review URL: http://codereview.chromium.org/386006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31648 0039d316-1c4b-4281-b951-d872f2087c98
* Try to make widgets clean up after themselves a bit better:pkasting@chromium.org2009-11-112-13/+16
| | | | | | | | | | | * When they get "destroy" window manager messages, clean up internal state so nothing will call into them and in theory someone could re-Init() successfully * When they're deleted, ensure they're also "destroyed" from the window manager point of view BUG=27347 TEST=none Review URL: http://codereview.chromium.org/391010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31646 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in showing bookmark menus where the wrong menu wouldsky@chromium.org2009-11-111-1/+1
| | | | | | | | | | | appear when rtl. BUG=26376 TEST=see bug Review URL: http://codereview.chromium.org/384021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31624 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a couple of missing parts for extensios on linux/views.oshima@chromium.org2009-11-111-2/+3
| | | | | | | | | | | | | | | | * Creating RenderWidgetHostView for gtk * Fix assertion failure in BrowserBubble * Don't change the window size if the size is empty, which causes gtk assertion error. With this change, most of extension tests in browser passes except for toolstrip. Given that toolstrip is obsolete, may be we should just remove it from test. BUG=None TEST=Run browesr_tests. All tests for extension must pass except for ExtensionApiTest.Toolstrip Review URL: http://codereview.chromium.org/390006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31622 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in showing bookmark menu. The problem occurredsky@chromium.org2009-11-102-21/+21
| | | | | | | | | | | | | | when you clicked on one top level menu on the bookmark bar, moused over another menu and then we loaded favicons for the first menu. The code needs to figure out which menu has the icon instead of invoking set icon on menu_. BUG=27067 TEST=make sure bookmark menus work ok. Review URL: http://codereview.chromium.org/388007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31603 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up function ordering in WidgetGtk.ben@chromium.org2009-11-093-239/+235
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/379001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31471 0039d316-1c4b-4281-b951-d872f2087c98
* Fix toolkit_views buildben@chromium.org2009-11-082-6/+7
| | | | | | Review URL: http://codereview.chromium.org/375021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31397 0039d316-1c4b-4281-b951-d872f2087c98
* blind fix for toolkit_viewsben@chromium.org2009-11-073-4/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31395 0039d316-1c4b-4281-b951-d872f2087c98
* Move all the stuff relating to detached tab dragging out of BrowserFrameWin ↵ben@chromium.org2009-11-0710-69/+189
| | | | | | | | and onto the TabStrip2 object. It was mostly cross platform anyway.Adds APIs to Widget that:- allow a Widget to be obtained for a given gfx::NativeView- allow native properties to be set on a Widget.Adds an API to Window that lets the caller convert the window's appearance into a lightly transparent transient looking thing for dragging.BUG=noneTEST=none Review URL: http://codereview.chromium.org/149440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31394 0039d316-1c4b-4281-b951-d872f2087c98
* Fix style issues in View class.maruel@chromium.org2009-11-075-65/+37
| | | | | | | | | | | BUG=None TEST=None Patch contributed by thiago.farina@gmail.com Review URL: http://codereview.chromium.org/338011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31360 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when GetOleInterface returns NULL. The replaced class, ↵jhawkins@chromium.org2009-11-061-2/+4
| | | | | | | | | | CComQIPtr, handles attaching to a NULL pointer, but ScopedComPtr does not, so check for a non-NULL ole_interface before calling QueryFrom. BUG=22829 TEST=none Review URL: http://codereview.chromium.org/374012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31271 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 11:02:46 +0000