summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* Fix Chrome OS Clang build.msw@chromium.org2011-10-184-8/+28
| | | | | | Review URL: http://codereview.chromium.org/8344020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106152 0039d316-1c4b-4281-b951-d872f2087c98
* Views Bubble API adjustments and cleanupmsw@chromium.org2011-10-1818-524/+250
| | | | | | | | | | | | | Adjust BubbleDelegateView API, add CreateBubble static factory function. Bubble's arrow anchors with a screen point, can fade in and fade out. Supporting changes, test updates, misc related cleanup, -275 lines. BUG=97248,98322,98323 TEST=updated unit tests, views_examples bubbles work. Review URL: http://codereview.chromium.org/8227003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106090 0039d316-1c4b-4281-b951-d872f2087c98
* Aura: Use same views menu setup on win_aura and linux_aurajamescook@chromium.org2011-10-1811-99/+203
| | | | | | | | | | | Resolves some TODOs I added in menu_config_win.cc and menu_item_view_win.cc, and harmonizes our menu rendering code between windows and linux Aura. BUG=100586 TEST=manual Review URL: http://codereview.chromium.org/8302017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106068 0039d316-1c4b-4281-b951-d872f2087c98
* WriteInto handles length_with_null values of 1 better.cbentzel@chromium.org2011-10-181-2/+4
| | | | | | | | | | | | | | | | In debug builds on VS2010, the old code triggered a debug assertion in xstring, since [0] was being accessed and the size of the array was 0. A |length_with_null| of 1 is considered a valid use of this function, so an alternate implementation is used which returns the data() pointer. BUG=None TEST=net_unittests --gtest_filter=*Digest* on debug on VS2010 works. Review URL: http://codereview.chromium.org/8143001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106062 0039d316-1c4b-4281-b951-d872f2087c98
* Fix native view host accessibility. We should have been passing a pointer to ↵dmazzoni@chromium.org2011-10-181-3/+4
| | | | | | | | | | | a pointer to the function to get the result; also switch to using AccessibleObjectFromWindow instead, which is cleaner. BUG=none TEST=none Review URL: http://codereview.chromium.org/8296010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106030 0039d316-1c4b-4281-b951-d872f2087c98
* views: Change TextButtonBase API to string16.tfarina@chromium.org2011-10-186-25/+26
| | | | | | | | | | | BUG=68267 R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105998 Review URL: http://codereview.chromium.org/8262003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106018 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 105998 - views: Change TextButtonBase API to string16.sail@chromium.org2011-10-186-26/+25
| | | | | | | | | | | | BUG=68267 R=sky@chromium.org Review URL: http://codereview.chromium.org/8262003 TBR=tfarina@chromium.org Review URL: http://codereview.chromium.org/8329010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106001 0039d316-1c4b-4281-b951-d872f2087c98
* views: Change TextButtonBase API to string16.tfarina@chromium.org2011-10-186-25/+26
| | | | | | | | | BUG=68267 R=sky@chromium.org Review URL: http://codereview.chromium.org/8262003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105998 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some unused temps.pkasting@chromium.org2011-10-172-2/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8297006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105889 0039d316-1c4b-4281-b951-d872f2087c98
* Minimum size for aura windowoshima@google.com2011-10-173-6/+8
| | | | | | | | | | | | | Update restore bounds when SetBounds is called in Fullscreen/Maximized mode. EventGenerator to generate fake events for various mouse operatings. BUG=none TEST=added test case for SetBounds in fullscreen/maximized mode. Added ToplevelWindow test that tests various toplevel operations. Review URL: http://codereview.chromium.org/8273040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105882 0039d316-1c4b-4281-b951-d872f2087c98
* Aura: Combine cursor support for Linux and Windowsjamescook@chromium.org2011-10-176-19/+31
| | | | | | | | | | | | | | + Change gfx::NativeCursor to an int id on Aura. + Fix several cursor-related TODOs in GetCursor() methods. + Move X11 cursor cache into x11_util + Set platform-specific cursors in aura::DesktopHostWin and DesktopHostLinux BUG=99871 TEST=manual Review URL: http://codereview.chromium.org/8256001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105850 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Add support for touch events.sadrul@chromium.org2011-10-177-60/+34
| | | | | | | | | | | | | | Among the changes: . Add touch event handling in EventFilter. Be default, activates a window on TOUCH_START (like for MOUSE_PRESSED). . Move TouchEvent details functions into ui/. Moved the X11 implementations from views/ to ui/. NOTIMPLEMENTED on windows. . Disable RWHVAura et. al. for touchui for now (they are still compiled in, but not used). BUG=100269 TEST=none Review URL: http://codereview.chromium.org/8274025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105816 0039d316-1c4b-4281-b951-d872f2087c98
* Wires keeping the launcher up to date with the browser. I also needed ↵sky@chromium.org2011-10-152-12/+27
| | | | | | | | | | | | GetBrowserViewForNativeWindow, so I had to wire up ViewProps for it to work correctly. BUG=97262 TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/8289022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105677 0039d316-1c4b-4281-b951-d872f2087c98
* views/examples: Fix the format string of size_t var in RadioButton example.tfarina@chromium.org2011-10-141-1/+2
| | | | | | | | | | | Cast from size_t to int. TEST=compile views_examples target, it should work without errors. R=sky@chromium.org Review URL: http://codereview.chromium.org/8252009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105584 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the KeyEvent unit test failure due to the aura implementation of ↵jennyz@chromium.org2011-10-141-1/+4
| | | | | | | | | | | | GetUnmodifiedCharacter(). BUG=99129 TEST=NONE Review URL: http://codereview.chromium.org/8286006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105549 0039d316-1c4b-4281-b951-d872f2087c98
* Support dynamic switching between integrated and discrete GPUs on Mac OS X.kbr@chromium.org2011-10-131-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change Chrome to allocate most OpenGL contexts with the kCGLPFAAllowOfflineRenderers flag, and specify NSSupportsAutomaticGraphicsSwitching in the Info.plist for the main executable and helper apps. This keeps Chrome on the integrated GPU except when using WebGL, accelerated 2D Canvas, Pepper 3D, and Core Animation-based plugins (except Flash). Chrome shares resources between OpenGL contexts in order to display WebGL and other content in the compositor, and resource sharing doesn't work between contexts allocated on different GPUs. Therefore, when the first context for a given renderer requests the discrete GPU, the channel is dropped and all contexts are reallocated on the discrete GPU. Similarly, when the last context requesting the discrete GPU for a given renderer is shut down, all contexts are dropped and reallocated on the integrated GPU. Currently dynamic GPU switching is only supported on the latest Mac OS X 10.7 update and MacBook Pros with dual AMD / Intel GPUs, though this will improve in future OS updates. Tested with WebGL, CSS 3D, Flash and Unity3D content and observed desired GPU switching behavior. Also added a layout test to WebKit under https://bugs.webkit.org/show_bug.cgi?id=69776 which when run in Chrome catches an assertion failure related to the destruction of contexts. The intent is to add it as a UI layout test on the GPU bots. BUG=88788 TEST=none Review URL: http://codereview.chromium.org/8233027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105399 0039d316-1c4b-4281-b951-d872f2087c98
* Enable VSync on TOUCH_UIbacker@chromium.org2011-10-131-1/+2
| | | | | | | | | | | This eliminates tearing on scrolling and animations. Unfortunately, due to a driver bug, we can only vsync if the window is not full screen. BUG=100000 TEST=flick scroll on a page with images; there should be no tearing Review URL: http://codereview.chromium.org/8272004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105393 0039d316-1c4b-4281-b951-d872f2087c98
* Get more of RenderWidgetHostViewAura running.ben@chromium.org2011-10-131-1/+0
| | | | | | | | | | This displays content now (software-only) on Windows, and supports Mouse Events. keyboard events are not yet working. http://crbug.com/99757 TEST=none Review URL: http://codereview.chromium.org/8234026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105359 0039d316-1c4b-4281-b951-d872f2087c98
* Flash white instead of black when the URL is changed in the omnibox for the ↵pkotwicz@chromium.org2011-10-131-0/+6
| | | | | | | | | | | | | | same tab This is separate from the previous fix, when a new tab is opened. When the URL of a tab is changed, the RWHV is deleted and another one is recreated. There is a period of time for which the root view contains no RWHV and is the top layer BUG=None TEST=None Review URL: http://codereview.chromium.org/8208009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105336 0039d316-1c4b-4281-b951-d872f2087c98
* views: Remove includes to deprecated base/task.h.tfarina@chromium.org2011-10-134-5/+1
| | | | | | | | | BUG=35223 R=sky@chromium.org Review URL: http://codereview.chromium.org/8241021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105303 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: Fix child toplevel widget positioning in touchui.sadrul@chromium.org2011-10-132-4/+26
| | | | | | | | | | | | The child widget gets added to the parent widget's view tree. So its origin needs to be correctly adjusted to be in the parent widget's coordinate system. BUG=99956 TEST=none Review URL: http://codereview.chromium.org/8231037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105299 0039d316-1c4b-4281-b951-d872f2087c98
* views: Change MenuButton API to string16.tfarina@chromium.org2011-10-123-11/+11
| | | | | | | | | BUG=68267 R=sky@chromium.org Review URL: http://codereview.chromium.org/8245013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105196 0039d316-1c4b-4281-b951-d872f2087c98
* Make views::Label and views::Link auto-color themselves to be readable over ↵pkasting@chromium.org2011-10-126-157/+141
| | | | | | | | | | | | | | their background color. Unfortunately since they can't automatically determine what that backgruond color is it has to be manually set. (I suppose I could try to add some crazy hierarchy-walking code looking for views::Background objects, but that seems like a bad move.) There is also a disable switch, which I use in a few places where I couldn't figure out what the background color actually is, or where updating it is really annoying. In theory, we might want to apply this to other controls like text buttons, but since those are usually rendered with explicit background images there's probably not a ton of win there. This also makes some other cleanup changes like converting a few wstrings to string16s, de-inlining some class member functions, etc. Some of these were mandated by the presubmitter :/ BUG=92 TEST=Things still look OK Review URL: http://codereview.chromium.org/8221027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105189 0039d316-1c4b-4281-b951-d872f2087c98
* Mouse watcher for auraoshima@chromium.org2011-10-121-10/+22
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8226025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105171 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a regression in the way WM_APPCOMMAND messages are handled.mma.public@gmail.com2011-10-121-3/+8
| | | | | | | | | | | | The double forward/back navigation bug was reintroduced by this patch: http://codereview.chromium.org/7190013 BUG=5393,19672,69254 TEST=Various cases reported on bug Review URL: http://codereview.chromium.org/7978017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105139 0039d316-1c4b-4281-b951-d872f2087c98
* 1. change the setters of gfx::SelectionModel to be private. Set one alone ↵xji@google.com2011-10-1214-101/+405
| | | | | | | | | | | | | | might make SelectionModel into un-stable state, which should not be allowed. 2. Removing SelectionModel(size_t, size_t) constructor. Introduce RenderText::SelectRange(const ui::Range&) to handle range. 3. revert removal of SelectRange/GetSelectedRange in r103188. BUG=90426 TEST=view_unittests. Review URL: http://codereview.chromium.org/8044004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105138 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang compile errors for USE_AURA=1dhollowa@chromium.org2011-10-121-4/+8
| | | | | | | | | | | Fixes various clang-reported errors when USE_AURA=1 BUG=none TEST=Compile on Mac/Clang. Trybots. Review URL: http://codereview.chromium.org/8229029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105104 0039d316-1c4b-4281-b951-d872f2087c98
* views: Change Checkbox API to string16.tfarina@chromium.org2011-10-1210-28/+38
| | | | | | | | | BUG=68267 R=sky@chromium.org Review URL: http://codereview.chromium.org/8245006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105088 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the views_unittests run without crashing on CHROME-OS TOUCH_UI.pkotwicz@chromium.org2011-10-121-0/+3
| | | | | | | | | | | | The issue is that we do not update the visibility of the scroll bar based on the theme. In TOUCH_UI, the scroll bar width is 0. This was causing a DCHECK in NativeThemeLinux::DrawBitmapInt to fail BUG=None TEST=None Review URL: http://codereview.chromium.org/8231013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105081 0039d316-1c4b-4281-b951-d872f2087c98
* views: Make sure layer visibility is updated properly.sadrul@chromium.org2011-10-124-4/+239
| | | | | | | | | | | If a View without a layer is hidden, and one of its descendant views has a layer, then the layer also needs to be hidden. This also needs to be reversed when such a View is redisplayed. BUG=none TEST=ViewLayerTreesInSync, VisibilityChildLayers Review URL: http://codereview.chromium.org/8216027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105080 0039d316-1c4b-4281-b951-d872f2087c98
* On desktoppkotwicz@chromium.org2011-10-121-0/+8
| | | | | | | | | | | | | | | | | | 1) Set focus on omnibox 2) Open wrench menu 3) Click on omnibox Keyboard does not show up The fix for this seems to be the second half of the code in the IsActivated method in native_widget_host_view_views BUG=None TEST=None Review URL: http://codereview.chromium.org/8200008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105077 0039d316-1c4b-4281-b951-d872f2087c98
* views: Change RadioButton API to string16.tfarina@chromium.org2011-10-125-15/+15
| | | | | | | | | BUG=68267 R=sky@chromium.org Review URL: http://codereview.chromium.org/8229017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105067 0039d316-1c4b-4281-b951-d872f2087c98
* ScheduleDraw() in View::SchedulePaintBoundsChanged() when a child view is ↵danakj@chromium.org2011-10-121-0/+6
| | | | | | | | | | | | moved so that its parent can be redrawn by the compositor with the child in its new position. R=sadrul,sky BUG= TEST=Drag and move chromium window around when no on-screen animation is occuring (such as cursor blink). Review URL: http://codereview.chromium.org/8177010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105062 0039d316-1c4b-4281-b951-d872f2087c98
* Enable NativeConstrainedWindowAuraoshima@chromium.org2011-10-121-4/+10
| | | | | | | | | | | | | Implement NativeWidgetAura::CenterWindow. The content of the html dialog is current blank due to a bug somewhere else. I'll address it in separate CL. BUG=none TEST=none Review URL: http://codereview.chromium.org/8224020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105047 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Fix mouse wheel events.sadrul@chromium.org2011-10-122-1/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8234020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104987 0039d316-1c4b-4281-b951-d872f2087c98
* Add ampersand prefix options to views text example.asvitkine@chromium.org2011-10-122-0/+32
| | | | | | | | | BUG=none TEST=manual Review URL: http://codereview.chromium.org/8232009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104963 0039d316-1c4b-4281-b951-d872f2087c98
* Add Windows manifest for views_examples.asvitkine@chromium.org2011-10-112-0/+32
| | | | | | | | | | | | | | This allows views_examples to use themed controls and fixes a problem with combo box drop down menus not being shown. Manifest file copied from chrome/app/chrome.exe.manifest. BUG=none TEST=manual Review URL: http://codereview.chromium.org/8227017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104939 0039d316-1c4b-4281-b951-d872f2087c98
* views: Get rid of std::wstring from table_view_unittest.cctfarina@chromium.org2011-10-111-20/+20
| | | | | | | | | BUG=68267 R=sky@chromium.org Review URL: http://codereview.chromium.org/8232007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104918 0039d316-1c4b-4281-b951-d872f2087c98
* Add gfx::kNullCursor to refer to "no cursor"oshima@chromium.org2011-10-118-11/+12
| | | | | | | | | | | | | linux/aura build uses unsigned long as NativeCursor which requires cast to use NULL. Define constants instead. BUG=none TEST=none Review URL: http://codereview.chromium.org/8216016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104848 0039d316-1c4b-4281-b951-d872f2087c98
* views: Some more layer change, and add/update some tests for layers.sadrul@chromium.org2011-10-117-27/+82
| | | | | | | | | | | | | | | | Hide the RootView's layer when a Widget is hidden. Call OnNativeWidgetVisibilityChanged on NativeWidgetGtk's hide/show callbacks. The tests: . Make sure Layer bounds change with a View even if it's not visible. . Make sure Layer visibility is updated with a View's visibility. . Make sure Layers get unparented properly when a View is removed from the parent view. BUG=none TEST=views_unittests Review URL: http://codereview.chromium.org/8202026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104846 0039d316-1c4b-4281-b951-d872f2087c98
* views: Change MessageBoxView API to string16.tfarina@chromium.org2011-10-113-21/+23
| | | | | | | | | BUG=68267 R=sky@chromium.org Review URL: http://codereview.chromium.org/8221015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104843 0039d316-1c4b-4281-b951-d872f2087c98
* Aura - Add NativeThemeAura, extract NativeThemeGtk, add sample widget window.jamescook@chromium.org2011-10-103-2/+28
| | | | | | | | | | | | | | | + Add native_theme_aura and native_theme_gtk, fix button background colors + Fix native_theme_chromeos instance generation + Rename button-related image resources + Rename class NativeThemeLinux to NativeThemeBase + Add window showing sample widgets BUG=98305 TEST=manual Review URL: http://codereview.chromium.org/8199021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104803 0039d316-1c4b-4281-b951-d872f2087c98
* Move some code around...ben@chromium.org2011-10-102-6/+6
| | | | | | | | | | | | | test infrastructure -> aura/test aura_shell_main -> aura/examples BUG=none TEST=none TBR=sky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104755 Review URL: http://codereview.chromium.org/8223006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104777 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 104755 - Move some code around...test infrastructure -> ↵ben@chromium.org2011-10-102-4/+4
| | | | | | | | aura/testaura_shell_main -> aura/examplesBUG=noneTEST=noneTBR=skyReview URL: http://codereview.chromium.org/8223006TBR=ben@chromium.org Review URL: http://codereview.chromium.org/8222011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104757 0039d316-1c4b-4281-b951-d872f2087c98
* Move some code around...ben@chromium.org2011-10-102-4/+4
| | | | | | | | | | | | test infrastructure -> aura/test aura_shell_main -> aura/examples BUG=none TEST=none TBR=sky Review URL: http://codereview.chromium.org/8223006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104755 0039d316-1c4b-4281-b951-d872f2087c98
* views/examples: TableExample::GetText() should return string16.tfarina@chromium.org2011-10-102-9/+10
| | | | | | | | | BUG=68267 R=sky@chromium.org Review URL: http://codereview.chromium.org/8198026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104721 0039d316-1c4b-4281-b951-d872f2087c98
* Multi-Profiels: Support high contrast mode in profile menusail@chromium.org2011-10-103-5/+11
| | | | | | | | | BUG=92250 TEST= Review URL: http://codereview.chromium.org/8168007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104690 0039d316-1c4b-4281-b951-d872f2087c98
* Windows compile fix.backer@chromium.org2011-10-081-0/+1
| | | | | | | | | | | | Missed updated .h file TBR=backer@chromium.org BUG=none TEST=tree goes green Review URL: http://codereview.chromium.org/8202027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104655 0039d316-1c4b-4281-b951-d872f2087c98
* Reorder Layers with NativeWidgetViews.backer@chromium.org2011-10-0816-32/+78
| | | | | | | | | | | The presence of NativeWidgetViews complicates the process of keeping the Layer tree in sync with the View tree. Specifically, when walking up the View tree to find a View with a Layer, we may have to walk up through a NativeWidgetViews to a NativeWidgetView in a different View tree. Similarly, when walking down the tree to find Views with Layers, we may have to walk down through a NativeWidgetView to a NativeWidgetViews. BUG=none TEST=none Review URL: http://codereview.chromium.org/8201008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104654 0039d316-1c4b-4281-b951-d872f2087c98
* views: Change ViewsDelegate::NotifyMenuItemFocused() to string16.tfarina@chromium.org2011-10-086-44/+41
| | | | | | | | | BUG=68267 R=sky@chromium.org Review URL: http://codereview.chromium.org/8186006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104622 0039d316-1c4b-4281-b951-d872f2087c98