summaryrefslogtreecommitdiffstats
path: root/views
Commit message (Collapse)AuthorAgeFilesLines
* views: Change TabbedPane::AddTab() to string16.tfarina@chromium.org2011-09-2912-46/+51
| | | | | | | | | BUG=68267 R=sky@chromium.org Review URL: http://codereview.chromium.org/8068009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103218 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors TestCompositor out of views_unittests into a place it can besky@chromium.org2011-09-283-91/+25
| | | | | | | | | | | | | | used by both the layer tests and the views test. Also fixes a bug that was causing test to fail and fixes up defines. I've disabled a portion of the compositor unit tests on linux as they don't compile. BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/8072010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103208 0039d316-1c4b-4281-b951-d872f2087c98
* views: Add a TODO to remove aura include hack.tfarina@chromium.org2011-09-281-0/+1
| | | | | | | | TBR=sky@chromium.org Review URL: http://codereview.chromium.org/8038068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103202 0039d316-1c4b-4281-b951-d872f2087c98
* views: Fix aura build on Linux.tfarina@chromium.org2011-09-281-0/+4
| | | | | | | | | TBR=sky@chromium.org R=msw@chromium.org Review URL: http://codereview.chromium.org/8038066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103194 0039d316-1c4b-4281-b951-d872f2087c98
* Fix omnibox state for each tab.xji@google.com2011-09-2814-170/+164
| | | | | | | | | | ui::Range only saves cursor's logical positions. In order to restore cursor's visual position, need to save and restore gfx::SelectionModel. BUG=90426 TEST=start chromeos --use-pure-views, type in "abcABC" in omnibox, where "ABC" stands for Hebrew characters. Mouse click on right half of 'c' so that cursor is placed at "abc|CBA". Create a new tab. Click to restore the previous tab page, cursor should be displayed the same as before "abc|CBA", not "abcCBA|". Review URL: http://codereview.chromium.org/7973007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103188 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete HAVE_XINPUT2 checks.sadrul@chromium.org2011-09-281-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8071002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103157 0039d316-1c4b-4281-b951-d872f2087c98
* views: Convert ButtonDropDown to use the new callback system.tfarina@chromium.org2011-09-282-11/+14
| | | | | | | | R=sky@chromium.org,ajwong@chromium.org Review URL: http://codereview.chromium.org/8059038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103140 0039d316-1c4b-4281-b951-d872f2087c98
* views: Remove focus_grabber_factory_ from MessageBoxView.tfarina@chromium.org2011-09-282-7/+2
| | | | | | | | | | This appear to be left around after some refactoring, so I'm just removing it now. R=sky@chromium.org,akalin@chromium.org Review URL: http://codereview.chromium.org/8055034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103139 0039d316-1c4b-4281-b951-d872f2087c98
* Delete use of wstring for views_examples titles and simplify code.asvitkine@chromium.org2011-09-2841-121/+38
| | | | | | | | | BUG=none TEST=views_examples still works as before. Review URL: http://codereview.chromium.org/8071001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103136 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: Convert XI2 MT tracking id to slot id.sadrul@chromium.org2011-09-281-12/+33
| | | | | | | | | | | | | | | The slot id mapped from tracking id is used as the touch id, and the gesture recognizer expects touch points to always start from 0. Patch from: Ningxin Hu <ningxin.hu@intel.com> (http://codereview.chromium.org/7927001/) BUG=95150 TEST=manually (touch-drag to scroll webpage, tap to click link) Review URL: http://codereview.chromium.org/8070003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103122 0039d316-1c4b-4281-b951-d872f2087c98
* Update TouchEvent initialize for USE_XI2_MT according tosadrul@chromium.org2011-09-281-3/+1
| | | | | | | | | | | http://codereview.chromium.org/7942004/ refactoring. BUG= TEST=build with touchui=1 use_xi2_mt=1 Review URL: http://codereview.chromium.org/8060002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103116 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes painting issue with bookmarks barpkotwicz@chromium.org2011-09-281-1/+2
| | | | | | | | | | | | | When the bookmarks bar was showing, opening a dialog which paints on top of the bookmark bar in touch_ui and dismissing it would leave ghosts where the dialog used to be. The reason is that the root view has a layer. It would paint the entire view tree into the root view including content which is contained by child layers BUG=none TEST=none Review URL: http://codereview.chromium.org/8046019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103111 0039d316-1c4b-4281-b951-d872f2087c98
* Change std::wstring to string16 on WidgetDelegate::GetWindowTitleyosin@chromium.org2011-09-2810-28/+36
| | | | | | Review URL: http://codereview.chromium.org/8065001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103102 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 103095 - Change std::wstring to string16 on ↵yosin@chromium.org2011-09-2810-36/+28
| | | | | | | | | | | | | | | WidgetDelegate::GetWindowTitle. BUG=68267 TEST=No visible changes Review URL: http://codereview.chromium.org/7972009 TBR=yosin@chromium.org Review URL: http://codereview.chromium.org/8052030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103096 0039d316-1c4b-4281-b951-d872f2087c98
* Change std::wstring to string16 on WidgetDelegate::GetWindowTitle.yosin@chromium.org2011-09-2810-28/+36
| | | | | | | | | | BUG=68267 TEST=No visible changes Review URL: http://codereview.chromium.org/7972009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103095 0039d316-1c4b-4281-b951-d872f2087c98
* Use Widget's SetOpacity in BubbleView.msw@chromium.org2011-09-281-19/+1
| | | | | | | | | | | | This fades the views_examples bubble better on Windows, no visual difference on Linux. On Win: the area outside the bubble is completely transparent now (was not on Win trunk). BUG=98312 TEST=views_examples > Bubble > FadeBubble Review URL: http://codereview.chromium.org/8056010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103094 0039d316-1c4b-4281-b951-d872f2087c98
* views: Convert NativeMenuGtk to use the new callback system.tfarina@chromium.org2011-09-272-3/+5
| | | | | | | | R=sky@chromium.org Review URL: http://codereview.chromium.org/8050025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103046 0039d316-1c4b-4281-b951-d872f2087c98
* views/examples: Move SplittedView implementation to source file.tfarina@chromium.org2011-09-272-50/+57
| | | | | | | | R=sky@chromium.org Review URL: http://codereview.chromium.org/8059010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103029 0039d316-1c4b-4281-b951-d872f2087c98
* Extend views example instance lifetimes over the main message loop.msw@chromium.org2011-09-274-60/+34
| | | | | | | | | | | | | | | | | Example lifetimes encompassed the message loop before r101736. Restore that behavior with a vector owned by ExamplesMain. Currently, most/all buttons in views_examples crash on click. ExampleBase subclasses are commonly used as ButonListeners, etc. Also: slightly less code/lines, unblock bubbles work :) BUG=none TEST=none Review URL: http://codereview.chromium.org/8059005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103025 0039d316-1c4b-4281-b951-d872f2087c98
* Allow layers to be created without a compositor, creating this association ↵ben@chromium.org2011-09-271-1/+1
| | | | | | | | when they are associated with a root layer/added to a hierarchy parented to a root layer.This allows us to configure a layer associated with a view before the view is attached to a widget.BUG=noneTEST=unittests Review URL: http://codereview.chromium.org/8036026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102989 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix uninitialized member variables.kmadhusu@chromium.org2011-09-272-0/+4
| | | | | | | | | | | CID_COUNT=12 CID=100727, 100582, 100851, 100854, 100904, 101224, 101533, 101534, 101535, 101615, 101631, 101647 BUG=none TEST=none Review URL: http://codereview.chromium.org/7983053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102953 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: Fix --touch-devices flag.sadrul@chromium.org2011-09-273-13/+11
| | | | | | | | | | | | This fixes the --touch-devices command-line flag, which can be used to create touch-events from a normal mouse device. BUG=none TEST=none Review URL: http://codereview.chromium.org/8048015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102936 0039d316-1c4b-4281-b951-d872f2087c98
* Gets views_unittests to work when aura is defined, and adds coveragesky@chromium.org2011-09-274-28/+135
| | | | | | | | | | | | | for recent painting bug. To get views_unittests to compile I had to convert BaseScrollBar to use MenuItemView (was still using native, which doesn't exist on windows). BUG=none TEST=none Review URL: http://codereview.chromium.org/8028027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102935 0039d316-1c4b-4281-b951-d872f2087c98
* Do not allocate a texture if hole covers entire layer.pkotwicz@chromium.org2011-09-273-7/+3
| | | | | | | | | BUG=None TEST= poster circle, at 35FPS on tegra2 hardware Review URL: http://codereview.chromium.org/7976004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102925 0039d316-1c4b-4281-b951-d872f2087c98
* views: Add protected virtual destructor to TabbedPaneListener.tfarina@chromium.org2011-09-271-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | The use of a protected virtual destructor is to prevent the destruction of a derived object via a base-class pointer. That's it, TabbedPaneListenere should only be deleted through derived class. Example: class FooListener { public: ... protected: virtual ~FooListener() {} }; class Foo : public FooListener { }; FooListener* listener = new Foo; delete listener; // It should prevent this situation! R=sky@chromium.org Review URL: http://codereview.chromium.org/8028030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102916 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for activation to aura.sky@chromium.org2011-09-272-1/+24
| | | | | | | | | | BUG=93938 TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/8041023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102840 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate/cleanup event cracking code; single out GdkEvents; saves ~850 lines.msw@chromium.org2011-09-2620-1948/+323
| | | | | | | | | | | | | | | | | | | | | Move ui::NativeEvent typdefs and common functions to ui/base/events.h. Remove NativeEvent2 typedef, single out GdkEvent* uses that should be removed. Implement platform specific ui/base/[platform]/events_[platform].cc. Revise views::NativeEvent definitions (to support Aura abstraction). Consolidate Event[Type/Flags/Location]FromNative(), GetMouseWheelOffset(), etc. Remove GetRepeatCount(), GetWindowsFlags(), IsExtendedKey(), etc. Add IsMouseEvent(), KeyboardCodeFromNative(), EF_EXTENDED flag, etc. Localize GetFlagsFromGdkEvent(), move some file locals to new helpers files. Move views/touchui/touch_factory.h|cc to ui/base/touch. Stop mixing Windows mouse events' MK_*BUTTON into their wParams. BUG=93945 TEST=No build breaks (many configs...), no mouse/key behavior changes. Review URL: http://codereview.chromium.org/7942004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102815 0039d316-1c4b-4281-b951-d872f2087c98
* Redesignate checkmark resource and add themed IDR_INPUT_GOOD imagerbyers@chromium.org2011-09-261-1/+1
| | | | | | | | | | | | | The resources IDR_INPUT_ALERT and IDR_INPUT_GOOD are used in tandem. This CL makes them both part of the theme resources. Furthermore, the IDR_INPUT_GOOD image is used by the checkmark throbber as a checkmark. It is simply renamed to be as such. This work is done in anticipation of using IDR_INPUT_ALRT and IDR_INPUT_GOOD in tandem as part of changing the edit search engine dialog to Web UI. BUG=None TEST=None Review URL: http://codereview.chromium.org/8044019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102771 0039d316-1c4b-4281-b951-d872f2087c98
* menu: Rename NativeMenuLinux to NativeMenuViews, and use it for aura.sadrul@chromium.org2011-09-264-100/+30
| | | | | | | | | | | This also fixes component build for aura_shell. BUG=none TEST=none Review URL: http://codereview.chromium.org/8036027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102761 0039d316-1c4b-4281-b951-d872f2087c98
* ui/gfx: Refactor favicon_size.htfarina@chromium.org2011-09-262-2/+4
| | | | | | | | | | | | | | - Put it into a gfx namespace. - Define the constant into the source file instead. - Rename the function from calc_favicon_target_size to CalculateFaviconTargetSize, so it matches with our style guide. - Move the implementation of the function to the source file. R=sky@chromium.org Review URL: http://codereview.chromium.org/8037011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102760 0039d316-1c4b-4281-b951-d872f2087c98
* views: Factor out ResizeAreaDelegate into its own header file.tfarina@chromium.org2011-09-264-17/+34
| | | | | | | | R=sky@chromium.org Review URL: http://codereview.chromium.org/8037010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102727 0039d316-1c4b-4281-b951-d872f2087c98
* NativeWidgetViews: Send unprocessed keyevents to the focus-manager.sadrul@chromium.org2011-09-261-1/+4
| | | | | | | | | | | | This fixes keyboard accelerators (e.g. ctrl-t etc.) to work correctly when the focus is in the omnibox in pure-views (e.g. touchui). BUG=none TEST=manually Review URL: http://codereview.chromium.org/8038012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102725 0039d316-1c4b-4281-b951-d872f2087c98
* Skip DefWindowProcWithRedrawLock on WM_SETCURSOR.msw@chromium.org2011-09-261-2/+6
| | | | | | | | | | | | | | | | | | My ScopedRedrawLock crrev.com/101642 (and related) seem to have exacerbated window rendering problems. One clear scenario is moving the cursor into the Chrome window as contents below change. OnSetCursor's ScopedRedrawLock allows obscured content to render and re-paint in front of Chrome. crrev.com/85628 was the first change to use ScopedRedrawLock for WM_SETCURSOR. I haven't observed any unwanted DefWindowProc painting yet, so this is promising. This change should be thoroughly tested before considering merge. BUG=97808 TEST=Chrome window painting artifacts when the cursor changes. Review URL: http://codereview.chromium.org/8045002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102708 0039d316-1c4b-4281-b951-d872f2087c98
* * Use DestoryIcon instead of DeleteObjectyosin@chromium.org2011-09-262-14/+20
| | | | | | | | | | | | * Changes for cpplint.py BUG=97559 TEST=Manual on Win7 Review URL: http://codereview.chromium.org/7977045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102689 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: support XInput2 multitouchsadrul@chromium.org2011-09-254-17/+118
| | | | | | | | | | | | | | Use XI2 multitouch events instead of mouse events as touch event input for touchui build. Note: XI MT will be supported in X server 1.12 and XI2.2. Please use build switch "use_xi2_mt=<minor version number>" to specify the minimum XI2 minor version. It is useful to test on experimental XI2.1 with MT support (e.g. build with use_xi2_mt=1). BUG=95150 TEST=(1) build with touchui=1 use_xi2_mt=1 (2) test on ubuntu 11.04 (X server 1.10 and XI2.1 with experimental MT support). (3) manually test if touch works on browser UI and JS touch events. Review URL: http://codereview.chromium.org/7792094 Patch from Ningxin Hu <ningxin.hu@intel.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102668 0039d316-1c4b-4281-b951-d872f2087c98
* views/examples: Cleanup ExampleBase.tfarina@chromium.org2011-09-242-22/+14
| | | | | | | | R=sadrul@chromium.org Review URL: http://codereview.chromium.org/8020008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102623 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "views: Factor out MenuListener into its own header file."tfarina@chromium.org2011-09-2312-52/+89
| | | | | | | | | | This should fix linux_touch build including the missing header file for MenuModel. TBR=sky@chromium.org Review URL: http://codereview.chromium.org/8008023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102538 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 102512 - views: Factor out MenuListener into its own header file.thakis@chromium.org2011-09-2312-88/+52
| | | | | | | | | | | R=sky@chromium.org Review URL: http://codereview.chromium.org/7969011 TBR=tfarina@chromium.org Review URL: http://codereview.chromium.org/8018007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102513 0039d316-1c4b-4281-b951-d872f2087c98
* views: Factor out MenuListener into its own header file.tfarina@chromium.org2011-09-2312-52/+88
| | | | | | | | R=sky@chromium.org Review URL: http://codereview.chromium.org/7969011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102512 0039d316-1c4b-4281-b951-d872f2087c98
* views: Convert some functions of ScrollBar class to unix_hacker style.tfarina@chromium.org2011-09-238-50/+36
| | | | | | | | R=sky@chromium.org Review URL: http://codereview.chromium.org/7980056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102498 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for Left mouse drag which was not functional after right drag in ↵wxjg68@motorola.com2011-09-231-5/+0
| | | | | | | | | | | | | | | | | | DoubleSplitViewExample. SplittedView::GetPreferredSize() was returning it's own size,instead of preferred size. Hence new_size was always = divder_offset_ in SingleSplitView::OnMosueDrag(), leading to no Layout() call. Avoid overriding SplittedView ::GetPreferredSize() to use default implementation. BUG=none TEST=Drag second splitter from left to right and then drag same splitter to right Review URL: http://codereview.chromium.org/7998001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102479 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for black-hole on views desktop with compositor.oshima@google.com2011-09-223-33/+56
| | | | | | | | | | | | | | | Child widget should not be parented to desktop. This was causing tab contents for prerendering be parented to desktop. Fix for DCHECK failure in NativeWidgetViews::OnKeyEvent Child widget should not be activated. Reset non_client_view_ when new contentview is set. BUG=none TEST=updated widget_unittests Review URL: http://codereview.chromium.org/7979035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102389 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crashes related to the extension uninstall dialog.jstritar@chromium.org2011-09-221-5/+4
| | | | | | | | | | | | | | | | | | | The uninstall prompt is owned by the settings page (the dialog's delegate), which gets destroyed when the user navigates to a new page. We need to make sure we invalidate pointers to the settings page when this occurs. This adds an ExtensionUninstallDialog with platform specific implementations. GTK: The settings page owns the ExtensionUninstallDialogGtk, which closes the GTK prompt when being destroyed. VIEWS: The views framework is a bit more convoluted because views owns the prompt's views::View. We have two classes: ExtensionUninstallDialogDelegateView owned by views, and ExtensionUninstallDialogViews owned by the settings page. If the user accepts or denies the prompt, we proxy the events through ExtensionUninstallDialogViews so we can invalidate pointers back to the views widget. If the settings page is destroyed, the ExtensionUninstallDialogViews closes the views widget after invalidating pointers back to the settings page. COCOA: You can't navigate away from the page when the prompt is open, so the dialog can't outlive its delegate. BUG=75011 TEST=see bug. Review URL: http://codereview.chromium.org/7920023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102351 0039d316-1c4b-4281-b951-d872f2087c98
* These are the changes necessary for views to be able to build w/ use_aura ↵davemoore@chromium.org2011-09-2214-32/+45
| | | | | | | | | | | implying no gtk. BUG=97131 TEST=views_unittests Review URL: http://codereview.chromium.org/7996008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102335 0039d316-1c4b-4281-b951-d872f2087c98
* NativeWidgetViews: Implement Maximize.sadrul@chromium.org2011-09-222-11/+23
| | | | | | | | | BUG=none TEST=manually Review URL: http://codereview.chromium.org/7925006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102330 0039d316-1c4b-4281-b951-d872f2087c98
* views: Get rid of TableView2::CreateWrapper().tfarina@chromium.org2011-09-222-15/+6
| | | | | | | | | | This is called only once, better to inline it in the call site, less code. R=sky@chromium.org Review URL: http://codereview.chromium.org/7983050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102300 0039d316-1c4b-4281-b951-d872f2087c98
* MenuConfig::Create passes HFONT to Font ctor but this HFONT isn't deleted. ↵yosin@chromium.org2011-09-221-4/+6
| | | | | | | | | | | | PlatformFontWin keeps copied HFONT by InitWIthCopyOfHFONT rather than keeping passed HFONT. BUG=96872 TEST=Manual on Win7 Review URL: http://codereview.chromium.org/7978021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102241 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call OnNativeWidgetVisibilityChange in NativeWidgetGtkoshima@chromium.org2011-09-221-2/+11
| | | | | | | | | BUG=chromium-os:20545 TEST=added a test case in FindInPageControllerTest.AcceleratorRestoring. See bug for repro step. Review URL: http://codereview.chromium.org/7978015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102233 0039d316-1c4b-4281-b951-d872f2087c98
* Fix infinite loop in GetInputMethod.oshima@google.com2011-09-221-1/+6
| | | | | | | | | | | RWHVV shouldn't update ime if there is no inputmethod associated with the view. BUG=none TEST=none Review URL: http://codereview.chromium.org/7976028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102225 0039d316-1c4b-4281-b951-d872f2087c98
* This is a reapply of xji@google.com2011-09-213-12/+687
| | | | | | | | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=102006 fix know issues in RenderText 1. add tests. 2. change SelectWord() to use BreakIterator, so it works for Chinese and Complex script. 3. DELETE/ReplaceChar delete/replace a whole grapheme. ReplaceTextInternal should only replace one grapheme when there is no selection. 4. pointing to position outside of text returns HOME/END position. 5. based on Chrome Linux omnibox and gedit, given "abc| def", double click should select " " instead of "abc". Change test expectation. BUG=90426 TEST=compile with touchui=1 test omnibox. run views_unittests.NativeTextfieldViewsTest/TextfieldViewsModelTest Review URL: http://codereview.chromium.org/7841056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102160 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 07:25:00 +0000